decidim-forms 0.22.0 → 0.23.3

data/config/locales/vi-VN.yml

@@ -0,0 +1 @@
+vi:

data/config/locales/vi.yml

@@ -0,0 +1 @@
+vi:

data/config/locales/zh-CN.yml

@@ -0,0 +1,172 @@
+zh-CN:
+  activemodel:
+    attributes:
+      answer:
+        body: 答案
+        choices: 选择
+        selected_choices: 选定的选择
+      question:
+        max_choices: 选择的最大数量
+        question_type: 类型
+      questionnaire_question:
+        mandatory: Mandatory
+    errors:
+      models:
+        answer:
+          attributes:
+            choices:
+              missing: 不完成
+              too_many: 太多了
+        questionnaire:
+          request_invalid: 处理请求时出错。请再试一次
+  decidim:
+    forms:
+      admin:
+        models:
+          components:
+            description: 描述
+            tos: 服务条款
+        questionnaires:
+          actions:
+            back: 返回问题
+            show: 显示回复
+          answer_option:
+            answer_option: 答案选项
+            free_text: 免费文本
+            remove: 删除
+            statement: 声明
+          answers:
+            actions:
+              back: 回到回应
+              export: 导出
+              show: 显示答案
+            empty: 尚无答案
+            export:
+              answer:
+                title: '回复 #%{number}'
+            export_response:
+              title: survey_user_answers_%{token}
+            index:
+              title: "%{total} 个回复总数"
+            show:
+              title: '答案 #%{number}'
+          display_condition:
+            answer_option: 答案选项
+            condition_question: 问
+            condition_type: 条件
+            condition_types:
+              answered: 已回答
+              equal: 等于
+              match: 包含文本
+              not_answered: 未回答
+              not_equal: 不等于
+            condition_value: 包含文本
+            display_condition: 显示条件
+            mandatory: 无论其他条件的状况如何，总是需要满足这个条件
+            remove: 删除
+            save_warning: 在配置显示条件之前记住保存表单
+            select_answer_option: 选择答案选项
+            select_condition_question: 选择一个问题
+            select_condition_type: 选择一个条件类型
+          edit:
+            save: 保存
+            title: 编辑问题单
+          form:
+            add_question: 添加问题
+            add_separator: 添加分隔符
+            already_answered_warning: 某些用户已经回答了表单，因此您不能修改其问题。
+            collapse: 收起所有问题
+            expand: 展开所有问题
+            preview: 预览
+            title: 编辑表单
+            unpublished_warning: 表单未发布。您可以修改它的问题，但这样做将删除当前答案。
+          matrix_row:
+            matrix_row: 行
+            remove: 删除
+            statement: 声明
+          question:
+            add_answer_option: 添加答案选项
+            add_display_condition: 添加显示条件
+            add_display_condition_info: 保存表单以配置显示条件
+            add_matrix_row: 添加行
+            any: 任何
+            collapse: 收起
+            description: 描述
+            down: 向下
+            expand: 扩展
+            question: 问
+            remove: 删除
+            statement: 声明
+            up: 上移
+          separator:
+            down: 向下
+            remove: 删除
+            separator: 分隔符
+            up: 上移
+          update:
+            invalid: 保存表单时出错。
+            success: 表单保存成功。
+      errors:
+        answer:
+          body: 主体不能为空
+      files:
+        extension_whitelist: '接受的格式：'
+      images:
+        dimensions: "%{width} x %{height} px"
+        dimensions_info: '这张图片将是：'
+        processors:
+          resize_and_pad: 缩放并填充到
+          resize_to_fit: 调整到适合的
+      question_types:
+        long_answer: 长答案
+        matrix_multiple: 矩阵(多选项)
+        matrix_single: 矩阵(单选项)
+        multiple_option: 多选项
+        short_answer: 简短答案
+        single_option: 单个选项
+        sorting: 排序中
+      questionnaires:
+        answer:
+          invalid: 回答表单时出现问题。
+          max_choices_alert: 选择了太多选项
+          success: 表单回答成功。
+        question:
+          max_choices: '最大选择数: %{n}'
+        show:
+          answer_questionnaire:
+            anonymous_user_message: <a href="%{sign_in_link}">使用您的帐户</a> 或 <a href="%{sign_up_link}">注册</a> 以回答表单。
+            title: 回答表单
+          current_step: 步骤 %{step}
+          of_total_steps: '%{total_steps}'
+          questionnaire_answered:
+            body: 您已经回答过这个表单。
+            title: 已经回答
+          questionnaire_closed:
+            body: 表格已关闭，无法解答。
+            title: 表单已关闭
+          questionnaire_for_private_users:
+            body: 表单仅供私人用户使用
+            title: 表单已关闭
+          questionnaire_js_disabled:
+            body: 此表单的一些功能将被禁用。为了改善您的体验，请在您的浏览器中启用 JavaScript。
+            title: JavaScript 已禁用
+          questionnaire_not_published:
+            body: 此表单尚未发布。
+          tos_agreement: 通过参与您接受其服务条款
+      step_navigation:
+        show:
+          are_you_sure: 此操作不能撤消，您将无法编辑您的答案。您确定吗？
+          back: 后退
+          continue: 继续
+          submit: 提交
+      user_answers_serializer:
+        body: 答案
+        completion: 完成
+        created_at: 回答于
+        id: 答案 ID
+        ip_hash: IP哈希
+        question: 问
+        registered: 已注册
+        session_token: 用户标识符
+        unregistered: 未注册
+        user_status: 用户状态

data/config/locales/zh-TW.yml

@@ -0,0 +1 @@
+zh-TW:

data/db/migrate/20200130194123_create_decidim_forms_display_conditions.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+class CreateDecidimFormsDisplayConditions < ActiveRecord::Migration[5.1]
+  def up
+    create_table :decidim_forms_display_conditions do |t|
+      t.bigint :decidim_question_id, index: { name: "decidim_forms_display_condition_question" }, null: false
+      t.bigint :decidim_condition_question_id, index: { name: "decidim_forms_display_condition_condition_question" }, null: false
+      t.bigint :decidim_answer_option_id, index: { name: "decidim_forms_display_condition_answer_option" }
+      t.integer :condition_type, default: 0, null: false
+      t.jsonb :condition_value
+      t.boolean :mandatory, default: false
+
+      t.timestamps
+    end
+  end
+
+  def down
+    drop_table :decidim_forms_display_conditions
+  end
+end

data/db/migrate/20201110152921_add_salt_to_decidim_forms_questionnaires.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+class AddSaltToDecidimFormsQuestionnaires < ActiveRecord::Migration[5.2]
+  class Questionnaire < ApplicationRecord
+    self.table_name = :decidim_forms_questionnaires
+  end
+
+  def change
+    add_column :decidim_forms_questionnaires, :salt, :string
+
+    Questionnaire.find_each do |questionnaire|
+      questionnaire.salt = Decidim::Tokenizer.random_salt
+      questionnaire.save!
+    end
+  end
+end

data/lib/decidim/exporters/form_pdf.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require "wicked_pdf"
+
+module Decidim
+  module Exporters
+    # Inherits from abstract PDF exporter. This class is used to set
+    # the parameters used to create a PDF when exporting Survey Answers.
+    #
+    class FormPDF < PDF
+      # i18n-tasks-use t('decidim.admin.exports.formats.FormPDF')
+
+      def controller
+        @controller ||= FormPDFControllerHelper.new
+      end
+
+      def template
+        "decidim/forms/admin/questionnaires/answers/export/pdf.html.erb"
+      end
+
+      def layout
+        "decidim/forms/admin/questionnaires/questionnaire_answers.html.erb"
+      end
+
+      def locals
+        {
+          questionnaire: collection.first.first.questionnaire,
+          collection: collection.map { |answer| Decidim::Forms::Admin::QuestionnaireParticipantPresenter.new(participant: answer.first) }
+        }
+      end
+    end
+  end
+end

data/lib/decidim/exporters/form_pdf_controller_helper.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Exporters
+    # A dummy controller to render views while exporting questionnaires
+    class FormPDFControllerHelper < ActionController::Base
+      helper Decidim::TranslationsHelper
+      helper Decidim::Forms::Admin::QuestionnaireAnswersHelper
+    end
+  end
+end

data/lib/decidim/forms.rb

@@ -11,4 +11,9 @@ module Decidim
     autoload :UserAnswersSerializer, "decidim/forms/user_answers_serializer"
     autoload :DataPortabilityUserAnswersSerializer, "decidim/forms/data_portability_user_answers_serializer"
   end
+
+  module Exporters
+    autoload :FormPDF, "decidim/exporters/form_pdf"
+    autoload :FormPDFControllerHelper, "decidim/exporters/form_pdf_controller_helper"
+  end
 end

data/lib/decidim/forms/admin_engine.rb

@@ -10,7 +10,7 @@ module Decidim
       paths["lib/tasks"] = nil
 
       initializer "decidim_forms.admin_assets" do |app|
-        app.config.assets.precompile += %w(admin/decidim_forms_manifest.js)
+        app.config.assets.precompile += %w(admin/decidim_forms_manifest.js admin/decidim_forms_manifest.css)
       end
 
       def load_seed

data/lib/decidim/forms/test.rb

@@ -2,3 +2,9 @@
 
 require "decidim/forms/test/shared_examples/has_questionnaire"
 require "decidim/forms/test/shared_examples/manage_questionnaires"
+require "decidim/forms/test/shared_examples/manage_questionnaire_answers"
+
+if defined? Decidim::Templates
+  require "decidim/templates/test/shared_examples/uses_questionnaire_templates"
+  require "decidim/templates/test/factories"
+end

data/lib/decidim/forms/test/factories.rb

@@ -13,6 +13,7 @@ FactoryBot.define do
     end
     tos { generate_localized_title }
     questionnaire_for { build(:participatory_process) }
+    salt { SecureRandom.hex(32) }
 
     trait :with_questions do
       questions do
@@ -23,6 +24,12 @@ FactoryBot.define do
         qs
       end
     end
+
+    trait :empty do
+      title { {} }
+      description { {} }
+      tos { {} }
+    end
   end
 
   factory :questionnaire_question, class: "Decidim::Forms::Question" do
@@ -67,6 +74,12 @@ FactoryBot.define do
       end
     end
 
+    trait :conditioned do
+      display_conditions do
+        Array.new(3).collect { build(:display_condition) }
+      end
+    end
+
     trait :separator do
       question_type { :separator }
     end
@@ -77,6 +90,7 @@ FactoryBot.define do
     questionnaire
     question { create(:questionnaire_question, questionnaire: questionnaire) }
     user { create(:user, organization: questionnaire.questionnaire_for.organization) }
+    session_token { Digest::MD5.hexdigest(user.id.to_s) }
   end
 
   factory :answer_option, class: "Decidim::Forms::AnswerOption" do
@@ -96,4 +110,21 @@ FactoryBot.define do
     body { generate_localized_title }
     position { 0 }
   end
+
+  factory :display_condition, class: "Decidim::Forms::DisplayCondition" do
+    condition_question { create(:questionnaire_question) }
+    question { create(:questionnaire_question, position: 1) }
+    condition_type { :answered }
+    mandatory { true }
+
+    trait :equal do
+      condition_type { :equal }
+      answer_option { create(:answer_option, question: condition_question) }
+    end
+
+    trait :match do
+      condition_type { :match }
+      condition_value { generate_localized_title }
+    end
+  end
 end

data/lib/decidim/forms/test/shared_examples/has_questionnaire.rb

@@ -75,7 +75,7 @@ shared_examples_for "has questionnaire" do
         click_link "Back"
 
         expect(page).to have_content("STEP 1 OF 2")
-        expect(page).to have_field("questionnaire_answers_0", with: "My first answer")
+        expect(page).to have_field("questionnaire_responses_0", with: "My first answer")
       end
 
       it "finishes the submission when answering the last questionnaire" do
@@ -257,7 +257,7 @@ shared_examples_for "has questionnaire" do
     end
 
     context "when a question has a rich text description" do
-      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, position: 0, description: "<b>This question is important</b>") }
+      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, position: 0, description: { en: "<b>This question is important</b>" }) }
 
       it "properly interprets HTML descriptions" do
         visit questionnaire_public_path
@@ -308,16 +308,16 @@ shared_examples_for "has questionnaire" do
         it "renders them as radio buttons with attached text fields disabled by default" do
           expect(page).to have_selector(".radio-button-collection input[type=radio]", count: 3)
 
-          expect(page).to have_field("questionnaire_answers_0_choices_2_custom_body", disabled: true, count: 1)
+          expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", disabled: true, count: 1)
 
           choose answer_option_bodies[2]["en"]
 
-          expect(page).to have_field("questionnaire_answers_0_choices_2_custom_body", disabled: false, count: 1)
+          expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", disabled: false, count: 1)
         end
 
         it "saves the free text in a separate field if submission correct" do
           choose answer_option_bodies[2]["en"]
-          fill_in "questionnaire_answers_0_choices_2_custom_body", with: "Cacatua"
+          fill_in "questionnaire_responses_0_choices_2_custom_body", with: "Cacatua"
 
           check "questionnaire_tos_agreement"
           accept_confirm { click_button "Submit" }
@@ -335,7 +335,7 @@ shared_examples_for "has questionnaire" do
           check other_question.answer_options.third.body["en"]
 
           choose answer_option_bodies[2]["en"]
-          fill_in "questionnaire_answers_0_choices_2_custom_body", with: "Cacatua"
+          fill_in "questionnaire_responses_0_choices_2_custom_body", with: "Cacatua"
 
           check "questionnaire_tos_agreement"
           accept_confirm { click_button "Submit" }
@@ -344,7 +344,7 @@ shared_examples_for "has questionnaire" do
             expect(page).to have_content("There was a problem answering")
           end
 
-          expect(page).to have_field("questionnaire_answers_0_choices_2_custom_body", with: "Cacatua")
+          expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", with: "Cacatua")
         end
       end
 
@@ -401,7 +401,7 @@ shared_examples_for "has questionnaire" do
       it "renders the answer as a textarea" do
         visit questionnaire_public_path
 
-        expect(page).to have_selector("textarea#questionnaire_answers_0")
+        expect(page).to have_selector("textarea#questionnaire_responses_0")
       end
     end
 
@@ -411,7 +411,7 @@ shared_examples_for "has questionnaire" do
       it "renders the answer as a text field" do
         visit questionnaire_public_path
 
-        expect(page).to have_selector("input[type=text]#questionnaire_answers_0")
+        expect(page).to have_selector("input[type=text]#questionnaire_responses_0")
       end
     end
 
@@ -509,11 +509,11 @@ shared_examples_for "has questionnaire" do
           questionnaire: questionnaire,
           question_type: "sorting",
           options: [
-            { "body" => "idiotas" },
-            { "body" => "trates" },
-            { "body" => "No" },
-            { "body" => "por" },
-            { "body" => "nos" }
+            { "body" => { "en" => "chocolate" } },
+            { "body" => { "en" => "like" } },
+            { "body" => { "en" => "We" } },
+            { "body" => { "en" => "dark" } },
+            { "body" => { "en" => "all" } }
           ]
         )
       end
@@ -523,25 +523,25 @@ shared_examples_for "has questionnaire" do
 
         expect(page).to have_selector(".sortable-check-box-collection input[type=checkbox]", count: 5)
 
-        expect(page).to have_content("idiotas\ntrates\nNo\npor\nnos")
+        expect(page).to have_content("chocolate\nlike\nWe\ndark\nall")
 
-        check "No"
-        check "nos"
-        check "trates"
-        check "por"
-        check "idiotas"
+        check "We"
+        check "all"
+        check "like"
+        check "dark"
+        check "chocolate"
 
-        expect(page).to have_content("1. No\n2. nos\n3. trates\n4. por\n5. idiotas")
+        expect(page).to have_content("1. We\n2. all\n3. like\n4. dark\n5. chocolate")
       end
 
       it "properly saves valid sortings" do
         visit questionnaire_public_path
 
-        check "No"
-        check "nos"
-        check "trates"
-        check "por"
-        check "idiotas"
+        check "We"
+        check "all"
+        check "like"
+        check "dark"
+        check "chocolate"
 
         check "questionnaire_tos_agreement"
 
@@ -552,14 +552,46 @@ shared_examples_for "has questionnaire" do
         end
 
         expect(Decidim::Forms::Answer.first.choices.pluck(:position, :body)).to eq(
-          [[0, "No"], [1, "nos"], [2, "trates"], [3, "por"], [4, "idiotas"]]
+          [[0, "We"], [1, "all"], [2, "like"], [3, "dark"], [4, "chocolate"]]
         )
       end
 
       it "displays errors on incomplete sortings" do
         visit questionnaire_public_path
 
-        check "No"
+        check "We"
+
+        accept_confirm { click_button "Submit" }
+
+        within ".alert.flash" do
+          expect(page).to have_content("problem")
+        end
+
+        expect(page).to have_content("are not complete")
+      end
+
+      it "displays maintains sorting order if errors" do
+        visit questionnaire_public_path
+
+        check "We"
+        check "dark"
+        check "chocolate"
+
+        accept_confirm { click_button "Submit" }
+
+        within ".alert.flash" do
+          expect(page).to have_content("problem")
+        end
+
+        # Check the next round to ensure a re-submission conserves status
+        expect(page).to have_content("are not complete")
+        expect(page).to have_content("1. We\n2. dark\n3. chocolate\nlike\nall")
+
+        checkboxes = page.all("input[type=checkbox]")
+
+        checkboxes[0].uncheck
+        check "We"
+        check "all"
 
         accept_confirm { click_button "Submit" }
 
@@ -568,6 +600,7 @@ shared_examples_for "has questionnaire" do
         end
 
         expect(page).to have_content("are not complete")
+        expect(page).to have_content("1. dark\n2. chocolate\n3. We\n4. all\nlike")
       end
     end
 
@@ -757,6 +790,26 @@ shared_examples_for "has questionnaire" do
         end
       end
 
+      context "when the question is mandatory and the answer is not complete" do
+        let!(:mandatory) { true }
+
+        it "shows an error" do
+          visit questionnaire_public_path
+
+          checkboxes = page.all(".check-box-collection input[type=checkbox]")
+          check checkboxes[0][:id]
+
+          check "questionnaire_tos_agreement"
+          accept_confirm { click_button "Submit" }
+
+          within ".alert.flash" do
+            expect(page).to have_content("There was a problem answering")
+          end
+
+          expect(page).to have_content("Choices are not complete")
+        end
+      end
+
       context "when the submission is not correct" do
         let!(:max_choices) { 2 }
 
@@ -780,26 +833,554 @@ shared_examples_for "has questionnaire" do
           expect(checkboxes.map { |c| c[:checked] }).to eq(["true", "true", "true", nil, nil, "true"])
         end
       end
+    end
 
-      context "when the question is mandatory and the answer is not complete" do
-        let!(:mandatory) { true }
+    describe "display conditions" do
+      let(:answer_options) do
+        3.times.to_a.map do |x|
+          {
+            "body" => Decidim::Faker::Localized.sentence,
+            "free_text" => x == 2
+          }
+        end
+      end
+      let(:condition_question_options) { [] }
+      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, position: 2) }
+      let!(:conditioned_question_id) { "#questionnaire_responses_1" }
+      let!(:condition_question) do
+        create(:questionnaire_question,
+               questionnaire: questionnaire,
+               question_type: condition_question_type,
+               position: 1,
+               options: condition_question_options)
+      end
 
-        it "shows an error" do
+      context "when a question has a display condition" do
+        context "when condition is of type 'answered'" do
+          let!(:display_condition) do
+            create(:display_condition,
+                   condition_type: "answered",
+                   question: question,
+                   condition_question: condition_question)
+          end
+
+          before do
+            visit questionnaire_public_path
+          end
+
+          context "when the condition_question type is short answer" do
+            let!(:condition_question_type) { "short_answer" }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              fill_in "questionnaire_responses_0", with: "Cacatua"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: ""
+              change_focus
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is long answer" do
+            let!(:condition_question_type) { "long_answer" }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              fill_in "questionnaire_responses_0", with: "Cacatua"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: ""
+              change_focus
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is single option" do
+            let!(:condition_question_type) { "single_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              choose condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+
+              choose condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is multiple option" do
+            let!(:condition_question_type) { "multiple_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+
+              uncheck condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+            end
+          end
+        end
+
+        context "when a question has a display condition of type 'not_answered'" do
+          let!(:display_condition) do
+            create(:display_condition,
+                   condition_type: "not_answered",
+                   question: question,
+                   condition_question: condition_question)
+          end
+
+          before do
+            visit questionnaire_public_path
+          end
+
+          context "when the condition_question type is short answer" do
+            let!(:condition_question_type) { "short_answer" }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: "Cacatua"
+              change_focus
+
+              expect_question_to_be_visible(false)
+
+              fill_in "questionnaire_responses_0", with: ""
+              change_focus
+
+              expect_question_to_be_visible(true)
+            end
+          end
+
+          context "when the condition_question type is long answer" do
+            let!(:condition_question_type) { "long_answer" }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: "Cacatua"
+              change_focus
+
+              expect_question_to_be_visible(false)
+
+              fill_in "questionnaire_responses_0", with: ""
+              change_focus
+
+              expect_question_to_be_visible(true)
+            end
+          end
+
+          context "when the condition_question type is single option" do
+            let!(:condition_question_type) { "single_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(true)
+
+              choose condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is multiple option" do
+            let!(:condition_question_type) { "multiple_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(true)
+
+              check condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              uncheck condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+            end
+          end
+        end
+
+        context "when a question has a display condition of type 'equal'" do
+          let!(:display_condition) do
+            create(:display_condition,
+                   condition_type: "equal",
+                   question: question,
+                   condition_question: condition_question,
+                   answer_option: condition_question.answer_options.first)
+          end
+
+          before do
+            visit questionnaire_public_path
+          end
+
+          context "when the condition_question type is single option" do
+            let!(:condition_question_type) { "single_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              choose condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+
+              choose condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is multiple option" do
+            let!(:condition_question_type) { "multiple_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+
+              uncheck condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+            end
+          end
+        end
+
+        context "when a question has a display condition of type 'not_equal'" do
+          let!(:display_condition) do
+            create(:display_condition,
+                   condition_type: "not_equal",
+                   question: question,
+                   condition_question: condition_question,
+                   answer_option: condition_question.answer_options.first)
+          end
+
+          before do
+            visit questionnaire_public_path
+          end
+
+          context "when the condition_question type is single option" do
+            let!(:condition_question_type) { "single_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              choose condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(true)
+
+              choose condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is multiple option" do
+            let!(:condition_question_type) { "multiple_option" }
+            let!(:condition_question_options) { answer_options }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(true)
+
+              uncheck condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.second.body["en"]
+
+              expect_question_to_be_visible(true)
+            end
+          end
+        end
+
+        context "when a question has a display condition of type 'match'" do
+          let!(:condition_value) { { en: "something" } }
+          let!(:display_condition) do
+            create(:display_condition,
+                   condition_type: "match",
+                   question: question,
+                   condition_question: condition_question,
+                   condition_value: condition_value)
+          end
+
+          before do
+            visit questionnaire_public_path
+          end
+
+          context "when the condition_question type is short answer" do
+            let!(:condition_question_type) { "short_answer" }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              fill_in "questionnaire_responses_0", with: "Aren't we all expecting #{condition_value[:en]}?"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: "Now upcase #{condition_value[:en].upcase}!"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: "Cacatua"
+              change_focus
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is long answer" do
+            let!(:condition_question_type) { "long_answer" }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              fill_in "questionnaire_responses_0", with: "Aren't we all expecting #{condition_value[:en]}?"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: "Now upcase #{condition_value[:en].upcase}!"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              fill_in "questionnaire_responses_0", with: "Cacatua"
+              change_focus
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is single option" do
+            let!(:condition_question_type) { "single_option" }
+            let!(:condition_question_options) { answer_options }
+            let!(:condition_value) { { en: condition_question.answer_options.first.body["en"].split.second.upcase } }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              choose condition_question.answer_options.first.body["en"]
+
+              expect_question_to_be_visible(true)
+            end
+          end
+
+          context "when the condition_question type is single option with free text" do
+            let!(:condition_question_type) { "single_option" }
+            let!(:condition_question_options) { answer_options }
+            let!(:condition_value) { { en: "forty two" } }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              choose condition_question.answer_options.third.body["en"]
+              fill_in "questionnaire_responses_0_choices_2_custom_body", with: "The answer is #{condition_value[:en]}"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              choose condition_question.answer_options.first.body["en"]
+              expect_question_to_be_visible(false)
+
+              choose condition_question.answer_options.third.body["en"]
+              fill_in "questionnaire_responses_0_choices_2_custom_body", with: "oh no not 42 again"
+              change_focus
+
+              expect_question_to_be_visible(false)
+            end
+          end
+
+          context "when the condition_question type is multiple option" do
+            let!(:condition_question_type) { "multiple_option" }
+            let!(:condition_question_options) { answer_options }
+            let!(:condition_value) { { en: "forty two" } }
+
+            it "shows the question only if the condition is fulfilled" do
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.third.body["en"]
+              fill_in "questionnaire_responses_0_choices_2_custom_body", with: "The answer is #{condition_value[:en]}"
+              change_focus
+
+              expect_question_to_be_visible(true)
+
+              check condition_question.answer_options.first.body["en"]
+              expect_question_to_be_visible(true)
+
+              uncheck condition_question.answer_options.third.body["en"]
+              expect_question_to_be_visible(false)
+
+              check condition_question.answer_options.third.body["en"]
+              fill_in "questionnaire_responses_0_choices_2_custom_body", with: "oh no not 42 again"
+              change_focus
+
+              expect_question_to_be_visible(false)
+            end
+          end
+        end
+      end
+
+      context "when a question has multiple display conditions" do
+        before do
           visit questionnaire_public_path
+        end
 
-          checkboxes = page.all(".check-box-collection input[type=checkbox]")
-          check checkboxes[0][:id]
+        context "when all conditions are mandatory" do
+          let!(:condition_question_type) { "single_option" }
+          let!(:condition_question_options) { answer_options }
+          let!(:display_conditions) do
+            [
+              create(:display_condition,
+                     condition_type: "answered",
+                     question: question,
+                     condition_question: condition_question,
+                     mandatory: true),
+              create(:display_condition,
+                     condition_type: "not_equal",
+                     question: question,
+                     condition_question: condition_question,
+                     mandatory: true,
+                     answer_option: condition_question.answer_options.second)
+            ]
+          end
 
-          check "questionnaire_tos_agreement"
-          accept_confirm { click_button "Submit" }
+          it "is displayed only if all conditions are fulfilled" do
+            expect_question_to_be_visible(false)
 
-          within ".alert.flash" do
-            expect(page).to have_content("There was a problem answering")
+            choose condition_question.answer_options.second.body["en"]
+
+            expect_question_to_be_visible(false)
+
+            choose condition_question.answer_options.first.body["en"]
+
+            expect_question_to_be_visible(true)
           end
+        end
 
-          expect(page).to have_content("Choices are not complete")
+        context "when all conditions are non-mandatory" do
+          let!(:condition_question_type) { "multiple_option" }
+          let!(:condition_question_options) { answer_options }
+          let!(:display_conditions) do
+            [
+              create(:display_condition,
+                     condition_type: "equal",
+                     question: question,
+                     condition_question: condition_question,
+                     mandatory: false,
+                     answer_option: condition_question.answer_options.first),
+              create(:display_condition,
+                     condition_type: "not_equal",
+                     question: question,
+                     condition_question: condition_question,
+                     mandatory: false,
+                     answer_option: condition_question.answer_options.third)
+            ]
+          end
+
+          it "is displayed if any of the conditions is fulfilled" do
+            expect_question_to_be_visible(false)
+
+            check condition_question.answer_options.first.body["en"]
+
+            expect_question_to_be_visible(true)
+
+            uncheck condition_question.answer_options.first.body["en"]
+            check condition_question.answer_options.second.body["en"]
+
+            expect_question_to_be_visible(true)
+
+            check condition_question.answer_options.first.body["en"]
+
+            expect_question_to_be_visible(true)
+          end
+        end
+
+        context "when a mandatory question has conditions that have not been fulfilled" do
+          let!(:condition_question_type) { "short_answer" }
+          let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, position: 2, mandatory: true) }
+          let!(:display_conditions) do
+            [
+              create(:display_condition,
+                     condition_type: "match",
+                     question: question,
+                     condition_question: condition_question,
+                     condition_value: { en: "hey", es: "ey", ca: "ei" },
+                     mandatory: true)
+            ]
+          end
+
+          it "doesn't throw error" do
+            visit questionnaire_public_path
+
+            fill_in condition_question.body["en"], with: "My first answer"
+
+            check "questionnaire_tos_agreement"
+
+            accept_confirm { click_button "Submit" }
+
+            within ".success.flash" do
+              expect(page).to have_content("successfully")
+            end
+          end
         end
       end
     end
+
+    private
+
+    def expect_question_to_be_visible(visible)
+      expect(page).to have_css(conditioned_question_id, visible: visible)
+    end
+
+    def change_focus
+      check "questionnaire_tos_agreement"
+    end
   end
 end