decidim-forms 0.22.0 → 0.23.0

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_display_conditions.rb

@@ -0,0 +1,179 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "add display conditions" do
+  context "when adding display conditions to a question" do
+    let!(:answer_options) do
+      3.times.to_a.map do |x|
+        {
+          "body" => Decidim::Faker::Localized.sentence,
+          "free_text" => x == 2
+        }
+      end
+    end
+
+    context "when questionnaire has only one question" do
+      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, body: body, question_type: "short_answer") }
+
+      before do
+        visit_questionnaire_edit_path_and_expand_all
+      end
+
+      it "doesn't display an add display condition button" do
+        expect(page).to have_no_button("Add display condition")
+      end
+
+      context "when creating a new question" do
+        it "disables the add display condition button if the question hasn't been saved" do
+          within "form.edit_questionnaire" do
+            click_button "Add question"
+            expand_all_questions
+
+            expect(page).to have_button("Add display condition", disabled: true)
+          end
+        end
+      end
+    end
+
+    context "when questionnaire has more than one question" do
+      let!(:question_short_answer) do
+        create(:questionnaire_question,
+               questionnaire: questionnaire,
+               body: Decidim::Faker::Localized.sentence,
+               question_type: "short_answer")
+      end
+      let!(:question_long_answer) do
+        create(:questionnaire_question,
+               questionnaire: questionnaire,
+               body: Decidim::Faker::Localized.sentence,
+               question_type: "long_answer")
+      end
+      let!(:question_single_option) do
+        create(:questionnaire_question,
+               questionnaire: questionnaire,
+               body: Decidim::Faker::Localized.sentence,
+               question_type: "single_option",
+               options: answer_options)
+      end
+      let!(:question_multiple_option) do
+        create(:questionnaire_question,
+               questionnaire: questionnaire,
+               body: Decidim::Faker::Localized.sentence,
+               question_type: "multiple_option",
+               options: answer_options)
+      end
+
+      let(:questions) { [question_short_answer, question_long_answer, question_single_option, question_multiple_option] }
+
+      before do
+        visit_questionnaire_edit_path_and_expand_all
+      end
+
+      context "when clicking add display condition button" do
+        it "adds a new display condition form with all correct elements" do
+          within "form.edit_questionnaire" do
+            within_add_display_condition do
+              expect(page).to have_select("Question")
+              expect(page).to have_select("Condition")
+              expect(page).to have_selector("[id$=mandatory]")
+
+              select question_single_option.body["en"], from: "Question"
+              select "Answered", from: "Condition"
+
+              expect(page).to have_no_select("Answer option")
+              expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
+
+              select question_single_option.body["en"], from: "Question"
+              select "Equal", from: "Condition"
+
+              expect(page).to have_select("Answer option")
+              expect(page).to have_no_css("[id$=condition_value_en]", visible: :visible)
+            end
+          end
+        end
+
+        it "fills condition_question select with saved questions from questionnaire" do
+          within_add_display_condition do
+            options = questions.map { |question| question["body"]["en"] }
+            options << "Select a question"
+            expect(page).to have_select("Question", options: options)
+
+            within "select[id$=decidim_condition_question_id]" do
+              elements = page.all("option[data-type]")
+              expect(elements.map { |element| element[:"data-type"] }).to eq(questions.map(&:question_type))
+              expect(page.find("option[value='#{questions.last.id}']")).to be_disabled
+            end
+          end
+        end
+
+        context "when a text question is selected" do
+          it "fills condition_type select with correct options" do
+            within_add_display_condition do
+              select question_short_answer.body["en"], from: "Question"
+
+              options = ["Select a condition type", "Answered", "Not answered", "Includes text"]
+
+              option_elements = page.all("select[id$=condition_type] option")
+              option_elements = option_elements.to_a.reject { |option| option[:style].match? "display: none" }
+
+              expect(option_elements.map(&:text)).to eq(options)
+            end
+          end
+        end
+
+        context "when an options question is selected" do
+          it "fills condition_type select with correct options" do
+            within_add_display_condition do
+              select question_single_option.body["en"], from: "Question"
+
+              options = ["Select a condition type", "Answered", "Not answered", "Equal", "Not equal", "Includes text"]
+
+              option_elements = page.all("select[id$=condition_type] option")
+              option_elements = option_elements.to_a.reject { |option| option[:style].match? "display: none" }
+
+              expect(option_elements.map(&:text)).to eq(options)
+            end
+          end
+        end
+
+        it "fills answer_options select with correct options" do
+          within_add_display_condition do
+            select question_single_option.body["en"], from: "Question"
+            select "Equal", from: "Condition"
+
+            options = answer_options.map { |option| option["body"]["en"] }
+            options << "Select answer option"
+
+            expect(page).to have_select("Answer option", options: options, wait: 5)
+          end
+        end
+
+        it "loads an empty value field" do
+          within_add_display_condition do
+            select question_single_option.body["en"], from: "Question"
+            select "Includes text", from: "Condition"
+            expect(page).to have_nested_field("condition_value_en", with: "")
+          end
+        end
+
+        it "loads a mandatory field with false value" do
+          within_add_display_condition do
+            expect(page).to have_selector("[id$=mandatory]")
+            expect(page).to have_no_selector("[id$=mandatory][checked]")
+          end
+        end
+
+        it "can be removed" do
+          within_add_display_condition do
+            click_button "Remove"
+          end
+
+          click_button "Save"
+
+          expect(page).to have_admin_callout("successfully")
+        end
+      end
+    end
+  end
+end

data/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_questions.rb

@@ -0,0 +1,463 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "add questions" do
+  it "adds a few questions and separators to the questionnaire" do
+    questions_body = ["This is the first question", "This is the second question"]
+
+    within "form.edit_questionnaire" do
+      click_button "Add question"
+      click_button "Add separator"
+      click_button "Add question"
+
+      expect(page).to have_selector(".questionnaire-question", count: 3)
+
+      expand_all_questions
+
+      page.all(".questionnaire-question .collapsible").each_with_index do |question, idx|
+        within question do
+          fill_in find_nested_form_field_locator("body_en"), with: questions_body[idx]
+        end
+      end
+
+      click_button "Save"
+    end
+
+    expect(page).to have_admin_callout("successfully")
+
+    visit_questionnaire_edit_path_and_expand_all
+
+    expect(page).to have_selector("input[value='This is the first question']")
+    expect(page).to have_selector("input[value='This is the second question']")
+    expect(page).to have_content("Separator #2")
+  end
+
+  it "adds a question with a rich text description" do
+    within "form.edit_questionnaire" do
+      click_button "Add question"
+      expand_all_questions
+
+      within ".questionnaire-question" do
+        fill_in find_nested_form_field_locator("body_en"), with: "Body"
+
+        fill_in_editor find_nested_form_field_locator("description_en", visible: false), with: "<b>Superkalifragilistic description</b>"
+      end
+
+      click_button "Save"
+    end
+
+    expect(page).to have_admin_callout("successfully")
+
+    component.update!(
+      step_settings: {
+        component.participatory_space.active_step.id => {
+          allow_answers: true
+        }
+      }
+    )
+
+    visit questionnaire_public_path
+
+    expect(page).to have_selector("strong", text: "Superkalifragilistic description")
+  end
+
+  it "adds a question with answer options" do
+    question_body = ["This is the first question", "This is the second question"]
+    answer_options_body = [
+      [
+        "This is the Q1 first option",
+        "This is the Q1 second option",
+        "This is the Q1 third option"
+      ],
+      [
+        "This is the Q2 first option",
+        "This is the Q2 second option",
+        "This is the Q2 third option"
+      ]
+    ]
+
+    within "form.edit_questionnaire" do
+      click_button "Add question"
+      click_button "Add question"
+      expand_all_questions
+
+      page.all(".questionnaire-question").each_with_index do |question, idx|
+        within question do
+          fill_in find_nested_form_field_locator("body_en"), with: question_body[idx]
+        end
+      end
+
+      expect(page).to have_no_content "Add answer option"
+
+      page.all(".questionnaire-question").each do |question|
+        within question do
+          select "Single option", from: "Type"
+          click_button "Add answer option"
+        end
+      end
+
+      page.all(".questionnaire-question").each_with_index do |question, question_idx|
+        question.all(".questionnaire-question-answer-option").each_with_index do |question_answer_option, answer_option_idx|
+          within question_answer_option do
+            fill_in find_nested_form_field_locator("body_en"), with: answer_options_body[question_idx][answer_option_idx]
+          end
+        end
+      end
+
+      click_button "Save"
+    end
+
+    expect(page).to have_admin_callout("successfully")
+
+    visit_questionnaire_edit_path_and_expand_all
+
+    expect(page).to have_selector("input[value='This is the first question']")
+    expect(page).to have_selector("input[value='This is the Q1 first option']")
+    expect(page).to have_selector("input[value='This is the Q1 second option']")
+    expect(page).to have_selector("input[value='This is the Q1 third option']")
+    expect(page).to have_selector("input[value='This is the second question']")
+    expect(page).to have_selector("input[value='This is the Q2 first option']")
+    expect(page).to have_selector("input[value='This is the Q2 second option']")
+    expect(page).to have_selector("input[value='This is the Q2 third option']")
+  end
+
+  it "adds a sane number of options for each attribute type" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Long answer", from: "Type"
+    expect(page).to have_no_selector(".questionnaire-question-answer-option")
+    expect(page).to have_no_selector(".questionnaire-question-matrix-row")
+
+    select "Single option", from: "Type"
+    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_no_selector(".questionnaire-question-matrix-row")
+
+    select "Multiple option", from: "Type"
+    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_no_selector(".questionnaire-question-matrix-row")
+
+    select "Matrix (Multiple option)", from: "Type"
+    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
+
+    select "Short answer", from: "Type"
+    expect(page).to have_no_selector(".questionnaire-question-answer-option")
+    expect(page).to have_no_selector(".questionnaire-question-matrix-row")
+
+    select "Matrix (Single option)", from: "Type"
+    expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+    expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
+  end
+
+  it "does not incorrectly reorder when clicking answer options" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Single option", from: "Type"
+    2.times { click_button "Add answer option" }
+
+    within ".questionnaire-question-answer-option:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Something"
+    end
+
+    within ".questionnaire-question-answer-option:last-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Else"
+    end
+
+    # If JS events for option reordering are incorrectly bound, clicking on
+    # the field to gain focus can cause the options to get inverted... :S
+    within ".questionnaire-question-answer-option:first-of-type" do
+      find_nested_form_field("body_en").click
+    end
+
+    within ".questionnaire-question-answer-option:first-of-type" do
+      expect(page).to have_nested_field("body_en", with: "Something")
+    end
+
+    within ".questionnaire-question-answer-option:last-of-type" do
+      expect(page).to have_nested_field("body_en", with: "Else")
+    end
+  end
+
+  it "does not incorrectly reorder when clicking matrix rows" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Matrix (Multiple option)", from: "Type"
+    2.times { click_button "Add row" }
+
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Something"
+    end
+
+    within ".questionnaire-question-matrix-row:last-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Else"
+    end
+
+    # If JS events for option reordering are incorrectly bound, clicking on
+    # the field to gain focus can cause the options to get inverted... :S
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      find_nested_form_field("body_en").click
+    end
+
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      expect(page).to have_nested_field("body_en", with: "Something")
+    end
+
+    within ".questionnaire-question-matrix-row:last-of-type" do
+      expect(page).to have_nested_field("body_en", with: "Else")
+    end
+  end
+
+  it "preserves question form across submission failures" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Long answer", from: "Type"
+    click_button "Save"
+
+    expand_all_questions
+    expect(page).to have_select("Type", selected: "Long answer")
+  end
+
+  it "does not preserve spurious answer options from previous type selections" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Single option", from: "Type"
+
+    within ".questionnaire-question-answer-option:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Something"
+    end
+
+    select "Long answer", from: "Type"
+
+    click_button "Save"
+    expand_all_questions
+
+    select "Single option", from: "Type"
+
+    within ".questionnaire-question-answer-option:first-of-type" do
+      expect(page).to have_no_nested_field("body_en", with: "Something")
+    end
+  end
+
+  it "does not preserve spurious matrix rows from previous type selections" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Matrix (Single option)", from: "Type"
+
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Something"
+    end
+
+    select "Long answer", from: "Type"
+
+    click_button "Save"
+    expand_all_questions
+
+    select "Matrix (Single option)", from: "Type"
+
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      expect(page).to have_no_nested_field("body_en", with: "Something")
+    end
+  end
+
+  it "preserves answer options form across submission failures" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Multiple option", from: "Type"
+
+    within ".questionnaire-question-answer-option:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Something"
+    end
+
+    click_button "Add answer option"
+
+    within ".questionnaire-question-answer-option:last-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Else"
+    end
+
+    select "3", from: "Maximum number of choices"
+
+    click_button "Save"
+    expand_all_questions
+
+    within ".questionnaire-question-answer-option:first-of-type" do
+      expect(page).to have_nested_field("body_en", with: "Something")
+    end
+
+    within ".questionnaire-question-answer-option:last-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Else"
+    end
+
+    expect(page).to have_select("Maximum number of choices", selected: "3")
+  end
+
+  it "preserves matrix rows form across submission failures" do
+    click_button "Add question"
+    expand_all_questions
+
+    select "Matrix (Multiple option)", from: "Type"
+
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Something"
+    end
+
+    click_button "Add row"
+
+    click_button "Save"
+    expand_all_questions
+
+    within ".questionnaire-question-matrix-row:first-of-type" do
+      expect(page).to have_nested_field("body_en", with: "Something")
+    end
+  end
+
+  it "allows switching translated field tabs after form failures" do
+    click_button "Add question"
+    click_button "Save"
+
+    expand_all_questions
+
+    within ".questionnaire-question:first-of-type" do
+      fill_in find_nested_form_field_locator("body_en"), with: "Bye"
+      click_link "Català", match: :first
+
+      fill_in find_nested_form_field_locator("body_ca"), with: "Adeu"
+      click_link "English", match: :first
+
+      expect(page).to have_nested_field("body_en", with: "Bye")
+      expect(page).to have_no_selector(nested_form_field_selector("body_ca"))
+      expect(page).to have_no_content("Adeu")
+    end
+  end
+
+  context "when adding a multiple option question" do
+    before do
+      visit questionnaire_edit_path
+
+      within "form.edit_questionnaire" do
+        click_button "Add question"
+
+        expand_all_questions
+
+        within ".questionnaire-question" do
+          fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
+        end
+
+        expect(page).to have_no_content "Add answer option"
+        expect(page).to have_no_select("Maximum number of choices")
+      end
+    end
+
+    it "updates the free text option selector according to the selected question type" do
+      expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
+
+      select "Multiple option", from: "Type"
+      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+
+      select "Short answer", from: "Type"
+      expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
+
+      select "Single option", from: "Type"
+      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+    end
+
+    it "updates the max choices selector according to the configured options" do
+      expect(page).to have_no_select("Maximum number of choices")
+
+      select "Multiple option", from: "Type"
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+      click_button "Add answer option"
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
+
+      click_button "Add answer option"
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3 4))
+
+      within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
+
+      within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+      click_button "Add question"
+      expand_all_questions
+
+      within(".questionnaire-question:last-of-type") do
+        select "Multiple option", from: "Type"
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+        select "Single option", from: "Type"
+        expect(page).to have_no_select("Maximum number of choices")
+      end
+    end
+  end
+
+  context "when adding a matrix question" do
+    before do
+      visit questionnaire_edit_path
+
+      within "form.edit_questionnaire" do
+        click_button "Add question"
+        expand_all_questions
+
+        within ".questionnaire-question" do
+          fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
+        end
+
+        expect(page).to have_no_content "Add answer option"
+        expect(page).to have_no_content "Add row"
+        expect(page).to have_no_select("Maximum number of choices")
+      end
+    end
+
+    it "updates the free text option selector according to the selected question type" do
+      expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
+
+      select "Matrix (Multiple option)", from: "Type"
+      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+
+      select "Short answer", from: "Type"
+      expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
+
+      select "Matrix (Single option)", from: "Type"
+      expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+    end
+
+    it "updates the max choices selector according to the configured options" do
+      expect(page).to have_no_select("Maximum number of choices")
+
+      select "Matrix (Multiple option)", from: "Type"
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+      click_button "Add answer option"
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
+
+      click_button "Add answer option"
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3 4))
+
+      within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
+
+      within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+      expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+      click_button "Add question"
+      expand_all_questions
+
+      within(".questionnaire-question:last-of-type") do
+        select "Matrix (Multiple option)", from: "Type"
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+        select "Matrix (Single option)", from: "Type"
+        expect(page).to have_no_select("Maximum number of choices")
+      end
+    end
+  end
+end