decidim-forms 0.21.0 → 0.22.0

data/lib/decidim/forms/test/shared_examples/manage_questionnaires.rb

@@ -37,15 +37,19 @@ shared_examples_for "manage questionnaires" do
       visit questionnaire_edit_path
     end
 
-    it "adds a few questions to the questionnaire" do
+    it "adds a few questions and separators to the questionnaire" do
       questions_body = ["This is the first question", "This is the second question"]
 
       within "form.edit_questionnaire" do
-        2.times { click_button "Add question" }
+        click_button "Add question"
+        click_button "Add separator"
+        click_button "Add question"
 
-        expect(page).to have_selector(".questionnaire-question", count: 2)
+        expect(page).to have_selector(".questionnaire-question", count: 3)
 
-        page.all(".questionnaire-question").each_with_index do |question, idx|
+        expand_all_questions
+
+        page.all(".questionnaire-question .collapsible").each_with_index do |question, idx|
           within question do
             fill_in find_nested_form_field_locator("body_en"), with: questions_body[idx]
           end
@@ -56,20 +60,22 @@ shared_examples_for "manage questionnaires" do
 
       expect(page).to have_admin_callout("successfully")
 
-      visit questionnaire_edit_path
+      visit_questionnaire_edit_path_and_expand_all
 
       expect(page).to have_selector("input[value='This is the first question']")
       expect(page).to have_selector("input[value='This is the second question']")
+      expect(page).to have_content("Separator #2")
     end
 
     it "adds a question with a rich text description" do
       within "form.edit_questionnaire" do
         click_button "Add question"
+        expand_all_questions
 
         within ".questionnaire-question" do
           fill_in find_nested_form_field_locator("body_en"), with: "Body"
 
-          fill_in_editor find_nested_form_field_locator("description_en", visible: false), with: "<b>Superkalifragilistic description</b>"
+          fill_in_editor find_nested_form_field_locator("description_en", visible: :all), with: "<b>Superkalifragilistic description</b>"
         end
 
         click_button "Save"
@@ -108,6 +114,7 @@ shared_examples_for "manage questionnaires" do
       within "form.edit_questionnaire" do
         click_button "Add question"
         click_button "Add question"
+        expand_all_questions
 
         page.all(".questionnaire-question").each_with_index do |question, idx|
           within question do
@@ -137,7 +144,7 @@ shared_examples_for "manage questionnaires" do
 
       expect(page).to have_admin_callout("successfully")
 
-      visit questionnaire_edit_path
+      visit_questionnaire_edit_path_and_expand_all
 
       expect(page).to have_selector("input[value='This is the first question']")
       expect(page).to have_selector("input[value='This is the Q1 first option']")
@@ -151,25 +158,37 @@ shared_examples_for "manage questionnaires" do
 
     it "adds a sane number of options for each attribute type" do
       click_button "Add question"
+      expand_all_questions
 
       select "Long answer", from: "Type"
       expect(page).to have_no_selector(".questionnaire-question-answer-option")
+      expect(page).to have_no_selector(".questionnaire-question-matrix-row")
 
       select "Single option", from: "Type"
       expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+      expect(page).to have_no_selector(".questionnaire-question-matrix-row")
 
       select "Multiple option", from: "Type"
       expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+      expect(page).to have_no_selector(".questionnaire-question-matrix-row")
 
-      select "Single option", from: "Type"
+      select "Matrix (Multiple option)", from: "Type"
       expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+      expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
 
       select "Short answer", from: "Type"
       expect(page).to have_no_selector(".questionnaire-question-answer-option")
+      expect(page).to have_no_selector(".questionnaire-question-matrix-row")
+
+      select "Matrix (Single option)", from: "Type"
+      expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
+      expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
     end
 
     it "does not incorrectly reorder when clicking answer options" do
       click_button "Add question"
+      expand_all_questions
+
       select "Single option", from: "Type"
       2.times { click_button "Add answer option" }
 
@@ -196,16 +215,53 @@ shared_examples_for "manage questionnaires" do
       end
     end
 
+    it "does not incorrectly reorder when clicking matrix rows" do
+      # Unable to find visible select box "Type" that is not disabled and Unable to find input box with datalist completion "Type" that is not disabled
+
+      click_button "Add question"
+      expand_all_questions
+
+      select "Matrix (Multiple option)", from: "Type"
+      2.times { click_button "Add row" }
+
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        fill_in find_nested_form_field_locator("body_en"), with: "Something"
+      end
+
+      within ".questionnaire-question-matrix-row:last-of-type" do
+        fill_in find_nested_form_field_locator("body_en"), with: "Else"
+      end
+
+      # If JS events for option reordering are incorrectly bound, clicking on
+      # the field to gain focus can cause the options to get inverted... :S
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        find_nested_form_field("body_en").click
+      end
+
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        expect(page).to have_nested_field("body_en", with: "Something")
+      end
+
+      within ".questionnaire-question-matrix-row:last-of-type" do
+        expect(page).to have_nested_field("body_en", with: "Else")
+      end
+    end
+
     it "preserves question form across submission failures" do
       click_button "Add question"
+      expand_all_questions
+
       select "Long answer", from: "Type"
       click_button "Save"
 
+      expand_all_questions
       expect(page).to have_select("Type", selected: "Long answer")
     end
 
     it "does not preserve spurious answer options from previous type selections" do
       click_button "Add question"
+      expand_all_questions
+
       select "Single option", from: "Type"
 
       within ".questionnaire-question-answer-option:first-of-type" do
@@ -215,6 +271,7 @@ shared_examples_for "manage questionnaires" do
       select "Long answer", from: "Type"
 
       click_button "Save"
+      expand_all_questions
 
       select "Single option", from: "Type"
 
@@ -223,8 +280,32 @@ shared_examples_for "manage questionnaires" do
       end
     end
 
+    it "does not preserve spurious matrix rows from previous type selections" do
+      click_button "Add question"
+      expand_all_questions
+
+      select "Matrix (Single option)", from: "Type"
+
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        fill_in find_nested_form_field_locator("body_en"), with: "Something"
+      end
+
+      select "Long answer", from: "Type"
+
+      click_button "Save"
+      expand_all_questions
+
+      select "Matrix (Single option)", from: "Type"
+
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        expect(page).to have_no_nested_field("body_en", with: "Something")
+      end
+    end
+
     it "preserves answer options form across submission failures" do
       click_button "Add question"
+      expand_all_questions
+
       select "Multiple option", from: "Type"
 
       within ".questionnaire-question-answer-option:first-of-type" do
@@ -240,6 +321,7 @@ shared_examples_for "manage questionnaires" do
       select "3", from: "Maximum number of choices"
 
       click_button "Save"
+      expand_all_questions
 
       within ".questionnaire-question-answer-option:first-of-type" do
         expect(page).to have_nested_field("body_en", with: "Something")
@@ -252,10 +334,32 @@ shared_examples_for "manage questionnaires" do
       expect(page).to have_select("Maximum number of choices", selected: "3")
     end
 
+    it "preserves matrix rows form across submission failures" do
+      click_button "Add question"
+      expand_all_questions
+
+      select "Matrix (Multiple option)", from: "Type"
+
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        fill_in find_nested_form_field_locator("body_en"), with: "Something"
+      end
+
+      click_button "Add row"
+
+      click_button "Save"
+      expand_all_questions
+
+      within ".questionnaire-question-matrix-row:first-of-type" do
+        expect(page).to have_nested_field("body_en", with: "Something")
+      end
+    end
+
     it "allows switching translated field tabs after form failures" do
       click_button "Add question"
       click_button "Save"
 
+      expand_all_questions
+
       within ".questionnaire-question:first-of-type" do
         fill_in find_nested_form_field_locator("body_en"), with: "Bye"
         click_link "Català", match: :first
@@ -276,6 +380,8 @@ shared_examples_for "manage questionnaires" do
         within "form.edit_questionnaire" do
           click_button "Add question"
 
+          expand_all_questions
+
           within ".questionnaire-question" do
             fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
           end
@@ -317,6 +423,7 @@ shared_examples_for "manage questionnaires" do
         expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
 
         click_button "Add question"
+        expand_all_questions
 
         within(".questionnaire-question:last-of-type") do
           select "Multiple option", from: "Type"
@@ -328,11 +435,74 @@ shared_examples_for "manage questionnaires" do
       end
     end
 
+    context "when adding a matrix question" do
+      before do
+        visit questionnaire_edit_path
+
+        within "form.edit_questionnaire" do
+          click_button "Add question"
+          expand_all_questions
+
+          within ".questionnaire-question" do
+            fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
+          end
+
+          expect(page).to have_no_content "Add answer option"
+          expect(page).to have_no_content "Add row"
+          expect(page).to have_no_select("Maximum number of choices")
+        end
+      end
+
+      it "updates the free text option selector according to the selected question type" do
+        expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
+
+        select "Matrix (Multiple option)", from: "Type"
+        expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+
+        select "Short answer", from: "Type"
+        expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
+
+        select "Matrix (Single option)", from: "Type"
+        expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
+      end
+
+      it "updates the max choices selector according to the configured options" do
+        expect(page).to have_no_select("Maximum number of choices")
+
+        select "Matrix (Multiple option)", from: "Type"
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+        click_button "Add answer option"
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
+
+        click_button "Add answer option"
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3 4))
+
+        within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
+
+        within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
+        expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+        click_button "Add question"
+        expand_all_questions
+
+        within(".questionnaire-question:last-of-type") do
+          select "Matrix (Multiple option)", from: "Type"
+          expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
+
+          select "Matrix (Single option)", from: "Type"
+          expect(page).to have_no_select("Maximum number of choices")
+        end
+      end
+    end
+
     context "when a questionnaire has an existing question" do
       let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, body: body) }
 
       before do
         visit questionnaire_edit_path
+        expand_all_questions
       end
 
       it "modifies the question when the information is valid" do
@@ -348,7 +518,7 @@ shared_examples_for "manage questionnaires" do
 
         expect(page).to have_admin_callout("successfully")
 
-        visit questionnaire_edit_path
+        visit_questionnaire_edit_path_and_expand_all
 
         expect(page).to have_selector("input[value='Modified question']")
         expect(page).to have_no_selector("input[value='This is the first question']")
@@ -357,26 +527,30 @@ shared_examples_for "manage questionnaires" do
       end
 
       it "re-renders the form when the information is invalid and displays errors" do
+        expand_all_questions
+
         within "form.edit_questionnaire" do
           within ".questionnaire-question" do
             expect(page).to have_content("Statement*")
             fill_in "questionnaire_questions_#{question.id}_body_en", with: ""
             check "Mandatory"
-            select "Multiple option", from: "Type"
+            select "Matrix (Multiple option)", from: "Type"
             select "2", from: "Maximum number of choices"
           end
 
           click_button "Save"
         end
 
+        expand_all_questions
+
         expect(page).to have_admin_callout("There was a problem saving")
-        expect(page).to have_content("can't be blank", count: 3) # emtpy question, 2 empty default answer options
+        expect(page).to have_content("can't be blank", count: 5) # emtpy question, 2 empty default answer options, 2 empty default matrix rows
 
         expect(page).to have_selector("input[value='']")
         expect(page).to have_no_selector("input[value='This is the first question']")
         expect(page).to have_selector("input#questionnaire_questions_#{question.id}_mandatory[checked]")
         expect(page).to have_select("Maximum number of choices", selected: "2")
-        expect(page).to have_selector("select#questionnaire_questions_#{question.id}_question_type option[value='multiple_option'][selected]")
+        expect(page).to have_selector("select#questionnaire_questions_#{question.id}_question_type option[value='matrix_multiple'][selected]")
       end
 
       it "preserves deleted status across submission failures" do
@@ -454,13 +628,15 @@ shared_examples_for "manage questionnaires" do
       end
 
       it "allows deleting answer options" do
+        expand_all_questions
+
         within ".questionnaire-question-answer-option:last-of-type" do
           click_button "Remove"
         end
 
         click_button "Save"
 
-        visit questionnaire_edit_path
+        visit_questionnaire_edit_path_and_expand_all
 
         expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
       end
@@ -469,6 +645,8 @@ shared_examples_for "manage questionnaires" do
         within "form.edit_questionnaire" do
           expect(page).to have_selector(".questionnaire-question", count: 1)
 
+          expand_all_questions
+
           within ".questionnaire-question-answer-option:first-of-type" do
             fill_in find_nested_form_field_locator("body_en"), with: ""
           end
@@ -482,7 +660,7 @@ shared_examples_for "manage questionnaires" do
 
         expect(page).to have_admin_callout("successfully")
 
-        visit questionnaire_edit_path
+        visit_questionnaire_edit_path_and_expand_all
 
         within "form.edit_questionnaire" do
           expect(page).to have_selector(".questionnaire-question", count: 0)
@@ -490,6 +668,72 @@ shared_examples_for "manage questionnaires" do
       end
     end
 
+    context "when a questionnaire has an existing question with matrix rows" do
+      let!(:other_question) { create(:questionnaire_question, questionnaire: questionnaire, position: 1) }
+      let!(:question) do
+        create(
+          :questionnaire_question,
+          questionnaire: questionnaire,
+          body: body,
+          question_type: "matrix_single",
+          position: 2,
+          options: [
+            { "body" => { "en" => "cacarua" } },
+            { "body" => { "en" => "cat" } },
+            { "body" => { "en" => "dog" } }
+          ],
+          rows: [
+            { "body" => { "en" => "cute" } },
+            { "body" => { "en" => "ugly" } },
+            { "body" => { "en" => "meh" } }
+          ]
+        )
+      end
+
+      before do
+        visit_questionnaire_edit_path_and_expand_all
+      end
+
+      it "allows deleting matrix rows" do
+        within ".questionnaire-question-matrix-row:last-of-type" do
+          click_button "Remove"
+        end
+
+        click_button "Save"
+
+        visit_questionnaire_edit_path_and_expand_all
+
+        within ".questionnaire-question:last-of-type" do
+          expect(page).to have_selector(".questionnaire-question-matrix-row", count: 2)
+          expect(page).to have_selector(".questionnaire-question-answer-option", count: 3)
+        end
+      end
+
+      it "still removes the question even if previous editions rendered the rows invalid" do
+        within "form.edit_questionnaire" do
+          expect(page).to have_selector(".questionnaire-question", count: 2)
+
+          within ".questionnaire-question-matrix-row:first-of-type" do
+            fill_in find_nested_form_field_locator("body_en"), with: ""
+          end
+
+          within ".questionnaire-question:last-of-type" do
+            click_button "Remove", match: :first
+          end
+
+          click_button "Save"
+        end
+
+        expect(page).to have_admin_callout("successfully")
+
+        visit_questionnaire_edit_path_and_expand_all
+
+        within "form.edit_questionnaire" do
+          expect(page).to have_selector(".questionnaire-question", count: 1)
+        end
+      end
+    end
+
     context "when a questionnaire has multiple existing questions" do
       let!(:question_1) do
         create(:questionnaire_question, questionnaire: questionnaire, body: first_body, position: 0)
@@ -509,6 +753,7 @@ shared_examples_for "manage questionnaires" do
 
       before do
         visit questionnaire_edit_path
+        expand_all_questions
       end
 
       shared_examples_for "switching questions order" do
@@ -545,8 +790,77 @@ shared_examples_for "manage questionnaires" do
         it_behaves_like "switching questions order"
       end
 
+      describe "collapsible questions" do
+        context "when clicking on Expand all button" do
+          it "expands all questions" do
+            click_button "Expand all questions"
+            expect(page).to have_selector(".collapsible", visible: :visible)
+            expect(page).to have_selector(".question--collapse .icon-collapse", count: questionnaire.questions.count)
+          end
+        end
+
+        context "when clicking on Collapse all button" do
+          it "collapses all questions" do
+            click_button "Collapse all questions"
+            expect(page).not_to have_selector(".collapsible", visible: :visible)
+            expect(page).to have_selector(".question--collapse .icon-expand", count: questionnaire.questions.count)
+          end
+        end
+
+        shared_examples_for "collapsing a question" do
+          it "changes the toggle button" do
+            within ".questionnaire-question:last-of-type" do
+              expect(page).to have_selector(".icon-expand")
+            end
+          end
+
+          it "hides the question card section" do
+            within ".questionnaire-question:last-of-type" do
+              expect(page).not_to have_selector(".collapsible", visible: :visible)
+            end
+          end
+        end
+
+        shared_examples_for "uncollapsing a question" do
+          it "changes the toggle button" do
+            within ".questionnaire-question:last-of-type" do
+              expect(page).to have_selector(".icon-collapse")
+            end
+          end
+
+          it "shows the question card section" do
+            expect(page).to have_selector(".collapsible", visible: :visible)
+          end
+        end
+
+        context "when collapsing an existing question" do
+          before do
+            expand_all_questions
+            within ".questionnaire-question:last-of-type" do
+              page.find(".question--collapse").click
+            end
+          end
+
+          it_behaves_like "collapsing a question"
+        end
+
+        context "when adding a new question" do
+          before do
+            click_button "Add question"
+            expand_all_questions
+
+            within ".questionnaire-question:last-of-type" do
+              page.find(".question--collapse").click
+            end
+          end
+
+          it_behaves_like "collapsing a question"
+        end
+      end
+
       it "properly decides which button to show after adding/removing questions" do
         click_button "Add question"
+        expand_all_questions
 
         expect(page.find(".questionnaire-question:nth-of-type(1)")).to look_like_first_question
         expect(page.find(".questionnaire-question:nth-of-type(2)")).to look_like_intermediate_question
@@ -561,11 +875,15 @@ shared_examples_for "manage questionnaires" do
       end
 
       it "does not duplicate editors when adding new questions" do
-        expect { click_button "Add question" }.to change { page.all(".ql-toolbar").size }.by(1)
+        expect do
+          click_button "Add question"
+          expand_all_questions
+        end.to change { page.all(".ql-toolbar").size }.by(1)
       end
 
       it "properly decides which button to show after adding/removing answer options" do
         click_button "Add question"
+        expand_all_questions
 
         within ".questionnaire-question:last-of-type" do
           select "Single option", from: "Type"
@@ -588,6 +906,7 @@ shared_examples_for "manage questionnaires" do
         end
 
         click_button "Save"
+        expand_all_questions
 
         within ".questionnaire-question:last-of-type" do
           within ".questionnaire-question-answer-options-list" do
@@ -621,6 +940,9 @@ shared_examples_for "manage questionnaires" do
 
       expect(page).to have_no_content("Add question")
       expect(page).to have_no_content("Remove")
+
+      expand_all_questions
+
       expect(page).to have_selector("input[value='This is the first question'][disabled]")
       expect(page).to have_selector("select[id$=question_type][disabled]")
       expect(page).to have_selector("select[id$=max_choices][disabled]")
@@ -649,4 +971,13 @@ shared_examples_for "manage questionnaires" do
   def nested_form_field_selector(attribute)
     "[id$=#{attribute}]"
   end
+
+  def expand_all_questions
+    find(".button.expand-all").click
+  end
+
+  def visit_questionnaire_edit_path_and_expand_all
+    visit questionnaire_edit_path
+    expand_all_questions
+  end
 end