decidim-forms 0.19.1 → 0.23.0

data/lib/decidim/forms/test/shared_examples/manage_questionnaire_answers.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "manage questionnaire answers" do
+  let(:first_type) { "short_answer" }
+  let!(:first) do
+    create :questionnaire_question, questionnaire: questionnaire, position: 1, question_type: first_type
+  end
+  let!(:second) do
+    create :questionnaire_question, questionnaire: questionnaire, position: 2, question_type: "single_option"
+  end
+  let(:questions) do
+    [first, second]
+  end
+
+  context "when there are no answers" do
+    it "do not answer admin link" do
+      visit questionnaire_edit_path
+      expect(page).to have_content("No answers yet")
+    end
+  end
+
+  context "when there are answers" do
+    let!(:answer1) { create :answer, questionnaire: questionnaire, question: first }
+    let!(:answer2) { create :answer, body: "second answer", questionnaire: questionnaire, question: first }
+    let!(:answer3) { create :answer, questionnaire: questionnaire, question: second }
+
+    it "shows the answer admin link" do
+      visit questionnaire_edit_path
+      expect(page).to have_content("Show responses")
+    end
+
+    context "and managing answers page" do
+      before do
+        visit questionnaire_edit_path
+        click_link "Show responses"
+      end
+
+      it "shows the anwers page" do
+        expect(page).to have_content(answer1.body)
+        expect(page).to have_content(answer1.question.body["en"])
+        expect(page).to have_content(answer2.body)
+        expect(page).to have_content(answer2.question.body["en"])
+      end
+
+      it "shows the percentage" do
+        expect(page).to have_content("50%")
+      end
+
+      it "has a detail link" do
+        expect(page).to have_link("Show answers")
+      end
+
+      it "has an export link" do
+        expect(page).to have_link(answer1.body)
+        expect(page).to have_link(answer2.body)
+        expect(page).to have_link("Export")
+      end
+
+      context "when no short answer exist" do
+        let(:first_type) { "long_answer" }
+
+        it "shows session token" do
+          expect(page).not_to have_content(answer1.body)
+          expect(page).to have_content(answer1.session_token)
+          expect(page).to have_content(answer2.session_token)
+          expect(page).to have_content(answer3.session_token)
+          expect(page).to have_content("User identifier")
+        end
+      end
+    end
+
+    context "and managing individual answer page" do
+      let!(:answer11) { create :answer, questionnaire: questionnaire, body: "", user: answer1.user, question: second }
+
+      before do
+        visit questionnaire_edit_path
+        click_link "Show responses"
+      end
+
+      it "shows all the questions and responses" do
+        click_link answer1.body, match: :first
+        expect(page).to have_content(first.body["en"])
+        expect(page).to have_content(second.body["en"])
+        expect(page).to have_content(answer1.body)
+      end
+
+      it "first answer has a next link" do
+        click_link answer1.body, match: :first
+        expect(page).to have_link("Next ›")
+        expect(page).not_to have_link("‹ Prev")
+      end
+
+      it "second answer has prev/next links" do
+        click_link answer2.body, match: :first
+        expect(page).to have_link("Next ›")
+        expect(page).to have_link("‹ Prev")
+      end
+
+      it "third answer has prev link" do
+        click_link answer3.session_token, match: :first
+        expect(page).not_to have_link("Next ›")
+        expect(page).to have_link("‹ Prev")
+      end
+    end
+  end
+end

data/lib/decidim/forms/test/shared_examples/manage_questionnaires.rb

@@ -2,6 +2,11 @@
 
 require "spec_helper"
 
+require "decidim/forms/test/shared_examples/manage_questionnaires/add_questions.rb"
+require "decidim/forms/test/shared_examples/manage_questionnaires/update_questions.rb"
+require "decidim/forms/test/shared_examples/manage_questionnaires/add_display_conditions.rb"
+require "decidim/forms/test/shared_examples/manage_questionnaires/update_display_conditions.rb"
+
 shared_examples_for "manage questionnaires" do
   let(:body) do
     {
@@ -37,579 +42,10 @@ shared_examples_for "manage questionnaires" do
       visit questionnaire_edit_path
     end
 
-    it "adds a few questions to the questionnaire" do
-      questions_body = ["This is the first question", "This is the second question"]
-
-      within "form.edit_questionnaire" do
-        2.times { click_button "Add question" }
-
-        expect(page).to have_selector(".questionnaire-question", count: 2)
-
-        page.all(".questionnaire-question").each_with_index do |question, idx|
-          within question do
-            fill_in find_nested_form_field_locator("body_en"), with: questions_body[idx]
-          end
-        end
-
-        click_button "Save"
-      end
-
-      expect(page).to have_admin_callout("successfully")
-
-      visit questionnaire_edit_path
-
-      expect(page).to have_selector("input[value='This is the first question']")
-      expect(page).to have_selector("input[value='This is the second question']")
-    end
-
-    it "adds a question with a rich text description" do
-      within "form.edit_questionnaire" do
-        click_button "Add question"
-
-        within ".questionnaire-question" do
-          fill_in find_nested_form_field_locator("body_en"), with: "Body"
-
-          fill_in_editor find_nested_form_field_locator("description_en", visible: false), with: "<b>Superkalifragilistic description</b>"
-        end
-
-        click_button "Save"
-      end
-
-      expect(page).to have_admin_callout("successfully")
-
-      component.update!(
-        step_settings: {
-          component.participatory_space.active_step.id => {
-            allow_answers: true
-          }
-        }
-      )
-
-      visit questionnaire_public_path
-
-      expect(page).to have_selector("strong", text: "Superkalifragilistic description")
-    end
-
-    it "adds a question with answer options" do
-      question_body = ["This is the first question", "This is the second question"]
-      answer_options_body = [
-        [
-          "This is the Q1 first option",
-          "This is the Q1 second option",
-          "This is the Q1 third option"
-        ],
-        [
-          "This is the Q2 first option",
-          "This is the Q2 second option",
-          "This is the Q2 third option"
-        ]
-      ]
-
-      within "form.edit_questionnaire" do
-        click_button "Add question"
-        click_button "Add question"
-
-        page.all(".questionnaire-question").each_with_index do |question, idx|
-          within question do
-            fill_in find_nested_form_field_locator("body_en"), with: question_body[idx]
-          end
-        end
-
-        expect(page).to have_no_content "Add answer option"
-
-        page.all(".questionnaire-question").each do |question|
-          within question do
-            select "Single option", from: "Type"
-            click_button "Add answer option"
-          end
-        end
-
-        page.all(".questionnaire-question").each_with_index do |question, idx|
-          question.all(".questionnaire-question-answer-option").each_with_index do |question_answer_option, aidx|
-            within question_answer_option do
-              fill_in find_nested_form_field_locator("body_en"), with: answer_options_body[idx][aidx]
-            end
-          end
-        end
-
-        click_button "Save"
-      end
-
-      expect(page).to have_admin_callout("successfully")
-
-      visit questionnaire_edit_path
-
-      expect(page).to have_selector("input[value='This is the first question']")
-      expect(page).to have_selector("input[value='This is the Q1 first option']")
-      expect(page).to have_selector("input[value='This is the Q1 second option']")
-      expect(page).to have_selector("input[value='This is the Q1 third option']")
-      expect(page).to have_selector("input[value='This is the second question']")
-      expect(page).to have_selector("input[value='This is the Q2 first option']")
-      expect(page).to have_selector("input[value='This is the Q2 second option']")
-      expect(page).to have_selector("input[value='This is the Q2 third option']")
-    end
-
-    it "adds a sane number of options for each attribute type" do
-      click_button "Add question"
-
-      select "Long answer", from: "Type"
-      expect(page).to have_no_selector(".questionnaire-question-answer-option")
-
-      select "Single option", from: "Type"
-      expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-
-      select "Multiple option", from: "Type"
-      expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-
-      select "Single option", from: "Type"
-      expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-
-      select "Short answer", from: "Type"
-      expect(page).to have_no_selector(".questionnaire-question-answer-option")
-    end
-
-    it "does not incorrectly reorder when clicking answer options" do
-      click_button "Add question"
-      select "Single option", from: "Type"
-      2.times { click_button "Add answer option" }
-
-      within ".questionnaire-question-answer-option:first-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Something"
-      end
-
-      within ".questionnaire-question-answer-option:last-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Else"
-      end
-
-      # If JS events for option reordering are incorrectly bound, clicking on
-      # the field to gain focus can cause the options to get inverted... :S
-      within ".questionnaire-question-answer-option:first-of-type" do
-        find_nested_form_field("body_en").click
-      end
-
-      within ".questionnaire-question-answer-option:first-of-type" do
-        expect(page).to have_nested_field("body_en", with: "Something")
-      end
-
-      within ".questionnaire-question-answer-option:last-of-type" do
-        expect(page).to have_nested_field("body_en", with: "Else")
-      end
-    end
-
-    it "preserves question form across submission failures" do
-      click_button "Add question"
-      select "Long answer", from: "Type"
-      click_button "Save"
-
-      expect(page).to have_select("Type", selected: "Long answer")
-    end
-
-    it "does not preserve spurious answer options from previous type selections" do
-      click_button "Add question"
-      select "Single option", from: "Type"
-
-      within ".questionnaire-question-answer-option:first-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Something"
-      end
-
-      select "Long answer", from: "Type"
-
-      click_button "Save"
-
-      select "Single option", from: "Type"
-
-      within ".questionnaire-question-answer-option:first-of-type" do
-        expect(page).to have_no_nested_field("body_en", with: "Something")
-      end
-    end
-
-    it "preserves answer options form across submission failures" do
-      click_button "Add question"
-      select "Multiple option", from: "Type"
-
-      within ".questionnaire-question-answer-option:first-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Something"
-      end
-
-      click_button "Add answer option"
-
-      within ".questionnaire-question-answer-option:last-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Else"
-      end
-
-      select "3", from: "Maximum number of choices"
-
-      click_button "Save"
-
-      within ".questionnaire-question-answer-option:first-of-type" do
-        expect(page).to have_nested_field("body_en", with: "Something")
-      end
-
-      within ".questionnaire-question-answer-option:last-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Else"
-      end
-
-      expect(page).to have_select("Maximum number of choices", selected: "3")
-    end
-
-    it "allows switching translated field tabs after form failures" do
-      click_button "Add question"
-      click_button "Save"
-
-      within ".questionnaire-question:first-of-type" do
-        fill_in find_nested_form_field_locator("body_en"), with: "Bye"
-        click_link "Català", match: :first
-
-        fill_in find_nested_form_field_locator("body_ca"), with: "Adeu"
-        click_link "English", match: :first
-
-        expect(page).to have_nested_field("body_en", with: "Bye")
-        expect(page).to have_no_selector(nested_form_field_selector("body_ca"))
-        expect(page).to have_no_content("Adeu")
-      end
-    end
-
-    context "when adding a multiple option question" do
-      before do
-        visit questionnaire_edit_path
-
-        within "form.edit_questionnaire" do
-          click_button "Add question"
-
-          within ".questionnaire-question" do
-            fill_in find_nested_form_field_locator("body_en"), with: "This is the first question"
-          end
-
-          expect(page).to have_no_content "Add answer option"
-          expect(page).to have_no_select("Maximum number of choices")
-        end
-      end
-
-      it "updates the free text option selector according to the selected question type" do
-        expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
-
-        select "Multiple option", from: "Type"
-        expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
-
-        select "Short answer", from: "Type"
-        expect(page).to have_no_selector("input[type=checkbox][id$=_free_text]")
-
-        select "Single option", from: "Type"
-        expect(page).to have_selector("input[type=checkbox][id$=_free_text]")
-      end
-
-      it "updates the max choices selector according to the configured options" do
-        expect(page).to have_no_select("Maximum number of choices")
-
-        select "Multiple option", from: "Type"
-        expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
-
-        click_button "Add answer option"
-        expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
-
-        click_button "Add answer option"
-        expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3 4))
-
-        within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
-        expect(page).to have_select("Maximum number of choices", options: %w(Any 2 3))
-
-        within(".questionnaire-question-answer-option:last-of-type") { click_button "Remove" }
-        expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
-
-        click_button "Add question"
-
-        within(".questionnaire-question:last-of-type") do
-          select "Multiple option", from: "Type"
-          expect(page).to have_select("Maximum number of choices", options: %w(Any 2))
-
-          select "Single option", from: "Type"
-          expect(page).to have_no_select("Maximum number of choices")
-        end
-      end
-    end
-
-    context "when a questionnaire has an existing question" do
-      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, body: body) }
-
-      before do
-        visit questionnaire_edit_path
-      end
-
-      it "modifies the question when the information is valid" do
-        within "form.edit_questionnaire" do
-          within ".questionnaire-question" do
-            fill_in "questionnaire_questions_#{question.id}_body_en", with: "Modified question"
-            check "Mandatory"
-            select "Long answer", from: "Type"
-          end
-
-          click_button "Save"
-        end
-
-        expect(page).to have_admin_callout("successfully")
-
-        visit questionnaire_edit_path
-
-        expect(page).to have_selector("input[value='Modified question']")
-        expect(page).to have_no_selector("input[value='This is the first question']")
-        expect(page).to have_selector("input#questionnaire_questions_#{question.id}_mandatory[checked]")
-        expect(page).to have_selector("select#questionnaire_questions_#{question.id}_question_type option[value='long_answer'][selected]")
-      end
-
-      it "re-renders the form when the information is invalid and displays errors" do
-        within "form.edit_questionnaire" do
-          within ".questionnaire-question" do
-            expect(page).to have_content("Statement*")
-            fill_in "questionnaire_questions_#{question.id}_body_en", with: ""
-            check "Mandatory"
-            select "Multiple option", from: "Type"
-            select "2", from: "Maximum number of choices"
-          end
-
-          click_button "Save"
-        end
-
-        expect(page).to have_admin_callout("There was a problem saving")
-        expect(page).to have_content("can't be blank", count: 3) # emtpy question, 2 empty default answer options
-
-        expect(page).to have_selector("input[value='']")
-        expect(page).to have_no_selector("input[value='This is the first question']")
-        expect(page).to have_selector("input#questionnaire_questions_#{question.id}_mandatory[checked]")
-        expect(page).to have_select("Maximum number of choices", selected: "2")
-        expect(page).to have_selector("select#questionnaire_questions_#{question.id}_question_type option[value='multiple_option'][selected]")
-      end
-
-      it "preserves deleted status across submission failures" do
-        within "form.edit_questionnaire" do
-          within ".questionnaire-question" do
-            click_button "Remove"
-          end
-        end
-
-        click_button "Add question"
-
-        click_button "Save"
-
-        expect(page).to have_selector(".questionnaire-question", count: 1)
-
-        within ".questionnaire-question" do
-          expect(page).to have_selector(".card-title", text: "#1")
-          expect(page).to have_no_button("Up")
-        end
-      end
-
-      it "removes the question" do
-        within "form.edit_questionnaire" do
-          within ".questionnaire-question" do
-            click_button "Remove"
-          end
-
-          click_button "Save"
-        end
-
-        expect(page).to have_admin_callout("successfully")
-
-        visit questionnaire_edit_path
-
-        within "form.edit_questionnaire" do
-          expect(page).to have_selector(".questionnaire-question", count: 0)
-        end
-      end
-
-      it "cannot be moved up" do
-        within "form.edit_questionnaire" do
-          within ".questionnaire-question" do
-            expect(page).to have_no_button("Up")
-          end
-        end
-      end
-
-      it "cannot be moved down" do
-        within "form.edit_questionnaire" do
-          within ".questionnaire-question" do
-            expect(page).to have_no_button("Down")
-          end
-        end
-      end
-    end
-
-    context "when a questionnaire has an existing question with answer options" do
-      let!(:question) do
-        create(
-          :questionnaire_question,
-          questionnaire: questionnaire,
-          body: body,
-          question_type: "single_option",
-          answer_options: [
-            { "body" => { "en" => "cacarua" } },
-            { "body" => { "en" => "cat" } },
-            { "body" => { "en" => "dog" } }
-
-          ]
-        )
-      end
-
-      before do
-        visit questionnaire_edit_path
-      end
-
-      it "allows deleting answer options" do
-        within ".questionnaire-question-answer-option:last-of-type" do
-          click_button "Remove"
-        end
-
-        click_button "Save"
-
-        visit questionnaire_edit_path
-
-        expect(page).to have_selector(".questionnaire-question-answer-option", count: 2)
-      end
-
-      it "still removes the question even if previous editions rendered the options invalid" do
-        within "form.edit_questionnaire" do
-          expect(page).to have_selector(".questionnaire-question", count: 1)
-
-          within ".questionnaire-question-answer-option:first-of-type" do
-            fill_in find_nested_form_field_locator("body_en"), with: ""
-          end
-
-          within ".questionnaire-question" do
-            click_button "Remove", match: :first
-          end
-
-          click_button "Save"
-        end
-
-        expect(page).to have_admin_callout("successfully")
-
-        visit questionnaire_edit_path
-
-        within "form.edit_questionnaire" do
-          expect(page).to have_selector(".questionnaire-question", count: 0)
-        end
-      end
-    end
-
-    context "when a questionnaire has multiple existing questions" do
-      let!(:question_1) do
-        create(:questionnaire_question, questionnaire: questionnaire, body: first_body, position: 0)
-      end
-
-      let!(:question_2) do
-        create(:questionnaire_question, questionnaire: questionnaire, body: second_body, position: 1)
-      end
-
-      let(:first_body) do
-        { en: "First", ca: "Primera", es: "Primera" }
-      end
-
-      let(:second_body) do
-        { en: "Second", ca: "Segunda", es: "Segunda" }
-      end
-
-      before do
-        visit questionnaire_edit_path
-      end
-
-      shared_examples_for "switching questions order" do
-        it "properly reorders the questions" do
-          within ".questionnaire-question:first-of-type" do
-            expect(page).to have_nested_field("body_en", with: "Second")
-            expect(page).to look_like_first_question
-          end
-
-          within ".questionnaire-question:last-of-type" do
-            expect(page).to have_nested_field("body_en", with: "First")
-            expect(page).to look_like_last_question
-          end
-        end
-      end
-
-      context "when moving a question up" do
-        before do
-          within ".questionnaire-question:last-of-type" do
-            click_button "Up"
-          end
-        end
-
-        it_behaves_like "switching questions order"
-      end
-
-      context "when moving a question down" do
-        before do
-          within ".questionnaire-question:first-of-type" do
-            click_button "Down"
-          end
-        end
-
-        it_behaves_like "switching questions order"
-      end
-
-      it "properly decides which button to show after adding/removing questions" do
-        click_button "Add question"
-
-        expect(page.find(".questionnaire-question:nth-of-type(1)")).to look_like_first_question
-        expect(page.find(".questionnaire-question:nth-of-type(2)")).to look_like_intermediate_question
-        expect(page.find(".questionnaire-question:nth-of-type(3)")).to look_like_last_question
-
-        within ".questionnaire-question:first-of-type" do
-          click_button "Remove"
-        end
-
-        expect(page.all(".questionnaire-question").first).to look_like_first_question
-        expect(page.all(".questionnaire-question").last).to look_like_last_question
-      end
-
-      it "does not duplicate editors when adding new questions" do
-        expect { click_button "Add question" }.to change { page.all(".ql-toolbar").size }.by(1)
-      end
-
-      it "properly decides which button to show after adding/removing answer options" do
-        click_button "Add question"
-
-        within ".questionnaire-question:last-of-type" do
-          select "Single option", from: "Type"
-
-          within ".questionnaire-question-answer-options-list" do
-            expect(page).to have_no_button("Remove")
-          end
-
-          click_button "Add answer option"
-
-          expect(page.all(".questionnaire-question-answer-option")).to all(have_button("Remove"))
-
-          within ".questionnaire-question-answer-option:first-of-type" do
-            click_button "Remove"
-          end
-
-          within ".questionnaire-question-answer-options-list" do
-            expect(page).to have_no_button("Remove")
-          end
-        end
-
-        click_button "Save"
-
-        within ".questionnaire-question:last-of-type" do
-          within ".questionnaire-question-answer-options-list" do
-            expect(page).to have_no_button("Remove")
-          end
-        end
-      end
-
-      private
-
-      def look_like_first_question
-        have_no_button("Up").and have_button("Down")
-      end
-
-      def look_like_intermediate_question
-        have_button("Up").and have_button("Down")
-      end
-
-      def look_like_last_question
-        have_button("Up").and have_no_button("Down")
-      end
-    end
+    it_behaves_like "add questions"
+    it_behaves_like "update questions"
+    it_behaves_like "add display conditions"
+    it_behaves_like "update display conditions"
   end
 
   context "when the questionnaire is already answered" do
@@ -621,6 +57,9 @@ shared_examples_for "manage questionnaires" do
 
       expect(page).to have_no_content("Add question")
       expect(page).to have_no_content("Remove")
+
+      expand_all_questions
+
       expect(page).to have_selector("input[value='This is the first question'][disabled]")
       expect(page).to have_selector("select[id$=question_type][disabled]")
       expect(page).to have_selector("select[id$=max_choices][disabled]")
@@ -630,11 +69,11 @@ shared_examples_for "manage questionnaires" do
 
   private
 
-  def find_nested_form_field_locator(attribute, visible: true)
+  def find_nested_form_field_locator(attribute, visible: :visible)
     find_nested_form_field(attribute, visible: visible)["id"]
   end
 
-  def find_nested_form_field(attribute, visible: true)
+  def find_nested_form_field(attribute, visible: :visible)
     current_scope.find(nested_form_field_selector(attribute), visible: visible)
   end
 
@@ -649,4 +88,23 @@ shared_examples_for "manage questionnaires" do
   def nested_form_field_selector(attribute)
     "[id$=#{attribute}]"
   end
+
+  def within_add_display_condition
+    within ".questionnaire-question:last-of-type" do
+      click_button "Add display condition"
+
+      within ".questionnaire-question-display-condition:last-of-type" do
+        yield
+      end
+    end
+  end
+
+  def expand_all_questions
+    find(".button.expand-all").click
+  end
+
+  def visit_questionnaire_edit_path_and_expand_all
+    visit questionnaire_edit_path
+    expand_all_questions
+  end
 end