decidim-forms 0.19.0 → 0.22.0

data/config/locales/sl.yml

@@ -0,0 +1,5 @@
+sl:
+  activemodel:
+    attributes:
+      answer:
+        body: Odgovor

data/config/locales/sr-CS.yml

@@ -0,0 +1 @@
+sr:

data/config/locales/sv.yml

@@ -15,6 +15,8 @@ sv:
             choices:
               missing: är inte fullständiga
               too_many: är för många
+        questionnaire:
+          request_invalid: Ett fel uppstod när begäran skulle hanteras. Försök igen
   decidim:
     forms:
       admin:
@@ -30,27 +32,52 @@ sv:
             statement: Påstående
           edit:
             save: Spara
-            title: Titel
+            title: Redigera frågeformulär
           form:
             add_question: Lägg till fråga
+            add_separator: Lägg till separator
             already_answered_warning: Frågeformuläret har redan besvarats av vissa användare så du inte kan ändra dess frågor.
+            collapse: Komprimera alla frågor
+            expand: Expandera alla frågor
+          matrix_row:
+            matrix_row: Rad
+            remove: Ta bort
+            statement: Påstående
           question:
             add_answer_option: Lägg till svarsalternativ
+            add_matrix_row: Lägg till rad
             any: Någon
+            collapse: Komprimera
             description: Beskrivning
             down: Ned
+            expand: Expandera
             question: Fråga
             remove: Ta bort
             statement: Påstående
             up: Upp
+          separator:
+            down: Ner
+            remove: Radera
+            separator: Avgränsare
+            up: Upp
           update:
             invalid: Det gick inte att spara formuläret.
             success: Formuläret har sparats.
       errors:
         answer:
           body: Kroppen kan inte vara to
+      files:
+        extension_whitelist: 'Godkända format:'
+      images:
+        dimensions: "%{width} x %{height} px"
+        dimensions_info: 'Denna bild kommer att vara:'
+        processors:
+          resize_and_pad: Anpassad och vadderad till
+          resize_to_fit: Anpassad för att passa
       question_types:
         long_answer: Långt svar
+        matrix_multiple: Matris (flera alternativ)
+        matrix_single: Matris (Single alternativ)
         multiple_option: Flera alternativ
         short_answer: Kort svar
         single_option: Ett alternativ
@@ -58,6 +85,7 @@ sv:
       questionnaires:
         answer:
           invalid: Det gick inte att besvara formuläret.
+          max_choices_alert: Det finns för många val valda
           success: Formuläret har besvarats.
         question:
           max_choices: 'Högst antal val: %{n}'
@@ -65,7 +93,8 @@ sv:
           answer_questionnaire:
             anonymous_user_message: <a href="%{sign_in_link}">Logga in med ditt konto</a> eller <a href="%{sign_up_link}">registrera dig</a> om du vill svara på formuläret.
             title: Besvara formuläret
-          are_you_sure: Den här åtgärden kan inte ångras och du kommer inte att kunna redigera dina svar. Är du säker?
+          current_step: Steg %{step}
+          of_total_steps: av %{total_steps}
           questionnaire_answered:
             body: Du har redan besvarat det här formuläret.
             title: Redan svarat
@@ -75,8 +104,17 @@ sv:
           questionnaire_for_private_users:
             body: Formuläret är endast tillgängligt för privata användare
             title: Formuläret är stängt
-          submit: Skicka in
           tos_agreement: Genom att delta godkänner du användarvillkoren
+      step_navigation:
+        show:
+          are_you_sure: Den här åtgärden kan inte ångras och du kommer inte att kunna redigera dina svar. Är du säker?
+          back: Tillbaka
+          continue: Fortsätt
+          submit: Skicka in
       user_answers_serializer:
         created_at: Besvarad
         id: Svars-ID
+        ip_hash: Ip-hash
+        registered: Registrerad
+        unregistered: Ej registrerad
+        user_status: Användarstatus

data/config/locales/tr-TR.yml

@@ -30,10 +30,12 @@ tr:
             statement: Beyan
           edit:
             save: Kayıt etmek
-            title: Başlık
           form:
             add_question: Soru ekle
             already_answered_warning: Form, bazı kullanıcılar tarafından zaten yanıtlandı, bu nedenle sorularını değiştiremezsiniz.
+          matrix_row:
+            remove: Kaldır
+            statement: Beyan
           question:
             add_answer_option: Cevap seçeneği ekle
             any: herhangi
@@ -65,7 +67,6 @@ tr:
           answer_questionnaire:
             anonymous_user_message: <a href="%{sign_in_link}">Formu yanıtlamak için</a> veya <a href="%{sign_up_link}">hesabınızla giriş yapın</a>.
             title: Formu cevapla
-          are_you_sure: Bu işlem geri alınamaz ve cevaplarınızı düzenleyemezsiniz. Emin misiniz?
           questionnaire_answered:
             body: Bu formu zaten cevapladınız.
             title: Zaten cevaplandı
@@ -75,8 +76,11 @@ tr:
           questionnaire_for_private_users:
             body: Form yalnızca özel kullanıcılar tarafından kullanılabilir
             title: Form kapatıldı
-          submit: Gönder
           tos_agreement: Katılarak Hizmet Şartlarını kabul etmiş olursunuz.
+      step_navigation:
+        show:
+          are_you_sure: Bu işlem geri alınamaz ve cevaplarınızı düzenleyemezsiniz. Emin misiniz?
+          submit: Gönder
       user_answers_serializer:
         created_at: Yanıtlandı
         id: Cevap kimliği

data/db/migrate/20190315203056_add_session_token_to_decidim_forms_answers.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class AddSessionTokenToDecidimFormsAnswers < ActiveRecord::Migration[5.2]
+  class Answer < ApplicationRecord
+    self.table_name = :decidim_forms_answers
+  end
+
+  def change
+    add_column :decidim_forms_answers, :session_token, :string, null: false, default: ""
+    add_index :decidim_forms_answers, :session_token
+
+    Answer.find_each do |answer|
+      answer.session_token = Digest::MD5.hexdigest("#{answer.decidim_user_id}-#{Rails.application.secrets.secret_key_base}")
+      answer.save!
+    end
+  end
+end

data/db/migrate/20190930094710_add_ip_hash_to_decidim_form_answers.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class AddIpHashToDecidimFormAnswers < ActiveRecord::Migration[5.2]
+  class Answer < ApplicationRecord
+    self.table_name = :decidim_forms_answers
+  end
+
+  def change
+    add_column :decidim_forms_answers, :ip_hash, :string
+    add_index :decidim_forms_answers, :ip_hash
+  end
+end

data/db/migrate/20200225123810_create_decidim_forms_question_matrix_rows.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class CreateDecidimFormsQuestionMatrixRows < ActiveRecord::Migration[5.2]
+  def change
+    create_table :decidim_forms_question_matrix_rows do |t|
+      t.references :decidim_question, index: { name: "index_decidim_forms_question_matrix_questionnaire_id" }
+      t.integer :position, index: true
+      t.jsonb :body
+    end
+  end
+end

data/db/migrate/20200304152939_add_matrix_row_id_to_decidim_forms_answer_choices.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class AddMatrixRowIdToDecidimFormsAnswerChoices < ActiveRecord::Migration[5.2]
+  class AnswerChoice < ApplicationRecord
+    self.table_name = :decidim_forms_answer_choices
+  end
+
+  def change
+    add_column :decidim_forms_answer_choices, :decidim_question_matrix_row_id, :integer
+  end
+end

data/lib/decidim/api/questionnaire_entity_interface.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Forms
+    # This interface should be implemented by any Type that can be linked to a questionnaire
+    # The only requirement is to have an ID and the Type name be the class.name + Type
+    QuestionnaireEntityInterface = GraphQL::InterfaceType.define do
+      name "QuestionnaireEntityInterface"
+      description "An interface that can be used in objects with questionnaires"
+
+      field :id, !types.ID, "ID of this entity"
+
+      resolve_type ->(obj, _ctx) {
+        "#{obj.class.name}Type".constantize
+      }
+    end
+  end
+end

data/lib/decidim/forms.rb

@@ -3,6 +3,7 @@
 require "decidim/forms/admin"
 require "decidim/forms/engine"
 require "decidim/forms/admin_engine"
+require "decidim/forms/api"
 
 module Decidim
   # This namespace holds the logic of the `Forms`.

data/lib/decidim/forms/api.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Forms
+    autoload :QuestionnaireEntityInterface, "decidim/api/questionnaire_entity_interface"
+  end
+end

data/lib/decidim/forms/test/factories.rb

@@ -4,7 +4,7 @@ require "decidim/core/test/factories"
 require "decidim/participatory_processes/test/factories"
 
 FactoryBot.define do
-  factory :questionnaire, class: Decidim::Forms::Questionnaire do
+  factory :questionnaire, class: "Decidim::Forms::Questionnaire" do
     title { generate_localized_title }
     description do
       Decidim::Faker::Localized.wrapped("<p>", "</p>") do
@@ -13,43 +13,87 @@ FactoryBot.define do
     end
     tos { generate_localized_title }
     questionnaire_for { build(:participatory_process) }
+
+    trait :with_questions do
+      questions do
+        qs = %w(short_answer long_answer).collect do |text_question_type|
+          build(:questionnaire_question, question_type: text_question_type)
+        end
+        qs << build(:questionnaire_question, :with_answer_options, question_type: :single_option)
+        qs
+      end
+    end
   end
 
-  factory :questionnaire_question, class: Decidim::Forms::Question do
+  factory :questionnaire_question, class: "Decidim::Forms::Question" do
     transient do
-      answer_options { [] }
+      options { [] }
+      rows { [] }
     end
 
     body { generate_localized_title }
+    description do
+      Decidim::Faker::Localized.wrapped("<p>", "</p>") do
+        generate_localized_title
+      end
+    end
     mandatory { false }
     position { 0 }
     question_type { Decidim::Forms::Question::TYPES.first }
     questionnaire
 
     before(:create) do |question, evaluator|
-      evaluator.answer_options.each do |answer_option|
-        question.answer_options.build(
-          body: answer_option["body"],
-          free_text: answer_option["free_text"]
-        )
+      if question.answer_options.empty?
+        evaluator.options.each do |option|
+          question.answer_options.build(
+            body: option["body"],
+            free_text: option["free_text"]
+          )
+        end
+      end
+
+      if question.matrix_rows.empty?
+        evaluator.rows.each do |row|
+          question.matrix_rows.build(
+            body: row["body"]
+          )
+        end
       end
     end
+
+    trait :with_answer_options do
+      answer_options do
+        Array.new(3).collect { build(:answer_option) }
+      end
+    end
+
+    trait :separator do
+      question_type { :separator }
+    end
   end
 
-  factory :answer, class: Decidim::Forms::Answer do
+  factory :answer, class: "Decidim::Forms::Answer" do
     body { "hola" }
     questionnaire
     question { create(:questionnaire_question, questionnaire: questionnaire) }
     user { create(:user, organization: questionnaire.questionnaire_for.organization) }
   end
 
-  factory :answer_option, class: Decidim::Forms::AnswerOption do
+  factory :answer_option, class: "Decidim::Forms::AnswerOption" do
     question { create(:questionnaire_question) }
     body { generate_localized_title }
+    free_text { false }
   end
 
-  factory :answer_choice, class: Decidim::Forms::AnswerChoice do
+  factory :answer_choice, class: "Decidim::Forms::AnswerChoice" do
     answer
     answer_option { create(:answer_option, question: answer.question) }
+    matrix_row { create(:question_matrix_row, question: answer.question) }
+  end
+
+  factory :question_matrix_row, class: "Decidim::Forms::QuestionMatrixRow" do
+    question { create(:questionnaire_question) }
+    body { generate_localized_title }
+    position { 0 }
   end
 end

data/lib/decidim/forms/test/shared_examples/has_questionnaire.rb

@@ -35,7 +35,9 @@ shared_examples_for "has questionnaire" do
 
       check "questionnaire_tos_agreement"
 
-      accept_confirm { click_button "Submit" }
+      accept_confirm do
+        click_button "Submit"
+      end
 
       within ".success.flash" do
         expect(page).to have_content("successfully")
@@ -47,6 +49,73 @@ shared_examples_for "has questionnaire" do
       expect(page).to have_no_i18n_content(question.body)
     end
 
+    context "with multiple steps" do
+      let!(:separator) { create(:questionnaire_question, questionnaire: questionnaire, position: 1, question_type: :separator) }
+      let!(:question2) { create(:questionnaire_question, questionnaire: questionnaire, position: 2) }
+
+      before do
+        visit questionnaire_public_path
+      end
+
+      it "allows answering the first questionnaire" do
+        expect(page).to have_content("STEP 1 OF 2")
+
+        within ".answer-questionnaire__submit" do
+          expect(page).to have_no_content("Back")
+        end
+
+        answer_first_questionnaire
+
+        expect(page).to have_no_selector(".success.flash")
+      end
+
+      it "allows revisiting previously-answered questionnaires with my answers" do
+        answer_first_questionnaire
+
+        click_link "Back"
+
+        expect(page).to have_content("STEP 1 OF 2")
+        expect(page).to have_field("questionnaire_answers_0", with: "My first answer")
+      end
+
+      it "finishes the submission when answering the last questionnaire" do
+        answer_first_questionnaire
+
+        check "questionnaire_tos_agreement"
+        accept_confirm { click_button "Submit" }
+
+        within ".success.flash" do
+          expect(page).to have_content("successfully")
+        end
+
+        visit questionnaire_public_path
+
+        expect(page).to have_content("You have already answered this form.")
+      end
+
+      def answer_first_questionnaire
+        expect(page).to have_no_selector("#questionnaire_tos_agreement")
+
+        fill_in question.body["en"], with: "My first answer"
+        within ".answer-questionnaire__submit" do
+          click_link "Continue"
+        end
+        expect(page).to have_content("STEP 2 OF 2")
+      end
+    end
+
+    it "requires confirmation when exiting mid-answering" do
+      visit questionnaire_public_path
+
+      fill_in question.body["en"], with: "My first answer"
+
+      dismiss_page_unload do
+        page.find(".logo-wrapper a").click
+      end
+
+      expect(page).to have_current_path questionnaire_public_path
+    end
+
     context "when the questionnaire has already been answered by someone else" do
       let!(:question) do
         create(
@@ -54,7 +123,7 @@ shared_examples_for "has questionnaire" do
           questionnaire: questionnaire,
           question_type: "single_option",
           position: 0,
-          answer_options: [
+          options: [
             { "body" => Decidim::Faker::Localized.sentence },
             { "body" => Decidim::Faker::Localized.sentence }
           ]
@@ -163,7 +232,7 @@ shared_examples_for "has questionnaire" do
           question_type: "single_option",
           position: 0,
           mandatory: true,
-          answer_options: [
+          options: [
             { "body" => Decidim::Faker::Localized.sentence },
             { "body" => Decidim::Faker::Localized.sentence }
           ]
@@ -205,7 +274,8 @@ shared_examples_for "has questionnaire" do
           :questionnaire_question,
           questionnaire: questionnaire,
           question_type: question_type,
-          answer_options: [
+          position: 1,
+          options: [
             { "body" => answer_option_bodies[0] },
             { "body" => answer_option_bodies[1] },
             { "body" => answer_option_bodies[2], "free_text" => true }
@@ -219,7 +289,8 @@ shared_examples_for "has questionnaire" do
           questionnaire: questionnaire,
           question_type: "multiple_option",
           max_choices: 2,
-          answer_options: [
+          position: 2,
+          options: [
             { "body" => Decidim::Faker::Localized.sentence },
             { "body" => Decidim::Faker::Localized.sentence },
             { "body" => Decidim::Faker::Localized.sentence }
@@ -283,16 +354,16 @@ shared_examples_for "has questionnaire" do
         it "renders them as check boxes with attached text fields disabled by default" do
           expect(page.first(".check-box-collection")).to have_selector("input[type=checkbox]", count: 3)
 
-          expect(page).to have_field("questionnaire_answers_0_choices_2_custom_body", disabled: true, count: 1)
+          expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", disabled: true, count: 1)
 
           check answer_option_bodies[2]["en"]
 
-          expect(page).to have_field("questionnaire_answers_0_choices_2_custom_body", disabled: false, count: 1)
+          expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", disabled: false, count: 1)
         end
 
         it "saves the free text in a separate field if submission correct" do
           check answer_option_bodies[2]["en"]
-          fill_in "questionnaire_answers_0_choices_2_custom_body", with: "Cacatua"
+          fill_in "questionnaire_responses_0_choices_2_custom_body", with: "Cacatua"
 
           check "questionnaire_tos_agreement"
           accept_confirm { click_button "Submit" }
@@ -305,12 +376,12 @@ shared_examples_for "has questionnaire" do
         end
 
         it "preserves the previous custom body if submission not correct" do
-          check "questionnaire_answers_1_choices_0_body"
-          check "questionnaire_answers_1_choices_1_body"
-          check "questionnaire_answers_1_choices_2_body"
+          check "questionnaire_responses_1_choices_0_body"
+          check "questionnaire_responses_1_choices_1_body"
+          check "questionnaire_responses_1_choices_2_body"
 
           check answer_option_bodies[2]["en"]
-          fill_in "questionnaire_answers_0_choices_2_custom_body", with: "Cacatua"
+          fill_in "questionnaire_responses_0_choices_2_custom_body", with: "Cacatua"
 
           check "questionnaire_tos_agreement"
           accept_confirm { click_button "Submit" }
@@ -319,7 +390,7 @@ shared_examples_for "has questionnaire" do
             expect(page).to have_content("There was a problem answering")
           end
 
-          expect(page).to have_field("questionnaire_answers_0_choices_2_custom_body", with: "Cacatua")
+          expect(page).to have_field("questionnaire_responses_0_choices_2_custom_body", with: "Cacatua")
         end
       end
     end
@@ -346,7 +417,7 @@ shared_examples_for "has questionnaire" do
 
     context "when question type is single option" do
       let(:answer_options) { Array.new(2) { { "body" => Decidim::Faker::Localized.sentence } } }
-      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, question_type: "single_option", answer_options: answer_options) }
+      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, question_type: "single_option", options: answer_options) }
 
       it "renders answers as a collection of radio buttons" do
         visit questionnaire_public_path
@@ -372,7 +443,7 @@ shared_examples_for "has questionnaire" do
 
     context "when question type is multiple option" do
       let(:answer_options) { Array.new(3) { { "body" => Decidim::Faker::Localized.sentence } } }
-      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, question_type: "multiple_option", answer_options: answer_options) }
+      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, question_type: "multiple_option", options: answer_options) }
 
       it "renders answers as a collection of radio buttons" do
         visit questionnaire_public_path
@@ -409,6 +480,8 @@ shared_examples_for "has questionnaire" do
         check answer_options[1]["body"][:en]
         check answer_options[2]["body"][:en]
 
+        expect(page).to have_content("too many choices")
+
         check "questionnaire_tos_agreement"
 
         accept_confirm { click_button "Submit" }
@@ -429,40 +502,13 @@ shared_examples_for "has questionnaire" do
       end
     end
 
-    context "when question type is multiple option" do
-      let(:answer_options) { Array.new(2) { { "body" => Decidim::Faker::Localized.sentence } } }
-      let!(:question) { create(:questionnaire_question, questionnaire: questionnaire, question_type: "multiple_option", answer_options: answer_options) }
-
-      it "renders the question answers as a collection of radio buttons" do
-        visit questionnaire_public_path
-
-        expect(page).to have_selector(".check-box-collection input[type=checkbox]", count: 2)
-
-        check answer_options[0]["body"][:en]
-        check answer_options[1]["body"][:en]
-
-        check "questionnaire_tos_agreement"
-
-        accept_confirm { click_button "Submit" }
-
-        within ".success.flash" do
-          expect(page).to have_content("successfully")
-        end
-
-        visit questionnaire_public_path
-
-        expect(page).to have_content("You have already answered this form.")
-        expect(page).to have_no_i18n_content(question.body)
-      end
-    end
-
     context "when question type is sorting" do
       let!(:question) do
         create(
           :questionnaire_question,
           questionnaire: questionnaire,
           question_type: "sorting",
-          answer_options: [
+          options: [
             { "body" => "idiotas" },
             { "body" => "trates" },
             { "body" => "No" },
@@ -524,5 +570,236 @@ shared_examples_for "has questionnaire" do
         expect(page).to have_content("are not complete")
       end
     end
+
+    context "when question type is matrix_single" do
+      let(:matrix_rows) { Array.new(2) { { "body" => Decidim::Faker::Localized.sentence } } }
+      let(:answer_options) { Array.new(2) { { "body" => Decidim::Faker::Localized.sentence } } }
+      let(:mandatory) { false }
+
+      let!(:question) do
+        create(
+          :questionnaire_question,
+          questionnaire: questionnaire,
+          question_type: "matrix_single",
+          rows: matrix_rows,
+          options: answer_options,
+          mandatory: mandatory
+        )
+      end
+
+      it "renders the question answers as a collection of radio buttons" do
+        visit questionnaire_public_path
+
+        expect(page).to have_selector(".radio-button-collection input[type=radio]", count: 4)
+
+        expect(page).to have_content(matrix_rows.map { |row| row["body"]["en"] }.join("\n"))
+        expect(page).to have_content(answer_options.map { |option| option["body"]["en"] }.join(" "))
+
+        radio_buttons = page.all(".radio-button-collection input[type=radio]")
+
+        choose radio_buttons.first[:id]
+        choose radio_buttons.last[:id]
+
+        check "questionnaire_tos_agreement"
+
+        accept_confirm { click_button "Submit" }
+
+        within ".success.flash" do
+          expect(page).to have_content("successfully")
+        end
+
+        visit questionnaire_public_path
+
+        expect(page).to have_content("You have already answered this form.")
+        expect(page).to have_no_i18n_content(question.body)
+
+        first_choice, last_choice = Decidim::Forms::Answer.last.choices.pluck(:decidim_answer_option_id, :decidim_question_matrix_row_id)
+
+        expect(first_choice).to eq([question.answer_options.first.id, question.matrix_rows.first.id])
+        expect(last_choice).to eq([question.answer_options.last.id, question.matrix_rows.last.id])
+      end
+
+      it "preserves the chosen answers if submission not correct" do
+        visit questionnaire_public_path
+
+        radio_buttons = page.all(".radio-button-collection input[type=radio]")
+        choose radio_buttons[1][:id]
+
+        accept_confirm { click_button "Submit" }
+
+        within ".alert.flash" do
+          expect(page).to have_content("There was a problem answering")
+        end
+
+        radio_buttons = page.all(".radio-button-collection input[type=radio]")
+        expect(radio_buttons.map { |b| b[:checked] }).to eq([nil, "true", nil, nil])
+      end
+
+      context "when the question is mandatory and the answer is not complete" do
+        let!(:mandatory) { true }
+
+        it "shows an error if the question is mandatory and the answer is not complete" do
+          visit questionnaire_public_path
+
+          radio_buttons = page.all(".radio-button-collection input[type=radio]")
+          choose radio_buttons[0][:id]
+
+          check "questionnaire_tos_agreement"
+          accept_confirm { click_button "Submit" }
+
+          within ".alert.flash" do
+            expect(page).to have_content("There was a problem answering")
+          end
+
+          expect(page).to have_content("Choices are not complete")
+        end
+      end
+    end
+
+    context "when question type is matrix_multiple" do
+      let(:matrix_rows) { Array.new(2) { { "body" => Decidim::Faker::Localized.sentence } } }
+      let(:answer_options) { Array.new(3) { { "body" => Decidim::Faker::Localized.sentence } } }
+      let(:max_choices) { nil }
+      let(:mandatory) { false }
+
+      let!(:question) do
+        create(
+          :questionnaire_question,
+          questionnaire: questionnaire,
+          question_type: "matrix_multiple",
+          rows: matrix_rows,
+          options: answer_options,
+          max_choices: max_choices,
+          mandatory: mandatory
+        )
+      end
+
+      it "renders the question answers as a collection of check boxes" do
+        visit questionnaire_public_path
+
+        expect(page).to have_selector(".check-box-collection input[type=checkbox]", count: 6)
+
+        expect(page).to have_content(matrix_rows.map { |row| row["body"]["en"] }.join("\n"))
+        expect(page).to have_content(answer_options.map { |option| option["body"]["en"] }.join(" "))
+
+        checkboxes = page.all(".check-box-collection input[type=checkbox]")
+
+        check checkboxes[0][:id]
+        check checkboxes[1][:id]
+        check checkboxes[3][:id]
+
+        check "questionnaire_tos_agreement"
+
+        accept_confirm { click_button "Submit" }
+
+        within ".success.flash" do
+          expect(page).to have_content("successfully")
+        end
+
+        visit questionnaire_public_path
+
+        expect(page).to have_content("You have already answered this form.")
+        expect(page).to have_no_i18n_content(question.body)
+
+        first_choice, second_choice, third_choice = Decidim::Forms::Answer.last.choices.pluck(:decidim_answer_option_id, :decidim_question_matrix_row_id)
+
+        expect(first_choice).to eq([question.answer_options.first.id, question.matrix_rows.first.id])
+        expect(second_choice).to eq([question.answer_options.second.id, question.matrix_rows.first.id])
+        expect(third_choice).to eq([question.answer_options.first.id, question.matrix_rows.last.id])
+      end
+
+      context "when the question hax max_choices defined" do
+        let!(:max_choices) { 2 }
+
+        it "respects the max number of choices" do
+          visit questionnaire_public_path
+
+          expect(page).to have_content("Max choices: 2")
+
+          checkboxes = page.all(".check-box-collection input[type=checkbox]")
+
+          check checkboxes[0][:id]
+          check checkboxes[1][:id]
+          check checkboxes[2][:id]
+
+          expect(page).to have_content("too many choices")
+
+          check checkboxes[3][:id]
+          check checkboxes[4][:id]
+
+          expect(page).to have_content("too many choices")
+
+          check checkboxes[5][:id]
+
+          uncheck checkboxes[0][:id]
+
+          expect(page).to have_content("too many choices")
+
+          check "questionnaire_tos_agreement"
+
+          accept_confirm { click_button "Submit" }
+
+          within ".alert.flash" do
+            expect(page).to have_content("There was a problem answering")
+          end
+
+          expect(page).to have_content("are too many")
+
+          checkboxes = page.all(".check-box-collection input[type=checkbox]")
+
+          uncheck checkboxes[5][:id]
+
+          accept_confirm { click_button "Submit" }
+
+          within ".success.flash" do
+            expect(page).to have_content("successfully")
+          end
+        end
+      end
+
+      context "when the submission is not correct" do
+        let!(:max_choices) { 2 }
+
+        it "preserves the chosen answers" do
+          visit questionnaire_public_path
+
+          checkboxes = page.all(".check-box-collection input[type=checkbox]")
+          check checkboxes[0][:id]
+          check checkboxes[1][:id]
+          check checkboxes[2][:id]
+          check checkboxes[5][:id]
+
+          check "questionnaire_tos_agreement"
+          accept_confirm { click_button "Submit" }
+
+          within ".alert.flash" do
+            expect(page).to have_content("There was a problem answering")
+          end
+
+          checkboxes = page.all(".check-box-collection input[type=checkbox]")
+          expect(checkboxes.map { |c| c[:checked] }).to eq(["true", "true", "true", nil, nil, "true"])
+        end
+      end
+
+      context "when the question is mandatory and the answer is not complete" do
+        let!(:mandatory) { true }
+
+        it "shows an error" do
+          visit questionnaire_public_path
+
+          checkboxes = page.all(".check-box-collection input[type=checkbox]")
+          check checkboxes[0][:id]
+
+          check "questionnaire_tos_agreement"
+          accept_confirm { click_button "Submit" }
+
+          within ".alert.flash" do
+            expect(page).to have_content("There was a problem answering")
+          end
+
+          expect(page).to have_content("Choices are not complete")
+        end
+      end
+    end
   end
 end