decidim-direct_verifications 0.17.8 → 0.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4928cec1e6b6d4f5e09fd2235e38b4e7a0fe411dc4be792a25d5bff2a8ef5b6
-  data.tar.gz: 978ba2b8a55151a524643df8268e2f0435f329edc46acad48c3fe463f5382150
+  metadata.gz: f9f466181031acf9fe03bd55ef1f1ae1e407707acc0b22a639576523eebe90ae
+  data.tar.gz: 3071bc96c9e22c9ca06ce14f3ce81b1280a54dcb3a4478abb0ef02531c2f6c23
 SHA512:
-  metadata.gz: f9435b6e219c4c49c2d19899fe7482524ca101545f9099dd2b09a7a7c33a0d662ce0b60dace84582912b1e91c8969843b2263404e4730c31043908da455f345a
-  data.tar.gz: 42dc907a3fd1bfc59194a31007c6ed083a5b5610790bde8f32a50ef83ee5fed8ed8e4a215adb8586bb7e1e096a9244e5aa48c0a0973b0d1afce1f409ddc9cd3d
+  metadata.gz: 490468f076bdc3f270d8f853f0c809bc6aac17f989d4984538550107e963fab25b52ae5bb30ed76856747e67740976dc3a027d49b0f916a339565b409f606751
+  data.tar.gz: 8e9b5c8d40c075d34e41f3711d9c5740e0ecc62bd916ec6d3a4b9afa80855d1ca1c260a13eda183feca9aefa2066b5682ba9e0a80c300a36844cab79b53896d0

data/README.md

@@ -1,6 +1,9 @@
 # Decidim::DirectVerifications
 
-[![Build Status](https://travis-ci.org/Platoniq/decidim-verifications-direct_verifications.svg?branch=master)](https://travis-ci.org/Platoniq/decidim-verifications-direct_verifications)
+![[CI] Test](https://github.com/Platoniq/decidim-verifications-direct_verifications/workflows/%5BCI%5D%20Test/badge.svg)
+[![Maintainability](https://api.codeclimate.com/v1/badges/2195deb4de6c6354a6bc/maintainability)](https://codeclimate.com/github/Platoniq/decidim-verifications-direct_verifications/maintainability)
+[![Test Coverage](https://api.codeclimate.com/v1/badges/2195deb4de6c6354a6bc/test_coverage)](https://codeclimate.com/github/Platoniq/decidim-verifications-direct_verifications/test_coverage)
+
 
 A [Decidim](https://github.com/decidim/decidim) that provides a verification method called `Direct verification`. Works only on the admin side, final users do not intervene in the verification process.
 
@@ -84,6 +87,11 @@ en:
       direct_verifications_managers:
         name: Organization managers
         explanation: Direct Verifications Subgroup explanation
+    verifications:
+      authorizations:
+        first_login:
+          actions:
+            direct_verifications_managers: Organization managers
 ```
 
 Similarly, you can also overwrite the default title "Direct verification" by creating the key again in your locales:
@@ -95,6 +103,11 @@ en:
       direct_verifications:
         name: Generic organization members
         explanation: Direct Verifications Subgroup explanation
+    verifications:
+      authorizations:
+        first_login:
+          actions:
+            direct_verifications: Generic organization members
 ```
 
 

data/app/controllers/decidim/direct_verifications/verification/admin/direct_verifications_controller.rb

@@ -75,6 +75,7 @@ module Decidim
 
           def configured_workflows
             return Decidim::DirectVerifications.config.manage_workflows if Decidim::DirectVerifications.config
+
             ["direct_verifications"]
           end
 

data/config/locales/ca.yml

@@ -59,6 +59,11 @@ ca:
         authorizations:
           new:
             no_action: Aquest mètode requereix que un administrador us verifiqui
+    verifications:
+      authorizations:
+        first_login:
+          actions:
+            direct_verifications: Verificació directa
   devise:
     mailer:
       direct_invite:

data/config/locales/en.yml

@@ -57,6 +57,11 @@ en:
         authorizations:
           new:
             no_action: This method requires an administrator that verifies you
+    verifications:
+      authorizations:
+        first_login:
+          actions:
+            direct_verifications: Direct verification
   devise:
     mailer:
       direct_invite:

data/config/locales/es.yml

@@ -59,6 +59,11 @@ es:
         authorizations:
           new:
             no_action: Este método requiere que un administrador os verifique
+    verifications:
+      authorizations:
+        first_login:
+          actions:
+            direct_verifications: Verificación directa
   devise:
     mailer:
       direct_invite:

data/lib/decidim/direct_verifications/tests/verification_controller_examples.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+shared_examples_for "checking users" do |params|
+  context "when check without mails" do
+    it "renders the index with info message" do
+      params[:userlist] = ""
+      post :create, params: params
+      expect(flash[:info]).not_to be_empty
+      expect(flash[:info]).to include("0 users detected")
+      expect(subject).to render_template("decidim/direct_verifications/verification/admin/direct_verifications/index")
+    end
+  end
+
+  context "when check with mails" do
+    it "renders the index with info message" do
+      params[:userlist] = "mail@example.com"
+      post :create, params: params
+      expect(flash[:info]).not_to be_empty
+      expect(flash[:info]).to include("1 users detected")
+      expect(subject).to render_template("decidim/direct_verifications/verification/admin/direct_verifications/index")
+    end
+  end
+end
+
+shared_examples_for "registering users" do |params|
+  context "when send valid emails" do
+    it "creates warning message" do
+      post :create, params: params
+      expect(flash[:warning]).not_to be_empty
+      expect(flash[:warning]).to include("1 detected")
+      expect(flash[:warning]).to include("0 errors")
+      expect(flash[:warning]).to include("1 users")
+      expect(flash[:warning]).to include("registered")
+    end
+  end
+end
+
+shared_examples_for "authorizing users" do |params|
+  context "when send valid emails" do
+    it "creates notice message" do
+      post :create, params: params
+      expect(flash[:notice]).not_to be_empty
+      expect(flash[:notice]).to include("1 detected")
+      expect(flash[:notice]).to include("0 errors")
+      expect(flash[:notice]).to include("1 users")
+      expect(flash[:notice]).to include("verified")
+    end
+  end
+end
+
+shared_examples_for "revoking users" do |params|
+  context "when send valid emails" do
+    it "creates notice message" do
+      create(
+        :authorization,
+        :granted,
+        name: verification_type,
+        user: authorized_user
+      )
+      post :create, params: params
+      expect(flash[:notice]).not_to be_empty
+      expect(flash[:notice]).to include("1 detected")
+      expect(flash[:notice]).to include("0 errors")
+      expect(flash[:notice]).to include("1 users")
+      expect(flash[:notice]).to include("revoked")
+    end
+  end
+end

data/lib/decidim/direct_verifications/user_processor.rb

@@ -22,6 +22,7 @@ module Decidim
       def register_users
         @emails.each do |email, name|
           next if find_user(email)
+
           form = register_form(email, name)
           begin
             InviteUser.call(form) do
@@ -44,6 +45,7 @@ module Decidim
           if (u = find_user(email))
             auth = authorization(u)
             next unless !auth.granted? || auth.expired?
+
             Verification::ConfirmUserAuthorization.call(auth, authorize_form(u)) do
               on(:ok) do
                 add_processed :authorized, email
@@ -63,6 +65,7 @@ module Decidim
           if (u = find_user(email))
             auth = authorization(u)
             next unless auth.granted?
+
             Verification::DestroyUserAuthorization.call(auth) do
               on(:ok) do
                 add_processed :revoked, email

data/lib/decidim/direct_verifications/user_stats.rb

@@ -39,7 +39,7 @@ module Decidim
         if authorization_handler.empty?
           filter = { decidim_organization_id: organization.id }
           filter[:email] = emails unless emails.empty?
-          return User.where(filter).where.not(email: '')
+          return User.where(filter).where.not(email: "")
         end
         authorized_users(false)
       end
@@ -55,17 +55,20 @@ module Decidim
         end
         q = q.where("decidim_users.decidim_organization_id=:org and decidim_users.email!=''", org: organization.id)
         return q if emails.empty?
+
         q.where("decidim_users.email IN (:emails)", emails: emails)
       end
 
       def expires_in
         return unless workflow_manifest
         return if workflow_manifest.expires_in.zero?
+
         workflow_manifest.expires_in
       end
 
       def workflow_manifest
         return if authorization_handler.empty?
+
         @workflow_manifest ||= Decidim::Verifications.find_workflow_manifest(authorization_handler)
       end
     end

data/lib/decidim/direct_verifications/version.rb

@@ -3,7 +3,8 @@
 module Decidim
   # This holds the decidim-direct_verifications version.
   module DirectVerifications
-    VERSION = "0.17.8"
-    DECIDIM_VERSION = ">= 0.17.1"
+    VERSION = "0.20"
+    DECIDIM_VERSION = "0.20.0"
+    MIN_DECIDIM_VERSION = ">= 0.17.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: decidim-direct_verifications
 version: !ruby/object:Gem::Version
-  version: 0.17.8
+  version: '0.20'
 platform: ruby
 authors:
 - Ivan Vergés
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-12 00:00:00.000000000 Z
+date: 2020-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: decidim-admin
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.1
+        version: 0.17.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.1
+        version: 0.17.0
 - !ruby/object:Gem::Dependency
   name: decidim-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.1
+        version: 0.17.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.1
+        version: 0.17.0
 description: Provides a verification method that also registers users directly in
   the platform. Can be used to mass verificate user with other verification handlers
 email:
@@ -66,6 +66,7 @@ files:
 - config/locales/es.yml
 - lib/decidim/direct_verifications.rb
 - lib/decidim/direct_verifications/config.rb
+- lib/decidim/direct_verifications/tests/verification_controller_examples.rb
 - lib/decidim/direct_verifications/user_processor.rb
 - lib/decidim/direct_verifications/user_stats.rb
 - lib/decidim/direct_verifications/verification.rb