decidim-dev 0.30.1 → 0.31.0.rc1

data/config/rubocop/{rails.yml → rails/configuration.yml}

@@ -1,4 +1,4 @@
-require: rubocop-rails
+plugins: rubocop-rails
 
 Rails:
   Enabled: true
@@ -8,12 +8,6 @@ Rails/ActionFilter:
     - app/controllers/**/*.rb
     - decidim-*/app/controllers/**/*.rb
 
-Rails/ContentTag:
-  Enabled: false
-
-Rails/CreateTableWithTimestamps:
-  Enabled: false
-
 Rails/EnumUniqueness:
   Include:
     - app/models/**/*.rb
@@ -50,16 +44,11 @@ Rails/HasManyOrHasOneDependent:
     - app/models/**/*.rb
     - decidim-*/app/models/**/*.rb
 
-Rails/InverseOf:
-  Enabled: false
-
 Rails/LexicallyScopedActionFilter:
   Include:
     - app/controllers/**/*.rb
     - decidim-*/app/controllers/**/*.rb
 
-Rails/NotNullColumn:
-  Enabled: false
 
 Rails/Output:
   Include:
@@ -74,23 +63,11 @@ Rails/Output:
   Exclude:
     - "**/db/seeds.rb"
 
-Rails/OutputSafety:
-  Enabled: false
-
-Rails/Pluck:
-  Enabled: false
-
-Rails/RakeEnvironment:
-  Enabled: false
-
 Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb
     - decidim-*/app/models/**/*.rb
 
-Rails/ReversibleMigration:
-  Enabled: false
-
 Rails/ScopeArgs:
   Include:
     - app/models/**/*.rb

data/config/rubocop/rails/disabled.yml

@@ -0,0 +1,46 @@
+# Disabled rails configurations
+
+Rails/ContentTag:
+  Enabled: false
+
+Rails/CreateTableWithTimestamps:
+  Enabled: false
+
+Rails/InverseOf:
+  Enabled: false
+
+Rails/NotNullColumn:
+  Enabled: false
+
+Rails/OutputSafety:
+  Enabled: false
+
+Rails/Pluck:
+  Enabled: false
+
+Rails/RakeEnvironment:
+  Enabled: false
+
+Rails/ReversibleMigration:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: false
+
+Rails/ActionOrder:
+  Enabled: false
+
+Rails/Delegate:
+  Enabled: false
+
+Rails/HelperInstanceVariable:
+  Enabled: false
+
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: false
+
+Rails/EnumHash:
+  Enabled: false
+
+Rails/I18nLazyLookup:
+  Enabled: false

data/config/rubocop/{rspec.yml → rspec/configuration.yml}

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-rspec
   - rubocop-rspec_rails
 
@@ -26,7 +26,7 @@ RSpec/DescribeClass:
   Exclude:
     - spec/gemfiles_spec.rb
     - spec/gemspecs_spec.rb
-    - spec/webpacker_spec.rb
+    - spec/shakapacker_spec.rb
     - spec/version_files_spec.rb
     - spec/spellcheck_spec.rb
     - spec/i18n_spec.rb
@@ -36,44 +36,17 @@ RSpec/DescribeClass:
 RSpec/ExampleLength:
   Max: 49
 
-RSpec/ExpectInHook:
-  Enabled: false
-
 RSpec/IteratedExpectation:
   Enabled: true
 
-RSpec/LetSetup:
-  Enabled: false
-
-RSpec/MessageSpies:
-  Enabled: false
-
-RSpec/MultipleExpectations:
-  Enabled: false
-
 RSpec/MultipleMemoizedHelpers:
   Max: 35
 
 RSpec/NestedGroups:
   Max: 7
 
-RSpec/NamedSubject:
-  Enabled: false
-
 RSpec/RepeatedExampleGroupDescription:
   Enabled: true
 
 RSpec/RepeatedExampleGroupBody:
   Enabled: true
-
-RSpec/VerifiedDoubles:
-  Enabled: false
-
-RSpec/LeakyConstantDeclaration:
-  Enabled: false
-
-RSpec/DescribedClass:
-  Enabled: false
-
-RSpec/IndexedLet:
-  Enabled: false

data/config/rubocop/rspec/disabled.yml

@@ -0,0 +1,49 @@
+# Disabled rspec configurations
+
+RSpec/ExpectInHook:
+  Enabled: false
+
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/MessageSpies:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+RSpec/LeakyConstantDeclaration:
+  Enabled: false
+
+RSpec/DescribedClass:
+  Enabled: false
+
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpec/VerifiedDoubleReference:
+  Enabled: false
+
+RSpec/ExampleWording:
+  Enabled: false
+
+RSpec/ReceiveMessages:
+  Enabled: false
+
+RSpecRails/NegationBeValid:
+  Enabled: false
+
+RSpec/MetadataStyle:
+  Enabled: false
+
+RSpec/RemoveConst:
+  Enabled: false
+
+RSpec/IncludeExamples:
+  Enabled: false

data/config/rubocop/{ruby.yml → ruby/configuration.yml}

@@ -1,3 +1,5 @@
+require: rubocop
+
 # Common configuration.
 AllCops:
   Include:
@@ -176,7 +178,6 @@ Style/ArrayCoercion:
     with a variable you want to treat as an Array, but you are not certain it is an array.
   StyleGuide: '#array-coercion'
   Safe: false
-  Enabled: false
   VersionAdded: '0.88'
 
 Style/AndOr:
@@ -187,9 +188,6 @@ Style/AndOr:
     - always
     - conditionals
 
-Style/AsciiComments:
-  Enabled: false
-
 # Checks if usage of %() or %Q() matches configuration.
 Style/BarePercentLiterals:
   EnforcedStyle: bare_percent
@@ -268,12 +266,6 @@ Style/BlockDelimiters:
     - proc
     - it
 
-Style/ExplicitBlockArgument:
-  Enabled: false
-
-Style/HashEachMethods:
-  Enabled: false
-
 Style/HashLikeCase:
   MinBranchesCount: 5
 
@@ -290,7 +282,6 @@ Layout/CaseIndentation:
   IndentationWidth: ~
 
 Style/ClassAndModuleChildren:
-  Enabled: false
   # Checks the style of children definitions at classes and modules.
   #
   # Basically there are two different styles:
@@ -790,10 +781,7 @@ Style/PercentQLiterals:
     - lower_case_q # Use %q when possible, %Q when necessary
     - upper_case_q # Always use %Q
 
-Style/SlicingWithRange:
-  Enabled: false
-
-Naming/PredicateName:
+Naming/PredicatePrefix:
   # Predicate name prefixes.
   NamePrefix:
     - is_
@@ -820,9 +808,6 @@ Style/PreferredHashMethods:
 Style/DateTime:
   Enabled: true
 
-Style/Documentation:
-  Enabled: false
-
 Style/RaiseArgs:
   EnforcedStyle: exploded
   SupportedStyles:
@@ -847,9 +832,6 @@ Style/RegexpLiteral:
   # are found in the regexp string.
   AllowInnerSlashes: false
 
-Style/SafeNavigation:
-  Enabled: false
-
 Style/Semicolon:
   # Allow ; to separate several expressions on the same line.
   AllowAsExpressionSeparator: false
@@ -963,9 +945,6 @@ Layout/SpaceInsideStringInterpolation:
     - space
     - no_space
 
-Style/AccessModifierDeclarations:
-  Enabled: false
-
 Style/SymbolArray:
   EnforcedStyle: brackets
   SupportedStyles:
@@ -1089,10 +1068,6 @@ Metrics/AbcSize:
   # The ABC size is a calculated magnitude, so this number can be an Integer or
   # a Float.
   Max: 15
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: false
 
 Metrics/BlockNesting:
   Max: 3
@@ -1100,12 +1075,10 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   CountComments: false  # count full line comments?
   Max: 100
-  Enabled: false
 
 Metrics/ModuleLength:
   CountComments: false  # count full line comments?
   Max: 100
-  Enabled: false
 
 # Avoid complex methods.
 Metrics/CyclomaticComplexity:
@@ -1118,7 +1091,6 @@ Metrics/CyclomaticComplexity:
 Metrics/MethodLength:
   CountComments: false  # count full line comments?
   Max: 15
-  Enabled: false
 
 Metrics/ParameterLists:
   Max: 5
@@ -1141,13 +1113,6 @@ Lint/AmbiguousBlockAssociation:
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
-Lint/ConstantDefinitionInBlock:
-  Enabled: false
-
-# Call super to initialize state of the parent class.
-Lint/MissingSuper:
-  Enabled: false
-
 # checks whether the end keywords are aligned properly for `do` `end` blocks.
 Layout/BlockAlignment:
   # The value `start_of_block` means that the `end` should be aligned with line

data/config/rubocop/ruby/disabled.yml

@@ -0,0 +1,106 @@
+# Disabled rubocop configurations
+Style/OpenStructUse:
+  Enabled: false
+
+Gemspec/RequireMFA:
+  Enabled: false
+
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+Lint/SelfAssignment:
+  Enabled: false
+
+Style/ArrayCoercion:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/ExplicitBlockArgument:
+  Enabled: false
+
+Style/HashEachMethods:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/SlicingWithRange:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/SafeNavigation:
+  Enabled: false
+
+Style/AccessModifierDeclarations:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
+# Call super to initialize state of the parent class.
+Lint/MissingSuper:
+  Enabled: false
+
+Style/RedundantParentheses:
+  Enabled: false
+
+Naming/PredicateMethod:
+  Enabled: false
+
+Style/CollectionQuerying:
+  Enabled: false
+
+Lint/UselessAccessModifier:
+  Enabled: false
+
+Style/MultipleComparison:
+  Enabled: false
+
+Lint/CopDirectiveSyntax:
+  Enabled: false
+
+Lint/RedundantTypeConversion:
+  Enabled: false
+
+Lint/DuplicateMethods:
+  Enabled: false
+
+Lint/UselessConstantScoping:
+  Enabled: false
+
+Style/RedundantCondition:
+  Enabled: false
+
+Lint/Void:
+  Enabled: false
+
+Style/HashSlice:
+  Enabled: false
+
+Lint/UselessOr:
+  Enabled: false
+
+Style/EmptyStringInsideInterpolation:
+  Enabled: false
+
+Style/ComparableBetween:
+  Enabled: false

data/decidim-dev.gemspec

@@ -56,16 +56,16 @@ Gem::Specification.new do |s|
   s.add_dependency "rspec_junit_formatter", "~> 0.6.0"
   s.add_dependency "rspec-rails", "~> 6.0"
   s.add_dependency "rspec-retry", "~> 0.6.2"
-  s.add_dependency "rubocop", "~> 1.69.0"
-  s.add_dependency "rubocop-capybara", "~> 2.21"
-  s.add_dependency "rubocop-factory_bot", "~> 2.26"
-  s.add_dependency "rubocop-faker", "~> 1.1"
-  s.add_dependency "rubocop-graphql", "~> 1.5"
-  s.add_dependency "rubocop-performance", "~> 1.21"
-  s.add_dependency "rubocop-rails", "~> 2.25"
-  s.add_dependency "rubocop-rspec", "~> 3.0"
-  s.add_dependency "rubocop-rspec_rails", "~> 2.30"
-  s.add_dependency "rubocop-rubycw", "~> 0.1"
+  s.add_dependency "rubocop", "~> 1.78.0"
+  s.add_dependency "rubocop-capybara", "~> 2.22.0", ">= 2.22.1"
+  s.add_dependency "rubocop-factory_bot", "~> 2.27.0"
+  s.add_dependency "rubocop-faker", "~> 1.3", ">= 1.3.0"
+  s.add_dependency "rubocop-graphql", "~> 1.5", ">= 1.5.6"
+  s.add_dependency "rubocop-performance", "~> 1.25", ">= 1.25.0"
+  s.add_dependency "rubocop-rails", "~> 2.32.0", ">= 2.32.0"
+  s.add_dependency "rubocop-rspec", "~> 3.0", ">= 3.6.0"
+  s.add_dependency "rubocop-rspec_rails", "~> 2.31.0"
+  s.add_dependency "rubocop-rubycw", "~> 0.2.0"
   s.add_dependency "selenium-webdriver", "~> 4.9"
   s.add_dependency "simplecov", "~> 0.22.0"
   s.add_dependency "simplecov-cobertura", "~> 2.1.0"

data/lib/decidim/dev/assets/assemblies.json

@@ -2,7 +2,6 @@
   {
     "id": 1,
     "slug": "quae-a",
-    "hashtag": "id",
     "decidim_organization_id": 1,
     "title": {
       "ca": "Eius iure laborum hic et.",
@@ -653,7 +652,7 @@
                   "id": 9,
                   "decidim_questionnaire_id": 9,
                   "position": null,
-                  "question_type": "short_answer",
+                  "question_type": "short_response",
                   "mandatory": null,
                   "body": {
                     "ca": "Est incidunt ut. Et distinctio velit. Perferendis ratione qui.",
@@ -664,15 +663,13 @@
                   "max_choices": null,
                   "created_at": "2020-01-22T07:55:13.496Z",
                   "updated_at": "2020-01-22T07:55:13.496Z",
-                  "answer_options": [
-
-                  ]
+                  "response_options": []
                 },
                 {
                   "id": 10,
                   "decidim_questionnaire_id": 9,
                   "position": null,
-                  "question_type": "long_answer",
+                  "question_type": "long_response",
                   "mandatory": null,
                   "body": {
                     "ca": "Unde qui recusandae. Ab saepe praesentium. Quis velit et.",
@@ -683,9 +680,7 @@
                   "max_choices": null,
                   "created_at": "2020-01-22T07:55:13.507Z",
                   "updated_at": "2020-01-22T07:55:13.507Z",
-                  "answer_options": [
-
-                  ]
+                  "response_options": []
                 },
                 {
                   "id": 11,
@@ -702,7 +697,7 @@
                   "max_choices": null,
                   "created_at": "2020-01-22T07:55:13.520Z",
                   "updated_at": "2020-01-22T07:55:13.520Z",
-                  "answer_options": [
+                  "response_options": [
                     {
                       "id": 13,
                       "decidim_question_id": 11,
@@ -750,7 +745,7 @@
                   "max_choices": null,
                   "created_at": "2020-01-22T07:55:13.564Z",
                   "updated_at": "2020-01-22T07:55:13.564Z",
-                  "answer_options": [
+                  "response_options": [
                     {
                       "id": 16,
                       "decidim_question_id": 12,

data/lib/decidim/dev/assets/assemblies_with_null.json

@@ -2,7 +2,6 @@
   {
     "id": 1,
     "slug": "quae-a",
-    "hashtag": "id",
     "decidim_organization_id": 1,
     "title": {
       "ca": "Eius iure laborum hic et.",

data/lib/decidim/dev/assets/census_all_invalid.csv

@@ -0,0 +1,4 @@
+email;token
+;TOKEN123
+invalid-email;TOKEN456
+;

data/lib/decidim/dev/assets/census_duplicate_emails.csv

@@ -0,0 +1,4 @@
+email;token
+user1@example.org;TOKEN123
+user1@example.org;TOKEN456
+user1@example.org;TOKEN456

data/lib/decidim/dev/assets/census_no_header.csv

@@ -0,0 +1,2 @@
+user1@example.org;TOKEN123
+user2@example.org;TOKEN456

data/lib/decidim/dev/assets/census_with_missing_email.csv

@@ -0,0 +1,3 @@
+email;token
+;TOKEN123
+user2@example.org;123456

data/lib/decidim/dev/assets/census_with_missing_token.csv

@@ -0,0 +1,3 @@
+email;token
+user1@example.org;
+user2@example.org;123456

data/lib/decidim/dev/assets/participatory_processes.json

@@ -12,7 +12,6 @@
       "es": "In laudantium."
     },
     "slug": "distinctio-cupiditate",
-    "hashtag": "harum",
     "short_description": {
       "ca": "<p>Harum magnam id.</p>",
       "en": "<p>Aut quam doloribus.</p>",

data/lib/decidim/dev/assets/participatory_processes_with_null.json

@@ -12,7 +12,6 @@
       "es": "In laudantium."
     },
     "slug": "distinctio-cupiditate",
-    "hashtag": "harum",
     "short_description": {
       "ca": "<p>Harum magnam id.</p>",
       "en": "<p>Aut quam doloribus.</p>",

data/lib/decidim/dev/assets/valid_election_census.csv

@@ -0,0 +1,3 @@
+email;token
+user1@example.org;token123
+user2@example.org;token456

data/lib/decidim/dev/assets/valid_emails.csv

@@ -0,0 +1,27 @@
+first_test_email@example.org
+second_test_email@example.org
+third_test_email@example.org
+this_is_a_test_email@test.org
+test.123@test.org
+example.123@test.org
+this_is_another_test_email@test.com
+test_user_001@example.com
+test.account@example.com
+test.example@example.com
+example.account@example.com
+new_email_test@example.com
+one_more_example_email@test.org
+another_example_email@test.org
+first_test@test.org
+one_example_email@test.org
+second_test@test.com
+four.test@test.org
+the_test_email@example.org
+these_test_email@test.org
+more_example_email@test.org
+the_new_email_test@example.test
+another_example_email@test.example
+this_is_the_new_email_test@example.test
+one_more_example_email@example.test
+another_example_email@example.test
+first_test@example.test

data/lib/decidim/dev/common_rake.rb

@@ -3,7 +3,6 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "decidim/dev"
-require "parallel_tests/tasks"
 
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.rspec_opts = "--format progress --format RspecJunitFormatter -o ~/rspec/rspec.xml" if ENV["CI"]

data/lib/decidim/dev/component.rb

@@ -33,8 +33,8 @@ Decidim.register_component(:dummy) do |component|
     settings.attribute :amendment_reaction_enabled, type: :boolean, default: true
     settings.attribute :amendment_promotion_enabled, type: :boolean, default: true
     settings.attribute :amendments_visibility, type: :string, default: "all"
-    settings.attribute :endorsements_enabled, type: :boolean, default: false
-    settings.attribute :endorsements_blocked, type: :boolean, default: false
+    settings.attribute :likes_enabled, type: :boolean, default: false
+    settings.attribute :likes_blocked, type: :boolean, default: false
   end
 
   component.register_resource(:dummy_resource) do |resource|

data/lib/decidim/dev/engine.rb

@@ -25,7 +25,7 @@ module Decidim
         ActiveSupport.on_load(:action_controller) { include Decidim::Dev::NeedsDevelopmentTools } if Rails.env.development? || ENV.fetch("DECIDIM_DEV_ENGINE", nil)
       end
 
-      initializer "decidim_dev.webpacker.assets_path" do
+      initializer "decidim_dev.shakapacker.assets_path" do
         Decidim.register_assets_path File.expand_path("app/packs", root)
       end
 

data/lib/decidim/dev/test/base_spec_helper.rb

@@ -4,6 +4,15 @@ require "decidim/dev"
 
 ENV["RAILS_ENV"] ||= "test"
 ENV["RAILS_SYSTEM_TESTING_SCREENSHOT_HTML"] ||= "1"
+ENV["DECIDIM_API_JWT_SECRET"] ||= "dummy-api-jwt-secret"
+ENV["DECIDIM_AVAILABLE_LOCALES"] ||= "en,ca,es"
+ENV["DECIDIM_ENABLE_MACHINE_TRANSLATION"] ||= "true"
+ENV["DECIDIM_SPAM_DETECTION_BACKEND_RESOURCE"] ||= "memory"
+ENV["DECIDIM_SPAM_DETECTION_BACKEND_USER"] ||= "memory"
+ENV["DECIDIM_SMS_GATEWAY_SERVICE"] ||= "Decidim::Verifications::Sms::ExampleGateway"
+ENV["DECIDIM_TIMESTAMP_SERVICE"] ||= "Decidim::Initiatives::DummyTimestamp"
+ENV["DECIDIM_PDF_SIGNATURE_SERVICE"] ||= "Decidim::PdfSignatureExample"
+ENV["DECIDIM_MACHINE_TRANSLATION_SERVICE"] ||= "Decidim::Dev::DummyTranslator"
 
 engine_spec_dir = File.join(Dir.pwd, "spec")