decidim-dev 0.28.1 → 0.29.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a0788fcddc027172a756f2875f4f43b9a85894e2ded6a39ea04c8b81098862c
-  data.tar.gz: cadcdd86dcf27af64737df7903cca1f371441cc5ed8edf0513f96d98fab10a2f
+  metadata.gz: e2fcbfc76decf8d8809bad2ff00344de88b9ccf71750415f1cdfc498e1c9921a
+  data.tar.gz: eb37bd7b9db59ef9fbf4551c7303ff82943cdeb496d7bb8acb0c739fea947ea6
 SHA512:
-  metadata.gz: '059463876ce9e8ab637bb92aac43f23c230abd154b2e9e8f35ca0a977ecf1e29bca378b977fb36057e812b75b6ae248623845cc50ea6ed0b6598c41c74f02341'
-  data.tar.gz: 25db9b82f0290f6dbd0897407684722ecad962092a30b825e120cc76f0f0ae4c330c0191d31c002db810a2606fa79102724e25325a11fe7dec38a2efb952ac8c
+  metadata.gz: 50596057f7f981b5e9630b1db72ad64352a32042f1bdd87158af74b0c57fd6214df68cb543db22413540d980e17dafc7625dd450440a6e5f58af808f39f0743d
+  data.tar.gz: 3c7084087adc7166f12d04ce5a2738cc63219cafa6a0793191d71d75419966a5f2e7ad613175635f06b524a3b3196e99a2a17daf44c48570afb66e1f372584f5

data/app/models/decidim/dev/dummy_resource.rb

@@ -63,7 +63,9 @@ module Decidim
 
       # Public: Whether the object can have new comments or not.
       def user_allowed_to_comment?(user)
-        component.can_participate_in_space?(user)
+        return unless component.can_participate_in_space?(user)
+
+        ActionAuthorizer.new(user, "comment", component, self).authorize.ok?
       end
 
       # Public: Whether the object can have new comment votes or not.

data/app/packs/stylesheets/decidim/dev/_accessibility.scss

@@ -2,7 +2,7 @@
   position: fixed;
   display: flex;
   z-index: 9999;
-  top: 60px;
+  bottom: 0;
   left: 0;
   background: #fff;
   border: 1px solid #888;

data/app/packs/stylesheets/decidim/dev/_bullet.scss

@@ -0,0 +1,4 @@
+details#bullet-footer {
+  z-index: 77777 !important;
+  bottom: 48px !important;
+}

data/app/packs/stylesheets/decidim/dev/_rack_profiler.scss

@@ -0,0 +1,4 @@
+.profiler-results.profiler-bottom {
+  bottom: 26px !important;
+  z-index: 88888 !important;
+}

data/app/packs/stylesheets/decidim/dev.scss

@@ -1,2 +1,4 @@
 @import "stylesheets/decidim/dev/accessibility";
+@import "stylesheets/decidim/dev/bullet";
+@import "stylesheets/decidim/dev/rack_profiler";
 @import "stylesheets/decidim/dev/map";

data/config/locales/bg.yml

@@ -15,6 +15,12 @@ bg:
       dummy:
         settings:
           global:
+            guided: Насочвано въвеждане
+            guided_help: Помощен текст
+            guided_readonly: Дезактивирано въвеждане
+            guided_rich: Насочвано широко въвеждане
+            guided_rich_help_html: HTML <strong>помощен</strong> текст
+            guided_rich_readonly_html: HTML <strong>помощен</strong> текст за дезакривирано въвеждане
             readonly_attribute: Само за четене атрибут
             test: А тест
             test_choices:
@@ -23,6 +29,7 @@ bg:
               c: В избор
             test_options:
               bar: Нещо1
+              baz: Baz
               foo: Нещо2
           step:
             endorsements_blocked: Одобряване забранено
@@ -30,6 +37,7 @@ bg:
             readonly_step_attribute: Само за четене стъпков атрибут
             test_options:
               bar: Нещо1
+              baz: Baz
               foo: Нещо2
     dummy:
       admin:
@@ -45,6 +53,7 @@ bg:
           description_own: Вие създадохте %{score} теста.
           name: Тестове
           next_level_in: Създайте още %{score} теста за да достигнете следващо ниво!
+          unearned_another: Този участник все още не е създал никакви тестове.
           unearned_own: Вие все още не сте създали тест.
     resource_links:
       test_link:

data/config/rubocop/disabled.yml

@@ -9,3 +9,63 @@ Naming/MemoizedInstanceVariableName:
 
 RSpec/VerifiedDoubleReference:
   Enabled: false
+
+FactoryBot/ConsistentParenthesesStyle:
+  Enabled: false
+
+FactoryBot/ExcessiveCreateList:
+  Enabled: false
+
+RSpec/ExampleWording:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: false
+
+RSpec/ReceiveMessages:
+  Enabled: false
+
+RSpecRails/NegationBeValid:
+  Enabled: false
+
+RSpec/MetadataStyle:
+  Enabled: false
+
+FactoryBot/FactoryAssociationWithStrategy:
+  Enabled: false
+
+RSpec/RemoveConst:
+  Enabled: false
+
+FactoryBot/AssociationStyle:
+  Enabled: false
+
+Rubycw/Rubycw:
+  Enabled: false
+
+Lint/SymbolConversion:
+  Enabled: false
+
+Style/RedundantParentheses:
+  Enabled: false
+
+Style/MapIntoArray:
+  Enabled: false
+
+Style/SuperWithArgsParentheses:
+  Enabled: false
+
+Style/ArgumentsForwarding:
+  Enabled: false
+
+Style/SuperArguments:
+  Enabled: false
+
+Lint/SelfAssignment:
+  Enabled: false
+
+Style/SendWithLiteralMethodName:
+  Enabled: false
+
+Rails/WhereRange:
+  Enabled: false

data/config/rubocop/performance.yml

@@ -0,0 +1,154 @@
+require: rubocop-performance
+
+Performance:
+  Enabled: false
+
+Performance/AncestorsInclude:
+  Enabled: false
+
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: false
+
+Performance/BigDecimalWithNumericArgument:
+  Enabled: false
+
+Performance/BindCall:
+  Enabled: false
+
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: false
+
+Performance/Caller:
+  Enabled: false
+
+Performance/CaseWhenSplat:
+  Enabled: false
+
+Performance/Casecmp:
+  Enabled: false
+
+Performance/ChainArrayAllocation:
+  Enabled: false
+
+Performance/CollectionLiteralInLoop:
+  Enabled: false
+
+Performance/CompareWithBlock:
+  Enabled: false
+
+Performance/ConcurrentMonotonicTime:
+  Enabled: false
+
+Performance/ConstantRegexp:
+  Enabled: false
+
+Performance/Count:
+  Enabled: false
+
+Performance/DeletePrefix:
+  Enabled: false
+
+Performance/DeleteSuffix:
+  Enabled: false
+
+Performance/Detect:
+  Enabled: false
+
+Performance/DoubleStartEndWith:
+  Enabled: false
+
+Performance/EndWith:
+  Enabled: false
+
+Performance/FixedSize:
+  Enabled: false
+
+Performance/FlatMap:
+  Enabled: false
+
+Performance/InefficientHashSearch:
+  Enabled: false
+
+Performance/IoReadlines:
+  Enabled: false
+
+Performance/MapCompact:
+  Enabled: false
+
+Performance/MapMethodChain:
+  Enabled: false
+
+Performance/MethodObjectAsBlock:
+  Enabled: false
+
+Performance/OpenStruct:
+  Enabled: false
+
+Performance/RangeInclude:
+  Enabled: false
+
+Performance/RedundantBlockCall:
+  Enabled: false
+
+Performance/RedundantEqualityComparisonBlock:
+  Enabled: false
+
+Performance/RedundantMatch:
+  Enabled: false
+
+Performance/RedundantMerge:
+  Enabled: false
+
+Performance/RedundantSortBlock:
+  Enabled: false
+
+Performance/RedundantSplitRegexpArgument:
+  Enabled: false
+
+Performance/RedundantStringChars:
+  Enabled: false
+
+Performance/RegexpMatch:
+  Enabled: false
+
+Performance/ReverseEach:
+  Enabled: false
+
+Performance/ReverseFirst:
+  Enabled: false
+
+Performance/SelectMap:
+  Enabled: false
+
+Performance/Size:
+  Enabled: false
+
+Performance/SortReverse:
+  Enabled: false
+
+Performance/Squeeze:
+  Enabled: false
+
+Performance/StartWith:
+  Enabled: false
+
+Performance/StringIdentifierArgument:
+  Enabled: false
+
+Performance/StringInclude:
+  Enabled: false
+
+Performance/StringReplacement:
+  Enabled: false
+
+Performance/Sum:
+  Enabled: false
+
+Performance/TimesMap:
+  Enabled: false
+
+Performance/UnfreezeString:
+  Enabled: false
+
+Performance/UriDefaultParser:
+  Enabled: false

data/config/rubocop/rspec.yml

@@ -1,11 +1,13 @@
-require: rubocop-rspec
+require:
+  - rubocop-rspec
+  - rubocop-rspec_rails
 
 #  RSpec:
 #    Patterns:
 #      - "(?:^|/)spec/"
 #      - "(?:^|/)test/"
 
-RSpec/FilePath:
+RSpec/SpecFilePathFormat:
   CustomTransform:
     OAuthApplicationPresenter: oauth_application_presenter
 
@@ -71,3 +73,6 @@ RSpec/LeakyConstantDeclaration:
 
 RSpec/DescribedClass:
   Enabled: false
+
+RSpec/IndexedLet:
+  Enabled: false

data/config/rubocop/ruby.yml

@@ -37,7 +37,7 @@ AllCops:
   StyleGuideCopsOnly: false
   # All cops except the ones in disabled.yml are enabled by default. Change
   # this behavior by overriding DisabledByDefault. When DisabledByDefault is
-  # true, all cops in the default configuration are disabled, and and only cops
+  # true, all cops in the default configuration are disabled, and only cops
   # in user configuration are enabled. This makes cops opt-in instead of
   # opt-out. Note that when DisabledByDefault is true, cops in user
   # configuration will be enabled even if they do not set the Enabled parameter.
@@ -66,7 +66,7 @@ AllCops:
   # If a value is specified for TargetRubyVersion then it is used.
   # Else if .ruby-version exists and it contains an MRI version it is used.
   # Otherwise we fallback to the oldest officially supported Ruby version (2.0).
-  TargetRubyVersion: 3.1
+  TargetRubyVersion: 3.2
 
 # Indent private/protected/public as deep as method definitions
 Layout/AccessModifierIndentation:
@@ -530,7 +530,7 @@ Style/GuardClause:
   MinBodyLength: 6
 
 Style/HashSyntax:
-  EnforcedStyle: ruby19
+  EnforcedStyle: no_mixed_keys
   SupportedStyles:
     # checks for 1.9 syntax (e.g. {a: 1}) for all symbol keys
     - ruby19
@@ -803,11 +803,11 @@ Naming/PredicateName:
   ForbiddenPrefixes:
     - is_
     - have_
-  # Predicate names which, despite having a blacklisted prefix, or no ?,
+  # Predicate names which, despite having a denylisted prefix, or no ?,
   # should still be accepted
   AllowedMethods:
     - is_a?
-  # Exclude Rspec specs because there is a strong convetion to write spec
+  # Exclude Rspec specs because there is a strong convention to write spec
   # helpers in the form of `have_something` or `be_something`.
   Exclude:
     - "**/spec/**/*"

data/decidim-dev.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
     "homepage_uri" => "https://decidim.org",
     "source_code_uri" => "https://github.com/decidim/decidim"
   }
-  s.required_ruby_version = "~> 3.1.0"
+  s.required_ruby_version = "~> 3.2.0"
 
   s.name = "decidim-dev"
   s.summary = "Decidim dev tools"
@@ -37,11 +37,11 @@ Gem::Specification.new do |s|
   s.add_dependency "factory_bot_rails", "~> 6.2"
   s.add_dependency "faker", "~> 3.2"
 
-  s.add_dependency "bullet", "~> 7.0"
+  s.add_dependency "bullet", "~> 7.1.6"
   s.add_dependency "byebug", "~> 11.0"
   s.add_dependency "erb_lint", "~> 0.4.0"
   s.add_dependency "i18n-tasks", "~> 1.0"
-  s.add_dependency "nokogiri", "~> 1.14", ">= 1.14.3"
+  s.add_dependency "nokogiri", "~> 1.16", ">= 1.16.2"
   s.add_dependency "parallel_tests", "~> 4.2"
   s.add_dependency "puma", "~> 6.2", ">= 6.3.1"
   s.add_dependency "rails-controller-testing", "~> 1.0"
@@ -51,10 +51,15 @@ Gem::Specification.new do |s|
   s.add_dependency "rspec_junit_formatter", "~> 0.6.0"
   s.add_dependency "rspec-rails", "~> 6.0"
   s.add_dependency "rspec-retry", "~> 0.6.2"
-  s.add_dependency "rubocop", "~> 1.50.0"
+  s.add_dependency "rubocop", "~> 1.65.0"
+  s.add_dependency "rubocop-capybara", "~> 2.21"
+  s.add_dependency "rubocop-factory_bot", "~> 2.26"
   s.add_dependency "rubocop-faker", "~> 1.1"
-  s.add_dependency "rubocop-rails", "~> 2.19"
-  s.add_dependency "rubocop-rspec", "~> 2.20"
+  s.add_dependency "rubocop-performance", "~> 1.21"
+  s.add_dependency "rubocop-rails", "~> 2.25"
+  s.add_dependency "rubocop-rspec", "~> 3.0"
+  s.add_dependency "rubocop-rspec_rails", "~> 2.30"
+  s.add_dependency "rubocop-rubycw", "~> 0.1"
   s.add_dependency "selenium-webdriver", "~> 4.9"
   s.add_dependency "simplecov", "~> 0.22.0"
   s.add_dependency "simplecov-cobertura", "~> 2.1.0"

data/lib/decidim/dev/assets/assemblies.json

@@ -58,7 +58,6 @@
       "en": "Vel qui.",
       "es": "Et molestiae."
     },
-    "show_statistics": false,
     "scopes_enabled": true,
     "private_space": false,
     "reference": "PhD-ASSE-2020-01-1",
@@ -352,38 +351,6 @@
           "intro_en": "<p>Praesentium iste sit dicta.</p>",
           "intro_ca": "<p>Odit aperiam ea reiciendis.</p>",
           "intro_es": "<p>Repudiandae magni quo sit.</p>",
-          "categories_label": {
-            "ca": "rerum",
-            "en": "dolores",
-            "es": "voluptatem"
-          },
-          "categories_label_en": "dolores",
-          "categories_label_ca": "rerum",
-          "categories_label_es": "voluptatem",
-          "subcategories_label": {
-            "ca": "totam",
-            "en": "qui",
-            "es": "iure"
-          },
-          "subcategories_label_en": "qui",
-          "subcategories_label_ca": "totam",
-          "subcategories_label_es": "iure",
-          "heading_parent_level_results": {
-            "ca": "pariatur",
-            "en": "voluptatem",
-            "es": "molestias"
-          },
-          "heading_parent_level_results_en": "voluptatem",
-          "heading_parent_level_results_ca": "pariatur",
-          "heading_parent_level_results_es": "molestias",
-          "heading_leaf_level_results": {
-            "ca": "enim",
-            "en": "nam",
-            "es": "et"
-          },
-          "heading_leaf_level_results_en": "nam",
-          "heading_leaf_level_results_ca": "enim",
-          "heading_leaf_level_results_es": "et",
           "display_progress_enabled": true
         },
         "weight": 0,
@@ -541,7 +508,7 @@
           "proposal_length": 500,
           "proposal_edit_before_minutes": 5,
           "threshold_per_proposal": 0,
-          "can_accumulate_supports_beyond_threshold": false,
+          "can_accumulate_votes_beyond_threshold": false,
           "proposal_answering_enabled": true,
           "official_proposals_enabled": true,
           "comments_enabled": true,

data/lib/decidim/dev/assets/assemblies_with_null.json

@@ -48,7 +48,7 @@
       "es": "Incidunt provident doloremque."
     },
     "decidim_scope_id": null,
-    "paticipatory_scope": {
+    "participatory_scope": {
       "ca": "Assumenda.",
       "en": "Quidem.",
       "es": "Aspernatur."
@@ -58,7 +58,6 @@
       "en": "Vel qui.",
       "es": "Et molestiae."
     },
-    "show_statistics": false,
     "scopes_enabled": true,
     "private_space": false,
     "reference": "PhD-ASSE-2020-01-1",

data/lib/decidim/dev/assets/participatory_processes.json

@@ -91,7 +91,6 @@
     "private_space": false,
     "promoted": true,
     "scopes_enabled": true,
-    "show_statistics": true,
     "participatory_process_steps": [
       {
         "id": 1,
@@ -340,38 +339,6 @@
           "intro_en": "<p>Voluptatem praesentium maxime vitae.</p>",
           "intro_ca": "<p>Sapiente animi quo at.</p>",
           "intro_es": "<p>Illum veritatis porro nulla.</p>",
-          "categories_label": {
-            "ca": "alias",
-            "en": "aut",
-            "es": "omnis"
-          },
-          "categories_label_en": "aut",
-          "categories_label_ca": "alias",
-          "categories_label_es": "omnis",
-          "subcategories_label": {
-            "ca": "rerum",
-            "en": "reprehenderit",
-            "es": "nostrum"
-          },
-          "subcategories_label_en": "reprehenderit",
-          "subcategories_label_ca": "rerum",
-          "subcategories_label_es": "nostrum",
-          "heading_parent_level_results": {
-            "ca": "et",
-            "en": "explicabo",
-            "es": "officiis"
-          },
-          "heading_parent_level_results_en": "explicabo",
-          "heading_parent_level_results_ca": "et",
-          "heading_parent_level_results_es": "officiis",
-          "heading_leaf_level_results": {
-            "ca": "consectetur",
-            "en": "illum",
-            "es": "sunt"
-          },
-          "heading_leaf_level_results_en": "illum",
-          "heading_leaf_level_results_ca": "consectetur",
-          "heading_leaf_level_results_es": "sunt",
           "display_progress_enabled": true
         },
         "weight": 0,
@@ -431,4 +398,4 @@
       }
     ]
   }
-]
+]

data/lib/decidim/dev/assets/participatory_processes_with_null.json

@@ -91,7 +91,6 @@
     "private_space": false,
     "promoted": true,
     "scopes_enabled": true,
-    "show_statistics": true,
     "participatory_process_steps": null,
     "participatory_process_categories": null,
     "attachments": {

data/lib/decidim/dev/assets/participatory_text.md

@@ -1,5 +1,3 @@
-<!-- markdown-lint-disable-file single-h1 -->
-
 # The great title for a new law
 
 ## A co-creation process to create creative creations

data/lib/decidim/dev/component.rb

@@ -40,7 +40,7 @@ Decidim.register_component(:dummy) do |component|
   component.register_resource(:dummy_resource) do |resource|
     resource.name = :dummy
     resource.model_class_name = "Decidim::Dev::DummyResource"
-    resource.template = "decidim/dummy_resource/linked_dummys"
+    resource.template = "decidim/dummy_resource/linked_dummies"
     resource.actions = %w(foo)
     resource.searchable = true
   end
@@ -53,7 +53,7 @@ Decidim.register_component(:dummy) do |component|
   component.register_resource(:coauthorable_dummy_resource) do |resource|
     resource.name = :coauthorable_dummy
     resource.model_class_name = "Decidim::Dev::CoauthorableDummyResource"
-    resource.template = "decidim/coauthorabledummy_resource/linked_dummys"
+    resource.template = "decidim/coauthorabledummy_resource/linked_dummies"
     resource.actions = %w(foo-coauthorable)
     resource.searchable = false
   end

data/lib/decidim/dev/dummy_translator.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module Dev
-    # This Dummy translator recieves the field value
+    # This Dummy translator receives the field value
     # and the locale of the field which has to be
     # translated. It returns the appended value for both.
     # This is for testing only.

data/lib/decidim/dev/engine.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "decidim/dev/needs_development_tools"
+
 module Decidim
   module Dev
     # Decidim's development Rails Engine.
@@ -27,6 +29,15 @@ module Decidim
         Decidim.register_assets_path File.expand_path("app/packs", root)
       end
 
+      initializer "decidim_dev.middleware.test_map_server" do |app|
+        next unless Rails.env.test?
+
+        require "decidim/dev/test/map_server"
+
+        # Add the test map server as the first middleware in the stack
+        app.config.middleware.insert_before 0, Decidim::Dev::Test::MapServer
+      end
+
       initializer "decidim_dev.moderation_content" do
         config.to_prepare do
           ActiveSupport::Notifications.subscribe("decidim.admin.block_user:after") do |_event_name, data|

data/lib/decidim/dev/test/factories.rb

@@ -35,6 +35,12 @@ FactoryBot.define do
         end
       end
     end
+
+    trait :moderated do
+      after(:create) do |resource, evaluator|
+        create(:moderation, reportable: resource, hidden_at: 2.days.ago, skip_injection: evaluator.skip_injection)
+      end
+    end
   end
 
   factory :nested_dummy_resource, class: "Decidim::Dev::NestedDummyResource" do