decidim-dev 0.28.0 → 0.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d771cf6c51fc798d8cbf1d938245c3f52e67cb8404f666e044250a93e92210c7
-  data.tar.gz: b5dec2927ed2a0e397e9d5c0a9b303a27add20a71508229812c7ca0e5b4a982e
+  metadata.gz: bc9d821614ad42d1eb20f682ab82321b933753c5b4d951fea170751b8f6a5bcf
+  data.tar.gz: e256ccb91d7c4ffc96a7722dcd4cb047bfd76724a1199d86ed04527fe0c8829b
 SHA512:
-  metadata.gz: 166cf877812db4d03c99d2a23df8d449800dadca22e05b0de418d3fad4f7e56202fcf730c00f753e73862eef11a7aa372fe9dec2cbf0404aee29703458b70cd2
-  data.tar.gz: 2cbeeb10ec359e66619fdb5780bf5643c7c9de663da470b50102e84c0a99e83b51d8ef7a1b3d2133aa99baaaa5f2c2500760f98dda31914d50d1ae179fd10d37
+  metadata.gz: ccaee176486a56c7b99979f06c2debc99e93b44ada6f251db4a6e57684a065858e46eb32884ff9c9696f225f5d243fd5fdfe8cf8eff2ab8ce84df59277a39e3a
+  data.tar.gz: b74b0ee53ae4c5b2db19932c575793fecf546458c51bc0bd62dc3692646c621e04786de35f0a540a166c7ad9ca91869e8c160b58c82ad3d67fe6bc3d4d21fdea

data/app/models/decidim/dev/dummy_resource.rb

@@ -63,7 +63,9 @@ module Decidim
 
       # Public: Whether the object can have new comments or not.
       def user_allowed_to_comment?(user)
-        component.can_participate_in_space?(user)
+        return unless component.can_participate_in_space?(user)
+
+        ActionAuthorizer.new(user, "comment", component, self).authorize.ok?
       end
 
       # Public: Whether the object can have new comment votes or not.

data/config/locales/bg.yml

@@ -15,6 +15,12 @@ bg:
       dummy:
         settings:
           global:
+            guided: Насочвано въвеждане
+            guided_help: Помощен текст
+            guided_readonly: Дезактивирано въвеждане
+            guided_rich: Насочвано широко въвеждане
+            guided_rich_help_html: HTML <strong>помощен</strong> текст
+            guided_rich_readonly_html: HTML <strong>помощен</strong> текст за дезакривирано въвеждане
             readonly_attribute: Само за четене атрибут
             test: А тест
             test_choices:
@@ -23,6 +29,7 @@ bg:
               c: В избор
             test_options:
               bar: Нещо1
+              baz: Baz
               foo: Нещо2
           step:
             endorsements_blocked: Одобряване забранено
@@ -30,6 +37,7 @@ bg:
             readonly_step_attribute: Само за четене стъпков атрибут
             test_options:
               bar: Нещо1
+              baz: Baz
               foo: Нещо2
     dummy:
       admin:
@@ -45,6 +53,7 @@ bg:
           description_own: Вие създадохте %{score} теста.
           name: Тестове
           next_level_in: Създайте още %{score} теста за да достигнете следващо ниво!
+          unearned_another: Този участник все още не е създал никакви тестове.
           unearned_own: Вие все още не сте създали тест.
     resource_links:
       test_link:

data/config/locales/he-IL.yml

@@ -0,0 +1 @@
+he:

data/config/locales/hu.yml

@@ -20,8 +20,8 @@ hu:
               bar: Oszlop
               foo: foo
           step:
-            endorsements_blocked: Jóváhagyások letiltva
-            endorsements_enabled: Jóváhagyások engedélyezve
+            endorsements_blocked: Támogatások letiltva
+            endorsements_enabled: Támogatások engedélyezve
             test_options:
               bar: Oszlop
               foo: foo

data/config/locales/pl.yml

@@ -15,6 +15,12 @@ pl:
       dummy:
         settings:
           global:
+            guided: Kierowane wprowadzanie danych
+            guided_help: Tekst pomocy
+            guided_readonly: Zablokowane pole wprowadzania danych
+            guided_rich: Kierowane i rozbudowane wprowadzanie danych
+            guided_rich_help_html: Tekst HTML <strong>pomocy</strong>
+            guided_rich_readonly_html: Treść HTML <strong>pomocy</strong> dla wyłączonego wprowadzania
             readonly_attribute: Atrybut tylko do odczytu
             test: Test A
             test_choices:
@@ -23,6 +29,7 @@ pl:
               c: Opcja C
             test_options:
               bar: Bar
+              baz: Baz
               foo: Foo
           step:
             endorsements_blocked: Możliwość rekomendacji zablokowana
@@ -30,6 +37,7 @@ pl:
             readonly_step_attribute: Atrybut kroku tylko do odczytu
             test_options:
               bar: Bar
+              baz: Baz
               foo: Foo
     dummy:
       admin:
@@ -45,6 +53,7 @@ pl:
           description_own: Utworzyłeś %{score} testów.
           name: Testy
           next_level_in: Stwórz %{score} dodatkowych testów, aby przejść do następnego poziomu!
+          unearned_another: Ten uczestnik nie utworzył jeszcze żadnych testów.
           unearned_own: Nie stworzyłeś jeszcze żadnych testów.
     resource_links:
       test_link:

data/config/locales/pt-BR.yml

@@ -29,6 +29,7 @@ pt-BR:
               c: Escolha C
             test_options:
               bar: Bar
+              baz: Baz
               foo: Foo
           step:
             endorsements_blocked: Endossos bloqueados
@@ -36,6 +37,7 @@ pt-BR:
             readonly_step_attribute: Atributo passo somente leitura
             test_options:
               bar: Bar
+              baz: Baz
               foo: Foo
     dummy:
       admin:
@@ -51,6 +53,7 @@ pt-BR:
           description_own: Você criou %{score} testes.
           name: Testes
           next_level_in: Crie mais %{score} testes para alcançar o próximo nível!
+          unearned_another: Este participante ainda não criou nenhum teste ainda.
           unearned_own: Você não criou testes ainda.
     resource_links:
       test_link:

data/config/rubocop/rspec.yml

@@ -5,6 +5,10 @@ require: rubocop-rspec
 #      - "(?:^|/)spec/"
 #      - "(?:^|/)test/"
 
+RSpec/FilePath:
+  CustomTransform:
+    OAuthApplicationPresenter: oauth_application_presenter
+
 RSpec/BeforeAfterAll:
   Enabled: true
 

data/decidim-dev.gemspec

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.push File.expand_path("lib", __dir__)
+
+# Maintain your gem's version:
+require "decidim/dev/version"
+
+# Describe your gem and declare its dependencies:
+Gem::Specification.new do |s|
+  s.version = Decidim::Dev.version
+  s.authors = ["Josep Jaume Rey Peroy", "Marc Riera Casals", "Oriol Gual Oliva"]
+  s.email = ["josepjaume@gmail.com", "mrc2407@gmail.com", "oriolgual@gmail.com"]
+  s.license = "AGPL-3.0"
+  s.homepage = "https://decidim.org"
+  s.metadata = {
+    "bug_tracker_uri" => "https://github.com/decidim/decidim/issues",
+    "documentation_uri" => "https://docs.decidim.org/",
+    "funding_uri" => "https://opencollective.com/decidim",
+    "homepage_uri" => "https://decidim.org",
+    "source_code_uri" => "https://github.com/decidim/decidim"
+  }
+  s.required_ruby_version = "~> 3.1.0"
+
+  s.name = "decidim-dev"
+  s.summary = "Decidim dev tools"
+  s.description = "Utilities and tools we need to develop Decidim"
+
+  s.files = Dir.chdir(__dir__) do
+    `git ls-files -z`.split("\x0").select do |f|
+      (File.expand_path(f) == __FILE__) ||
+        f.start_with?(*%w(app/ config/ db/ lib/ Rakefile README.md rubocop-decidim.yml))
+    end
+  end
+
+  s.add_dependency "capybara", "~> 3.39"
+  s.add_dependency "decidim", Decidim::Dev.version
+  s.add_dependency "factory_bot_rails", "~> 6.2"
+  s.add_dependency "faker", "~> 3.2"
+
+  s.add_dependency "bullet", "~> 7.0"
+  s.add_dependency "byebug", "~> 11.0"
+  s.add_dependency "erb_lint", "~> 0.4.0"
+  s.add_dependency "i18n-tasks", "~> 1.0"
+  s.add_dependency "nokogiri", "~> 1.14", ">= 1.14.3"
+  s.add_dependency "parallel_tests", "~> 4.2"
+  s.add_dependency "puma", "~> 6.2", ">= 6.3.1"
+  s.add_dependency "rails-controller-testing", "~> 1.0"
+  s.add_dependency "rspec", "~> 3.12"
+  s.add_dependency "rspec-cells", "~> 0.3.7"
+  s.add_dependency "rspec-html-matchers", "~> 0.10"
+  s.add_dependency "rspec_junit_formatter", "~> 0.6.0"
+  s.add_dependency "rspec-rails", "~> 6.0"
+  s.add_dependency "rspec-retry", "~> 0.6.2"
+  s.add_dependency "rubocop", "~> 1.50.0"
+  s.add_dependency "rubocop-faker", "~> 1.1"
+  s.add_dependency "rubocop-rails", "~> 2.19"
+  s.add_dependency "rubocop-rspec", "~> 2.20"
+  s.add_dependency "selenium-webdriver", "~> 4.9"
+  s.add_dependency "simplecov", "~> 0.22.0"
+  s.add_dependency "simplecov-cobertura", "~> 2.1.0"
+  s.add_dependency "w3c_rspec_validators", "~> 0.3.0"
+  s.add_dependency "webmock", "~> 3.18"
+  s.add_dependency "wisper-rspec", "~> 1.0"
+end

data/lib/decidim/dev/test/factories.rb

@@ -4,53 +4,69 @@ require "decidim/components/namer"
 
 FactoryBot.define do
   factory :dummy_component, parent: :component do
-    name { Decidim::Components::Namer.new(participatory_space.organization.available_locales, :surveys).i18n_name }
+    transient do
+      skip_injection { false }
+    end
+    name { generate_component_name(participatory_space.organization.available_locales, :surveys, skip_injection:) }
     manifest_name { :dummy }
   end
 
   factory :dummy_resource, class: "Decidim::Dev::DummyResource" do
     transient do
+      skip_injection { false }
       users { nil }
       # user_groups correspondence to users is by sorting order
       user_groups { [] }
     end
-    title { Decidim::Faker::Localized.localized { generate(:name) } }
-    component { create(:component, manifest_name: "dummy") }
-    author { create(:user, :confirmed, organization: component.organization) }
-    scope { create(:scope, organization: component.organization) }
+    title { generate_localized_title(:dummy_resource_title, skip_injection:) }
+    component { create(:dummy_component, skip_injection:) }
+    author { create(:user, :confirmed, organization: component.organization, skip_injection:) }
+    scope { create(:scope, organization: component.organization, skip_injection:) }
 
     trait :published do
       published_at { Time.current }
     end
 
     trait :with_endorsements do
-      after :create do |resource|
+      after :create do |resource, evaluator|
         5.times.collect do
-          create(:endorsement, resource:, author: build(:user, organization: resource.component.organization))
+          create(:endorsement, resource:, skip_injection: evaluator.skip_injection,
+                               author: build(:user, organization: resource.component.organization, skip_injection: evaluator.skip_injection))
         end
       end
     end
+
+    trait :moderated do
+      after(:create) do |resource, evaluator|
+        create(:moderation, reportable: resource, hidden_at: 2.days.ago, skip_injection: evaluator.skip_injection)
+      end
+    end
   end
 
   factory :nested_dummy_resource, class: "Decidim::Dev::NestedDummyResource" do
+    transient do
+      skip_injection { false }
+    end
     title { generate(:name) }
     dummy_resource { create(:dummy_resource) }
   end
 
   factory :coauthorable_dummy_resource, class: "Decidim::Dev::CoauthorableDummyResource" do
-    title { generate(:name) }
-    component { create(:component, manifest_name: "dummy") }
-
     transient do
-      authors_list { [create(:user, organization: component.organization)] }
+      skip_injection { false }
+      authors_list { [create(:user, organization: component.organization, skip_injection:)] }
     end
+    title { generate(:name) }
+    component { create(:component, manifest_name: "dummy") }
 
     after :build do |resource, evaluator|
       evaluator.authors_list.each do |coauthor|
         resource.coauthorships << if coauthor.is_a?(Decidim::UserGroup)
-                                    build(:coauthorship, author: coauthor.users.first, user_group: coauthor, coauthorable: resource, organization: evaluator.component.organization)
+                                    build(:coauthorship, author: coauthor.users.first, user_group: coauthor, coauthorable: resource,
+                                                         organization: evaluator.component.organization, skip_injection: evaluator.skip_injection)
                                   else
-                                    build(:coauthorship, author: coauthor, coauthorable: resource, organization: evaluator.component.organization)
+                                    build(:coauthorship, author: coauthor, coauthorable: resource, organization: evaluator.component.organization,
+                                                         skip_injection: evaluator.skip_injection)
                                   end
       end
     end

data/lib/decidim/dev/test/rspec_support/capybara.rb

@@ -32,6 +32,7 @@ end
   port = rand(5000..6999)
   begin
     Socket.tcp("127.0.0.1", port, connect_timeout: 5).close
+    warn "Port #{port} is already in use, trying another one."
   rescue Errno::ECONNREFUSED
     # When connection is refused, the port is available for use.
     Capybara.server_port = port
@@ -42,7 +43,9 @@ end
 Capybara.register_driver :headless_chrome do |app|
   options = Selenium::WebDriver::Chrome::Options.new
   options.args << "--explicitly-allowed-ports=#{Capybara.server_port}"
-  options.args << "--headless"
+  options.args << "--headless=new"
+  # Do not limit browser resources
+  options.args << "--disable-dev-shm-usage"
   options.args << "--no-sandbox"
   options.args << if ENV["BIG_SCREEN_SIZE"].present?
                     "--window-size=1920,3000"
@@ -91,8 +94,10 @@ end
 
 Capybara.register_driver :iphone do |app|
   options = Selenium::WebDriver::Chrome::Options.new
-  options.args << "--headless"
+  options.args << "--headless=new"
   options.args << "--no-sandbox"
+  # Do not limit browser resources
+  options.args << "--disable-dev-shm-usage"
   options.add_emulation(device_name: "iPhone 6")
 
   Capybara::Selenium::Driver.new(
@@ -116,12 +121,38 @@ end
 Capybara.server = :puma, server_options
 
 Capybara.server_errors = [SyntaxError, StandardError]
+Capybara.save_path = Rails.root.join("tmp/screenshots")
 
 Capybara.default_max_wait_time = 10
 
 RSpec.configure do |config|
+  config.before :all, type: :system do
+    if ENV["BIG_SCREEN_SIZE"].present?
+      warn "[DECIDIM] ChromeDriver Workaround is being active: Setting window size to 1920x3000."
+    else
+      warn "[DECIDIM] ChromeDriver Workaround is being active: Setting window size to 1920x1080."
+    end
+  end
+
   config.before :each, type: :system do
     driven_by(:headless_chrome)
+
+    # Workaround for flaky spec related to resolution change
+    #
+    # For some unknown reason, depending on the order run for these specs, the resolution is changed to
+    # 800x600, which breaks the drag and drop. This forces the resolution to be 1920x1080.
+    # One possible culprit for the screen resolution change is the alert error intercepting which messes with the window focus.
+    # This has been reported to SeleniumHQ, https://github.com/SeleniumHQ/selenium/issues/13553
+    # and to the chromedriver project, https://bugs.chromium.org/p/chromedriver/issues/detail?id=4709
+    #
+    # Note to future maintainers: If you remove this workaround, please make sure to check if the issue has been fixed.
+    # If that is the case, please remove this comment, workaround, and the above warning that starts with "[DECIDIM] ChromeDriver Workaround".
+    if ENV["BIG_SCREEN_SIZE"].present?
+      current_window.resize_to(1920, 3000)
+    else
+      current_window.resize_to(1920, 1080)
+    end
+
     switch_to_default_host
     domain = (try(:organization) || try(:current_organization))&.host
     if domain

data/lib/decidim/dev/test/rspec_support/concurrency.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+# Note that RSpec also provides `uses_transaction` but it needs to be specific
+# with the name of the method which can easily break and the concurrency tests
+# will anyways pass when run with the transactional mode. We want the same
+# database to be used without transactions during the tests so that we can test
+# concurrency correctly.
+RSpec.shared_context "with concurrency" do
+  self.use_transactional_tests = false
+
+  after do
+    # Because the transactional tests are disabled, we need to manually clear
+    # the tables after the test.
+    connection = ActiveRecord::Base.connection
+    connection.disable_referential_integrity do
+      connection.tables.each do |table_name|
+        next if connection.select_value("SELECT COUNT(*) FROM #{table_name}").zero?
+
+        connection.execute("TRUNCATE #{table_name} CASCADE")
+      end
+    end
+  end
+end

data/lib/decidim/dev/test/rspec_support/decidim_sanitization.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.include Decidim::SanitizeHelper
+end

data/lib/decidim/dev/test/rspec_support/dynamic_attach.rb

@@ -23,7 +23,7 @@ module Capybara
           expect(page).to have_content(filename.first(12)) if front_interface
         end
         all(title_input(front_interface)).last.set(options[:title]) if options.has_key?(:title)
-        click_button(front_interface ? "Next" : "Save") unless options[:keep_modal_open]
+        click_button("Save") unless options[:keep_modal_open]
       end
     end
 

data/lib/decidim/dev/test/rspec_support/filters.rb

@@ -2,7 +2,7 @@
 
 module FiltersHelpers
   def click_filter_item(text)
-    find("label.filter", text:).click
+    find("div.filter > label", text:).click
   end
 end
 

data/lib/decidim/dev/test/rspec_support/webmock.rb

@@ -2,4 +2,4 @@
 
 require "webmock/rspec"
 
-WebMock.disable_net_connect!(allow_localhost: true, allow: %r{https://validator.w3.org/})
+WebMock.disable_net_connect!(allow_localhost: true, allow: %r{https://validator\.w3\.org/})

data/lib/decidim/dev/test/rspec_support/webpacker.rb

@@ -1,10 +1,28 @@
 # frozen_string_literal: true
 
 RSpec.configure do |config|
-  config.before(:all, type: :system) do
-    Dir.chdir(Rails.root) { Webpacker.compile }
-  end
-  config.before(:all, type: :mailer) do
+  config.before(:all) do
+    raise "Rails.root directory does not exist" unless Rails.root.exist?
+    raise "package.json file does not exist" unless Rails.root.join("package.json").exist?
+    raise "Node modules directory does not exist" unless Rails.root.join("node_modules").exist?
+
     Dir.chdir(Rails.root) { Webpacker.compile }
+  rescue Errno::ENOENT
+    node_modules_contents = `ls #{Rails.root.join("node_modules")}`
+
+    message = <<~ERROR
+      There was an error during the Webpacker compilation
+      #{"=" * 80}
+      Node version: #{`node -v`}
+      #{"=" * 80}
+      NPM version: #{`npm -v`}
+      #{"=" * 80}
+      Node modules packages: #{`npm list`}
+      #{"=" * 80}
+      Node modules contents: #{node_modules_contents}
+      #{"=" * 80}
+    ERROR
+
+    raise message
   end
 end

data/lib/decidim/dev/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-dev version.
   module Dev
     def self.version
-      "0.28.0"
+      "0.28.2"
     end
   end
 end

data/lib/tasks/lighthouse_report.rake

@@ -43,8 +43,8 @@ namespace :decidim do
     def lighthouse_paths
       ["/"].tap do |urls|
         urls << Decidim::ResourceLocatorPresenter.new(Decidim::ParticipatoryProcess.published.first).path
-        urls << Decidim::ResourceLocatorPresenter.new(Decidim::Meetings::Meeting.published.first).path
-        urls << Decidim::ResourceLocatorPresenter.new(Decidim::Proposals::Proposal.published.first).path
+        urls << Decidim::ResourceLocatorPresenter.new(Decidim::Meetings::Meeting.published.not_hidden.first).path
+        urls << Decidim::ResourceLocatorPresenter.new(Decidim::Proposals::Proposal.published.not_hidden.first).path
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-dev
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.28.2
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-20 00:00:00.000000000 Z
+date: 2024-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -32,14 +32,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.28.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.28.0
+        version: 0.28.2
 - !ruby/object:Gem::Dependency
   name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
@@ -454,7 +454,6 @@ files:
 - app/views/decidim/dev/dummy_resources/show.html.erb
 - app/views/decidim/dummy_resource/_linked_dummys.html.erb
 - config/assets.rb
-- config/environment.rb
 - config/locales/am-ET.yml
 - config/locales/ar-SA.yml
 - config/locales/ar.yml
@@ -487,6 +486,7 @@ files:
 - config/locales/ga-IE.yml
 - config/locales/gl.yml
 - config/locales/gn-PY.yml
+- config/locales/he-IL.yml
 - config/locales/hr-HR.yml
 - config/locales/hr.yml
 - config/locales/hu.yml
@@ -539,6 +539,7 @@ files:
 - config/rubocop/rails.yml
 - config/rubocop/rspec.yml
 - config/rubocop/ruby.yml
+- decidim-dev.gemspec
 - lib/decidim-dev.rb
 - lib/decidim/dev.rb
 - lib/decidim/dev/admin.rb
@@ -616,10 +617,12 @@ files:
 - lib/decidim/dev/test/rspec_support/comments.rb
 - lib/decidim/dev/test/rspec_support/component.rb
 - lib/decidim/dev/test/rspec_support/component_context.rb
+- lib/decidim/dev/test/rspec_support/concurrency.rb
 - lib/decidim/dev/test/rspec_support/confirmation_helpers.rb
 - lib/decidim/dev/test/rspec_support/content_processing.rb
 - lib/decidim/dev/test/rspec_support/controller_example_group.rb
 - lib/decidim/dev/test/rspec_support/data_consent.rb
+- lib/decidim/dev/test/rspec_support/decidim_sanitization.rb
 - lib/decidim/dev/test/rspec_support/dynamic_attach.rb
 - lib/decidim/dev/test/rspec_support/editor_context.rb
 - lib/decidim/dev/test/rspec_support/engine_examples.rb
@@ -672,16 +675,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.22
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Decidim dev tools

data/config/environment.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-# Empty line for playing nice with tpope/vim-rails