decidim-dev 0.27.4 → 0.28.0.rc4

data/lib/decidim/dev/test/rspec_support/capybara_data_picker.rb

@@ -1,36 +0,0 @@
-# frozen_string_literal: true
-
-module Capybara
-  module DataPicker
-    def select_data_picker(id, multiple: nil, global_value: "")
-      Struct.new(:data_picker, :global_value).new(find_data_picker(id, multiple: multiple), global_value)
-    end
-
-    def find_data_picker(id, multiple: nil)
-      if multiple.nil?
-        expect(page).to have_selector("div.data-picker[id$='#{id}']")
-      else
-        expect(page).to have_selector("div.data-picker.picker-#{multiple ? "multiple" : "single"}[id$='#{id}']")
-      end
-      first("div.data-picker[id$='#{id}']")
-    end
-
-    def data_picker_pick_current
-      body = find(:xpath, "//body")
-      expect(body).to have_selector("#data_picker-modal .picker-footer a[data-picker-choose]", wait: 2)
-      body.find("#data_picker-modal .picker-footer a[data-picker-choose]").click
-    end
-
-    def data_picker_choose_value(value)
-      body = find(:xpath, "//body")
-      expect(body).to have_selector("#data_picker-modal input[data-picker-choose][type=checkbox][value=\"#{value}\"]")
-      body.find("#data_picker-modal input[data-picker-choose][type=checkbox][value=\"#{value}\"]").click
-    end
-
-    def data_picker_close
-      body = find(:xpath, "//body")
-      expect(body).to have_selector("#data_picker-modal .picker-footer a[data-close]")
-      body.find("#data_picker-modal .picker-footer a[data-close]").click
-    end
-  end
-end

data/lib/decidim/dev/test/rspec_support/capybara_scopes_picker.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "capybara_data_picker"
-
-module Capybara
-  module ScopesPicker
-    include DataPicker
-
-    RSpec::Matchers.define :have_scope_picked do |expected|
-      match do |scope_picker|
-        data_picker = scope_picker.data_picker
-        scope_name = expected ? translated(expected.name) : t("decidim.scopes.global")
-
-        expect(data_picker).to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: :all)
-        expect(data_picker).to have_selector(:xpath, "//div[contains(@class,'picker-values')]/div/a[text()[contains(.,'#{scope_name}')]]")
-      end
-    end
-
-    RSpec::Matchers.define :have_scope_not_picked do |expected|
-      match do |scope_picker|
-        data_picker = scope_picker.data_picker
-        scope_name = expected ? translated(expected.name) : t("decidim.scopes.global")
-        expect(data_picker).not_to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: :all)
-        expect(data_picker).not_to have_selector(:xpath, "//div[contains(@class,'picker-values')]/div/a[text()[contains(.,'#{scope_name}')]]")
-      end
-    end
-
-    def scope_pick(scope_picker, scope)
-      data_picker = scope_picker.data_picker
-      # use scope_repick to change single scope picker selected scope
-      expect(data_picker).to have_selector(".picker-values:empty", visible: :all) if data_picker.has_css?(".picker-single")
-
-      expect(data_picker).to have_selector(".picker-prompt")
-      data_picker.find(".picker-prompt").click
-
-      scope_picker_browse_scopes(scope.part_of_scopes) if scope
-      data_picker_pick_current
-
-      expect(scope_picker).to have_scope_picked(scope)
-    end
-
-    def scope_repick(element_id, old_scope, new_scope)
-      scope_picker = select_data_picker(element_id)
-
-      data_picker = scope_picker.data_picker
-
-      expect(data_picker).to have_selector(".picker-values div input[value='#{old_scope&.id || scope_picker.global_value}']", visible: :all)
-      data_picker.find(:xpath, "//div[contains(@class,'picker-values')]/div/input[@value='#{old_scope&.id || scope_picker.global_value}']/../a").click
-
-      # browse to lowest common parent between old and new scope
-      parent_scope = (old_scope.part_of_scopes & new_scope.part_of_scopes).last
-
-      scope_picker_browse_scope(parent_scope, back: true)
-      scope_picker_browse_scopes(new_scope.part_of_scopes - old_scope.part_of_scopes)
-      data_picker_pick_current
-
-      scope_picker = select_data_picker(element_id)
-
-      expect(scope_picker).to have_scope_picked(new_scope)
-    end
-
-    def scope_unpick(scope_picker, scope)
-      data_picker = scope_picker.data_picker
-
-      expect(data_picker).to have_selector(".picker-values div input[value='#{scope&.id || scope_picker.global_value}']", visible: :all)
-      data_picker.find(".picker-values div input[value='#{scope&.id || scope_picker.global_value}']").click
-
-      expect(scope_picker).to have_scope_not_picked(scope)
-    end
-
-    private
-
-    def scope_picker_browse_scopes(scopes)
-      scopes.each do |scope|
-        scope_picker_browse_scope(scope)
-        sleep(2)
-      end
-    end
-
-    def scope_picker_browse_scope(scope, back: false)
-      body = find(:xpath, "//body")
-      where = back ? "header" : "content"
-      scope_name = scope ? translated(scope.name) : t("decidim.scopes.global")
-      expect(body).to have_selector("#data_picker-modal .picker-#{where} a", text: scope_name)
-      body.find("#data_picker-modal .picker-#{where} a", text: scope_name).click
-    end
-  end
-end
-
-RSpec.configure do |config|
-  config.include Capybara::ScopesPicker, type: :system
-end

data/lib/decidim/dev/test/rspec_support/summary_notification.rb

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-module RSpec::Core
-  module Notifications
-    class SummaryNotification
-      # Override the original method to add the full path to the spec file and the correct rspec command to rerun the failed spec
-      # The goal is to be able to copy-paste the command to rerun the failed spec without having to manually add the full path to the spec file
-      #
-      # So, instead of:
-      # > rspec ./spec/system/registration_spec.rb:27
-      #
-      # We get:
-      # > bin/rspec ./decidim-core/spec/system/registration_spec.rb:27
-      #
-      # Original code in rspec-core: https://github.com/rspec/rspec-core/blob/8caecca0b9b299ccbaa5c7ea5dd885ab42cd57d3/lib/rspec/core/notifications.rb#L365
-      def colorized_rerun_commands(colorizer=::RSpec::Core::Formatters::ConsoleCodes)
-        rspec_command = running_with_rspec_wrapper? ? "bin/rspec" : "rspec"
-        "\nFailed examples:\n\n" +
-          failed_examples.map do |example|
-            colorizer.wrap("#{rspec_command} #{rerun_argument_for(example)}", RSpec.configuration.failure_color) + " " +
-              colorizer.wrap("# #{example.full_description}",   RSpec.configuration.detail_color)
-          end.join("\n")
-      end
-
-      private
-
-      def running_with_rspec_wrapper?
-        $0 == "bin/rspec"
-      end
-
-      def rerun_argument_for(example)
-        if running_with_rspec_wrapper?
-          location = location_rerun_argument_for_decidim(example)
-        else
-          location = example.location_rerun_argument
-        end
-        return location unless duplicate_rerun_locations.include?(location)
-
-        conditionally_quote(example.id)
-      end
-
-      def location_rerun_argument_for_decidim(example)
-        absolute_file_path = example.metadata[:absolute_file_path]
-        file_path = example.metadata[:file_path][1..-1]
-        module_dir = absolute_file_path.gsub(file_path, "").split("/")[-1]
-
-        "./#{module_dir}#{file_path}:#{example.metadata[:line_number]}"
-      end
-    end
-  end
-end

data/lib/rubocop/cop/decidim/hash_shorthand_syntax_backports.rb

@@ -1,175 +0,0 @@
-# frozen_string_literal: true
-
-#
-# Originally copied from https://github.com/koic/rubocop/blob/master/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb
-# Copyright (c) 2012-22 Bozhidar Batsov
-# MIT License
-#
-
-module RuboCop
-  module Cop
-    # This module checks for Ruby 3.1's hash value omission syntax.
-    #
-    # For using this on Decidim, we have added the Decidim namespace and also the Backports prefix
-    # to the module name
-    module Decidim
-      module HashShorthandSyntaxBackports
-        OMIT_HASH_VALUE_MSG = "Omit the hash value."
-        EXPLICIT_HASH_VALUE_MSG = "Include the hash value."
-        DO_NOT_MIX_MSG_PREFIX = "Do not mix explicit and implicit hash values."
-        DO_NOT_MIX_OMIT_VALUE_MSG = "#{DO_NOT_MIX_MSG_PREFIX} #{OMIT_HASH_VALUE_MSG}".freeze
-        DO_NOT_MIX_EXPLICIT_VALUE_MSG = "#{DO_NOT_MIX_MSG_PREFIX} #{EXPLICIT_HASH_VALUE_MSG}".freeze
-
-        def on_hash_for_mixed_shorthand(hash_node)
-          return if ignore_mixed_hash_shorthand_syntax?(hash_node)
-
-          hash_value_type_breakdown = breakdown_value_types_of_hash(hash_node)
-
-          if hash_with_mixed_shorthand_syntax?(hash_value_type_breakdown)
-            mixed_shorthand_syntax_check(hash_value_type_breakdown)
-          else
-            no_mixed_shorthand_syntax_check(hash_value_type_breakdown)
-          end
-        end
-
-        def on_pair(node)
-          return if ignore_hash_shorthand_syntax?(node)
-
-          hash_key_source = node.key.source
-
-          if enforced_shorthand_syntax == "always"
-            return if node.value_omission? || require_hash_value?(hash_key_source, node)
-
-            message = OMIT_HASH_VALUE_MSG
-            replacement = "#{hash_key_source}:"
-            self.config_to_allow_offenses = { "Enabled" => false }
-          else
-            return unless node.value_omission?
-
-            message = EXPLICIT_HASH_VALUE_MSG
-            replacement = "#{hash_key_source}: #{hash_key_source}"
-          end
-
-          register_offense(node, message, replacement)
-        end
-
-        private
-
-        def register_offense(node, message, replacement)
-          add_offense(node.value, message:) do |corrector|
-            corrector.replace(node, replacement)
-          end
-        end
-
-        def ignore_mixed_hash_shorthand_syntax?(hash_node)
-          target_ruby_version <= 3.0 || enforced_shorthand_syntax != "consistent" ||
-            !hash_node.hash_type?
-        end
-
-        def ignore_hash_shorthand_syntax?(pair_node)
-          target_ruby_version <= 3.0 || enforced_shorthand_syntax == "either" ||
-            enforced_shorthand_syntax == "consistent" ||
-            !pair_node.parent.hash_type?
-        end
-
-        def enforced_shorthand_syntax
-          cop_config.fetch("EnforcedShorthandSyntax", "always")
-        end
-
-        def require_hash_value?(hash_key_source, node)
-          return true if !node.key.sym_type? || require_hash_value_for_around_hash_literal?(node)
-
-          hash_value = node.value
-          return true unless hash_value.send_type? || hash_value.lvar_type?
-
-          hash_key_source != hash_value.source || hash_key_source.end_with?("!", "?")
-        end
-
-        def require_hash_value_for_around_hash_literal?(node)
-          return false unless (ancestor = node.parent.parent)
-          return false if ancestor.send_type? && ancestor.method?(:[])
-
-          !node.parent.braces? && !use_element_of_hash_literal_as_receiver?(ancestor, node.parent) &&
-            (use_modifier_form_without_parenthesized_method_call?(ancestor) ||
-             without_parentheses_call_expr_follows?(ancestor))
-        end
-
-        def use_element_of_hash_literal_as_receiver?(ancestor, parent)
-          # `{value:}.do_something` is a valid syntax.
-          ancestor.send_type? && ancestor.receiver == parent
-        end
-
-        def use_modifier_form_without_parenthesized_method_call?(ancestor)
-          return false if ancestor.respond_to?(:parenthesized?) && ancestor.parenthesized?
-
-          ancestor.ancestors.any? { |node| node.respond_to?(:modifier_form?) && node.modifier_form? }
-        end
-
-        def without_parentheses_call_expr_follows?(ancestor)
-          return false unless ancestor.respond_to?(:parenthesized?) && !ancestor.parenthesized?
-
-          right_sibling = ancestor.right_sibling
-          right_sibling ||= ancestor.each_ancestor.find do |node|
-            node.assignment? || node.send_type?
-          end&.right_sibling
-
-          !!right_sibling
-        end
-
-        def breakdown_value_types_of_hash(hash_node)
-          hash_node.pairs.group_by do |pair_node|
-            if pair_node.value_omission?
-              :value_omitted
-            elsif require_hash_value?(pair_node.key.source, pair_node)
-              :value_needed
-            else
-              :value_omittable
-            end
-          end
-        end
-
-        def hash_with_mixed_shorthand_syntax?(hash_value_type_breakdown)
-          hash_value_type_breakdown.keys.size > 1
-        end
-
-        def hash_with_values_that_cant_be_omitted?(hash_value_type_breakdown)
-          hash_value_type_breakdown[:value_needed]&.any?
-        end
-
-        def each_omitted_value_pair(hash_value_type_breakdown, &)
-          hash_value_type_breakdown[:value_omitted]&.each(&)
-        end
-
-        def each_omittable_value_pair(hash_value_type_breakdown, &)
-          hash_value_type_breakdown[:value_omittable]&.each(&)
-        end
-
-        def mixed_shorthand_syntax_check(hash_value_type_breakdown)
-          if hash_with_values_that_cant_be_omitted?(hash_value_type_breakdown)
-            each_omitted_value_pair(hash_value_type_breakdown) do |pair_node|
-              hash_key_source = pair_node.key.source
-              replacement = "#{hash_key_source}: #{hash_key_source}"
-              register_offense(pair_node, DO_NOT_MIX_EXPLICIT_VALUE_MSG, replacement)
-            end
-          else
-            each_omittable_value_pair(hash_value_type_breakdown) do |pair_node|
-              hash_key_source = pair_node.key.source
-              replacement = "#{hash_key_source}:"
-              register_offense(pair_node, DO_NOT_MIX_OMIT_VALUE_MSG, replacement)
-            end
-          end
-        end
-
-        def no_mixed_shorthand_syntax_check(hash_value_type_breakdown)
-          return if hash_with_values_that_cant_be_omitted?(hash_value_type_breakdown)
-
-          each_omittable_value_pair(hash_value_type_breakdown) do |pair_node|
-            hash_key_source = pair_node.key.source
-            replacement = "#{hash_key_source}:"
-            register_offense(pair_node, OMIT_HASH_VALUE_MSG, replacement)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/decidim.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-module Rubocop
-  module Cop
-    class Decidim < Base
-      include HashShortandSyntaxBacports
-    end
-  end
-end