decidim-dev 0.26.8 → 0.27.0.rc1

data/lib/decidim/dev/test/rspec_support/imports_controller_shared_examples.rb

@@ -19,14 +19,9 @@ shared_examples "admin imports controller" do
   end
 
   describe "POST create" do
-    let(:file) do
-      # The file does not really matter for the dummies creator because it
-      # will always create a record for each data row regardless of the data.
-      Rack::Test::UploadedFile.new(
-        Decidim::Dev.test_file("import_proposals.csv", "text/csv"),
-        "text/csv"
-      )
-    end
+    # The file does not really matter for the dummies creator because it
+    # will always create a record for each data row regardless of the data.
+    let(:file) { upload_test_file(Decidim::Dev.test_file("import_proposals.csv", "text/csv")) }
     let(:params) do
       default_params.merge(extra_params).merge(file: file)
     end

data/lib/decidim/dev/test/rspec_support/network_conditions_helpers.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module NetworkConditionsHelpers
+  def with_browser_in_offline_mode
+    page.driver.browser.network_conditions = { offline: true }
+
+    # Wait for the browser to be offline
+    sleep 1
+
+    yield
+
+    page.driver.browser.network_conditions = { offline: false }
+  end
+end
+
+RSpec.configure do |config|
+  config.include NetworkConditionsHelpers, type: :system
+end

data/lib/decidim/dev/test/rspec_support/rake_tasks.rb

@@ -32,7 +32,6 @@ module RakeTaskOutputHelpers
   included do
     let!(:original_stdout) { $stdout }
 
-    # rubocop:disable RSpec/ExpectOutput
     before do
       $stdout = StringIO.new
     end
@@ -40,7 +39,6 @@ module RakeTaskOutputHelpers
     after do
       $stdout = original_stdout
     end
-    # rubocop:enable RSpec/ExpectOutput
   end
 
   def check_no_errors_have_been_printed

data/lib/decidim/dev/test/rspec_support/screenshot_helper.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require "action_dispatch/system_testing/test_helpers/screenshot_helper"
+
+module ActionDispatch
+  module SystemTesting
+    module TestHelpers
+      module ScreenshotHelper
+        private
+
+        # Customize the screenshot helper to fix the file paths for examples that have
+        # unallowed characters in them. Otherwise the artefacts creation and upload
+        # fails at GitHub actions. See the list of unallowed characters from:
+        # https://github.com/actions/toolkit/blob/main/packages/artifact/docs/additional-information.md#non-supported-characters
+        def image_name
+          # By default, this only cleans up the forward and backward slash characters.
+          sanitized_method_name = method_name.tr("/\\()\":<>|*?", "-----------")
+          name = "#{unique}_#{sanitized_method_name}"
+          name[0...225]
+        end
+
+        # Add the file URI scheme so terminal emulators can open one click
+        def display_image
+          message = +"[Screenshot Image]: file://#{image_path}\n"
+          message << +"[Screenshot HTML]: file://#{html_path}\n" if save_html?
+
+          case output_type
+          when "artifact"
+            message << "\e]1338;url=artifact://#{absolute_image_path}\a\n"
+          when "inline"
+            name = inline_base64(File.basename(absolute_image_path))
+            image = inline_base64(File.read(absolute_image_path))
+            message << "\e]1337;File=name=#{name};height=400px;inline=1:#{image}\a\n"
+          end
+
+          message
+        end
+      end
+    end
+  end
+end

data/lib/decidim/dev/test/rspec_support/warden.rb

@@ -18,6 +18,7 @@ end
 
 RSpec.configure do |config|
   config.include Decidim::WardenTestHelpers, type: :system
+  config.include Decidim::WardenTestHelpers, type: :request
   config.include Devise::Test::ControllerHelpers, type: :controller
 
   config.before :each, type: :cell do
@@ -30,4 +31,8 @@ RSpec.configure do |config|
   config.after :each, type: :system do
     Warden.test_reset!
   end
+
+  config.after :each, type: :request do
+    Warden.test_reset!
+  end
 end

data/lib/decidim/dev/test/rspec_support/wicked_pdf_assets_mock.rb

@@ -8,6 +8,10 @@ class WickedPdf
       def wicked_pdf_stylesheet_pack_tag(*sources)
         stylesheet_pack_tag(*sources)
       end
+
+      # Disables the images in the PDFs as those requests would be jamming under
+      # the test environment
+      def wicked_pdf_image_tag(img, options = {}); end
     end
   end
 end

data/lib/decidim/dev/test/spec_helper.rb

@@ -4,7 +4,6 @@ require "rails-controller-testing"
 require "rspec/rails"
 require "rspec/cells"
 require "byebug"
-require "rectify/rspec"
 require "wisper/rspec/stub_wisper_publisher"
 require "db-query-matchers"
 require "action_view/helpers/sanitize_helper"
@@ -14,13 +13,13 @@ require "decidim/dev/test/w3c_rspec_validators_overrides"
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./rspec_support/ and its subdirectories.
-Dir["#{__dir__}/rspec_support/**/*.rb"].sort.each { |f| require f }
+Dir["#{__dir__}/rspec_support/**/*.rb"].each { |f| require f }
 
 require_relative "factories"
 
 RSpec.configure do |config|
   config.color = true
-  config.fail_fast = ENV["FAIL_FAST"] == "true"
+  config.fail_fast = ENV.fetch("FAIL_FAST", nil) == "true"
   config.infer_spec_type_from_file_location!
   config.mock_with :rspec
   config.order = :random
@@ -32,7 +31,6 @@ RSpec.configure do |config|
   # instead of true.
   config.use_transactional_fixtures = true
 
-  config.include Rectify::RSpec::Helpers
   config.include ActionView::Helpers::SanitizeHelper
   config.include ERB::Util
 end

data/lib/decidim/dev/test/w3c_rspec_validators_overrides.rb

@@ -36,12 +36,10 @@ end
 # This allows us to dynamically load the validator URL from the ENV.
 module W3cRspecValidators
   class Config
-    # rubocop:disable Naming/MemoizedInstanceVariableName
     def self.get
       @config ||= {
         w3c_service_uri: ENV.fetch("VALIDATOR_HTML_URI", "https://validator.w3.org/nu/")
       }.stringify_keys
     end
-    # rubocop:enable Naming/MemoizedInstanceVariableName
   end
 end

data/lib/decidim/dev/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-dev version.
   module Dev
     def self.version
-      "0.26.8"
+      "0.27.0.rc1"
     end
   end
 end

data/lib/decidim-dev.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require "decidim/dev/engine" if Rails.env.development? || ENV["DECIDIM_DEV_ENGINE"]
+require "decidim/dev/engine" if Rails.env.development? || ENV.fetch("DECIDIM_DEV_ENGINE", nil)

data/lib/tasks/generators.rake

@@ -32,7 +32,9 @@ namespace :decidim do
       "--skip_spring",
       "--demo",
       "--force_ssl",
-      "false"
+      "false",
+      "--locales",
+      "en,ca,es"
     )
   end
 
@@ -48,7 +50,9 @@ namespace :decidim do
         "--recreate_db",
         "--seed_db",
         "--demo",
-        "--profiling"
+        "--profiling",
+        "--locales",
+        "en,ca,es"
       )
     end
   end

data/lib/tasks/lighthouse_report.rake

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+namespace :decidim do
+  namespace :lighthouse do
+    desc "Prepares seeds for Lighthouse report"
+    task prepare_urls: :environment do
+      # Lighhouse report is executed in CI and should check:
+      # - homepage
+      # - a participatory process page
+      # - a meeting page
+      # - a proposal page
+      #
+      # Because seeds make urls dynamic, this task updates the lighthouse configuration
+      # to add dynamically the urls to check.
+
+      host = "http://localhost:3000"
+      urls = ["/"]
+      urls << ::Decidim::ResourceLocatorPresenter.new(Decidim::ParticipatoryProcess.published.first).path
+      urls << ::Decidim::ResourceLocatorPresenter.new(Decidim::Meetings::Meeting.published.first).path
+      urls << ::Decidim::ResourceLocatorPresenter.new(Decidim::Proposals::Proposal.published.first).path
+
+      # Update lighthouse configuration with the urls
+      lighthouse_rc_path = Rails.root.join("../.lighthouserc.json")
+      lighthouserc = JSON.parse(File.read(lighthouse_rc_path))
+      lighthouserc["ci"]["collect"]["url"] = urls.map { |url| "#{host}#{url}" }
+      File.write(lighthouse_rc_path, lighthouserc.to_json)
+    end
+  end
+end

data/lib/tasks/locale_checker.rake

@@ -5,7 +5,7 @@ namespace :decidim do
   task check_locales: :environment do
     FileUtils.remove_dir("tmp/decidim_repo", true)
 
-    branch = ENV["TARGET_BRANCH"] || "develop"
+    branch = ENV.fetch("TARGET_BRANCH", nil) || "develop"
     status = system("git clone --depth=1 --single-branch --branch #{branch} https://github.com/decidim/decidim tmp/decidim_repo")
     return unless status
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-dev
 version: !ruby/object:Gem::Version
-  version: 0.26.8
+  version: 0.27.0.rc1
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-07-27 00:00:00.000000000 Z
+date: 2022-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -32,14 +32,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.26.8
+        version: 0.27.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.26.8
+        version: 0.27.0.rc1
 - !ruby/object:Gem::Dependency
   name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
@@ -144,14 +144,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.12'
+        version: '1.13'
+- !ruby/object:Gem::Dependency
+  name: parallel_tests
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.7'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.7'
 - !ruby/object:Gem::Dependency
   name: puma
   requirement: !ruby/object:Gem::Requirement
@@ -186,14 +200,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.4
+        version: 0.3.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.4
+        version: 0.3.7
 - !ruby/object:Gem::Dependency
   name: rspec-html-matchers
   requirement: !ruby/object:Gem::Requirement
@@ -256,98 +270,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.92.0
+        version: 1.28.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.92.0
+        version: 1.28.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.8'
+        version: '2.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.8'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.43.2
+        version: '2.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.43.2
+        version: '2.10'
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.142'
+        version: 4.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.142'
+        version: 4.1.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.19.0
+        version: 0.21.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.19.0
+        version: 0.21.0
 - !ruby/object:Gem::Dependency
   name: simplecov-cobertura
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.3.1
-- !ruby/object:Gem::Dependency
-  name: system_test_html_screenshots
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
+        version: 2.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: w3c_rspec_validators
   requirement: !ruby/object:Gem::Requirement
@@ -408,18 +408,15 @@ files:
 - app/mailers/decidim/dummy_resources/dummy_resource_mailer.rb
 - app/packs/entrypoints/decidim_dev.js
 - app/packs/entrypoints/decidim_dev.scss
-- app/packs/entrypoints/decidim_dev_test_custom_map.js
 - app/packs/images/decidim/decidim_dev_dummy.svg
 - app/packs/images/decidim/gamification/badges/decidim_gamification_badges_test.svg
 - app/packs/src/decidim/dev/accessibility.js
-- app/packs/src/decidim/dev/test/custom_map_factory.js
 - app/packs/stylesheets/decidim/dev.scss
 - app/packs/stylesheets/decidim/dev/_accessibility.scss
 - app/views/decidim/dummy_resource/_linked_dummys.html.erb
 - app/views/decidim/dummy_resources/dummy_resources/foo.html.erb
 - app/views/decidim/dummy_resources/dummy_resources/show.html.erb
 - config/assets.rb
-- config/environment.rb
 - config/locales/am-ET.yml
 - config/locales/ar-SA.yml
 - config/locales/ar.yml
@@ -442,7 +439,6 @@ files:
 - config/locales/et-EE.yml
 - config/locales/et.yml
 - config/locales/eu.yml
-- config/locales/fa-IR.yml
 - config/locales/fi-pl.yml
 - config/locales/fi-plain.yml
 - config/locales/fi.yml
@@ -451,7 +447,6 @@ files:
 - config/locales/fr.yml
 - config/locales/ga-IE.yml
 - config/locales/gl.yml
-- config/locales/gn-PY.yml
 - config/locales/hr-HR.yml
 - config/locales/hr.yml
 - config/locales/hu.yml
@@ -460,13 +455,10 @@ files:
 - config/locales/is.yml
 - config/locales/it.yml
 - config/locales/ja.yml
-- config/locales/ka-GE.yml
-- config/locales/kaa.yml
 - config/locales/ko-KR.yml
 - config/locales/ko.yml
 - config/locales/lb-LU.yml
 - config/locales/lb.yml
-- config/locales/lo-LA.yml
 - config/locales/lt-LT.yml
 - config/locales/lt.yml
 - config/locales/lv.yml
@@ -474,7 +466,6 @@ files:
 - config/locales/mt.yml
 - config/locales/nl.yml
 - config/locales/no.yml
-- config/locales/oc-FR.yml
 - config/locales/om-ET.yml
 - config/locales/pl.yml
 - config/locales/pt-BR.yml
@@ -528,6 +519,7 @@ files:
 - lib/decidim/dev/assets/import_voting_census_without_headers.csv
 - lib/decidim/dev/assets/invalid.jpeg
 - lib/decidim/dev/assets/iso-8859-15.md
+- lib/decidim/dev/assets/logo.png
 - lib/decidim/dev/assets/malicious.jpg
 - lib/decidim/dev/assets/participatory_processes.json
 - lib/decidim/dev/assets/participatory_processes_with_null.json
@@ -556,6 +548,7 @@ files:
 - lib/decidim/dev/test/rspec_support/active_job.rb
 - lib/decidim/dev/test/rspec_support/attachment_helpers.rb
 - lib/decidim/dev/test/rspec_support/authorization.rb
+- lib/decidim/dev/test/rspec_support/autocomplete_select.rb
 - lib/decidim/dev/test/rspec_support/caching.rb
 - lib/decidim/dev/test/rspec_support/capybara.rb
 - lib/decidim/dev/test/rspec_support/capybara_data_picker.rb
@@ -566,6 +559,9 @@ files:
 - lib/decidim/dev/test/rspec_support/component_context.rb
 - lib/decidim/dev/test/rspec_support/confirmation_helpers.rb
 - lib/decidim/dev/test/rspec_support/content_processing.rb
+- lib/decidim/dev/test/rspec_support/controller_example_group.rb
+- lib/decidim/dev/test/rspec_support/cookies.rb
+- lib/decidim/dev/test/rspec_support/dynamic_attach.rb
 - lib/decidim/dev/test/rspec_support/factory_bot.rb
 - lib/decidim/dev/test/rspec_support/frontend.rb
 - lib/decidim/dev/test/rspec_support/gamification.rb
@@ -574,13 +570,13 @@ files:
 - lib/decidim/dev/test/rspec_support/html_matchers.rb
 - lib/decidim/dev/test/rspec_support/imports_controller_shared_examples.rb
 - lib/decidim/dev/test/rspec_support/migration.rb
+- lib/decidim/dev/test/rspec_support/network_conditions_helpers.rb
 - lib/decidim/dev/test/rspec_support/orderly_matchers.rb
 - lib/decidim/dev/test/rspec_support/organization.rb
 - lib/decidim/dev/test/rspec_support/permissions_shared_examples.rb
 - lib/decidim/dev/test/rspec_support/rake_tasks.rb
-- lib/decidim/dev/test/rspec_support/react_select.rb
 - lib/decidim/dev/test/rspec_support/route_helpers.rb
-- lib/decidim/dev/test/rspec_support/summary_notification.rb
+- lib/decidim/dev/test/rspec_support/screenshot_helper.rb
 - lib/decidim/dev/test/rspec_support/time_helpers.rb
 - lib/decidim/dev/test/rspec_support/timezone.rb
 - lib/decidim/dev/test/rspec_support/translation_helpers.rb
@@ -592,9 +588,8 @@ files:
 - lib/decidim/dev/test/spec_helper.rb
 - lib/decidim/dev/test/w3c_rspec_validators_overrides.rb
 - lib/decidim/dev/version.rb
-- lib/rubocop/cop/decidim.rb
-- lib/rubocop/cop/decidim/hash_shorthand_syntax_backports.rb
 - lib/tasks/generators.rake
+- lib/tasks/lighthouse_report.rake
 - lib/tasks/locale_checker.rake
 homepage: https://github.com/decidim/decidim
 licenses:
@@ -608,14 +603,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Decidim dev tools

data/app/packs/entrypoints/decidim_dev_test_custom_map.js

@@ -1 +0,0 @@
-import "src/decidim/dev/test/custom_map_factory";

data/app/packs/src/decidim/dev/test/custom_map_factory.js

@@ -1,55 +0,0 @@
-/**
- * Example of a custom map controller and how to override the
- * `createMapController` factory method. To use it in the ERB view, add the
- * following snippet to any view:
- *
- * <%= dynamic_map_for type: "custom", markers: [{ title: "Test 1", latitude: 41.385063, longitude: 2.173404 }], popup_template_id: "custom-popup" do %>
- *  <% javascript_pack_tag("decidim_dev_test_custom_map") %>
- *  <template id="custom-popup">
- *    <div>
- *      <h3>${title}</h3>
- *    </div>
- *  </template>
- * <% end %>
- */
-
-import MapMarkersController from "src/decidim/map/controller/markers";
-
-const appendToBody = (content) => {
-  const p = document.createElement("p");
-  p.innerHTML = content;
-  document.body.appendChild(p);
-}
-
-class CustomMapController extends MapMarkersController {
-  start() {
-    this.markerClusters = null;
-    this.addMarkers(this.config.markers);
-
-    appendToBody("Custom map started");
-  }
-}
-
-const origCreateMapController = window.Decidim.createMapController;
-
-const createMapController = (mapId, config) => {
-  if (config.type === "custom") {
-    return new CustomMapController(mapId, config);
-  }
-
-  return origCreateMapController(mapId, config);
-}
-
-window.Decidim.createMapController = createMapController;
-
-// Prevent external requests to the Here URLs during tests
-if (L.TileLayer.HERE) {
-  L.TileLayer.HERE.prototype.onAdd = function(map) {};
-}
-
-// Test that the map events are working correctly
-$("[data-decidim-map]").on("ready.decidim", (ev, _map, mapConfig) => {
-  appendToBody("Custom map ready");
-});
-
-appendToBody("LOADED");

data/config/locales/fa-IR.yml

@@ -1 +0,0 @@
-fa:

data/config/locales/gn-PY.yml

@@ -1 +0,0 @@
-gn:

data/config/locales/ka-GE.yml

@@ -1 +0,0 @@
-ka:

data/config/locales/kaa.yml

@@ -1 +0,0 @@
-kaa:

data/config/locales/lo-LA.yml

@@ -1 +0,0 @@
-lo:

data/config/locales/oc-FR.yml

@@ -1 +0,0 @@
-oc: