decidim-dev 0.26.0 → 0.27.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5211d30543bd442eff253804b25b338328b7dcd23239a8471857e4591b3ae5cb
-  data.tar.gz: 26ca4e5657a7b4293d7a43ba50f1c6857e3c470b7197585c58f2fcaa39587b09
+  metadata.gz: 352297a2285a46b08d1d758ef879cb997dd0c4cd6fc5d4413a3db9503ba04a24
+  data.tar.gz: '0099b3b7b5e6566b5f3f3dfb1c44cbf5e3e871b976e8e453d3d668e2a4f161cb'
 SHA512:
-  metadata.gz: f23e257022ba88956a2cabd533909044aeab7cb51661a2e384a13b438d62c7f8582990804d62d4dc8d794e5231dfe9acfdf46eba12050037b8308df609592f9c
-  data.tar.gz: eb8cc457f65a9d468993a392f40cf4d49dbc01938f69c778723acf9ad6e6e7b5b2fa9ec7c96a76e66e37682db4b5e2f94a86547da952cba029998f4d9da6be6d
+  metadata.gz: 3dff37974008ead98152ef3f156e3f73e082af7477c72c84c0f5e8f18204510d3a3c46605a88842289da7a57e228e2f2da3744d9aab59de2497f8aca5e5075e9
+  data.tar.gz: ed2983e1a820fa3686cf6f5a7cae8d64d9aaf4e473ccda2952f291d795ffe87f95555864d30c56b91523a4ce0ee003b1d1dd3eefa8226c96266ea2a59b183537

data/app/commands/decidim/dummy_resources/create_dummy_resource.rb

@@ -2,7 +2,7 @@
 
 module Decidim
   module DummyResources
-    class CreateDummyResource < Rectify::Command
+    class CreateDummyResource < Decidim::Command
       include Decidim::AttachmentMethods
       include Decidim::GalleryMethods
 

data/app/controllers/concerns/decidim/dev/needs_development_tools.rb

@@ -18,7 +18,7 @@ module Decidim
         return unless respond_to?(:snippets)
 
         snippets.add(:head, helpers.stylesheet_pack_tag("decidim_dev"))
-        snippets.add(:head, helpers.javascript_pack_tag("decidim_dev"))
+        snippets.add(:foot, helpers.javascript_pack_tag("decidim_dev", defer: false))
       end
     end
   end

data/config/locales/am-ET.yml

@@ -1 +1,2 @@
+---
 am:

data/config/locales/ar.yml

@@ -1,3 +1,4 @@
+---
 ar:
   activemodel:
     attributes:

data/config/locales/bg.yml

@@ -1,3 +1,4 @@
+---
 bg:
   activemodel:
     attributes:

data/config/locales/ca.yml

@@ -1,3 +1,4 @@
+---
 ca:
   activemodel:
     attributes:

data/config/locales/cs.yml

@@ -1,3 +1,4 @@
+---
 cs:
   activemodel:
     attributes:

data/config/locales/da.yml

@@ -1 +1,2 @@
+---
 da:

data/config/locales/de.yml

@@ -1,3 +1,4 @@
+---
 de:
   activemodel:
     attributes:

data/config/locales/el.yml

@@ -1,3 +1,4 @@
+---
 el:
   activemodel:
     attributes:

data/config/locales/eo.yml

@@ -1 +1,2 @@
+---
 eo:

data/config/locales/es-MX.yml

@@ -1,3 +1,4 @@
+---
 es-MX:
   activemodel:
     attributes:

data/config/locales/es-PY.yml

@@ -1,3 +1,4 @@
+---
 es-PY:
   activemodel:
     attributes:

data/config/locales/es.yml

@@ -1,3 +1,4 @@
+---
 es:
   activemodel:
     attributes:

data/config/locales/et.yml

@@ -1 +1,2 @@
+---
 et:

data/config/locales/eu.yml

@@ -1,3 +1,4 @@
+---
 eu:
   activemodel:
     attributes:

data/config/locales/fi-plain.yml

@@ -1,3 +1,4 @@
+---
 fi-pl:
   activemodel:
     attributes:

data/config/locales/fi.yml

@@ -1,3 +1,4 @@
+---
 fi:
   activemodel:
     attributes:

data/config/locales/fr-CA.yml

@@ -1,3 +1,4 @@
+---
 fr-CA:
   activemodel:
     attributes:

data/config/locales/fr.yml

@@ -1,3 +1,4 @@
+---
 fr:
   activemodel:
     attributes:

data/config/locales/ga-IE.yml

@@ -1,3 +1,4 @@
+---
 ga:
   activemodel:
     attributes:

data/config/locales/gl.yml

@@ -1,3 +1,4 @@
+---
 gl:
   activemodel:
     attributes:

data/config/locales/hr.yml

@@ -1 +1,2 @@
+---
 hr:

data/config/locales/hu.yml

@@ -1,3 +1,4 @@
+---
 hu:
   activemodel:
     attributes:

data/config/locales/id-ID.yml

@@ -1,3 +1,4 @@
+---
 id:
   activemodel:
     attributes:

data/config/locales/is-IS.yml

@@ -1,4 +1,5 @@
-is-IS:
+---
+is:
   activemodel:
     attributes:
       dummy_resource:

data/config/locales/it.yml

@@ -1,3 +1,4 @@
+---
 it:
   activemodel:
     attributes:

data/config/locales/ja.yml

@@ -1,3 +1,4 @@
+---
 ja:
   activemodel:
     attributes:

data/config/locales/ko.yml

@@ -1 +1,2 @@
+---
 ko:

data/config/locales/lb.yml

@@ -1 +1,2 @@
+---
 lb:

data/config/locales/lt.yml

@@ -1 +1,2 @@
+---
 lt:

data/config/locales/lv.yml

@@ -1,3 +1,4 @@
+---
 lv:
   activemodel:
     attributes:

data/config/locales/mt.yml

@@ -1 +1,2 @@
+---
 mt:

data/config/locales/nl.yml

@@ -1,3 +1,4 @@
+---
 nl:
   activemodel:
     attributes:

data/config/locales/no.yml

@@ -1,3 +1,4 @@
+---
 "no":
   activemodel:
     attributes:

data/config/locales/om-ET.yml

@@ -1 +1,2 @@
+---
 om:

data/config/locales/pl.yml

@@ -1,3 +1,4 @@
+---
 pl:
   activemodel:
     attributes:

data/config/locales/pt-BR.yml

@@ -1,4 +1,5 @@
-pt-BR:
+---
+pt:
   activemodel:
     attributes:
       dummy_resource:

data/config/locales/pt.yml

@@ -1,3 +1,4 @@
+---
 pt:
   activemodel:
     attributes:

data/config/locales/ro-RO.yml

@@ -1,3 +1,4 @@
+---
 ro:
   activemodel:
     attributes:

data/config/locales/ru.yml

@@ -1,3 +1,4 @@
+---
 ru:
   activemodel:
     attributes:

data/config/locales/si-LK.yml

@@ -1 +1,2 @@
+---
 si:

data/config/locales/sk.yml

@@ -1,3 +1,4 @@
+---
 sk:
   activemodel:
     attributes:

data/config/locales/sl.yml

@@ -1,3 +1,4 @@
+---
 sl:
   activemodel:
     attributes:

data/config/locales/so-SO.yml

@@ -1 +1,2 @@
+---
 so:

data/config/locales/sr-CS.yml

@@ -1,3 +1,4 @@
+---
 sr:
   decidim:
     components:

data/config/locales/sv.yml

@@ -1,3 +1,4 @@
+---
 sv:
   activemodel:
     attributes:

data/config/locales/sw-KE.yml

@@ -1 +1,2 @@
+---
 sw:

data/config/locales/ti-ER.yml

@@ -1 +1,2 @@
+---
 ti:

data/config/locales/tr-TR.yml

@@ -1,3 +1,4 @@
+---
 tr:
   activemodel:
     attributes:

data/config/locales/uk.yml

@@ -1,3 +1,4 @@
+---
 uk:
   activemodel:
     attributes:

data/config/locales/val-ES.yml

@@ -1 +1,2 @@
+---
 val:

data/config/locales/vi.yml

@@ -1 +1,2 @@
+---
 vi:

data/config/locales/zh-CN.yml

@@ -1,3 +1,4 @@
+---
 zh-CN:
   activemodel:
     attributes:

data/config/locales/zh-TW.yml

@@ -1 +1,2 @@
+---
 zh-TW:

data/lib/decidim/dev/assets/geocoder_result_here.json

@@ -1,72 +1,51 @@
 {
-    "Response": {
-      "MetaInfo": {
-        "Timestamp": "2013-02-08T16:26:39.382+0000"
+  "items": [
+    {
+      "title": "5 Rue Daunou, 75002 Paris, France",
+      "id": "here:af:streetsection:bI4Le6cyA.1mlQyLunYpjC:CggIBCCi-9SPARABGgE1KGQ",
+      "resultType": "houseNumber",
+      "houseNumberType": "PA",
+      "address": {
+        "label": "5 Rue Daunou, 75002 Paris, France",
+        "countryCode": "FRA",
+        "countryName": "France",
+        "stateCode": "IDF",
+        "state": "Île-de-France",
+        "county": "Paris",
+        "city": "Paris",
+        "district": "2e Arrondissement",
+        "street": "Rue Daunou",
+        "postalCode": "75002",
+        "houseNumber": "5"
       },
-      "View": [
+      "position": {
+        "lat": 48.86926,
+        "lng": 2.3321
+      },
+      "access": [
         {
-          "_type": "SearchResultsViewType",
-          "ViewId": 0,
-          "Result": [
-            {
-              "Relevance": 1.0,
-              "MatchLevel": "houseNumber",
-              "MatchQuality": {
-                "State": 1.0,
-                "City": 1.0,
-                "Street": [
-                  1.0
-                ],
-                "HouseNumber": 1.0
-              },
-              "MatchType": "pointAddress",
-              "Location": {
-                "LocationId": "NT_ArsGdYbpo6dqjPQel9gTID_4",
-                "LocationType": "point",
-                "DisplayPosition": {
-                  "Latitude": 40.7504692,
-                  "Longitude": -73.9933777
-                },
-                "NavigationPosition": [
-                  {
-                    "Latitude": 40.7500305,
-                    "Longitude": -73.9942398
-                  }
-                ],
-                "MapView": {
-                  "TopLeft": {
-                    "Latitude": 40.7515934,
-                    "Longitude": -73.9948616
-                  },
-                  "BottomRight": {
-                    "Latitude": 40.7493451,
-                    "Longitude": -73.9918938
-                  }
-                },
-                "Address": {
-                  "Label": "4 Penn Plz, New York, NY 10001, United States",
-                  "Country": "USA",
-                  "State": "NY",
-                  "County": "New York",
-                  "City": "New York",
-                  "Street": "Penn Plz",
-                  "HouseNumber": "4",
-                  "PostalCode": "10001",
-                  "AdditionalData": [
-                    {
-                      "value": "United States",
-                      "key": "CountryName"
-                    },
-                    {
-                      "value": "New York",
-                      "key": "StateName"
-                    }
-                  ]
-                }
-              }
-            }
-          ]
+          "lat": 48.86931,
+          "lng": 2.33215
+        }
+      ],
+      "mapView": {
+        "west": 2.33073,
+        "south": 48.86836,
+        "east": 2.33347,
+        "north": 48.87016
+      },
+      "scoring": {
+        "queryScore": 0.97,
+        "fieldScore": {
+          "country": 1,
+          "city": 1,
+          "streets": [
+            1
+          ],
+          "houseNumber": 1,
+          "postalCode": 0.82
         }
-      ]
+      }
     }
-  }
+  ]
+}

data/lib/decidim/dev/common_rake.rb

@@ -3,6 +3,7 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "decidim/dev"
+require "parallel_tests/tasks"
 
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.rspec_opts = "--format progress --format RspecJunitFormatter -o ~/rspec/rspec.xml" if ENV["CI"]

data/lib/decidim/dev/railtie.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "rails"
+require "decidim/rails"
 
 module Decidim
   module Dev

data/lib/decidim/dev/test/base_spec_helper.rb

@@ -3,6 +3,7 @@
 require "decidim/dev"
 
 ENV["RAILS_ENV"] ||= "test"
+ENV["RAILS_SYSTEM_TESTING_SCREENSHOT_HTML"] ||= "1"
 
 engine_spec_dir = File.join(Dir.pwd, "spec")
 
@@ -11,13 +12,14 @@ require "simplecov" if ENV["SIMPLECOV"]
 require "decidim/core"
 require "decidim/core/test"
 require "decidim/admin/test"
+require "decidim/api/test"
 
 require_relative "rspec_support/component"
 require_relative "rspec_support/authorization"
 
 require "#{Decidim::Dev.dummy_app_path}/config/environment"
 
-Dir["#{engine_spec_dir}/shared/**/*.rb"].sort.each { |f| require f }
+Dir["#{engine_spec_dir}/shared/**/*.rb"].each { |f| require f }
 
 require "paper_trail/frameworks/rspec"
 

data/lib/decidim/dev/test/rspec_support/attachment_helpers.rb

@@ -9,6 +9,36 @@ module AttachmentHelpers
   def attachment_file_size(attachment)
     ActiveSupport::NumberHelper.number_to_human_size(attachment.file_size)
   end
+
+  # Creates ActiveStorage::Blob object and returns its signed_id
+  # Used in non-system tests that need files.
+  def upload_test_file(file, options = {})
+    filename = options[:filename] || upload_test_file_filename(file)
+    content_type = options[:content_type] || upload_test_file_content_type(file)
+
+    blob = ActiveStorage::Blob.create_and_upload!(
+      io: File.open(file),
+      filename: filename,
+      content_type: content_type
+    )
+    return blob if options[:return_blob]
+
+    blob.signed_id
+  end
+
+  private
+
+  def upload_test_file_filename(file)
+    return file.original_filename if file.respond_to? :original_filename
+
+    file.split("/").last
+  end
+
+  def upload_test_file_content_type(file)
+    return file.content_type if file.respond_to? :content_type
+
+    MIME::Types.type_for(file).first.content_type
+  end
 end
 
 RSpec.configure do |config|

data/lib/decidim/dev/test/rspec_support/autocomplete_select.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Capybara
+  module AutoCompleteJS
+    def autocomplete_select(value, from:)
+      within("div[data-autocomplete-for='#{from}']") do
+        find(".autocomplete-input").click
+        find(".autocomplete-input").native.send_keys(value[0..4])
+        expect(page).to have_css("#autoComplete_list_1") # select should be open now
+
+        expect(page).to have_css("#autoComplete_result_0", text: value)
+        find("#autoComplete_result_0", text: value).hover
+        expect(page).to have_css("#autoComplete_result_0", text: value)
+        find("#autoComplete_result_0", text: value).click
+        expect(page).to have_css(".autocomplete__selected-item", text: value)
+      end
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include Capybara::AutoCompleteJS, type: :system
+end

data/lib/decidim/dev/test/rspec_support/capybara.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "selenium-webdriver"
-require "system_test_html_screenshots"
 
 module Decidim
   # Helpers meant to be used only during capybara test runs.
@@ -32,11 +31,40 @@ Capybara.register_driver :headless_chrome do |app|
                   else
                     "--window-size=1920,1080"
                   end
+  Capybara::Selenium::Driver.new(
+    app,
+    browser: :chrome,
+    capabilities: [options]
+  )
+end
+
+Capybara.server_port = rand(5000..6999)
+
+# In order to work with PWA apps, Chrome can't be run in headless mode, and requires
+# setting up special prefs and flags
+Capybara.register_driver :pwa_chrome do |app|
+  options = ::Selenium::WebDriver::Chrome::Options.new
+  options.args << "--no-sandbox"
+  # Don't limit browser resources
+  options.args << "--disable-dev-shm-usage"
+  # Add pwa.lvh.me host as a secure origin
+  options.args << "--unsafely-treat-insecure-origin-as-secure=http://pwa.lvh.me:#{Capybara.server_port}"
+  # User data flag is mandatory when preferences and locale state is set
+  options.args << "--user-data-dir=/tmp/decidim_tests_user_data_#{rand(1000)}"
+  options.args << if ENV["BIG_SCREEN_SIZE"].present?
+                    "--window-size=1920,3000"
+                  else
+                    "--window-size=1920,1080"
+                  end
+  # Set notifications allowed in http protocol
+  options.local_state["browser.enabled_labs_experiments"] = ["enable-system-notifications@1", "unsafely-treat-insecure-origin-as-secure"]
+  # Mark notification permission as enabled
+  options.prefs["profile.default_content_setting_values.notifications"] = 1
 
   Capybara::Selenium::Driver.new(
     app,
     browser: :chrome,
-    options: options
+    capabilities: [options]
   )
 end
 
@@ -49,11 +77,11 @@ Capybara.register_driver :iphone do |app|
   Capybara::Selenium::Driver.new(
     app,
     browser: :chrome,
-    options: options
+    capabilities: [options]
   )
 end
 
-Capybara.server = :puma, { Silent: true, Threads: "1:1" }
+Capybara.server = :puma, { Silent: true, queue_requests: false }
 
 Capybara.asset_host = "http://localhost:3000"
 
@@ -65,6 +93,16 @@ RSpec.configure do |config|
   config.before :each, type: :system do
     driven_by(:headless_chrome)
     switch_to_default_host
+    domain = (try(:organization) || try(:current_organization))&.host
+    if domain
+      page.driver.browser.execute_cdp(
+        "Network.setCookie",
+        domain: domain,
+        name: Decidim.consent_cookie_name,
+        value: { essential: true }.to_json,
+        path: "/"
+      )
+    end
   end
 
   config.before :each, driver: :rack_test do
@@ -80,7 +118,7 @@ RSpec.configure do |config|
   end
 
   config.after(type: :system) do |example|
-    warn page.driver.browser.manage.logs.get(:browser) unless example.metadata[:driver].eql?(:rack_test)
+    warn page.driver.browser.logs.get(:browser) unless example.metadata[:driver].eql?(:rack_test)
   end
 
   config.include Decidim::CapybaraTestHelpers, type: :system