decidim-dev 0.24.0 → 0.25.0.rc1

data/lib/decidim/dev/test/rspec_support/capybara_data_picker.rb

@@ -17,7 +17,7 @@ module Capybara
 
     def data_picker_pick_current
       body = find(:xpath, "//body")
-      expect(body).to have_selector("#data_picker-modal .picker-footer a[data-picker-choose]")
+      expect(body).to have_selector("#data_picker-modal .picker-footer a[data-picker-choose]", wait: 2)
       body.find("#data_picker-modal .picker-footer a[data-picker-choose]").click
     end
 

data/lib/decidim/dev/test/rspec_support/capybara_scopes_picker.rb

@@ -10,6 +10,7 @@ module Capybara
       match do |scope_picker|
         data_picker = scope_picker.data_picker
         scope_name = expected ? translated(expected.name) : t("decidim.scopes.global")
+
         expect(data_picker).to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: :all)
         expect(data_picker).to have_selector(:xpath, "//div[contains(@class,'picker-values')]/div/a[text()[contains(.,'#{scope_name}')]]")
       end
@@ -38,7 +39,9 @@ module Capybara
       expect(scope_picker).to have_scope_picked(scope)
     end
 
-    def scope_repick(scope_picker, old_scope, new_scope)
+    def scope_repick(element_id, old_scope, new_scope)
+      scope_picker = select_data_picker(element_id)
+
       data_picker = scope_picker.data_picker
 
       expect(data_picker).to have_selector(".picker-values div input[value='#{old_scope&.id || scope_picker.global_value}']", visible: :all)
@@ -51,6 +54,8 @@ module Capybara
       scope_picker_browse_scopes(new_scope.part_of_scopes - old_scope.part_of_scopes)
       data_picker_pick_current
 
+      scope_picker = select_data_picker(element_id)
+
       expect(scope_picker).to have_scope_picked(new_scope)
     end
 
@@ -68,6 +73,7 @@ module Capybara
     def scope_picker_browse_scopes(scopes)
       scopes.each do |scope|
         scope_picker_browse_scope(scope)
+        sleep(2)
       end
     end
 

data/lib/decidim/dev/test/rspec_support/component.rb

@@ -115,6 +115,11 @@ module Decidim
         component.can_participate_in_space?(user)
       end
 
+      # Public: Whether the object can have new comment votes or not.
+      def user_allowed_to_vote_comment?(user)
+        component.can_participate_in_space?(user)
+      end
+
       def self.user_collection(user)
         where(decidim_author_id: user.id, decidim_author_type: "Decidim::User")
       end
@@ -179,6 +184,10 @@ class DummySerializer
     @id = id
   end
 
+  def run
+    serialize
+  end
+
   def serialize
     {
       id: @id
@@ -189,7 +198,7 @@ end
 Decidim.register_component(:dummy) do |component|
   component.engine = Decidim::DummyResources::DummyEngine
   component.admin_engine = Decidim::DummyResources::DummyAdminEngine
-  component.icon = "decidim/dummy.svg"
+  component.icon = "media/images/decidim_dev_dummy.svg"
 
   component.actions = %w(foo bar)
 

data/lib/decidim/dev/test/rspec_support/geocoder.rb

@@ -61,7 +61,7 @@ module Decidim::Map::Provider
 
       class Builder < Decidim::Map::Autocomplete::Builder
         def javascript_snippets
-          template.javascript_include_tag("decidim/geocoding/provider/photon")
+          template.javascript_pack_tag("decidim_geocoding_provider_photon")
         end
       end
     end

data/lib/decidim/dev/test/rspec_support/migration.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+module Decidim
+  module MigrationTestGroup
+    extend ActiveSupport::Concern
+
+    included do
+      subject { migration }
+
+      let(:migration) do |example|
+        struct = migration_for(example)
+        require Rails.root.join(struct.filename)
+        struct.name.constantize.new
+      end
+
+      around do |example|
+        ActiveRecord::Migration.suppress_messages do
+          example.run
+        end
+      end
+    end
+
+    private
+
+    def migration_name_for(example)
+      group = example.metadata[:example_group]
+      group = group[:parent_example_group] while group[:parent_example_group]
+      group[:description]
+    end
+
+    def migration_for(example)
+      migration_name = migration_name_for(example)
+      struct = migrations.find { |m| m.name == migration_name }
+      raise NameError, "Unexisting migration: `#{migration_name}`" unless struct
+
+      struct
+    end
+
+    def migrations
+      ActiveRecord::MigrationContext.new(
+        [Rails.root.join("db/migrate")],
+        ActiveRecord::SchemaMigration
+      ).migrations
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include Decidim::MigrationTestGroup, type: :migration
+end

data/lib/decidim/dev/test/rspec_support/time_helpers.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.include ActiveSupport::Testing::TimeHelpers
+end

data/lib/decidim/dev/test/rspec_support/webmock.rb

@@ -2,4 +2,4 @@
 
 require "webmock/rspec"
 
-WebMock.disable_net_connect!(allow_localhost: true)
+WebMock.disable_net_connect!(allow_localhost: true, allow: %r{https://validator.w3.org/})

data/lib/decidim/dev/test/rspec_support/wicked_pdf_assets_mock.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class WickedPdf
+  module WickedPdfHelper
+    module Assets
+      # Force wicked_pdf styles to have a relative path, to prevent fetching
+      # them from a host
+      def wicked_pdf_stylesheet_pack_tag(*sources)
+        stylesheet_pack_tag(*sources)
+      end
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include WickedPdf::WickedPdfHelper::Assets
+end

data/lib/decidim/dev/test/spec_helper.rb

@@ -8,6 +8,8 @@ require "rectify/rspec"
 require "wisper/rspec/stub_wisper_publisher"
 require "db-query-matchers"
 require "action_view/helpers/sanitize_helper"
+require "axe-rspec"
+require "w3c_rspec_validators"
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./rspec_support/ and its subdirectories.

data/lib/decidim/dev/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-dev version.
   module Dev
     def self.version
-      "0.24.0"
+      "0.25.0.rc1"
     end
   end
 end

data/lib/tasks/generators.rake

@@ -29,7 +29,10 @@ namespace :decidim do
       "../..",
       "--recreate_db",
       "--skip_gemfile",
-      "--demo"
+      "--skip_spring",
+      "--demo",
+      "--force_ssl",
+      "false"
     )
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-dev
 version: !ruby/object:Gem::Version
-  version: 0.24.0
+  version: 0.25.0.rc1
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-26 00:00:00.000000000 Z
+date: 2021-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -32,14 +32,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.24.0
+        version: 0.25.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.24.0
+        version: 0.25.0.rc1
 - !ruby/object:Gem::Dependency
   name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
@@ -54,6 +54,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.8'
+- !ruby/object:Gem::Dependency
+  name: axe-core-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.1.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -74,28 +88,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: erb_lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.28
+        version: 0.0.35
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.28
+        version: 0.0.35
 - !ruby/object:Gem::Dependency
   name: i18n-tasks
   requirement: !ruby/object:Gem::Requirement
@@ -133,7 +147,7 @@ dependencies:
         version: '1.11'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.1
+        version: 1.11.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -143,21 +157,7 @@ dependencies:
         version: '1.11'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.1
-- !ruby/object:Gem::Dependency
-  name: puffing-billy
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.4.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 1.11.4
 - !ruby/object:Gem::Dependency
   name: puma
   requirement: !ruby/object:Gem::Requirement
@@ -234,14 +234,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rspec-retry
   requirement: !ruby/object:Gem::Requirement
@@ -276,28 +276,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.21'
+        version: 1.43.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.21'
+        version: 1.43.2
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -346,28 +346,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: '0.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.1
+        version: '0.2'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: w3c_rspec_validators
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -407,15 +407,22 @@ extra_rdoc_files: []
 files:
 - README.md
 - Rakefile
-- app/assets/images/decidim/dummy.svg
-- app/assets/images/decidim/gamification/badges/test.svg
 - app/commands/decidim/dummy_resources/create_dummy_resource.rb
+- app/controllers/concerns/decidim/dev/needs_development_tools.rb
 - app/controllers/decidim/dummy_resources/dummy_resources_controller.rb
 - app/forms/decidim/dummy_resources/dummy_resource_form.rb
 - app/mailers/decidim/dummy_resources/dummy_resource_mailer.rb
+- app/packs/entrypoints/decidim_dev.js
+- app/packs/entrypoints/decidim_dev.scss
+- app/packs/images/decidim/decidim_dev_dummy.svg
+- app/packs/images/decidim/gamification/badges/decidim_gamification_badges_test.svg
+- app/packs/src/decidim/dev/accessibility.js
+- app/packs/stylesheets/decidim/dev.scss
+- app/packs/stylesheets/decidim/dev/_accessibility.scss
 - app/views/decidim/dummy_resource/_linked_dummys.html.erb
 - app/views/decidim/dummy_resources/dummy_resources/foo.html.erb
 - app/views/decidim/dummy_resources/dummy_resources/show.html.erb
+- config/assets.rb
 - config/locales/am-ET.yml
 - config/locales/ar-SA.yml
 - config/locales/ar.yml
@@ -442,6 +449,7 @@ files:
 - config/locales/fi-plain.yml
 - config/locales/fi.yml
 - config/locales/fr-CA.yml
+- config/locales/fr-LU.yml
 - config/locales/fr.yml
 - config/locales/ga-IE.yml
 - config/locales/gl.yml
@@ -452,10 +460,10 @@ files:
 - config/locales/is-IS.yml
 - config/locales/is.yml
 - config/locales/it.yml
-- config/locales/ja-JP.yml
 - config/locales/ja.yml
 - config/locales/ko-KR.yml
 - config/locales/ko.yml
+- config/locales/lb-LU.yml
 - config/locales/lt-LT.yml
 - config/locales/lt.yml
 - config/locales/lv.yml
@@ -484,6 +492,7 @@ files:
 - config/locales/vi.yml
 - config/locales/zh-CN.yml
 - config/locales/zh-TW.yml
+- lib/decidim-dev.rb
 - lib/decidim/dev.rb
 - lib/decidim/dev/assets/5000x5000.png
 - lib/decidim/dev/assets/Exampledocument.pdf
@@ -500,10 +509,13 @@ files:
 - lib/decidim/dev/assets/id.jpg
 - lib/decidim/dev/assets/import_participatory_space_private_users.csv
 - lib/decidim/dev/assets/import_participatory_space_private_users_nok.csv
+- lib/decidim/dev/assets/import_participatory_space_private_users_with_bom.csv
 - lib/decidim/dev/assets/import_proposals.csv
 - lib/decidim/dev/assets/import_proposals.json
-- lib/decidim/dev/assets/import_proposals.xls
+- lib/decidim/dev/assets/import_proposals.xlsx
 - lib/decidim/dev/assets/import_proposals_broken.csv
+- lib/decidim/dev/assets/import_voting_census.csv
+- lib/decidim/dev/assets/import_voting_census_with_ballot_styles.csv
 - lib/decidim/dev/assets/invalid.jpeg
 - lib/decidim/dev/assets/iso-8859-15.md
 - lib/decidim/dev/assets/malicious.jpg
@@ -519,17 +531,19 @@ files:
 - lib/decidim/dev/assets/verify_user_groups.csv
 - lib/decidim/dev/common_rake.rb
 - lib/decidim/dev/dummy_translator.rb
+- lib/decidim/dev/engine.rb
 - lib/decidim/dev/railtie.rb
 - lib/decidim/dev/test/authorization_shared_examples.rb
 - lib/decidim/dev/test/base_spec_helper.rb
 - lib/decidim/dev/test/factories.rb
 - lib/decidim/dev/test/form_to_param_shared_examples.rb
 - lib/decidim/dev/test/promoted_participatory_processes_shared_examples.rb
+- lib/decidim/dev/test/rspec_support/accessibility_examples.rb
 - lib/decidim/dev/test/rspec_support/action_mailer.rb
 - lib/decidim/dev/test/rspec_support/active_job.rb
 - lib/decidim/dev/test/rspec_support/attachment_helpers.rb
-- lib/decidim/dev/test/rspec_support/attachments.rb
 - lib/decidim/dev/test/rspec_support/authorization.rb
+- lib/decidim/dev/test/rspec_support/caching.rb
 - lib/decidim/dev/test/rspec_support/capybara.rb
 - lib/decidim/dev/test/rspec_support/capybara_data_picker.rb
 - lib/decidim/dev/test/rspec_support/capybara_scopes_picker.rb
@@ -545,18 +559,19 @@ files:
 - lib/decidim/dev/test/rspec_support/geocoder.rb
 - lib/decidim/dev/test/rspec_support/helpers.rb
 - lib/decidim/dev/test/rspec_support/html_matchers.rb
+- lib/decidim/dev/test/rspec_support/migration.rb
 - lib/decidim/dev/test/rspec_support/orderly_matchers.rb
 - lib/decidim/dev/test/rspec_support/organization.rb
 - lib/decidim/dev/test/rspec_support/permissions_shared_examples.rb
-- lib/decidim/dev/test/rspec_support/puffing_billy.rb
 - lib/decidim/dev/test/rspec_support/rake_tasks.rb
 - lib/decidim/dev/test/rspec_support/react_select.rb
 - lib/decidim/dev/test/rspec_support/route_helpers.rb
+- lib/decidim/dev/test/rspec_support/time_helpers.rb
 - lib/decidim/dev/test/rspec_support/timezone.rb
 - lib/decidim/dev/test/rspec_support/translation_helpers.rb
-- lib/decidim/dev/test/rspec_support/vcr.rb
 - lib/decidim/dev/test/rspec_support/warden.rb
 - lib/decidim/dev/test/rspec_support/webmock.rb
+- lib/decidim/dev/test/rspec_support/wicked_pdf_assets_mock.rb
 - lib/decidim/dev/test/rspec_support/wisper.rb
 - lib/decidim/dev/test/rspec_support/z_download_helper.rb
 - lib/decidim/dev/test/spec_helper.rb
@@ -578,11 +593,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Decidim dev tools