decidim-dev 0.22.0 → 0.23.3

data/lib/decidim/dev/test/rspec_support/component_context.rb

@@ -19,8 +19,7 @@ shared_context "with a component" do
            participatory_space: participatory_space)
   end
 
-  let!(:category) { create :category, participatory_space: participatory_process }
-
+  let!(:category) { create :category, participatory_space: participatory_space }
   let!(:scope) { create :scope, organization: organization }
 
   before do

data/lib/decidim/dev/test/rspec_support/content_processing.rb

@@ -12,7 +12,7 @@ module Decidim
   end
 
   class ContentRenderers::DummyFooRenderer < ContentRenderers::BaseRenderer
-    def render
+    def render(_options = nil)
       content.gsub("%lorem%", "<em>neque dicta enim quasi</em>")
     end
   end
@@ -28,7 +28,7 @@ module Decidim
   end
 
   class ContentRenderers::DummyBarRenderer < ContentRenderers::BaseRenderer
-    def render
+    def render(_options = nil)
       content.gsub("*ipsum*", "<em>illo qui voluptas</em>")
     end
   end

data/lib/decidim/dev/test/rspec_support/frontend.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module FrontendHelpers
+  # Thanks to:
+  # https://medium.com/@coorasse/catch-javascript-errors-in-your-system-tests-89c2fe6773b1
+  def expect_no_js_errors
+    errors = page.driver.browser.manage.logs.get(:browser)
+    return if errors.blank?
+
+    aggregate_failures "javascript errors" do
+      errors.each do |error|
+        expect(error.level).not_to eq("SEVERE"), error.message
+      end
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include FrontendHelpers, type: :system
+end

data/lib/decidim/dev/test/rspec_support/geocoder.rb

@@ -8,6 +8,69 @@ module GeocoderHelpers
       address,
       result
     )
+    Decidim::Map::Provider::Autocomplete::Test.add_stub(
+      address,
+      coordinates
+    )
+  end
+
+  # Waits for the front-end geocoding request to finish in order to ensure there
+  # are no pending requests when proceeding.
+  def fill_in_geocoding(attribute, options = {})
+    fill_in attribute, options
+    expect(page).to have_selector(".tribute-container ul#results", count: 1)
+  end
+
+  module_function
+
+  public def configure_maps
+    # Set maps configuration in test mode
+    Decidim.maps = {
+      provider: :test,
+      api_key: "1234123412341234",
+      static: { url: "https://www.example.org/my_static_map" },
+      autocomplete: { url: "/photon_api" } # Locally drawn route for the tests
+    }
+  end
+end
+
+module Decidim::Map::Provider
+  module Geocoding
+    class Test < ::Decidim::Map::Geocoding; end
+  end
+  module Autocomplete
+    class Test < ::Decidim::Map::Autocomplete
+      def self.stubs
+        @stubs ||= []
+      end
+
+      def self.add_stub(address, coordinates)
+        stubs.push(
+          properties: address.is_a?(Hash) ? address : { street: address },
+          geometry: { coordinates: coordinates }
+        )
+      end
+
+      def self.clear_stubs
+        @stubs = []
+      end
+
+      def builder_options
+        { url: configuration.fetch(:url, nil) }.compact
+      end
+
+      class Builder < Decidim::Map::Autocomplete::Builder
+        def javascript_snippets
+          template.javascript_include_tag("decidim/geocoding/provider/photon")
+        end
+      end
+    end
+  end
+  module DynamicMap
+    class Test < ::Decidim::Map::DynamicMap; end
+  end
+  module StaticMap
+    class Test < ::Decidim::Map::StaticMap; end
   end
 end
 
@@ -15,16 +78,97 @@ RSpec.configure do |config|
   config.include GeocoderHelpers
 
   config.before(:suite) do
-    # Set geocoder configuration in test mode
-    Decidim.geocoder = {
-      static_map_url: "https://www.example.org/my_static_map",
-      here_api_key: "1234123412341234"
-    }
-    Geocoder.configure(lookup: :test)
+    GeocoderHelpers.configure_maps
+  end
+
+  config.after(:each, :configures_map) do
+    # Ensure the initializer is always re-run after the examples because
+    # otherwise the utilities could remain unregistered which causes issues with
+    # further tests.
+    Decidim::Core::Engine.initializers.each do |i|
+      next unless i.name == "decidim.maps"
+
+      i.run
+      break
+    end
+
+    # Ensure the utility configuration is reset after each example for it to be
+    # reloaded the next time.
+    Decidim::Map.reset_utility_configuration!
+    configure_maps
   end
 
   config.before(:each, :serves_map) do
     stub_request(:get, %r{https://www\.example\.org/my_static_map})
       .to_return(body: "map_data")
   end
+
+  config.before(:each, :serves_geocoding_autocomplete) do
+    # Clear the autocomplete stubs
+    Decidim::Map::Provider::Autocomplete::Test.clear_stubs
+
+    photon_response = lambda do
+      {
+        features: [
+          {
+            properties: {
+              name: "Park",
+              street: "Street1",
+              housenumber: "1",
+              postcode: "123456",
+              city: "City1",
+              state: "State1",
+              country: "Country1"
+            },
+            geometry: {
+              coordinates: [1.123, 2.234]
+            }
+          },
+          {
+            properties: {
+              street: "Street2",
+              postcode: "654321",
+              city: "City2",
+              country: "Country2"
+            },
+            geometry: {
+              coordinates: [3.345, 4.456]
+            }
+          },
+          {
+            properties: {
+              street: "Street3",
+              housenumber: "3",
+              postcode: "142536",
+              city: "City3",
+              country: "Country3"
+            },
+            geometry: {
+              coordinates: [5.567, 6.678]
+            }
+          }
+        ]
+      }.tap do |response|
+        Decidim::Map::Provider::Autocomplete::Test.stubs.length.positive? &&
+          response[:features] = Decidim::Map::Provider::Autocomplete::Test.stubs
+      end
+    end
+
+    # The Photon API path needs to be mounted in the application itself because
+    # otherwise we would have to run a separate server for the API itself.
+    # Mocking the request would not work here because the call to the Photon API
+    # is initialized by the front-end to the URL specified for the maps
+    # geocoding autocompletion configuration which is not proxied by the
+    # headless browser running the Capybara tests.
+    Rails.application.routes.disable_clear_and_finalize = true
+    Rails.application.routes.draw do
+      get "photon_api", to: ->(_) { [200, { "Content-Type" => "application/json" }, [photon_response.call.to_json.to_s]] }
+    end
+    Rails.application.routes.disable_clear_and_finalize = false
+  end
+
+  config.after(:each, :serves_geocoding_autocomplete) do
+    # Reset the routes back to original
+    Rails.application.reload_routes!
+  end
 end

data/lib/decidim/dev/test/rspec_support/organization.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.after do
+    Decidim::OrganizationSettings.reset!
+  end
+end

data/lib/decidim/dev/test/rspec_support/rake_tasks.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+# File: spec/support/tasks.rb
+require "rake"
+
+# Task names should be used in the top-level describe, with an optional
+# "rake "-prefix for better documentation. Both of these will work:
+#
+# 1) describe "foo:bar" do ... end
+#
+# 2) describe "rake foo:bar" do ... end
+#
+# Favor including "rake "-prefix as in the 2nd example above as it produces
+# doc output that makes it clear a rake task is under test and how it is
+# invoked.
+module TaskExampleGroup
+  extend ActiveSupport::Concern
+
+  included do
+    # Make the Rake task available as `task` in your examples:
+    subject(:task) { tasks[task_name] }
+
+    let(:task_name) { self.class.top_level_description.sub(/\Arake /, "") }
+    let(:tasks) { Rake::Task }
+  end
+end
+
+# A collection of methods to help dealing with rake tasks output.
+module RakeTaskOutputHelpers
+  extend ActiveSupport::Concern
+
+  included do
+    let!(:original_stdout) { $stdout }
+
+    # rubocop:disable RSpec/ExpectOutput
+    before do
+      $stdout = StringIO.new
+    end
+
+    after do
+      $stdout = original_stdout
+    end
+    # rubocop:enable RSpec/ExpectOutput
+  end
+
+  def check_no_errors_have_been_printed
+    expect($stdout.string).not_to include("ERROR:")
+  end
+
+  def check_some_errors_have_been_printed
+    expect($stdout.string).to include("ERROR:")
+  end
+
+  def check_error_printed(type)
+    expect($stdout.string).to include("ERROR: [#{type}]")
+  end
+
+  def check_message_printed(message)
+    expect($stdout.string).to include(message)
+  end
+end
+
+RSpec.configure do |config|
+  # Tag Rake specs with `:task` metadata or put them in the spec/tasks dir
+  config.define_derived_metadata(file_path: %r{/spec/tasks/}) do |metadata|
+    metadata[:type] = :task
+  end
+
+  config.include TaskExampleGroup, type: :task
+  config.include RakeTaskOutputHelpers, type: :task
+
+  config.before(:suite) do
+    Rails.application.load_tasks
+  end
+end

data/lib/decidim/dev/test/rspec_support/translation_helpers.rb

@@ -13,6 +13,8 @@ module TranslationHelpers
   # It is intended to be used to avoid the implementation details, so that the
   # translated attributes implementation can change more easily.
   def translated(field, locale: I18n.locale)
+    return field if field.is_a?(String)
+
     field.try(:[], locale.to_s)
   end
 

data/lib/decidim/dev/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-dev version.
   module Dev
     def self.version
-      "0.22.0"
+      "0.23.3"
     end
   end
 end

data/lib/tasks/generators.rake

@@ -44,7 +44,8 @@ namespace :decidim do
         "..",
         "--recreate_db",
         "--seed_db",
-        "--demo"
+        "--demo",
+        "--profiling"
       )
     end
   end

data/lib/tasks/locale_checker.rake

@@ -5,7 +5,7 @@ namespace :decidim do
   task check_locales: :environment do
     FileUtils.remove_dir("tmp/decidim_repo", true)
 
-    branch = ENV["TARGET_BRANCH"] || "master"
+    branch = ENV["TARGET_BRANCH"] || "develop"
     status = system("git clone --depth=1 --single-branch --branch #{branch} https://github.com/decidim/decidim tmp/decidim_repo")
     return unless status
 

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: decidim-dev
 version: !ruby/object:Gem::Version
-  version: 0.22.0
+  version: 0.23.3
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
 - Marc Riera Casals
 - Oriol Gual Oliva
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-01 00:00:00.000000000 Z
+date: 2021-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -32,14 +32,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.22.0
+        version: 0.23.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.22.0
+        version: 0.23.3
 - !ruby/object:Gem::Dependency
   name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
@@ -116,14 +116,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -298,14 +298,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.5
+        version: 0.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.18.5
+        version: 0.19.0
 - !ruby/object:Gem::Dependency
   name: simplecov-cobertura
   requirement: !ruby/object:Gem::Requirement
@@ -378,25 +378,31 @@ files:
 - app/commands/decidim/dummy_resources/create_dummy_resource.rb
 - app/controllers/decidim/dummy_resources/dummy_resources_controller.rb
 - app/forms/decidim/dummy_resources/dummy_resource_form.rb
+- app/mailers/decidim/dummy_resources/dummy_resource_mailer.rb
 - app/views/decidim/dummy_resource/_linked_dummys.html.erb
 - app/views/decidim/dummy_resources/dummy_resources/foo.html.erb
 - app/views/decidim/dummy_resources/dummy_resources/show.html.erb
+- config/locales/am-ET.yml
 - config/locales/ar-SA.yml
 - config/locales/ar.yml
 - config/locales/bg-BG.yml
+- config/locales/bg.yml
 - config/locales/ca.yml
 - config/locales/cs-CZ.yml
 - config/locales/cs.yml
 - config/locales/da-DK.yml
+- config/locales/da.yml
 - config/locales/de.yml
 - config/locales/el-GR.yml
 - config/locales/el.yml
 - config/locales/en.yml
 - config/locales/eo-UY.yml
+- config/locales/eo.yml
 - config/locales/es-MX.yml
 - config/locales/es-PY.yml
 - config/locales/es.yml
 - config/locales/et-EE.yml
+- config/locales/et.yml
 - config/locales/eu.yml
 - config/locales/fi-pl.yml
 - config/locales/fi-plain.yml
@@ -406,38 +412,60 @@ files:
 - config/locales/ga-IE.yml
 - config/locales/gl.yml
 - config/locales/hr-HR.yml
+- config/locales/hr.yml
 - config/locales/hu.yml
 - config/locales/id-ID.yml
 - config/locales/is-IS.yml
+- config/locales/is.yml
 - config/locales/it.yml
 - config/locales/ja-JP.yml
+- config/locales/ja.yml
+- config/locales/ko-KR.yml
+- config/locales/ko.yml
 - config/locales/lt-LT.yml
-- config/locales/lv-LV.yml
+- config/locales/lt.yml
+- config/locales/lv.yml
 - config/locales/mt-MT.yml
+- config/locales/mt.yml
 - config/locales/nl.yml
 - config/locales/no.yml
+- config/locales/om-ET.yml
 - config/locales/pl.yml
 - config/locales/pt-BR.yml
 - config/locales/pt.yml
 - config/locales/ro-RO.yml
 - config/locales/ru.yml
+- config/locales/si-LK.yml
 - config/locales/sk-SK.yml
 - config/locales/sk.yml
 - config/locales/sl.yml
+- config/locales/so-SO.yml
 - config/locales/sr-CS.yml
 - config/locales/sv.yml
+- config/locales/sw-KE.yml
+- config/locales/ti-ER.yml
 - config/locales/tr-TR.yml
 - config/locales/uk.yml
+- config/locales/vi-VN.yml
+- config/locales/vi.yml
+- config/locales/zh-CN.yml
+- config/locales/zh-TW.yml
 - lib/decidim/dev.rb
+- lib/decidim/dev/assets/5000x5000.png
 - lib/decidim/dev/assets/Exampledocument.pdf
+- lib/decidim/dev/assets/assemblies.json
+- lib/decidim/dev/assets/assemblies_with_null.json
 - lib/decidim/dev/assets/avatar.jpg
 - lib/decidim/dev/assets/city.jpeg
 - lib/decidim/dev/assets/city2.jpeg
 - lib/decidim/dev/assets/city3.jpeg
 - lib/decidim/dev/assets/dni.jpg
+- lib/decidim/dev/assets/geocoder_result_here.json
+- lib/decidim/dev/assets/geocoder_result_osm.json
 - lib/decidim/dev/assets/icon.png
 - lib/decidim/dev/assets/id.jpg
 - lib/decidim/dev/assets/import_participatory_space_private_users.csv
+- lib/decidim/dev/assets/import_participatory_space_private_users_nok.csv
 - lib/decidim/dev/assets/iso-8859-15.md
 - lib/decidim/dev/assets/malicious.jpg
 - lib/decidim/dev/assets/participatory_processes.json
@@ -447,6 +475,7 @@ files:
 - lib/decidim/dev/assets/participatory_text_wrong.odt
 - lib/decidim/dev/assets/verify_user_groups.csv
 - lib/decidim/dev/common_rake.rb
+- lib/decidim/dev/dummy_translator.rb
 - lib/decidim/dev/railtie.rb
 - lib/decidim/dev/test/authorization_shared_examples.rb
 - lib/decidim/dev/test/base_spec_helper.rb
@@ -468,12 +497,15 @@ files:
 - lib/decidim/dev/test/rspec_support/content_processing.rb
 - lib/decidim/dev/test/rspec_support/download_helper.rb
 - lib/decidim/dev/test/rspec_support/factory_bot.rb
+- lib/decidim/dev/test/rspec_support/frontend.rb
 - lib/decidim/dev/test/rspec_support/gamification.rb
 - lib/decidim/dev/test/rspec_support/geocoder.rb
 - lib/decidim/dev/test/rspec_support/helpers.rb
 - lib/decidim/dev/test/rspec_support/html_matchers.rb
 - lib/decidim/dev/test/rspec_support/orderly_matchers.rb
+- lib/decidim/dev/test/rspec_support/organization.rb
 - lib/decidim/dev/test/rspec_support/permissions_shared_examples.rb
+- lib/decidim/dev/test/rspec_support/rake_tasks.rb
 - lib/decidim/dev/test/rspec_support/react_select.rb
 - lib/decidim/dev/test/rspec_support/route_helpers.rb
 - lib/decidim/dev/test/rspec_support/timezone.rb
@@ -489,7 +521,7 @@ homepage: https://github.com/decidim/decidim
 licenses:
 - AGPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -497,15 +529,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: Decidim dev tools
 test_files: []