decidim-dev 0.19.0 → 0.22.0

data/lib/decidim/dev/assets/participatory_processes_with_null.json

@@ -0,0 +1,103 @@
+[
+  {
+    "id": 1,
+    "title": {
+      "ca": "Laborum totam et nisi autem.",
+      "en": "Tempora esse debitis in ut.",
+      "es": "Eum quia ut maiores officia."
+    },
+    "subtitle": {
+      "ca": "Sit ut.",
+      "en": "Consequatur sed.",
+      "es": "In laudantium."
+    },
+    "slug": "distinctio-cupiditate",
+    "hashtag": "harum",
+    "short_description": {
+      "ca": "<p>Harum magnam id.</p>",
+      "en": "<p>Aut quam doloribus.</p>",
+      "es": "<p>Vel eaque voluptatem.</p>"
+    },
+    "description": {
+      "ca": "<p>Eius velit earum. Dolorem consequuntur ullam. Atque autem non.</p>",
+      "en": "<p>Ad quaerat consequuntur. Voluptas dignissimos eos. Eos saepe et.</p>",
+      "es": "<p>Omnis similique illo. Expedita adipisci qui. Voluptas cupiditate qui.</p>"
+    },
+    "announcement": null,
+    "start_date": "2019-10-02",
+    "end_date": "2019-12-02",
+    "remote_hero_image_url": "http://localhost:3000/uploads/decidim/participatory_process/hero_image/1/city.jpeg",
+    "remote_banner_image_url": "http://localhost:3000/uploads/decidim/participatory_process/banner_image/1/city2.jpeg",
+    "developer_group": {
+      "ca": "Reiciendis.",
+      "en": "Nostrum.",
+      "es": "Aut."
+    },
+    "local_area": {
+      "ca": "Eum necessitatibus.",
+      "en": "Aspernatur perspiciatis.",
+      "es": "A laudantium."
+    },
+    "meta_scope": {
+      "ca": "sint",
+      "en": "voluptas",
+      "es": "ullam"
+    },
+    "participatory_scope": {
+      "ca": "Ad.",
+      "en": "Amet.",
+      "es": "Excepturi."
+    },
+    "participatory_structure": {
+      "ca": "Eos est.",
+      "en": "Quaerat mollitia.",
+      "es": "Vel iusto."
+    },
+    "target": {
+      "ca": "Ratione amet harum.",
+      "en": "Deserunt nulla modi.",
+      "es": "Aut quae ipsa."
+    },
+    "area": {
+      "id": null,
+      "name": {
+        "en": "",
+        "ca": "",
+        "es": ""
+      }
+    },
+    "participatory_process_group": {
+      "id": 1,
+      "name": {
+        "ca": "Molestias pariatur eaque.",
+        "en": "Iure iusto ut.",
+        "es": "Pariatur culpa reprehenderit."
+      },
+      "description": {
+        "ca": "<p>Et accusamus debitis. Sint voluptatem velit. Quia architecto at.</p>",
+        "en": "<p>Sunt eius labore. Odit fugiat numquam. Et consequatur pariatur.</p>",
+        "es": "<p>Rerum aperiam omnis. Optio est quo. Odit est eveniet.</p>"
+      },
+      "remote_hero_image_url": "http://localhost:3000/uploads/decidim/participatory_process_group/hero_image/1/city.jpeg"
+    },
+    "scope": {
+      "id": 1,
+      "name": {
+        "ca": "South Carolina",
+        "en": "South Carolina",
+        "es": "South Carolina"
+      }
+    },
+    "private_space": false,
+    "promoted": true,
+    "scopes_enabled": true,
+    "show_statistics": true,
+    "participatory_process_steps": null,
+    "participatory_process_categories": null,
+    "attachments": {
+      "attachment_collections": null,
+      "files": null
+    },
+    "components": null
+  }
+]

data/lib/decidim/dev/test/base_spec_helper.rb

@@ -22,3 +22,17 @@ Dir["#{engine_spec_dir}/shared/**/*.rb"].each { |f| require f }
 require "paper_trail/frameworks/rspec"
 
 require_relative "spec_helper"
+
+if ENV["CI"]
+  require "rspec/retry"
+
+  RSpec.configure do |config|
+    # show retry status in spec process
+    config.verbose_retry = true
+    # show exception that triggers a retry if verbose_retry is set to true
+    config.display_try_failure_messages = true
+
+    # Retry failed test, set to 1 for normal behavior
+    config.default_retry_count = ENV.fetch("FAILED_TEST_RETRY_COUNT") { 3 }
+  end
+end

data/lib/decidim/dev/test/rspec_support/authorization.rb

@@ -14,6 +14,7 @@ module Decidim
         routes do
           root to: proc { [200, {}, ["DUMMY VERIFICATION ENGINE"]] }
           get :edit_authorization, to: proc { [200, {}, ["CONTINUE YOUR VERIFICATION"]] }
+          get :renew_authorization, to: proc { [200, {}, ["RENEW YOUR VERIFICATION"]] }
         end
       end
     end
@@ -23,6 +24,8 @@ end
 Decidim::Verifications.register_workflow(:dummy_authorization_workflow) do |workflow|
   workflow.engine = Decidim::Verifications::DummyVerification::Engine
   workflow.expires_in = 1.hour
+  workflow.renewable = true
+  workflow.time_between_renewals = 5.minutes
 end
 
 RSpec.configure do |config|

data/lib/decidim/dev/test/rspec_support/capybara.rb

@@ -62,7 +62,7 @@ RSpec.configure do |config|
   end
 
   config.around :each, :slow do |example|
-    max_wait_time_for_slow_specs = 12
+    max_wait_time_for_slow_specs = 30
 
     using_wait_time(max_wait_time_for_slow_specs) do
       example.run

data/lib/decidim/dev/test/rspec_support/capybara_data_picker.rb

@@ -6,15 +6,13 @@ module Capybara
       Struct.new(:data_picker, :global_value).new(find_data_picker(id, multiple: multiple), global_value)
     end
 
-    private
-
     def find_data_picker(id, multiple: nil)
       if multiple.nil?
-        expect(page).to have_selector("div.data-picker##{id}")
+        expect(page).to have_selector("div.data-picker[id$='#{id}']")
       else
-        expect(page).to have_selector("div.data-picker.picker-#{multiple ? "multiple" : "single"}##{id}")
+        expect(page).to have_selector("div.data-picker.picker-#{multiple ? "multiple" : "single"}[id$='#{id}']")
       end
-      find("div.data-picker##{id}")
+      first("div.data-picker[id$='#{id}']")
     end
 
     def data_picker_pick_current
@@ -22,5 +20,17 @@ module Capybara
       expect(body).to have_selector("#data_picker-modal .picker-footer a[data-picker-choose]")
       body.find("#data_picker-modal .picker-footer a[data-picker-choose]").click
     end
+
+    def data_picker_choose_value(value)
+      body = find(:xpath, "//body")
+      expect(body).to have_selector("#data_picker-modal input[data-picker-choose][type=checkbox][value=\"#{value}\"]")
+      body.find("#data_picker-modal input[data-picker-choose][type=checkbox][value=\"#{value}\"]").click
+    end
+
+    def data_picker_close
+      body = find(:xpath, "//body")
+      expect(body).to have_selector("#data_picker-modal .picker-footer a[data-close]")
+      body.find("#data_picker-modal .picker-footer a[data-close]").click
+    end
   end
 end

data/lib/decidim/dev/test/rspec_support/capybara_scopes_picker.rb

@@ -10,7 +10,7 @@ module Capybara
       match do |scope_picker|
         data_picker = scope_picker.data_picker
         scope_name = expected ? translated(expected.name) : t("decidim.scopes.global")
-        expect(data_picker).to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: false)
+        expect(data_picker).to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: :all)
         expect(data_picker).to have_selector(:xpath, "//div[contains(@class,'picker-values')]/div/a[text()[contains(.,'#{scope_name}')]]")
       end
     end
@@ -19,7 +19,7 @@ module Capybara
       match do |scope_picker|
         data_picker = scope_picker.data_picker
         scope_name = expected ? translated(expected.name) : t("decidim.scopes.global")
-        expect(data_picker).not_to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: false)
+        expect(data_picker).not_to have_selector(".picker-values div input[value='#{expected&.id || scope_picker.global_value}']", visible: :all)
         expect(data_picker).not_to have_selector(:xpath, "//div[contains(@class,'picker-values')]/div/a[text()[contains(.,'#{scope_name}')]]")
       end
     end
@@ -27,7 +27,7 @@ module Capybara
     def scope_pick(scope_picker, scope)
       data_picker = scope_picker.data_picker
       # use scope_repick to change single scope picker selected scope
-      expect(data_picker).to have_selector(".picker-values:empty", visible: false) if data_picker.has_css?(".picker-single")
+      expect(data_picker).to have_selector(".picker-values:empty", visible: :all) if data_picker.has_css?(".picker-single")
 
       expect(data_picker).to have_selector(".picker-prompt")
       data_picker.find(".picker-prompt").click
@@ -41,7 +41,7 @@ module Capybara
     def scope_repick(scope_picker, old_scope, new_scope)
       data_picker = scope_picker.data_picker
 
-      expect(data_picker).to have_selector(".picker-values div input[value='#{old_scope&.id || scope_picker.global_value}']", visible: false)
+      expect(data_picker).to have_selector(".picker-values div input[value='#{old_scope&.id || scope_picker.global_value}']", visible: :all)
       data_picker.find(:xpath, "//div[contains(@class,'picker-values')]/div/input[@value='#{old_scope&.id || scope_picker.global_value}']/../a").click
 
       # browse to lowest common parent between old and new scope
@@ -57,7 +57,7 @@ module Capybara
     def scope_unpick(scope_picker, scope)
       data_picker = scope_picker.data_picker
 
-      expect(data_picker).to have_selector(".picker-values div input[value='#{scope&.id || scope_picker.global_value}']", visible: false)
+      expect(data_picker).to have_selector(".picker-values div input[value='#{scope&.id || scope_picker.global_value}']", visible: :all)
       data_picker.find(".picker-values div input[value='#{scope&.id || scope_picker.global_value}']").click
 
       expect(scope_picker).to have_scope_not_picked(scope)

data/lib/decidim/dev/test/rspec_support/comments.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 module CommentsHelpers
-  def have_comment_from(user, text)
+  def have_comment_from(user, text, opts = {})
     within "#comments" do
-      have_content(user.name) && have_content(text)
+      have_content(user.name, opts) && have_content(text, opts)
     end
   end
 

data/lib/decidim/dev/test/rspec_support/component.rb

@@ -64,6 +64,8 @@ module Decidim
       include Amendable
       include Decidim::NewsletterParticipant
       include Hashtaggable
+      include ::Decidim::Endorsable
+      include Decidim::HasAttachments
 
       searchable_fields(
         scope_id: { scope: :id },
@@ -103,6 +105,39 @@ module Decidim
                                               .pluck(:decidim_author_id).flatten.compact.uniq
       end
     end
+
+    class CoauthorableDummyResource < ApplicationRecord
+      include ::Decidim::Coauthorable
+      include HasComponent
+    end
+
+    class OfficialAuthorPresenter
+      def name
+        self.class.name
+      end
+
+      def nickname
+        UserBaseEntity.nicknamize(name)
+      end
+
+      def deleted?
+        false
+      end
+
+      def respond_to_missing?
+        true
+      end
+
+      def method_missing(method, *args)
+        if method.to_s.ends_with?("?")
+          false
+        elsif [:avatar_url, :profile_path, :badge, :followers_count].include?(method)
+          ""
+        else
+          super
+        end
+      end
+    end
   end
 end
 
@@ -131,7 +166,8 @@ Decidim.register_component(:dummy) do |component|
     settings.attribute :comments_enabled, type: :boolean, default: true
     settings.attribute :resources_permissions_enabled, type: :boolean, default: true
     settings.attribute :dummy_global_attribute_1, type: :boolean
-    settings.attribute :dummy_global_attribute_2, type: :boolean
+    settings.attribute :dummy_global_attribute_2, type: :boolean, readonly: ->(_context) { false }
+    settings.attribute :readonly_attribute, type: :boolean, default: true, readonly: ->(_context) { true }
     settings.attribute :enable_pads_creation, type: :boolean, default: false
     settings.attribute :amendments_enabled, type: :boolean, default: false
     settings.attribute :dummy_global_translatable_text, type: :text, translated: true, editor: true, required: true
@@ -140,12 +176,15 @@ Decidim.register_component(:dummy) do |component|
   component.settings(:step) do |settings|
     settings.attribute :comments_blocked, type: :boolean, default: false
     settings.attribute :dummy_step_attribute_1, type: :boolean
-    settings.attribute :dummy_step_attribute_2, type: :boolean
+    settings.attribute :dummy_step_attribute_2, type: :boolean, readonly: ->(_context) { false }
     settings.attribute :dummy_step_translatable_text, type: :text, translated: true, editor: true, required: true
+    settings.attribute :readonly_step_attribute, type: :boolean, default: true, readonly: ->(_context) { true }
     settings.attribute :amendment_creation_enabled, type: :boolean, default: true
     settings.attribute :amendment_reaction_enabled, type: :boolean, default: true
     settings.attribute :amendment_promotion_enabled, type: :boolean, default: true
     settings.attribute :amendments_visibility, type: :string, default: "all"
+    settings.attribute :endorsements_enabled, type: :boolean, default: false
+    settings.attribute :endorsements_blocked, type: :boolean, default: false
   end
 
   component.register_resource(:dummy_resource) do |resource|
@@ -156,6 +195,14 @@ Decidim.register_component(:dummy) do |component|
     resource.searchable = true
   end
 
+  component.register_resource(:coauthorable_dummy_resource) do |resource|
+    resource.name = :coauthorable_dummy
+    resource.model_class_name = "Decidim::DummyResources::CoauthorableDummyResource"
+    resource.template = "decidim/coauthorabledummy_resource/linked_dummys"
+    resource.actions = %w(foo-coauthorable)
+    resource.searchable = false
+  end
+
   component.register_stat :dummies_count_high, primary: true, priority: Decidim::StatsRegistry::HIGH_PRIORITY do |components, _start_at, _end_at|
     components.count * 10
   end
@@ -186,6 +233,7 @@ RSpec.configure do |config|
           t.float :longitude
           t.datetime :published_at
           t.integer :coauthorships_count, null: false, default: 0
+          t.integer :endorsements_count, null: false, default: 0
 
           t.references :decidim_component, index: false
           t.integer :decidim_author_id, index: false
@@ -198,6 +246,27 @@ RSpec.configure do |config|
           t.timestamps
         end
       end
+
+      unless ActiveRecord::Base.connection.data_source_exists?("decidim_dummy_resources_coauthorable_dummy_resources")
+        ActiveRecord::Migration.create_table :decidim_dummy_resources_coauthorable_dummy_resources do |t|
+          t.jsonb :translatable_text
+          t.string :title
+          t.string :body
+          t.text :address
+          t.float :latitude
+          t.float :longitude
+          t.datetime :published_at
+          t.integer :coauthorships_count, null: false, default: 0
+          t.integer :endorsements_count, null: false, default: 0
+
+          t.references :decidim_component, index: false
+          t.references :decidim_category, index: false
+          t.references :decidim_scope, index: false
+          t.string :reference
+
+          t.timestamps
+        end
+      end
     end
   end
 

data/lib/decidim/dev/test/rspec_support/confirmation_helpers.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+# Helpers that get automatically included in component specs.
+module ConfirmationHelpers
+  # Overrides the Capybara default accept_confirm because we have replaced the
+  # system's own confirmation modal with foundation based modal.
+  #
+  # See:
+  # https://github.com/teamcapybara/capybara/blob/44621209496fe4dd352709799a0061a80d97d562/lib/capybara/session.rb#L647
+  def accept_confirm(_text = nil, **_options)
+    yield if block_given?
+
+    # The test can already be "within", so find the body using xpath
+    message = nil
+    body = find(:xpath, "/html/body")
+    within(body.find(".confirm-reveal")) do
+      message = find(".confirm-modal-content").text
+      find("a.button[data-confirm-ok]").click
+    end
+
+    message
+  end
+
+  # Overrides the Capybara default dismiss_confirm because we have replaced the
+  # system's own confirmation modal with foundation based modal.
+  #
+  # See:
+  # https://github.com/teamcapybara/capybara/blob/44621209496fe4dd352709799a0061a80d97d562/lib/capybara/session.rb#L657
+  def dismiss_confirm(_text = nil, **_options)
+    yield if block_given?
+
+    # The test can already be "within", so find the body using xpath
+    message = nil
+    body = find(:xpath, "/html/body")
+    within(body.find(".confirm-reveal")) do
+      message = find(".confirm-modal-content").text
+      find("a.button[data-confirm-cancel]").click
+    end
+
+    message
+  end
+
+  # Used to accept the "onbeforeunload" event's normal browser confirm modal
+  # as this cannot be overridden. Original confirm dismiss implementation in
+  # Capybara.
+  def accept_page_unload(text = nil, **options, &blk)
+    page.send(:accept_modal, :confirm, text, options, &blk)
+  end
+
+  # Used to dismiss the "onbeforeunload" event's normal browser confirm modal
+  # as this cannot be overridden. Original confirm dismiss implementation in
+  # Capybara.
+  def dismiss_page_unload(text = nil, **options, &blk)
+    page.send(:dismiss_modal, :confirm, text, options, &blk)
+  end
+end
+
+RSpec.configure do |config|
+  config.include ConfirmationHelpers, type: :system
+end

data/lib/decidim/dev/test/rspec_support/content_processing.rb

@@ -3,7 +3,7 @@
 module Decidim
   class ContentParsers::DummyFooParser < ContentParsers::BaseParser
     def rewrite
-      content.gsub("foo", "*lorem*")
+      content.gsub("foo", "%lorem%")
     end
 
     def metadata
@@ -13,7 +13,7 @@ module Decidim
 
   class ContentRenderers::DummyFooRenderer < ContentRenderers::BaseRenderer
     def render
-      content.gsub("*lorem*", "<em>neque dicta enim quasi</em>")
+      content.gsub("%lorem%", "<em>neque dicta enim quasi</em>")
     end
   end
 

data/lib/decidim/dev/test/rspec_support/geocoder.rb

@@ -18,8 +18,7 @@ RSpec.configure do |config|
     # Set geocoder configuration in test mode
     Decidim.geocoder = {
       static_map_url: "https://www.example.org/my_static_map",
-      here_app_id: "1234",
-      here_app_code: "5678"
+      here_api_key: "1234123412341234"
     }
     Geocoder.configure(lookup: :test)
   end