decidim-decidim_awesome 0.8.3 → 0.9.1

data/app/packs/src/decidim/decidim_awesome/awesome_map/awesome_map.js

@@ -1,8 +1,11 @@
 import * as L from "leaflet";
-import "src/decidim/map/icon.js" // comes with Decidim
+// comes with Decidim
+import "src/decidim/map/icon.js" 
 import "src/decidim/vendor/leaflet-tilelayer-here"
-import "leaflet.markercluster"; // Comes with Decidim
-import "leaflet.featuregroup.subgroup" // included in this package.json
+// Comes with Decidim
+import "leaflet.markercluster"; 
+// included in this package.json
+import "leaflet.featuregroup.subgroup" 
 import "src/vendor/jquery.truncate"
 import "jsrender"
 
@@ -60,7 +63,7 @@ export default class AwesomeMap {
           this.loading.pop();
           this.autoResize();
 
-          if (this.loading.length == 0) {
+          if (this.loading.length === 0) {
             this.controls.$loading.hide();
             // call trigger as all loads are finished
             this.onFinished();
@@ -90,13 +93,11 @@ export default class AwesomeMap {
     };
 
     if (category) {
-      let id = category.id
-        ? parseInt(category.id, 10)
-        : parseInt(category, 10);
-      let cat = this.categories.find((c) => c.id == id);
+      let id = category.id ? parseInt(category.id, 10) : parseInt(category, 10); // eslint-disable-line no-ternary, multiline-ternary
+      let cat = this.categories.find((ct) => ct.id === id);
       if (cat) {
         cat.children = () => {
-          return this.categories.filter((c) => c.parent === cat.id);
+          return this.categories.filter((ct) => ct.parent === cat.id);
         }
         return cat;
       }
@@ -105,12 +106,12 @@ export default class AwesomeMap {
   }
 
   _getController(component) {
-    let controller;
+    let controller = null;
 
-    if (component.type == "proposals") {
+    if (component.type === "proposals") {
       controller = new ProposalsController(this, component);
     }
-    if (component.type == "meetings" && this.config.menu.meetings) {
+    if (component.type === "meetings" && this.config.menu.meetings) {
       controller = new MeetingsController(this, component);
     }
 
@@ -125,5 +126,6 @@ export default class AwesomeMap {
       this.controllers[component.type] = controller;
       return this.controllers[component.type]
     }
+    return null;
   }
 }

data/app/packs/src/decidim/decidim_awesome/awesome_map/controllers/controller.js

@@ -14,9 +14,10 @@ export default class Controller {
   }
 
   getLabel() {
-    let text = this.awesomeMap.config.menu.mergeComponents || !this.component.name 
-      ? window.DecidimAwesome.texts[this.component.type]
-      : this.component.name;
+    let text = this.awesomeMap.config.menu.mergeComponents || this.component.name;
+    if (!text) {
+      text = window.DecidimAwesome.texts[this.component.type];
+    }
     return `<span class="awesome_map-component" id="awesome_map-component_${this.component.id}" title="0" data-layer="${this.component.type}">${text}</span>`
   }
 
@@ -29,13 +30,15 @@ export default class Controller {
     this.fetcher.onCollection = (collection) =>  {
       if (collection && collection.edges)  { 
         // Add markers to the main cluster group
+        const collectionEdges = collection.edges.filter((item) => item.node.coordinates && item.node.coordinates.latitude && item.node.coordinates.longitude);
         try {
-          this.awesomeMap.cluster.addLayers(collection.edges.map((item) => item.node.marker));
-        } catch (e) {
-          console.error("Failed marker collection assignation", collection);
+          this.awesomeMap.cluster.addLayers(collectionEdges.map((item) => item.node.marker));
+        } catch (evt) {
+          console.error("Failed marker collection assignation", collectionEdges, "error", evt);
         }
         // subgroups don't have th addLayers utility
-        collection.edges.forEach((item) => {
+        collectionEdges.forEach((item) => {
+          this.awesomeMap.layers[this.component.type].group.addLayer(item.node.marker);
           this.addMarkerCategory(item.node.marker, item.node.category);
           this.addMarkerHashtags(item.node.marker, item.node.hashtags);
         });
@@ -45,7 +48,8 @@ export default class Controller {
 
   addControls() {
     this.awesomeMap.controls.main.addOverlay(this.controls.group, this.controls.label);
-    this.awesomeMap.map.addLayer(this.controls.group);
+    this.controls.group.addTo(this.awesomeMap.map);
+    this.awesomeMap.layers[this.component.type] = this.controls;
   }
 
   loadNodes() {
@@ -94,8 +98,8 @@ export default class Controller {
       try {
         this.awesomeMap.layers[cat.id].group.addLayer(marker);
         this.awesomeMap.controls.showCategory(cat);
-      } catch (e) {
-        console.error("Failed category marker assignation", marker, e.message);
+      } catch (evt) {
+        console.error("Failed category marker assignation", marker, evt.message);
       }
     }   
   }
@@ -105,8 +109,8 @@ export default class Controller {
     if (this.awesomeMap.config.menu.hashtags) {
       try {
         this.awesomeMap.controls.addHashtagsControls(hashtags, marker);
-      } catch (e) {
-        console.error("Failed hashtags marker assignation", marker, e.message);
+      } catch (evt) {
+        console.error("Failed hashtags marker assignation", marker, evt.message);
       }
     }
   }

data/app/packs/src/decidim/decidim_awesome/awesome_map/controllers/proposals_controller.js

@@ -62,15 +62,15 @@ export default class ProposalsController extends Controller {
 
     // Process all amendments
     iterableAmendments.forEach((amendment) => {
-      const marker = this.allNodes.find((node) => node.id == amendment[0]);
+      const marker = this.allNodes.find((node) => node.id === amendment[0]);
       const parent = amendment[1];
       // console.log("marker", marker, "parent proposal", parent)
       // add marker to amendments layers and remove it from proposals
       if (marker) {
         try { 
           marker.marker.removeFrom(this.controls.group) 
-        } catch (e) { 
-          console.error("error removeFrom marker", marker, "layer", this.controls.group,  e);
+        } catch (evt) { 
+          console.error("error removeFrom marker", marker, "layer", this.controls.group,  evt);
         }
         if (this.awesomeMap.config.menu.amendments) {
           marker.marker.addTo(this.awesomeMap.layers.amendments.group);

data/app/packs/src/decidim/decidim_awesome/awesome_map/controls_ui.js

@@ -1,3 +1,5 @@
+/* eslint-disable no-ternary, multiline-ternary */
+
 import * as L from "leaflet";
 
 export default class ControlsUI {
@@ -33,28 +35,28 @@ export default class ControlsUI {
     }
 
     // sub-layer hashtag title toggle
-    $("#awesome-map").on("click", ".awesome_map-title-control", (e) => {
-      e.preventDefault();
-      e.stopPropagation();
+    $("#awesome-map").on("click", ".awesome_map-title-control", (evt) => {
+      evt.preventDefault();
+      evt.stopPropagation();
       $("#awesome_map-categories-control").toggleClass("active");
       $("#awesome_map-hashtags-control").toggleClass("active");
     });
 
     // hashtag events
-    $("#awesome-map").on("change", ".awesome_map-hashtags-selector", (e) => {
-      e.preventDefault();
-      e.stopPropagation();
-      const tag = $(e.target).closest("label").data("layer");
-      // console.log("changed, layer", tag, "checked", e.target.checked, e);
+    $("#awesome-map").on("change", ".awesome_map-hashtags-selector", (evt) => {
+      evt.preventDefault();
+      evt.stopPropagation();
+      const tag = $(evt.target).closest("label").data("layer");
+      // console.log("changed, layer", tag, "checked", evt.target.checked, e);
       if (tag) {
         this.updateHashtagLayers();
       }
     });
 
     // select/deselect all tags
-    $("#awesome-map").on("click", ".awesome_map-toggle_all_tags", (e) => {
-      e.preventDefault();
-      e.stopPropagation();
+    $("#awesome-map").on("click", ".awesome_map-toggle_all_tags", (evt) => {
+      evt.preventDefault();
+      evt.stopPropagation();
       $("#awesome-map .awesome_map-hashtags-selector").prop("checked", $("#awesome-map .awesome_map-hashtags-selector:checked").length < $("#awesome-map .awesome_map-hashtags-selector").length);
       this.updateHashtagLayers();
     });
@@ -74,22 +76,20 @@ export default class ControlsUI {
         group: new L.FeatureGroup.SubGroup(this.awesomeMap.cluster)
       };
       this.awesomeMap.layers[category.id].group.addTo(this.awesomeMap.map);
-      $("#awesome_map-categories-control .categories-container").append(`<label data-layer="${category.id}" class="awesome_map-category-${category.id}${category.parent
-        ? " subcategory"
-        : ""}" data-parent="${category.parent}"><input type="checkbox" class="awesome_map-categories-selector" checked><span>${label}</span></label>`);
+      $("#awesome_map-categories-control .categories-container").append(`<label data-layer="${category.id}" class="awesome_map-category-${category.id}${category.parent ? " subcategory" : ""}" data-parent="${category.parent}"><input type="checkbox" class="awesome_map-categories-selector" checked><span>${label}</span></label>`);
     })
 
     // category events
-    $("#awesome-map").on("change", ".awesome_map-categories-selector", (e) => {
-      e.preventDefault();
-      e.stopPropagation();
+    $("#awesome-map").on("change", ".awesome_map-categories-selector", (evt) => {
+      evt.preventDefault();
+      evt.stopPropagation();
 
-      const id = $(e.target).closest("label").data("layer");
+      const id = $(evt.target).closest("label").data("layer");
       const cat = this.awesomeMap.getCategory(id);
-      // console.log("changed, layer", id, "cat", cat, "checked", e.target.checked, e);
+      // console.log("changed, layer", id, "cat", cat, "checked", evt.target.checked, e);
       if (cat) {
         const layer = this.awesomeMap.layers[cat.id];
-        if (e.target.checked) {
+        if (evt.target.checked) {
           // show group of markers
           this.awesomeMap.map.addLayer(layer.group);
         } else {
@@ -131,7 +131,7 @@ export default class ControlsUI {
 
         const $label = $(`label.awesome_map-hashtag-${hashtag.tag}`);
         // update number of items
-        $label.attr("title", `${parseInt($label.attr("title") || 0) + 1} ${window.DecidimAwesome.texts.items}`);
+        $label.attr("title", `${parseInt($label.attr("title") || 0, 10) + 1} ${window.DecidimAwesome.texts.items}`);
       });
     }
   }
@@ -143,10 +143,10 @@ export default class ControlsUI {
     const $parent = $(`label.awesome_map-category-${cat.parent}`);
     $label.show();
     // update number of items
-    $label.attr("title", `${parseInt($label.attr("title") || 0) + 1} ${window.DecidimAwesome.texts.items}`);
+    $label.attr("title", `${parseInt($label.attr("title") || 0, 10) + 1} ${window.DecidimAwesome.texts.items}`);
     // show parent if apply
     $parent.show();
-    $parent.attr("title", `${parseInt($parent.attr("title") || 0) + 1} ${window.DecidimAwesome.texts.items}`);
+    $parent.attr("title", `${parseInt($parent.attr("title") || 0, 10) + 1} ${window.DecidimAwesome.texts.items}`);
   }
 
   removeHiddenComponents() {
@@ -200,8 +200,8 @@ export default class ControlsUI {
     if (cat.parent) {
       let $input = $(`.awesome_map-category-${cat.parent}`).contents("input");
       let $subcats = $(`[class^="awesome_map-category-"][data-parent="${cat.parent}"]:visible`);
-      let num_checked = $subcats.contents("input:checked").length;
-      $input.prop("indeterminate", num_checked != $subcats.length && num_checked != 0);
+      let numChecked = $subcats.contents("input:checked").length;
+      $input.prop("indeterminate", numChecked !== $subcats.length && numChecked !== 0);
     }
   }
 
@@ -213,7 +213,6 @@ export default class ControlsUI {
       $div.contents("label").each((_idx, el) => {
         if ($(el).text().localeCompare($last.text()) > 0) {
           $(el).before($last);
-          return false;
         }
       });
     }

data/app/packs/src/decidim/decidim_awesome/awesome_map/load_map.js

@@ -12,6 +12,7 @@ $(() => {
         }
       }
     }
+    return null;
   };
 
   const config = {

data/app/packs/src/decidim/decidim_awesome/editors/editor.js

@@ -1,4 +1,4 @@
-/* eslint-disable require-jsdoc */
+/* eslint-disable require-jsdoc, func-style */
 
 /*
 * Since version 0.25 we follow a different strategy and opt to destroy and override completely the original editor
@@ -13,10 +13,9 @@ import "inline-attachment/src/codemirror-4.inline-attachment";
 import "inline-attachment/src/jquery.inline-attachment";
 import hljs from "highlight.js";
 import "highlight.js/styles/github.css";
-
-// In 0.26 these files come with Decidim in the folder src/decidim/vendor so the awesome one's could be removed
-import "src/vendor/image-resize.min"
-import "src/vendor/image-upload.min"
+import "src/decidim/editor/clipboard_override"
+import "src/decidim/vendor/image-resize.min"
+import "src/decidim/vendor/image-upload.min"
 
 const DecidimAwesome = window.DecidimAwesome || {};
 const quillFormats = ["bold", "italic", "link", "underline", "header", "list", "video", "image", "alt", "break", "width", "style", "code", "blockquote", "indent"];
@@ -27,8 +26,8 @@ export function destroyQuillEditor(container) {
     const content = $(container).find(".ql-editor").html();
     $(container).html(content);
     $(container).siblings(".ql-toolbar").remove();
-    $(container).find("*[class*='ql-']").removeClass((index, class_name) => (class_name.match(/(^|\s)ql-\S+/g) || []).join(" "));
-    $(container).removeClass((index, class_name) => (class_name.match(/(^|\s)ql-\S+/g) || []).join(" "));
+    $(container).find("*[class*='ql-']").removeClass((index, className) => (className.match(/(^|\s)ql-\S+/g) || []).join(" "));
+    $(container).removeClass((index, className) => (className.match(/(^|\s)ql-\S+/g) || []).join(" "));
     if ($(container).next().is("p.help-text")) {
       $(container).next().remove();
     }
@@ -41,6 +40,7 @@ export function destroyQuillEditor(container) {
 export function createQuillEditor(container) {
   const toolbar = $(container).data("toolbar");
   const disabled = $(container).data("disabled");
+  const allowedEmptyContentSelector = "iframe";
 
   let quillToolbar = [
     ["bold", "italic", "underline", "linebreak"],
@@ -93,7 +93,7 @@ export function createQuillEditor(container) {
       modules: ["Resize", "DisplaySize"]
     }
     modules.imageUpload = {
-      url: $(container).data("uploadImagesPath") || DecidimAwesome.editor_uploader_path,
+      url: DecidimAwesome.editor_uploader_path,
       method: "POST",
       name: "image",
       withCredentials: false,
@@ -104,7 +104,18 @@ export function createQuillEditor(container) {
       },
       callbackKO: (serverError) => {
         $("div.ql-toolbar").last().removeClass("editor-loading")
-        console.error(`Image upload error: ${serverError.message}`);
+        let msg = serverError && serverError.body;
+        try { 
+          msg = JSON.parse(msg).message; 
+        } catch (evt) { console.error("Parsing error", evt); }
+        console.error(`Image upload error: ${msg}`);
+        let $p = $(`<p class="text-alert help-text">${msg}</p>`);
+        $(container).after($p)
+        setTimeout(() => {
+          $p.fadeOut(1000, () => { 
+            $p.destroy();
+          });
+        }, 3000);
       },
       checkBeforeSend: (file, next) => {
         $("div.ql-toolbar").last().addClass("editor-loading")
@@ -137,6 +148,16 @@ export function createQuillEditor(container) {
     } else {
       $input.val(quill.root.innerHTML);
     }
+    if ((text === "\n" || text === "\n\n") && quill.root.querySelectorAll(allowedEmptyContentSelector).length === 0) {
+      $input.val("");
+    } else {
+      const emptyParagraph = "<p><br></p>";
+      const cleanHTML = quill.root.innerHTML.replace(
+        new RegExp(`^${emptyParagraph}|${emptyParagraph}$`, "g"),
+        ""
+      );
+      $input.val(cleanHTML);
+    }
   });
   // After editor is ready, linebreak_module deletes two extraneous new lines
   quill.emitter.emit("editor-ready");
@@ -153,7 +174,7 @@ export function createQuillEditor(container) {
 }
 
 export function createMarkdownEditor(container) {
-  const t = DecidimAwesome.texts.drag_and_drop_image;
+  const text = DecidimAwesome.texts.drag_and_drop_image;
   const token = $('meta[name="csrf-token"]').attr("content");
   const $input = $(container).siblings('input[type="hidden"]');
   const $faker = $('<textarea name="faker-inscrybmde"/>');
@@ -174,8 +195,8 @@ export function createMarkdownEditor(container) {
 
   // Allow image upload
   if (DecidimAwesome.allow_images_in_markdown_editor) {
-    $(inscrybmde.gui.statusbar).prepend(`<span class="help-text" style="float:left;margin:0;text-align:left;">${t}</span>`);
-    inlineAttachment.editors.codemirror4.attach(inscrybmde.codemirror, {
+    $(inscrybmde.gui.statusbar).prepend(`<span class="help-text" style="float:left;margin:0;text-align:left;">${text}</span>`);
+    window.inlineAttachment.editors.codemirror4.attach(inscrybmde.codemirror, {
       uploadUrl: DecidimAwesome.editor_uploader_path,
       uploadFieldName: "image",
       jsonFieldName: "url",

data/app/packs/src/decidim/decidim_awesome/forms/autosave.js

@@ -33,18 +33,14 @@ $(() => {
       '[name="utf8"]',
       '[name="authenticity_token"]',
       "[disabled]",
-      '[type="checkbox"]' // there are problems with matrix questions
+      // there are problems with matrix questions
+      '[type="checkbox"]' 
     ]
   });
 
-  const showMsg = (msg, error = false, default_time = 700) => {
-    const time = error
-      ? 5000
-      : default_time;
-    const $div = $(`<div class="awesome_autosave-notice${error
-      ? " error"
-      : ""}">${msg}</div>`).
-      appendTo($form);
+  const showMsg = (msg, error = false, defaultTime = 700) => {
+    const time = error ? 5000 : defaultTime; // eslint-disable-line no-ternary, multiline-ternary
+    const $div = $(`<div class="awesome_autosave-notice${error ? " error" : ""}">${msg}</div>`).appendTo($form); // eslint-disable-line no-ternary, multiline-ternary
     setTimeout(() => {
       $div.fadeOut(500, () => {
         $div.remove();
@@ -62,14 +58,14 @@ $(() => {
   }
 
   // restore if available
-  store.apply();
+  store.apply(); // eslint-disable-line prefer-reflect
   // restore checkboxes
   try {
     let checkboxes = JSON.parse(window.localStorage.getItem(storeCheckboxesId));
-    for (let id in checkboxes) {
+    for (let id in checkboxes) { // eslint-disable-line guard-for-in
       $(`#${id}`).prop("checked", checkboxes[id]);
     }
-  } catch (e) {
+  } catch (evt) {
     console.log("No checkboxes found");
   }
   // this trigger the "change" event, it seems that it is too much

data/app/packs/src/decidim/decidim_awesome/forms/custom_fields_renderer.js

@@ -2,8 +2,8 @@ require("formBuilder/dist/form-render.min.js")
 import "src/decidim/decidim_awesome/forms/rich_text_plugin"
 
 export default class CustomFieldsRenderer { // eslint-disable-line no-unused-vars
-  constructor(container_selector) {
-    this.container_selector = container_selector || ".proposal_custom_field:last";
+  constructor(containerSelector) {
+    this.containerSelector = containerSelector || ".proposal_custom_field:last";
     this.lang = this.getLang($("html").attr("lang"));
   }
 
@@ -56,14 +56,21 @@ export default class CustomFieldsRenderer { // eslint-disable-line no-unused-var
   */
   dataToXML(data) {
     const $dl = $("<dl/>");
-    let $dd, $div, $dt, key, l, label, text, val;
+    let $dd = null, 
+        $div = null, 
+        $dt = null, 
+        datum = null, 
+        key = null, 
+        label = null, 
+        text = null, 
+        val = null;
     $dl.attr("class", "decidim_awesome-custom_fields");
     $dl.attr("data-generator", "decidim_awesome");
     $dl.attr("data-version", window.DecidimAwesome.version);
-    for (key in data) {
+    for (key in data) { // eslint-disable-line guard-for-in
       // console.log("get the data!", key, data[key]);
       // Richtext plugin does not saves userdata, so we get it from the hidden input
-      if (data[key].type == "textarea" && data[key].subtype == "richtext") {
+      if (data[key].type === "textarea" && data[key].subtype === "richtext") {
         data[key].userData = [$(`#${data[key].name}-input`).val()];
       }
       if (data[key].userData && data[key].userData.length) {
@@ -72,25 +79,25 @@ export default class CustomFieldsRenderer { // eslint-disable-line no-unused-var
         $dt.attr("name", data[key].name);
         $dd = $("<dd/>");
         // console.log("data for", key, data[key].name, data[key])
-        for (val in data[key].userData) {
+        for (val in data[key].userData) { // eslint-disable-line guard-for-in
           $div = $("<div/>");
           label = data[key].userData[val];
           text = null;
           if (data[key].values) {
-            l = data[key].values.find((v) => v.value == label);
-            if (l) {
+            datum = data[key].values.find((obj) => obj.value === label); // eslint-disable-line no-loop-func
+            if (datum) { // eslint-disable-line max-depth
               text = label;
-              label = l.label;
+              label = datum.label;
             }
-          } else if (data[key].type == "date" && label) {
-            l = new Date(label).toLocaleDateString();
-            if (l) {
+          } else if (data[key].type === "date" && label) {
+            datum = new Date(label).toLocaleDateString();
+            if (datum) { // eslint-disable-line max-depth
               text = label;
-              label = l;
+              label = datum;
             }
           }
           // console.log("userData", text, "label", label, 'key', key, 'data', data)
-          if (data[key].type == "textarea" && data[key].subtype == "richtext") {
+          if (data[key].type === "textarea" && data[key].subtype === "richtext") {
             $div.html(label);
           } else {
             $div.text(label);
@@ -120,7 +127,7 @@ export default class CustomFieldsRenderer { // eslint-disable-line no-unused-var
     */
     this.$container.find(".formbuilder-checkbox-group").each((_key, group) => {
       const inputs = $(".formbuilder-checkbox input", group);
-      const data = this.spec.find((a) => a.type == "checkbox-group");
+      const data = this.spec.find((obj) => obj.type === "checkbox-group");
       let values = data.userData;
       if (!inputs.length || !data || !values) {
         return;
@@ -138,19 +145,19 @@ export default class CustomFieldsRenderer { // eslint-disable-line no-unused-var
       });
 
       // Fill "other" option
-      const other_option = $(".other-option", inputs.parent())[0];
-      const other_val = $(".other-val", inputs.parent())[0];
-      const other_text = values.join(" ");
+      const otherOption = $(".other-option", inputs.parent())[0];
+      const otherVal = $(".other-val", inputs.parent())[0];
+      const otherText = values.join(" ");
 
-      if (other_option) {
-        if (other_text) {
-          other_option.checked = true;
-          other_option.value = other_text;
-          other_val.value = other_text;
+      if (otherOption) {
+        if (otherText) {
+          otherOption.checked = true;
+          otherOption.value = otherText;
+          otherVal.value = otherText;
         } else {
-          other_option.checked = false;
-          other_option.value = "";
-          other_val.value = "";
+          otherOption.checked = false;
+          otherOption.value = "";
+          otherVal.value = "";
         }
       }
     });
@@ -169,6 +176,7 @@ export default class CustomFieldsRenderer { // eslint-disable-line no-unused-var
         }
       });
     });
+    return this;
   }
 
   // Saves xml to the hidden input
@@ -184,13 +192,14 @@ export default class CustomFieldsRenderer { // eslint-disable-line no-unused-var
       this.$element.data("spec", this.spec);
     }
     // console.log("storeData spec", this.spec, "$body", $body,"$form",$form,"this",this);
+    return this;
   }
 
   init($element) {
     this.$element = $element;
     this.spec = $element.data("spec");
     if (!this.$container) {
-      this.$container = $(this.container_selector);
+      this.$container = $(this.containerSelector);
     }
     // console.log("init", $element, "this", this)
     // always use the last field (in case of multilang tabs we only render one form due a limitation of the library to handle several instances)

data/app/packs/src/decidim/decidim_awesome/forms/rich_text_plugin.js

@@ -24,7 +24,7 @@ window.fbControls.push(function(controlClass, allControlClasses) {
 
     /**
      * Class configuration - return the icons & label related to this control
-     * @returndefinition object
+     * @return {JSON} definition object
      */
     static get definition() {
       return {
@@ -37,6 +37,7 @@ window.fbControls.push(function(controlClass, allControlClasses) {
 
     /**
      * configure the richtext editor requirements
+     * @return {void}
      */
     configure() {
       window.fbEditors.richtext = {};
@@ -68,15 +69,16 @@ window.fbControls.push(function(controlClass, allControlClasses) {
         `,
         { type: "text/css" }
       );
-      const wrapper_attrs = {...attrs, "data-toolbar": "full" };
-      // console.log("build value", value, "userData", userData, "attrs", attrs, attrs.id, "wrapper_attrs", wrapper_attrs);
-      this.wrapper = this.markup("div", null, wrapper_attrs);
+      const wrapperAttrs = {...attrs, "data-toolbar": "full" };
+      // console.log("build value", value, "userData", userData, "attrs", attrs, attrs.id, "wrapperAttrs", wrapperAttrs);
+      this.wrapper = this.markup("div", null, wrapperAttrs);
       return this.markup("div", [css, this.input, this.wrapper], attrs);
     }
 
     /**
      * When the element is rendered into the DOM, execute the following code to initialise it
      * @param {Object} evt - event
+     * @return {Object} evt - event
      */
     onRender(evt) {
       // const value = this.config.value || '';

data/app/packs/src/decidim/decidim_awesome/proposals/custom_fields.js

@@ -5,18 +5,18 @@ window.DecidimAwesome.CustomFieldsRenderer = window.DecidimAwesome.CustomFieldsR
 $(() => {
   // use admin multilang specs if exists
   let $el = $("proposal_custom_field:first", ".tabs-title.is-active");
-  $el = $el.length
-    ? $el
-    : $(".proposal_custom_field:first");
+  if (!$el.length) {
+    $el = $(".proposal_custom_field:first");
+  }
   window.DecidimAwesome.CustomFieldsRenderer.init($el);
 
-  window.DecidimAwesome.CustomFieldsRenderer.$container.closest("form").on("submit", (e) => {
-    if (e.target.checkValidity()) {
+  window.DecidimAwesome.CustomFieldsRenderer.$container.closest("form").on("submit", (evt) => {
+    if (evt.target.checkValidity()) {
       // save current editor
       window.DecidimAwesome.CustomFieldsRenderer.storeData();
     } else {
-      e.preventDefault();
-      e.target.reportValidity();
+      evt.preventDefault();
+      evt.target.reportValidity();
     }
   });
 });

data/app/packs/src/decidim/decidim_awesome/proposals/images.js

@@ -3,7 +3,7 @@ $(() => {
 
   const token = $('meta[name="csrf-token"]').attr("content");
   const $textarea = $("textarea#proposal_body");
-  const t = window.DecidimAwesome.texts.drag_and_drop_image;
+  const text = window.DecidimAwesome.texts.drag_and_drop_image;
 
   if (!$textarea.length) {
     return;
@@ -12,7 +12,7 @@ $(() => {
   if (window.DecidimAwesome.allow_images_in_proposals) {
     // Add the capability to upload images only (they will be presented as links)
 
-    $textarea.after(`<p class="help-text">${t}</p>`);
+    $textarea.after(`<p class="help-text">${text}</p>`);
     $textarea.inlineattachment({
       uploadUrl: window.DecidimAwesome.editor_uploader_path,
       uploadFieldName: "image",

data/app/packs/stylesheets/decidim/decidim_awesome/awesome_admin.scss

@@ -6,11 +6,14 @@
 @import "stylesheets/decidim/decidim_awesome/editors/markdown_editor";
 @import "stylesheets/decidim/decidim_awesome/editors/quill_editor";
 
-.platoniq-credits {
-  position: absolute;
-  bottom: 0;
-  right: 0;
-  margin: 1em;
+.pokecode-credits {
+  float: right;
+  margin: 0 1em .5em 0;
+
+  // position: absolute;
+  // bottom: 0;
+  // right: 0;
+  // margin: 1em;
   font-size: .8em;
 }