decidim-decidim_awesome 0.7.0 → 0.7.2

data/lib/decidim/decidim_awesome/test/shared_examples/current_config_examples.rb

@@ -0,0 +1,143 @@
+# frozen_string_literal: true
+
+shared_examples "same environment" do
+  it "do not modify the environment" do
+    code, new_env = middleware.call(env)
+
+    expect(new_env).to eq(env)
+    expect(code).to eq(200)
+  end
+
+  it "has current organization in env" do
+    _code, new_env = middleware.call(env)
+
+    expect(new_env["decidim.current_organization"]).to eq(env["decidim.current_organization"])
+    expect(new_env["decidim_awesome.current_config"]).to be_a Decidim::DecidimAwesome::Config
+  end
+end
+
+shared_examples "untampered user model" do
+  it "user model is reset" do
+    # ensure model is always reset after calling the middleware
+    Decidim::User.awesome_admins_for_current_scope = [123]
+    middleware.call(env)
+
+    expect(Decidim::User.awesome_admins_for_current_scope).not_to be_present
+  end
+end
+
+shared_examples "tampered users model" do
+  it "user model is tampered" do
+    # ensure model is always reset after calling the middleware
+    Decidim::User.awesome_admins_for_current_scope = [123]
+    middleware.call(env)
+
+    expect(Decidim::User.awesome_admins_for_current_scope).to match_array([user.id, admin.id])
+  end
+end
+
+shared_examples "tampered user model" do
+  it "user model is tampered" do
+    # ensure model is always reset after calling the middleware
+    Decidim::User.awesome_admins_for_current_scope = [123]
+    middleware.call(env)
+
+    expect(Decidim::User.awesome_admins_for_current_scope).to match_array([user.id])
+  end
+end
+
+shared_examples "tampered admin model" do
+  it "user model is tampered" do
+    # ensure model is always reset after calling the middleware
+    Decidim::User.awesome_admins_for_current_scope = [123]
+    middleware.call(env)
+
+    expect(Decidim::User.awesome_admins_for_current_scope).to match_array([admin.id])
+  end
+end
+
+shared_examples "generic admin routes" do
+  context "when admin index" do
+    let(:path) { "admin/" }
+
+    it_behaves_like "tampered users model"
+
+    context "when additional slashes" do
+      let(:path) { "/admin/" }
+
+      it_behaves_like "untampered user model"
+    end
+
+    context "when multiple slashes" do
+      let(:path) { "//admin/" }
+
+      it_behaves_like "untampered user model"
+    end
+
+    context "when POST" do
+      let(:method) { "POST" }
+
+      it_behaves_like "untampered user model"
+    end
+
+    context "when PATCH" do
+      let(:method) { "PATCH" }
+
+      it_behaves_like "untampered user model"
+    end
+  end
+
+  context "when admin terms" do
+    let(:path) { "admin/admin_terms" }
+
+    it_behaves_like "tampered users model"
+
+    context "when POST" do
+      let(:method) { "POST" }
+
+      it_behaves_like "tampered users model"
+    end
+  end
+
+  context "when admin out of scope" do
+    let(:path) { "admin/some_path" }
+
+    it_behaves_like "untampered user model"
+  end
+
+  context "when admin an assembly" do
+    let(:path) { "admin/assemblies/#{assembly.slug}" }
+
+    it_behaves_like "tampered users model"
+
+    context "and accessing assemblies index" do
+      let(:path) { "admin/assemblies" }
+
+      it_behaves_like "tampered users model"
+
+      context "when POST" do
+        let(:method) { "POST" }
+
+        it_behaves_like "untampered user model"
+      end
+
+      context "when PATCH" do
+        let(:method) { "PATCH" }
+
+        it_behaves_like "untampered user model"
+      end
+    end
+  end
+
+  context "and accessing another assemblies index" do
+    let(:path) { "admin/assemblies/#{another_assembly.slug}" }
+
+    it_behaves_like "untampered user model"
+  end
+
+  context "when admin a participatory process" do
+    let(:path) { "admin/participatory_processes/some-process" }
+
+    it_behaves_like "tampered admin model"
+  end
+end

data/lib/decidim/decidim_awesome/test/shared_examples/editor_examples.rb

@@ -11,10 +11,12 @@ shared_examples "has no drag and drop" do |rte|
     end
   else
     it "has no paste event" do
+      sleep 1
       expect(page.execute_script("return typeof $._data($('#{editor_selector}')[0], 'events').paste")).to eq("undefined")
     end
 
     it "has no drop event" do
+      sleep 1
       expect(page.execute_script("return typeof $._data($('#{editor_selector}')[0], 'events').drop")).to eq("undefined")
     end
   end
@@ -31,10 +33,12 @@ shared_examples "has drag and drop" do |rte|
     end
   else
     it "has paste event" do
+      sleep 1
       expect(page.execute_script("return typeof $._data($('#{editor_selector}')[0], 'events').paste")).to eq("object")
     end
 
     it "has drop event" do
+      sleep 1
       expect(page.execute_script("return typeof $._data($('#{editor_selector}')[0], 'events').drop")).to eq("object")
     end
   end

data/lib/decidim/decidim_awesome/test/shared_examples/scoped_admins_examples.rb

@@ -0,0 +1,428 @@
+# frozen_string_literal: true
+
+shared_examples "redirects to index" do |_link|
+  it "display index page" do
+    expect(page).to have_content("You are not authorized to perform this action")
+    expect(page).to have_content("Welcome to the Decidim Admin Panel.")
+    expect(page).to have_current_path(decidim_admin.root_path, ignore_query: true)
+  end
+end
+
+shared_examples "forbids awesome access" do
+  it "does not have awesome link" do
+    visit decidim_admin.root_path
+    expect(page).not_to have_content("Decidim awesome")
+  end
+
+  describe "forbids module access" do
+    before do
+      visit decidim_admin_decidim_awesome.config_path(:editors)
+    end
+
+    it_behaves_like "redirects to index"
+  end
+end
+
+shared_examples "allows awesome access" do
+  it "does not have awesome link" do
+    visit decidim_admin.root_path
+    expect(page).to have_link("Decidim awesome")
+  end
+
+  it "allows module access" do
+    visit decidim_admin_decidim_awesome.config_path(:editors)
+    expect(page).to have_content("Tweaks for editors")
+  end
+end
+
+shared_examples "forbids external accesses" do
+  describe "forbids newsletter access" do
+    before do
+      visit decidim_admin.newsletters_path
+    end
+
+    it_behaves_like "redirects to index"
+  end
+
+  describe "forbids participants access" do
+    before do
+      visit decidim_admin.users_path
+    end
+
+    it_behaves_like "redirects to index"
+  end
+
+  describe "forbids pages access" do
+    before do
+      visit decidim_admin.static_pages_path
+    end
+
+    it_behaves_like "redirects to index"
+  end
+
+  unless legacy_version?
+    describe "forbids moderation access" do
+      before do
+        visit decidim_admin.moderations_path
+      end
+
+      it_behaves_like "redirects to index"
+    end
+  end
+
+  describe "forbids organization access" do
+    before do
+      visit decidim_admin.edit_organization_path
+    end
+
+    it_behaves_like "redirects to index"
+  end
+end
+
+shared_examples "allows external accesses" do
+  it "shows newsletter access" do
+    visit decidim_admin.newsletters_path
+    expect(page).to have_content("New newsletter")
+  end
+
+  it "shows participants access" do
+    visit decidim_admin.users_path
+    if legacy_version?
+      expect(page).to have_content("New Participant")
+    else
+      expect(page).to have_content("New user")
+    end
+  end
+
+  it "shows pages access" do
+    visit decidim_admin.static_pages_path
+    expect(page).to have_content("Pages without topic")
+  end
+
+  unless legacy_version?
+    it "shows moderation access" do
+      visit decidim_admin.moderations_path
+      expect(page).to have_content("Reported content URL")
+    end
+  end
+
+  it "shows organization access" do
+    visit decidim_admin.edit_organization_path
+    expect(page).to have_content("Edit organization")
+  end
+end
+
+shared_examples "allows all admin routes" do
+  before do
+    visit decidim_admin.root_path
+  end
+
+  it "allows the admin root page" do
+    expect(page).to have_content("Welcome to the Decidim Admin Panel.")
+  end
+
+  it "allows the assemblies page" do
+    click_link "Assemblies"
+
+    expect(page).to have_content("New assembly")
+  end
+
+  it "allows the processes page" do
+    click_link "Processes"
+
+    expect(page).to have_content("New process")
+  end
+end
+
+shared_examples "allows scoped admin routes" do
+  before do
+    visit decidim_admin.root_path
+  end
+
+  it "allows the admin root page" do
+    expect(page).to have_content("Welcome to the Decidim Admin Panel.")
+  end
+
+  it "allows the assemblies page" do
+    click_link "Assemblies"
+
+    expect(page).to have_content("New assembly")
+  end
+
+  describe "forbids processes" do
+    before do
+      click_link "Processes"
+    end
+
+    it_behaves_like "redirects to index"
+
+    it "is not a process page" do
+      expect(page).not_to have_content("New process")
+    end
+  end
+end
+
+shared_examples "has admin link" do
+  it "has menu link" do
+    within ".topbar__dropmenu.topbar__user__logged" do
+      expect(page).to have_selector("#user-menu li", text: "Admin dashboard", visible: :hidden)
+    end
+  end
+end
+
+shared_examples "has no admin link" do
+  it "has menu link" do
+    within ".topbar__dropmenu.topbar__user__logged" do
+      expect(page).not_to have_selector("#user-menu li", text: "Admin dashboard", visible: :hidden)
+    end
+  end
+end
+
+shared_examples "shows partial admin links in the frontend" do
+  describe "shows the link in the homepage" do
+    before do
+      visit decidim.root_path
+    end
+
+    it_behaves_like "has admin link"
+  end
+
+  describe "shows the link in assemblies" do
+    before do
+      visit decidim_assemblies.assemblies_path
+    end
+
+    it_behaves_like "has admin link"
+    it "has a Edit button" do
+      expect(page).to have_link(href: "/admin/assemblies")
+    end
+  end
+
+  describe "do not show the link in processes" do
+    before do
+      visit decidim_participatory_processes.participatory_processes_path
+    end
+
+    it_behaves_like "has no admin link"
+    it "has no Edit button" do
+      expect(page).not_to have_link(href: "/admin/processes")
+    end
+  end
+end
+
+shared_examples "can edit assembly" do
+  it "can save" do
+    visit decidim_admin_assemblies.edit_assembly_path(assembly.slug)
+    expect(page).to have_content("General Information")
+    fill_in_i18n(
+      :assembly_title,
+      "#assembly-title-tabs",
+      en: "Edited assembly",
+      ca: "Assamblea editada",
+      es: "Asamblea editada"
+    )
+    find("*[type=submit]").click
+    expect(page).to have_admin_callout("successfully")
+  end
+end
+
+shared_examples "edits all assemblies" do
+  before do
+    visit decidim_admin.root_path
+  end
+
+  it_behaves_like "can edit assembly"
+
+  it "can edit another assembly" do
+    visit decidim_admin_assemblies.edit_assembly_path(another_assembly.slug)
+    expect(page).to have_content("General Information")
+  end
+end
+
+shared_examples "edits allowed assemblies" do
+  before do
+    visit decidim_admin.root_path
+  end
+
+  it_behaves_like "can edit assembly"
+
+  describe "forbids unallowed assembly" do
+    before do
+      visit decidim_admin_assemblies.edit_assembly_path(another_assembly.slug)
+    end
+
+    it_behaves_like "redirects to index"
+  end
+
+  describe "create new assemblies" do
+    before do
+      visit decidim_admin_assemblies.new_assembly_path
+    end
+
+    it_behaves_like "redirects to index"
+  end
+end
+
+shared_examples "can manage component" do
+  it "can update proposal" do
+    visit manage_component_path(component)
+    expect(page).to have_content("Proposals")
+    expect(page).to have_content("Title")
+    expect(page).to have_content(proposal.title["en"])
+
+    click_link "Edit proposal"
+    expect(page).to have_content("Update proposal")
+    fill_in_i18n(
+      :proposal_title,
+      "#proposal-title-tabs",
+      en: "Edited proposal",
+      ca: "Proposta editada",
+      es: "Propuesta editada"
+    )
+    find("*[type=submit]").click
+    expect(page).to have_admin_callout("successfully")
+  end
+
+  it "can create a proposal" do
+    visit manage_component_path(component)
+
+    click_link "New proposal"
+    expect(page).to have_content("Create proposal")
+    fill_in_i18n(
+      :proposal_title,
+      "#proposal-title-tabs",
+      en: "Create proposal",
+      ca: "Proposta creada",
+      es: "Propuesta creada"
+    )
+    fill_in_i18n_editor(
+      :proposal_body,
+      "#proposal-body-tabs",
+      en: "Create body",
+      ca: "Body creat",
+      es: "Body creat"
+    )
+    find("*[type=submit]").click
+    expect(page).to have_admin_callout("successfully")
+  end
+end
+
+shared_examples "edits allowed components" do
+  before do
+    visit decidim_admin.root_path
+  end
+
+  it_behaves_like "can manage component"
+  it "can edit component" do
+    visit Decidim::EngineRouter.admin_proxy(component.participatory_space).edit_component_path(component.id)
+    expect(page).to have_content("Edit component")
+  end
+
+  it "set permissions in component" do
+    visit Decidim::EngineRouter.admin_proxy(component.participatory_space).edit_component_permissions_path(component.id)
+    expect(page).to have_content("Edit permissions")
+  end
+
+  describe "forbids unallowed component" do
+    before do
+      visit manage_component_path(another_component)
+    end
+
+    it_behaves_like "redirects to index"
+  end
+end
+
+shared_examples "shows component partial admin links in the frontend" do
+  describe "shows the link in the homepage" do
+    before do
+      visit decidim.root_path
+    end
+
+    it_behaves_like "has admin link"
+  end
+
+  describe "shows the link in the component" do
+    before do
+      visit main_component_path(component)
+    end
+
+    it_behaves_like "has admin link"
+    it "has a Edit button" do
+      expect(page).to have_link(href: manage_component_path(component))
+    end
+  end
+
+  describe "do not show the link in another compoenent" do
+    before do
+      visit main_component_path(another_component)
+    end
+
+    it_behaves_like "has no admin link"
+    it "has no Edit button" do
+      expect(page).not_to have_link(href: manage_component_path(another_component))
+    end
+  end
+end
+
+shared_examples "allows access to group processes" do
+  before do
+    visit decidim_admin_participatory_processes.participatory_processes_path
+  end
+
+  it "shows the list of processes" do
+    expect(page).to have_content("Participatory processes")
+    expect(page).to have_content(participatory_process.title["en"])
+  end
+
+  describe "forbids editing processes" do
+    before do
+      visit decidim_admin_participatory_processes.edit_participatory_process_path(participatory_process.slug)
+    end
+
+    it_behaves_like "redirects to index"
+  end
+
+  describe "allows listing group process" do
+    before do
+      visit decidim_admin_participatory_processes.participatory_process_groups_path
+    end
+
+    it "shows the list of groups" do
+      expect(page).to have_content("Participatory process groups")
+      expect(page).to have_content(process_group.title["en"])
+    end
+  end
+end
+
+shared_examples "allows edit any group process" do
+  before do
+    visit decidim_admin_participatory_processes.edit_participatory_process_group_path(another_process_group.id)
+  end
+
+  it "allows to edit group processes" do
+    expect(page).to have_content("Edit process group")
+    fill_in_i18n(
+      :participatory_process_group_title,
+      "#participatory_process_group-title-tabs",
+      en: "Edited process group",
+      ca: "Proces grup editat",
+      es: "Grupo de procesos editado"
+    )
+    find("*[type=submit]").click
+    expect(page).to have_admin_callout("successfully")
+  end
+end
+
+shared_examples "allows edit only allowed group process" do
+  before do
+    visit decidim_admin_participatory_processes.participatory_processes_path
+  end
+
+  describe "forbids editing group" do
+    before do
+      visit decidim_admin_participatory_processes.edit_participatory_process_group_path(another_process_group.id)
+    end
+
+    it_behaves_like "redirects to index"
+  end
+end

data/lib/decidim/decidim_awesome/version.rb

@@ -3,7 +3,7 @@
 module Decidim
   # This holds the decidim-decidim_awesome version.
   module DecidimAwesome
-    VERSION = "0.7.0"
+    VERSION = "0.7.2"
     COMPAT_DECIDIM_VERSION = [">= 0.23.0", "< 0.25"].freeze
   end
 end

data/lib/decidim/decidim_awesome.rb

@@ -3,7 +3,6 @@
 require "decidim/decidim_awesome/admin"
 require "decidim/decidim_awesome/engine"
 require "decidim/decidim_awesome/admin_engine"
-require "decidim/decidim_awesome/content_renderers"
 require "decidim/decidim_awesome/context_analyzers"
 require "decidim/decidim_awesome/map_component/engine"
 require "decidim/decidim_awesome/map_component/component"
@@ -16,9 +15,9 @@ module Decidim
 
     autoload :Config, "decidim/decidim_awesome/config"
     autoload :SystemChecker, "decidim/decidim_awesome/system_checker"
-    autoload :ContentRenderes, "decidim/decidim_awesome/content_renderers"
     autoload :ContextAnalyzers, "decidim/decidim_awesome/context_analyzers"
     autoload :MenuHacker, "decidim/decidim_awesome/menu_hacker"
+    autoload :CustomFields, "decidim/decidim_awesome/custom_fields"
 
     # Boolean configuration options
     #
@@ -72,6 +71,19 @@ module Decidim
       {}
     end
 
+    # custom fields for proposals using JSON specification:
+    # https://github.com/jsonform/jsonform/wiki
+    # Valid values uses the same structure as :scoped_styles
+    #   :disabled => false and non available, hidden from admins
+    #   Hash => hash of different JSON texts, each key will be used for the contraints
+    # Admins can create this hash dynamically but some pre-defined css boxes can be created here as:
+    #   {
+    #      some_identifier: "{ ... some definition... }"
+    #   }
+    config_accessor :proposal_custom_fields do
+      {}
+    end
+
     # allows to keep modifications for the main menu
     # can return :disabled to completly remove this feature
     # otherwise it should be an array (some overrides can be specified by default):
@@ -86,6 +98,18 @@ module Decidim
       []
     end
 
+    # Allows admins to assignate "fake" admins scoped to some admin zones using the
+    # same scope editor as :scoped_styles, valid values uses the same convention:
+    #   :disabled => false and non available, hidden from admins
+    #   Hash => hash of different admin ids, each key will be used for the contraints
+    # Admins create this hash dynamically but some pre-defined admin boxes can be created here as:
+    #   {
+    #      some_identifier: [1234, 5678, 90123]
+    #   }
+    config_accessor :scoped_admins do
+      {}
+    end
+
     # these settings do not follow the :disabled convention but
     # depends on the previous intergram configurations
     config_accessor :intergram_url do
@@ -119,6 +143,21 @@ module Decidim
         auto_no_response: nil
       }
     end
+
+    # additional correspondences between participatory spaces manifests and routes
+    # ie: /admin/assemblies and /admin/assemblies_types are both treated as a "assembly" participatory space in terms of permission scoping
+    # This can be tuned in a initialized if some other hacks over routes are applied
+    # if a registered participatory space is not listed here then the name manifest will be used as a default route /manifest_name /admin/manifes_name
+    config_accessor :participatory_spaces_routes_context do
+      {
+        # route in admin is diferent than in the frontend: /processes, /admin/participatory_processes
+        participatory_processes: [:participatory_processes, :processes],
+        # both /admin/assemblies and /admin/assemblies_types are considered assemblies
+        assemblies: [:assemblies, :assemblies_types],
+        # route in admin is diferent than in the frontend: /process_groups, /admin/participatory_process_groups
+        process_groups: [:processes_groups, :participatory_process_groups]
+      }
+    end
   end
 end
 
@@ -129,9 +168,3 @@ Decidim.register_global_engine(
   ::Decidim::DecidimAwesome::Engine,
   at: "/decidim_awesome"
 )
-
-# Decidim.register_global_engine(
-#   :decidim_admin_action_awesome,
-#   ::Decidim::DecidimAwesome::AdminEngine,
-#   at: "/admin/action_awesome"
-# )