decidim-decidim_awesome 0.10.1 → 0.11.1

data/db/migrate/20240306175331_rename_editor_images_awesome_config.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+class RenameEditorImagesAwesomeConfig < ActiveRecord::Migration[6.1]
+  class AwesomeConfig < ApplicationRecord
+    self.table_name = :decidim_awesome_config
+  end
+
+  # rubocop:disable Rails/SkipsModelValidations
+  def up
+    AwesomeConfig.where(var: :allow_images_in_full_editor).update_all(var: :allow_images_in_editors)
+    AwesomeConfig.where(var: :allow_images_in_small_editor).destroy_all
+  end
+
+  def down
+    AwesomeConfig.where(var: :allow_images_in_editors).update_all(var: :allow_images_in_full_editor)
+  end
+  # rubocop:enable Rails/SkipsModelValidations
+end

data/db/migrate/20240531224204_add_decidim_awesome_proposal_private_fields.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+class AddDecidimAwesomeProposalPrivateFields < ActiveRecord::Migration[6.0]
+  class ProposalExtraField < ApplicationRecord
+    self.table_name = :decidim_awesome_proposal_extra_fields
+  end
+
+  def change
+    add_column :decidim_awesome_proposal_extra_fields, :private_body, :string
+    add_column :decidim_awesome_proposal_extra_fields, :decidim_proposal_type, :string
+    reversible do |direction|
+      direction.up do
+        execute <<~SQL.squish
+          UPDATE decidim_awesome_proposal_extra_fields
+          SET decidim_proposal_type = 'Decidim::Proposals::Proposal'
+        SQL
+      end
+    end
+
+    remove_index :decidim_awesome_proposal_extra_fields, name: "decidim_awesome_extra_fields_on_proposal"
+    add_index :decidim_awesome_proposal_extra_fields,
+              [:decidim_proposal_id, :decidim_proposal_type],
+              name: "index_decidim_awesome_proposal_extra_fields_on_decidim_proposal"
+
+    change_column_null :decidim_awesome_proposal_extra_fields, :decidim_proposal_id, false
+    change_column_null :decidim_awesome_proposal_extra_fields, :decidim_proposal_type, false
+    ProposalExtraField.reset_column_information
+  end
+end

data/db/migrate/20240729164227_add_decidim_awesome_proposal_private_fields_date.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+class AddDecidimAwesomeProposalPrivateFieldsDate < ActiveRecord::Migration[6.1]
+  class ProposalExtraField < ApplicationRecord
+    self.table_name = :decidim_awesome_proposal_extra_fields
+  end
+
+  def change
+    add_column :decidim_awesome_proposal_extra_fields, :private_body_updated_at, :datetime
+
+    reversible do |direction|
+      direction.up do
+        execute <<~SQL.squish
+          UPDATE decidim_awesome_proposal_extra_fields
+          SET private_body_updated_at = updated_at
+        SQL
+      end
+    end
+  end
+end

data/db/seeds.rb

@@ -7,7 +7,7 @@ if !Rails.env.production? || ENV.fetch("SEED", nil)
 
   # Set the htmleditor on to facilitate development
   admin_user = Decidim::User.find_by(
-    organization: organization,
+    organization:,
     email: "admin@example.org"
   )
 
@@ -18,10 +18,10 @@ if !Rails.env.production? || ENV.fetch("SEED", nil)
   )
 
   # Enable images in general
-  setting = Decidim::DecidimAwesome::AwesomeConfig.find_or_initialize_by(var: :allow_images_in_full_editor, organization: organization)
+  setting = Decidim::DecidimAwesome::AwesomeConfig.find_or_initialize_by(var: :allow_images_in_editors, organization:)
   setting.value = true
   setting.save!
-  setting = Decidim::DecidimAwesome::AwesomeConfig.find_or_initialize_by(var: :allow_images_in_small_editor, organization: organization)
+  setting = Decidim::DecidimAwesome::AwesomeConfig.find_or_initialize_by(var: :allow_videos_in_editors, organization:)
   setting.value = true
   setting.save!
 end

data/lib/decidim/decidim_awesome/admin_engine.rb

@@ -16,7 +16,9 @@ module Decidim
       routes do
         # Add admin engine routes here
         resources :constraints
-        resources :menu_hacks, except: [:show]
+        resources :menus, only: [:show] do
+          resources :hacks, except: [:show], controller: "menu_hacks"
+        end
         resources :custom_redirects, except: [:show]
         resources :config, param: :var, only: [:show, :update]
         resources :scoped_styles, param: :var, only: [:create, :destroy]
@@ -26,7 +28,10 @@ module Decidim
         post :export_admin_accountability, to: "admin_accountability#export", as: "export_admin_accountability"
         get :users, to: "config#users"
         post :rename_scope_label, to: "config#rename_scope_label"
-        get :checks, to: "checks#index"
+        resources :maintenance, only: [:show] do
+          delete :destroy_private_data, on: :member
+          get :checks, on: :collection, to: "checks#index"
+        end
         post :migrate_images, to: "checks#migrate_images"
         root to: "config#show"
       end
@@ -37,19 +42,33 @@ module Decidim
         end
       end
 
-      initializer "decidim_awesome.admin_menu" do
+      initializer "decidim_awesome.admin_menus" do
+        first_available = Decidim::DecidimAwesome::Menu.menus.detect { |_key, val| val.present? }&.first
+
         Decidim.menu :admin_menu do |menu|
           menu.add_item :awesome_menu,
                         I18n.t("menu.decidim_awesome", scope: "decidim.admin"),
-                        decidim_admin_decidim_awesome.config_path(:editors),
+                        if first_available
+                          decidim_admin_decidim_awesome.config_path(first_available)
+                        else
+                          decidim_admin_decidim_awesome.checks_maintenance_index_path
+                        end,
                         icon_name: "fire",
                         position: 7.5,
-                        active: is_active_link?(decidim_admin_decidim_awesome.config_path(:editors), :inclusive),
+                        active: if first_available
+                                  is_active_link?(decidim_admin_decidim_awesome.config_path(first_available), :inclusive)
+                                else
+                                  is_active_link?(decidim_admin_decidim_awesome.checks_maintenance_index_path)
+                                end,
                         if: defined?(current_user) && current_user&.read_attribute("admin")
         end
-      end
+        # submenus
+        Decidim::DecidimAwesome::Menu.register_custom_fields_submenu!
+        Decidim::DecidimAwesome::Menu.register_menu_hacks_submenu!
+        Decidim::DecidimAwesome::Menu.register_maintenance_admin_menu!
+        Decidim::DecidimAwesome::Menu.register_awesome_admin_menu!
 
-      initializer "decidim_awesome.admin_menu" do
+        # user menu
         Decidim.menu :admin_user_menu do |menu|
           if DecidimAwesome.enabled? :admin_accountability
             menu.add_item :admin_accountability,

data/lib/decidim/decidim_awesome/api/types/localized_custom_fields_type.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    # This type represents a localized string in a single language.
+    class LocalizedCustomFieldsType < Decidim::Api::Types::BaseObject
+      description "Represents a particular translation of a LocalizedCustomFieldsType"
+
+      field :locale, GraphQL::Types::String, "The standard locale of this translation.", null: false
+      field :fields, GraphQL::Types::JSON, "The fields of this translation.", null: true
+      field :machine_translated, GraphQL::Types::Boolean, "Whether this string is machine translated or not.", null: false
+
+      def machine_translated
+        if object.respond_to?(:machine_translated)
+          object.machine_translated.present?
+        else
+          false
+        end
+      end
+    end
+  end
+end

data/lib/decidim/decidim_awesome/api/types/translated_custom_fields_type.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Decidim::DecidimAwesome
+    # This type represents a translated field in multiple languages.
+    class TranslatedCustomFieldsType < Decidim::Api::Types::BaseObject
+      description "A translated field"
+
+      field :locales, [GraphQL::Types::String, { null: true }], description: "Lists all the locales in which this translation is available", null: true
+
+      field :translations, [LocalizedCustomFieldsType, { null: true }], description: "All the localized custom fields for this translation.", null: false do
+        argument :locales, [GraphQL::Types::String], description: "A list of locales to scope the translations to.", required: false
+      end
+
+      field :translation, GraphQL::Types::JSON, description: "Returns a single translation given a locale.", null: true do
+        argument :locale, GraphQL::Types::String, "A locale to search for", required: true
+      end
+
+      def locales
+        (defined_translations.keys + machine_translations.keys).uniq
+      end
+
+      def translation(locale: "")
+        display_translations[locale]
+      end
+
+      def translations(locales: [])
+        translations = display_translations
+        translations = translations.slice(*locales) unless locales.empty?
+
+        translations.map { |locale, fields| OpenStruct.new(locale:, fields:, machine_translated: defined_translations[locale].blank?) }
+      end
+
+      private
+
+      def display_translations
+        @display_translations ||= locales.index_with do |locale|
+          defined_translations[locale].presence || machine_translations[locale]
+        end
+      end
+
+      def defined_translations
+        object.stringify_keys.except("machine_translations")
+      end
+
+      def machine_translations
+        object.stringify_keys["machine_translations"]&.stringify_keys || {}
+      end
+    end
+  end
+end

data/lib/decidim/decidim_awesome/awesome.rb

@@ -10,8 +10,11 @@ module Decidim
     autoload :MenuHacker, "decidim/decidim_awesome/menu_hacker"
     autoload :CustomFields, "decidim/decidim_awesome/custom_fields"
     autoload :VotingManifest, "decidim/decidim_awesome/voting_manifest"
+    autoload :Lock, "decidim/decidim_awesome/lock"
+    autoload :TranslatedCustomFieldsType, "decidim/decidim_awesome/api/types/translated_custom_fields_type"
+    autoload :LocalizedCustomFieldsType, "decidim/decidim_awesome/api/types/localized_custom_fields_type"
 
-    # Awesome coms with some components for participatory spaces
+    # Awesome comes with some components for participatory spaces
     # Currently :awesome_map and :awesome_iframe, list them here
     # if you wan to disable them
     # NOTE if you have spaces with some of these components already configured
@@ -32,11 +35,11 @@ module Decidim
     #   true  => always true but admins can still restrict its scope
     #   false => default false, admins can turn it true
     #   :disabled => false and non available, hidden from admins
-    config_accessor :allow_images_in_full_editor do
+    config_accessor :allow_images_in_editors do
       false
     end
 
-    config_accessor :allow_images_in_small_editor do
+    config_accessor :allow_videos_in_editors do
       false
     end
 
@@ -44,28 +47,20 @@ module Decidim
       false
     end
 
-    config_accessor :use_markdown_editor do
-      false
-    end
-
-    config_accessor :allow_images_in_markdown_editor do
-      false
-    end
-
     # used to save forms in localstorage
     config_accessor :auto_save_forms do
-      false
+      true
     end
 
     # Live chat widget linked to Telegram account or group
     # In the admin side only
     config_accessor :intergram_for_admins do
-      false
+      true
     end
 
     # In the public side only
     config_accessor :intergram_for_public do
-      false
+      true
     end
 
     # Configuration options to handle different validations in proposals
@@ -121,6 +116,16 @@ module Decidim
       ]
     end
 
+    # Allows admins to limit the amount of pending amendments to (currently) one per proposal before it's accepted.
+    # Once a pending amendment is accepted, a new on can be created.
+    # Note that this does not limit the number of amendment per se, the admin has to set the limit in the proposal's component configuration.
+    # set to :disable to will prevent admins to set an amendment's limit in the proposal's component configuration.
+    # if set to "true" the checkbox will be checked by default
+    # if set to "false" the checkbox will be unchecked by default
+    config_accessor :allow_limiting_amendments do
+      false
+    end
+
     # allows admins to created specific CSS snippets affecting only some specific parts
     # Valid values differ a little from the previous convention:
     #   :disabled => false and non available, hidden from admins
@@ -146,6 +151,21 @@ module Decidim
       {}
     end
 
+    # Same as proposal_custom_fields but for generating private fields than can be read only by admins
+    config_accessor :proposal_private_custom_fields do
+      {}
+    end
+
+    # How old must be the private data to be considered expired and therefore presented to the admins for deletion
+    config_accessor :private_data_expiration_time do
+      3.months
+    end
+
+    # How long must be the private data prevented from being deleted again after being scheduled for deletion
+    config_accessor :lock_time do
+      1.minute
+    end
+
     # allows to keep modifications for the main menu
     # can return :disabled to completly remove this feature
     # otherwise it should be an array (some overrides can be specified by default):
@@ -160,6 +180,10 @@ module Decidim
       []
     end
 
+    config_accessor :home_content_block_menu do
+      []
+    end
+
     # Allows admins to assignate "fake" admins scoped to some admin zones using the
     # same scope editor as :scoped_styles, valid values uses the same convention:
     #   :disabled => false and non available, hidden from admins
@@ -262,6 +286,13 @@ module Decidim
       [:proposals, :reporting_propposals]
     end
 
+    # A URL where to obtain the translations for the FormBuilder component
+    # you can a custom place if you are worried about the CDN geolocation
+    # Download them from https://github.com/kevinchappell/formBuilder-languages
+    config_accessor :form_builder_langs_location do
+      "https://cdn.jsdelivr.net/npm/formbuilder-languages@1.1.0/"
+    end
+
     # Public: Stores an instance of ContentBlockRegistry
     def self.voting_registry
       @voting_registry ||= Decidim::ManifestRegistry.new("decidim_awesome/voting")
@@ -273,13 +304,33 @@ module Decidim
     # pass a single config var or an array of them
     # any non disabled match will return as true
     def self.possible_additional_proposal_sortings
-      @possible_additional_proposal_sortings ||= additional_proposal_sortings.to_a.filter_map do |sort|
+      return [] unless additional_proposal_sortings.is_a?(Array)
+
+      @possible_additional_proposal_sortings ||= additional_proposal_sortings.filter_map do |sort|
         next unless sort.to_sym.in?([:az, :za, :supported_first, :supported_last])
 
         sort.to_s
       end
     end
 
+    # appends to a hash a new value in a specified position so that the hash becomes:
+    # { a: 1, b: 2, c: 3 } => append_hash(hash, :b, :d, 4) => { a: 1, b: 2, d: 4, c: 3 }
+    # if key is not found then it will be inserted at the end
+    def self.hash_append!(hash, after_key, key, value)
+      insert_at = hash.to_a.index(hash.assoc(after_key))
+      insert_at = insert_at.nil? ? hash.size : insert_at + 1
+      hash.replace(hash.to_a.insert(insert_at, [key, value]).to_h)
+    end
+
+    # prepends to a hash a new value in a specified position so that the hash becomes:
+    # { a: 1, b: 2, c: 3 } => prepend_hash(hash, :b, :d, 4) => { a: 1, d: 4, b: 2, c: 3 }
+    # if key is not found then it will be inserted at the beggining
+    def self.hash_prepend!(hash, before_key, key, value)
+      insert_at = hash.to_a.index(hash.assoc(before_key))
+      insert_at = 0 if insert_at.nil?
+      hash.replace(hash.to_a.insert(insert_at, [key, value]).to_h)
+    end
+
     def self.collation_for(locale)
       @collation_for ||= {}
       @collation_for[locale] ||= begin
@@ -289,9 +340,7 @@ module Decidim
       end
     end
 
-    def self.enabled?(config_vars)
-      config_vars = [config_vars] unless config_vars.respond_to?(:any?)
-
+    def self.enabled?(*config_vars)
       config_vars.any? do |item|
         next unless config.has_key?(item.to_sym)
 
@@ -309,8 +358,10 @@ module Decidim
       registered_components << [manifest, block]
     end
 
+    # version 0.11 is compatible only with decidim 0.28
     def self.legacy_version?
-      Decidim.version[0..3] == "0.26"
+      # Decidim.version[0..3] == "0.28"
+      false
     end
   end
 end

data/lib/decidim/decidim_awesome/awesome_helpers.rb

@@ -24,11 +24,11 @@ module Decidim
       end
 
       def javascript_config_vars
-        awesome_config.except(:scoped_styles, :proposal_custom_fields, :scoped_admins).to_json.html_safe
+        awesome_config.except(:scoped_styles, :proposal_custom_fields, :proposal_private_custom_fields, :scoped_admins).to_json.html_safe
       end
 
       def show_public_intergram?
-        return unless awesome_config[:intergram_for_public]
+        return false unless awesome_config[:intergram_for_public]
         return true unless awesome_config[:intergram_for_public_settings][:require_login]
 
         user_signed_in?
@@ -61,6 +61,10 @@ module Decidim
         @awesome_proposal_custom_fields ||= awesome_config_instance.collect_sub_configs_values("proposal_custom_field")
       end
 
+      def awesome_proposal_private_custom_fields
+        @awesome_proposal_private_custom_fields ||= awesome_config_instance.collect_sub_configs_values("proposal_private_custom_field")
+      end
+
       # this will check if the current component has been configured to use a custom voting manifest
       def awesome_voting_manifest_for(component)
         return nil unless component.settings.respond_to? :awesome_voting_manifest

data/lib/decidim/decidim_awesome/checksums.yml

@@ -1,63 +1,65 @@
 decidim-admin:
   /app/views/layouts/decidim/admin/_header.html.erb:
-    decidim-0.25: 1aff077428830b12306d6c42e6b37216
+    decidim-0.28: 25bf272ac5a70eb8a975f4889fa46095
+    decidim-0.28.c4d3889: 6391da1f357f9b260622ddd404a47987
+    decidim-0.28.1: b2ae319d5bcf43954bbe0edb9a4e3ffb
 decidim-core:
+  /app/packs/entrypoints/decidim_editor.js:
+    decidim-0.28: beddd77e3893fd0b7cd2679a7ee6e536
+  /app/packs/src/decidim/editor/index.js:
+    decidim-0.28: 90dfac3acae97202dec083955e2249e4
   /app/validators/etiquette_validator.rb:
-    decidim-0.25: f7a4a652005385a994208f1ab41c4f08
-    decidim-0.26.4: f1f0fdf15be88f695c8359afab80f73f
+    decidim-0.28: e9ad91d824ad48ac2075a088a0d21349
   /app/views/layouts/decidim/_head.html.erb:
-    decidim-0.26: 0927fc81123addec70853c2e7986c538
-    decidim-0.27: c82ac6defe55b6d4f6a54544dbf2ac58
-  /app/packs/src/decidim/editor.js:
-    decidim-0.25: 742698903a30034094c01aecaca6de84
-    decidim-0.26: 651830d87aeeeff39316a787fc70d461
-    decidim-0.26.4: eac4ea47c09762aa2e56300bf7e98f31
-    decidim-0.27.3: a9585960d5979aa3adbf5561010513fe
+    decidim-0.28: e51e400a98821f4ca0fff26ebd4d0741
+    decidim-0.28.1: 8ac1af4e223d9a7a98136760b6194a75
+  /app/views/layouts/decidim/_decidim_javascript.html.erb:
+    decidim-0.28: dc60ed8abf7649611f18804b67b1408d
   /app/presenters/decidim/menu_presenter.rb:
-    decidim-0.25: f3b05daf279f909f8b3b628658dd5810
+    decidim-0.28: 220c8865a43bd8b7b12a7f926f7f4324
   /app/presenters/decidim/menu_item_presenter.rb:
-    decidim-0.25: 860ffb160ec5f8552cc2855a6a47851b
-    decidim-0.26.4: d6d0129d81845c61884bcfd07885e911
-    decidim-0.27: c82bc2ea3c8f792472670d5996613ecf
+    decidim-0.28: 4e4cd366a8a313079ac5fab466bd3679
   /app/helpers/decidim/amendments_helper.rb:
-    decidim-0.25: 63532a04fcf07cf92b789833a9421416
-    decidim-0.26: 636943ccb2e994fe0124dc87e72e49e9
+    decidim-0.28: df28f9321d1bc07757746ed608274e3d
+  /app/presenters/decidim/admin_log/component_presenter.rb:
+    decidim-0.28: 77e80d527727acdf117a0c4517a69a7c
 decidim-proposals:
   /lib/decidim/proposals/proposal_serializer.rb:
-    decidim-0.26: 2d817775f79a19cfcf9cfae8e5b68c5a
+    decidim-0.28: bbd33bdc60defb734b3fb814666bb622
+    decidim-0.28.1: 7bd5cadb1127a4e81bd5f333670351bd
+    decidim-0.28.2: ab146c54850a4486d96cf50211679671
   /lib/decidim/api/proposal_type.rb:
     decidim-0.26: e38e4875e408ec4f658e28725c5a94d4
   /app/forms/decidim/proposals/proposal_wizard_create_step_form.rb:
-    decidim-0.24: db69edd0ba8ffa3965a5c44a6bfaba8d
     decidim-0.27: b495d37088ecebcbe4ac9563bb3498d5
+  /app/forms/decidim/proposals/admin/proposal_form.rb:
+    decidim-0.28: 422632395194b19beed4c7c65f127ff5
   /app/helpers/decidim/proposals/application_helper.rb:
-    decidim-0.26: 216c974bc425393c18b01bfc4eed4f0b
-    decidim-0.26.4: 2e673d2aabe66a80a971d7ff80ebdbb8
-    decidim-0.26.7: ddd9a1f88609c8c7b60c07882d026441
-    decidim-0.27: c0ebeac39ebe4926bf0e5fc585a384d7
-    decidim-0.27.1: a4f902d1c4829a7f7f62299686f8604e
-    decidim-0.27.3: a9c9ed5eedaf7bf80afaf9ff5a89c254
+    decidim-0.28: 89df14045349cc2eaaec78f79f6140b1
+    decidim-0.28.2: 317b0347528e697fa405a792bcfa3db8
   /app/controllers/decidim/proposals/proposal_votes_controller.rb:
-    decidim-0.26: 65ca00fdb4aaf30da37ad75aaf66e70a
-    decidim-0.27: a1d416491752f4c2fb2668b29ceb8e09
-  /app/views/decidim/proposals/collaborative_drafts/_edit_form_fields.html.erb:
-    # this file is not overriden anymore but it needs to be the last version
-    decidim-0.26: 519a0d34a9ffbd8b9c26d9b68ff4e2a3
-    decidim-0.27.3: 949b2163c547742549531320bf5e0de1
-  /app/views/decidim/proposals/collaborative_drafts/show.html.erb:
-    # this file is not overriden anymore but it needs to be the last version
-    decidim-0.26: 519a0d34a9ffbd8b9c26d9b68ff4e2a3
-    decidim-0.27.3: b1ec22d35263a2ac96fe4604c0ceb752
+    decidim-0.28: f983e72c1ee8d31222d537533c762cd2
   /app/views/decidim/proposals/admin/proposals/_form.html.erb:
-    decidim-0.25: 90a04984d4269398b7cd21aa33763a1f
-    decidim-0.27: f60168e432e1d419e5aec5d3d1e53f0e
+    decidim-0.28: 824463b320562c15fdb530bfebbf2f0f
   /app/views/decidim/proposals/proposals/_vote_button.html.erb:
-    decidim-0.27: f7202c37fe042cd816a6f9fd0f9e6807
+    decidim-0.27: 3d087d807238f33b71e6b385db8ffc70
   /app/views/decidim/proposals/proposals/_votes_count.html.erb:
-    decidim-0.27: 33339aae5004361e24c4c5b009cc2888
-  /app/cells/decidim/proposals/proposal_m_cell.rb:
-    decidim-0.26: 21cc09a45efa20dbcda5c943d820c867
-    decidim-0.27: 9df97ded3e6594b65b85fcbf1e5b0644
-    decidim-0.27.4: ce3b30cdddfee547b8fb089c0fddd8a4
-  /app/cells/decidim/proposals/proposal_m/footer.erb:
-    decidim-0.26: 7ade5bbd8412f44f1c4ed913ae1834c6
+    decidim-0.27: 6e663e5c82c27291b63f29f346df8737
+  /app/cells/decidim/proposals/proposal_l_cell.rb:
+    decidim-0.27.4: 5e111ed30bca9475bed8247e5e056747
+  /app/cells/decidim/proposals/proposal_metadata_cell.rb:
+    decidim-0.26: eedfd7f813aedbd819b519e03ae4a680
+  /app/commands/decidim/proposals/create_proposal.rb:
+    decidim-0.28: 95c7bba44dbe477abdfbf450b7eee258
+  /app/commands/decidim/proposals/create_collaborative_draft.rb:
+    decidim-0.28: ab3f937f15c6ed945e776fef34b18abf
+  /app/commands/decidim/proposals/admin/create_proposal.rb:
+    decidim-0.28: aa0c093cb10b3ccfb046edd0018eae1d
+  /app/commands/decidim/proposals/update_proposal.rb:
+    decidim-0.28: 1cc15b946512f4d5a54d1cf5aea8450a
+  /app/commands/decidim/proposals/update_collaborative_draft.rb:
+    decidim-0.28: 7df5266382bd57db72832da391fe7e11
+  /app/commands/decidim/proposals/admin/update_proposal.rb:
+    decidim-0.28: 67b691b6d1ce61cb198592ac25f76f74
+  /app/presenters/decidim/proposals/proposal_presenter.rb:
+    decidim-0.28: 72910541010305f25baf297f4a58497b

data/lib/decidim/decidim_awesome/config.rb

@@ -71,7 +71,7 @@ module Decidim
       def setting_for(var)
         @vars.find_or_initialize_by(
           organization: @organization,
-          var: var
+          var:
         )
       end
 

data/lib/decidim/decidim_awesome/custom_fields.rb

@@ -13,6 +13,14 @@ module Decidim
 
       attr_reader :fields, :xml, :errors, :data
 
+      def empty?
+        @fields.empty?
+      end
+
+      def present?
+        !@fields.empty?
+      end
+
       def apply_xml(xml)
         parse_xml(xml)
         map_fields!
@@ -32,7 +40,7 @@ module Decidim
 
       def parse_xml(xml)
         @xml = xml
-        @data = Nokogiri.XML(xml).xpath("//dl/dd")
+        @data = Nokogiri.XML(@xml).xpath("//dl/dd")
         return if @data.present?
 
         apply_to_first_textarea
@@ -54,7 +62,7 @@ module Decidim
       # Finds the first textarea and applies non-xml compatible content
       # when textarea has not wysiwyg assigned, strips html
       def apply_to_first_textarea
-        # quill editor might leave html traces without any user content
+        # HTML editors might leave html traces without any user content
         # so we won't process it if there is no text (html free) result
         text = Nokogiri.HTML(xml).html? ? Nokogiri.HTML(xml).text.strip : text.strip
         return if text.blank?
@@ -79,12 +87,12 @@ module Decidim
         @fields
       end
 
-      def deep_transform_values!(object, &block)
+      def deep_transform_values!(object, &)
         case object
         when Hash
-          object.transform_values! { |value| deep_transform_values!(value, &block) }
+          object.transform_values! { |value| deep_transform_values!(value, &) }
         when Array
-          object.map! { |e| deep_transform_values!(e, &block) }
+          object.map! { |e| deep_transform_values!(e, &) }
         else
           yield(object)
         end