decidim-debates 0.26.2 → 0.27.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bba1a20bf1be9a3163def8c0453e533ca38ef4ca11ff69c3ac499676574c20ac
-  data.tar.gz: c23359c29608db9ed45ff0b007396615d6207346c55f4f186010b4641fa311a6
+  metadata.gz: 3fab5be1a72275d74438c9474395018e2ec6820ce43d222fe0a252f77f835fd3
+  data.tar.gz: 4762a3d6f218f65c360a25a60c7717d1216972e163d49a5a17bba1b408a1ef30
 SHA512:
-  metadata.gz: c52b2dc948574e885b3302a036b745cc8eea0567943b34808e4b69e3a26921158523a534b969d7e6abbcf3dc960222b09f01400d1c1a4c26d01474b826c8bb6b
-  data.tar.gz: 3a72216f5e580781cd411e6a2dca024ec05e8df483c6150c9b047f4ade729e8e24a00fe4129c4c7198926caaea4b77fff513717974ca635f70875c2e613cb107
+  metadata.gz: 0ab714005a3269dc998591084fe53794840ad1ab3c4b265fda289f87a466fd375714037eb9cda73471e8abdc57a108d90a7085b966f819f461cc581f282fdf24
+  data.tar.gz: ce7ceaea9b4d8b0a81a993b220f02c3207f245a7354692fa1b1eec89e9bb6fb8d9ac9ef412a7fa2f86344606beec5544beccabbdaeb0200af618d8331d97b52f

data/app/commands/decidim/debates/admin/close_debate.rb

@@ -4,7 +4,7 @@ module Decidim
   module Debates
     module Admin
       # A command with all the business logic when an admin closes a debate.
-      class CloseDebate < Rectify::Command
+      class CloseDebate < Decidim::Command
         # Public: Initializes the command.
         #
         # form         - A form object with the params.

data/app/commands/decidim/debates/admin/create_debate.rb

@@ -5,7 +5,7 @@ module Decidim
     module Admin
       # This command is executed when the user creates a Debate from the admin
       # panel.
-      class CreateDebate < Rectify::Command
+      class CreateDebate < Decidim::Command
         def initialize(form)
           @form = form
         end

data/app/commands/decidim/debates/admin/update_debate.rb

@@ -5,7 +5,7 @@ module Decidim
     module Admin
       # This command is executed when the user changes a Debate from the admin
       # panel.
-      class UpdateDebate < Rectify::Command
+      class UpdateDebate < Decidim::Command
         # Initializes a UpdateDebate Command.
         #
         # form - The form from which to get the data.

data/app/commands/decidim/debates/close_debate.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Debates
     # A command with all the business logic when a user updates a debate.
-    class CloseDebate < Rectify::Command
+    class CloseDebate < Decidim::Command
       # Public: Initializes the command.
       #
       # form         - A form object with the params.

data/app/commands/decidim/debates/create_debate.rb

@@ -4,7 +4,7 @@ module Decidim
   module Debates
     # This command is executed when the user creates a Debate from the public
     # views.
-    class CreateDebate < Rectify::Command
+    class CreateDebate < Decidim::Command
       def initialize(form)
         @form = form
       end

data/app/commands/decidim/debates/update_debate.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Debates
     # A command with all the business logic when a user updates a debate.
-    class UpdateDebate < Rectify::Command
+    class UpdateDebate < Decidim::Command
       # Public: Initializes the command.
       #
       # form         - A form object with the params.

data/app/controllers/decidim/debates/admin/debate_closes_controller.rb

@@ -17,7 +17,6 @@ module Decidim
           enforce_permission_to :close, :debate, debate: debate
 
           @form = form(Admin::CloseDebateForm).from_params(params)
-          @form.debate = debate
 
           CloseDebate.call(@form) do
             on(:ok) do |_debate|

data/app/controllers/decidim/debates/debates_controller.rb

@@ -53,7 +53,6 @@ module Decidim
         enforce_permission_to :edit, :debate, debate: debate
 
         @form = form(DebateForm).from_params(params)
-        @form.debate = debate
 
         UpdateDebate.call(@form) do
           on(:ok) do |debate|
@@ -72,7 +71,6 @@ module Decidim
         enforce_permission_to :close, :debate, debate: debate
 
         @form = form(CloseDebateForm).from_params(params)
-        @form.debate = debate
 
         CloseDebate.call(@form) do
           on(:ok) do |debate|
@@ -98,7 +96,7 @@ module Decidim
       end
 
       def debates
-        @debates ||= reorder(search.results)
+        @debates ||= reorder(search.result)
       end
 
       def debate
@@ -109,26 +107,18 @@ module Decidim
         @close_debate_form ||= form(CloseDebateForm).from_model(debate)
       end
 
-      def search_klass
-        DebateSearch
-      end
-
-      def default_search_params
-        {
-          page: params[:page],
-          per_page: 12
-        }
+      def search_collection
+        Debate.where(component: current_component).not_hidden
       end
 
       def default_filter_params
         {
-          search_text: "",
-          origin: %w(official citizens user_group),
+          search_text_cont: "",
+          with_any_origin: %w(official participants user_group),
           activity: "all",
-          category_id: default_filter_category_params,
-          scope_id: default_filter_scope_params,
-          status: "all",
-          state: %w(open closed)
+          with_any_category: default_filter_category_params,
+          with_any_scope: default_filter_scope_params,
+          with_any_state: %w(open closed)
         }
       end
     end

data/app/controllers/decidim/debates/orderable.rb

@@ -24,11 +24,11 @@ module Decidim
         def reorder(debates)
           case order
           when "recent"
-            debates.order("created_at DESC")
+            debates.order(created_at: :desc)
           when "commented"
-            debates.order("comments_count DESC")
+            debates.order(comments_count: :desc)
           when "updated"
-            debates.order("updated_at DESC")
+            debates.order(updated_at: :desc)
           when "random"
             debates.order_randomly(random_seed)
           else

data/app/forms/decidim/debates/admin/close_debate_form.rb

@@ -14,8 +14,6 @@ module Decidim
           validates translated_attribute, length: { minimum: 10, maximum: 10_000 }, if: ->(record) { record.default_locale?(locale) }
         end
 
-        attribute :debate, Debate
-
         validates :debate, presence: true
         validate :user_can_close_debate
 
@@ -23,6 +21,10 @@ module Decidim
           debate&.closed_at || Time.current
         end
 
+        def debate
+          @debate ||= Debate.find_by(id: id)
+        end
+
         private
 
         def user_can_close_debate

data/app/forms/decidim/debates/admin/debate_form.rb

@@ -46,14 +46,14 @@ module Decidim
         #
         # Returns a Decidim::Scope
         def scope
-          @scope ||= @scope_id ? current_component.scopes.find_by(id: @scope_id) : current_component.scope
+          @scope ||= @attributes["scope_id"].value ? current_component.scopes.find_by(id: @attributes["scope_id"].value) : current_component.scope
         end
 
         # Scope identifier
         #
         # Returns the scope identifier related to the meeting
         def scope_id
-          @scope_id || scope&.id
+          super || scope&.id
         end
 
         private

data/app/forms/decidim/debates/close_debate_form.rb

@@ -7,7 +7,6 @@ module Decidim
       mimic :debate
 
       attribute :conclusions, Decidim::Attributes::CleanString
-      attribute :debate, Debate
 
       validates :debate, presence: true
       validates :conclusions, presence: true, length: { minimum: 10, maximum: 10_000 }
@@ -19,7 +18,6 @@ module Decidim
 
       def map_model(debate)
         super
-        self.debate = debate
 
         # Debates can be translated in different languages from the admin but
         # the public form doesn't allow it. When a user closes a debate the
@@ -27,6 +25,10 @@ module Decidim
         self.conclusions = debate.conclusions&.values&.first
       end
 
+      def debate
+        @debate ||= Debate.find_by(id: id)
+      end
+
       private
 
       def user_can_close_debate

data/app/forms/decidim/debates/debate_form.rb

@@ -11,7 +11,6 @@ module Decidim
       attribute :category_id, Integer
       attribute :scope_id, Integer
       attribute :user_group_id, Integer
-      attribute :debate, Debate
 
       validates :title, presence: true
       validates :description, presence: true
@@ -22,8 +21,6 @@ module Decidim
 
       def map_model(debate)
         super
-        self.debate = debate
-
         # Debates can be translated in different languages from the admin but
         # the public form doesn't allow it. When a user creates a debate the
         # user locale is taken as the text locale.
@@ -45,14 +42,18 @@ module Decidim
       #
       # Returns a Decidim::Scope
       def scope
-        @scope ||= @scope_id ? current_component.scopes.find_by(id: @scope_id) : current_component.scope
+        @scope ||= @attributes["scope_id"].value ? current_component.scopes.find_by(id: @attributes["scope_id"].value) : current_component.scope
       end
 
       # Scope identifier
       #
       # Returns the scope identifier related to the debate
       def scope_id
-        @scope_id || scope&.id
+        super || scope&.id
+      end
+
+      def debate
+        @debate ||= Debate.find_by(id: id)
       end
 
       private

data/app/helpers/decidim/debates/application_helper.rb

@@ -35,7 +35,7 @@ module Decidim
       def filter_origin_values
         origin_values = []
         origin_values << TreePoint.new("official", t("decidim.debates.debates.filters.official"))
-        origin_values << TreePoint.new("citizens", t("decidim.debates.debates.filters.citizens"))
+        origin_values << TreePoint.new("participants", t("decidim.debates.debates.filters.participants"))
         origin_values << TreePoint.new("user_group", t("decidim.debates.debates.filters.user_groups")) if current_organization.user_groups_enabled?
 
         TreeNode.new(TreePoint.new("", t("decidim.debates.debates.filters.all")), origin_values)

data/app/models/decidim/debates/debate.rb

@@ -18,13 +18,14 @@ module Decidim
       include Decidim::HasReference
       include Decidim::Traceable
       include Decidim::Loggable
-      include Decidim::DataPortability
+      include Decidim::DownloadYourData
       include Decidim::NewsletterParticipant
       include Decidim::Searchable
       include Decidim::TranslatableResource
       include Decidim::TranslatableAttributes
       include Decidim::Endorsable
       include Decidim::Randomable
+      include Decidim::FilterableResource
 
       belongs_to :last_comment_by, polymorphic: true, foreign_type: "last_comment_by_type", optional: true
       component_manifest_name "debates"
@@ -53,6 +54,7 @@ module Decidim
           }
         )
       }
+      scope_search_multi :with_any_state, [:open, :closed]
 
       def self.log_presenter_class_for(_log)
         Decidim::Debates::AdminLog::DebatePresenter
@@ -141,7 +143,7 @@ module Decidim
       end
 
       def self.export_serializer
-        Decidim::Debates::DataPortabilityDebateSerializer
+        Decidim::Debates::DownloadYourDataDebateSerializer
       end
 
       def self.newsletter_participant_ids(component)
@@ -193,6 +195,18 @@ module Decidim
       end
       # rubocop:enable Rails/SkipsModelValidations
 
+      # Create i18n ransackers for :title and :description.
+      # Create the :search_text ransacker alias for searching from both of these.
+      ransacker_i18n_multi :search_text, [:title, :description]
+
+      def self.ransackable_scopes(_auth_object = nil)
+        [:with_any_state, :with_any_origin, :with_any_category, :with_any_scope]
+      end
+
+      def self.ransack(params = {}, options = {})
+        DebateSearch.new(self, params, options)
+      end
+
       private
 
       def comments_blocked?

data/app/serializers/decidim/debates/{data_portability_debate_serializer.rb → download_your_data_debate_serializer.rb}

@@ -2,8 +2,8 @@
 
 module Decidim
   module Debates
-    class DataPortabilityDebateSerializer < Decidim::Exporters::Serializer
-      # Serializes a Debate for data portability
+    class DownloadYourDataDebateSerializer < Decidim::Exporters::Serializer
+      # Serializes a Debate for download your data
       def serialize
         {
           id: resource.id,

data/app/services/decidim/debates/debate_search.rb

@@ -2,35 +2,24 @@
 
 module Decidim
   module Debates
-    # This class handles search and filtering of debates. Needs a
-    # `current_component` param with a `Decidim::Component` in order to
-    # find the debates.
+    # This service scopes the debate searches with parameters that cannot be
+    # passed from the user interface.
     class DebateSearch < ResourceSearch
-      text_search_fields :title, :description
+      attr_reader :activity
 
-      # Public: Initializes the service.
-      # component     - A Decidim::Component to get the debates from.
-      # page        - The page number to paginate the results.
-      # per_page    - The number of debates to return per page.
-      def initialize(options = {})
-        super(Debate.not_hidden, options)
-      end
+      def build(params)
+        @activity = params[:activity]
 
-      # Handle the activity filter
-      def search_activity
-        case activity
-        when "commented"
-          query.commented_by(user)
-        when "my_debates"
-          query.authored_by(user)
-        else # Assume 'all'
-          query
+        if params[:activity] && user
+          case params[:activity]
+          when "commented"
+            add_scope(:commented_by, user)
+          when "my_debates"
+            add_scope(:authored_by, user)
+          end
         end
-      end
 
-      # Handle the state filter
-      def search_state
-        apply_scopes(%w(open closed), state)
+        super
       end
     end
   end

data/app/views/decidim/debates/debates/_filters.html.erb

@@ -4,7 +4,7 @@
   <div class="filters__section">
     <div class="filters__search">
       <div class="input-group">
-        <%= form.search_field :search_text, label: false, class: "input-group-field", placeholder: t(".search"), title: t(".search"), "aria-label": t(".search"), data: { disable_dynamic_change: true } %>
+        <%= form.search_field :search_text_cont, label: false, class: "input-group-field", placeholder: t(".search"), title: t(".search"), "aria-label": t(".search"), data: { disable_dynamic_change: true } %>
         <div class="input-group-button">
           <button type="submit" class="button" aria-controls="debates">
             <%= icon "magnifying-glass", aria_label: t(".search"), role: "img" %>
@@ -14,17 +14,17 @@
     </div>
   </div>
 
-  <%= form.check_boxes_tree :state, filter_debates_state_values, legend_title: t(".state"), "aria-controls": "debates" %>
+  <%= form.check_boxes_tree :with_any_state, filter_debates_state_values, legend_title: t(".state"), "aria-controls": "debates" %>
 
   <% if current_component.has_subscopes? %>
-    <%= form.check_boxes_tree :scope_id, filter_scopes_values, legend_title: t(".scope"), "aria-controls": "debates" %>
+    <%= form.check_boxes_tree :with_any_scope, filter_scopes_values, legend_title: t(".scope"), "aria-controls": "debates" %>
   <% end %>
 
   <% if current_participatory_space.categories.any? %>
-    <%= form.check_boxes_tree :category_id, filter_categories_values, legend_title: t(".category"), "aria-controls": "debates" %>
+    <%= form.check_boxes_tree :with_any_category, filter_categories_values, legend_title: t(".category"), "aria-controls": "debates" %>
   <% end %>
 
-  <%= form.check_boxes_tree :origin, filter_origin_values, legend_title: t(".origin"), "aria-controls": "debates" %>
+  <%= form.check_boxes_tree :with_any_origin, filter_origin_values, legend_title: t(".origin"), "aria-controls": "debates" %>
 
   <% if current_user %>
     <%= form.collection_radio_buttons :activity, activity_filter_values, :first, :last, { legend_title: t(".activity") }, "aria-controls": "debates" %>

data/config/locales/ar.yml

@@ -1,3 +1,4 @@
+---
 ar:
   activemodel:
     attributes:
@@ -87,10 +88,10 @@ ar:
           all: الكل
           category: الفئة
           category_prompt: اختر تصنيف
-          citizens: المواطنين
           my_debates: مناقشاتي
           official: الرسمية
           origin: الأصل
+          participants: المشاركون
           search: بحث
           user_groups: الفِرَق
         filters_small_view:

data/config/locales/bg.yml

@@ -1,3 +1,4 @@
+---
 bg:
   activemodel:
     attributes:

data/config/locales/ca.yml

@@ -1,3 +1,4 @@
+---
 ca:
   activemodel:
     attributes:
@@ -117,11 +118,11 @@ ca:
           all: Tots
           category: Categoria
           category_prompt: Selecciona una categoria
-          citizens: Ciutadania
           commented: Comentat
           my_debates: Els meus debats
           official: Oficial
           origin: Origen
+          participants: Participants
           scope: Àmbit
           search: Cerca
           state: Estat

data/config/locales/cs.yml

@@ -1,3 +1,4 @@
+---
 cs:
   activemodel:
     attributes:
@@ -121,11 +122,11 @@ cs:
           all: Vše
           category: Kategorie
           category_prompt: Vyberte kategorii
-          citizens: Občané
           commented: Okomentováno
           my_debates: Moje rozpravy
           official: Oficiální
           origin: Původ
+          participants: Účastníci
           scope: Oblast působnosti
           search: Hledat
           state: Stav
@@ -163,7 +164,7 @@ cs:
           groups_count: Skupiny
           last_comment_by: Poslední komentář od
           no_comments_yet: Zatím žádné komentáře
-          open: Otevřít diskusi
+          open: Otevřená diskuse
           participants_count: Účastníci
         update:
           invalid: Při aktualizaci rozpravy došlo k chybě.

data/config/locales/de.yml

@@ -1,3 +1,4 @@
+---
 de:
   activemodel:
     attributes:
@@ -17,6 +18,7 @@ de:
       decidim/debates/close_debate_event: Debatte beendet
       decidim/debates/create_debate_event: Debatte
       decidim/debates/creation_disabled_event: Debatten deaktiviert
+      decidim/debates/creation_enabled_event: Erstellung von Debatten aktiviert
   activerecord:
     models:
       decidim/debates/debate:
@@ -26,6 +28,7 @@ de:
     components:
       debates:
         actions:
+          comment: Kommentar
           create: Erstellen
           endorse: Bestätigen
         name: Debatten
@@ -39,6 +42,7 @@ de:
           step:
             announcement: Ankündigung
             comments_blocked: Kommentare blockiert
+            creation_enabled: Teilnehmer können Debatten erstellen
             endorsements_blocked: Bestätigungen blockiert
             endorsements_enabled: Bestätigungen aktiviert
     debates:
@@ -114,11 +118,11 @@ de:
           all: Alle
           category: Kategorie
           category_prompt: Wählen Sie eine Kategorie
-          citizens: Einzelpersonen
           commented: Kommentiert
           my_debates: Meine Debatten
           official: Offiziell
           origin: Ursprung
+          participants: Teilnehmer
           scope: Bereich
           search: Suche
           state: Status

data/config/locales/el.yml

@@ -1,3 +1,4 @@
+---
 el:
   activemodel:
     attributes:
@@ -78,7 +79,6 @@ el:
           all: Όλα
           category: Κατηγορία
           category_prompt: Επιλέξτε μια κατηγορία
-          citizens: Πολίτες
           official: Επίσημη
           origin: Προέλευση
           search: Αναζήτηση

data/config/locales/en.yml

@@ -118,11 +118,11 @@ en:
           all: All
           category: Category
           category_prompt: Select a category
-          citizens: Citizens
           commented: Commented
           my_debates: My debates
           official: Official
           origin: Origin
+          participants: Participants
           scope: Scope
           search: Search
           state: Status

data/config/locales/es-MX.yml

@@ -1,3 +1,4 @@
+---
 es-MX:
   activemodel:
     attributes:
@@ -117,11 +118,11 @@ es-MX:
           all: Todos
           category: Categoría
           category_prompt: Selecciona una categoría
-          citizens: Ciudadanía
           commented: Comentado
           my_debates: Mis debates
           official: Oficial
           origin: Origen
+          participants: Participantes
           scope: Ámbito
           search: Buscar
           state: Estado

data/config/locales/es-PY.yml

@@ -1,3 +1,4 @@
+---
 es-PY:
   activemodel:
     attributes:
@@ -113,11 +114,11 @@ es-PY:
           all: Todos
           category: Categoría
           category_prompt: Selecciona una categoría
-          citizens: Ciudadanía
           commented: Comentado
           my_debates: Mis debates
           official: Oficial
           origin: Origen
+          participants: Participantes
           scope: Ámbito
           search: Buscar
           state: Estado

data/config/locales/es.yml

@@ -1,3 +1,4 @@
+---
 es:
   activemodel:
     attributes:
@@ -117,11 +118,11 @@ es:
           all: Todos
           category: Categoría
           category_prompt: Selecciona una categoría
-          citizens: Ciudadanía
           commented: Comentado
           my_debates: Mis debates
           official: Oficial
           origin: Origen
+          participants: Participantes
           scope: Ámbito
           search: Buscar
           state: Estado

data/config/locales/eu.yml

@@ -1,3 +1,4 @@
+---
 eu:
   activemodel:
     attributes:
@@ -115,7 +116,6 @@ eu:
           all: guztiak
           category: Kategoria
           category_prompt: Aukeratu kategoria bat
-          citizens: Hiritarrak
           commented: Iruzkina eginda
           my_debates: Nire eztabaidak
           official: Ofiziala

data/config/locales/fi-plain.yml

@@ -1,3 +1,4 @@
+---
 fi-pl:
   activemodel:
     attributes:
@@ -117,11 +118,11 @@ fi-pl:
           all: Kaikki
           category: Aihepiiri
           category_prompt: Valitse aihepiiri
-          citizens: Kansalaiset
           commented: Kommentoitu
           my_debates: Omat keskustelut
           official: Virallinen
           origin: Alkuperä
+          participants: Osallistujat
           scope: Teema
           search: Hae
           state: Tila

data/config/locales/fi.yml

@@ -1,3 +1,4 @@
+---
 fi:
   activemodel:
     attributes:
@@ -117,11 +118,11 @@ fi:
           all: Kaikki
           category: Aihepiiri
           category_prompt: Valitse aihepiiri
-          citizens: Kansalaiset
           commented: Kommentoitu
           my_debates: Omat keskustelut
           official: Virallinen
           origin: Alkuperä
+          participants: Osallistujat
           scope: Teema
           search: Hae
           state: Tila