decidim-core 0.31.2 → 0.31.4

data/lib/decidim/content_renderers/blob_renderer.rb

@@ -18,8 +18,8 @@ module Decidim
     #
     # @see BaseRenderer Examples of how to use a content renderer
     class BlobRenderer < BaseRenderer
-      # Matches a global id representing a Decidim::User
-      GLOBAL_ID_REGEX = %r{(gid://[\w-]+/ActiveStorage::Blob/\d+)(/([\w=-]+))?}
+      # Matches a global id representing an ActiveStorage::Blob (optionally with a variant key)
+      GLOBAL_ID_REGEX = %r{(gid://[\w-]+/ActiveStorage::Blob/\d+)(/([\w=-]+))?(?:[^\s"'<>]*)}
 
       # Replaces found Global IDs matching an existing blob with a URL to
       # that blob. The Global IDs representing an invalid ActiveStorage::Blob

data/lib/decidim/core/test/shared_examples/participatory_space_members_shared_examples.rb

@@ -0,0 +1,121 @@
+# frozen_string_literal: true
+
+shared_examples "participatory space members" do
+  let(:blocks_manifests) { [] }
+  let(:organization) { create(:organization) }
+  let(:user) { create(:user, organization: participatory_space.organization) }
+  let(:unpublished_user) { create(:user, organization: participatory_space.organization) }
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  context "when there are no members and directly accessing from URL" do
+    it_behaves_like "a 404 page" do
+      let(:target_path) { members_path }
+    end
+  end
+
+  context "when there are no members and accessing from the space homepage" do
+    context "and the main data content block is disabled" do
+      it "the menu nav is not shown" do
+        visit participatory_space_homepage_path
+
+        expect(page).to have_no_css(".participatory-space__nav-container")
+      end
+    end
+
+    context "and the main data content block is enabled" do
+      let(:blocks_manifests) { ["main_data"] }
+
+      it "the menu link is not shown" do
+        visit participatory_space_homepage_path
+
+        expect(page).to have_no_content("Members")
+      end
+    end
+  end
+
+  context "when the participatory space does not exist" do
+    it_behaves_like "a 404 page" do
+      let(:target_path) { unexisting_participatory_space_members_path }
+    end
+  end
+
+  context "when there are some members and all are unpublished" do
+    before do
+      create(:member, user:, participatory_space:, published: false)
+    end
+
+    context "and directly accessing from URL" do
+      it_behaves_like "a 404 page" do
+        let(:target_path) { members_path }
+      end
+    end
+
+    context "and accessing from the homepage" do
+      context "and the main data content block is disabled" do
+        it "the menu nav is not shown" do
+          visit participatory_space_homepage_path
+
+          expect(page).to have_no_css(".participatory-space__nav-container")
+        end
+      end
+
+      context "and the main data content block is enabled" do
+        let(:blocks_manifests) { ["main_data"] }
+
+        it "the menu link is not shown" do
+          visit participatory_space_homepage_path
+
+          expect(page).to have_no_content("Members")
+        end
+      end
+    end
+  end
+
+  context "when there are some published members" do
+    let!(:member) { create(:member, user:, participatory_space:, published: true) }
+    let!(:unpublished_member) { create(:member, user: unpublished_user, participatory_space:, published: false) }
+
+    before do
+      visit members_path
+    end
+
+    context "and accessing from the space homepage" do
+      context "and the main data content block is disabled" do
+        it "the menu nav is not shown" do
+          visit participatory_space_homepage_path
+
+          expect(page).to have_no_css(".participatory-space__nav-container")
+        end
+      end
+
+      context "and the main data content block is enabled" do
+        let(:blocks_manifests) { ["main_data"] }
+
+        it "the menu link is shown" do
+          visit participatory_space_homepage_path
+
+          within ".participatory-space__nav-container" do
+            expect(page).to have_content("Members")
+            click_on "Members"
+          end
+
+          expect(page).to have_current_path members_path
+        end
+      end
+
+      it "lists all the members" do
+        within ".layout-main__section" do
+          expect(page).to have_css(".profile__user", count: 1)
+          expect(page).to have_no_content(Decidim::ParticipatorySpace::MemberPresenter.new(unpublished_member).name)
+        end
+
+        click_on(member.name)
+
+        expect(page).to have_content("Profile")
+      end
+    end
+  end
+end

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.31.2"
+      "0.31.4"
     end
   end
 end

data/lib/decidim/form_builder.rb

@@ -45,14 +45,6 @@ module Decidim
     end
     # rubocop:enable Metrics/ParameterLists
 
-    def create_language_selector(locales, tabs_id, name)
-      if locales.count > 4
-        language_selector_select(locales, tabs_id, name)
-      else
-        language_tabs(locales, tabs_id, name)
-      end
-    end
-
     # Public: Generates a form field for each locale.
     #
     # type - The form field's type, like `text_area` or `text_field`
@@ -65,23 +57,11 @@ module Decidim
 
       tabs_id = sanitize_tabs_selector(options[:tabs_id] || "#{object_name}-#{name}-tabs")
 
-      label_tabs = content_tag(:div, class: "label--tabs") do
-        field_label = label_i18n(name, options[:label] || label_for(name), required: options[:required])
+      error_on_locale = locales.find { |locale| error?(name_with_locale(name, locale)) }
 
-        language_selector = "".html_safe
-        language_selector = create_language_selector(locales, tabs_id, name) if options[:label] != false
+      label_tabs = translated_labels(name, options, tabs_id, error_on_locale)
 
-        safe_join [field_label, language_selector]
-      end
-
-      tabs_content = content_tag(:div, class: "tabs-content", data: { tabs_content: tabs_id }) do
-        locales.each_with_index.inject("".html_safe) do |string, (locale, index)|
-          tab_content_id = "#{tabs_id}-#{name}-panel-#{index}"
-          string + content_tag(:div, class: tab_element_class_for("panel", index), id: tab_content_id, "aria-hidden": tab_attr_aria_hidden_for(index)) do
-            send(type, name_with_locale(name, locale), options.merge(label: false))
-          end
-        end
-      end
+      tabs_content = translated_tabs(type, name, options, tabs_id, error_on_locale)
 
       safe_join [label_tabs, tabs_content]
     end
@@ -452,6 +432,44 @@ module Decidim
 
     private
 
+    def translated_tabs(type, name, options, tabs_id, error_on_locale = nil)
+      content_tag(:div, class: "tabs-content", data: { tabs_content: tabs_id }) do
+        locales.each_with_index.inject("".html_safe) do |string, (locale, index)|
+          tab_content_id = sanitize_tabs_selector "#{tabs_id}-#{name}-panel-#{index}"
+
+          aria_hidden = (error_on_locale.present? ? !locale.eql?(error_on_locale) : index.positive?).to_s
+          css_class = if error_on_locale.present?
+                        tab_element_class_for("panel", locale.eql?(error_on_locale) ? 0 : 1)
+                      else
+                        tab_element_class_for("panel", index)
+                      end
+
+          string + content_tag(:div, class: css_class, id: tab_content_id, "aria-hidden": aria_hidden) do
+            send(type, name_with_locale(name, locale), options.merge(label: false))
+          end
+        end
+      end
+    end
+
+    def create_language_selector(locales, tabs_id, name, error_on_locale = nil)
+      if locales.count > 4
+        language_selector_select(locales, tabs_id, name, error_on_locale)
+      else
+        language_tabs(locales, tabs_id, name, error_on_locale)
+      end
+    end
+
+    def translated_labels(name, options, tabs_id, error_on_locale = nil)
+      content_tag(:div, class: "label--tabs") do
+        field_label = label_i18n(name, options[:label] || label_for(name), required: options[:required])
+
+        language_selector = "".html_safe
+        language_selector = create_language_selector(locales, tabs_id, name, error_on_locale) if options[:label] != false
+
+        safe_join [field_label, language_selector]
+      end
+    end
+
     def editor_hidden_options(name, options)
       hidden_options = extract_validations(name, options).merge(options)
       if hidden_options[:minlength] || hidden_options[:maxlength]
@@ -682,9 +700,7 @@ module Decidim
     end
 
     def tab_attr_aria_hidden_for(index)
-      return "false" if index.zero?
-
-      "true"
+      index.positive?.to_s
     end
 
     def locales
@@ -799,29 +815,35 @@ module Decidim
                   class: "columns")
     end
 
-    def language_selector_select(locales, tabs_id, name)
+    # i18n-tasks-use t('locale.name_with_error')
+    # i18n-tasks-use t('locale.name')
+    def language_selector_select(locales, tabs_id, name, error_on_locale = nil)
       content_tag(:div) do
         content_tag(:select, id: tabs_id, class: "language-change", data: { controller: "language-change" }) do
           locales.each_with_index.inject("".html_safe) do |string, (locale, index)|
-            title = if error?(name_with_locale(name, locale))
-                      I18n.with_locale(locale) { I18n.t("name_with_error", scope: "locale") }
-                    else
-                      I18n.with_locale(locale) { I18n.t("name", scope: "locale") }
-                    end
+            title = locale.eql?(error_on_locale) ? "name_with_error" : "name"
+            title = I18n.with_locale(locale) { I18n.t(title, scope: "locale") }
             tab_content_id = sanitize_tabs_selector "#{tabs_id}-#{name}-panel-#{index}"
-            string + content_tag(:option, title, value: "##{tab_content_id}")
+            string + content_tag(:option, title, value: "##{tab_content_id}", selected: locale.eql?(error_on_locale))
           end
         end
       end
     end
 
-    def language_tabs(locales, tabs_id, name)
+    def language_tabs(locales, tabs_id, name, error_on_locale = nil)
       content_tag(:ul, class: "tabs tabs--lang", id: tabs_id, data: { tabs: true }) do
         locales.each_with_index.inject("".html_safe) do |string, (locale, index)|
-          string + content_tag(:li, class: tab_element_class_for("title", index)) do
+          display = if error_on_locale.nil?
+                      index
+                    else
+                      locale.eql?(error_on_locale) ? 0 : 1
+                    end
+
+          css_class = tab_element_class_for("title", display)
+          string + content_tag(:li, class: css_class) do
             title = I18n.with_locale(locale) { I18n.t("name", scope: "locale") }
             element_class = nil
-            element_class = "is-tab-error" if error?(name_with_locale(name, locale))
+            element_class = "is-tab-error" if locale.eql?(error_on_locale)
             tab_content_id = sanitize_tabs_selector "#{tabs_id}-#{name}-panel-#{index}"
             content_tag(:a, title, href: "##{tab_content_id}", class: element_class)
           end

data/lib/decidim/maintenance/taxonomy_importer.rb

@@ -85,7 +85,7 @@ module Decidim
           component = GlobalID::Locator.locate(component_id)
           if component
             begin
-              component.update!(settings: { taxonomy_filters: [filter.id.to_s] })
+              component.update!(settings: component.settings.to_h.merge(taxonomy_filters: [filter.id.to_s]))
               result[:components_assigned][filter.internal_name[organization.default_locale]] ||= []
               result[:components_assigned][filter.internal_name[organization.default_locale]] << component_id
             rescue ActiveRecord::RecordInvalid

data/lib/decidim/participatory_space_user.rb

@@ -11,7 +11,7 @@ module Decidim
     included do
       validate :user_and_space_same_organization
 
-      belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User", optional: true
+      belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User"
 
       ransacker :name do
         Arel.sql(%{("decidim_users"."name")::text})

data/lib/decidim/searchable.rb

@@ -101,7 +101,7 @@ module Decidim
 
       # Public: after_update callback to update index information of the model.
       #
-      def try_update_index_for_search_resource
+      def try_update_index_for_search_resource(current_depth = 0)
         return unless self.class.searchable_resource?(self)
 
         org = self.class.search_resource_fields_mapper.retrieve_organization(self)
@@ -124,13 +124,13 @@ module Decidim
           searchables_in_org.destroy_all
         end
 
-        find_and_update_descendants
+        find_and_update_descendants(current_depth)
       end
 
       private
 
-      def find_and_update_descendants
-        Decidim::FindAndUpdateDescendantsJob.perform_later(self)
+      def find_and_update_descendants(current_depth = 0)
+        Decidim::FindAndUpdateDescendantsJob.perform_later(self, current_depth)
       end
 
       def contents_to_searchable_resource_attributes(fields, locale)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-core
 version: !ruby/object:Gem::Version
-  version: 0.31.2
+  version: 0.31.4
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-26 00:00:00.000000000 Z
+date: 2026-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -828,28 +828,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.2
+        version: 0.31.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.2
+        version: 0.31.4
 - !ruby/object:Gem::Dependency
   name: decidim-dev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.2
+        version: 0.31.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.31.2
+        version: 0.31.4
 description: Adds core features so other engines can hook into the framework.
 email:
 - josepjaume@gmail.com
@@ -1368,6 +1368,7 @@ files:
 - app/helpers/decidim/layout_helper.rb
 - app/helpers/decidim/likeable_helper.rb
 - app/helpers/decidim/localized_locales_helper.rb
+- app/helpers/decidim/mailer_helper.rb
 - app/helpers/decidim/map_helper.rb
 - app/helpers/decidim/markup_helper.rb
 - app/helpers/decidim/menu_helper.rb
@@ -1570,12 +1571,15 @@ files:
 - app/packs/images/decidim/vendor/social-share-button/x.svg
 - app/packs/images/decidim/vendor/social-share-button/xing.svg
 - app/packs/src/decidim/a11y.js
+- app/packs/src/decidim/a11y.test.js
 - app/packs/src/decidim/append_redirect_url_to_modals.js
 - app/packs/src/decidim/attachments/file_or_link_tabs.js
 - app/packs/src/decidim/attachments/index.js
 - app/packs/src/decidim/callout.js
 - app/packs/src/decidim/confirm.js
+- app/packs/src/decidim/confirm.test.js
 - app/packs/src/decidim/controllers/.keep
+- app/packs/src/decidim/controllers/accordion/accordion.test.js
 - app/packs/src/decidim/controllers/accordion/controller.js
 - app/packs/src/decidim/controllers/account_form/account_form.test.js
 - app/packs/src/decidim/controllers/account_form/controller.js
@@ -1586,6 +1590,7 @@ files:
 - app/packs/src/decidim/controllers/delete_account_form/controller.js
 - app/packs/src/decidim/controllers/delete_account_form/delete_account_form.test.js
 - app/packs/src/decidim/controllers/dropdown/controller.js
+- app/packs/src/decidim/controllers/dropdown/dropdown.test.js
 - app/packs/src/decidim/controllers/editor/controller.js
 - app/packs/src/decidim/controllers/emoji/controller.js
 - app/packs/src/decidim/controllers/emoji/emoji.js
@@ -1632,6 +1637,7 @@ files:
 - app/packs/src/decidim/datepicker/generate_datepicker.js
 - app/packs/src/decidim/datepicker/generate_timepicker.js
 - app/packs/src/decidim/datepicker/test/date.test.js
+- app/packs/src/decidim/datepicker/test/datepicker_functions_adjust_picker_position.test.js
 - app/packs/src/decidim/datepicker/test/time.test.js
 - app/packs/src/decidim/decidim_application.js
 - app/packs/src/decidim/direct_uploads/upload_field.js
@@ -1667,6 +1673,7 @@ files:
 - app/packs/src/decidim/editor/test/extensions/emoji.test.js
 - app/packs/src/decidim/editor/test/extensions/heading.test.js
 - app/packs/src/decidim/editor/test/extensions/image.test.js
+- app/packs/src/decidim/editor/test/extensions/image_links.test.js
 - app/packs/src/decidim/editor/test/extensions/indent.test.js
 - app/packs/src/decidim/editor/test/extensions/link.test.js
 - app/packs/src/decidim/editor/test/extensions/mention.test.js
@@ -2836,6 +2843,7 @@ files:
 - lib/decidim/core/test/shared_examples/paginated_resource_examples.rb
 - lib/decidim/core/test/shared_examples/participatory_space_dropdown_metadata_cell_examples.rb
 - lib/decidim/core/test/shared_examples/participatory_space_members_page_examples.rb
+- lib/decidim/core/test/shared_examples/participatory_space_members_shared_examples.rb
 - lib/decidim/core/test/shared_examples/participatory_space_search_examples.rb
 - lib/decidim/core/test/shared_examples/permissions.rb
 - lib/decidim/core/test/shared_examples/preview_with_share_token_examples.rb