decidim-core 0.30.1 → 0.30.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 763791440d8acd9bfdb66f0afe4d1a738f362815fd237b20b703a6fdc89edfb8
-  data.tar.gz: e6ff16714f702a13b60bee8d4bce8fe03978be54bbeea60c779bb5aaf735661f
+  metadata.gz: df5ddb6f2f1e3c2557f89a0a2b9bab41c3108ad0ce0e728bfb317502cc6aa1a9
+  data.tar.gz: ed7e8f76a6f52fd5040a7bfbb462276d891406a13198df8571d6e154fb504a2f
 SHA512:
-  metadata.gz: 6ca3eaa4281c6b5f676f1df20466d18f8cd1893a26645f5bdd1f00ed9efe413849250801ae49d3e8572a7ca66fe24c0fe09935fb972719b67083df9ff13b4143
-  data.tar.gz: '068568c77bcf227bb7ef783606a63e858d59992001cc2e36d88c97212bf89fac3acefde0568f3557b4af7aa518326db6f5f10e5188d2195211a1a2b356228789'
+  metadata.gz: e3ee0aa2b315e4038a9737c46b8453b075d4d058569d060b777c530a4cb62b71edd37f99bddecdf50fc810e7d9995a89729c60b10cbd10363b6c14d217b069d4
+  data.tar.gz: 7f2b0baa65e1c613ee50d8ff74c4d1bb0a38c2224d51bfa76b34da5a44ec2024fd0e4bcba51a6664d283786ce62f0a4dbd05f4125011b8136750599106e6369d

data/app/cells/decidim/activity/show.erb

@@ -1,19 +1,19 @@
 <div class="activity" data-activity>
-  <div class="activity__time">
+  <p class="activity__time">
     <%= created_at %>
-  </div>
+  </p>
   <div class="activity__content">
-    <span>
+    <div>
       <% if title.present? %>
-        <span>
+        <p>
           <%= title_icon %>
           <%= title %>
-        </span>
+        </p>
       <% end %>
       <a href="<%= resource_link_path %>">
         <%= html_truncate decidim_sanitize(resource_link_text, strip_tags: true), length: 80 %>
       </a>
-    </span>
+    </div>
     <% unless hide_participatory_space? %>
       <span>
         <%= participatory_space_link %>

data/app/cells/decidim/author/badge.erb

@@ -0,0 +1,6 @@
+<% if show_badge? %>
+  <span class="author__badge">
+    <%= icon "star-s-fill" %>
+    <span class="sr-only"><%= officialization_text %></span>
+  </span>
+<% end %>

data/app/cells/decidim/author/show.erb

@@ -6,7 +6,10 @@
       <%= render :avatar %>
 
       <span>
-        <%= render :name %>
+        <span class="flex gap-2">
+          <%= render :name %>
+          <%= render :badge %>
+        </span>
 
         <% context_actions.each do |action| %>
           <%= render action %>
@@ -17,6 +20,7 @@
     <% else %>
       <%= render :avatar %>
       <%= render :name %>
+      <%= render :badge %>
     <% end %>
   <% end %>
 

data/app/cells/decidim/author_cell.rb

@@ -186,5 +186,15 @@ module Decidim
 
       model.has_tooltip?
     end
+
+    def show_badge?
+      return false unless model.respond_to? :officialized?
+
+      model.officialized?
+    end
+
+    def officialization_text
+      translated_attribute(model.officialized_as).presence || t("decidim.profiles.show.officialized")
+    end
   end
 end

data/app/cells/decidim/content_blocks/participatory_space_main_data/title.erb

@@ -11,11 +11,11 @@
   <div class="content-block__description editor-content" <%= "data-component='accordion'" if should_truncate %>>
     <% if should_truncate %>
       <% seed = SecureRandom.hex(4) %>
-      <div id="panel-view-more-<%= seed %>" aria-hidden="true">
+      <div id="panel-view-more-<%= seed %>" aria-hidden="true" inert>
         <%= description_text %>
       </div>
 
-      <button class="button button__sm button__text-secondary mt-2" data-controls="panel-view-more-<%= seed %>" aria-expanded="false">
+      <button class="button button__sm button__text-secondary mt-2" data-controls="panel-view-more-<%= seed %>" aria-expanded="false" onclick="document.querySelector('div[id^=panel-view-more]').toggleAttribute('inert')">
         <span>
           <%= t("view_more", scope: "layouts.decidim.announcements") %>
         </span>
@@ -30,3 +30,12 @@
     <% end %>
   </div>
 <% end %>
+<script>
+  const button = document.querySelector('button[data-controls^="panel-view-more"]')
+  button.addEventListener('keydown', function(e){
+    // press space or enter
+    if (e.keyCode === 32 || e.keyCode === 13){
+      document.querySelector('div[id^=panel-view-more]').toggleAttribute('inert')
+    }
+  })
+</script>

data/app/cells/decidim/footer_topics/show.erb

@@ -1,5 +1,5 @@
-<nav role="navigation" aria-label="Help">
-  <h2 class="h4 mb-4">Help</h2>
+<nav role="navigation" aria-label="<%= t("layouts.decidim.footer.help") %>">
+  <h2 class="h4 mb-4"><%= t("layouts.decidim.footer.help") %></h2>
   <ul class="space-y-4 break-inside-avoid">
     <% topics.each do |topic| %>
       <%= topic_item(topic, class: "font-semibold underline") %>

data/app/cells/decidim/group_admins/show.erb

@@ -21,7 +21,9 @@
       <%= link_to(
         decidim.demote_group_manage_user_path(model.nickname, membership),
         method: :post,
-        data: { confirm: t("decidim.group_admins.actions.are_you_sure") },
+        data: { confirm: t("decidim.group_admins.actions.confirm_remove_from_admin"),
+                confirm_title: t("decidim.group_admins.actions.confirm_modal.title_remove"),
+                confirm_button: t("decidim.group_admins.actions.confirm_modal.ok_remove") },
         class: "button button__sm button__transparent-secondary"
       ) do %>
         <span><%= t("decidim.group_admins.actions.demote_admin") %></span>

data/app/cells/decidim/group_members/show.erb

@@ -24,14 +24,18 @@
         t("decidim.group_members.actions.promote_to_admin"),
         decidim.promote_group_manage_user_path(model.nickname, membership),
         method: :post,
-        data: { confirm: t("decidim.group_members.actions.are_you_sure") },
+        data: { confirm: t("decidim.group_members.actions.confirm_promote_to_admin"),
+                confirm_title: t("decidim.group_admins.actions.confirm_modal.title_add"),
+                confirm_button: t("decidim.group_admins.actions.confirm_modal.ok_add") },
         class: "button button__sm button__transparent-secondary"
       ) %>
 
       <%= link_to(
         decidim.group_manage_user_path(model.nickname, membership),
         method: :delete,
-        data: { confirm: t("decidim.group_members.actions.are_you_sure") },
+        data: { confirm: t("decidim.group_members.actions.confirm_remove_from_group"),
+                confirm_title: t("decidim.group_members.actions.confirm_modal.title_remove"),
+                confirm_button: t("decidim.group_members.actions.confirm_modal.ok_remove") },
         class: "button button__sm button__transparent-secondary"
       ) do %>
         <span><%= t("decidim.group_members.actions.remove_from_group") %></span>

data/app/cells/decidim/images_panel/show.erb

@@ -1,7 +1,10 @@
 <div class="grid grid-cols-1 md:grid-cols-4 gap-6">
-  <% photos.each_with_index do |photo, index| %>
+  <% photos.each_with_index do |photo| %>
     <%= link_to photo.big_url, target: "_blank", rel: "noopener", class: "overflow-hidden rounded aspect-video" do %>
-      <%= image_tag photo.thumbnail_url, class:"w-full h-full object-cover", alt: strip_tags(translated_attribute(photo.title)) %>
+      <%= image_tag photo.thumbnail_url,
+                    class: "w-full h-full object-cover",
+                    role: "presentation",
+                    "data-filename": strip_tags(translated_attribute(photo.title)) %>
     <% end %>
   <% end %>
 </div>

data/app/cells/decidim/profile/avatar.erb

@@ -2,6 +2,4 @@
   <div class="profile__avatar">
     <%= image_tag avatar_url, alt: t("decidim.author.avatar", name: decidim_sanitize(presented_profile.name)) %>
   </div>
-
-  <%= render :badge if show_badge? %>
 </div>

data/app/cells/decidim/profile/badge.erb

@@ -1,4 +1,4 @@
-<div class="profile__avatar-badge">
+<span class="profile__details-badge">
   <%= icon "star-s-fill" %>
-  <span class="sr-only"><%= officialization_text %></span>
-</div>
+  <%= officialization_text %>
+</span>

data/app/cells/decidim/profile/details.erb

@@ -1,7 +1,8 @@
 <div class="profile__details">
-  <h1 class="h3">
+  <h1 class="h3 flex gap-2">
     <%= presented_profile.name %>
     <span class="sr-only"><%= tab_items.find { |tab_item| is_active_link?(tab_item[:path]) }&.dig(:text) %> (<%= presented_profile.name %>)</span>
+    <%= render :badge if show_badge? %>
   </h1>
   <div class="profile__details-data">
     <% details_items.each do |detail| %>

data/app/cells/decidim/report_button/flag_modal.erb

@@ -6,16 +6,18 @@
       <div>
         <div class="form__wrapper flag-modal__form">
           <p id="dialog-desc-<%= modal_id %>" class="flag-modal__form-description"><%= t("decidim.shared.flag_modal.description") %></p>
-          <p class="flag-modal__form-reason"><%= t("decidim.shared.flag_modal.reason") %>:</p>
-          <%= f.collection_radio_buttons :reason, [
-            [:spam, t("decidim.shared.flag_modal.spam")],
-            [:offensive, t("decidim.shared.flag_modal.offensive")],
-            [:does_not_belong, t("decidim.shared.flag_modal.does_not_belong", organization_name: current_organization_name)]
-          ], :first, :last do |builder|
-            builder.label(for: nil, class: "form__wrapper-checkbox-label") { builder.radio_button(id: nil) + builder.text }
-          end %>
+          <fieldset class="mt-6">
+            <legend class="flag-modal__form-reason"><%= t("decidim.shared.flag_modal.reason") %>:</legend>
+            <%= f.collection_radio_buttons :reason, [
+              [:spam, t("decidim.shared.flag_modal.spam")],
+              [:offensive, t("decidim.shared.flag_modal.offensive")],
+              [:does_not_belong, t("decidim.shared.flag_modal.does_not_belong", organization_name: current_organization_name)]
+            ], :first, :last do |builder|
+              builder.label(for: "#{builder.value.to_s}-#{modal_id}", class: "form__wrapper-checkbox-label") { builder.radio_button(id: "#{builder.value.to_s}-#{modal_id}") + builder.text }
+            end %>
+          </fieldset>
 
-          <%= f.text_area :details, rows: 4, label_options: { class: "flag-modal__form-textarea-label", for: nil }, id: nil %>
+          <%= f.text_area :details, rows: 4, label_options: { class: "flag-modal__form-textarea-label", for: "additional-comments-#{modal_id}" }, id: "additional-comments-#{modal_id}" %>
 
           <% if frontend_administrable? %>
             <%= f.check_box :hide,

data/app/cells/decidim/report_user_button/flag_modal.erb

@@ -6,16 +6,17 @@
       <div>
         <div class="form__wrapper flag-modal__form">
           <p class="flag-modal__form-description"><%= t("decidim.shared.flag_user_modal.description") %></p>
-          <p class="flag-modal__form-reason"><%= t("decidim.shared.flag_modal.reason") %>:</p>
-          <%= f.collection_radio_buttons :reason, [
-            [:spam, t("decidim.shared.flag_user_modal.spam")],
-            [:offensive, t("decidim.shared.flag_user_modal.offensive")],
-            [:does_not_belong, t("decidim.shared.flag_user_modal.does_not_belong", organization_name: current_organization_name)]
-          ], :first, :last do |builder|
-            builder.label(for: nil, class: "form__wrapper-checkbox-label") { builder.radio_button(id: nil) + builder.text }
-          end %>
-
-          <%= f.text_area :details, rows: 4, label_options: { class: "flag-modal__form-textarea-label", for: nil }, id: nil %>
+          <fieldset class="mt-6">
+            <legend class="flag-modal__form-reason"><%= t("decidim.shared.flag_modal.reason") %>:</legend>
+            <%= f.collection_radio_buttons :reason, [
+              [:spam, t("decidim.shared.flag_user_modal.spam")],
+              [:offensive, t("decidim.shared.flag_user_modal.offensive")],
+              [:does_not_belong, t("decidim.shared.flag_user_modal.does_not_belong", organization_name: current_organization_name)]
+            ], :first, :last do |builder|
+              builder.label(for: "#{builder.value.to_s}-#{modal_id}", class: "form__wrapper-checkbox-label") { builder.radio_button(id: "#{builder.value.to_s}-#{modal_id}") + builder.text }
+            end %>
+          </fieldset>
+          <%= f.text_area :details, rows: 4, label_options: { class: "flag-modal__form-textarea-label", for: "additional-comments-#{modal_id}" }, id: "additional-comments-#{modal_id}" %>
 
           <% if frontend_administrable? %>
             <%= f.check_box :block,

data/app/cells/decidim/upload_modal/files.erb

@@ -25,19 +25,19 @@
 
         <div class="attachment-details" data-attachment-id="<%= attachment.id %>" data-title="<%= title_for(attachment) %>" data-filename="<%= file_name_for(attachment) %>" data-state="uploaded">
           <% if file_attachment_path(attachment) && blob(attachment).image? %>
-            <div><%= image_tag(file_attachment_path(attachment), alt: title_for(attachment) || file_name_for(attachment)) %></div>
+            <div><%= image_tag(file_attachment_path(attachment), alt: "") %></div>
           <% elsif uploader_default_image_path(attribute).present? %>
             <div><%= image_tag uploader_default_image_path(attribute) %></div>
           <% end %>
 
           <% if has_title? %>
-            <span><%= title_for(attachment) %> (<%= truncated_file_name_for(attachment) %>)</span>
+            <span><%= title_for(attachment) %></span>
             <%= form.hidden_field attribute, multiple: true, value: attachment.id, id: attachment.id %>
           <% else %>
             <% if blob(attachment).image? %>
-              <span><%= truncated_file_name_for(attachment, 15) %></span>
+              <span><%= title_for(attachment) %></span>
             <% else %>
-              <%= link_to truncated_file_name_for(attachment), file_attachment_path(attachment) %>
+              <%= link_to title_for(attachment), file_attachment_path(attachment), class: "w-full break-all mb-2" %>
             <% end %>
           <% end %>
         </div>

data/app/cells/decidim/upload_modal_cell.rb

@@ -132,9 +132,11 @@ module Decidim
     end
 
     def title_for(attachment)
-      return unless has_title?
-
-      decidim_html_escape(decidim_sanitize(translated_attribute(attachment.title)))
+      if has_title?
+        decidim_html_escape(decidim_sanitize(translated_attribute(attachment.title)))
+      else
+        decidim_html_escape(decidim_sanitize(determine_filename(attachment)))
+      end
     end
 
     def truncated_file_name_for(attachment, max_length = 31)

data/app/cells/decidim/user_activity_cell.rb

@@ -11,7 +11,12 @@ module Decidim
     end
 
     def activities
-      context[:activities]
+      resource_ids_to_filter = context[:activities].select { |log| log[:action] == "delete" && log[:resource_type] == "Decidim::Comments::Comment" }.map(&:resource_id)
+      if resource_ids_to_filter.any?
+        context[:activities].where.not("resource_id in (?) AND resource_type = ?", resource_ids_to_filter, "Decidim::Comments::Comment")
+      else
+        context[:activities]
+      end
     end
 
     def resource_types

data/app/commands/decidim/amendable/accept.rb

@@ -62,7 +62,8 @@ module Decidim
           @amendable.save!
           @amendable
         end
-        @amendable.add_coauthor(@amender, user_group: @user_group)
+
+        @amendable.add_coauthor(@amender, user_group: @user_group) if @amendable.is_a?(Decidim::Coauthorable)
       end
 
       def notify_emendation_state_change!

data/app/commands/decidim/create_omniauth_registration.rb

@@ -69,7 +69,7 @@ module Decidim
         @user.email = (verified_email || form.email)
         @user.name = form.name.gsub(REGEXP_SANITIZER, "")
         @user.nickname = form.normalized_nickname
-        @user.newsletter_notifications_at = nil
+        @user.newsletter_notifications_at = form.newsletter_at
         @user.password = SecureRandom.hex
         attach_avatar(form.avatar_url) if form.avatar_url.present?
         @user.tos_agreement = form.tos_agreement

data/app/controllers/decidim/amendments_controller.rb

@@ -107,7 +107,7 @@ module Decidim
     end
 
     def reject
-      enforce_permission_to :reject, :amendment, current_component: amendable.component
+      enforce_permission_to :reject, :amendment, amendable:, current_component: amendable.component
 
       @form = form(Decidim::Amendable::RejectForm).from_model(amendment)
 
@@ -143,13 +143,13 @@ module Decidim
     end
 
     def review
-      enforce_permission_to :accept, :amendment, current_component: amendable.component
+      enforce_permission_to :accept, :amendment, amendable:, current_component: amendable.component
 
       @form = form(Decidim::Amendable::ReviewForm).from_params(params)
     end
 
     def accept
-      enforce_permission_to :accept, :amendment, current_component: amendable.component
+      enforce_permission_to :accept, :amendment, amendable:, current_component: amendable.component
 
       @form = form(Decidim::Amendable::ReviewForm).from_params(params)
 

data/app/forms/decidim/user_group_form.rb

@@ -16,10 +16,12 @@ module Decidim
     attribute :phone
 
     validates :name, presence: true
+    validates :name, format: { with: Decidim::UserBaseEntity::REGEXP_NAME }
     validates :email, presence: true, "valid_email_2/email": { disposable: true }
     validates :nickname, presence: true
 
     validates :nickname, length: { maximum: Decidim::User.nickname_max_length, allow_blank: true }
+    validates :nickname, format: { with: Decidim::UserBaseEntity::REGEXP_NICKNAME }
     validates :avatar, passthru: { to: Decidim::UserGroup }
 
     validate :unique_document_number

data/app/helpers/decidim/amendments_helper.rb

@@ -61,8 +61,9 @@ module Decidim
     # Checks if the user can accept and reject the emendation
     def allowed_to_accept_and_reject?(emendation)
       return unless emendation.amendment.evaluating?
+      return current_user.admin? if emendation.amendable.respond_to?(:official?) && emendation.amendable.official?
 
-      emendation.amendable.created_by?(current_user) || current_user.admin?
+      emendation.amendable.created_by?(current_user)
     end
 
     # Checks if the user can promote the emendation

data/app/helpers/decidim/filters_helper.rb

@@ -32,6 +32,31 @@ module Decidim
       end
     end
 
+    def filter_search_label(label, id)
+      I18n.t("decidim.searches.filters.resource", label:, collection: filter_for_resource(id))
+    end
+
+    def filter_for_resource(skip_to_id)
+      case skip_to_id
+      when "proposals"
+        I18n.t("decidim/proposals/proposal.other", scope: "activerecord.models")
+      when "meetings"
+        I18n.t("decidim/meetings/meeting.other", scope: "activerecord.models")
+      when "debates"
+        I18n.t("decidim/debates/debate.other", scope: "activerecord.models")
+      when "sortitions"
+        I18n.t("decidim/sortitions/sortition.other", scope: "activerecord.models")
+      when "surveys"
+        I18n.t("decidim/surveys/survey.other", scope: "activerecord.models")
+      when "projects"
+        I18n.t("decidim/budgets/project.other", scope: "activerecord.models")
+      when "initiatives"
+        I18n.t("decidim/initiative.other", scope: "activerecord.models")
+      else
+        ""
+      end
+    end
+
     private
 
     # Creates a unique namespace for a filter form to prevent duplicate IDs in

data/app/helpers/decidim/layout_helper.rb

@@ -60,6 +60,12 @@ module Decidim
       html_properties = options.with_indifferent_access.transform_keys(&:dasherize).slice("width", "height", "aria-label", "role", "aria-hidden", "class", "style")
       html_properties = default_html_properties.merge(html_properties)
 
+      if name == "wechat-line"
+        html_properties = html_properties.merge({ "aria-label" => I18n.t("decidim.author.comments.other") }).except("aria-hidden")
+      elsif name == "heart-line"
+        html_properties = html_properties.merge({ "aria-label" => I18n.t("decidim.author.endorsements.other") }).except("aria-hidden")
+      end
+
       href = Decidim.cors_enabled ? "" : asset_pack_path("media/images/remixicon.symbol.svg")
 
       content_tag :svg, html_properties do

data/app/helpers/decidim/map_helper.rb

@@ -81,7 +81,7 @@ module Decidim
 
       help = content_tag(:div, class: "map__skip-container") do
         sr_content = content_tag(:p, t("screen_reader_explanation", scope: "decidim.map.dynamic"), class: "sr-only")
-        link = link_to(t("skip_button", scope: "decidim.map.dynamic"), "##{bottom_id}", class: "map__skip")
+        link = link_to(t("skip_button", scope: "decidim.map.dynamic"), "##{bottom_id}", class: "map__skip", "data-skip-to-content": true)
 
         sr_content + link
       end

data/app/helpers/decidim/menu_helper.rb

@@ -68,8 +68,14 @@ module Decidim
       @menu_highlighted_participatory_process ||= (
         # The queries already include the order by weight
         Decidim::ParticipatoryProcesses::OrganizationParticipatoryProcesses.new(current_organization) |
-        Decidim::ParticipatoryProcesses::PromotedParticipatoryProcesses.new
-      ).first
+          Decidim::ParticipatoryProcesses::PromotedParticipatoryProcesses.new
+      ).select(&:published?).map { |process| remove_private_space_if_not_private_user(process) }&.compact&.first
+    end
+
+    def remove_private_space_if_not_private_user(process)
+      return nil if process.private_space == true && !process.can_participate?(current_user)
+
+      process
     end
 
     def home_content_block_menu

data/app/packs/images/decidim/default-avatar.svg

@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="Layer_1" width="200" height="200" x="0" y="0" enable-background="new 0 0 200 200" version="1.1" viewBox="0 0 200 200" xml:space="preserve"><g><path fill="#C5C5C5" d="M200-0.5H0v200h26.099c2.885-35.293,24.07-64.381,52.419-74.319C64.372,117.596,54.75,102.674,54.75,85.5 c0-24.853,20.146-45,45-45c24.853,0,45,20.147,45,45c0,17.095-9.533,31.963-23.572,39.58c28.5,9.837,49.828,39.002,52.724,74.42 H200V-0.5z"/><path fill="#FFF" d="M121.178,125.08c14.039-7.617,23.572-22.485,23.572-39.58c0-24.853-20.147-45-45-45 c-24.854,0-45,20.147-45,45c0,17.174,9.622,32.096,23.768,39.681c-28.349,9.938-49.534,39.026-52.419,74.319h147.803 C171.006,164.082,149.678,134.917,121.178,125.08z"/></g></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="Layer_1" width="200" height="200" x="0" y="0" enable-background="new 0 0 200 200" version="1.1" viewBox="0 0 200 200" xml:space="preserve"><g><path fill="#908e8e" d="M200-0.5H0v200h26.099c2.885-35.293,24.07-64.381,52.419-74.319C64.372,117.596,54.75,102.674,54.75,85.5 c0-24.853,20.146-45,45-45c24.853,0,45,20.147,45,45c0,17.095-9.533,31.963-23.572,39.58c28.5,9.837,49.828,39.002,52.724,74.42 H200V-0.5z"/><path fill="#FFF" d="M121.178,125.08c14.039-7.617,23.572-22.485,23.572-39.58c0-24.853-20.147-45-45-45 c-24.854,0-45,20.147-45,45c0,17.174,9.622,32.096,23.768,39.681c-28.349,9.938-49.534,39.026-52.419,74.319h147.803 C171.006,164.082,149.678,134.917,121.178,125.08z"/></g></svg>

data/app/packs/src/decidim/callout.js

@@ -4,13 +4,18 @@
  * reload without this.
  */
 
-$(() => {
-  const $callout = $('.callout[role="alert"]:first');
-  if ($callout.length > 0) {
-    setTimeout(() => {
-      // The content insertion is to try to hint some of the screen readers
-      // that the alert content has changed and needs to be announced.
-      $callout.attr("tabindex", "0").focus().html(`${$callout.html()} `);
-    }, 500);
+document.addEventListener("turbo:load", () => {
+  const callout = document.querySelector(".flash[role='alert']");
+  if (!callout) {
+    return;
   }
+
+  setTimeout(() => {
+    callout.setAttribute("tabindex", "0");
+    callout.focus();
+
+    // The content insertion is to try to hint some of the screen readers
+    // that the alert content has changed and needs to be announced.
+    callout.innerHTML += " ";
+  }, 500);
 });

data/app/packs/src/decidim/confirm.js

@@ -10,13 +10,25 @@ const { Rails } = window;
 class ConfirmDialog {
   constructor(sourceElement) {
     this.$modal = $("#confirm-modal");
-    if (sourceElement) {
-      this.$source = $(sourceElement);
-    }
     this.$content = $("[data-confirm-modal-content]", this.$modal);
+    this.$title = $("[data-dialog-title]", this.$modal);
     this.$buttonConfirm = $("[data-confirm-ok]", this.$modal);
     this.$buttonCancel = $("[data-confirm-cancel]", this.$modal);
 
+    if (sourceElement) {
+      this.$source = $(sourceElement);
+
+      const confirmTitle = this.$source.data("confirm-title");
+      const confirmButton = this.$source.data("confirm-button");
+
+      this.$title.text(confirmTitle)
+
+      const $buttonSpan = this.$buttonConfirm.find("span");
+      if ($buttonSpan.length > 0) {
+        $buttonSpan.text(confirmButton);
+      }
+    }
+
     window.Decidim.currentDialogs["confirm-modal"].open()
   }
 

data/app/packs/src/decidim/datepicker/generate_datepicker.js

@@ -13,11 +13,13 @@ export default function generateDatePicker(input, row, formats) {
   const date = document.createElement("input");
   date.setAttribute("id", `${input.id}_date`);
   date.setAttribute("type", "text");
+  date.setAttribute("aria-label", input.dataset.dateLabel);
 
   const calendar = document.createElement("button");
   calendar.innerHTML = icon("calendar-line");
   calendar.setAttribute("class", "datepicker__calendar-button");
   calendar.setAttribute("type", "button");
+  calendar.setAttribute("aria-label", input.dataset.buttonDateLabel);
 
   dateColumn.appendChild(date);
   dateColumn.appendChild(calendar);

data/app/packs/src/decidim/datepicker/generate_timepicker.js

@@ -13,11 +13,13 @@ export default function generateTimePicker(input, row, formats) {
   const time = document.createElement("input");
   time.setAttribute("id", `${input.id}_time`);
   time.setAttribute("type", "text");
+  time.setAttribute("aria-label", input.dataset.timeLabel);
 
   const clock = document.createElement("button");
   clock.innerHTML = icon("time-line")
   clock.setAttribute("class", "datepicker__clock-button");
   clock.setAttribute("type", "button");
+  clock.setAttribute("aria-label", input.dataset.buttonTimeLabel);
 
   timeColumn.appendChild(time);
   timeColumn.appendChild(clock);

data/app/packs/src/decidim/direct_uploads/upload_field.js

@@ -1,5 +1,4 @@
 import UploadModal from "src/decidim/direct_uploads/upload_modal";
-import { truncateFilename } from "src/decidim/direct_uploads/upload_utility";
 import { escapeHtml, escapeQuotes } from "src/decidim/utilities/text";
 
 const updateModalTitle = (modal) => {
@@ -30,7 +29,7 @@ const updateActiveUploads = (modal) => {
   const [removeFiles, addFiles] = [modal.items.filter(({ removable }) => removable), modal.items.filter(({ removable }) => !removable)]
 
   addFiles.forEach((file, ix) => {
-    let title = truncateFilename(file.name, 19)
+    let title = file.name
 
     let hidden = ""
     if (file.hiddenField) {
@@ -79,8 +78,8 @@ const updateActiveUploads = (modal) => {
 
     const template = `
       <div ${attachmentIdOrHiddenField} data-filename="${escapeQuotes(file.name)}" data-title="${escapeQuotes(title)}">
-        ${(/image/).test(file.type) && `<div><img src="data:," alt="${escapeQuotes(file.name)}" /></div>` || ""}
-        <span>${escapeHtml(title)} (${escapeHtml(truncateFilename(file.name))})</span>
+        ${(/image/).test(file.type) && "<div><img src=\"data:,\" role=\"presentation\" /></div>" || ""}
+        <span>${escapeHtml(title)}</span>
         ${hidden}
       </div>
     `