decidim-core 0.29.6 → 0.30.0.rc1

data/app/models/decidim/user.rb

@@ -13,6 +13,8 @@ module Decidim
     include Decidim::UserReportable
     include Decidim::Traceable
 
+    REGEXP_NICKNAME = /\A[\w-]+\z/
+
     class Roles
       def self.all
         Decidim.config.user_roles
@@ -33,6 +35,7 @@ module Decidim
     has_many :access_grants, class_name: "Doorkeeper::AccessGrant", foreign_key: :resource_owner_id, dependent: :destroy
     has_many :access_tokens, class_name: "Doorkeeper::AccessToken", foreign_key: :resource_owner_id, dependent: :destroy
     has_many :reminders, foreign_key: "decidim_user_id", class_name: "Decidim::Reminder", dependent: :destroy
+    has_many :private_exports, class_name: "Decidim::PrivateExport", dependent: :destroy, inverse_of: :attached_to, as: :attached_to
 
     validates :name, presence: true, unless: -> { deleted? }
     validates :nickname,
@@ -43,37 +46,28 @@ module Decidim
     validates :locale, inclusion: { in: :available_locales }, allow_blank: true
     validates :tos_agreement, acceptance: true, allow_nil: false, on: :create
     validates :tos_agreement, acceptance: true, if: :user_invited?
+    validates :tos_agreement, acceptance: true, if: :ephemeral?
     validates :email, :nickname, uniqueness: { scope: :organization }, unless: -> { deleted? || managed? || nickname.blank? }
 
     validate :all_roles_are_valid
 
     has_one_attached :download_your_data_file
 
+    scope :not_deleted, -> { where(deleted_at: nil) }
+
     scope :managed, -> { where(managed: true) }
     scope :not_managed, -> { where(managed: false) }
 
     scope :officialized, -> { where.not(officialized_at: nil) }
     scope :not_officialized, -> { where(officialized_at: nil) }
 
-    scope :interested_in_scopes, lambda { |scope_ids|
-      actual_ids = scope_ids.select(&:presence)
-      if actual_ids.count.positive?
-        ids = actual_ids.map(&:to_i).join(",")
-        where(Arel.sql("extended_data->'interested_scopes' @> ANY('{#{ids}}')").to_s)
-      else
-        # Do not apply the scope filter when there are scope ids available. Note
-        # that the active record scope must always return an active record
-        # collection.
-        self
-      end
-    }
-
     scope :org_admins_except_me, ->(user) { where(organization: user.organization, admin: true).where.not(id: user.id) }
 
+    scope :ephemeral, -> { where("extended_data @> ?", Arel.sql({ ephemeral: true }.to_json)) }
+
     attr_accessor :newsletter_notifications
 
     searchable_fields({
-                        # scope_id: :decidim_scope_id,
                         organization_id: :decidim_organization_id,
                         A: :name,
                         B: :nickname,
@@ -191,7 +185,7 @@ module Decidim
     end
 
     def tos_accepted?
-      return true if managed
+      return true if managed && !ephemeral?
       return false if accepted_tos_version.nil?
 
       # For some reason, if we do not use `#to_i` here we get some
@@ -213,14 +207,6 @@ module Decidim
       ImpersonationLog.active.exists?(user: self)
     end
 
-    def interested_scopes_ids
-      extended_data["interested_scopes"] || []
-    end
-
-    def interested_scopes
-      @interested_scopes ||= organization.scopes.where(id: interested_scopes_ids)
-    end
-
     def user_name
       extended_data["user_name"] || name
     end
@@ -274,6 +260,10 @@ module Decidim
       false
     end
 
+    def ephemeral?
+      extended_data["ephemeral"]
+    end
+
     def after_confirmation
       return unless organization.send_welcome_notification?
 

data/app/models/decidim/user_base_entity.rb

@@ -21,13 +21,11 @@ module Decidim
 
     # Regex for name & nickname format validations
     REGEXP_NAME = /\A(?!.*[<>?%&\^*#@()\[\]=+:;"{}\\|])/
-    REGEXP_NICKNAME = /\A[a-z0-9_-]+\z/
 
     has_one_attached :avatar
     validates_avatar :avatar, uploader: Decidim::AvatarUploader
 
     validates :name, format: { with: REGEXP_NAME }
-    validates :nickname, format: { with: REGEXP_NICKNAME }, unless: -> { deleted? || managed? }
 
     scope :confirmed, -> { where.not(confirmed_at: nil) }
     scope :not_confirmed, -> { where(confirmed_at: nil) }
@@ -36,8 +34,6 @@ module Decidim
     scope :not_blocked, -> { where(blocked: false) }
     scope :available, -> { where(deleted_at: nil, blocked: false, managed: false) }
 
-    scope :not_deleted, -> { where(deleted_at: nil) }
-
     # Public: Returns a collection with all the public entities this user is following.
     #
     # This cannot be done as with a `has_many :following, through: :following_follows`
@@ -69,6 +65,18 @@ module Decidim
       Decidim::UserBaseEntity.joins(:follows).where(decidim_follows: { user: self }).blocked.exists?
     end
 
+    def self.ransackable_attributes(auth_object = nil)
+      base = %w(name email nickname last_sign_in_at)
+
+      return base unless auth_object&.admin?
+
+      base + %w(invitation_sent_at invitation_accepted_at officialized_at)
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      []
+    end
+
     private
 
     def only_public(klass, ids)

data/app/models/decidim/user_moderation.rb

@@ -6,6 +6,7 @@ module Decidim
     include Loggable
 
     belongs_to :user, foreign_key: :decidim_user_id, class_name: "Decidim::UserBaseEntity"
+    has_one :blocking, through: :user
     has_many :reports, class_name: "Decidim::UserReport", dependent: :destroy
 
     scope :blocked, -> { joins(:user).where(decidim_users: { blocked: true }) }
@@ -16,5 +17,13 @@ module Decidim
     def self.log_presenter_class_for(_log)
       Decidim::AdminLog::UserModerationPresenter
     end
+
+    def self.ransackable_attributes(_auth_object = nil)
+      []
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      %w(reports user)
+    end
   end
 end

data/app/models/decidim/user_report.rb

@@ -19,6 +19,10 @@ module Decidim
       # Decidim::DownloadYourDataSerializers::DownloadYourDataReportSerializer
     end
 
+    def self.ransackable_attributes(_auth_object = nil)
+      %w(reason)
+    end
+
     private
 
     # Private: check if the moderation and the user have the same organization

data/app/packs/entrypoints/decidim_core.js

@@ -6,6 +6,7 @@ import "src/decidim/decidim_application"
 
 // CSS
 import "entrypoints/decidim_core.scss"
+import "stylesheets/decidim/resource_history.scss"
 
 // Images
 require.context("../images", true)

data/app/packs/entrypoints/decidim_geocoding.js

@@ -0,0 +1,2 @@
+import "src/decidim/geocoding/reverse_geocoding.js"
+import "stylesheets/decidim/geocoding_addons.scss";

data/app/packs/images/decidim/brands/facebook.svg

@@ -0,0 +1,10 @@
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<g clip-path="url(#clip0_29214_25190)">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M24 12.0707C24 5.40424 18.6274 0 12 0C5.37258 0 0 5.40424 0 12.0707C0 18.0956 4.38823 23.0893 10.125 23.9948V15.5599H7.07812V12.0707H10.125V9.41139C10.125 6.38617 11.9165 4.71513 14.6576 4.71513C15.9705 4.71513 17.3438 4.95088 17.3438 4.95088V7.92141H15.8306C14.3399 7.92141 13.875 8.85187 13.875 9.80645V12.0707H17.2031L16.6711 15.5599H13.875V23.9948C19.6118 23.0893 24 18.0956 24 12.0707Z" fill="white"/>
+</g>
+<defs>
+<clipPath id="clip0_29214_25190">
+<rect width="24" height="24" fill="white"/>
+</clipPath>
+</defs>
+</svg>

data/app/packs/images/decidim/brands/google.svg

@@ -1 +1,7 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="42" height="42" viewBox="2 -2 42 42"><defs><filter id="b" width="2" height="2" x="-.5" y="-.5" filterUnits="objectBoundingBox"><feOffset dy="1" in="SourceAlpha" result="shadowOffsetOuter1"/><feGaussianBlur in="shadowOffsetOuter1" result="shadowBlurOuter1" stdDeviation=".5"/><feColorMatrix in="shadowBlurOuter1" result="shadowMatrixOuter1" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.168 0"/><feOffset in="SourceAlpha" result="shadowOffsetOuter2"/><feGaussianBlur in="shadowOffsetOuter2" result="shadowBlurOuter2" stdDeviation=".5"/><feColorMatrix in="shadowBlurOuter2" result="shadowMatrixOuter2" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0.084 0"/><feMerge><feMergeNode in="shadowMatrixOuter1"/><feMergeNode in="shadowMatrixOuter2"/><feMergeNode in="SourceGraphic"/></feMerge></filter><rect id="a" width="40" height="40" x="0" y="0" rx="2"/></defs><use width="100%" height="100%" fill="#fff" fill-rule="evenodd" filter="url(#b)" transform="translate(3 -1)" xlink:href="#a"/><use width="100%" height="100%" fill="none" fill-rule="evenodd" filter="url(#b)" transform="translate(3 -1)" xlink:href="#a"/><use width="100%" height="100%" fill="none" fill-rule="evenodd" filter="url(#b)" transform="translate(3 -1)" xlink:href="#a"/><use width="100%" height="100%" fill="none" fill-rule="evenodd" filter="url(#b)" transform="translate(3 -1)" xlink:href="#a"/><path fill="#4285f4" fill-rule="evenodd" d="M31.64 19.205c0-.639-.057-1.252-.164-1.841H23v3.481h4.844a4.14 4.14 0 01-1.796 2.716v2.259h2.908c1.702-1.567 2.684-3.875 2.684-6.615z"/><path fill="#34a853" fill-rule="evenodd" d="M23 28c2.43 0 4.467-.806 5.956-2.18l-2.908-2.259c-.806.54-1.837.86-3.048.86-2.344 0-4.328-1.584-5.036-3.711h-3.007v2.332A8.997 8.997 0 0023 28z"/><path fill="#fbbc05" fill-rule="evenodd" d="M17.964 20.71a5.41 5.41 0 01-.282-1.71c0-.593.102-1.17.282-1.71v-2.332h-3.007A8.996 8.996 0 0014 19c0 1.452.348 2.827.957 4.042z"/><path fill="#ea4335" fill-rule="evenodd" d="M23 13.58c1.321 0 2.508.454 3.44 1.345l2.582-2.58C27.463 10.891 25.426 10 23 10a8.997 8.997 0 00-8.043 4.958l3.007 2.332c.708-2.127 2.692-3.71 5.036-3.71z"/><path fill="none" d="M14 10h18v18H14z"/></svg>
+<svg version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48" xmlns:xlink="http://www.w3.org/1999/xlink" style="display: block;">
+        <path fill="#EA4335" d="M24 9.5c3.54 0 6.71 1.22 9.21 3.6l6.85-6.85C35.9 2.38 30.47 0 24 0 14.62 0 6.51 5.38 2.56 13.22l7.98 6.19C12.43 13.72 17.74 9.5 24 9.5z"></path>
+        <path fill="#4285F4" d="M46.98 24.55c0-1.57-.15-3.09-.38-4.55H24v9.02h12.94c-.58 2.96-2.26 5.48-4.78 7.18l7.73 6c4.51-4.18 7.09-10.36 7.09-17.65z"></path>
+        <path fill="#FBBC05" d="M10.53 28.59c-.48-1.45-.76-2.99-.76-4.59s.27-3.14.76-4.59l-7.98-6.19C.92 16.46 0 20.12 0 24c0 3.88.92 7.54 2.56 10.78l7.97-6.19z"></path>
+        <path fill="#34A853" d="M24 48c6.48 0 11.93-2.13 15.89-5.81l-7.73-6c-2.15 1.45-4.92 2.3-8.16 2.3-6.26 0-11.57-4.22-13.47-9.91l-7.98 6.19C6.51 42.62 14.62 48 24 48z"></path>
+        <path fill="none" d="M0 0h48v48H0z"></path>
+      </svg>

data/app/packs/images/decidim/brands/twitter-x.svg

@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-twitter-x" viewBox="0 0 16 16">
+  <path d="M12.6.75h2.454l-5.36 6.142L16 15.25h-4.937l-3.867-5.07-4.425 5.07H.316l5.733-6.57L0 .75h5.063l3.495 4.633L12.601.75Zm-.86 13.028h1.36L4.323 2.145H2.865z"/>
+</svg>

data/app/packs/images/decidim/default-avatar.svg

@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="Layer_1" width="200" height="200" x="0" y="0" enable-background="new 0 0 200 200" version="1.1" viewBox="0 0 200 200" xml:space="preserve"><g><path fill="#908e8e" d="M200-0.5H0v200h26.099c2.885-35.293,24.07-64.381,52.419-74.319C64.372,117.596,54.75,102.674,54.75,85.5 c0-24.853,20.146-45,45-45c24.853,0,45,20.147,45,45c0,17.095-9.533,31.963-23.572,39.58c28.5,9.837,49.828,39.002,52.724,74.42 H200V-0.5z"/><path fill="#FFF" d="M121.178,125.08c14.039-7.617,23.572-22.485,23.572-39.58c0-24.853-20.147-45-45-45 c-24.854,0-45,20.147-45,45c0,17.174,9.622,32.096,23.768,39.681c-28.349,9.938-49.534,39.026-52.419,74.319h147.803 C171.006,164.082,149.678,134.917,121.178,125.08z"/></g></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" id="Layer_1" width="200" height="200" x="0" y="0" enable-background="new 0 0 200 200" version="1.1" viewBox="0 0 200 200" xml:space="preserve"><g><path fill="#C5C5C5" d="M200-0.5H0v200h26.099c2.885-35.293,24.07-64.381,52.419-74.319C64.372,117.596,54.75,102.674,54.75,85.5 c0-24.853,20.146-45,45-45c24.853,0,45,20.147,45,45c0,17.095-9.533,31.963-23.572,39.58c28.5,9.837,49.828,39.002,52.724,74.42 H200V-0.5z"/><path fill="#FFF" d="M121.178,125.08c14.039-7.617,23.572-22.485,23.572-39.58c0-24.853-20.147-45-45-45 c-24.854,0-45,20.147-45,45c0,17.174,9.622,32.096,23.768,39.681c-28.349,9.938-49.534,39.026-52.419,74.319h147.803 C171.006,164.082,149.678,134.917,121.178,125.08z"/></g></svg>

data/app/packs/src/decidim/callout.js

@@ -4,18 +4,13 @@
  * reload without this.
  */
 
-document.addEventListener("turbo:load", () => {
-  const callout = document.querySelector(".flash[role='alert']");
-  if (!callout) {
-    return;
+$(() => {
+  const $callout = $('.callout[role="alert"]:first');
+  if ($callout.length > 0) {
+    setTimeout(() => {
+      // The content insertion is to try to hint some of the screen readers
+      // that the alert content has changed and needs to be announced.
+      $callout.attr("tabindex", "0").focus().html(`${$callout.html()} `);
+    }, 500);
   }
-
-  setTimeout(() => {
-    callout.setAttribute("tabindex", "0");
-    callout.focus();
-
-    // The content insertion is to try to hint some of the screen readers
-    // that the alert content has changed and needs to be announced.
-    callout.innerHTML += " ";
-  }, 500);
 });

data/app/packs/src/decidim/check_boxes_tree.js

@@ -101,7 +101,6 @@ export default class CheckBoxesTree {
     const indeterminateSiblings = totalCheckSiblings.filter((checkbox) => checkbox.indeterminate)
 
     if (checkedSiblings.length === 0 && indeterminateSiblings.length === 0) {
-      parentCheck.checked = false;
       parentCheck.indeterminate = false;
     } else if (checkedSiblings.length === totalCheckSiblings.length && indeterminateSiblings.length === 0) {
       parentCheck.checked = true;

data/app/packs/src/decidim/clipboard.js

@@ -21,7 +21,9 @@ import select from "select";
  *
  * Options through data attributes:
  * - `data-clipboard-copy` = The jQuery selector for the target input element
- *   where text will be copied from.
+ *   where text will be copied from. If this element does not contain any visible text (for instance is an image),
+ *   the selector indicated in here will be used to place the confirmation message.
+ * - `data-clipboard-content` = The text that will be copied. If empty or not present, the target input element will be used.
  * - `data-clipboard-copy-label` = The label that will be shown in the button
  *   after a succesful copy.
  * - `data-clipboard-copy-message` = The text that will be announced to screen
@@ -40,12 +42,17 @@ $(() => {
     }
 
     const $input = $($el.data("clipboard-copy"));
-    if ($input.length < 1 || !$input.is("input, textarea, select")) {
-      return;
+
+    let selectedText = $el.data("clipboard-content") || "";
+    if (selectedText === "" && $input.is("input, textarea, select")) {
+      selectedText = select($input[0]);
     }
 
+    let $msgEl = $el;
+    if ($msgEl.text() === "") {
+      $msgEl = $input;
+    }
     // Get the available text to clipboard.
-    const selectedText = select($input[0]);
     if (!selectedText || selectedText.length < 1) {
       return;
     }
@@ -83,16 +90,18 @@ $(() => {
       }
 
       if (!$el.data("clipboard-copy-label-original")) {
-        $el.data("clipboard-copy-label-original", $el.html());
+        $el.data("clipboard-copy-label-original", $msgEl.html());
       }
 
-      $el.html(label);
+      $msgEl.html(label);
+
       to = setTimeout(() => {
-        $el.html($el.data("clipboard-copy-label-original"));
+        $msgEl.html($el.data("clipboard-copy-label-original"));
         $el.removeData("clipboard-copy-label-original");
         $el.removeData("clipboard-copy-label-timeout");
       }, CLIPBOARD_COPY_TIMEOUT);
-      $el.data("clipboard-copy-label-timeout", to)
+
+      $el.data("clipboard-copy-label-timeout", to);
     }
 
     // Alert the screen reader what just happened (the link was copied).
@@ -107,7 +116,7 @@ $(() => {
         }
       } else {
         $msg = $('<div aria-role="alert" aria-live="assertive" aria-atomic="true" class="sr-only"></div>');
-        $el.after($msg);
+        $msgEl.append($msg);
         $el.data("clipboard-message-element", $msg);
       }
 

data/app/packs/src/decidim/datepicker/datepicker_functions.js

@@ -29,12 +29,12 @@ export const formatInputDate = (date, formats) => {
   const month = dateList[1];
   const day = dateList[2];
 
-  if (formats.order === "m-d-y") {
-    return `${month}${formats.separator}${day}${formats.separator}${year}`;
+  if (formats.order === "d-m-y") {
+    return `${day}${formats.separator}${month}${formats.separator}${year}`;
   } else if (formats.order === "y-m-d") {
     return `${year}${formats.separator}${month}${formats.separator}${day}`;
   };
-  return `${day}${formats.separator}${month}${formats.separator}${year}`;
+  return `${month}${formats.separator}${day}${formats.separator}${year}`;
 };
 
 export const formatInputTime = (time, format, input) => {

data/app/packs/src/decidim/datepicker/generate_datepicker.js

@@ -13,13 +13,11 @@ export default function generateDatePicker(input, row, formats) {
   const date = document.createElement("input");
   date.setAttribute("id", `${input.id}_date`);
   date.setAttribute("type", "text");
-  date.setAttribute("aria-label", input.dataset.dateLabel);
 
   const calendar = document.createElement("button");
   calendar.innerHTML = icon("calendar-line");
   calendar.setAttribute("class", "datepicker__calendar-button");
   calendar.setAttribute("type", "button");
-  calendar.setAttribute("aria-label", input.dataset.buttonDateLabel);
 
   dateColumn.appendChild(date);
   dateColumn.appendChild(calendar);

data/app/packs/src/decidim/datepicker/generate_timepicker.js

@@ -13,13 +13,11 @@ export default function generateTimePicker(input, row, formats) {
   const time = document.createElement("input");
   time.setAttribute("id", `${input.id}_time`);
   time.setAttribute("type", "text");
-  time.setAttribute("aria-label", input.dataset.timeLabel);
 
   const clock = document.createElement("button");
   clock.innerHTML = icon("time-line")
   clock.setAttribute("class", "datepicker__clock-button");
   clock.setAttribute("type", "button");
-  clock.setAttribute("aria-label", input.dataset.buttonTimeLabel);
 
   timeColumn.appendChild(time);
   timeColumn.appendChild(clock);

data/app/packs/src/decidim/decidim_application.js

@@ -0,0 +1 @@
+// This file is intentionally empty, because is the place for the defidim applications will add their JavaScript code.

data/app/packs/src/decidim/direct_uploads/upload_field.js

@@ -1,4 +1,5 @@
 import UploadModal from "src/decidim/direct_uploads/upload_modal";
+import { truncateFilename } from "src/decidim/direct_uploads/upload_utility";
 import { escapeHtml, escapeQuotes } from "src/decidim/utilities/text";
 
 const updateModalTitle = (modal) => {
@@ -29,7 +30,7 @@ const updateActiveUploads = (modal) => {
   const [removeFiles, addFiles] = [modal.items.filter(({ removable }) => removable), modal.items.filter(({ removable }) => !removable)]
 
   addFiles.forEach((file, ix) => {
-    let title = file.name
+    let title = truncateFilename(file.name, 19)
 
     let hidden = ""
     if (file.hiddenField) {
@@ -78,8 +79,8 @@ const updateActiveUploads = (modal) => {
 
     const template = `
       <div ${attachmentIdOrHiddenField} data-filename="${escapeQuotes(file.name)}" data-title="${escapeQuotes(title)}">
-        ${(/image/).test(file.type) && "<div><img src=\"data:,\" role=\"presentation\" /></div>" || ""}
-        <span>${escapeHtml(title)}</span>
+        ${(/image/).test(file.type) && `<div><img src="data:," alt="${escapeQuotes(file.name)}" /></div>` || ""}
+        <span>${escapeHtml(title)} (${escapeHtml(truncateFilename(file.name))})</span>
         ${hidden}
       </div>
     `

data/app/packs/src/decidim/direct_uploads/upload_modal.js

@@ -1,5 +1,6 @@
 import { Uploader } from "src/decidim/direct_uploads/uploader";
 import icon from "src/decidim/icon";
+import { truncateFilename } from "src/decidim/direct_uploads/upload_utility";
 import { escapeHtml, escapeQuotes } from "src/decidim/utilities/text";
 
 const STATUS = {
@@ -41,7 +42,7 @@ export default class UploadModal {
 
     this.emptyItems = this.modal.querySelector("[data-dropzone-no-items]");
     this.uploadItems = this.modal.querySelector("[data-dropzone-items]");
-    this.input = this.dropZone.querySelector("input[type=file]");
+    this.input = this.dropZone.querySelector("input");
     this.items = []
 
     this.attachmentCounter = 0;
@@ -170,29 +171,29 @@ export default class UploadModal {
 
   createUploadItem(file, errors, opts = {}) {
     const okTemplate = `
-      <img src="data:,", role="presentation" />
-      <span class="upload-modal__span">${escapeHtml(file.name)}</span>
+      <img src="data:," alt="${escapeQuotes(file.name)}" />
+      <span>${escapeHtml(truncateFilename(file.name))}</span>
     `
 
     const errorTemplate = `
       <div>${icon("error-warning-line")}</div>
       <div>
-        <span class="upload-modal__span">${escapeHtml(file.name)}</span>
+        <span>${escapeHtml(truncateFilename(file.name))}</span>
         <span>${this.locales.validation_error}</span>
         <ul>${errors.map((error) => `<li>${error}</li>`).join("\n")}</ul>
       </div>
     `
 
     const titleTemplate = `
-      <img src="data:," role="presentation" />
+      <img src="data:," alt="${escapeQuotes(file.name)}" />
       <div>
         <div>
           <label>${this.locales.filename}</label>
-          <span class="upload-modal__span">${escapeHtml(file.name)}</span>
+          <span>${escapeHtml(truncateFilename(file.name))}</span>
         </div>
         <div>
-          <label for="${file.name}">${this.locales.title}</label>
-          <input class="sm" type="text" value="${escapeQuotes(opts.title || file.name)}" id="${file.name}" />
+          <label>${this.locales.title}</label>
+          <input class="sm" type="text" value="${escapeQuotes(opts.title || truncateFilename(file.name))}" />
         </div>
       </div>
     `

data/app/packs/src/decidim/editor/common/suggestion.js

@@ -98,17 +98,7 @@ export const createSuggestionRenderer = (node, { itemConverter } = {}) => () =>
       suggestionItem.textContent = label;
       suggestion.append(suggestionItem);
 
-      suggestionItem.addEventListener("click", (ev) => {
-        ev.preventDefault();
-
-        if (currentRange) {
-          // Increase the current range by 1 since the ENTER key would do the
-          // same when doing the selection through keyboard.
-          currentRange.to += 1;
-        }
-
-        selectItem(idx);
-      });
+      suggestionItem.addEventListener("click", () => selectItem(idx));
     });
   }
 

data/app/packs/src/decidim/form_filter.js

@@ -206,12 +206,6 @@ export default class FormFilterComponent {
     this.changeEvents = false;
     this._clearForm();
 
-    // Prevent filtering again on anchor link "Skip to main content", "Skip map", or "Skip to results"
-    const filterSkipValues = [...document.querySelectorAll("[data-skip-to-content]")].map((el) => el.hash);
-    if (filterSkipValues.includes(window.location.hash)) {
-      return;
-    }
-
     const filterParams = this._parseLocationFilterValues();
     const currentOrder = this._parseLocationOrderValue();
 

data/app/packs/src/decidim/geocoding/reverse_geocoding.js

@@ -0,0 +1,60 @@
+document.addEventListener("DOMContentLoaded", () => {
+  const info = (target, msg) => {
+    const label = target.closest("label");
+    label.querySelectorAll(".form-error").forEach((el) => el.remove());
+    if (msg) {
+      const error = document.createElement("span");
+      error.className = "form-error";
+      error.textContent = msg;
+      label.appendChild(error);
+      error.style.display = "block";
+    }
+  };
+
+  const setLocating = (button, enable) => {
+    if (enable) {
+      button.setAttribute("disabled", true);
+    } else {
+      button.removeAttribute("disabled");
+    }
+  };
+
+  document.querySelectorAll(".user-device-location button").forEach((button) => {
+    button.addEventListener("click", (event) => {
+      const target = event.target;
+      if (target.disabled) {
+        return;
+      }
+
+      const input = document.getElementById(target.dataset.input);
+      const errorNoLocation = target.dataset.errorNoLocation;
+      const errorUnsupported = target.dataset.errorUnsupported;
+      const url = target.dataset.url;
+
+      if (navigator.geolocation) {
+        setLocating(target, true);
+        navigator.geolocation.getCurrentPosition((position) => {
+          const coordinates = [position.coords.latitude, position.coords.longitude];
+
+          // reverse geolocation
+          $.post(url, { latitude: coordinates[0], longitude: coordinates[1] }, (data) => {
+            input.value = data.address;
+            $(input).trigger("geocoder-suggest-coordinates.decidim", [coordinates]);
+          }).fail((xhr, status, error) => {
+            info(input, `${errorNoLocation} ${error}`);
+          });
+
+          setLocating(target, false);
+
+        }, (evt) => {
+          info(input, `${errorNoLocation} ${evt.message}`);
+          target.removeAttribute("disabled");
+        }, {
+          enableHighAccuracy: true
+        });
+      } else {
+        info(input, errorUnsupported);
+      }
+    });
+  });
+});

data/app/packs/src/decidim/index.js

@@ -8,6 +8,7 @@
 import "core-js/stable";
 import "regenerator-runtime/runtime";
 import "jquery"
+import "chartkick/chart.js"
 
 // REDESIGN_PENDING: deprecated
 import "foundation-sites";
@@ -49,8 +50,8 @@ import "src/decidim/data_consent"
 import "src/decidim/abide_form_validator_fixer"
 import "src/decidim/sw"
 import "src/decidim/sticky_header"
+import "src/decidim/sticky_footer"
 import "src/decidim/attachments"
-import "src/decidim/dropdown_menu"
 
 // local deps that require initialization
 import ConfirmDialog, { initializeConfirm } from "src/decidim/confirm"
@@ -70,8 +71,7 @@ import handleNotificationActions from "src/decidim/notifications_actions"
 import RemoteModal from "src/decidim/remote_modal"
 import selectActiveIdentity from "src/decidim/identity_selector_dialog"
 import createTooltip from "src/decidim/tooltips"
-// Temporary disabling this feature because we have a poor performance. See https://github.com/decidim/decidim/issues/14431
-// import fetchRemoteTooltip from "src/decidim/remote_tooltips"
+import fetchRemoteTooltip from "src/decidim/remote_tooltips"
 import createToggle from "src/decidim/toggle"
 import {
   createAccordion,
@@ -81,6 +81,7 @@ import {
   Dialogs
 } from "src/decidim/a11y"
 import changeReportFormBehavior from "src/decidim/change_report_form_behavior"
+import setOnboardingAction from "src/decidim/onboarding_pending_action"
 
 // bad practice: window namespace should avoid be populated as much as possible
 // rails-translations could be referenced through a single Decidim.I18n object
@@ -201,10 +202,13 @@ const initializer = (element = document) => {
   // Initialize data-toggles
   element.querySelectorAll("[data-toggle]").forEach((elem) => createToggle(elem))
 
-  // Temporary disabling this feature because we have a poor performance. See https://github.com/decidim/decidim/issues/14431
-  // element.querySelectorAll("[data-remote-tooltip]").forEach((elem) => fetchRemoteTooltip(elem))
+  element.querySelectorAll("[data-remote-tooltip]").forEach((elem) => fetchRemoteTooltip(elem))
 
   element.querySelectorAll(".new_report").forEach((elem) => changeReportFormBehavior(elem))
+
+  element.querySelectorAll("[data-onboarding-action]").forEach((elem) => setOnboardingAction(elem))
+
+  document.dispatchEvent(new CustomEvent("decidim:loaded", { detail: { element } }));
 }
 
 // If no jQuery is used the Tribute feature used in comments to autocomplete

data/app/packs/src/decidim/input_character_counter.js

@@ -93,7 +93,7 @@ export default class InputCharacterCounter {
       this.$srTarget = $(`#${screenReaderId}`);
       if (!this.$srTarget.length) {
         this.$srTarget = $(
-          `<span role="status" id="${screenReaderId}" class="sr-only remaining-character-count-sr" aria-hidden="true"/>`
+          `<span role="status" id="${screenReaderId}" class="sr-only remaining-character-count-sr" />`
         );
         this.$target.before(this.$srTarget);
       }

data/app/packs/src/decidim/map/provider/here.js

@@ -1,5 +1,5 @@
 import "leaflet"
-import "leaflet-tilelayer-here"
+import "src/decidim/vendor/leaflet-tilelayer-here"
 
 /**
  * NOTE:

data/app/packs/src/decidim/onboarding_pending_action.js

@@ -0,0 +1,24 @@
+import Cookies from "js-cookie";
+
+const ONBOARDING_COOKIE_EXPIRY = 365;
+
+// The same key is set in the Decidim::OnboardingManager class to retrieve the data from the cookie and store it in the extended data attribute
+const DATA_KEY = "onboarding";
+
+/**
+ * @param {DOMElement} element Element which provides the information for cookie about action to perform.
+ * @return {Void} Nothing
+ */
+export default function setOnboardingAction(element) {
+  // the dialog-open data attribute is stealing the click event
+  element.addEventListener("mousedown", () => {
+    const action = element.dataset.onboardingAction;
+    const model = element.dataset.onboardingModel;
+    const permissionsHolder = element.dataset.onboardingPermissionsHolder;
+    const redirectPath = element.dataset.onboardingRedirectPath;
+
+    Cookies.set(DATA_KEY, JSON.stringify({ action, model, permissionsHolder, redirectPath }), {
+      expires: ONBOARDING_COOKIE_EXPIRY
+    });
+  });
+}