decidim-core 0.29.2 → 0.30.0.rc2

data/lib/tasks/upgrade/{decidim_fix_categorization.rake → clean.rake}

@@ -8,6 +8,7 @@ namespace :decidim do
         :"decidim:upgrade:clean:searchable_resources",
         :"decidim:upgrade:clean:notifications",
         :"decidim:upgrade:clean:follows",
+        :"decidim:upgrade:clean:categories",
         :"decidim:upgrade:clean:action_logs",
         :"decidim:upgrade:clean:clean_deleted_users",
         :"decidim:upgrade:clean:fix_blocked_user_notification"
@@ -15,14 +16,13 @@ namespace :decidim do
 
       desc "Remove data from deleted users"
       task clean_deleted_users: :environment do
-        logger = Logger.new($stdout)
         logger.info("=== Removing extra data from deleted users")
         Decidim::User.where.not(deleted_at: nil).update_all(personal_url: "", about: "", notifications_sending_frequency: "none") # rubocop:disable Rails/SkipsModelValidations
       end
 
       desc "Removes any action logs belonging to invalid resources"
       task :action_logs, [] => :environment do
-        puts "=== Deleting Action logs\n"
+        logger.info("=== Deleting Action logs")
         invalid = 0
         Decidim::ActionLog.find_each do |log|
           log.participatory_space if log.participatory_space_type.present?
@@ -42,12 +42,12 @@ namespace :decidim do
           log.delete
           invalid += 1
         end
-        puts "===== Deleted #{invalid} invalid action logs\n"
+        logger.info("===== Deleted #{invalid} invalid action logs")
       end
 
       desc "Removes any follows belonging to invalid resources"
       task :follows, [] => :environment do
-        puts "=== Deleting Follows\n"
+        logger.info("=== Deleting Follows")
         invalid = 0
         Decidim::Follow.find_each do |follow|
           follow.followable
@@ -63,12 +63,12 @@ namespace :decidim do
           follow.delete
           invalid += 1
         end
-        puts "===== Deleted #{invalid} invalid follows\n"
+        logger.info("===== Deleted #{invalid} invalid follows")
       end
 
       desc "Removes any notifications belonging to invalid resources"
       task :notifications, [] => :environment do
-        puts "=== Deleting Notification\n"
+        logger.info("=== Deleting Notification")
         invalid = 0
         Decidim::Notification.find_each do |notification|
           # Check if the resource class still exists
@@ -79,13 +79,13 @@ namespace :decidim do
           notification.destroy
           invalid += 1
         end
-        puts "===== Deleted #{invalid} invalid notifications\n"
+        logger.info("===== Deleted #{invalid} invalid notifications")
       end
 
       desc "Removes any resources from search index that do not exist"
       task :searchable_resources, [] => :environment do
-        puts "=== Deleting Searchable results\n"
-        puts "==== Deleting invalid spaces \n"
+        logger.info("=== Deleting Searchable results")
+        logger.info("==== Deleting invalid spaces ")
         invalid = 0
         Decidim::SearchableResource.where.not(decidim_participatory_space_type: nil).find_each do |search|
           search.decidim_participatory_space
@@ -93,9 +93,9 @@ namespace :decidim do
           search.destroy!
           invalid += 1
         end
-        puts "===== Deleted #{invalid} invalid spaces\n"
+        logger.info("===== Deleted #{invalid} invalid spaces")
 
-        puts "==== Deleting invalid resources from search index \n"
+        logger.info("==== Deleting invalid resources from search index ")
         invalid = 0
         Decidim::SearchableResource.find_each do |search|
           next unless search.resource.respond_to?(:component)
@@ -107,24 +107,31 @@ namespace :decidim do
           search.destroy!
           invalid += 1
         end
-        puts "===== Deleted #{invalid} invalid resources\n"
+        logger.info("===== Deleted #{invalid} invalid resources")
       end
 
-      desc "Removes orphan categorizations"
-      task fix_orphan_categorizations: :environment do
-        logger = Logger.new($stdout)
-        logger.info("Removing orphan categorizations...")
+      desc "Removes any categorizations belonging to invalid resources"
+      task categories: :environment do
+        logger.info("=== Removing orphan categorizations...")
+        invalid = 0
 
         Decidim::Categorization.find_each do |categorization|
-          categorization.destroy if categorization.categorizable.nil?
+          next unless categorization.categorizable.nil?
+
+          invalid += 1
+          categorization.destroy
+        rescue NameError
+          categorization.destroy!
+          invalid += 1
         end
+        logger.info("===== Deleted #{invalid} invalid resources")
       end
 
       desc "Update all blocked users notifications_sending_frequency setting"
       task fix_blocked_user_notification: :environment do
         logger.info("=== Updating all blocked users notifications_sending_frequency ...")
         blocked_users = 0
-        Decidim::User.blocked.where.not("notifications_sending_frequency = ?", "none").find_each do |blocked_user|
+        Decidim::User.blocked.where.not(notifications_sending_frequency: :none).find_each do |blocked_user|
           unless blocked_user.notifications_sending_frequency == "none"
             blocked_user.update(notifications_sending_frequency: "none")
             blocked_users += 1

data/lib/tasks/upgrade/clean_hidden_resources.rake

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+namespace :decidim do
+  namespace :upgrade do
+    namespace :clean do
+      desc "Removes all related resources from hidden resource"
+      task hidden_resources: :environment do
+        logger.info("Removing child resources for hidden parents...")
+        Decidim::Moderation.hidden.find_each do |moderation_for_hidden_resource|
+          reportable = moderation_for_hidden_resource.reportable
+
+          current_user = if Decidim.module_installed?(:ai)
+                           reportable.organization.users.find_by!(email: Decidim::Ai::SpamDetection.reporting_user_email)
+                         else
+                           reportable.organization.admins.first
+                         end
+
+          tool = Decidim::ModerationTools.new(reportable, current_user)
+          tool.hide!
+        rescue NameError => e
+          log_error "Could not hide child resources for reportable id #{moderation_for_hidden_resource.id} because: #{e.message}"
+        end
+      end
+
+      private
+
+      def log_error(msg)
+        puts msg
+        Rails.logger.error(msg)
+      end
+    end
+  end
+end

data/lib/tasks/upgrade/decidim_active_storage_migration_tasks.rake

@@ -7,7 +7,7 @@ namespace :decidim do
       task :migrate_inline_images_to_active_storage, [:admin_email] => :environment do |_t, args|
         user = Decidim::User.find_by(email: args[:admin_email])
 
-        raise "Invalid admin. Please, provide the email of an admin with permissions to create editor images" unless user&.admin? && user&.admin_terms_accepted?
+        raise "Invalid admin. Please, provide the email of an admin with permissions to create editor images" unless user&.admin? && user.admin_terms_accepted?
 
         inline_images_available_attributes.each do |model, attributes|
           puts "=== Updating model #{model.name} (attributes: #{attributes.join(", ")})..."

data/lib/tasks/upgrade/migrations.rake

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+namespace :decidim do
+  namespace :upgrade do
+    desc "Replace legacy migration content"
+    task migrations: :environment do
+      available_modules = {
+        "accountability" => "Accountability",
+        "admin" => "Admin",
+        "ai" => "Ai",
+        "api" => "Api",
+        "assemblies" => "Assemblies",
+        "blogs" => "Blogs",
+        "budgets" => "Budgets",
+        "comments" => "Comments",
+        "conferences" => "Conferences",
+        "core" => "Core",
+        "debates" => "Debates",
+        "design" => "Design",
+        "dev" => "Dev",
+        "forms" => "Forms",
+        "initiatives" => "Initiatives",
+        "meetings" => "Meetings",
+        "pages" => "Pages",
+        "participatory_processes" => "ParticipatoryProcesses",
+        "proposals" => "Proposals",
+        "sortitions" => "Sortitions",
+        "surveys" => "Surveys",
+        "system" => "System",
+        "templates" => "Templates",
+        "verifications" => "Verifications"
+      }
+
+      available_modules.each do |key, value|
+        next unless Decidim.module_installed?(key.to_sym)
+
+        migration_files = Dir["Decidim::#{value}::Engine".constantize.root.join("db/migrate/*.rb")]
+        next if migration_files.blank?
+
+        migration_files.each do |file|
+          next if file.include?("active_storage")
+
+          replace_content(file)
+        end
+      end
+    end
+
+    private
+
+    def replace_content(file_path)
+      migration_file = File.basename(file_path)
+      version = migration_file.split("_").first
+      migration_file_base = migration_file.gsub!(/^\d+_/, "").gsub!(/\.rb$/, "")
+
+      target_file = Rails.root.glob("db/migrate/**_#{migration_file_base}.*.rb").first
+      return if target_file.blank?
+
+      scope = target_file.to_s.split(".")[-2]
+
+      source = File.binread(file_path)
+
+      # This has been extracted from activerecord file lib/active_record/migration.rb
+      inserted_comment = "# This migration comes from #{scope} (originally #{version})\n"
+      magic_comments = +""
+      loop do
+        source.sub!(/\A(?:#.*\b(?:en)?coding:\s*\S+|#\s*frozen_string_literal:\s*(?:true|false)).*\n/) do |magic_comment|
+          magic_comments << magic_comment
+          ""
+        end || break
+      end
+
+      if !magic_comments.empty? && source.start_with?("\n")
+        magic_comments << "\n"
+        source = source[1..-1]
+      end
+
+      new_source = "#{magic_comments}#{inserted_comment}#{source}"
+      old_source = File.binread(target_file)
+
+      return if old_source == new_source
+
+      logger.warn("[Patch migration] Replacing content of #{File.basename(target_file)}")
+
+      additional_comment = "# This file has been modified by `decidim upgrade:migrations` task on #{Time.now.utc}\n"
+      source = new_source.gsub(inserted_comment, "#{inserted_comment}#{additional_comment}")
+
+      File.binwrite(target_file, source)
+    end
+
+    def logger
+      @logger ||= Logger.new($stdout)
+    end
+  end
+end