decidim-core 0.29.2 → 0.30.0.rc1

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -38,7 +38,7 @@ shared_examples "comments" do
     expect(page).to have_css(".comment", minimum: 1)
 
     within ".comment-order-by" do
-      click_on "Best rated"
+      select "Best rated", from: "order"
     end
 
     expect(page).to have_css(".comments > div:nth-child(2)", text: "Most Rated Comment")
@@ -54,7 +54,7 @@ shared_examples "comments" do
       expect(page).to have_css(".comment", minimum: 1)
 
       within("#accordion-#{single_comment.id}") do
-        expect(page).to have_content "Hide reply"
+        expect(page).to have_content "1 answer"
       end
     end
 
@@ -120,6 +120,24 @@ shared_examples "comments" do
       expect(page).to have_no_css(".add-comment form")
       expect(page).to have_css(".comment-thread")
     end
+
+    context "when user visit a mobile browser" do
+      before do
+        driven_by(:iphone)
+        switch_to_host(organization.host)
+        visit decidim.root_path
+        click_on "Accept all"
+        visit resource_path
+      end
+
+      it "does not show the add comment button" do
+        expect(page).to have_no_content("Add comment")
+      end
+
+      it "shows a message so user can Log in or create an account" do
+        expect(page).to have_content("Log in or create an account to add your comment.")
+      end
+    end
   end
 
   context "when authenticated" do
@@ -132,6 +150,62 @@ shared_examples "comments" do
       expect(page).to have_css(".add-comment form")
     end
 
+    context "when user visit a computer browser" do
+      before do
+        switch_to_host(organization.host)
+        visit decidim.root_path
+        login_as user, scope: :user
+        visit resource_path
+      end
+
+      it "does not show a modal with form to add comments" do
+        expect(page).to have_no_css(".fullscreen")
+      end
+
+      it "does not show the add comment button" do
+        expect(page).to have_no_content("Add comment")
+      end
+
+      it "allows user to comment" do
+        find("textarea[name='comment[body]']").set("Test comment with a computer.")
+        click_on "Publish comment"
+        expect(page).to have_content("Test comment with a computer.")
+      end
+    end
+
+    context "when user visit a mobile browser" do
+      before do
+        driven_by(:iphone)
+        switch_to_host(organization.host)
+        visit decidim.root_path
+        click_on "Accept all"
+        login_as user, scope: :user
+        visit resource_path
+      end
+
+      it "shows the add comment button" do
+        expect(page).to have_content("Add comment")
+      end
+
+      it "does not show a message so user can Log in or create an account" do
+        expect(page).to have_no_content("Log in or create an account to add your comment.")
+      end
+
+      it "shows a modal with the comment form" do
+        sleep 1
+        click_on "Add comment"
+        sleep 1
+        expect(page).to have_content("Add comment")
+        expect(page).to have_content("1000 characters left")
+        expect(page).to have_css(".add-comment form")
+        expect(page).to have_css(".fullscreen")
+
+        find("textarea[name='comment[body]']").set("Test comment with a mobile phone.")
+        click_on "Publish comment"
+        expect(page).to have_content("Test comment with a mobile phone.")
+      end
+    end
+
     context "when user is not authorized to comment" do
       let(:permissions) do
         {
@@ -560,19 +634,29 @@ shared_examples "comments" do
         let(:new_reply_body) { "Hey, I just jumped inside the thread!" }
         let!(:new_reply) { create(:comment, commentable: thread, root_commentable: commentable, body: new_reply_body) }
 
-        it "displays the hide button" do
+        it "displays a way to to display content" do
           visit current_path
           within "#comment_#{thread.id}" do
-            expect(page).to have_content("Hide reply")
+            expect(page).to have_content("1 answer")
+            click_on "1 answer"
             expect(page).to have_content(new_reply_body)
+            click_on "Reply", match: :first
+            expect(page).to have_content("Publish reply")
+            find("textarea[name='comment[body]']").set("Test reply comments.")
+            click_on "Publish reply"
+            expect(page).to have_content("Show 2 replies")
+            click_on "Show 2 replies"
+            expect(page).to have_content("Test reply comments.")
           end
         end
 
-        it "displays the show button" do
+        it "displays a way hide content" do
           visit current_path
           within "#comment_#{thread.id}" do
-            click_on "Hide reply"
-            expect(page).to have_content("Show reply")
+            expect(page).to have_content("1 answer")
+            click_on "1 answer"
+            expect(page).to have_content("1 answer")
+            click_on "1 answer"
             expect(page).to have_no_content(new_reply_body)
           end
         end
@@ -583,9 +667,10 @@ shared_examples "comments" do
           it "displays the show button" do
             visit current_path
             within "#comment_#{thread.id}" do
-              click_on "Hide 3 replies"
-              expect(page).to have_content("Show 3 replies")
+              expect(page).to have_content("3 answers")
               expect(page).to have_no_content(new_reply_body)
+              click_on "3 answers"
+              expect(page).to have_content(new_reply_body)
             end
           end
         end
@@ -633,7 +718,6 @@ shared_examples "comments" do
           field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
           field.set " "
           field.native.send_keys content
-          select user_group.name, from: "Comment as"
           click_on "Publish comment"
         end
 
@@ -815,29 +899,6 @@ shared_examples "comments" do
 
           expect(page).to have_css(".add-comment form")
         end
-
-        it "works according to the setting in the commentable" do
-          if commentable.comments_have_alignment?
-            page.find("[data-toggle-ok=true]").click
-            expect(page.find("[data-toggle-ok=true]")["aria-pressed"]).to eq("true")
-            expect(page.find("[data-toggle-meh=true]")["aria-pressed"]).to eq("false")
-            expect(page.find("[data-toggle-ko=true]")["aria-pressed"]).to eq("false")
-            expect(page.find("div[data-opinion-toggle] .selected-state", visible: false)).to have_content("Your opinion about this topic is positive")
-
-            within "form#new_comment_for_#{commentable.commentable_type.demodulize}_#{commentable.id}" do
-              field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
-              field.set " "
-              field.native.send_keys "I am in favor about this!"
-              click_on "Publish comment"
-            end
-
-            within "#comments" do
-              expect(page).to have_css "span.success.label", text: "In favor", wait: 20
-            end
-          else
-            expect(page).to have_no_css("[data-toggle-ok=true]")
-          end
-        end
       end
     end
 
@@ -866,10 +927,11 @@ shared_examples "comments" do
             skip "Commentable comments has no votes" unless commentable.comments_have_votes?
 
             visit current_path
-            expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/)
+            expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/, visible: :all)
             page.find("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up").click
-            expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /1/)
-            expect(page).to have_css("#comment_#{comment_on_comment.id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/)
+            expect(page).to have_css("#comment_#{comments[0].id} > [data-comment-footer] > .comment__footer-grid .comment__votes .js-comment__votes--up", text: /1/, visible: :all)
+            expect(page).to have_css("#comment_#{comment_on_comment.id} > [data-comment-footer] >.comment__footer-grid .comment__votes .js-comment__votes--up", text: /0/,
+                                                                                                                                                                visible: :all)
           end
         end
       end
@@ -1038,7 +1100,7 @@ shared_examples "comments blocked" do
 
       it "shows a message indicating that comments are disabled" do
         visit resource_path
-        expect(page).to have_content("Comments are disabled at this time")
+        expect(page).to have_content("Comments are currently disabled, only administrators can reply or post new ones.")
         expect(page).to have_no_content("You need to be verified to comment at this moment")
       end
     end
@@ -1053,6 +1115,26 @@ shared_examples "comments blocked" do
       visit resource_path
     end
 
+    shared_examples "can answer comments" do
+      it "can answer" do
+        visit resource_path
+        expect(page).to have_link("Comment")
+        page.find("a", text: "Comment").click
+        find("textarea[name='comment[body]']").set("Test admin commenting in a closed comment.")
+        click_on "Publish comment"
+        expect(page).to have_content("Test admin commenting in a closed comment.")
+
+        expect(page).to have_button("Reply")
+        first("button", text: "Reply").click
+        expect(page).to have_css(".comment-thread")
+        within first(".comment-thread") do
+          find("textarea[name='comment[body]']").set("Test admin replying a closed comment.")
+          click_on "Publish reply"
+        end
+        expect(page).to have_content("Test admin replying a closed comment.")
+      end
+    end
+
     context "when comments are blocked" do
       let(:active_step_id) { component.participatory_space.active_step.id }
 
@@ -1062,9 +1144,282 @@ shared_examples "comments blocked" do
 
       it "shows a message indicating that comments are disabled" do
         visit resource_path
-        expect(page).to have_content("Comments are disabled at this time")
+        expect(page).to have_content("Comments are currently disabled, only administrators can reply or post new ones.")
         expect(page).to have_no_content("You need to be verified to comment at this moment")
       end
+
+      context "when the user is an administrator" do
+        let!(:user) { create(:user, :admin, :confirmed, organization:) }
+
+        it_behaves_like "can answer comments"
+      end
+
+      context "when the user has a role of user manager" do
+        let!(:user) { create(:user, :user_manager, :confirmed, organization:) }
+
+        it_behaves_like "can answer comments"
+      end
+
+      context "when the user has an evaluator role in the same participatory space" do
+        let!(:valuator_role) { create(:participatory_process_user_role, role: :valuator, user:, participatory_process: participatory_space) }
+
+        it_behaves_like "can answer comments"
+      end
+
+      shared_examples "evaluator role in different participatory space" do |space_type|
+        let!(:another_space_valuator_role) do
+          create(:"#{space_type}_user_role", role: :valuator, user:, "#{space_type}": create(space_type, organization:))
+        end
+
+        it "cannot answer" do
+          visit resource_path
+          expect(page).to have_content("Comments are currently disabled, only administrators can reply or post new ones.")
+          expect(page).to have_no_content("You need to be verified to comment at this moment")
+          expect(page).to have_no_css("textarea#add-comment-Proposal-1")
+        end
+      end
+
+      context "when the user has an evaluator role in a different participatory space" do
+        include_examples "evaluator role in different participatory space", :participatory_process
+        include_examples "evaluator role in different participatory space", :conference
+        include_examples "evaluator role in different participatory space", :assembly
+      end
+    end
+  end
+end
+
+shared_examples "comments with two columns" do
+  let!(:user) { create(:user, :confirmed, organization:) }
+
+  before do
+    login_as user, scope: :user
+  end
+
+  context "displays comments list in two columns" do
+    let!(:comments_in_favor) { create_list(:comment, 2, :in_favor, commentable:) }
+    let!(:comments_against) { create_list(:comment, 1, :against, commentable:) }
+
+    it "shows the list of comments for the resource" do
+      visit resource_path
+
+      expect(page).to have_css("#comments")
+      expect(page).to have_css(".comment", count: comments.length)
+
+      within(".comments-two-columns") do
+        check_comments_order(".comments-section__in-favor", comments_in_favor)
+        check_comments_order(".comments-section__against", comments_against)
+      end
+    end
+  end
+
+  context "in mobile view" do
+    it "shows kebab menu functionality" do
+      resize_window_to_mobile
+      visit resource_path
+
+      within "#comment_#{comments.first.id}" do
+        page.find("[id^='dropdown-trigger']").click
+        expect(page).to have_css("ul.dropdown.dropdown__bottom", visible: :visible)
+      end
+
+      resize_window_to_desktop
+    end
+
+    context "when commentable is closed" do
+      let!(:commentable) { closed_commentable }
+      let!(:highest_voted_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 2.days.ago, up_votes_count: 15) }
+      let!(:high_voted_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 4.days.ago, up_votes_count: 10) }
+      let!(:older_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 3.days.ago, up_votes_count: 5) }
+
+      let!(:highest_voted_comment_against) { create(:comment, :against, commentable:, created_at: 2.days.ago, up_votes_count: 12) }
+      let!(:high_voted_comment_against) { create(:comment, :against, commentable:, created_at: 5.days.ago, up_votes_count: 8) }
+      let!(:older_comment_against) { create(:comment, :against, commentable:, created_at: 3.days.ago, up_votes_count: 4) }
+
+      it "shows comments with top comments at the beginning and interleaved order after" do
+        resize_window_to_mobile
+        visit resource_path
+
+        within(".comment-threads") do
+          interleaved_comments = [
+            highest_voted_comment_in_favor,
+            highest_voted_comment_against,
+            high_voted_comment_in_favor,
+            high_voted_comment_against,
+            older_comment_in_favor,
+            older_comment_against
+          ]
+
+          all_comments = all(".comment-thread")
+
+          interleaved_comments.each_with_index do |comment, index|
+            expect(all_comments[index]).to have_content(comment.body["en"])
+          end
+
+          expect(page).to have_css(".most-upvoted-label", text: "Most upvoted", count: 2)
+        end
+
+        resize_window_to_desktop
+      end
+    end
+  end
+
+  context "when viewing a single comment" do
+    let!(:single_comment) { create(:comment, commentable:, body: { "en" => "This is a single comment" }) }
+
+    before do
+      visit "#{resource_locator(commentable).path}?commentId=#{single_comment.id}"
+    end
+
+    it "displays only the single comment without columns" do
+      expect(page).to have_css("#comments")
+      expect(page).to have_css(".comment-thread", count: 1)
+      expect(page).to have_content("This is a single comment")
+      expect(page).to have_no_css(".comments-two-columns")
+      expect(page).to have_no_content("In Favor")
+      expect(page).to have_no_content("Against")
+      expect(page).to have_no_content("You are viewing only one comment")
+    end
+  end
+
+  context "when commentable is not closed" do
+    let!(:oldest_in_favor_comment) { create(:comment, :in_favor, commentable:, created_at: 3.days.ago) }
+    let!(:older_in_favor_comment) { create(:comment, :in_favor, commentable:, created_at: 2.days.ago) }
+    let!(:oldest_against_comment) { create(:comment, :against, commentable:, created_at: 4.days.ago) }
+    let!(:newer_against_comment) { create(:comment, :against, commentable:, created_at: 1.day.ago) }
+
+    it "shows the comments in two columns sorted by creation date in ascending order" do
+      visit resource_path
+
+      within(".comments-two-columns") do
+        check_comments_order(".comments-section__in-favor", [oldest_in_favor_comment, older_in_favor_comment])
+        check_comments_order(".comments-section__against", [oldest_against_comment, newer_against_comment])
+      end
+    end
+
+    it "allows the user to add a new comment at the end of the respective column" do
+      visit resource_path
+
+      add_new_comment("In favor", "This is a new comment in favor")
+
+      within(".comments-section__in-favor") do
+        expect(page).to have_content("This is a new comment in favor")
+      end
+    end
+
+    it "disables the publish button until 'in favor' or 'against' is selected" do
+      visit resource_path
+
+      expect(page).to have_button("Publish comment", disabled: true)
+
+      within(".comment__opinion-container") do
+        click_on "In favor"
+      end
+
+      within "form#new_comment_for_#{commentable.commentable_type.demodulize}_#{commentable.id}" do
+        fill_in_comment_field("This is a new comment in favor")
+        click_on "Publish comment"
+      end
+    end
+
+    it "shows comments sorted by creation date when viewed on a small screen" do
+      resize_window_to_mobile
+      visit resource_path
+
+      within(".comment-threads") do
+        comments = all(".comment-thread")
+
+        expect(comments[0]).to have_content(oldest_in_favor_comment.body["en"])
+        expect(comments[1]).to have_content(oldest_against_comment.body["en"])
+        expect(comments[2]).to have_content(older_in_favor_comment.body["en"])
+        expect(comments[3]).to have_content(newer_against_comment.body["en"])
+      end
+
+      resize_window_to_desktop
+    end
+  end
+
+  context "when commentable is closed" do
+    let!(:commentable) { closed_commentable }
+    let!(:highest_voted_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 2.days.ago, up_votes_count: 15) }
+    let!(:high_voted_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 4.days.ago, up_votes_count: 10) }
+    let!(:older_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 3.days.ago, up_votes_count: 5) }
+    let!(:recent_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 2.days.ago, up_votes_count: 3) }
+    let!(:latest_comment_in_favor) { create(:comment, :in_favor, commentable:, created_at: 1.day.ago, up_votes_count: 1) }
+
+    let!(:highest_voted_comment_against) { create(:comment, :against, commentable:, created_at: 2.days.ago, up_votes_count: 12) }
+    let!(:high_voted_comment_against) { create(:comment, :against, commentable:, created_at: 5.days.ago, up_votes_count: 8) }
+    let!(:older_comment_against) { create(:comment, :against, commentable:, created_at: 3.days.ago, up_votes_count: 4) }
+    let!(:recent_comment_against) { create(:comment, :against, commentable:, created_at: 2.days.ago, up_votes_count: 2) }
+    let!(:latest_comment_against) { create(:comment, :against, commentable:, created_at: 1.day.ago, up_votes_count: 1) }
+
+    before do
+      visit resource_path
+    end
+
+    it "shows the top voted comments at the top of each column, followed by comments in ascending chronological order" do
+      within(".comments-two-columns") do
+        check_comments_order(".comments-section__in-favor", [
+                               highest_voted_comment_in_favor,
+                               high_voted_comment_in_favor,
+                               older_comment_in_favor,
+                               recent_comment_in_favor,
+                               latest_comment_in_favor
+                             ])
+
+        check_comments_order(".comments-section__against", [
+                               highest_voted_comment_against,
+                               high_voted_comment_against,
+                               older_comment_against,
+                               recent_comment_against,
+                               latest_comment_against
+                             ])
+      end
     end
+
+    it "shows the top voted comments with label at the top of each column" do
+      within(".comments-two-columns") do
+        within(".comments-section__in-favor") do
+          expect(page).to have_css(".most-upvoted-label", text: "Most upvoted")
+          expect(page).to have_content(highest_voted_comment_in_favor.body["en"])
+        end
+
+        within(".comments-section__against") do
+          expect(page).to have_css(".most-upvoted-label", text: "Most upvoted")
+          expect(page).to have_content(highest_voted_comment_against.body["en"])
+        end
+      end
+    end
+  end
+
+  def check_comments_order(section_selector, comments)
+    comments_section = all("#{section_selector} .comment-thread")
+    comments.each_with_index do |comment, index|
+      expect(comments_section[index]).to have_content(comment.body["en"])
+    end
+  end
+
+  def add_new_comment(opinion, comment_text)
+    within(".comment__opinion-container") do
+      click_on opinion
+    end
+
+    within "form#new_comment_for_#{commentable.commentable_type.demodulize}_#{commentable.id}" do
+      fill_in_comment_field(comment_text)
+      click_on "Publish comment"
+    end
+  end
+
+  def fill_in_comment_field(comment_text)
+    field = find("#add-comment-#{commentable.commentable_type.demodulize}-#{commentable.id}")
+    field.set " "
+    field.native.send_keys comment_text
+  end
+
+  def resize_window_to_mobile
+    page.driver.browser.manage.window.resize_to(375, 667)
+  end
+
+  def resize_window_to_desktop
+    page.driver.browser.manage.window.resize_to(1920, 1080)
   end
 end

data/lib/decidim/core/test/shared_examples/components_controller_hide_shared_examples.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+shared_examples_for "a components controller to hide" do |params|
+  describe "PUT hide" do
+    it "hides the components" do
+      put :hide, params: { "#{params[:slug_attribute]}": space.slug, id: component.id }
+
+      expect(component.reload.visible).to eq(false)
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/components_controller_reorder_shared_examples.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+shared_examples_for "a reorder components controller" do |params|
+  describe "PUT reorder" do
+    let(:other_component) do
+      create(
+        :component,
+        manifest_name: :dummy,
+        participatory_space: space
+      )
+    end
+
+    it "reorders the components" do
+      expect([component.id, other_component.id]).to eq(space.components.pluck(:id))
+
+      put :reorder, params: { "#{params[:slug_attribute]}": space.slug, order_ids: [other_component.id, component.id] }
+
+      expect([other_component.id, component.id]).to eq(space.components.pluck(:id))
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/download_open_data_shared_context.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+RSpec.shared_context "when downloading open data files" do
+  # Workaround to ignore Bullet warnings in these examples, until we found a way to actually fix these issues
+  before do
+    Bullet.n_plus_one_query_enable = false
+    Bullet.unused_eager_loading_enable = false
+  end
+
+  after do
+    Bullet.n_plus_one_query_enable = Decidim::Env.new("DECIDIM_BULLET_N_PLUS_ONE", "false").present?
+    Bullet.unused_eager_loading_enable = Decidim::Env.new("DECIDIM_BULLET_UNUSED_EAGER", "false").present?
+  end
+
+  def download_open_data_file
+    # Prevent using the same cached file
+    open_data_file = Rails.root.join("tmp/#{organization.open_data_file_path}")
+    FileUtils.rm_f(open_data_file)
+    Decidim::OpenDataJob.perform_now(organization)
+
+    switch_to_host(organization.host)
+    visit decidim.root_path
+
+    click_on "Open Data"
+    click_on "Download all the Open Data files"
+  end
+
+  def extract_content_from_zip(download_path, file_name)
+    Zip::File.open(download_path) do |zipfile|
+      entry = zipfile.select { |an_entry| an_entry.name.match?(/.*#{file_name}/) }.first
+      content = entry.get_input_stream.read
+
+      return content
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/download_open_data_shared_examples.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require "decidim/core/test/shared_examples/download_open_data_shared_context"
+
+RSpec.shared_examples "includes it in the open data ZIP file" do
+  include_context "when downloading open data files"
+
+  it do
+    download_open_data_file
+    content = extract_content_from_zip(download_path, file_name)
+    expect(content).to include(resource_title)
+  end
+end
+
+RSpec.shared_examples "does not include it in the open data ZIP file" do
+  include_context "when downloading open data files"
+
+  it do
+    download_open_data_file
+    content = extract_content_from_zip(download_path, file_name)
+    expect(content).not_to include(resource_title)
+  end
+end
+
+RSpec.shared_examples "includes it in the open data CSV file" do
+  def download_open_data_csv_file(resource_type)
+    open_data_file = Rails.root.join("tmp/#{organization.open_data_file_path(resource_type)}")
+    FileUtils.rm_f(open_data_file)
+    Decidim::OpenDataJob.perform_now(organization, resource_type)
+  end
+
+  it do
+    download_open_data_csv_file(resource_type)
+
+    switch_to_host(organization.host)
+    visit decidim.root_path
+    click_on "Open Data"
+
+    expect(page).to have_content("What are these files?")
+    click_on "Download #{resource_type} in CSV format"
+
+    expect(File.basename(download_path)).to include("#{resource_type}.csv")
+    expect(File.read(download_path)).to include(resource_title)
+  end
+end

data/lib/decidim/core/test/shared_examples/download_your_data_shared_examples.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+shared_examples_for "a download your data entity" do
+  let(:data) { subject.send(:readme) }
+
+  before do
+    subject.send(:data_and_attachments_for_user) # to create the data and get the help definitions
+  end
+
+  it "does not have any missing translation" do
+    expect(data).not_to include("Translation missing"), data
+  end
+
+  it "has the correct help definition" do
+    expect(data).to include(help_definition_string)
+  end
+end

data/lib/decidim/core/test/shared_examples/etiquette_validator_examples.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+shared_examples "etiquette validator" do |options|
+  options[:fields].map(&:to_sym).each do |field|
+    let!(field) { options[:i18n] ? { en: string } : string }
+
+    context "when #{field} contains too many caps" do
+      let(:string) { "#{"A" * 50}#{"a" * 49}" }
+
+      it { is_expected.to be_invalid }
+    end
+
+    context "when #{field} not starting with caps" do
+      let(:string) { "aa#{"A" * 50}#{"a" * 49}" }
+
+      it { is_expected.to be_invalid }
+    end
+
+    context "when #{field} containing too many marks" do
+      let(:string) { "#{"A" * 5}#{"a" * 49}!!??" }
+
+      it { is_expected.to be_invalid }
+    end
+  end
+end