decidim-core 0.29.0.rc4 → 0.29.0

data/db/migrate/20181025082245_add_timestamps_to_components.rb

@@ -1,10 +1,14 @@
 # frozen_string_literal: true
 
 class AddTimestampsToComponents < ActiveRecord::Migration[5.2]
+  class Component < ApplicationRecord
+    self.table_name = :decidim_components
+  end
+
   def change
     add_timestamps :decidim_components, null: true
     # rubocop:disable Rails/SkipsModelValidations
-    Decidim::Component.update_all(created_at: Time.current, updated_at: Time.current)
+    Component.update_all(created_at: Time.current, updated_at: Time.current)
     # rubocop:enable Rails/SkipsModelValidations
     change_column_null :decidim_components, :created_at, false
     change_column_null :decidim_components, :updated_at, false

data/lib/decidim/core/test/shared_examples/follows_examples.rb

@@ -1,7 +1,12 @@
 # frozen_string_literal: true
 
-shared_examples "follows" do
+# When using these shared examples, make sure there are no prior requests within
+# the same group of examples where this is included. Otherwise you may end up
+# in race conditions that cause these to fail as explained at:
+# https://github.com/decidim/decidim/pull/6161
+shared_examples "followable content for users" do
   before do
+    switch_to_host(organization.host)
     login_as user, scope: :user
   end
 
@@ -34,9 +39,9 @@ shared_examples "follows" do
   end
 end
 
-shared_examples "follows with a component" do
+shared_examples "followable content for users with a component" do
   include_context "with a component"
-  include_examples "follows"
+  include_examples "followable content for users"
 
   context "when the user is following the followable's participatory space" do
     before do

data/lib/decidim/core/test/shared_examples/paginated_resource_examples.rb

@@ -1,22 +1,22 @@
 # frozen_string_literal: true
 
 shared_examples "a paginated resource" do
-  let(:collection_size) { 30 }
+  let(:collection_size) { 50 }
 
   before do
     visit_component
   end
 
-  it "lists 10 resources per page by default" do
-    expect(page).to have_css(resource_selector, count: 10)
-    expect(page).to have_css("[data-pages] [data-page]", count: 3)
+  it "lists 25 resources per page by default" do
+    expect(page).to have_css(resource_selector, count: 25)
+    expect(page).to have_css("[data-pages] [data-page]", count: 2)
   end
 
   it "results per page can be changed from the selector" do
     expect(page).to have_css("[data-pagination]")
 
     within "[data-pagination]" do
-      page.find("summary", text: "10").click
+      page.find("summary", text: "25").click
       click_on "50"
     end
 

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.29.0.rc4"
+      "0.29.0"
     end
   end
 end

data/lib/tasks/upgrade/decidim_fix_categorization.rake

@@ -2,6 +2,106 @@
 
 namespace :decidim do
   namespace :upgrade do
+    namespace :clean do
+      desc "Removes all the invalid records from search, notifications, follows and action_logs"
+      task invalid_records: [
+        :"decidim:upgrade:clean:searchable_resources",
+        :"decidim:upgrade:clean:notifications",
+        :"decidim:upgrade:clean:follows",
+        :"decidim:upgrade:clean:action_logs"
+      ]
+
+      desc "Removes any action logs belonging to invalid resources"
+      task :action_logs, [] => :environment do
+        puts "=== Deleting Action logs\n"
+        invalid = 0
+        Decidim::ActionLog.find_each do |log|
+          log.participatory_space if log.participatory_space_type.present?
+          log.resource if log.resource_type.present?
+
+          if log.resource_type == "Decidim::Component" && log.resource.blank?
+            log.delete
+            invalid += 1
+          end
+
+          next if log.decidim_component_id.blank?
+          next if log.component.present?
+
+          log.delete
+          invalid += 1
+        rescue NameError
+          log.delete
+          invalid += 1
+        end
+        puts "===== Deleted #{invalid} invalid action logs\n"
+      end
+
+      desc "Removes any follows belonging to invalid resources"
+      task :follows, [] => :environment do
+        puts "=== Deleting Follows\n"
+        invalid = 0
+        Decidim::Follow.find_each do |follow|
+          follow.followable
+
+          next unless follow.followable.respond_to?(:component)
+          next if follow.followable.component.present?
+
+          # We attempt to remove any of the follows that refer to spaces or components that disappeared
+          follow.destroy
+          invalid += 1
+        rescue NameError
+          # We use delete as we do not want to call the hooks
+          follow.delete
+          invalid += 1
+        end
+        puts "===== Deleted #{invalid} invalid follows\n"
+      end
+
+      desc "Removes any notifications belonging to invalid resources"
+      task :notifications, [] => :environment do
+        puts "=== Deleting Notification\n"
+        invalid = 0
+        Decidim::Notification.find_each do |notification|
+          # Check if the resource class still exists
+          notification.resource
+          # Check if the event class still exists
+          notification.event_class_instance
+        rescue NameError
+          notification.destroy
+          invalid += 1
+        end
+        puts "===== Deleted #{invalid} invalid notifications\n"
+      end
+
+      desc "Removes any resources from search index that do not exist"
+      task :searchable_resources, [] => :environment do
+        puts "=== Deleting Searchable results\n"
+        puts "==== Deleting invalid spaces \n"
+        invalid = 0
+        Decidim::SearchableResource.where.not(decidim_participatory_space_type: nil).find_each do |search|
+          search.decidim_participatory_space
+        rescue NameError
+          search.destroy!
+          invalid += 1
+        end
+        puts "===== Deleted #{invalid} invalid spaces\n"
+
+        puts "==== Deleting invalid resources from search index \n"
+        invalid = 0
+        Decidim::SearchableResource.find_each do |search|
+          next unless search.resource.respond_to?(:component)
+          next if search.resource.component.present?
+
+          search.destroy
+          invalid += 1
+        rescue NameError
+          search.destroy!
+          invalid += 1
+        end
+        puts "===== Deleted #{invalid} invalid resources\n"
+      end
+    end
+
     desc "Removes orphan categorizations"
     task fix_orphan_categorizations: :environment do
       logger = Logger.new($stdout)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-core
 version: !ruby/object:Gem::Version
-  version: 0.29.0.rc4
+  version: 0.29.0
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-30 00:00:00.000000000 Z
+date: 2024-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_link_to
@@ -758,28 +758,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.29.0.rc4
+        version: 0.29.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.29.0.rc4
+        version: 0.29.0
 - !ruby/object:Gem::Dependency
   name: decidim-dev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.29.0.rc4
+        version: 0.29.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.29.0.rc4
+        version: 0.29.0
 description: Adds core features so other engines can hook into the framework.
 email:
 - josepjaume@gmail.com
@@ -2994,9 +2994,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.4.10
 signing_key: