decidim-core 0.27.0.rc1 → 0.27.0.rc2

data/config/locales/lv.yml

@@ -1278,15 +1278,6 @@ lv:
       updated_not_active: Jūsu parole ir veiksmīgi nomainīta.
     registrations:
       destroyed: Jūsu konts ir veiksmīgi atcelts. Mēs ceram jūs drīz atkal redzēt.
-      edit:
-        are_you_sure: Vai esat pārliecināts?
-        cancel_my_account: Atcelt manu kontu
-        currently_waiting_confirmation_for_email: 'Pašlaik tiek gaidīts apstiprinājums e-pastam: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: atstājiet tukšu, ja nevēlaties to mainīt
-        title: Labot %{resource}
-        unhappy: Neesat apmierināts?
-        update: Atjaunināt
-        we_need_your_current_password_to_confirm_your_changes: mums ir nepieciešama jūsu pašreizējā parole, lai apstiprinātu izmaiņas
       new:
         sign_up: Reģistrēties
       signed_up: Laipni lūdzam! Jūsu reģistrācija bija veiksmīga.

data/config/locales/mt.yml

@@ -1,2 +1 @@
----
 mt:

data/config/locales/nl.yml

@@ -1480,15 +1480,6 @@ nl:
       updated_not_active: Je wachtwoord is met succes veranderd.
     registrations:
       destroyed: Uw account is succesvol geannuleerd. We hopen je snel weer te zien.
-      edit:
-        are_you_sure: Weet je het zeker?
-        cancel_my_account: Annuleer mijn account
-        currently_waiting_confirmation_for_email: 'Momenteel wachtende bevestiging voor: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: laat leeg als je het niet wilt wijzigen
-        title: Bewerk %{resource}
-        unhappy: Ongelukkig?
-        update: Bijwerken
-        we_need_your_current_password_to_confirm_your_changes: we hebben je huidige wachtwoord nodig om je wijzigingen te bevestigen
       new:
         sign_up: Aanmelden
       signed_up: Welkom! Je hebt je succesvol aangemeld.
@@ -1557,6 +1548,21 @@ nl:
     timestamp_error_message: Sorry, dat was te snel! Gelieve opnieuw in te dienen.
   layouts:
     decidim:
+      data_consent:
+        details:
+          columns:
+            description: Beschrijving
+            name: Naam
+            type: Type
+          items:
+            pwaInstallPromptSeen:
+              description: Bewaart de status als de progressieve webapplicatie (PWA) installatiemelding al gezien is door de gebruiker.
+          types:
+            local_storage: Lokale opslag
+        modal:
+          analytics:
+            description: Deze cookies worden gebruikt om het gebruik van de website te meten en te analyseren en zo de website te verbeteren.
+          description: We gebruiken cookies om de basisfunctionaliteiten van de website te garanderen en jouw online-ervaring te verbeteren. Je kunt op elk gewenst moment het gebruik van de cookies configureren en accepteren of je toestemmingsopties wijzigen.
       edit_link:
         edit: Bewerk
       footer:
@@ -1610,7 +1616,7 @@ nl:
         see_more: Zie meer
   locale:
     name: Nederlands
-    name_with_error: Engels (fout!)
+    name_with_error: Nederlands (fout!)
   password_validator:
     blacklisted: staat op de zwarte lijst
     domain_included_in_password: lijkt te veel op deze domeinnaam

data/config/locales/no.yml

@@ -1526,15 +1526,6 @@
       updated_not_active: Passordet ditt er blitt endret.
     registrations:
       destroyed: Din konto er lukket. Vi håper å se deg igjen snart.
-      edit:
-        are_you_sure: Er du sikker?
-        cancel_my_account: Avbryt kontoen min
-        currently_waiting_confirmation_for_email: 'Foreløpig venter for bekreftelse på: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: la stå tom hvis du ikke vil endre det
-        title: Endre %{resource}
-        unhappy: Ikke fornøyd?
-        update: Oppdater
-        we_need_your_current_password_to_confirm_your_changes: vi trenger ditt nåværende passord for å bekrefte endringene dine
       new:
         sign_up: Registrer deg
       signed_up: Velkommen! Din registrering er fullført. Husk å bekrefte epostadressen din via mailen vi har sendt deg.
@@ -1661,7 +1652,7 @@
         see_more: Se mer
   locale:
     name: Engelsk
-    name_with_error: Engelsk (feil!)
+    name_with_error: Norsk (feil!)
   password_validator:
     blacklisted: er svartelistet
     domain_included_in_password: er for lik dette domenenavnet

data/config/locales/om-ET.yml

@@ -1,2 +1 @@
----
 om:

data/config/locales/pl.yml

@@ -1583,15 +1583,6 @@ pl:
       updated_not_active: Twoje hasło zostało zmienione.
     registrations:
       destroyed: Twoje konto zostało pomyślnie zawieszone. Mamy nadzieję zobaczyć Cię ponownie wkrótce.
-      edit:
-        are_you_sure: Jesteś pewny?
-        cancel_my_account: Zawieś moje konto
-        currently_waiting_confirmation_for_email: 'Obecnie oczekujące potwierdzenie dla: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: pozostaw puste, jeśli nie chcesz tego zmieniać
-        title: Edytuj %{resource}
-        unhappy: Niezadowolony?
-        update: Aktualizuj
-        we_need_your_current_password_to_confirm_your_changes: potrzebujemy Twojego obecnego hasła, aby potwierdzić Twoje zmiany
       new:
         sign_up: Zarejestruj się
       signed_up: Witamy! Zarejestrowałeś się pomyślnie.

data/config/locales/pt-BR.yml

@@ -1,5 +1,5 @@
 ---
-pt:
+pt-BR:
   activemodel:
     attributes:
       account:
@@ -1479,15 +1479,6 @@ pt:
       updated_not_active: Sua senha foi alterada com sucesso.
     registrations:
       destroyed: Tchau! Sua conta foi cancelada com sucesso. Esperamos te ver novamente em breve.
-      edit:
-        are_you_sure: Você tem certeza?
-        cancel_my_account: Cancelar minha conta
-        currently_waiting_confirmation_for_email: 'Atualmente aguardando confirmação para: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: deixe em branco se você não quiser mudá-lo
-        title: Editar %{resource}
-        unhappy: Infeliz?
-        update: Atualizar
-        we_need_your_current_password_to_confirm_your_changes: Precisamos da sua senha atual para confirmar suas alterações
       new:
         sign_up: inscrever-se
       signed_up: Bem vinda! Você se inscreveu com sucesso.
@@ -1612,7 +1603,7 @@ pt:
         see_more: Ver mais
   locale:
     name: Português
-    name_with_error: Inglês (erro!)
+    name_with_error: Português (erro!)
   password_validator:
     domain_included_in_password: é muito semelhante a este nome de domínio
     email_included_in_password: é muito parecido com o seu email

data/config/locales/pt.yml

@@ -1478,15 +1478,6 @@ pt:
       updated_not_active: A sua palavra-passe foi modificada corretamente.
     registrations:
       destroyed: A sua conta foi cancelada corretamente. Esperamos vê-lo(a) novamente em breve.
-      edit:
-        are_you_sure: Tem a certeza?
-        cancel_my_account: Cancelar a minha conta
-        currently_waiting_confirmation_for_email: 'Atualmente à espera de confirmação para: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: deixe em branco se não quiser modificá-lo
-        title: Editar %{resource}
-        unhappy: Infeliz?
-        update: Atualizar
-        we_need_your_current_password_to_confirm_your_changes: precisamos da sua palavra-passe atual para confirmar as suas alterações
       new:
         sign_up: Inscrever-se
       signed_up: Bem-vindo(a)! Inscreveu-se corretamente.

data/config/locales/ro-RO.yml

@@ -1514,15 +1514,6 @@ ro:
       updated_not_active: Parola dvs. a fost schimbată cu succes.
     registrations:
       destroyed: Contul tău a fost anulat cu succes. Sperăm să te revedem în curând.
-      edit:
-        are_you_sure: Sigur dorești asta?
-        cancel_my_account: Anulează contul meu
-        currently_waiting_confirmation_for_email: 'În prezent se așteaptă confirmarea pentru: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: lasă necompletat dacă nu vrei să-l schimbi
-        title: Editează %{resource}
-        unhappy: Nefericit?
-        update: Actualizare
-        we_need_your_current_password_to_confirm_your_changes: avem nevoie de parola curentă pentru a confirma modificările
       new:
         sign_up: Înscrie-te
       signed_up: Bine ați venit! V-ați înregistrat cu succes.

data/config/locales/si-LK.yml

@@ -1,2 +1 @@
----
 si:

data/config/locales/sk.yml

@@ -1208,15 +1208,6 @@ sk:
       updated_not_active: Vaše heslo bolo úspešne zmenené.
     registrations:
       destroyed: Zbohom! Váš účet bol úspešne zrušený. Dúfame, že vás čoskoro uvidíme.
-      edit:
-        are_you_sure: Ste si istí?
-        cancel_my_account: Zrušiť môj účet
-        currently_waiting_confirmation_for_email: 'Aktuálne čaká potvrdenie o:%{email}'
-        leave_blank_if_you_don_t_want_to_change_it: ponechajte prázdne, ak nechcete zmeniť
-        title: Upraviť%{resource}
-        unhappy: Nespokojný?
-        update: Aktualizácia
-        we_need_your_current_password_to_confirm_your_changes: pre potvrdenie zmien potrebujeme vaše aktuálne heslo
       new:
         sign_up: Prihlásiť sa
       signed_up: Vitajte! Úspešne ste sa zaregistrovali.

data/config/locales/so-SO.yml

@@ -1,2 +1 @@
----
 so:

data/config/locales/sv.yml

@@ -42,6 +42,7 @@ sv:
       decidim/promote_to_admin: Befordrad till gruppadministratör
       decidim/removed_from_group: Borttagen från gruppen
       decidim/resource_endorsed_event: Resurs instämd
+      decidim/welcome_notification_event: Välkomstmeddelande
   activerecord:
     attributes:
       decidim/user:
@@ -69,6 +70,8 @@ sv:
     'true': 'Ja'
   carrierwave:
     errors:
+      file_resolution_too_large: Filupplösningen är för stor
+      file_size_too_large: Filen är för stor
       not_inside_organization: Den här filen är inte bifogad till någon organisation
   date:
     formats:
@@ -127,7 +130,10 @@ sv:
         file_no_exists: Filen finns inte
         notice: Dina uppgifter hämtas för närvarande. Du får ett e-postmeddelande när det är klart.
       email_change:
+        body1: Vi har skickat ett e-postmeddelande till %{unconfirmed_email} för att bekräfta din nya e-postadress.
+        body2: Vill du att vi ska skicka verifieringsmailet igen? %{resend_link} eller %{cancel_link}.
         cancel: avbryt
+        cancel_error: Kunde inte avbryta ändringen av e-postadressen.
       show:
         available_locales_helper: Välj det språk du vill använda på plattformen och få i notiserna
         change_password: Ändra lösenord
@@ -1559,15 +1565,6 @@ sv:
       updated_not_active: Ditt lösenord har ändrats.
     registrations:
       destroyed: Ditt konto har avregistrerats. Vi hoppas att vi ses snart igen.
-      edit:
-        are_you_sure: Är du säker?
-        cancel_my_account: Avregistrera mitt konto
-        currently_waiting_confirmation_for_email: 'Väntar för närvarande på bekräftelse från: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: lämna tomt om du inte vill ändra det
-        title: Redigera %{resource}
-        unhappy: Olycklig?
-        update: Uppdatera
-        we_need_your_current_password_to_confirm_your_changes: Vi behöver ditt nuvarande lösenord för att bekräfta ändringarna
       new:
         sign_up: Registrera
       signed_up: Välkommen! Din registrering är klar.
@@ -1636,16 +1633,14 @@ sv:
     timestamp_error_message: Det gick för snabbt! Försök igen.
   layouts:
     decidim:
-      cookie_consent:
-        cookie_details:
+      data_consent:
+        details:
           columns:
-            name: Namn
             service: Tjänst
-            type: Typ
           types:
             cookie: Cookie
         dialog:
-          cookie_settings: Inställningar
+          settings: Inställningar
         modal:
           save_settings: Spara inställningar
       edit_link:

data/config/locales/sw-KE.yml

@@ -1,2 +1 @@
----
 sw:

data/config/locales/ti-ER.yml

@@ -1,2 +1 @@
----
 ti:

data/config/locales/tr-TR.yml

@@ -1436,15 +1436,6 @@ tr:
       updated_not_active: Şifreniz başarıyla değiştirildi.
     registrations:
       destroyed: Hoşçakal! Hesabınız başarıyla iptal edildi. Kısa süre sonra tekrar görmeyi umuyoruz.
-      edit:
-        are_you_sure: Emin misiniz?
-        cancel_my_account: Hesabımı iptal et
-        currently_waiting_confirmation_for_email: 'Şu an için bekleme onayı: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: değiştirmek istemiyorsanız boş bırakın
-        title: '%{resource}düzenle'
-        unhappy: Mutsuz?
-        update: Güncelleştirme
-        we_need_your_current_password_to_confirm_your_changes: değişikliklerinizi onaylamak için mevcut şifrenize ihtiyacımız var
       new:
         sign_up: kaydol
       signed_up: Hoşgeldiniz! Başarıyla kaydoldunuz.

data/config/locales/val-ES.yml

@@ -1,2 +1 @@
----
 val:

data/config/locales/vi.yml

@@ -1,2 +1 @@
----
 vi:

data/config/locales/zh-CN.yml

@@ -1341,15 +1341,6 @@ zh-CN:
       updated_not_active: 您的密码已成功更改。
     registrations:
       destroyed: 您的帐户已成功取消。我们希望很快再见到您。
-      edit:
-        are_you_sure: 您确定吗？
-        cancel_my_account: 取消我的帐户
-        currently_waiting_confirmation_for_email: '正在等待确认: %{email}'
-        leave_blank_if_you_don_t_want_to_change_it: 如果您不想更改它，请留空
-        title: 编辑 %{resource}
-        unhappy: 不愉快？
-        update: 更新
-        we_need_your_current_password_to_confirm_your_changes: 我们需要您当前的密码来确认您的更改
       new:
         sign_up: 注册
       signed_up: 欢迎！您已成功注册。
@@ -1459,8 +1450,8 @@ zh-CN:
       widget:
         see_more: 查看更多
   locale:
-    name: Distr.
-    name_with_error: 英文(错误!)
+    name: 中文
+    name_with_error: 中文(错误!)
   password_validator:
     domain_included_in_password: 与这个域名太近了
     email_included_in_password: 与您的电子邮件太相似了

data/config/locales/zh-TW.yml

@@ -1,2 +1 @@
----
 zh-TW:

data/config/routes.rb

@@ -13,11 +13,29 @@ Decidim::Core::Engine.routes.draw do
                invitations: "decidim/devise/invitations",
                sessions: "decidim/devise/sessions",
                confirmations: "decidim/devise/confirmations",
-               registrations: "decidim/devise/registrations",
                passwords: "decidim/devise/passwords",
                unlocks: "decidim/devise/unlocks",
                omniauth_callbacks: "decidim/devise/omniauth_registrations"
-             }
+             },
+             skip: [:registrations]
+
+  # Manually define the registration routes because otherwise the default "edit"
+  # route would be exposed through Devise while we already have the edit and
+  # destroy routes available through the account pages.
+  resource(
+    :registration,
+    only: [:new, :create],
+    as: :user_registration,
+    path: "/users",
+    path_names: { new: "sign_up" },
+    controller: "devise/registrations"
+  ) do
+    # The "cancel" route forces the session data which is usually expired after
+    # sign in to be expired now. This is useful if the user wants to cancel
+    # OAuth signing in/up in the middle of the process, removing all OAuth
+    # session data. @see [Devise::RegistrationsController#cancel]
+    get :cancel
+  end
 
   devise_for :user_groups,
              class_name: "Decidim::UserGroup",

data/lib/decidim/attributes/model.rb

@@ -15,7 +15,15 @@ module Decidim
         return value if value.is_a?(Decidim::AttributeObject::Model)
         return primitive.new(value) if value.is_a?(::Hash)
         return primitive.new(value.to_h) if value.respond_to?(:to_h)
-        return primitive.new(value.attributes) if value.respond_to?(:attributes)
+
+        if value.respond_to?(:attributes)
+          # In case the primitive is a form object, we also need to call the
+          # `map_model` method in case the target form object defines it for
+          # nested forms to work properly.
+          converted = primitive.new(value.attributes)
+          converted.map_model(value) if converted.respond_to?(:map_model)
+          return converted
+        end
 
         value
       end

data/lib/decidim/content_parsers/hashtag_parser.rb

@@ -18,7 +18,7 @@ module Decidim
 
       # Matches a hashtag if it starts with a letter or number
       # and only contains letters, numbers or underscores.
-      HASHTAG_REGEX = /\s\K\B#([[:alnum:]](?:[[:alnum:]]|_)*)\b/i
+      HASHTAG_REGEX = /(?:\A|\s\K)\B#([[:alnum:]](?:[[:alnum:]]|_)*)\b/i
 
       # Replaces hashtags name with new or existing hashtags models global ids.
       #

data/lib/decidim/core/engine.rb

@@ -265,7 +265,7 @@ module Decidim
         Cell::ViewModel.view_paths << File.expand_path("#{Decidim::Core::Engine.root}/app/views") # for partials
       end
 
-      initializer "doorkeeper" do
+      initializer "doorkeeper", before: "doorkeeper.params.filter" do
         Doorkeeper.configure do
           orm :active_record
 

data/lib/decidim/core/test/shared_examples/resource_endorsed_event_examples.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples_for "resource endorsed event" do
+  include_context "when a simple event"
+
+  let(:event_name) { "decidim.events.resource_endorsed" }
+  let(:author) { create :user, organization: resource.organization }
+
+  let(:extra) { { endorser_id: author.id } }
+  let(:endorsement) { create :endorsement, resource: resource, author: author }
+  let(:resource_path) { resource_locator(resource).path }
+  let(:follower) { create(:user, organization: resource.organization) }
+  let(:follow) { create(:follow, followable: author, user: follower) }
+
+  it_behaves_like "a simple event"
+
+  describe "types" do
+    subject { described_class }
+
+    it "supports notifications" do
+      expect(subject.types).to include :notification
+    end
+
+    it "supports emails" do
+      expect(subject.types).to include :email
+    end
+  end
+
+  describe "email_subject" do
+    it "is generated correctly" do
+      expect(subject.email_subject).to eq("#{author_presenter.nickname} has performed a new endorsement")
+    end
+  end
+
+  describe "email_intro" do
+    it "is generated correctly" do
+      expect(subject.email_intro)
+        .to eq("#{author.name} #{author_presenter.nickname}, who you are following," \
+               " has just endorsed \"#{translated resource.title}\" and we think it may be interesting to you. Check it out and contribute:")
+    end
+  end
+
+  describe "notification_title" do
+    it "is generated correctly" do
+      expect(subject.notification_title)
+        .to include("The <a href=\"#{resource_path}\">#{translated resource.title}</a> #{resource_type} has been endorsed by ")
+
+      expect(subject.notification_title)
+        .to include("<a href=\"/profiles/#{author.nickname}\">#{author.name} #{author_presenter.nickname}</a>.")
+    end
+  end
+
+  describe "resource_text" do
+    it "shows the resource text" do
+      expect(subject.resource_text).to eq resource_text
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/versions_controller_examples.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples "versions controller" do
+  let(:base_params) do
+    if resource.is_a?(Decidim::Participable)
+      { "#{resource.model_name.singular_route_key}_slug".to_sym => resource.slug }
+    else
+      { "#{resource.model_name.singular_route_key}_id".to_sym => resource.id }
+    end
+  end
+
+  before do
+    request.env["decidim.current_organization"] = resource.organization
+
+    if resource.is_a?(Decidim::HasComponent)
+      request.env["decidim.current_participatory_space"] = resource.participatory_space
+      request.env["decidim.current_component"] = resource.component
+    end
+  end
+
+  describe "GET show" do
+    context "with an existing version" do
+      it "returns a HTTP 200" do
+        get :show, params: base_params.merge(id: 1)
+
+        expect(response).to have_http_status(:ok)
+      end
+    end
+
+    context "when the resource does not exist" do
+      it "raises a routing error" do
+        expect do
+          get :show, params: base_params.merge(id: 999_999_999)
+        end.to raise_error(ActionController::RoutingError)
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/with_endorsable_permissions_examples.rb

@@ -5,7 +5,7 @@ require "spec_helper"
 # users of this test should delare the `subject` variable.
 shared_examples "with endorsable permissions can perform actions related to endorsable" do
   let(:action_subject) { :endorsement }
-  let(:resource) { create :dummy_resource }
+  let(:resource) { create :dummy_resource, component: component }
   before do
     context[:current_settings] = double(current_settings)
     context[:resource] = resource

data/lib/decidim/core/test.rb

@@ -71,3 +71,5 @@ require "decidim/core/test/shared_examples/categories_container_examples"
 require "decidim/core/test/shared_examples/assembly_announcements_examples"
 require "decidim/core/test/shared_examples/translated_event_examples"
 require "decidim/core/test/shared_examples/conversations_examples"
+require "decidim/core/test/shared_examples/resource_endorsed_event_examples"
+require "decidim/core/test/shared_examples/versions_controller_examples"

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.27.0.rc1"
+      "0.27.0.rc2"
     end
   end
 end

data/lib/decidim/core.rb

@@ -113,6 +113,7 @@ module Decidim
   autoload :EventRecorder, "decidim/event_recorder"
   autoload :ControllerHelpers, "decidim/controller_helpers"
   autoload :ProcessesFileLocally, "decidim/processes_file_locally"
+  autoload :DependencyResolver, "decidim/dependency_resolver"
 
   include ActiveSupport::Configurable
   # Loads seeds from all engines.
@@ -396,23 +397,24 @@ module Decidim
     1_000
   end
 
-  # Defines the name of the cookie used to check if the user allows Decidim to
-  # set cookies.
+  # Defines the name of the cookie used to check if the user has given consent
+  # to store local data in their browser.
   config_accessor :consent_cookie_name do
     "decidim-consent"
   end
 
-  # Defines cookie categories. Note that when adding a cookie you need to
-  # add following i18n entries also (change 'foo' with the name of the cookie).
+  # Defines data consent categories. Note that when adding an item you need to
+  # add following i18n entries also (change 'foo' with the name of the data
+  # which can be a cookie for instance).
   #
-  # layouts.decidim.cookie_consent.cookie_details.cookies.foo.service
-  # layouts.decidim.cookie_consent.cookie_details.cookies.foo.description
+  # layouts.decidim.data_consent.details.items.foo.service
+  # layouts.decidim.data_consent.details.items.foo.description
   config_accessor :consent_categories do
     [
       {
         slug: "essential",
         mandatory: true,
-        cookies: [
+        items: [
           {
             type: "cookie",
             name: "_session_id"
@@ -420,6 +422,10 @@ module Decidim
           {
             type: "cookie",
             name: Decidim.consent_cookie_name
+          },
+          {
+            type: "local_storage",
+            name: "pwaInstallPromptSeen"
           }
         ]
       },
@@ -711,12 +717,45 @@ module Decidim
     Rails.autoloaders.main.ignore(path) if Rails.configuration.autoloader == :zeitwerk
   end
 
-  # Checks if a particular decidim gem is installed
-  # Note that defined(Decidim::Something) does not work all the times, specially when the
-  # Gemfile uses the "path" parameter to find the module.
-  # This is because the module can be defined by some files searched by Rails automatically
-  # (ie: decidim-initiatives/lib/decidim/initiatives/version.rb automatically defines Decidim::Intiatives even if not required)
+  # Checks if a particular decidim gem is installed and needed by this
+  # particular instance. Preferrably this happens through bundler by inspecting
+  # the Gemfile of the instance but when Decidim is used without bundler, this
+  # will check:
+  # 1. If the gem is globally available or not in the loaded specs, i.e. the
+  #    gems available in the gem install directory/directories.
+  # 2. If the gem has been required through `require "decidim/foo"`.
+  #
+  # Using bundler is suggested as it will provide more accurate results
+  # regarding what is actually needed. It will resolve all the gems listed in
+  # the Gemfile and also their dependencies which provides us accurate
+  # information whether a gem is needed by the instance or not.
+  #
+  # Note that using something like defined?(Decidim::Foo) will not work because
+  # the way the Decidim handles version definitions for each gem. After the gems
+  # are loaded, this would always return true because the version definition
+  # files of each module define that module which means it is available at
+  # runtime if the gem is installed in the gem load path. In some situations it
+  # can be installed there through other projects or through the command line
+  # even if the instance does not require that module or even through
+  # installing gems from git sources or from file paths.
+  #
+  # When a gem is reported as "needed" by the dependency resolver, this will
+  # also require that module ensuring its availability for the initialization
+  # code.
+  #
+  # @param mod [Symbol, String] The module name to check, e.g. `:proposals`.
+  # @return [Boolean] A boolean indicating whether the module is installed.
   def self.module_installed?(mod)
-    Gem.loaded_specs.has_key?("decidim-#{mod}")
+    return false unless Decidim::DependencyResolver.instance.needed?("decidim-#{mod}")
+
+    # The dependency may not be automatically loaded through the Gemfile if the
+    # user lists e.g. "decidim-core" and "decidim-budgets" in it. In this
+    # situation, "decidim-comments" is also needed because it is a dependency
+    # for "decidim-budgets".
+    require "decidim/#{mod}"
+
+    true
+  rescue LoadError
+    false
   end
 end