decidim-core 0.26.0 → 0.26.1

data/lib/decidim/core/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds the decidim-core version.
   module Core
     def self.version
-      "0.26.0"
+      "0.26.1"
     end
   end
 end

data/lib/decidim/endorsable.rb

@@ -18,7 +18,11 @@ module Decidim
       #
       # Returns Boolean.
       def endorsed_by?(user, user_group = nil)
-        endorsements.where(author: user, user_group: user_group).any?
+        if user_group
+          endorsements.where(user_group: user_group).any?
+        else
+          endorsements.where(author: user, user_group: nil).any?
+        end
       end
     end
   end

data/lib/decidim/middleware/rails_cookies.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+# This is a backport for Rails 6.0 for the Same-Site option for the cookies
+# because this option was added in Rails 6.1.
+#
+# See:
+# https://github.com/decidim/decidim/pull/9051
+# https://github.com/rails/rails/issues/35822
+# https://github.com/rails/rails/commit/7ccaa125ba396d418aad1b217b63653d06044680
+module ActionDispatch
+  class Cookies
+    class CookieJar #:nodoc:
+      alias handle_options_original handle_options
+
+      def handle_options(options)
+        handle_options_original(options)
+
+        options[:same_site] ||= Rails.application.config.action_dispatch.cookies_same_site_protection || :lax
+        options[:same_site] = false if options[:same_site] == :none
+      end
+    end
+  end
+end

data/lib/decidim/social_share/service.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Decidim
+  module SocialShare
+    # This class represents an abstract social network.
+    class Service
+      include Decidim::AttributeObject::Model
+      include ActiveModel::Validations
+
+      # The name of the social networking service.
+      attribute :name, String
+
+      # The icon of the social networking service.
+      attribute :icon, String
+
+      # The share_url of the social networking service.
+      attribute :share_uri, String
+
+      # TODO validate #{url} in share_url
+
+      def formatted_share_uri(title, **args)
+        format(share_uri, title: title, **args)
+      end
+
+      # Public: Returns an image of the icon for this social network.
+      #
+      # Returns a String with the icon.
+      def icon_path
+        ActionController::Base.helpers.asset_pack_path("media/images/#{icon}")
+      end
+    end
+  end
+end

data/lib/decidim/social_share/service_registry.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module Decidim
+  module SocialShare
+    # This class represents a repository of social networking services. New services can be
+    # registered thanks to its DSL and will be validated prior to being
+    # inserted.
+    #
+    class ServiceRegistry
+      # Public: Initializes the social networking service.
+      def initialize
+        @services = {}
+      end
+
+      # Public: Returns all the registered social networking services.
+      #
+      # Returns Array<Service>.
+      def all
+        @services.values
+      end
+
+      # Public: Finds a social networking services given its name.
+      #
+      # name - The name of the service to find.
+      #
+      # Returns a Service if found or nil otherwise.
+      def find(name)
+        @services[name.to_s]
+      end
+
+      # Public: Registers a new social networking service.
+      #
+      # name   - The name of the social network to register.
+      # &block - A block that gets the new social network as argument.
+      #
+      # Example:
+      #     register(:fake){ |service| service.image = "twitter.svg" }
+      #
+      # Returns a Service when registered successfully, raises an exception
+      # otherwise.
+      def register(name, &block)
+        name = name.to_s
+
+        service = Service.new(name: name).tap do |object|
+          object.instance_eval(&block)
+        end
+
+        service.validate!
+
+        @services[name] = service
+      end
+
+      # Public: Unregisters a previously registered social network.
+      #
+      # name - The name of the social network to unregister.
+      #
+      # Returns the deleted Service if found, nil otherwise.
+      def unregister(name)
+        @services.delete(name.to_s)
+      end
+    end
+  end
+end

data/lib/decidim/social_share.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Decidim
+  module SocialShare
+    autoload :Service, "decidim/social_share/service"
+    autoload :ServiceRegistry, "decidim/social_share/service_registry"
+
+    # Semi-private: The ServiceRegistry to register global services to.
+    def self.service_registry
+      @service_registry ||= Decidim::SocialShare::ServiceRegistry.new
+    end
+
+    # Public: Returns all available services.
+    #
+    # Returns an Array<Service>
+    def self.services
+      service_registry.all
+    end
+
+    # Public: Finds a Service given a name.
+    #
+    # Returns a Service if found, nil otherwise.
+    def self.find_service(name)
+      service_registry.find(name)
+    end
+
+    # Public: Registers a new Service.
+    #
+    # Example:
+    #
+    #     Decidim.register_service(:foo) do |service|
+    #       service.levels = [1, 10, 50]
+    #     end
+    #
+    # Returns nothing if registered successfully, raises an exception
+    # otherwise.
+    def self.register_service(name, &block)
+      service_registry.register(name, &block)
+    end
+
+    def self.enabled_services
+      services.select { |s| Decidim.config.social_share_services.include?(s.name) }
+    end
+  end
+end

data/lib/decidim/view_model.rb

@@ -15,7 +15,6 @@ module Decidim
     include Decidim::ReplaceButtonsHelper
     include Cell::Caching::Notifications
     include Decidim::MarkupHelper
-    include Decidim::FilterParamsHelper
     include ::Webpacker::Helper
 
     delegate :current_organization, to: :controller

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-core
 version: !ruby/object:Gem::Version
-  version: 0.26.0
+  version: 0.26.1
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-22 00:00:00.000000000 Z
+date: 2022-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_link_to
@@ -754,28 +754,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.26.0
+        version: 0.26.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.26.0
+        version: 0.26.1
 - !ruby/object:Gem::Dependency
   name: decidim-dev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.26.0
+        version: 0.26.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.26.0
+        version: 0.26.1
 description: Adds core features so other engines can hook into the framework.
 email:
 - josepjaume@gmail.com
@@ -886,6 +886,7 @@ files:
 - app/cells/decidim/endorsement_buttons/select_identity_button.erb
 - app/cells/decidim/endorsement_buttons/show.erb
 - app/cells/decidim/endorsement_buttons_cell.rb
+- app/cells/decidim/endorsement_buttons_cell.rb.2
 - app/cells/decidim/endorsers_list/show.erb
 - app/cells/decidim/endorsers_list_cell.rb
 - app/cells/decidim/fingerprint/show.erb
@@ -1188,7 +1189,6 @@ files:
 - app/helpers/decidim/decidim_form_helper.rb
 - app/helpers/decidim/endorsable_helper.rb
 - app/helpers/decidim/external_domain_helper.rb
-- app/helpers/decidim/filter_params_helper.rb
 - app/helpers/decidim/filters_helper.rb
 - app/helpers/decidim/followable_helper.rb
 - app/helpers/decidim/humanize_booleans_helper.rb
@@ -1215,9 +1215,11 @@ files:
 - app/helpers/decidim/sanitize_helper.rb
 - app/helpers/decidim/scopes_helper.rb
 - app/helpers/decidim/searches_helper.rb
+- app/helpers/decidim/social_share_button_helper.rb
 - app/helpers/decidim/tooltip_helper.rb
 - app/helpers/decidim/traceability_helper.rb
 - app/helpers/decidim/translations_helper.rb
+- app/helpers/decidim/twitter_search_helper.rb
 - app/helpers/decidim/user_group_helper.rb
 - app/helpers/decidim/user_profile_helper.rb
 - app/helpers/decidim/view_hooks_helper.rb
@@ -1382,6 +1384,7 @@ files:
 - app/packs/src/decidim/ajax_modals.js
 - app/packs/src/decidim/append_elements.js
 - app/packs/src/decidim/append_redirect_url_to_modals.js
+- app/packs/src/decidim/back_to_list.js
 - app/packs/src/decidim/callout.js
 - app/packs/src/decidim/check_boxes_tree.js
 - app/packs/src/decidim/clipboard.js
@@ -1406,11 +1409,13 @@ files:
 - app/packs/src/decidim/external_domain_warning.js
 - app/packs/src/decidim/external_link.js
 - app/packs/src/decidim/floating_help.js
+- app/packs/src/decidim/focus_guard.js
 - app/packs/src/decidim/form_attachments.js
 - app/packs/src/decidim/form_datepicker.js
 - app/packs/src/decidim/form_filter.component.test.js
 - app/packs/src/decidim/form_filter.component_for_testing.js
 - app/packs/src/decidim/form_filter.js
+- app/packs/src/decidim/form_remote.js
 - app/packs/src/decidim/form_validator.js
 - app/packs/src/decidim/foundation-datepicker/js/locales/foundation-datepicker.lb.js
 - app/packs/src/decidim/foundation_datepicker_locales.js
@@ -1461,6 +1466,7 @@ files:
 - app/packs/src/decidim/vendor/jquery-tmpl.js
 - app/packs/src/decidim/vendor/leaflet-tilelayer-here.js
 - app/packs/src/decidim/vendor/modernizr.js
+- app/packs/src/decidim/vendor/social-share-button.js
 - app/packs/src/decidim/vendor/tribute.js
 - app/packs/src/decidim/vizzs.js
 - app/packs/src/decidim/vizzs/areachart.js
@@ -1938,7 +1944,6 @@ files:
 - config/initializers/devise.rb
 - config/initializers/foundation_rails_helper.rb
 - config/initializers/invisible_captcha.rb
-- config/initializers/mail_previews.rb
 - config/initializers/omniauth.rb
 - config/initializers/rack_attack.rb
 - config/locales/am-ET.yml
@@ -2350,9 +2355,11 @@ files:
 - lib/decidim/core/test/shared_examples/comments_reports_examples.rb
 - lib/decidim/core/test/shared_examples/component_type.rb
 - lib/decidim/core/test/shared_examples/controller_render_views.rb
+- lib/decidim/core/test/shared_examples/conversations_examples.rb
 - lib/decidim/core/test/shared_examples/counts_commentators_as_newsletter_participants.rb
 - lib/decidim/core/test/shared_examples/edit_link_shared_examples.rb
 - lib/decidim/core/test/shared_examples/embed_resource_examples.rb
+- lib/decidim/core/test/shared_examples/endorsable.rb
 - lib/decidim/core/test/shared_examples/endorsable_interface_examples.rb
 - lib/decidim/core/test/shared_examples/endorsements_controller_shared_context.rb
 - lib/decidim/core/test/shared_examples/errors.rb
@@ -2498,6 +2505,7 @@ files:
 - lib/decidim/metric_operation_manifest.rb
 - lib/decidim/metric_registry.rb
 - lib/decidim/middleware/current_organization.rb
+- lib/decidim/middleware/rails_cookies.rb
 - lib/decidim/middleware/strip_x_forwarded_host.rb
 - lib/decidim/newsletter_encryptor.rb
 - lib/decidim/newsletter_participant.rb
@@ -2526,6 +2534,9 @@ files:
 - lib/decidim/settings_manifest.rb
 - lib/decidim/shareable_with_token.rb
 - lib/decidim/snippets.rb
+- lib/decidim/social_share.rb
+- lib/decidim/social_share/service.rb
+- lib/decidim/social_share/service_registry.rb
 - lib/decidim/stats_registry.rb
 - lib/decidim/traceable.rb
 - lib/decidim/translatable_attributes.rb

data/app/helpers/decidim/filter_params_helper.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  # A helper to allow only Decidim params to be added to a link.
-  # This is useful when we want to preserve the params from a search, ordering
-  # or paginating results. Using this, we can link back to where the user was
-  # at the show page.
-  module FilterParamsHelper
-    # Public: Builds a hash to be added to a _path or _url method with only
-    # allowed params.
-    #
-    # params - An optional Hash with the values of the params. It will try to
-    # get them from the controller if none are present.
-    #
-    # Returns a Hash.
-    def filter_link_params(params = nil)
-      return {} if params.blank? && (!respond_to?(:controller) || !controller.respond_to?(:params))
-
-      params = controller.params.to_unsafe_h if params.blank?
-
-      params.stringify_keys.slice(
-        "order",
-        "filter",
-        "page",
-        "per_page",
-        "locale"
-      )
-    end
-  end
-end

data/config/initializers/mail_previews.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-Rails.application.configure do
-  config.action_mailer.preview_path = Decidim::Core::Engine.root.join("spec/mailers")
-end