decidim-core 0.1.0 → 0.2.0

data/app/models/decidim/participatory_process_step.rb

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
+
 module Decidim
   # A ParticipatoryProcess is composed of many steps that hold different
   # features that will show up in the depending on what step is currently
   # active.
   class ParticipatoryProcessStep < ApplicationRecord
-    belongs_to :participatory_process, foreign_key: "decidim_participatory_process_id", class_name: Decidim::ParticipatoryProcess
+    belongs_to :participatory_process, foreign_key: "decidim_participatory_process_id", class_name: "Decidim::ParticipatoryProcess"
     has_one :organization, through: :participatory_process
 
     validates :start_date, date: { before: :end_date, allow_blank: true, if: proc { |obj| obj.end_date.present? } }

data/app/models/decidim/report.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
+
 module Decidim
   # A reportable can be reported one time for each user.
   class Report < ApplicationRecord
     REASONS = %w(spam offensive does_not_belong).freeze
 
-    belongs_to :moderation, foreign_key: "decidim_moderation_id", class_name: Decidim::Moderation
-    belongs_to :user, foreign_key: "decidim_user_id", class_name: Decidim::User
+    belongs_to :moderation, foreign_key: "decidim_moderation_id", class_name: "Decidim::Moderation"
+    belongs_to :user, foreign_key: "decidim_user_id", class_name: "Decidim::User"
 
     validates :moderation, :user, :reason, presence: true
     validates :user, uniqueness: { scope: :decidim_moderation_id }

data/app/models/decidim/resource_link.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # A ResourceLink allows linking resources (other entities in Decidim) between
   # them without them having to know each other.

data/app/models/decidim/scope.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # Scopes are used in some entities through Decidim to help users know which is
   # the scope of a participatory process.
@@ -6,7 +7,7 @@ module Decidim
   class Scope < ApplicationRecord
     belongs_to :organization,
                foreign_key: "decidim_organization_id",
-               class_name: Decidim::Organization,
+               class_name: "Decidim::Organization",
                inverse_of: :scopes
 
     validates :name, presence: true, uniqueness: { scope: :organization }

data/app/models/decidim/static_page.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # A page is used to add static content to the website, it can be useful so
   # organization can add their own terms and conditions, privacy policy or
@@ -7,7 +8,7 @@ module Decidim
   # Pages with a default slug cannot be destroyed and its slug cannot be
   # modified.
   class StaticPage < ApplicationRecord
-    belongs_to :organization, foreign_key: "decidim_organization_id", class_name: Decidim::Organization, inverse_of: :static_pages
+    belongs_to :organization, foreign_key: "decidim_organization_id", class_name: "Decidim::Organization", inverse_of: :static_pages
 
     validates :slug, :organization, presence: true
     validates :slug, uniqueness: { scope: :organization }

data/app/models/decidim/user.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_dependency "devise/models/decidim_validatable"
 
 module Decidim
@@ -11,11 +12,11 @@ module Decidim
            :omniauthable, omniauth_providers: [:facebook, :twitter, :google_oauth2],
                           request_keys: [:env], reset_password_keys: [:decidim_organization_id, :email]
 
-    belongs_to :organization, foreign_key: "decidim_organization_id", class_name: Decidim::Organization
-    has_many :authorizations, foreign_key: "decidim_user_id", class_name: Decidim::Authorization, inverse_of: :user
-    has_many :identities, foreign_key: "decidim_user_id", class_name: Decidim::Identity
-    has_many :user_groups, through: :memberships, class_name: Decidim::UserGroup, foreign_key: :decidim_user_group_id
-    has_many :memberships, class_name: Decidim::UserGroupMembership, foreign_key: :decidim_user_id
+    belongs_to :organization, foreign_key: "decidim_organization_id", class_name: "Decidim::Organization"
+    has_many :authorizations, foreign_key: "decidim_user_id", class_name: "Decidim::Authorization", inverse_of: :user
+    has_many :identities, foreign_key: "decidim_user_id", class_name: "Decidim::Identity"
+    has_many :user_groups, through: :memberships, class_name: "Decidim::UserGroup", foreign_key: :decidim_user_group_id
+    has_many :memberships, class_name: "Decidim::UserGroupMembership", foreign_key: :decidim_user_id
 
     ROLES = %w(admin moderator collaborator official).freeze
 

data/app/models/decidim/user_group.rb

@@ -3,25 +3,41 @@
 module Decidim
   # A UserGroup is an organization of citizens
   class UserGroup < ApplicationRecord
-    has_many :users, through: :memberships, class_name: Decidim::User, foreign_key: :decidim_user_id
-    has_many :memberships, class_name: Decidim::UserGroupMembership, foreign_key: :decidim_user_group_id
+    has_many :users, through: :memberships, class_name: "Decidim::User", foreign_key: :decidim_user_id
+    has_many :memberships, class_name: "Decidim::UserGroupMembership", foreign_key: :decidim_user_group_id
 
     validates :name, presence: true
     validates :document_number, presence: true
     validates :phone, presence: true
     validates :avatar, file_size: { less_than_or_equal_to: 5.megabytes }
+
+    validate :correct_state
+
     mount_uploader :avatar, Decidim::AvatarUploader
 
     scope :verified, -> { where.not(verified_at: nil) }
-
-    # Public: Mark the user group as verified
-    def verify!
-      update_attribute(:verified_at, Time.current)
-    end
+    scope :rejected, -> { where.not(rejected_at: nil) }
 
     # Public: Checks if the user group is verified.
     def verified?
       verified_at.present?
     end
+
+    # Public: Checks if the user group is rejected.
+    def rejected?
+      rejected_at.present?
+    end
+
+    # Public: Checks if the user group is pending.
+    def pending?
+      verified_at.blank? && rejected_at.blank?
+    end
+
+    private
+
+    # Private: Checks if the state user group is correct.
+    def correct_state
+      errors.add(:base, :invalid) if verified? && rejected?
+    end
   end
 end

data/app/models/decidim/user_group_membership.rb

@@ -3,7 +3,7 @@
 module Decidim
   # A UserGroupMembership associate user with user groups
   class UserGroupMembership < ApplicationRecord
-    belongs_to :user, class_name: Decidim::User, foreign_key: :decidim_user_id
-    belongs_to :user_group, class_name: Decidim::UserGroup, foreign_key: :decidim_user_group_id
+    belongs_to :user, class_name: "Decidim::User", foreign_key: :decidim_user_id
+    belongs_to :user_group, class_name: "Decidim::UserGroup", foreign_key: :decidim_user_group_id
   end
 end

data/app/presenters/decidim/home_stats_presenter.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # A presenter to render statistics in the homepage.
   class HomeStatsPresenter < Rectify::Presenter
@@ -62,7 +63,7 @@ module Decidim
       content_tag :div, "", class: "home-pam__data" do
         safe_join([
                     content_tag(:h4, I18n.t(name, scope: "pages.home.statistics"), class: "home-pam__title"),
-                    content_tag(:span, " #{data}", class: "home-pam__number #{name}")
+                    content_tag(:span, " #{number_with_delimiter(data)}", class: "home-pam__number #{name}")
                   ])
       end
     end

data/app/presenters/decidim/menu_item_presenter.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module Decidim
+  # A presenter to render menu items
+  class MenuItemPresenter
+    #
+    # Initializes a menu item for presentation
+    #
+    # @param menu_item [MenuItem] The menu item itself
+    # @param view [ActionView::Base] The view instance to help rendering the item
+    # @param options [Hash] The rendering options for the item
+    #
+    # @option options [String] :element_class
+    #         The CSS class to be used for the item
+    #
+    # @option options [String] :active_class
+    #         The CSS class to be used for the active item
+    #
+    def initialize(menu_item, view, options = {})
+      @menu_item = menu_item
+      @view = view
+      @element_class = options[:element_class]
+      @active_class = options[:active_class]
+    end
+
+    delegate :label, :url, :active, :icon_name, to: :@menu_item
+    delegate :content_tag, :link_to, :active_link_to_class, :is_active_link?, :icon, to: :@view
+
+    def render
+      content_tag :li, class: link_wrapper_classes do
+        if icon_name
+          link_to(url) { icon(icon_name) + label }
+        else
+          link_to label, url
+        end
+      end
+    end
+
+    private
+
+    attr_reader :element_class
+
+    def link_wrapper_classes
+      return element_class unless is_active_link?(url, active)
+
+      [element_class, active_class].compact.join(" ")
+    end
+
+    def active_class
+      active_link_to_class(
+        url,
+        active: active,
+        class_active: @active_class
+      )
+    end
+  end
+end

data/app/presenters/decidim/menu_presenter.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module Decidim
+  # A presenter to render menus
+  class MenuPresenter
+    #
+    # Initializes a menu for presentation
+    #
+    # @param name [Symbol] The name of the menu registry to be rendered
+    # @param view [ActionView::Base] The view scope to render the menu
+    # @param options [Hash] The rendering options for the menu entries
+    #
+    def initialize(name, view, options = {})
+      @name = name
+      @view = view
+
+      @options = options
+    end
+
+    delegate :items, to: :evaluated_menu
+    delegate :content_tag, :safe_join, to: :@view
+
+    def evaluated_menu
+      @evaluated_menu ||= begin
+                            menu = Menu.new(@name)
+                            menu.build_for(@view)
+                            menu
+                          end
+    end
+
+    def render
+      content_tag :nav, class: "main-nav" do
+        content_tag :ul do
+          safe_join(menu_items)
+        end
+      end
+    end
+
+    private
+
+    def menu_items
+      items.map do |menu_item|
+        MenuItemPresenter.new(menu_item, @view, @options).render
+      end
+    end
+  end
+end

data/app/queries/decidim/highlighted_participatory_processes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This query adds some scopes so the processes are ready to be showed in a
   # public view.

data/app/queries/decidim/organization_participatory_processes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This query class returns the visible Participatory Processes given an
   # Organization.

data/app/queries/decidim/organization_prioritized_participatory_processes.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Decidim
+  # This query class returns the public Participatory Processes given an
+  # Organization in a meaningful order.
+  class OrganizationPrioritizedParticipatoryProcesses < Rectify::Query
+    def initialize(organization)
+      @organization = organization
+    end
+
+    def query
+      Rectify::Query.merge(
+        OrganizationParticipatoryProcesses.new(@organization),
+        PrioritizedParticipatoryProcesses.new
+      ).query
+    end
+  end
+end

data/app/queries/decidim/{public_participatory_processes.rb → prioritized_participatory_processes.rb}

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 module Decidim
-  # This query adds some scopes so the processes are ready to be showed in a
-  # public view.
-  class PublicParticipatoryProcesses < Rectify::Query
+  # This query orders processes by importance, prioritizing promoted processes
+  # first, and closest to finalization date second.
+  class PrioritizedParticipatoryProcesses < Rectify::Query
     def query
       Decidim::ParticipatoryProcess.order("promoted DESC").includes(:active_step).order("decidim_participatory_process_steps.end_date ASC")
     end

data/app/queries/decidim/promoted_participatory_processes.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This query filters processes so only promoted ones are returned.
   class PromotedParticipatoryProcesses < Rectify::Query

data/app/queries/decidim/stats_users_count.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This query counts registered users from a collection of organizations
   # in an optional interval of time.

data/app/services/decidim/action_authorizer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class is used to authorize a user against an action in the context of a
   # feature.

data/app/services/decidim/authorization_handler.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This is the base class for authorization handlers, all implementations
   # should inherit from it.

data/app/services/decidim/resource_search.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This is the base class to be used by other search services.
   # Searchlight documentation: https://github.com/nathanl/searchlight

data/app/services/decidim/static_map_generator.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require "httparty"
 
 module Decidim

data/app/uploaders/decidim/application_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading images to Decidim It is intended to just
   # hold the uploads configuration, so you should inherit from this class and

data/app/uploaders/decidim/banner_image_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading banner images to ParticipatoryProcesses.
   class BannerImageUploader < ImageUploader

data/app/uploaders/decidim/hero_image_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading hero images to ParticipatoryProcesses.
   class HeroImageUploader < ImageUploader

data/app/uploaders/decidim/homepage_image_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading hero images to ParticipatoryProcesses.
   class HomepageImageUploader < ImageUploader

data/app/uploaders/decidim/image_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading hero images to ParticipatoryProcesses.
   class ImageUploader < ApplicationUploader

data/app/uploaders/decidim/official_image_footer_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading hero images to ParticipatoryProcesses.
   class OfficialImageFooterUploader < ImageUploader

data/app/uploaders/decidim/official_image_header_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading hero images to ParticipatoryProcesses.
   class OfficialImageHeaderUploader < ImageUploader

data/app/uploaders/decidim/organization_favicon_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading an organization's favicon.
   class OrganizationFaviconUploader < ImageUploader

data/app/uploaders/decidim/organization_logo_uploader.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Decidim
   # This class deals with uploading the organization's logo.
   class OrganizationLogoUploader < ImageUploader

data/app/validators/etiquette_validator.rb

@@ -1,5 +1,5 @@
-# coding: utf-8
 # frozen_string_literal: true
+
 # This validator takes care of ensuring the validated content is
 # respectful, doesn't use caps, and overall is meaningful.
 class EtiquetteValidator < ActiveModel::EachValidator
@@ -16,7 +16,7 @@ class EtiquetteValidator < ActiveModel::EachValidator
   private
 
   def validate_caps(record, attribute, value)
-    return if value.scan(/[A-Z]/).length < value.length / 3
+    return if value.scan(/[A-Z]/).length < value.length / 4
     record.errors.add(attribute, options[:message] || :too_much_caps)
   end
 
@@ -26,7 +26,7 @@ class EtiquetteValidator < ActiveModel::EachValidator
   end
 
   def validate_long_words(record, attribute, value)
-    return if value.scan(/[A-z]{30,}/).empty?
+    return if value.scan(/[A-z]{35,}/).empty?
     record.errors.add(attribute, options[:message] || :long_words)
   end