decidim-core 0.0.5 → 0.0.6

data/lib/decidim/core/test/shared_examples/comments_examples.rb

@@ -0,0 +1,215 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "comments" do
+  let!(:organization) { create(:organization) }
+  let!(:user) { create(:user, :confirmed, organization: organization) }
+  let!(:comments) {
+    3.times.map do
+      create(:comment, commentable: commentable)
+    end
+  }
+  let(:authenticated) { false }
+
+  def visit_commentable_path
+    if authenticated
+      login_as user, scope: :user
+    end
+    visit resource_path
+  end
+
+  before do
+    switch_to_host(organization.host)
+  end
+
+  it "user should see a list of comments" do
+    visit_commentable_path
+
+    expect(page).to have_selector("#comments")
+    expect(page).to have_selector("article.comment", count: comments.length)
+
+    within "#comments" do
+      comments.each do |comment|
+        expect(page).to have_content comment.author.name
+        expect(page).to have_content comment.body
+      end
+    end
+  end
+
+  it "user should be able to sort the comments" do
+    comment = create(:comment, commentable: commentable, body: "Most Rated Comment")
+    create(:comment_vote, comment: comment, author: user, weight: 1)
+
+    visit_commentable_path
+
+    within ".order-by" do
+      page.find('.dropdown.menu .is-dropdown-submenu-parent').hover
+    end
+
+    click_link "Best rated"
+
+    within "#comments" do
+      expect(page.find('.comment', match: :first)).to have_content "Most Rated Comment"
+    end
+  end
+
+  context "when not authenticated" do
+    it "user should not see the form to add comments" do
+      visit_commentable_path
+      expect(page).not_to have_selector(".add-comment form")
+    end
+  end
+
+  context "when authenticated" do
+    let(:authenticated) { true }
+
+    it "user sees the form to add comments" do
+      visit_commentable_path
+
+      expect(page).to have_selector(".add-comment form")
+    end
+
+    context "when user adds a new comment" do
+      before do
+        visit_commentable_path
+
+        expect(page).to have_selector(".add-comment form")
+
+        within ".add-comment form" do
+          fill_in "add-comment-#{commentable.commentable_type}-#{commentable.id}", with: "This is a new comment"
+          click_button "Send"
+        end
+      end
+
+      it "user visualize the comment" do
+        within "#comments" do
+          expect(page).to have_content user.name
+          expect(page).to have_content "This is a new comment"
+        end
+      end
+
+      it "commentable's author receives notificatione" do
+        if commentable.respond_to? :author
+          wait_for_email subject: "new comment"
+          login_as commentable.author, scope: :user
+          visit last_email_first_link
+
+          within "#comments" do
+            expect(page).to have_content user.name
+            expect(page).to have_content "This is a new comment"
+          end
+        else
+          expect {
+            wait_for_email subject: "new comment"
+          }.to raise_error StandardError
+        end
+      end
+    end
+
+    context "when the user has verified organizations" do
+      let(:user_group) { create(:user_group, :verified) }
+
+      before do
+        create(:user_group_membership, user: user, user_group: user_group)
+      end
+
+      it "user can add a new comment as a user group" do
+        visit_commentable_path
+
+        expect(page).to have_selector(".add-comment form")
+
+        within ".add-comment form" do
+          fill_in "add-comment-#{commentable.commentable_type}-#{commentable.id}", with: "This is a new comment"
+          select user_group.name, from: "Comment as"
+          click_button "Send"
+        end
+
+        within "#comments" do
+          expect(page).to have_content user_group.name
+          expect(page).to have_content "This is a new comment"
+        end
+      end
+    end
+
+    context "when a user replies a coment" do
+      let!(:comment_author) { create(:user, :confirmed, organization: organization) }
+      let!(:comment) { create(:comment, commentable: commentable, author: comment_author) }
+
+      before do
+        visit_commentable_path
+
+        expect(page).to have_selector(".comment__reply")
+
+        within "#comments #comment_#{comment.id}" do
+          click_button "Reply"
+          find("textarea").set("This is a reply")
+          click_button "Send"
+        end
+      end
+
+      it "user visualize the reply" do
+        within "#comments #comment_#{comment.id}" do
+          expect(page).to have_content "This is a reply"
+        end
+      end
+
+      it "comment's author receives notification" do
+        wait_for_email subject: "new reply"
+        login_as comment.author, scope: :user
+        visit last_email_first_link
+
+        within "#comments #comment_#{comment.id}" do
+          expect(page).to have_content "This is a reply"
+        end
+      end
+    end
+
+    context "when arguable option is enabled" do
+      before do
+        expect_any_instance_of(commentable.class).to receive(:comments_have_alignment?).and_return(true)
+      end
+
+      it "user can comment in favor" do
+        visit_commentable_path
+
+        expect(page).to have_selector(".add-comment form")
+
+        page.find('.opinion-toggle--ok').click
+
+        within ".add-comment form" do
+          fill_in "add-comment-#{commentable.commentable_type}-#{commentable.id}", with: "I am in favor about this!"
+          click_button "Send"
+        end
+
+        within "#comments" do
+          expect(page).to have_selector 'span.success.label', text: "In favor"
+        end
+      end
+    end
+
+    context "when votable option is enabled" do
+      before do
+        expect_any_instance_of(commentable.class).to receive(:comments_have_votes?).and_return(true)
+      end
+
+      it "user can upvote a comment" do
+        visit_commentable_path
+
+        within "#comment_#{comments[0].id}" do
+          expect(page).to have_selector('.comment__votes--up', text: /0/)
+          page.find('.comment__votes--up').click
+          expect(page).to have_selector('.comment__votes--up', text: /1/)
+        end
+      end
+
+      it "user can downvote a comment" do
+        visit_commentable_path
+
+        within "#comment_#{comments[0].id}" do
+          expect(page).to have_selector('.comment__votes--down', text: /0/)
+          page.find('.comment__votes--down').click
+          expect(page).to have_selector('.comment__votes--down', text: /1/)
+        end
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/has_reference.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+shared_examples_for "has reference" do
+  context "when the reference is nil" do
+    before do
+      subject[:reference] = nil
+    end
+
+    it "generates a valid reference" do
+      expect(subject.reference).to match(/[A-z]+/)
+    end
+  end
+
+  context "when the reference is already set" do
+    before do
+      subject[:reference] = "ARBITRARYREF"
+    end
+
+    it "keeps the pre-existing reference" do
+      expect(subject.reference).to eq("ARBITRARYREF")
+    end
+  end
+
+  context "when saving" do
+    it "stores the reference" do
+      subject.reference = nil
+      subject.save!
+      expect(subject.reload.reference).to_not be_blank
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/manage_moderations_examples.rb

@@ -0,0 +1,75 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "manage moderations" do
+  let!(:moderations) do
+    reportables.first(reportables.length - 1).map do |reportable|
+      moderation = create(:moderation, reportable: reportable, report_count: 1)
+      create(:report, moderation: moderation)
+      moderation
+    end
+  end
+  let!(:moderation) { moderations.first }
+  let!(:hidden_moderations) do
+    reportables.last(1).map do |reportable|
+      moderation = create(:moderation, reportable: reportable, report_count: 3, hidden_at: Time.current)
+      create_list(:report, 3, moderation: moderation)
+      moderation
+    end
+  end
+
+  before do
+    visit decidim_admin.participatory_process_path(participatory_process)
+    click_link "Moderations"
+  end
+
+  context "listing moderations" do
+    it "user can review them" do
+      click_link "Moderations"
+
+      moderations.each do |moderation|
+        within "tr[data-id=\"#{moderation.id}\"]" do
+          expect(page).to have_content moderation.reportable.reported_content
+          expect(page).to have_content moderation.reports.first.reason
+        end
+      end
+    end
+
+    it "user can un-report a resource" do
+      click_link "Moderations"
+
+      within "tr[data-id=\"#{moderation.id}\"]" do
+        click_link "Unreport"
+      end
+
+      within ".flash" do
+        expect(page).to have_content("Resource successfully unreported")
+      end
+    end
+
+    it "user can hide a resource" do
+      click_link "Moderations"
+
+      within "tr[data-id=\"#{moderation.id}\"]" do
+        click_link "Hide"
+      end
+
+      within ".flash" do
+        expect(page).to have_content("Resource successfully hidden")
+      end
+
+      expect(page).to have_no_content(moderation.reportable.reported_content)
+    end
+  end
+
+  context "listing hidden resources" do
+    it "user can review them" do
+      click_link "Hidden"
+
+      hidden_moderations.each do |moderation|
+        within "tr[data-id=\"#{moderation.id}\"]" do
+          expect(page).to have_content moderation.reportable.reported_content
+        end
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/reportable.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+shared_examples_for "reportable" do
+  let(:user) { create(:user, organization: subject.organization) }
+  let(:participatory_process) { subject.feature.participatory_process }
+  let(:moderation) { create(:moderation, reportable: subject, participatory_process: participatory_process, report_count: 1) }
+  let!(:report) { create(:report, moderation: moderation, user: user) }
+
+  describe "#reported_by?" do
+    context "when the resource has not been reported by the given user" do
+      let!(:report) { nil }
+
+      it { expect(subject.reported_by?(user)).to be_falsey }
+    end
+
+    context "when the resource has been reported" do
+      it { expect(subject.reported_by?(user)).to be_truthy }
+    end
+  end
+
+  context "#hidden?" do
+    context "when the resource has not been hidden" do
+      it { expect(subject).not_to be_hidden }
+    end
+
+    context "when the resource has been hidden" do
+      let(:moderation) { create(:moderation, reportable: subject, participatory_process: participatory_process, report_count: 1, hidden_at: Time.current) }
+      it { expect(subject).to be_hidden }
+    end
+  end
+
+  context "#reported?" do
+    context "when the report count is equal to 0" do
+      let(:moderation) { create(:moderation, reportable: subject, participatory_process: participatory_process, report_count: 0) }
+      let!(:report) { nil }
+      it { expect(subject).not_to be_reported }
+    end
+
+    context "when the report count is greater than 0" do
+      it { expect(subject).to be_reported }
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/reports_examples.rb

@@ -0,0 +1,64 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "reports" do
+  context "when the user is not logged in" do
+    it "should be given the option to sign in" do
+      visit reportable_path
+
+      expect(page).to have_selector('.author-data__extra')
+
+      within ".author-data__extra", match: :first do
+        page.find('button').click
+      end
+
+      expect(page).to have_css('#loginModal', visible: true)
+    end
+  end
+
+  context "when the user is logged in" do
+    before do
+      login_as user, scope: :user
+    end
+
+    context "and the user has not reported the resource yet" do
+      it "reports the resource" do
+        visit reportable_path
+
+        expect(page).to have_selector('.author-data__extra')
+
+        within ".author-data__extra", match: :first do
+          page.find('button').click
+        end
+
+        expect(page).to have_css('.flag-modal', visible: true)
+
+        within ".flag-modal" do
+          click_button "Report"
+        end
+
+        expect(page).to have_content "report has been created"
+      end
+    end
+
+    context "and the user has reported the resource previously" do
+      before do
+        moderation = create(:moderation, reportable: reportable, participatory_process: participatory_process)
+        create(:report, moderation: moderation, user: user, reason: "spam")
+      end
+
+      it "cannot report it twice" do
+        visit reportable_path
+
+        expect(page).to have_selector('.author-data__extra')
+
+        within ".author-data__extra", match: :first do
+          page.find('button').click
+        end
+
+        expect(page).to have_css('.flag-modal', visible: true)
+
+        expect(page).to have_content "already reported"
+      end
+    end
+  end
+end

data/lib/decidim/core/version.rb

@@ -2,11 +2,11 @@
 # This holds Decidim's version and the Rails version on which it depends.
 module Decidim
   def self.version
-    "0.0.5"
+    "0.0.6"
   end
 
   def self.rails_version
-    ["~> 5.0.0", ">= 5.0.0.1"]
+    ["~> 5.0.2"]
   end
 
   def self.add_default_gemspec_properties(spec)