decidim-core 0.0.2 → 0.0.3

data/lib/decidim/core/engine.rb

@@ -10,7 +10,6 @@ require "devise-i18n"
 require "devise_invitable"
 require "jquery-rails"
 require "sassc-rails"
-require "turbolinks"
 require "foundation-rails"
 require "foundation_rails_helper"
 require "active_link_to"
@@ -42,7 +41,7 @@ module Decidim
 
       initializer "decidim.action_controller" do |_app|
         ActiveSupport.on_load :action_controller do
-          helper Decidim::LayoutHelper
+          helper Decidim::LayoutHelper if respond_to?(:helper)
         end
       end
 
@@ -74,7 +73,7 @@ module Decidim
 
       initializer "decidim_admin.inject_abilities_to_user" do |_app|
         Decidim.configure do |config|
-          config.abilities << Abilities::Everyone
+          config.abilities << "Decidim::Abilities::Everyone"
         end
       end
 

data/lib/decidim/core/test.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+require "decidim/core/test/shared_examples/authorable"
+require "decidim/core/test/shared_examples/has_attachments"
+require "decidim/core/test/shared_examples/has_feature"
+require "decidim/core/test/shared_examples/has_scope"
+require "decidim/core/test/shared_examples/has_category"

data/lib/decidim/core/test/factories.rb

@@ -36,6 +36,7 @@ FactoryGirl.define do
     description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(2) } }
     welcome_text { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(2) } }
     homepage_image { test_file("city.jpeg", "image/jpeg") }
+    favicon { test_file("icon.png", "image/png") }
     default_locale I18n.default_locale
     available_locales Decidim.available_locales
   end
@@ -50,6 +51,10 @@ FactoryGirl.define do
     banner_image { test_file("city2.jpeg", "image/jpeg") }
     published_at { Time.current }
     organization
+    scope  { Decidim::Faker::Localized.word }
+    domain { Decidim::Faker::Localized.word }
+    developer_group { Faker::Company.name }
+    end_date 2.month.from_now.at_midnight
 
     trait :promoted do
       promoted true
@@ -94,7 +99,7 @@ FactoryGirl.define do
     organization
     locale                { organization.default_locale }
     tos_agreement         "1"
-    avatar                { test_file("avatar.svg", "image/svg+xml") }
+    avatar                { test_file("avatar.jpg", "image/jpeg") }
 
     trait :confirmed do
       confirmed_at { Time.current }
@@ -117,6 +122,11 @@ FactoryGirl.define do
     name { Faker::Educator.course }
     document_number { Faker::Number.number(8) + "X" }
     phone { Faker::PhoneNumber.phone_number }
+    avatar { test_file("avatar.jpg", "image/jpeg") }
+
+    trait :verified do
+      verified_at { Time.current }
+    end
   end
 
   factory :user_group_membership, class: Decidim::UserGroupMembership do
@@ -147,11 +157,11 @@ FactoryGirl.define do
     end
   end
 
-  factory :participatory_process_attachment, class: Decidim::ParticipatoryProcessAttachment do
+  factory :attachment, class: Decidim::Attachment do
     title { Decidim::Faker::Localized.sentence(3) }
     description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(4) } }
     file { test_file("city.jpeg", "image/jpeg") }
-    participatory_process
+    attached_to { build(:participatory_process) }
 
     trait :with_image do
       file { test_file("city.jpeg", "image/jpeg") }
@@ -180,6 +190,17 @@ FactoryGirl.define do
     name { generate(:name) }
     organization
   end
+
+  factory :dummy_resource, class: Decidim::DummyResource do
+    title { generate(:name) }
+    feature
+  end
+
+  factory :resource_link, class: Decidim::ResourceLink do
+    name { generate(:slug) }
+    to { build(:dummy_resource) }
+    from { build(:dummy_resource, feature: to.feature) }
+  end
 end
 
 def test_file(filename, content_type)

data/lib/decidim/core/test/shared_examples/authorable.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+shared_examples_for "authorable" do
+  describe "validations" do
+    context "when the user group is not verified" do
+      it "is not valid" do
+        user_group = create(:user_group)
+        create(:user_group_membership, user: subject.author, user_group: user_group)
+        subject.user_group = user_group
+        expect(subject).not_to be_valid
+      end
+    end
+
+    context "when the author doesn't have a membership of the user group" do
+      it "is not valid" do
+        user_group = create(:user_group, :verified)
+        subject.user_group = user_group
+        expect(subject).not_to be_valid
+      end
+    end
+
+    context "when the author is from another organization" do
+      before do
+        subject.author = create(:user)
+      end
+
+      it { is_expected.to be_invalid }
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/has_attachments.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+shared_examples_for "has attachments" do
+  context "when it has attachments" do
+    let!(:document) do
+      Decidim::AttachmentUploader.enable_processing = true
+      create(:attachment, :with_pdf, attached_to: attached_to)
+    end
+    let!(:image) do
+      Decidim::AttachmentUploader.enable_processing = true
+      create(:attachment, attached_to: attached_to)
+    end
+
+    before do
+      visit current_path
+    end
+
+    it "shows them" do
+      within "div.wrapper .documents" do
+        expect(page).to have_content(/#{translated(document.title, locale: :en)}/i)
+      end
+
+      within "div.wrapper .images" do
+        expect(page).to have_css("img.thumbnail")
+      end
+    end
+  end
+end

data/lib/decidim/core/test/shared_examples/has_category.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+shared_examples_for "has category" do
+  context "when the category is from another organization" do
+    before do
+      subject.category = create(:category)
+    end
+
+    it { is_expected.not_to be_valid }
+  end
+end

data/lib/decidim/core/test/shared_examples/has_feature.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+shared_examples_for "has feature" do
+  context "without a feature" do
+    before do
+      subject.feature = nil
+    end
+
+    it { is_expected.not_to be_valid }
+  end
+
+  context "without a valid feature" do
+    before do
+      subject.feature = build(:feature, manifest_name: "foo-bar")
+    end
+
+    it { is_expected.not_to be_valid }
+  end
+end

data/lib/decidim/core/test/shared_examples/has_scope.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+shared_examples_for "has scope" do
+  context "when the scope is from another organization" do
+    before do
+      subject.scope = create(:scope)
+    end
+
+    it { is_expected.not_to be_valid }
+  end
+end

data/lib/decidim/core/version.rb

@@ -2,7 +2,7 @@
 # This holds Decidim's version and the Rails version on which it depends.
 module Decidim
   def self.version
-    "0.0.2"
+    "0.0.3"
   end
 
   def self.rails_version

data/lib/decidim/feature_manifest.rb

@@ -1,6 +1,6 @@
+# frozen_string_literal: true
 require_dependency "decidim/features/settings_manifest"
 
-# frozen_string_literal: true
 module Decidim
   # This class handles all the logic associated to configuring a feature
   # associated to a participatory process.
@@ -17,6 +17,11 @@ module Decidim
     attribute :name, Symbol
     attribute :hooks, Hash[Symbol => Array[Proc]], default: {}
 
+    # A path with the `scss` stylesheet this engine provides. It is used to
+    # mix this engine's stylesheets with the main app's stylesheets so it can
+    # use the scss variables and mixins provided by Decidim::Core.
+    attribute :stylesheet, String, default: nil
+
     # A String with the feature's icon. The icon must be stored in the
     # engine's assets path.
     attribute :icon, String
@@ -94,5 +99,30 @@ module Decidim
       yield(settings) if block
       settings
     end
+
+    # Public: Registers a resource inside a feature manifest. Exposes a DSL
+    # defined by `Decidim::ResourceManifest`.
+    #
+    # Resource manifests are a way to expose a resource from one engine to
+    # the whole system. This was resoruces can be linked between them.
+    #
+    # block - A Block that will be called to set the Resource attributes.
+    #
+    # Returns nothing.
+    def register_resource
+      manifest = ResourceManifest.new
+      manifest.feature_manifest = self
+      yield(manifest)
+      manifest.validate!
+      resource_manifests << manifest
+    end
+
+    # Public: Finds all the registered resource manifest's via the
+    # `register_resource` method.
+    #
+    # Returns an Array[ResourceManifest].
+    def resource_manifests
+      @resource_manifests ||= []
+    end
   end
 end

data/lib/decidim/features/base_controller.rb

@@ -11,6 +11,7 @@ module Decidim
       include FeatureSettings
       helper Decidim::TranslationsHelper
       helper Decidim::ParticipatoryProcessHelper
+      helper Decidim::ResourceHelper
 
       helper_method :current_feature,
                     :current_manifest
@@ -32,6 +33,15 @@ module Decidim
       def current_participatory_process
         request.env["decidim.current_participatory_process"]
       end
+
+      def ability_context
+        super.merge(
+          current_manifest: current_manifest,
+          current_participatory_process: current_participatory_process,
+          current_settings: current_settings,
+          feature_settings: feature_settings
+        )
+      end
     end
   end
 end

data/lib/decidim/features/settings_manifest.rb

@@ -73,6 +73,7 @@ module Decidim
 
       TYPES = {
         boolean: { klass: Boolean, default: false },
+        integer: { klass: Integer, default: 0 },
         string: { klass: String, default: nil },
         text: { klass: String, default: nil }
       }.freeze

data/lib/decidim/has_attachment.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require "active_support/concern"
+
+module Decidim
+  # A concern with the features needed when you want a model to be able to create
+  # links from it to another resource.
+  module HasAttachments
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :attachments,
+               class_name: Decidim::Attachment,
+               dependent: :destroy,
+               inverse_of: :attached_to,
+               as: :attached_to
+
+      # All the attachments that are photos for this porcess.
+      #
+      # Returns an Array<Attachment>
+      def photos
+        @photos ||= attachments.select(&:photo?)
+      end
+
+      # All the attachments that are documents for this porcess.
+      #
+      # Returns an Array<Attachment>
+      def documents
+        @documents ||= attachments.select(&:document?)
+      end
+    end
+  end
+end

data/lib/decidim/has_attachments.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require "active_support/concern"
+
+module Decidim
+  # A concern with the features needed when you want a model to be able to create
+  # links from it to another resource.
+  module HasAttachments
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :attachments,
+               class_name: Decidim::Attachment,
+               dependent: :destroy,
+               inverse_of: :attached_to,
+               as: :attached_to
+
+      # All the attachments that are photos for this porcess.
+      #
+      # Returns an Array<Attachment>
+      def photos
+        @photos ||= attachments.select(&:photo?)
+      end
+
+      # All the attachments that are documents for this porcess.
+      #
+      # Returns an Array<Attachment>
+      def documents
+        @documents ||= attachments.select(&:document?)
+      end
+    end
+  end
+end

data/lib/decidim/has_category.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+require "active_support/concern"
+
+module Decidim
+  # A concern with the features needed when you want a model to be have a category.
+  module HasCategory
+    extend ActiveSupport::Concern
+
+    included do
+      belongs_to :category, foreign_key: "decidim_category_id", class_name: Decidim::Category
+      validate :category_belongs_to_organization
+
+      private
+
+      def category_belongs_to_organization
+        return unless category
+        errors.add(:category, :invalid) unless feature.categories.where(id: category.id).exists?
+      end
+    end
+  end
+end

data/lib/decidim/has_feature.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+require "active_support/concern"
+
+module Decidim
+  # A concern with the features needed when you want a model to have a feature.
+  module HasFeature
+    extend ActiveSupport::Concern
+
+    included do
+      belongs_to :feature, foreign_key: "decidim_feature_id", class_name: Decidim::Feature
+      has_one :organization, through: :feature
+    end
+
+    class_methods do
+      def feature_manifest_name(manifest_name)
+        validates :feature, feature: { manifest: manifest_name || name.demodulize.pluralize.downcase }
+      end
+    end
+  end
+end

data/lib/decidim/has_scope.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+require "active_support/concern"
+
+module Decidim
+  # A concern with the features needed when you want a model to be have a scope.
+  module HasScope
+    extend ActiveSupport::Concern
+
+    included do
+      belongs_to :scope, foreign_key: "decidim_scope_id", class_name: Decidim::Scope
+      validate :scope_belongs_to_organization
+
+      private
+
+      def scope_belongs_to_organization
+        return if !scope || !feature
+        errors.add(:scope, :invalid) unless feature.scopes.where(id: scope.id).exists?
+      end
+    end
+  end
+end

data/lib/decidim/query_extensions.rb

@@ -19,8 +19,8 @@ module Decidim
           }
         end
 
-        field :currentUser do
-          type UserType
+        field :session do
+          type SessionType
           description "Return's information about the logged in user"
 
           resolve ->(_obj, _args, ctx) {