decidim-conferences 0.28.5 → 0.29.0.rc1

data/app/commands/decidim/conferences/admin/destroy_media_link.rb

@@ -5,50 +5,18 @@ module Decidim
     module Admin
       # A command with all the business logic when destroying a media link
       # in the system.
-      class DestroyMediaLink < Decidim::Command
-        # Public: Initializes the command.
-        #
-        # media_link - the MediaLink to destroy
-        # current_user - the user performing this action
-        def initialize(media_link, current_user)
-          @media_link = media_link
-          @current_user = current_user
-        end
-
-        # Executes the command. Broadcasts these events:
-        #
-        # - :ok when everything is valid.
-        # - :invalid if the form was not valid and we could not proceed.
-        #
-        # Returns nothing.
-        def call
-          destroy_speaker!
-          broadcast(:ok)
-        end
+      class DestroyMediaLink < Decidim::Commands::DestroyResource
+        protected
 
-        private
-
-        attr_reader :media_link, :current_user
-
-        def destroy_speaker!
-          log_info = {
+        def extra_params
+          {
             resource: {
-              title: media_link.title
+              title: resource.title
             },
             participatory_space: {
-              title: media_link.conference.title
+              title: resource.conference.title
             }
           }
-
-          Decidim.traceability.perform_action!(
-            "delete",
-            media_link,
-            current_user,
-            log_info
-          ) do
-            media_link.destroy!
-            media_link
-          end
         end
       end
     end

data/app/commands/decidim/conferences/admin/destroy_partner.rb

@@ -5,50 +5,18 @@ module Decidim
     module Admin
       # A command with all the business logic when destroying a conference
       # Partner in the system.
-      class DestroyPartner < Decidim::Command
-        # Public: Initializes the command.
-        #
-        # conference_partner - the Partner to destroy
-        # current_user - the user performing this action
-        def initialize(conference_partner, current_user)
-          @conference_partner = conference_partner
-          @current_user = current_user
-        end
-
-        # Executes the command. Broadcasts these events:
-        #
-        # - :ok when everything is valid.
-        # - :invalid if the form was not valid and we could not proceed.
-        #
-        # Returns nothing.
-        def call
-          destroy_partner!
-          broadcast(:ok)
-        end
+      class DestroyPartner < Decidim::Commands::DestroyResource
+        protected
 
-        private
-
-        attr_reader :conference_partner, :current_user
-
-        def destroy_partner!
-          log_info = {
+        def extra_params
+          {
             resource: {
-              title: conference_partner.name
+              title: resource.name
             },
             participatory_space: {
-              title: conference_partner.conference.title
+              title: resource.conference.title
             }
           }
-
-          Decidim.traceability.perform_action!(
-            "delete",
-            conference_partner,
-            current_user,
-            log_info
-          ) do
-            conference_partner.destroy!
-            conference_partner
-          end
         end
       end
     end

data/app/commands/decidim/conferences/admin/destroy_registration_type.rb

@@ -5,50 +5,18 @@ module Decidim
     module Admin
       # A command with all the business logic when destroying a conference
       # registration type in the system.
-      class DestroyRegistrationType < Decidim::Command
-        # Public: Initializes the command.
-        #
-        # registration_type - the Partner to destroy
-        # current_user - the user performing this action
-        def initialize(registration_type, current_user)
-          @registration_type = registration_type
-          @current_user = current_user
-        end
-
-        # Executes the command. Broadcasts these events:
-        #
-        # - :ok when everything is valid.
-        # - :invalid if the form was not valid and we could not proceed.
-        #
-        # Returns nothing.
-        def call
-          destroy_registration_type!
-          broadcast(:ok)
-        end
+      class DestroyRegistrationType < Decidim::Commands::DestroyResource
+        protected
 
-        private
-
-        attr_reader :registration_type, :current_user
-
-        def destroy_registration_type!
-          log_info = {
+        def extra_params
+          {
             resource: {
-              title: registration_type.title
+              title: resource.title
             },
             participatory_space: {
-              title: registration_type.conference.title
+              title: resource.conference.title
             }
           }
-
-          Decidim.traceability.perform_action!(
-            "delete",
-            registration_type,
-            current_user,
-            log_info
-          ) do
-            registration_type.destroy!
-            registration_type
-          end
         end
       end
     end

data/app/commands/decidim/conferences/admin/publish_conference_speaker.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Conferences
+    module Admin
+      # A command with all the business logic that publishes an
+      # existing conference speaker.
+      class PublishConferenceSpeaker < Decidim::Command
+        # Public: Initializes the command.
+        #
+        # conference_speaker - Decidim::Conferences::Admin::ConferenceSpeaker
+        # current_user - the user performing the action
+        def initialize(conference_speaker, current_user)
+          @conference_speaker = conference_speaker
+          @current_user = current_user
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if the form was not valid and we could not proceed.
+        #
+        # Returns nothing.
+        def call
+          return broadcast(:invalid) if conference_speaker.published?
+
+          transaction do
+            publish_conference_speaker
+          end
+
+          broadcast(:ok, conference_speaker)
+        end
+
+        private
+
+        attr_reader :conference_speaker, :current_user
+
+        def publish_conference_speaker
+          @conference_speaker = Decidim.traceability.perform_action!(
+            :publish,
+            conference_speaker,
+            current_user
+          ) do
+            conference_speaker.publish!
+            conference_speaker
+          end
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/conferences/admin/unpublish_conference_speaker.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Conferences
+    module Admin
+      # A command with all the business logic that unpublishes an
+      # existing conference speaker.
+      class UnpublishConferenceSpeaker < Decidim::Command
+        # Public: Initializes the command.
+        #
+        # conference_speaker - Decidim::Conferences::Admin::ConferenceSpeaker
+        # current_user - the user performing the action
+        def initialize(conference_speaker, current_user)
+          @conference_speaker = conference_speaker
+          @current_user = current_user
+        end
+
+        # Executes the command. Broadcasts these events:
+        #
+        # - :ok when everything is valid.
+        # - :invalid if the form was not valid and we could not proceed.
+        #
+        # Returns nothing.
+        def call
+          return broadcast(:invalid) unless conference_speaker.published?
+
+          @conference_speaker = Decidim.traceability.perform_action!(
+            :unpublish,
+            conference_speaker,
+            current_user
+          ) do
+            conference_speaker.unpublish!
+            conference_speaker
+          end
+          broadcast(:ok, conference_speaker)
+        end
+
+        private
+
+        attr_reader :conference_speaker, :current_user
+      end
+    end
+  end
+end

data/app/commands/decidim/conferences/admin/update_conference.rb

@@ -5,120 +5,62 @@ module Decidim
     module Admin
       # A command with all the business logic when creating a new participatory
       # conference in the system.
-      class UpdateConference < Decidim::Command
-        include ::Decidim::AttachmentAttributesMethods
-
-        # Public: Initializes the command.
-        #
-        # conference - the Conference to update
-        # form - A form object with the params.
-        def initialize(conference, form)
-          @conference = conference
-          @form = form
-        end
-
-        # Executes the command. Broadcasts these events:
-        #
-        # - :ok when everything is valid.
-        # - :invalid if the form was not valid and we could not proceed.
-        #
-        # Returns nothing.
-        def call
-          return broadcast(:invalid) if form.invalid?
+      class UpdateConference < Decidim::Commands::UpdateResource
+        fetch_file_attributes :hero_image, :banner_image
 
-          update_conference
-          link_participatory_processes
-          link_assemblies
-
-          if @conference.valid?
-            broadcast(:ok, @conference)
-          else
-            form.errors.add(:hero_image, @conference.errors[:hero_image]) if @conference.errors.include? :hero_image
-            form.errors.add(:banner_image, @conference.errors[:banner_image]) if @conference.errors.include? :banner_image
-            broadcast(:invalid)
-          end
-        end
+        fetch_form_attributes :title, :slogan, :slug, :weight, :hashtag, :description, :short_description,
+                              :objectives, :location, :start_date, :end_date, :promoted, :show_statistics,
+                              :scopes_enabled, :scope, :registrations_enabled
 
         private
 
-        attr_reader :form, :conference
-
-        def update_conference
-          @conference.assign_attributes(attributes)
-          save_conference if @conference.valid?
-        end
+        def run_after_hooks
+          send_notification_registrations_enabled if should_notify_followers_registrations_enabled?
+          send_notification_update_conference if should_notify_followers_update_conference?
+          schedule_upcoming_conference_notification if start_date_changed?
 
-        def save_conference
-          transaction do
-            update_conference_registrations
-            @conference.save!
-            send_notification_registrations_enabled if should_notify_followers_registrations_enabled?
-            send_notification_update_conference if should_notify_followers_update_conference?
-            schedule_upcoming_conference_notification if start_date_changed?
-            Decidim.traceability.perform_action!(:update, @conference, form.current_user) do
-              @conference
-            end
-          end
+          link_participatory_processes
+          link_assemblies
         end
 
-        def update_conference_registrations
-          @conference.registrations_enabled = form.registrations_enabled
+        def registration_attributes
+          return {} unless form.registrations_enabled
 
-          if form.registrations_enabled
-            @conference.available_slots = form.available_slots
-            @conference.registration_terms = form.registration_terms
-          end
-        end
-
-        def attributes
           {
-            title: form.title,
-            slogan: form.slogan,
-            slug: form.slug,
-            weight: form.weight,
-            hashtag: form.hashtag,
-            description: form.description,
-            short_description: form.short_description,
-            objectives: form.objectives,
-            location: form.location,
-            start_date: form.start_date,
-            end_date: form.end_date,
-            promoted: form.promoted,
-            scopes_enabled: form.scopes_enabled,
-            scope: form.scope,
-            show_statistics: form.show_statistics
-          }.merge(
-            attachment_attributes(:hero_image, :banner_image)
-          )
+            available_slots: form.available_slots,
+            registration_terms: form.registration_terms
+          }
         end
 
+        def attributes = super.merge(registration_attributes)
+
         def send_notification_registrations_enabled
           Decidim::EventsManager.publish(
             event: "decidim.events.conferences.registrations_enabled",
             event_class: Decidim::Conferences::ConferenceRegistrationsEnabledEvent,
-            resource: @conference,
-            followers: @conference.followers
+            resource:,
+            followers: resource.followers
           )
         end
 
         def should_notify_followers_registrations_enabled?
-          @conference.previous_changes["registrations_enabled"].present? &&
-            @conference.registrations_enabled? &&
-            @conference.published?
+          resource.previous_changes["registrations_enabled"].present? &&
+            resource.registrations_enabled? &&
+            resource.published?
         end
 
         def send_notification_update_conference
           Decidim::EventsManager.publish(
             event: "decidim.events.conferences.conference_updated",
             event_class: Decidim::Conferences::UpdateConferenceEvent,
-            resource: @conference,
-            followers: @conference.followers
+            resource:,
+            followers: resource.followers
           )
         end
 
         def should_notify_followers_update_conference?
-          important_attributes.any? { |attr| @conference.previous_changes[attr].present? } &&
-            @conference.published?
+          important_attributes.any? { |attr| resource.previous_changes[attr].present? } &&
+            resource.published?
         end
 
         def important_attributes
@@ -126,31 +68,31 @@ module Decidim
         end
 
         def start_date_changed?
-          @conference.previous_changes["start_date"].present?
+          resource.previous_changes["start_date"].present?
         end
 
         def schedule_upcoming_conference_notification
-          checksum = Decidim::Conferences::UpcomingConferenceNotificationJob.generate_checksum(@conference)
+          checksum = Decidim::Conferences::UpcomingConferenceNotificationJob.generate_checksum(resource)
 
           Decidim::Conferences::UpcomingConferenceNotificationJob
-            .set(wait_until: (@conference.start_date - 2.days).to_s)
-            .perform_later(@conference.id, checksum)
+            .set(wait_until: (resource.start_date - 2.days).to_s)
+            .perform_later(resource.id, checksum)
         end
 
         def participatory_processes
-          @participatory_processes ||= @conference.participatory_space_sibling_scope(:participatory_processes).where(id: @form.participatory_processes_ids)
+          @participatory_processes ||= resource.participatory_space_sibling_scope(:participatory_processes).where(id: form.participatory_processes_ids)
         end
 
         def link_participatory_processes
-          @conference.link_participatory_space_resources(participatory_processes, "included_participatory_processes")
+          resource.link_participatory_space_resources(participatory_processes, "included_participatory_processes")
         end
 
         def assemblies
-          @assemblies ||= @conference.participatory_space_sibling_scope(:assemblies).where(id: @form.assemblies_ids)
+          @assemblies ||= resource.participatory_space_sibling_scope(:assemblies).where(id: form.assemblies_ids)
         end
 
         def link_assemblies
-          @conference.link_participatory_space_resources(assemblies, "included_assemblies")
+          resource.link_participatory_space_resources(assemblies, "included_assemblies")
         end
       end
     end

data/app/commands/decidim/conferences/admin/update_conference_speaker.rb

@@ -5,94 +5,37 @@ module Decidim
     module Admin
       # A command with all the business logic when updating a conference
       # speaker in the system.
-      class UpdateConferenceSpeaker < Decidim::Command
-        include ::Decidim::AttachmentAttributesMethods
+      class UpdateConferenceSpeaker < Decidim::Commands::UpdateResource
+        fetch_file_attributes :avatar
 
-        # Public: Initializes the command.
-        #
-        # form - A form object with the params.
-        # conference_speaker - The ConferenceSpeaker to update
-        def initialize(form, conference_speaker)
-          @form = form
-          @conference_speaker = conference_speaker
-        end
-
-        # Executes the command. Broadcasts these events:
-        #
-        # - :ok when everything is valid.
-        # - :invalid if the form was not valid and we could not proceed.
-        #
-        # Returns nothing.
-        def call
-          return broadcast(:invalid) if form.invalid?
-          return broadcast(:invalid) unless conference_speaker
-
-          # We are going to assign the attributes only to handle the validation of the avatar before accessing
-          # `update_conference_speaker!` which uses `update!`. Without this step, the image validation may render
-          # an ActiveRecord::RecordInvalid error
-          # After we assign and check if the object is valid, we reload the model to let it be handled the old way
-          # If there is an error we add the error to the form
-          conference_speaker.assign_attributes(attributes)
-
-          if conference_speaker.valid?
-            conference_speaker.reload
-
-            transaction do
-              update_conference_speaker!
-              link_meetings(@conference_speaker)
-            end
-            broadcast(:ok)
-          else
-            form.errors.add(:avatar, conference_speaker.errors[:avatar]) if conference_speaker.errors.include? :avatar
-
-            broadcast(:invalid)
-          end
-        end
-
-        private
+        fetch_form_attributes :full_name, :twitter_handle, :personal_url, :position, :affiliation, :user, :short_bio
 
-        attr_reader :form, :conference_speaker
+        protected
 
-        def attributes
-          form.attributes.slice(
-            "full_name",
-            "twitter_handle",
-            "personal_url",
-            "position",
-            "affiliation",
-            "short_bio"
-          ).symbolize_keys.merge(
-            user: form.user
-          ).merge(
-            attachment_attributes(:avatar)
-          )
+        def invalid?
+          form.invalid? || !resource
         end
 
-        def update_conference_speaker!
-          log_info = {
+        def extra_params
+          {
             resource: {
-              title: conference_speaker.full_name
+              title: resource.full_name
             },
             participatory_space: {
-              title: conference_speaker.conference.title
+              title: resource.conference.title
             }
           }
-
-          Decidim.traceability.update!(
-            conference_speaker,
-            form.current_user,
-            attributes,
-            log_info
-          )
         end
 
-        def conference_meetings(speaker)
-          meeting_components = speaker.conference.components.where(manifest_name: "meetings")
-          Decidim::ConferenceMeeting.where(component: meeting_components).where(id: @form.attributes[:conference_meeting_ids])
+        private
+
+        def conference_meetings
+          meeting_components = resource.conference.components.where(manifest_name: "meetings")
+          Decidim::ConferenceMeeting.where(component: meeting_components).where(id: form.conference_meeting_ids)
         end
 
-        def link_meetings(conference_speaker)
-          conference_speaker.conference_meetings = conference_meetings(conference_speaker)
+        def run_after_hooks
+          resource.conference_meetings = conference_meetings
         end
       end
     end

data/app/commands/decidim/conferences/admin/update_media_link.rb

@@ -5,58 +5,22 @@ module Decidim
     module Admin
       # A command with all the business logic when updating a conference
       # speaker in the system.
-      class UpdateMediaLink < Decidim::Command
-        # Public: Initializes the command.
-        #
-        # form - A form object with the params.
-        # media_link - The ConferenceSpeaker to update
-        def initialize(form, media_link)
-          @form = form
-          @media_link = media_link
-        end
-
-        # Executes the command. Broadcasts these events:
-        #
-        # - :ok when everything is valid.
-        # - :invalid if the form was not valid and we could not proceed.
-        #
-        # Returns nothing.
-        def call
-          return broadcast(:invalid) if form.invalid?
-          return broadcast(:invalid) unless media_link
-
-          transaction do
-            update_media_link!
-          end
+      class UpdateMediaLink < Decidim::Commands::UpdateResource
+        fetch_form_attributes :title, :link, :weight, :date
 
-          broadcast(:ok)
-        end
-
-        private
+        protected
 
-        attr_reader :form, :media_link
+        def invalid? = form.invalid? || !resource
 
-        def update_media_link!
-          log_info = {
+        def extra_params
+          {
             resource: {
-              title: media_link.title
+              title: resource.title
             },
             participatory_space: {
-              title: media_link.conference.title
+              title: resource.conference.title
             }
           }
-
-          Decidim.traceability.update!(
-            media_link,
-            form.current_user,
-            form.attributes.slice(
-              "title",
-              "link",
-              "weight",
-              "date"
-            ).symbolize_keys,
-            log_info
-          )
         end
       end
     end