decidim-assemblies 0.31.3 → 0.32.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b390ecc1992cc0c80979a2dd3009efae463a452f3c051190409abb098ed060a9
-  data.tar.gz: 2f68bbb23efa90ea3bd940c7d8f28d4468703e699c406ddcb32eb2c3d64896ae
+  metadata.gz: e281f489f7f47da21acec28d2771d799f6a46de0d0ca7fb34d1a6e4f9baa8a32
+  data.tar.gz: 3b173a11dc651d6dececd6c9c05022365e85f91e406abd0ba1b06d4e0c5e079e
 SHA512:
-  metadata.gz: ab090584ef6a4dc05849df9c88daff436857b44241f712bc319fcc7e8a4eb77f7c3003f1524fe9495a8a9607bdcdf6a1fdaf3f82c80da9d51d516527ca1a553c
-  data.tar.gz: 7836b2a30013e7e032f8271d6c3935b43732c65aecbca6e3ff8f01f7dd3376769c4feac7620389bbed10e44ac99109da03ab479bb0c3afd283d968fa2aa897a2
+  metadata.gz: 1a2e340210186d6225909ff074fae66f02b153cc63808ff8d14ae2d723be1d1a3acf02e95962869e2f2f1250d83cb608b3953801170e6fc60e3d60255f919328
+  data.tar.gz: 4f334da82cd6ce0ddb35b3a7a51c6bf2efb00a3b301f8e413db1a5d6d308861f04cef4f2da55870fb39536960c765e157b3bf04484d4d1bead3188790e26dc5b

data/README.md

@@ -1,4 +1,4 @@
-# Decidim::Assemblies
+# decidim-assemblies
 
 Assemblies are the permanent Decidim's participatory space. They are always
 "active" so unlike participatory processes, they have no steps or phases.
@@ -15,19 +15,11 @@ This module provides:
 
 * Public views for assembly via a high level section in the main menu.
 
-## Installation
-
-Add this line to your application's Gemfile:
+You can see the documentation of this feature at the [Decidim Documentation](https://docs.decidim.org/en/develop/admin/spaces/assemblies).
 
-```ruby
-gem 'decidim-assemblies'
-```
-
-And then execute:
+## Installation
 
-```bash
-bundle
-```
+This is on the default Decidim installation so you should not change anything to use this participatory space.
 
 ## Contributing
 

data/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb

@@ -7,6 +7,7 @@ module Decidim
         include AssembliesHelper
         include Decidim::ComponentPathHelper
         include ActiveLinkTo
+        include Decidim::ActiveLinkToHelper
 
         EXTRA_ATTRIBUTES = %w(purpose_of_action internal_organisation composition).freeze
 

data/app/commands/decidim/assemblies/admin/create_assembly.rb

@@ -6,15 +6,15 @@ module Decidim
       # A command with all the business logic when creating a new assembly
       # in the system.
       class CreateAssembly < Decidim::Commands::CreateResource
-        fetch_file_attributes :hero_image, :banner_image
+        fetch_file_attributes :hero_image
 
         fetch_form_attributes :title, :subtitle, :weight, :slug, :description, :short_description,
-                              :promoted, :taxonomizations, :parent, :announcement, :organization,
-                              :private_space, :developer_group, :local_area, :target, :participatory_scope,
+                              :promoted, :taxonomizations, :parent, :organization,
+                              :access_mode, :developer_group, :local_area, :target, :participatory_scope,
                               :participatory_structure, :meta_scope, :purpose_of_action,
                               :composition, :creation_date, :created_by, :created_by_other,
                               :duration, :included_at, :closing_date, :closing_date_reason, :internal_organisation,
-                              :is_transparent, :special_features, :twitter_handler, :facebook_handler,
+                              :has_members, :special_features, :twitter_handler, :facebook_handler,
                               :instagram_handler, :youtube_handler, :github_handler
 
         protected

data/app/commands/decidim/assemblies/admin/duplicate_assembly.rb

@@ -58,13 +58,12 @@ module Decidim
             participatory_scope: @assembly.participatory_scope,
             participatory_structure: @assembly.participatory_structure,
             meta_scope: @assembly.meta_scope,
-            announcement: @assembly.announcement,
             taxonomies: @assembly.taxonomies
           )
         end
 
         def duplicate_assembly_attachments
-          [:hero_image, :banner_image].each do |attribute|
+          [:hero_image].each do |attribute|
             next unless @assembly.attached_uploader(attribute).attached?
 
             @duplicated_assembly.send(attribute).attach(@assembly.send(attribute).blob)

data/app/commands/decidim/assemblies/admin/update_assembly.rb

@@ -6,14 +6,14 @@ module Decidim
       # A command with all the business logic when updating a new assembly
       # in the system.
       class UpdateAssembly < Decidim::Commands::UpdateResource
-        fetch_file_attributes :hero_image, :banner_image
+        fetch_file_attributes :hero_image
 
         fetch_form_attributes :title, :subtitle, :slug, :promoted, :description, :short_description,
-                              :taxonomizations, :parent, :private_space, :developer_group, :local_area,
+                              :taxonomizations, :parent, :access_mode, :developer_group, :local_area,
                               :target, :participatory_scope, :participatory_structure, :meta_scope,
                               :purpose_of_action, :composition, :creation_date, :created_by,
                               :created_by_other, :duration, :included_at, :closing_date, :closing_date_reason,
-                              :internal_organisation, :is_transparent, :special_features, :twitter_handler, :announcement,
+                              :internal_organisation, :has_members, :special_features, :twitter_handler,
                               :facebook_handler, :instagram_handler, :youtube_handler, :github_handler, :weight
 
         private

data/app/controllers/concerns/decidim/assemblies/admin/filterable.rb

@@ -25,15 +25,19 @@ module Decidim
           end
 
           def filters
-            [:private_space_eq, :published_at_null]
+            [:with_any_access_mode, :published_at_null]
           end
 
           def filters_with_values
             {
-              private_space_eq: [true, false],
+              with_any_access_mode: access_modes,
               published_at_null: [true, false]
             }
           end
+
+          def access_modes
+            Assembly::ACCESS_MODES.keys
+          end
         end
       end
     end

data/app/controllers/concerns/decidim/assemblies/assembly_breadcrumb.rb

@@ -12,14 +12,11 @@ module Decidim
         return {} if current_participatory_space.blank?
         return super unless current_participatory_space.is_a?(Decidim::Assembly)
 
-        dropdown_cell = current_participatory_space_manifest.breadcrumb_cell
-
         items = current_participatory_space.ancestors.map do |participatory_space|
           {
             label: participatory_space.title,
             url: Decidim::ResourceLocatorPresenter.new(participatory_space).path,
             active: false,
-            dropdown_cell:,
             resource: participatory_space
           }
         end

data/app/controllers/decidim/assemblies/admin/assemblies_controller.rb

@@ -37,7 +37,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("assemblies.create.error", scope: "decidim.admin")
-              render :new, status: :unprocessable_entity
+              render :new, status: :unprocessable_content
             end
           end
         end
@@ -63,7 +63,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("assemblies.update.error", scope: "decidim.admin")
-              render :edit, layout: "decidim/admin/assembly", status: :unprocessable_entity
+              render :edit, layout: "decidim/admin/assembly", status: :unprocessable_content
             end
           end
         end

data/app/controllers/decidim/assemblies/admin/assembly_duplicates_controller.rb

@@ -25,7 +25,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("assemblies_duplicates.create.error", scope: "decidim.admin")
-              render :new, status: :unprocessable_entity
+              render :new, status: :unprocessable_content
             end
           end
         end

data/app/controllers/decidim/assemblies/admin/assembly_imports_controller.rb

@@ -24,7 +24,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("assembly_imports.create.error", scope: "decidim.admin")
-              render :new, status: :unprocessable_entity
+              render :new, status: :unprocessable_content
             end
           end
         end

data/app/controllers/decidim/assemblies/admin/concerns/assembly_admin.rb

@@ -19,6 +19,7 @@ module Decidim
 
           included do
             include Decidim::Admin::ParticipatorySpaceAdminContext
+
             helper_method :current_assembly
             add_breadcrumb_item_from_menu :admin_assembly_menu
 

data/app/controllers/decidim/assemblies/admin/members_controller.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Assemblies
+    module Admin
+      # Controller that allows managing assembly members
+      # on assemblies
+      class MembersController < Decidim::Assemblies::Admin::ApplicationController
+        include Concerns::AssemblyAdmin
+        include Decidim::Admin::ParticipatorySpace::Concerns::HasMembers
+      end
+    end
+  end
+end

data/app/controllers/decidim/assemblies/admin/members_csv_imports_controller.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Assemblies
+    module Admin
+      # Controller that allows importing assembly members
+      # on assemblies
+      class MembersCsvImportsController < Decidim::Admin::ApplicationController
+        include Concerns::AssemblyAdmin
+        include Decidim::Admin::ParticipatorySpace::Concerns::HasMembersCsvImport
+
+        def after_import_path
+          members_path(current_assembly)
+        end
+
+        def participatory_space
+          current_assembly
+        end
+      end
+    end
+  end
+end

data/app/controllers/decidim/assemblies/{participatory_space_private_users_controller.rb → members_controller.rb}

@@ -2,9 +2,9 @@
 
 module Decidim
   module Assemblies
-    class ParticipatorySpacePrivateUsersController < Decidim::Assemblies::ApplicationController
+    class MembersController < Decidim::Assemblies::ApplicationController
       include ParticipatorySpaceContext
-      include Decidim::HasMembersPage
+      include Decidim::ParticipatorySpace::HasMembersPage
 
       def index
         raise ActionController::RoutingError, "No members for this assembly" if members.none?

data/app/forms/decidim/assemblies/admin/assembly_form.rb

@@ -31,7 +31,6 @@ module Decidim
         translatable_attribute :subtitle, String
         translatable_attribute :target, String
         translatable_attribute :title, String
-        translatable_attribute :announcement, Decidim::Attributes::RichText
 
         attribute :created_by, String
         attribute :facebook_handler, String
@@ -45,18 +44,16 @@ module Decidim
         attribute :participatory_processes_ids, Array[Integer]
         attribute :weight, Integer, default: 0
 
-        attribute :is_transparent, Boolean
+        attribute :access_mode, String, default: :open
+        attribute :has_members, Boolean
         attribute :promoted, Boolean
-        attribute :private_space, Boolean
 
         attribute :closing_date, Decidim::Attributes::LocalizedDate
         attribute :creation_date, Decidim::Attributes::LocalizedDate
         attribute :duration, Decidim::Attributes::LocalizedDate
         attribute :included_at, Decidim::Attributes::LocalizedDate
 
-        attribute :banner_image
         attribute :hero_image
-        attribute :remove_banner_image, Boolean, default: false
         attribute :remove_hero_image, Boolean, default: false
 
         validates :parent, presence: true, if: ->(form) { form.parent.present? }
@@ -69,11 +66,13 @@ module Decidim
         validates :created_by_other, translatable_presence: true, if: ->(form) { form.created_by == "others" }
         validates :title, :subtitle, :description, :short_description, translatable_presence: true
 
-        validates :banner_image, passthru: { to: Decidim::Assembly }
         validates :hero_image, passthru: { to: Decidim::Assembly }
 
         validates :weight, presence: true
 
+        validates :access_mode, presence: true, inclusion: { in: Decidim::Assembly.access_modes.keys }
+        validate :ensure_access_mode_for_has_members
+
         alias organization current_organization
 
         def participatory_space_manifest
@@ -125,6 +124,10 @@ module Decidim
 
           errors.add(:slug, :taken)
         end
+
+        def ensure_access_mode_for_has_members
+          self.access_mode = :open if has_members == false
+        end
       end
     end
   end

data/app/helpers/decidim/assemblies/assemblies_helper.rb

@@ -23,8 +23,8 @@ module Decidim
           *(if participatory_space.members_public_page?
               [{
                 name: t("assembly_member_menu_item", scope: "layouts.decidim.assembly_navigation"),
-                url: decidim_assemblies.assembly_participatory_space_private_users_path(participatory_space),
-                active: is_active_link?(decidim_assemblies.assembly_participatory_space_private_users_path(participatory_space), :inclusive)
+                url: decidim_assemblies.assembly_members_path(participatory_space),
+                active: is_active_link?(decidim_assemblies.assembly_members_path(participatory_space), :inclusive)
               }]
             end
            )

data/app/helpers/decidim/assemblies/filter_assemblies_helper.rb

@@ -10,7 +10,8 @@ module Decidim
         items = []
 
         available_taxonomy_filters.find_each do |taxonomy_filter|
-          items.append(method: "with_any_taxonomies[#{taxonomy_filter.root_taxonomy_id}]",
+          items.append(method: :with_any_taxonomies,
+                       name: "[with_any_taxonomies][#{taxonomy_filter.root_taxonomy_id}]",
                        collection: filter_taxonomy_values_for(taxonomy_filter),
                        label: decidim_sanitize_translated(taxonomy_filter.name),
                        id: "taxonomy-#{taxonomy_filter.root_taxonomy_id}")

data/app/models/decidim/assembly.rb

@@ -31,7 +31,7 @@ module Decidim
     include Decidim::Traceable
     include Decidim::Loggable
     include Decidim::ParticipatorySpaceResourceable
-    include Decidim::HasPrivateUsers
+    include Decidim::ParticipatorySpace::HasMembers
     include Decidim::Searchable
     include Decidim::HasUploadValidations
     include Decidim::TranslatableResource
@@ -53,10 +53,6 @@ module Decidim
                foreign_key: "decidim_area_id",
                class_name: "Decidim::Area",
                optional: true
-    belongs_to :assembly_type,
-               foreign_key: "decidim_assemblies_type_id",
-               class_name: "Decidim::AssembliesType",
-               optional: true
     has_many :categories,
              foreign_key: "decidim_participatory_space_id",
              foreign_type: "decidim_participatory_space_type",
@@ -71,9 +67,6 @@ module Decidim
     has_one_attached :hero_image
     validates_upload :hero_image, uploader: Decidim::HeroImageUploader
 
-    has_one_attached :banner_image
-    validates_upload :banner_image, uploader: Decidim::BannerImageUploader
-
     validates :slug, uniqueness: { scope: :organization }
     validates :slug, presence: true, format: { with: Decidim::Assembly.slug_format }
 
@@ -92,10 +85,14 @@ module Decidim
                       index_on_create: ->(_assembly) { false },
                       index_on_update: ->(assembly) { assembly.visible? })
 
-    # Overwriting existing method Decidim::HasPrivateUsers.public_spaces
-    def self.public_spaces
-      where(private_space: false).or(where(private_space: true).where(is_transparent: true)).published
-    end
+    # Access modes are consistent across participatory spaces (assemblies and processes)
+    # open: visible and accessible for all
+    # transparent: visible for all but the actions require to be a member of the space
+    # restricted: visible and accessible only for members fo the space
+    ACCESS_MODES = { open: 0, transparent: 1, restricted: 2 }.freeze
+    enum :access_mode, ACCESS_MODES
+
+    scope_search_multi :with_any_access_mode, ACCESS_MODES.keys
 
     # Scope to return only the promoted assemblies.
     #
@@ -120,7 +117,7 @@ module Decidim
 
     # This is a overwrite for Decidim::ParticipatorySpaceResourceable.visible?
     def visible?
-      published? && (!private_space? || (private_space? && is_transparent?))
+      published? && (open? || transparent?)
     end
 
     def to_param
@@ -157,7 +154,7 @@ module Decidim
     end
 
     def self.ransackable_scopes(_auth_object = nil)
-      [:with_any_taxonomies]
+      [:with_any_taxonomies, :with_any_access_mode]
     end
 
     def shareable_url(share_token)
@@ -169,7 +166,7 @@ module Decidim
 
       return base unless auth_object&.admin?
 
-      base + %w(published_at created_at private_space parent_id)
+      base + %w(published_at created_at parent_id access_mode)
     end
 
     def self.ransackable_associations(_auth_object = nil)

data/app/packs/src/decidim/assemblies/controllers/assembly_admin/assembly_admin.test.js

@@ -363,7 +363,6 @@ describe("AssemblyAdminController", () => {
                       <div aria-disabled="false" aria-label="Choose date" class="wc-datepicker sc-wc-datepicker" role="group">
                       </div>
                     </wc-datepicker>
-                    <button class="datepicker__pick-calendar button button__secondary button__xs" disabled="true" type="button">Select</button>
                     <button class="datepicker__close-calendar button button__transparent-secondary button__xs" type="button">Close</button>
                   </div>
                 </div>
@@ -388,7 +387,6 @@ describe("AssemblyAdminController", () => {
                   <div class="datepicker__container" style="display: none;">
                     <wc-datepicker id="assembly_included_at_date_datepicker" locale="en" class="sc-wc-datepicker-h sc-wc-datepicker-s hydrated">
                     </wc-datepicker>
-                    <button class="datepicker__pick-calendar button button__secondary button__xs" disabled="true" type="button">Select</button>
                     <button class="datepicker__close-calendar button button__transparent-secondary button__xs" type="button">Close</button>
                   </div>
                 </div>
@@ -411,7 +409,6 @@ describe("AssemblyAdminController", () => {
                     </svg>
                   </button>
                   <div class="datepicker__container" style="display: none;">
-                    <button class="datepicker__pick-calendar button button__secondary button__xs" disabled="true" type="button">Select</button>
                     <button class="datepicker__close-calendar button button__transparent-secondary button__xs" type="button">Close</button>
                   </div>
                 </div>
@@ -433,7 +430,6 @@ describe("AssemblyAdminController", () => {
                     </svg>
                   </button>
                   <div class="datepicker__container" style="display: none;">
-                    <button class="datepicker__pick-calendar button button__secondary button__xs" disabled="true" type="button">Select</button>
                     <button class="datepicker__close-calendar button button__transparent-secondary button__xs" type="button">Close</button>
                   </div>
                 </div>
@@ -494,15 +490,6 @@ describe("AssemblyAdminController", () => {
                   <button id="assembly_hero_image_button" name="hero_image" class="button button__sm button__transparent-secondary" type="button" data-dialog-open="upload_c5515a82-b6d4-4c1c-a957-013c9679b956" data-upload="{&quot;addAttribute&quot;:&quot;hero_image&quot;,&quot;resourceName&quot;:&quot;assembly&quot;,&quot;resourceClass&quot;:&quot;Decidim::Assembly&quot;,&quot;required&quot;:false,&quot;maxFileSize&quot;:10485760.0,&quot;multiple&quot;:false,&quot;titled&quot;:false,&quot;formObjectClass&quot;:&quot;Decidim::Assemblies::Admin::AssemblyForm&quot;}" aria-haspopup="dialog">Add image</button>
                 </div>
               </div>
-              <div class="columns">
-                <div class="upload-modal__files-container upload-container-for-banner_image ">
-                  <div>
-                    <label>Banner image</label>
-                    <div class="upload-modal__files" data-active-uploads="upload_0d6b6c3f-3681-450e-dummy-2"></div>
-                  </div>
-                  <button id="assembly_banner_image_button" name="banner_image" class="button button__sm button__transparent-secondary" type="button" data-dialog-open="upload_0d6b6c3f-3681-450e-dummy-2" data-upload="{&quot;addAttribute&quot;:&quot;banner_image&quot;,&quot;resourceName&quot;:&quot;assembly&quot;,&quot;resourceClass&quot;:&quot;Decidim::Assembly&quot;,&quot;required&quot;:false,&quot;maxFileSize&quot;:10485760.0,&quot;multiple&quot;:false,&quot;titled&quot;:false,&quot;formObjectClass&quot;:&quot;Decidim::Assemblies::Admin::AssemblyForm&quot;}" aria-haspopup="dialog">Add image</button>
-                </div>
-              </div>
             </div>
           </div>
         </div>
@@ -748,7 +735,7 @@ describe("AssemblyAdminController", () => {
               <label for="assembly_private_space">
                 <input name="assembly[private_space]" type="hidden" value="0" autocomplete="off">
                 <input type="checkbox" value="1" name="assembly[private_space]" id="assembly_private_space">Private space </label>
-              <p class="help-text">You will be able to manage private participants after setting it as private</p>
+              <p class="help-text">You will be able to manage members after setting it as private</p>
             </div>
             <div class="row column" id="is_transparent">
               <label for="assembly_is_transparent">
@@ -870,28 +857,6 @@ describe("AssemblyAdminController", () => {
     it("should initialize the controller and set up event listeners", () => {
       expect(controller).toBeDefined();
       expect(element).toBeDefined();
-
-      // Test that initial state is set correctly
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      expect(isTransparentCheckbox.disabled).toBe(true);
-      expect(specialFeatures.style.display).toBe("none");
-    });
-
-    it("should call assignBehavior for assembly_type and created_by fields", () => {
-      const assemblyType = element.querySelector("#assembly_assembly_type");
-      const createdBy = element.querySelector("#assembly_created_by");
-
-      expect(assemblyType).toBeDefined();
-      expect(createdBy).toBeDefined();
-
-      // Verify that event listeners are attached by triggering changes
-      // const assemblyTypeOther = element.querySelector("#assembly_type_other");
-      const createdByOther = element.querySelector("#created_by_other");
-
-      // expect(assemblyTypeOther.style.display).toBe("none");
-      expect(createdByOther.style.display).toBe("none");
     });
   });
 
@@ -931,16 +896,6 @@ describe("AssemblyAdminController", () => {
       // Should hide initially if value is not "others"
       expect(targetDiv.style.display).toBe("none");
     });
-
-    it("should handle null elements gracefully", () => {
-      expect(() => {
-        controller.attachVisibility(null, null);
-      }).not.toThrow();
-
-      expect(() => {
-        controller.attachVisibility(element.querySelector("#assembly_assembly_type"), null);
-      }).not.toThrow();
-    });
   });
 
   describe("toggleDependsOnSelect", () => {
@@ -963,79 +918,6 @@ describe("AssemblyAdminController", () => {
 
       expect(targetDiv.style.display).toBe("none");
     });
-
-    it("should return early if target or showDiv is null", () => {
-      const select = element.querySelector("#assembly_assembly_type");
-
-      expect(() => {
-        controller.toggleDependsOnSelect(null, null);
-      }).not.toThrow();
-
-      expect(() => {
-        controller.toggleDependsOnSelect(select, null);
-      }).not.toThrow();
-    });
-  });
-
-  describe("toggleDisabledHiddenFields", () => {
-    it("should initially disable transparent checkbox and hide special features", () => {
-      controller.toggleDisabledHiddenFields();
-
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      expect(isTransparentCheckbox.disabled).toBe(true);
-      expect(specialFeatures.style.display).toBe("none");
-    });
-
-    it("should enable transparent checkbox and show special features when private space is checked", () => {
-      const privateSpaceCheckbox = element.querySelector("#private_space input[type='checkbox']");
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      // Check private space checkbox
-      privateSpaceCheckbox.checked = true;
-
-      controller.toggleDisabledHiddenFields();
-
-      expect(isTransparentCheckbox.disabled).toBe(false);
-      expect(specialFeatures.style.display).toBe("block");
-    });
-
-    it("should disable transparent checkbox and hide special features when private space is unchecked", () => {
-      const privateSpaceCheckbox = element.querySelector("#private_space input[type='checkbox']");
-      const isTransparentCheckbox = element.querySelector("#is_transparent input[type='checkbox']");
-      const specialFeatures = element.querySelector("#special_features");
-
-      // Uncheck private space checkbox
-      privateSpaceCheckbox.checked = false;
-
-      controller.toggleDisabledHiddenFields();
-
-      expect(isTransparentCheckbox.disabled).toBe(true);
-      expect(specialFeatures.style.display).toBe("none");
-    });
-
-    it("should handle missing elements gracefully", () => {
-      // Remove elements to test graceful handling
-      element.querySelector("#private_space").remove();
-      element.querySelector("#is_transparent").remove();
-      element.querySelector("#special_features").remove();
-
-      expect(() => {
-        controller.toggleDisabledHiddenFields();
-      }).not.toThrow();
-    });
-
-    it("should handle missing checkbox inside transparent div", () => {
-      // Remove checkbox from transparent div
-      const isTransparent = element.querySelector("#is_transparent");
-      isTransparent.innerHTML = "";
-
-      expect(() => {
-        controller.toggleDisabledHiddenFields();
-      }).not.toThrow();
-    });
   });
 
   describe("integration tests", () => {
@@ -1063,15 +945,4 @@ describe("AssemblyAdminController", () => {
     });
   });
 
-  describe("edge cases", () => {
-    it("should handle elements with no checkbox inside", () => {
-      // Replace private space with div that has no checkbox
-      const privateSpace = element.querySelector("#private_space");
-      privateSpace.innerHTML = "<div>No checkbox here</div>";
-
-      expect(() => {
-        controller.toggleDisabledHiddenFields();
-      }).not.toThrow();
-    });
-  });
 });

data/app/packs/src/decidim/assemblies/controllers/assembly_admin/controller.js

@@ -2,14 +2,6 @@ import { Controller } from "@hotwired/stimulus"
 
 export default class extends Controller {
   connect() {
-    const privateSpace = this.element.querySelector("#private_space");
-
-    if (privateSpace) {
-      privateSpace.addEventListener("change", this.toggleDisabledHiddenFields);
-    }
-    this.toggleDisabledHiddenFields();
-
-    this.assignBehavior("assembly_type");
     this.assignBehavior("created_by");
   }
 
@@ -39,24 +31,4 @@ export default class extends Controller {
       showDiv.style.display = "block";
     }
   }
-
-  toggleDisabledHiddenFields() {
-    const privateSpace = document.getElementById("private_space");
-    const isTransparent = document.getElementById("is_transparent");
-    const specialFeatures = document.getElementById("special_features");
-
-    const enabledPrivateSpace = privateSpace?.querySelector("input[type='checkbox']")?.checked;
-    const isTransparentCheckbox = isTransparent?.querySelector("input[type='checkbox']");
-
-    if (isTransparentCheckbox) {
-      isTransparentCheckbox.disabled = (enabledPrivateSpace === false);
-    }
-
-    if (specialFeatures) {
-      specialFeatures.style.display = enabledPrivateSpace
-        ? "block"
-        : "none";
-    }
-  }
-
 }