decidim-admin 0.4.4 → 0.5.0

data/app/controllers/decidim/admin/scopes_controller.rb

@@ -6,10 +6,15 @@ module Decidim
     #
     class ScopesController < Decidim::Admin::ApplicationController
       layout "decidim/admin/settings"
+      helper_method :scope, :parent_scope, :add_scope_path, :current_scopes_path
 
       def index
         authorize! :index, Scope
-        @scopes = collection
+        @scopes = if parent_scope
+                    parent_scope.children
+                  else
+                    collection.top_level
+                  end
       end
 
       def new
@@ -20,11 +25,10 @@ module Decidim
       def create
         authorize! :new, Scope
         @form = form(ScopeForm).from_params(params)
-
-        CreateScope.call(@form) do
+        CreateScope.call(@form, parent_scope) do
           on(:ok) do
             flash[:notice] = I18n.t("scopes.create.success", scope: "decidim.admin")
-            redirect_to scopes_path
+            redirect_to current_scopes_path
           end
 
           on(:invalid) do
@@ -40,14 +44,13 @@ module Decidim
       end
 
       def update
-        @scope = collection.find(params[:id])
         authorize! :update, scope
         @form = form(ScopeForm).from_params(params)
 
         UpdateScope.call(scope, @form) do
           on(:ok) do
             flash[:notice] = I18n.t("scopes.update.success", scope: "decidim.admin")
-            redirect_to scopes_path
+            redirect_to current_scopes_path
           end
 
           on(:invalid) do
@@ -63,7 +66,7 @@ module Decidim
 
         flash[:notice] = I18n.t("scopes.destroy.success", scope: "decidim.admin")
 
-        redirect_to scopes_path
+        redirect_to current_scopes_path
       end
 
       private
@@ -72,9 +75,21 @@ module Decidim
         @scope ||= collection.find(params[:id])
       end
 
+      def parent_scope
+        @parent_scope ||= @scope ? @scope.parent : collection.find_by_id(params[:scope_id])
+      end
+
       def collection
         current_organization.scopes
       end
+
+      def current_scopes_path
+        if parent_scope
+          scope_scopes_path(parent_scope)
+        else
+          scopes_path
+        end
+      end
     end
   end
 end

data/app/controllers/decidim/admin/user_groups_controller.rb

@@ -4,7 +4,7 @@ module Decidim
   module Admin
     # Controller that allows managing user groups at the admin panel.
     #
-    class UserGroupsController < ApplicationController
+    class UserGroupsController < Decidim::Admin::ApplicationController
       layout "decidim/admin/users"
 
       def index

data/app/controllers/decidim/admin/users_controller.rb

@@ -21,7 +21,6 @@ module Decidim
         default_params = {
           organization: current_organization,
           invitation_instructions: "invite_admin",
-          admin: true,
           invited_by: current_user,
           comments_notifications: true,
           replies_notifications: true
@@ -81,7 +80,7 @@ module Decidim
       end
 
       def collection
-        @collection ||= current_organization.admins
+        @collection ||= current_organization.admins.or(current_organization.users_with_any_role)
       end
     end
   end

data/app/forms/decidim/admin/impersonate_managed_user_form.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A form object used to impersonate managed users from the admin dashboard.
+    #
+    # This form will contain a dynamic attribute for the user authorization.
+    # This authorization will be selected by the admin user if more than one exists.
+    class ImpersonateManagedUserForm < Form
+      def initialize(attributes)
+        extend(Virtus.model)
+
+        # Set the authorization dynamic attribute as a nested form class based on the handler name.
+        attribute(:authorization, attributes.dig(:authorization, :handler_name).classify.constantize)
+
+        super
+      end
+    end
+  end
+end

data/app/forms/decidim/admin/managed_user_form.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A form object used to create managed users from the admin dashboard.
+    #
+    # This form will contain a dynamic attribute for the user authorization.
+    # This authorization will be selected by the admin user if more than one exists.
+    class ManagedUserForm < Form
+      attribute :name, String
+
+      validates :name, presence: true
+      validate :authorization_uniqueness
+
+      def initialize(attributes)
+        extend(Virtus.model)
+
+        # Set the authorization dynamic attribute as a nested form class based on the handler name.
+        attribute(:authorization, attributes.dig(:authorization, :handler_name).classify.constantize)
+
+        super
+      end
+
+      private
+
+      def authorization_uniqueness
+        errors.add :authorization, :invalid if Authorization.where(
+          user: current_organization.users,
+          name: authorization.handler_name,
+          unique_id: authorization.unique_id
+        ).exists?
+      end
+    end
+  end
+end

data/app/forms/decidim/admin/managed_user_promotion_form.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A form object used to promote managed users from the admin dashboard.
+    #
+    class ManagedUserPromotionForm < Form
+      attribute :email, String
+
+      validates :email, presence: true
+    end
+  end
+end

data/app/forms/decidim/admin/participatory_process_form.rb

@@ -18,6 +18,7 @@ module Decidim
       translatable_attribute :target, String
       translatable_attribute :participatory_scope, String
       translatable_attribute :participatory_structure, String
+      translatable_attribute :announcement, String
 
       mimic :participatory_process
 
@@ -25,6 +26,7 @@ module Decidim
       attribute :slug, String
       attribute :hashtag, String
       attribute :promoted, Boolean
+      attribute :scopes_enabled, Boolean
       attribute :scope_id, Integer
       attribute :hero_image
       attribute :remove_hero_image

data/app/forms/decidim/admin/scope_form.rb

@@ -4,21 +4,32 @@ module Decidim
   module Admin
     # A form object to create or update scopes.
     class ScopeForm < Form
-      attribute :name, String
+      include TranslatableAttributes
+
+      translatable_attribute :name, String
       attribute :organization, Decidim::Organization
+      attribute :code, String
+      attribute :parent_id, Integer
+      attribute :scope_type_id, Integer
+
       mimic :scope
 
-      validates :name, :organization, presence: true
-      validate :name, :name_uniqueness
+      validates :name, translatable_presence: true
+      validates :organization, :code, presence: true
+      validate :code, :code_uniqueness
 
       alias organization current_organization
 
+      def scope_type
+        Decidim::ScopeType.find_by_id(scope_type_id) if scope_type_id
+      end
+
       private
 
-      def name_uniqueness
-        return unless organization && organization.scopes.where(name: name).where.not(id: id).any?
+      def code_uniqueness
+        return unless organization && organization.scopes.where(code: code).where.not(id: id).any?
 
-        errors.add(:name, :taken)
+        errors.add(:code, :taken)
       end
     end
   end

data/app/forms/decidim/admin/scope_type_form.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A form object to create or update scopes.
+    class ScopeTypeForm < Form
+      include TranslatableAttributes
+
+      translatable_attribute :name, String
+      translatable_attribute :plural, String
+      attribute :organization, Decidim::Organization
+
+      mimic :scope_type
+
+      validates :name, :plural, translatable_presence: true
+      validates :organization, presence: true
+
+      alias organization current_organization
+    end
+  end
+end

data/app/helpers/decidim/admin/scopes_helper.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # This module includes helpers to show scopes in admin
+    module ScopesHelper
+      Option = Struct.new(:id, :name)
+
+      # Public: This helper shows the path to the given scope, linking each ancestor.
+      #
+      # current_scope - Scope object to show
+      #
+      def scope_breadcrumbs(current_scope)
+        current_scope.part_of_scopes.map do |scope|
+          if scope == current_scope
+            translated_attribute(scope.name)
+          else
+            link_to translated_attribute(scope.name), scope_scopes_path(scope)
+          end
+        end
+      end
+
+      # Public: A formatted collection of scopes for a given organization to be used
+      # in forms.
+      #
+      # organization - Organization object
+      #
+      # Returns an Array.
+      def organization_scope_types(organization = current_organization)
+        [Option.new("", "-")] +
+          organization.scope_types.map do |scope_type|
+            Option.new(scope_type.id, translated_attribute(scope_type.name))
+          end
+      end
+
+      # Public: Check if the given scopable object has the scope enabled or not.
+      #
+      # scopable - A scopable object.
+      #
+      # Returns a Boolean.
+      def scopes_enabled?(scopable)
+        scopable.scopes_enabled?
+      end
+    end
+  end
+end

data/app/helpers/decidim/admin/settings_helper.rb

@@ -23,7 +23,18 @@ module Decidim
       #
       # Returns a rendered form field.
       def settings_attribute_input(form, attribute, name, options = {})
-        form.send(TYPES[attribute.type.to_sym], name, options)
+        if attribute.translated?
+          form.send(:translated, form_method_for_attribute(attribute), name, options.merge(tabs_id: "#{options[:tabs_prefix]}-#{name}-tabs"))
+        else
+          form.send(form_method_for_attribute(attribute), name, options)
+        end
+      end
+
+      private
+
+      def form_method_for_attribute(attribute)
+        return :editor if attribute.type.to_sym == :text && attribute.editor?
+        TYPES[attribute.type.to_sym]
       end
     end
   end

data/app/jobs/decidim/admin/expire_impersonation_job.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    class ExpireImpersonationJob < ApplicationJob
+      queue_as :default
+
+      def perform(user, current_user)
+        impersonation_log = Decidim::ImpersonationLog.where(admin: current_user, user: user).active.first
+        return unless impersonation_log
+        impersonation_log.expired_at = Time.current
+        impersonation_log.save!
+      end
+    end
+  end
+end

data/app/models/decidim/admin/abilities/admin_ability.rb

@@ -26,9 +26,20 @@ module Decidim
 
           can :manage, Feature
           can :manage, :admin_users
+
+          can :manage, :managed_users
+          cannot [:new, :create], :managed_users if empty_available_authorizations?
+          can :impersonate, Decidim::User do |user_to_impersonate|
+            user_to_impersonate.managed? && Decidim::ImpersonationLog.active.empty?
+          end
+          can :promote, Decidim::User do |user_to_promote|
+            user_to_promote.managed? && Decidim::ImpersonationLog.active.empty?
+          end
+
           can :manage, Moderation
           can :manage, Attachment
           can :manage, Scope
+          can :manage, ScopeType
           can :manage, Newsletter
           can [:create, :index, :new, :read, :invite], User
 
@@ -38,6 +49,12 @@ module Decidim
 
           can [:index, :verify, :reject], UserGroup
         end
+
+        private
+
+        def empty_available_authorizations?
+          @context[:current_organization] && @context[:current_organization].available_authorizations.empty?
+        end
       end
     end
   end

data/app/models/decidim/admin/abilities/user_manager_ability.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    module Abilities
+      # Defines the abilities for a user with role 'user_manager' in the admin section.
+      # Intended to be used with `cancancan`.
+      class UserManagerAbility < Decidim::Abilities::UserManagerAbility
+        def define_abilities
+          super
+
+          can :manage, :managed_users
+          cannot [:new, :create], :managed_users if empty_available_authorizations?
+          can :impersonate, Decidim::User do |user_to_impersonate|
+            user_to_impersonate.managed? && Decidim::ImpersonationLog.active.empty?
+          end
+          can :promote, Decidim::User do |user_to_promote|
+            user_to_promote.managed? && Decidim::ImpersonationLog.active.empty?
+          end
+        end
+
+        private
+
+        def empty_available_authorizations?
+          @context[:current_organization] && @context[:current_organization].available_authorizations.empty?
+        end
+      end
+    end
+  end
+end

data/app/views/decidim/admin/categories/_form.html.erb

@@ -17,4 +17,4 @@
       <%= select :category, :parent_id, @form.parent_categories.collect { |c| [c.name[current_organization.default_locale], c.id] }, include_blank: true %>
     </div>
   </div>
-</div>
+</div>

data/app/views/decidim/admin/categories/edit.html.erb

@@ -1,4 +1,4 @@
-<%= decidim_form_for(@form, url: participatory_process_category_path(@category.participatory_process, @category), html: { class: "form edit_participatory_process_category" }) do |f| %>
+<%= decidim_form_for(@form, url: category_path(@category.participatory_process, @category), html: { class: "form edit_participatory_process_category" }) do |f| %>
   <%= render partial: 'form', object: f, locals: { title: t('.title') } %>
 
   <div class="button--double form-general-submit">

data/app/views/decidim/admin/categories/index.html.erb

@@ -3,7 +3,7 @@
     <h2 class='card-title'>
       <%= t(".categories_title") %>
       <% if can? :create, Decidim::Category %>
-        <%= link_to t("actions.new", scope: "decidim.admin", name: t("models.category.name", scope: "decidim.admin")), new_participatory_process_category_path(current_participatory_process), class: 'button tiny button--title new' %>
+        <%= link_to t("actions.new", scope: "decidim.admin", name: t("models.category.name", scope: "decidim.admin")), new_category_path(current_participatory_process), class: 'button tiny button--title new' %>
       <% end %>
     </h2>
   </div>
@@ -22,16 +22,16 @@
             <% current_participatory_process.categories.first_class.each do |category| %>
               <tr>
                 <td>
-                  <%= link_to translated_attribute(category.name), edit_participatory_process_category_path(current_participatory_process, category) %><br />
+                  <%= link_to translated_attribute(category.name), edit_category_path(current_participatory_process, category) %><br />
                 </td>
                 <td class="table-list__actions">
                   <% if can? :update, category %>
-                    <%= icon_link_to "pencil", edit_participatory_process_category_path(current_participatory_process, category), t("actions.edit", scope: "decidim.admin"), class: "action-icon--edit" %>
+                    <%= icon_link_to "pencil", edit_category_path(current_participatory_process, category), t("actions.edit", scope: "decidim.admin"), class: "action-icon--edit" %>
                   <% end %>
 
                   <% if can? :destroy, category %>
                     <% if category.unused? %>
-                      <%= icon_link_to "circle-x", participatory_process_category_path(current_participatory_process, category), t("actions.destroy", scope: "decidim.admin"), class: "action-icon--remove", method: :delete, data: { confirm: t("actions.confirm_destroy", scope: "decidim.admin") } %>
+                      <%= icon_link_to "circle-x", category_path(current_participatory_process, category), t("actions.destroy", scope: "decidim.admin"), class: "action-icon--remove", method: :delete, data: { confirm: t("actions.confirm_destroy", scope: "decidim.admin") } %>
                     <% else %>
                       <span class="action-icon" title="<%= t('.category_used') %>" data-tooltip="true" data-disable-hover="false">
                         <%= icon "circle-x", class: "action-icon action-icon--disabled" %>
@@ -43,15 +43,15 @@
               <% category.subcategories.each do |subcategory| %>
                 <tr class="extra__table-list__subcategory">
                   <td>
-                    <%= link_to translated_attribute(subcategory.name), edit_participatory_process_category_path(current_participatory_process, subcategory) %><br />
+                    <%= link_to translated_attribute(subcategory.name), edit_category_path(current_participatory_process, subcategory) %><br />
                   </td>
                   <td class="table-list__actions">
                   <% if can? :update, subcategory %>
-                    <%= icon_link_to "pencil", edit_participatory_process_category_path(current_participatory_process, subcategory), t("actions.edit", scope: "decidim.admin"), class: "action-icon--edit" %>
+                    <%= icon_link_to "pencil", edit_category_path(current_participatory_process, subcategory), t("actions.edit", scope: "decidim.admin"), class: "action-icon--edit" %>
                   <% end %>
 
                   <% if can? :destroy, subcategory %>
-                    <%= icon_link_to "circle-x", participatory_process_category_path(current_participatory_process, subcategory), t("actions.destroy", scope: "decidim.admin"), class: "action-icon--remove", method: :delete, data: { confirm: t("actions.confirm_destroy", scope: "decidim.admin") } %>
+                    <%= icon_link_to "circle-x", category_path(current_participatory_process, subcategory), t("actions.destroy", scope: "decidim.admin"), class: "action-icon--remove", method: :delete, data: { confirm: t("actions.confirm_destroy", scope: "decidim.admin") } %>
                   <% end %>
                   </td>
                 </tr>