decidim-admin 0.27.8 → 0.28.0.rc4

data/lib/decidim/admin/menu.rb

@@ -0,0 +1,281 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    class Menu
+      def self.register_admin_global_moderation_menu!
+        Decidim.menu :admin_global_moderation_menu do |menu|
+          moderations_count = Decidim::Admin::ModerationStats.new(current_user).count_content_moderations
+
+          caption = I18n.t("menu.content", scope: "decidim.admin")
+          caption += content_tag(:span, moderations_count, class: moderations_count.zero? ? "component-counter component-counter--off" : "component-counter")
+
+          menu.add_item :moderations,
+                        caption.html_safe,
+                        decidim_admin.moderations_path,
+                        position: 1,
+                        active: is_active_link?(decidim_admin.moderations_path),
+                        if: allowed_to?(:read, :global_moderation)
+
+          user_reports = Decidim::Admin::ModerationStats.new(current_user).count_user_pending_reports
+
+          caption = I18n.t("menu.reported_users", scope: "decidim.admin")
+          caption += content_tag(:span, user_reports, class: user_reports.zero? ? "component-counter component-counter--off" : "component-counter")
+
+          menu.add_item :moderated_users,
+                        caption.html_safe,
+                        decidim_admin.moderated_users_path,
+                        active: is_active_link?(decidim_admin.moderated_users_path),
+                        if: allowed_to?(:index, :moderate_users)
+        end
+      end
+
+      def self.register_workflows_menu!
+        Decidim.menu :workflows_menu do |menu|
+          Decidim::Verifications.admin_workflows.each do |manifest|
+            next unless current_organization.available_authorizations.include?(manifest.name.to_s)
+
+            workflow = Decidim::Verifications::Adapter.new(manifest)
+
+            menu.add_item manifest.name.to_s,
+                          workflow.fullname,
+                          workflow.admin_root_path,
+                          active: is_active_link?(workflow.admin_root_path)
+          end
+        end
+      end
+
+      def self.register_impersonate_menu!
+        Decidim.menu :impersonate_menu do |menu|
+          menu.add_item :conflicts,
+                        I18n.t("title", scope: "decidim.admin.conflicts"),
+                        decidim_admin.conflicts_path,
+                        active: is_active_link?(decidim_admin.conflicts_path),
+                        if: allowed_to?(:index, :impersonatable_user)
+        end
+      end
+
+      def self.register_admin_static_pages_menu!
+        Decidim.menu :admin_static_pages_menu do |menu|
+          menu.add_item :static_pages,
+                        I18n.t("menu.static_pages", scope: "decidim.admin"),
+                        decidim_admin.static_pages_path,
+                        icon_name: "pages-line",
+                        position: 1,
+                        active: is_active_link?(decidim_admin.static_pages_path, :inclusive),
+                        if: allowed_to?(:read, :static_page)
+          menu.add_item :static_page_topics,
+                        I18n.t("menu.static_page_topics", scope: "decidim.admin"),
+                        decidim_admin.static_page_topics_path,
+                        icon_name: "pages-line",
+                        position: 2,
+                        active: is_active_link?(decidim_admin.static_page_topics_path, :inclusive),
+                        if: allowed_to?(:create, :static_page_topic)
+        end
+      end
+
+      def self.register_admin_user_menu!
+        Decidim.menu :admin_user_menu do |menu|
+          menu.add_item :users,
+                        I18n.t("menu.admins", scope: "decidim.admin"), decidim_admin.users_path,
+                        icon_name: "user-line",
+                        active: is_active_link?(decidim_admin.users_path),
+                        if: allowed_to?(:read, :admin_user)
+          menu.add_item :user_groups,
+                        I18n.t("menu.user_groups", scope: "decidim.admin"), decidim_admin.user_groups_path,
+                        icon_name: "group-line",
+                        active: is_active_link?(decidim_admin.user_groups_path),
+                        if: current_organization.user_groups_enabled? && allowed_to?(:index, :user_group)
+          menu.add_item :officializations,
+                        I18n.t("menu.participants", scope: "decidim.admin"), decidim_admin.officializations_path,
+                        icon_name: "service-line",
+                        active: is_active_link?(decidim_admin.officializations_path),
+                        if: allowed_to?(:index, :officialization)
+          menu.add_item :impersonatable_users,
+                        I18n.t("menu.impersonations", scope: "decidim.admin"), decidim_admin.impersonatable_users_path,
+                        icon_name: "user-add-line",
+                        active: is_active_link?(decidim_admin.impersonatable_users_path),
+                        if: allowed_to?(:index, :impersonatable_user),
+                        submenu: { target_menu: :impersonate_menu }
+          menu.add_item :authorization_workflows,
+                        I18n.t("menu.authorization_workflows", scope: "decidim.admin"), decidim_admin.authorization_workflows_path,
+                        icon_name: "key-2-line",
+                        active: is_active_link?(decidim_admin.authorization_workflows_path),
+                        if: allowed_to?(:index, :authorization),
+                        submenu: { target_menu: :workflows_menu }
+        end
+      end
+
+      def self.register_admin_scopes_menu!
+        Decidim.menu :admin_scopes_menu do |menu|
+          menu.add_item :scopes,
+                        I18n.t("menu.scopes", scope: "decidim.admin"),
+                        decidim_admin.scopes_path,
+                        icon_name: "price-tag-3-line",
+                        position: 1.3,
+                        if: allowed_to?(:read, :scope)
+          menu.add_item :scope_types,
+                        I18n.t("menu.scope_types", scope: "decidim.admin"),
+                        decidim_admin.scope_types_path,
+                        icon_name: "price-tag-3-line",
+                        position: 1.4,
+                        if: allowed_to?(:read, :scope_type)
+        end
+      end
+
+      def self.register_admin_areas_menu!
+        Decidim.menu :admin_areas_menu do |menu|
+          menu.add_item :areas,
+                        I18n.t("menu.areas", scope: "decidim.admin"),
+                        decidim_admin.areas_path,
+                        icon_name: "layout-masonry-line",
+                        position: 1.5,
+                        if: allowed_to?(:read, :area)
+          menu.add_item :area_types,
+                        I18n.t("menu.area_types", scope: "decidim.admin"),
+                        decidim_admin.area_types_path,
+                        icon_name: "layout-masonry-line",
+                        position: 1.6,
+                        if: allowed_to?(:read, :area_type)
+        end
+      end
+
+      def self.register_admin_settings_menu!
+        Decidim.menu :admin_settings_menu do |menu|
+          menu.add_item :edit_organization,
+                        I18n.t("menu.configuration", scope: "decidim.admin"),
+                        decidim_admin.edit_organization_path,
+                        position: 1.0,
+                        icon_name: "pencil-line",
+                        if: allowed_to?(:update, :organization, organization: current_organization)
+
+          menu.add_item :edit_organization_appearance,
+                        I18n.t("menu.appearance", scope: "decidim.admin"),
+                        decidim_admin.edit_organization_appearance_path,
+                        position: 1.1,
+                        icon_name: "tools-line",
+                        if: allowed_to?(:update, :organization, organization: current_organization)
+
+          menu.add_item :edit_organization_homepage,
+                        I18n.t("menu.homepage", scope: "decidim.admin"),
+                        decidim_admin.edit_organization_homepage_path,
+                        position: 1.2,
+                        icon_name: "home-gear-line",
+                        if: allowed_to?(:update, :organization, organization: current_organization)
+
+          menu.add_item :scopes,
+                        I18n.t("menu.scopes", scope: "decidim.admin"),
+                        decidim_admin.scopes_path,
+                        icon_name: "price-tag-3-line",
+                        position: 1.3,
+                        if: allowed_to?(:read, :scope)
+          menu.add_item :areas,
+                        I18n.t("menu.areas", scope: "decidim.admin"),
+                        decidim_admin.areas_path,
+                        icon_name: "layout-masonry-line",
+                        position: 1.5,
+                        if: allowed_to?(:read, :area)
+
+          menu.add_item :help_sections,
+                        I18n.t("menu.help_sections", scope: "decidim.admin"),
+                        decidim_admin.help_sections_path,
+                        icon_name: "question-line",
+                        position: 1.6,
+                        if: allowed_to?(:update, :help_sections)
+
+          menu.add_item :external_domain_whitelist,
+                        I18n.t("menu.external_domain_whitelist", scope: "decidim.admin"),
+                        decidim_admin.edit_organization_external_domain_whitelist_path,
+                        icon_name: "computer-line",
+                        position: 1.7,
+                        if: allowed_to?(:update, :organization, organization: current_organization)
+        end
+      end
+
+      def self.register_admin_menu!
+        Decidim.menu :admin_menu do |menu|
+          menu.add_item :moderations,
+                        I18n.t("menu.moderation", scope: "decidim.admin"),
+                        decidim_admin.moderations_path,
+                        icon_name: "flag-line",
+                        position: 4,
+                        active: [%w(
+                          decidim/admin/global_moderations
+                          decidim/admin/global_moderations/reports
+                          decidim/admin/moderated_users
+                        ), []],
+                        if: allowed_to?(:read, :global_moderation) || allowed_to?(:index, :moderate_users)
+
+          menu.add_item :static_pages,
+                        I18n.t("menu.static_pages", scope: "decidim.admin"),
+                        decidim_admin.static_pages_path,
+                        icon_name: "pages-line",
+                        position: 4.5,
+                        active: is_active_link?(decidim_admin.static_pages_path, :inclusive) ||
+                                is_active_link?(decidim_admin.static_page_topics_path, :inclusive),
+                        if: allowed_to?(:read, :static_page)
+
+          menu.add_item :impersonatable_users,
+                        I18n.t("menu.users", scope: "decidim.admin"),
+                        allowed_to?(:read, :admin_user) ? decidim_admin.users_path : decidim_admin.impersonatable_users_path,
+                        icon_name: "team-line",
+                        position: 5,
+                        active: [%w(
+                          decidim/admin/users
+                          decidim/admin/user_groups
+                          decidim/admin/user_groups_csv_verifications
+                          decidim/admin/officializations
+                          decidim/admin/impersonatable_users
+                          decidim/admin/conflicts
+                          decidim/admin/managed_users/impersonation_logs
+                          decidim/admin/managed_users/promotions
+                          decidim/admin/authorization_workflows
+                          decidim/verifications/id_documents/admin/pending_authorizations
+                          decidim/verifications/id_documents/admin/config
+                          decidim/verifications/postal_letter/admin/pending_authorizations
+                          decidim/verifications/csv_census/admin/census
+                        ), []],
+                        if: allowed_to?(:read, :admin_user) || allowed_to?(:read, :managed_user)
+
+          menu.add_item :newsletters,
+                        I18n.t("menu.newsletters", scope: "decidim.admin"),
+                        decidim_admin.newsletters_path,
+                        icon_name: "mail-add-line",
+                        position: 6,
+                        active: is_active_link?(decidim_admin.newsletters_path, :inclusive) ||
+                                is_active_link?(decidim_admin.newsletter_templates_path, :inclusive),
+                        if: allowed_to?(:index, :newsletter)
+
+          menu.add_item :edit_organization,
+                        I18n.t("menu.settings", scope: "decidim.admin"),
+                        decidim_admin.edit_organization_path,
+                        icon_name: "tools-line",
+                        position: 7,
+                        active: [
+                          %w(
+                            decidim/admin/organization
+                            decidim/admin/organization_appearance
+                            decidim/admin/organization_homepage
+                            decidim/admin/organization_homepage_content_blocks
+                            decidim/admin/scopes
+                            decidim/admin/scope_types
+                            decidim/admin/areas decidim/admin/area_types
+                            decidim/admin/help_sections
+                            decidim/admin/organization_external_domain_whitelist
+                          ),
+                          []
+                        ],
+                        if: allowed_to?(:update, :organization, organization: current_organization)
+
+          menu.add_item :logs,
+                        I18n.t("menu.admin_log", scope: "decidim.admin"),
+                        decidim_admin.logs_path,
+                        icon_name: "pages-line",
+                        position: 10,
+                        active: [%w(decidim/admin/logs), []],
+                        if: allowed_to?(:read, :admin_log)
+        end
+      end
+    end
+  end
+end

data/lib/decidim/admin/search_form_builder.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # This custom FormBuilder extends the Admin::FormBuilder with the needed
+    # functionality for the Ransack search forms. Adapts functionality from
+    # Ransack::Helpers::FormBuilder to the FoundationRailsHelper::FormBuilder
+    # that we use as the form builder in the admin views.
+    class SearchFormBuilder < Decidim::Admin::FormBuilder
+      private
+
+      # Translates the form labels using the translation method available for
+      # the Ransack::Search objects.
+      #
+      # @see Ransack::Helpers::FormBuilder#default_label_text
+      # @see Ransack::Nodes::Node#translate
+      # @see Ransack::Nodes::Grouping#translate
+      def default_label_text(object, attribute, i18n_options = {})
+        if object.respond_to?(:translate)
+          return object.translate(
+            attribute,
+            i18n_options.reverse_merge(include_associations: true)
+          )
+        end
+
+        super(object, attribute)
+      end
+
+      # Passes the `:i18n` options for the default_label_text method from the
+      # options passed for the custom_label method.
+      #
+      # @see FoundationRailsHelper::FormBuilder#custom_label
+      def custom_label(attribute, text, options)
+        text = default_label_text(object, attribute, options.delete(:i18n) || {}) if text.nil? || text == true
+        super(attribute, text, options)
+      end
+    end
+  end
+end

data/lib/decidim/admin/test/admin_participatory_space_access_examples.rb

@@ -2,7 +2,8 @@
 
 shared_examples "accessing the participatory space" do
   it "shows the page" do
-    expect(page).to have_content("View public page")
+    # Since the button now contains dynamic text, we have to check the href
+    expect(page).to have_css("[href='#{resource_locator(try(:participatory_space) || try(:participatory_process)).path.split("?").first}']", text: "See")
     expect(page).to have_content("My space")
   end
 end
@@ -21,7 +22,7 @@ shared_examples "admin participatory space access" do
   end
 
   context "when the user is a normal user" do
-    let(:user) { create(:user, :confirmed, organization: organization) }
+    let(:user) { create(:user, :confirmed, organization:) }
     let(:unauthorized_path) { "/" }
 
     it_behaves_like "a 404 page"

data/lib/decidim/admin/test/commands/create_attachment_collection_examples.rb

@@ -7,7 +7,7 @@ module Decidim
     shared_examples_for "CreateAttachmentCollection command" do
       describe "call" do
         let(:organization) { create(:organization) }
-        let(:user) { create(:user, organization: organization) }
+        let(:user) { create(:user, organization:) }
         let(:form_params) do
           {
             "attachment_collection" => {
@@ -23,7 +23,7 @@ module Decidim
         let(:form) do
           AttachmentCollectionForm.from_params(
             form_params,
-            collection_for: collection_for
+            collection_for:
           ).with_context(
             current_organization: organization
           )
@@ -39,7 +39,7 @@ module Decidim
             expect { command.call }.to broadcast(:invalid)
           end
 
-          it "doesn't create an attachment collection" do
+          it "does not create an attachment collection" do
             expect do
               command.call
             end.not_to change(AttachmentCollection, :count)

data/lib/decidim/admin/test/commands/create_category_examples.rb

@@ -7,7 +7,7 @@ module Decidim
     shared_examples_for "CreateCategory command" do
       describe "call" do
         let(:organization) { create(:organization) }
-        let(:user) { create(:user, organization: organization) }
+        let(:user) { create(:user, organization:) }
         let(:form_params) do
           {
             "category" => {
@@ -36,7 +36,7 @@ module Decidim
             expect { command.call }.to broadcast(:invalid)
           end
 
-          it "doesn't create a category" do
+          it "does not create a category" do
             expect do
               command.call
             end.not_to change(Category, :count)

data/lib/decidim/admin/test/commands/destroy_category_examples.rb

@@ -7,8 +7,8 @@ module Decidim
     shared_examples_for "DestroyCategory command" do
       describe "call" do
         let(:organization) { create(:organization) }
-        let(:user) { create(:user, organization: organization) }
-        let(:category) { create(:category, participatory_space: participatory_space) }
+        let(:user) { create(:user, organization:) }
+        let(:category) { create(:category, participatory_space:) }
         let(:command) { described_class.new(category, user) }
 
         describe "when the category is not present" do
@@ -19,19 +19,10 @@ module Decidim
           end
         end
 
-        context "when the category is being used by a resource" do
-          let(:component) { create(:dummy_component, participatory_space: participatory_space) }
-          let!(:resource) { create(:dummy_resource, component: component, category: category) }
-
-          it "broadcasts invalid" do
-            expect { command.call }.to broadcast(:invalid)
-          end
-        end
-
         context "when the category is not empty" do
           let!(:subcategory) { create :subcategory, parent: category }
 
-          it "doesn't destroy the category" do
+          it "does not destroy the category" do
             expect do
               command.call
             end.not_to change(Category, :count)
@@ -39,7 +30,7 @@ module Decidim
         end
 
         context "when the category is a subcategory" do
-          let!(:parent_category) { create :category, participatory_space: participatory_space }
+          let!(:parent_category) { create :category, participatory_space: }
 
           before do
             category.parent = parent_category

data/lib/decidim/admin/test/commands/publish_participatory_space_examples.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+shared_examples "Publicable space" do |participatory_manifest_name|
+  let(:tested) { Decidim::Admin::ParticipatorySpace::Publish }
+  subject { tested.new(participatory_space, user) }
+  let(:space_options) { {} }
+
+  let(:participatory_space) { create(participatory_manifest_name, :unpublished, organization: user.organization, **space_options) }
+  let(:user) { create(:user) }
+  let(:default_options) { { visibility: "all" } }
+
+  context "when the process is nil" do
+    let(:participatory_space) { nil }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is published" do
+    let(:participatory_space) { create(participatory_manifest_name) }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is not published" do
+    it "is valid" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "traces the action", versioning: true do
+      expect(Decidim.traceability)
+        .to receive(:perform_action!)
+        .with(:publish, participatory_space, user, **default_options)
+        .and_call_original
+
+      expect { subject.call }.to change(Decidim::ActionLog, :count)
+
+      action_log = Decidim::ActionLog.last
+      expect(action_log.version).to be_present
+      expect(action_log.version.event).to eq "update"
+    end
+
+    it "publishes it" do
+      subject.call
+      participatory_space.reload
+      expect(participatory_space).to be_published
+    end
+  end
+end
+
+shared_examples "Unpublicable space" do |participatory_manifest_name|
+  subject { Decidim::Admin::ParticipatorySpace::Unpublish.new(participatory_space, user) }
+
+  let(:participatory_space) { create(participatory_manifest_name, :published, organization: user.organization) }
+  let(:user) { create(:user) }
+
+  context "when the process is nil" do
+    let(:participatory_space) { nil }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is not published" do
+    let(:participatory_space) { create(participatory_manifest_name, :unpublished) }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when the process is published" do
+    it "is valid" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "traces the action", versioning: true do
+      expect(Decidim.traceability)
+        .to receive(:perform_action!)
+        .with(:unpublish, participatory_space, user, visibility: "all")
+        .and_call_original
+
+      expect { subject.call }.to change(Decidim::ActionLog, :count)
+
+      action_log = Decidim::ActionLog.last
+      expect(action_log.version).to be_present
+      expect(action_log.version.event).to eq "update"
+    end
+
+    it "unpublishes it" do
+      subject.call
+      participatory_space.reload
+      expect(participatory_space).not_to be_published
+    end
+  end
+end

data/lib/decidim/admin/test/commands/update_attachment_collection_examples.rb

@@ -7,8 +7,8 @@ module Decidim
     shared_examples_for "UpdateAttachmentCollection command" do
       describe "call" do
         let(:organization) { create(:organization) }
-        let(:user) { create(:user, organization: organization) }
-        let(:attachment_collection) { create(:attachment_collection, collection_for: collection_for) }
+        let(:user) { create(:user, organization:) }
+        let(:attachment_collection) { create(:attachment_collection, collection_for:) }
         let(:form_params) do
           {
             "attachment_collection" => {
@@ -24,7 +24,7 @@ module Decidim
         let(:form) do
           AttachmentCollectionForm.from_params(
             form_params,
-            collection_for: collection_for
+            collection_for:
           ).with_context(
             current_organization: organization
           )
@@ -40,7 +40,7 @@ module Decidim
             expect { command.call }.to broadcast(:invalid)
           end
 
-          it "doesn't update the attachment collection" do
+          it "does not update the attachment collection" do
             command.call
             attachment_collection.reload
 

data/lib/decidim/admin/test/commands/update_category_examples.rb

@@ -7,8 +7,8 @@ module Decidim
     shared_examples_for "UpdateCategory command" do
       describe "call" do
         let(:organization) { create(:organization) }
-        let(:user) { create(:user, organization: organization) }
-        let(:category) { create(:category, participatory_space: participatory_space) }
+        let(:user) { create(:user, organization:) }
+        let(:category) { create(:category, participatory_space:) }
         let(:form_params) do
           {
             "category" => {
@@ -37,7 +37,7 @@ module Decidim
             expect { command.call }.to broadcast(:invalid)
           end
 
-          it "doesn't update the category" do
+          it "does not update the category" do
             command.call
             category.reload
 

data/lib/decidim/admin/test/destroy_admin_examples.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+shared_examples "destroys participatory space role" do
+  let!(:current_user) { create :user, email: "some_email@example.org", organization: my_process.organization }
+  let!(:user) { create :user, :confirmed, organization: my_process.organization }
+
+  let(:log_info) do
+    {
+      resource: {
+        title: role.user.name
+      }
+    }
+  end
+
+  it "deletes the user role" do
+    subject.call
+    expect { role.reload }.to raise_error(ActiveRecord::RecordNotFound)
+  end
+
+  it "traces the action" do
+    expect(Decidim.traceability)
+      .to receive(:perform_action!)
+      .with("delete", role, current_user, log_info)
+      .and_call_original
+
+    expect { subject.call }.to change(Decidim::ActionLog, :count)
+
+    action_log = Decidim::ActionLog.last
+    expect(action_log.version).to be_present
+    expect(action_log.version.event).to eq "destroy"
+  end
+
+  it_behaves_like "fires an ActiveSupport::Notification event", "decidim.admin.participatory_space.destroy_admin:before" do
+    let(:command) { subject }
+  end
+  it_behaves_like "fires an ActiveSupport::Notification event", "decidim.admin.participatory_space.destroy_admin:after" do
+    let(:command) { subject }
+  end
+end

data/lib/decidim/admin/test/filterable_examples.rb

@@ -16,7 +16,7 @@ shared_context "with filterable context" do
   end
 
   def remove_applied_filter(filter)
-    within(".label", text: /#{filter}/i) do
+    within("[data-applied-filters-tags] .label", text: /#{filter}/i) do
       click_link("Cancel")
     end
   end
@@ -31,7 +31,7 @@ shared_context "with filterable context" do
   shared_examples "paginating a collection" do
     unless block_given?
       let!(:collection) do
-        create_list(factory_name, 50, organization: organization)
+        create_list(factory_name, 50, organization:)
       end
     end
 
@@ -39,9 +39,9 @@ shared_context "with filterable context" do
   end
 
   shared_examples "searching by text" do
-    before { search_by_text(text) }
+    before { search_by_text(ActionView::Base.full_sanitizer.sanitize(text)) }
 
-    it { expect(page).to have_content(text) }
+    it { expect(page).to have_content(ActionView::Base.full_sanitizer.sanitize(text)) }
 
     after { search_by_text("") }
   end
@@ -74,11 +74,11 @@ shared_examples "filtering collection by published/unpublished" do
 
   unless block_given?
     let!(:published_space) do
-      create(factory_name, published_at: Time.current, organization: organization)
+      create(factory_name, published_at: Time.current, organization:)
     end
 
     let!(:unpublished_space) do
-      create(factory_name, published_at: nil, organization: organization)
+      create(factory_name, published_at: nil, organization:)
     end
   end
 
@@ -100,11 +100,11 @@ shared_examples "filtering collection by private/public" do
 
   unless block_given?
     let!(:public_space) do
-      create(factory_name, private_space: false, organization: organization)
+      create(factory_name, private_space: false, organization:)
     end
 
     let!(:private_space) do
-      create(factory_name, private_space: true, organization: organization)
+      create(factory_name, private_space: true, organization:)
     end
   end