decidim-admin 0.10.1 → 0.11.0.pre1

data/app/commands/decidim/admin/create_area.rb

@@ -29,7 +29,9 @@ module Decidim
       attr_reader :form
 
       def create_area
-        Area.create!(
+        Decidim.traceability.create!(
+          Area,
+          form.current_user,
           name: form.name,
           organization: form.organization,
           area_type: form.area_type

data/app/commands/decidim/admin/{create_feature.rb → create_component.rb}

@@ -2,29 +2,29 @@
 
 module Decidim
   module Admin
-    # This command gets called when a feature is created from the admin panel.
-    class CreateFeature < Rectify::Command
+    # This command gets called when a component is created from the admin panel.
+    class CreateComponent < Rectify::Command
       attr_reader :form, :manifest, :participatory_space
 
       # Public: Initializes the command.
       #
-      # manifest            - The feature's manifest to create a feature from.
-      # form                - The form from which the data in this feature comes from.
-      # participatory_space - The participatory space that will hold this feature.
+      # manifest            - The component's manifest to create a component from.
+      # form                - The form from which the data in this component comes from.
+      # participatory_space - The participatory space that will hold this component.
       def initialize(manifest, form, participatory_space)
         @manifest = manifest
         @form = form
         @participatory_space = participatory_space
       end
 
-      # Public: Creates the Feature.
+      # Public: Creates the Component.
       #
       # Broadcasts :ok if created, :invalid otherwise.
       def call
         return broadcast(:invalid) if form.invalid?
 
         transaction do
-          create_feature
+          create_component
           run_hooks
         end
 
@@ -33,9 +33,9 @@ module Decidim
 
       private
 
-      def create_feature
-        @feature = Decidim.traceability.create!(
-          Feature,
+      def create_component
+        @component = Decidim.traceability.create!(
+          Component,
           form.current_user,
           manifest_name: manifest.name,
           name: form.name,
@@ -48,7 +48,7 @@ module Decidim
       end
 
       def run_hooks
-        manifest.run_hooks(:create, @feature)
+        manifest.run_hooks(:create, @component)
       end
     end
   end

data/app/commands/decidim/admin/create_oauth_application.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # Creates an OAuthApplication.
+    class CreateOAuthApplication < Rectify::Command
+      # Initializes the command.
+      #
+      # form - The source fo data for this OAuthApplication.
+      def initialize(form)
+        @form = form
+      end
+
+      def call
+        return broadcast(:invalid) unless @form.valid?
+
+        @application = Decidim.traceability.create!(
+          OAuthApplication,
+          @form.current_user,
+          name: @form.name,
+          organization_name: @form.organization_name,
+          organization_url: @form.organization_url,
+          organization_logo: @form.organization_logo,
+          redirect_uri: @form.redirect_uri,
+          scopes: "public",
+          organization: @form.current_organization
+        )
+
+        broadcast(:ok, @application)
+      rescue ActiveRecord::RecordInvalid
+        @form.errors.add(:organization_logo, @application.errors[:organization_logo]) if @application.errors.include? :organization_logo
+        broadcast(:invalid)
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/create_participatory_space_private_user.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A command with all the business logic when creating a new participatory space
+    # private user in the system.
+    class CreateParticipatorySpacePrivateUser < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # form - A form object with the params.
+      # private_user_to - The private_user_to that will hold the
+      #   user role
+      def initialize(form, current_user, private_user_to)
+        @form = form
+        @current_user = current_user
+        @private_user_to = private_user_to
+      end
+
+      # Executes the command. Broadcasts these events:
+      #
+      # - :ok when everything is valid.
+      # - :invalid if the form wasn't valid and we couldn't proceed.
+      #
+      # Returns nothing.
+      def call
+        return broadcast(:invalid) if form.invalid?
+
+        ActiveRecord::Base.transaction do
+          @user ||= existing_user || new_user
+          create_private_user
+        end
+
+        broadcast(:ok)
+      rescue ActiveRecord::RecordInvalid
+        form.errors.add(:email, :taken)
+        broadcast(:invalid)
+      end
+
+      private
+
+      attr_reader :form, :private_user_to, :current_user, :user
+
+      def create_private_user
+        Decidim::ParticipatorySpacePrivateUser.find_or_create_by!(
+          user: user,
+          privatable_to: @private_user_to
+        )
+      end
+
+      def existing_user
+        return @existing_user if defined?(@existing_user)
+
+        @existing_user = User.find_by(
+          email: form.email,
+          organization: private_user_to.organization
+        )
+
+        InviteUserAgain.call(@existing_user, invitation_instructions) if @existing_user && !@existing_user.invitation_accepted?
+
+        @existing_user
+      end
+
+      def new_user
+        @new_user ||= InviteUser.call(user_form) do
+          on(:ok) do |user|
+            return user
+          end
+        end
+      end
+
+      def user_form
+        OpenStruct.new(name: form.name,
+                       email: form.email.downcase,
+                       organization: private_user_to.organization,
+                       admin: false,
+                       invited_by: current_user,
+                       invitation_instructions: invitation_instructions)
+      end
+
+      def invitation_instructions
+        "invite_private_user"
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/destroy_area.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # A command with all the business logic to destroy an area.
+    class DestroyArea < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # area - The area to destroy
+      # current_user - the user performing the action
+      def initialize(area, current_user)
+        @area = area
+        @current_user = current_user
+      end
+
+      # Executes the command. Broadcasts these events:
+      #
+      # - :ok when everything is valid.
+      # - :invalid if the form wasn't valid and we couldn't proceed.
+      #
+      # Returns nothing.
+      def call
+        destroy_area
+        broadcast(:ok)
+      end
+
+      private
+
+      attr_reader :current_user
+
+      def destroy_area
+        Decidim.traceability.perform_action!(
+          "delete",
+          @area,
+          current_user
+        ) do
+          @area.destroy!
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/{destroy_feature.rb → destroy_component.rb}

@@ -2,14 +2,14 @@
 
 module Decidim
   module Admin
-    # This command deals with destroying a Feature from the admin panel.
-    class DestroyFeature < Rectify::Command
+    # This command deals with destroying a Component from the admin panel.
+    class DestroyComponent < Rectify::Command
       # Public: Initializes the command.
       #
-      # feature - The Feature to be destroyed.
+      # component - The Component to be destroyed.
       # current_user - the user performing the action
-      def initialize(feature, current_user)
-        @feature = feature
+      def initialize(component, current_user)
+        @component = component
         @current_user = current_user
       end
 
@@ -18,7 +18,7 @@ module Decidim
       # Broadcasts :ok if it got destroyed, raises an exception otherwise.
       def call
         begin
-          destroy_feature
+          destroy_component
         rescue StandardError
           return broadcast(:invalid)
         end
@@ -27,16 +27,16 @@ module Decidim
 
       private
 
-      def destroy_feature
+      def destroy_component
         transaction do
           run_before_hooks
 
           Decidim.traceability.perform_action!(
             "delete",
-            @feature,
+            @component,
             @current_user
           ) do
-            @feature.destroy!
+            @component.destroy!
           end
 
           run_hooks
@@ -44,11 +44,11 @@ module Decidim
       end
 
       def run_before_hooks
-        @feature.manifest.run_hooks(:before_destroy, @feature)
+        @component.manifest.run_hooks(:before_destroy, @component)
       end
 
       def run_hooks
-        @feature.manifest.run_hooks(:destroy, @feature)
+        @component.manifest.run_hooks(:destroy, @component)
       end
     end
   end

data/app/commands/decidim/admin/destroy_oauth_application.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # This command deals with destroying an application from the admin panel.
+    class DestroyOAuthApplication < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # application - The OAuthApplication to be destroyed.
+      # user        - The user that destroys the application.
+      def initialize(application, current_user)
+        @application = application
+        @current_user = current_user
+      end
+
+      # Public: Executes the command.
+      #
+      # Broadcasts :ok if it got destroyed
+      def call
+        destroy_application
+        broadcast(:ok)
+      end
+
+      private
+
+      attr_reader :application, :current_user
+
+      def destroy_application
+        Decidim.traceability.perform_action!(
+          "delete",
+          application,
+          current_user
+        ) do
+          application.destroy!
+        end
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/{impersonate_managed_user.rb → impersonate_user.rb}

@@ -3,14 +3,13 @@
 module Decidim
   module Admin
     # A command with all the business logic to impersonate a managed user.
-    class ImpersonateManagedUser < Rectify::Command
+    class ImpersonateUser < Rectify::Command
       # Public: Initializes the command.
       #
       # form         - The form with the authorization info
       # user         - The user to impersonate
-      def initialize(form, user)
+      def initialize(form)
         @form = form
-        @user = user
       end
 
       # Executes the command. Broadcasts these events:
@@ -20,9 +19,16 @@ module Decidim
       #
       # Returns nothing.
       def call
-        return broadcast(:invalid) unless user.managed? && authorization_valid?
+        return broadcast(:invalid) unless form.valid?
+
+        transaction do
+          user.save! unless user.persisted?
+
+          create_authorization
+
+          create_impersonation_log
+        end
 
-        create_impersonation_log
         enqueue_expire_job
 
         broadcast(:ok)
@@ -30,21 +36,21 @@ module Decidim
 
       private
 
-      attr_reader :user, :form
+      attr_reader :form
 
-      def authorization_valid?
-        return false unless form.valid?
-        Decidim::Authorization.where(
-          user: user,
-          name: form.authorization.handler_name,
-          unique_id: form.authorization.unique_id
-        ).any?
+      def user
+        form.user
+      end
+
+      def create_authorization
+        Authorization.create_or_update_from(form.authorization)
       end
 
       def create_impersonation_log
         Decidim::ImpersonationLog.create!(
           admin: form.current_user,
           user: user,
+          reason: form.reason,
           started_at: Time.current
         )
       end

data/app/commands/decidim/admin/publish_component.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # This command gets called when a component is published from the admin panel.
+    class PublishComponent < Rectify::Command
+      # Public: Initializes the command.
+      #
+      # component - The component to publish.
+      # current_user - the user performing the action
+      def initialize(component, current_user)
+        @component = component
+        @current_user = current_user
+      end
+
+      # Public: Publishes the Component.
+      #
+      # Broadcasts :ok if published, :invalid otherwise.
+      def call
+        publish_component
+        publish_event
+
+        broadcast(:ok)
+      end
+
+      private
+
+      attr_reader :component, :current_user
+
+      def publish_component
+        Decidim.traceability.perform_action!(
+          :publish,
+          component,
+          current_user
+        ) do
+          component.publish!
+          component
+        end
+      end
+
+      def publish_event
+        Decidim::EventsManager.publish(
+          event: "decidim.events.components.component_published",
+          event_class: Decidim::ComponentPublishedEvent,
+          resource: component,
+          recipient_ids: component.participatory_space.followers.pluck(:id)
+        )
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/{unpublish_feature.rb → unpublish_component.rb}

@@ -2,38 +2,38 @@
 
 module Decidim
   module Admin
-    # This command gets called when a feature is unpublished from the admin panel.
-    class UnpublishFeature < Rectify::Command
+    # This command gets called when a component is unpublished from the admin panel.
+    class UnpublishComponent < Rectify::Command
       # Public: Initializes the command.
       #
-      # feature - The feature to unpublish.
+      # component - The component to unpublish.
       # current_user - the user performing the action
-      def initialize(feature, current_user)
-        @feature = feature
+      def initialize(component, current_user)
+        @component = component
         @current_user = current_user
       end
 
-      # Public: Unpublishes the Feature.
+      # Public: Unpublishes the Component.
       #
       # Broadcasts :ok if unpublished, :invalid otherwise.
       def call
-        unpublish_feature
+        unpublish_component
 
         broadcast(:ok)
       end
 
       private
 
-      attr_reader :feature, :current_user
+      attr_reader :component, :current_user
 
-      def unpublish_feature
+      def unpublish_component
         Decidim.traceability.perform_action!(
           :unpublish,
-          feature,
+          component,
           current_user
         ) do
-          feature.unpublish!
-          feature
+          component.unpublish!
+          component
         end
       end
     end

data/app/commands/decidim/admin/update_area.rb

@@ -31,7 +31,11 @@ module Decidim
       attr_reader :form
 
       def update_area
-        @area.update!(attributes)
+        Decidim.traceability.update!(
+          @area,
+          form.current_user,
+          attributes
+        )
       end
 
       def attributes

data/app/commands/decidim/admin/update_component.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # This command gets called when a component is created from the admin panel.
+    class UpdateComponent < Rectify::Command
+      attr_reader :form, :component, :previous_settings
+
+      # Public: Initializes the command.
+      #
+      # form    - The form from which the data in this component comes from.
+      # component - The component to update.
+      def initialize(form, component)
+        @manifest = component.manifest
+        @form = form
+        @component = component
+      end
+
+      # Public: Creates the Component.
+      #
+      # Broadcasts :ok if created, :invalid otherwise.
+      def call
+        return broadcast(:invalid) if form.invalid?
+
+        transaction do
+          update_component
+          run_hooks
+        end
+
+        broadcast(:ok, settings_changed?, previous_settings, current_settings)
+      end
+
+      private
+
+      def update_component
+        @previous_settings = @component.attributes["settings"].dup
+
+        @component.name = form.name
+        @component.settings = form.settings
+        @component.default_step_settings = form.default_step_settings
+        @component.step_settings = form.step_settings
+        @component.weight = form.weight
+
+        @settings_changed = @component.settings_changed?
+
+        @component.save!
+      end
+
+      def run_hooks
+        @manifest.run_hooks(:update, @component)
+      end
+
+      def settings_changed?
+        @settings_changed
+      end
+
+      def current_settings
+        @component.attributes["settings"]
+      end
+    end
+  end
+end

data/app/commands/decidim/admin/{update_feature_permissions.rb → update_component_permissions.rb}

@@ -2,21 +2,21 @@
 
 module Decidim
   module Admin
-    # This command gets called when permissions for a feature are updated
+    # This command gets called when permissions for a component are updated
     # in the admin panel.
-    class UpdateFeaturePermissions < Rectify::Command
-      attr_reader :form, :feature
+    class UpdateComponentPermissions < Rectify::Command
+      attr_reader :form, :component
 
       # Public: Initializes the command.
       #
-      # form    - The form from which the data in this feature comes from.
-      # feature - The feature to update.
-      def initialize(form, feature)
+      # form    - The form from which the data in this component comes from.
+      # component - The component to update.
+      def initialize(form, component)
         @form = form
-        @feature = feature
+        @component = component
       end
 
-      # Public: Sets the permissions for a feature.
+      # Public: Sets the permissions for a component.
       #
       # Broadcasts :ok if created, :invalid otherwise.
       def call
@@ -42,13 +42,13 @@ module Decidim
           result.update(key => serialized)
         end
 
-        @feature.update!(
+        @component.update!(
           permissions: permissions
         )
       end
 
       def run_hooks
-        @feature.manifest.run_hooks(:permission_update, @feature)
+        @component.manifest.run_hooks(:permission_update, @component)
       end
     end
   end

data/app/commands/decidim/admin/update_oauth_application.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Admin
+    # Updates the OAuth application given form data.
+    class UpdateOAuthApplication < Rectify::Command
+      # Initializes the command.
+      #
+      # application - The OAuthApplication to update.
+      # form        - The form object containing the data to update.
+      # user        - The user that updates the application.
+      def initialize(application, form, user)
+        @application = application
+        @form = form
+        @user = user
+      end
+
+      def call
+        return broadcast(:invalid) unless @form.valid?
+        return broadcast(:invalid) unless @user.organization == @application.organization
+
+        @application = Decidim.traceability.update!(
+          @application,
+          @user,
+          name: @form.name,
+          organization_name: @form.organization_name,
+          organization_url: @form.organization_url,
+          organization_logo: @form.organization_logo,
+          redirect_uri: @form.redirect_uri
+        )
+
+        broadcast(:ok, @application)
+      rescue ActiveRecord::RecordInvalid
+        @form.errors.add(:organization_logo, @application.errors[:organization_logo]) if @application.errors.include? :organization_logo
+        broadcast(:invalid)
+      end
+    end
+  end
+end

data/app/controllers/decidim/admin/application_controller.rb

@@ -21,7 +21,7 @@ module Decidim
       helper Decidim::ScopesHelper
       helper Decidim::TranslationsHelper
       helper Decidim::LanguageChooserHelper
-      helper Decidim::FeaturePathHelper
+      helper Decidim::ComponentPathHelper
 
       protect_from_forgery with: :exception, prepend: true