decidim-action_delegator 0.8.2 → 0.9.0

data/lib/decidim/action_delegator.rb

@@ -14,25 +14,25 @@ module Decidim
     # this is the SmsGateway provided by this module
     # Note that it will be ignored if you provide your own SmsGateway in Decidim.sms_gateway_service
     config_accessor :sms_gateway_service do
-      "Decidim::ActionDelegator::SmsGateway"
+      Decidim::Env.new("AD_SMS_GATEWAY_SERVICE", "Decidim::ActionDelegator::SmsGateway").to_s
     end
 
     # The default expiration time for the integrated authorization
     # if zero, the authorization won't be registered
     config_accessor :authorization_expiration_time do
-      3.months
+      Decidim::Env.new("AD_AUTHORIZATION_EXPIRATION_TIME").presence&.to_i || 3.months
     end
 
     # Put this to false if you don't want to allow administrators to invite users not registered
     # in the platform when uploading a census (inviting users without permission can be a GDPR offense).
     config_accessor :allow_to_invite_users do
-      true
+      Decidim::Env.new("AD_ALLOW_TO_INVITE_USERS", true).present?
     end
 
     # If true, tries to automatically authorize users when they log in with the "Corporate Governance Verifier"
     # Note that this is only possible when the verifier is configured to use only the email (if SMS is required, the user will have to do the standard verification process)
     config_accessor :authorize_on_login do
-      true
+      Decidim::Env.new("AD_AUTHORIZE_ON_LOGIN", true).present?
     end
 
     # used for comparing phone numbers from a census list and the ones introduced by the user
@@ -40,30 +40,12 @@ module Decidim
     # if you have a census list with  +34 666 666 666 and the user introduces 0034666666666 or 666666666, they will be considered the same
     # can be empty or null if yo don't want to check different combinations of prefixes
     config_accessor :phone_prefixes do
-      %w(+34 0034 34)
+      Decidim::Env.new("AD_PHONE_PREFIXES", "+34,0034,34").to_array
     end
 
     # The regex for validating phone numbers
     config_accessor :phone_regex do
-      /^\d{6,15}$/ # 6 to 15 digits
-    end
-
-    # Consultations has an annoying and totally useless deprecation warning
-    # This plugin removes it by default.
-    # If you want to keep it, you can set this config to false
-    config_accessor :remove_consultation_deprecation_warning do
-      true
-    end
-
-    # In a consultation the highlighted questions are duplicated in the list of regular questions
-    # this maintains the highlighted questions in the highlighted list and removes them from the regular list
-    config_accessor :remove_duplicated_highlighted_questions do
-      true
-    end
-
-    # If true, admins can view the result of a consultation even if the consultation is ongoing
-    config_accessor :admin_preview_results do
-      true
+      Decidim::Env.new("AD_PHONE_REGEX", '^\d{6,15}$').to_s # 6 to 15 digits
     end
   end
 end
@@ -74,7 +56,7 @@ end
 # manage their delegations
 Decidim.register_global_engine(
   :decidim_action_delegator, # this is the name of the global method to access engine routes
-  ::Decidim::ActionDelegator::Engine,
+  Decidim::ActionDelegator::Engine,
   at: "/action_delegator"
 )
 
@@ -82,6 +64,6 @@ Decidim.register_global_engine(
 # create their own
 Decidim.register_global_engine(
   :decidim_admin_action_delegator,
-  ::Decidim::ActionDelegator::AdminEngine,
+  Decidim::ActionDelegator::AdminEngine,
   at: "/admin/action_delegator"
 )

data/lib/tasks/migrate_consultations.rake

@@ -0,0 +1,382 @@
+# frozen_string_literal: true
+
+namespace :action_delegator do
+  desc "Migrate old decidim-consultations data to decidim-elections component"
+  task :migrate_consultations, [:component_id, :consultation_id] => :environment do |_task, args|
+    component_id = args[:component_id]
+    consultation_id = args[:consultation_id]
+
+    if component_id.blank?
+      puts "ERROR: component_id is required"
+      puts "Usage: rake action_delegator:migrate_consultations[COMPONENT_ID] or rake action_delegator:migrate_consultations[COMPONENT_ID,CONSULTATION_ID]"
+      exit 1
+    end
+
+    component = Decidim::Component.find_by(id: component_id)
+    unless component&.manifest_name == "elections"
+      puts "ERROR: Component ##{component_id} not found or is not an elections component"
+      exit 1
+    end
+
+    # Define inline models for old consultation tables (module no longer exists in Decidim)
+    module Legacy
+      class Consultation < ApplicationRecord
+        self.table_name = "decidim_consultations"
+        has_many :questions, class_name: "Legacy::Question", foreign_key: :decidim_consultation_id
+      end
+
+      class Question < ApplicationRecord
+        self.table_name = "decidim_consultations_questions"
+        belongs_to :consultation, class_name: "Legacy::Consultation", foreign_key: :decidim_consultation_id
+        has_many :responses, class_name: "Legacy::Response", foreign_key: :decidim_consultations_questions_id
+        has_many :votes, class_name: "Legacy::Vote", foreign_key: :decidim_consultation_question_id
+      end
+
+      class Response < ApplicationRecord
+        self.table_name = "decidim_consultations_responses"
+        belongs_to :question, class_name: "Legacy::Question", foreign_key: :decidim_consultations_questions_id
+        belongs_to :response_group, class_name: "Legacy::ResponseGroup", foreign_key: :decidim_consultations_response_group_id, optional: true
+      end
+
+      class ResponseGroup < ApplicationRecord
+        self.table_name = "decidim_consultations_response_groups"
+        belongs_to :question, class_name: "Legacy::Question", foreign_key: :decidim_consultations_questions_id
+        has_many :responses, class_name: "Legacy::Response", foreign_key: :decidim_consultations_response_group_id
+      end
+
+      class Vote < ApplicationRecord
+        self.table_name = "decidim_consultations_votes"
+        belongs_to :question, class_name: "Legacy::Question", foreign_key: :decidim_consultation_question_id
+        belongs_to :response, class_name: "Legacy::Response", foreign_key: :decidim_consultations_response_id
+        belongs_to :author, class_name: "Decidim::User", foreign_key: :decidim_author_id
+      end
+    end
+
+    # Check if consultations table exists
+    unless ActiveRecord::Base.connection.table_exists?("decidim_consultations")
+      puts "ERROR: decidim_consultations table not found. Make sure you have legacy data to migrate."
+      exit 1
+    end
+
+    # Fetch consultations to migrate
+    consultations = if consultation_id.present?
+                      Legacy::Consultation.where(id: consultation_id)
+                    else
+                      Legacy::Consultation.where(decidim_organization_id: component.organization.id)
+                    end
+
+    if consultations.empty?
+      puts "No consultations found"
+      exit 0
+    end
+
+    # Calculate source data statistics
+    source_stats = {
+      consultations: consultations.count,
+      questions: 0,
+      responses: 0,
+      votes: 0
+    }
+
+    consultations.each do |c|
+      source_stats[:questions] += c.questions.count
+      c.questions.each do |q|
+        source_stats[:responses] += q.responses.count
+        source_stats[:votes] += q.votes.count
+      end
+    end
+
+    migrated_stats = {
+      elections: 0,
+      questions: 0,
+      responses: 0,
+      votes: 0,
+      skipped_votes: 0,
+      skipped_consultations: 0,
+      errors: []
+    }
+
+    puts "\nStarting migration of #{source_stats[:consultations]} consultations from decidim-consultations to decidim-elections"
+    puts "Component: ##{component.id} - #{component.name}"
+    puts "Consultations:"
+    consultations.each do |c|
+      puts "  • ##{c.id} - #{c.title}"
+    end
+    puts "\nSource data summary:"
+    puts "-" * 70
+    puts "TYPE            Elections    Questions    Responses        Votes"
+    puts "-" * 70
+    puts format("%-12s %12d %12d %12d %12d", "SOURCE", source_stats[:consultations], source_stats[:questions], source_stats[:responses], source_stats[:votes])
+    puts "-" * 70
+    puts ""
+    unless ENV["CI"].present? || ENV["FORCE_MIGRATION"].to_s.downcase == "true"
+      print "Continue migration? (y/N): "
+      answer = $stdin.gets.chomp.downcase
+      unless answer == "y"
+        puts "Aborted by user."
+        exit 0
+      end
+    end
+
+    def determine_census_config(consultation, setting)
+      resource_handlers = extract_authorization_handlers(consultation)
+      census_manifest = determine_census_manifest(setting, resource_handlers)
+      authorization_handlers = determine_authorization_handlers(setting, resource_handlers, census_manifest)
+      census_settings = build_census_settings(census_manifest, setting, authorization_handlers)
+
+      [census_manifest, census_settings]
+    end
+
+    def extract_authorization_handlers(consultation)
+      question_ids = consultation.questions.pluck(:id)
+      return [] unless ActiveRecord::Base.connection.table_exists?("decidim_resource_permissions") && question_ids.any?
+
+      handlers = []
+      perms = ActiveRecord::Base.connection.execute(<<-SQL.squish)
+        SELECT permissions FROM decidim_resource_permissions
+        WHERE resource_type = 'Decidim::Consultations::Question'
+        AND resource_id IN (#{question_ids.join(",")})
+        AND permissions::jsonb -> 'vote' -> 'authorization_handlers' IS NOT NULL
+      SQL
+
+      perms.each do |perm|
+        perm_handlers = begin
+          JSON.parse(perm["permissions"])["vote"]["authorization_handlers"].keys
+        rescue StandardError
+          []
+        end
+        handlers.concat(perm_handlers)
+      end
+      handlers.uniq
+    end
+
+    def determine_census_manifest(setting, resource_handlers)
+      return "action_delegator_census" if setting&.delegations&.any?
+      return "internal_users" if setting&.authorization_method.present? || resource_handlers.any?
+
+      "internal_users"
+    end
+
+    def determine_authorization_handlers(setting, resource_handlers, census_manifest)
+      return [] if census_manifest == "action_delegator_census"
+      return ["delegations_verifier"] if setting&.authorization_method.present?
+
+      resource_handlers
+    end
+
+    def build_census_settings(census_manifest, setting, authorization_handlers)
+      return { "setting_id" => setting.id } if census_manifest == "action_delegator_census" && setting
+
+      return {} if authorization_handlers.empty?
+
+      {
+        authorization_handlers: authorization_handlers.index_with do |handler|
+          handler == "delegations_verifier" && setting ? { "options" => { "setting" => setting.id.to_s } } : { "options" => {} }
+        end
+      }
+    end
+
+    def build_question_description(old_question)
+      parts = [old_question.subtitle, old_question.what_is_decided].compact.compact_blank
+      return {} if parts.empty?
+
+      parts_by_locale = parts.each_with_object({}) do |part, result|
+        part.each do |locale, text|
+          result[locale] ||= []
+          result[locale] << text if text.present?
+        end
+      end
+      parts_by_locale.transform_values { |arr| arr.join("\n\n") }
+    end
+
+    def migrate_question_votes(old_question, new_question, response_mapping, migrated_stats)
+      votes_migrated = 0
+      votes_skipped = 0
+
+      old_question.votes.find_each do |old_vote|
+        user = old_vote.author
+        unless user
+          votes_skipped += 1
+          migrated_stats[:skipped_votes] += 1
+          next
+        end
+
+        new_response_id = response_mapping[old_vote.decidim_consultations_response_id]
+        unless new_response_id
+          votes_skipped += 1
+          migrated_stats[:skipped_votes] += 1
+          next
+        end
+
+        new_vote = Decidim::Elections::Vote.new(
+          question: new_question,
+          response_option_id: new_response_id,
+          voter_uid: user.to_global_id.to_s,
+          created_at: old_vote.created_at,
+          updated_at: old_vote.updated_at
+        )
+
+        if new_vote.save
+          votes_migrated += 1
+          migrated_stats[:votes] += 1
+        else
+          votes_skipped += 1
+          migrated_stats[:skipped_votes] += 1
+          puts "    ✗ Failed to migrate Vote ##{old_vote.id}: #{new_vote.errors.full_messages.join(", ")}"
+        end
+      end
+
+      puts "    ✓ Migrated #{votes_migrated} votes, skipped #{votes_skipped} votes"
+
+      [votes_migrated, votes_skipped]
+    end
+
+    consultations.find_each do |consultation|
+      ActiveRecord::Base.transaction do
+        setting = Decidim::ActionDelegator::Setting.find_by(decidim_consultation_id: consultation.id)
+
+        # Check if already migrated (idempotency check by matching title)
+        existing_election = Decidim::Elections::Election.joins(:component)
+                                                        .where(component: component, title: consultation.title)
+                                                        .first
+
+        if existing_election
+          cons_title = consultation.title["en"] || consultation.title.values.first
+          puts "  ✓ Consultation ##{consultation.id} (#{cons_title}) already migrated to Election ##{existing_election.id}"
+          migrated_stats[:skipped_consultations] += 1
+          next
+        end
+
+        census_manifest, census_settings = determine_census_config(consultation, setting)
+
+        # Create Election from Consultation
+        election = Decidim::Elections::Election.new(
+          component: component,
+          title: consultation.title,
+          description: consultation.description,
+          start_at: consultation.start_voting_date&.to_time&.beginning_of_day,
+          end_at: consultation.end_voting_date&.to_time&.end_of_day,
+          published_at: consultation.published_at,
+          published_results_at: consultation.results_published_at,
+          results_availability: "after_end",
+          census_manifest: census_manifest,
+          census_settings: census_settings,
+          created_at: consultation.created_at,
+          updated_at: consultation.updated_at
+        )
+
+        if election.save
+          migrated_stats[:elections] += 1
+          puts "  ✓ Created Election ##{election.id} from Consultation ##{consultation.id}"
+
+          consultation.questions.order(:order).each_with_index do |old_question, index|
+            new_question = Decidim::Elections::Question.new(
+              election: election,
+              body: old_question.title.transform_values { |t| ActionController::Base.helpers.strip_tags(t) },
+              description: build_question_description(old_question),
+              position: old_question.order || index,
+              question_type: (old_question.max_votes.to_i > 1 ? "multiple_option" : "single_option"),
+              created_at: old_question.created_at,
+              updated_at: old_question.updated_at
+            )
+
+            unless new_question.save
+              migrated_stats[:errors] << "Question creation failed: #{new_question.errors.full_messages.join(", ")}"
+              puts "    ✗ Failed to create Question from Old Question ##{old_question.id}: #{new_question.errors.full_messages.join(", ")}"
+              next
+            end
+
+            migrated_stats[:questions] += 1
+
+            response_mapping = {}
+            old_question.responses.each do |old_response|
+              title = old_response.title
+              if old_response.response_group
+                title = title.to_h do |locale, text|
+                  group_text = old_response.response_group.title[locale]
+                  combined_text = [group_text, text].compact.join(" - ")
+                  [locale, combined_text]
+                end
+              end
+              new_response = Decidim::Elections::ResponseOption.new(
+                question: new_question,
+                body: title,
+                created_at: old_response.created_at,
+                updated_at: old_response.updated_at
+              )
+
+              if new_response.save
+                response_mapping[old_response.id] = new_response.id
+                migrated_stats[:responses] += 1
+              else
+                migrated_stats[:errors] << "Response failed: #{new_response.errors.full_messages.join(", ")}"
+                puts "    ✗ Failed to create Response from Old Response ##{old_response.id}: #{new_response.errors.full_messages.join(", ")}"
+              end
+            end
+
+            puts "    ✓ Created Question ##{new_question.id} with #{response_mapping.size} Responses"
+
+            migrate_question_votes(old_question, new_question, response_mapping, migrated_stats)
+
+            new_question.response_options.each { |ro| Decidim::Elections::ResponseOption.reset_counters(ro.id, :votes) }
+            Decidim::Elections::Question.reset_counters(new_question.id, :votes)
+          end
+
+          # Update election votes count
+          election.update_votes_count!
+        else
+          cons_title = consultation.title["en"] || consultation.title.values.first
+          migrated_stats[:errors] << "Consultation ##{consultation.id} (#{cons_title}): #{election.errors.full_messages.join(", ")}"
+          puts "  ✗ Failed to create Election from Consultation ##{consultation.id}: #{election.errors.full_messages.join(", ")}"
+          raise ActiveRecord::Rollback
+        end
+      rescue StandardError => e
+        cons_title = begin
+          consultation.title["en"] || consultation.title.values.first
+        rescue StandardError
+          "ID #{consultation.id}"
+        end
+        migrated_stats[:errors] << "Consultation ##{consultation.id} (#{cons_title}): #{e.message}"
+        puts "  ✗ Exception migrating Consultation ##{consultation.id} (#{cons_title}): #{e.message}"
+        Rails.logger.error e.backtrace.join("\n")
+        raise ActiveRecord::Rollback
+      end
+    end
+
+    puts "\n#{"-" * 70}"
+    puts "Migration results: Consultations → Elections"
+    puts "-" * 70
+    puts "                Elections    Questions    Responses        Votes"
+    puts "-" * 70
+    puts format("%-12s %12d %12d %12d %12d", "SOURCE", source_stats[:consultations], source_stats[:questions], source_stats[:responses], source_stats[:votes])
+    puts format("%-12s %12d %12d %12d %12d", "MIGRATED", migrated_stats[:elections], migrated_stats[:questions], migrated_stats[:responses], migrated_stats[:votes])
+
+    puts format("%-12s %12d %12s %12s %12s", "EXISTED", migrated_stats[:skipped_consultations], "-", "-", "-") if migrated_stats[:skipped_consultations].positive?
+
+    puts format("%-12s %12s %12s %12s %12d", "SKIPPED", "-", "-", "-", migrated_stats[:skipped_votes]) if migrated_stats[:skipped_votes].positive?
+
+    if migrated_stats[:errors].any?
+      puts "\nErrors (#{migrated_stats[:errors].size}):"
+      migrated_stats[:errors].each { |err| puts "  • #{err}" }
+    end
+
+    puts ""
+    total_processed = migrated_stats[:elections] + migrated_stats[:skipped_consultations]
+    success = total_processed == source_stats[:consultations] &&
+              migrated_stats[:questions] == source_stats[:questions] &&
+              migrated_stats[:responses] == source_stats[:responses] &&
+              migrated_stats[:votes] == source_stats[:votes] &&
+              migrated_stats[:errors].empty? &&
+              (migrated_stats[:skipped_votes]).zero?
+
+    if success
+      if migrated_stats[:skipped_consultations].positive?
+        puts "✓ All data processed (#{migrated_stats[:elections]} migrated, #{migrated_stats[:skipped_consultations]} already existed)"
+      else
+        puts "✓ All data migrated successfully"
+      end
+    else
+      puts "⚠ Some data was not migrated (see details above)"
+    end
+  end
+end

data/lib/tasks/upgrade_tasks.rake

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+Rake::Task["decidim:choose_target_plugins"].enhance do
+  ENV["FROM"] = "#{ENV.fetch("FROM", nil)},decidim_action_delegator"
+end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "decidim-action_delegator",
-  "version": "0.6.0",
+  "version": "0.9.0",
   "description": "Delgation actions (votes) for Decidim",
   "main": "index.js",
   "directories": {
@@ -16,7 +16,7 @@
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/coopdevs/decidim-module-action_delegator.git"
+    "url": "git+https://github.com/Openpoke/decidim-module-action_delegator.git"
   },
   "keywords": [
     "decidim"
@@ -24,34 +24,17 @@
   "author": "ivan@pokecode.net",
   "license": "AGPL-3.0-or-later",
   "bugs": {
-    "url": "https://github.com/coopdevs/decidim-module-action_delegator/issues"
+    "url": "https://github.com/Openpoke/decidim-module-action_delegator/issues"
   },
-  "homepage": "https://github.com/coopdevs/decidim-module-action_delegator#readme",
+  "homepage": "https://github.com/Openpoke/decidim-module-action_delegator#readme",
   "stylelint": {
-    "extends": "@decidim/stylelint-config",
-    "rules" : {
-      "block-opening-brace-space-before": "always"
-    }
+    "extends": "@decidim/stylelint-config"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.19.1",
-    "@babel/plugin-proposal-class-properties": "^7.18.6",
-    "@babel/plugin-proposal-private-methods": "^7.18.6",
-    "@babel/plugin-proposal-private-property-in-object": "^7.20.5",
-    "@babel/plugin-transform-classes": "^7.20.7",
-    "@babel/plugin-transform-regenerator": "^7.20.5",
-    "@babel/plugin-transform-runtime": "^7.19.6",
-    "@babel/preset-env": "^7.20.2",
-    "@babel/preset-react": "^7.18.6",
-    "@decidim/dev": "0.27.1",
-    "@decidim/eslint-config": "0.27.1",
-    "@decidim/stylelint-config": "0.27.1",
-    "eslint-config-prettier": "^8.2.0",
-    "eslint-config-standard": "^11.0.0",
-    "eslint-plugin-import": "^2.22.0",
-    "eslint-plugin-standard": "^3.1.0",
-    "sass-embedded": "~1.57.1"
-  },
-  "dependencies": {
+    "@decidim/dev": "0.30",
+    "@decidim/eslint-config": "0.30",
+    "@decidim/prettier-config": "0.30",
+    "@decidim/stylelint-config": "0.30",
+    "postcss-scss": "^4.0.9"
   }
 }