decidim-accountability 0.31.8 → 0.32.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c87e10cab3a24a882575bf4b40eded34c02803470f34109935f6c07120659aaf
-  data.tar.gz: d72cbd2c821899c74364b7e281d5f88280ad8e54106f189a589195fad68ebd82
+  metadata.gz: b11b03399049993a09e10d946a0963a2f79405496523bdb1b2392e52fab4c9fd
+  data.tar.gz: e9a3872042ae120dcd2d34acfdddd1fa96303b041661fe139428093d6915fdc5
 SHA512:
-  metadata.gz: f5121e60765ca3e4070f2372a1e50436fe46102e7e0b082269c782c382a863b80eacf5daa124809cce104b4301a870ff0ff346c653405923a3e05df51f80dddb
-  data.tar.gz: 4a5041e2052dad7340432f9e5ca7479e7cf9014c4cf14b2b5f25709305e6bb75b53d4fc1f105387ab94f8463088d7768fef39c8780cf086f54a4668647236627
+  metadata.gz: d92038bd1cbc613f975a6106d0f289c797faf1d3bc3725d4a1343bded0a5f39c80fbd64de70191059819b169af3b3446478be3189668a827ee8cd3b9646aa049
+  data.tar.gz: 85e75f6e3ba8b8f09f87c4d24aaa27a11d1a9891ba5ce4e2a38b77593130d7f8cbab98ded6deb29e146fa6ab72c8c8e1ecc345473bb45f4a90ec0c2564944b9f

data/README.md

@@ -1,29 +1,19 @@
-# Decidim::Accountability
+# decidim-accountability
 
-The Accountability module adds results to any participatory process. It adds a CRUD engine to the admin and public views scoped inside the participatory process. Accountability will link to related meetings and proposals and will be used to show the progress on the related proposals.
+The Accountability module adds results to any participatory space. It adds a CRUD engine to the admin and public views scoped inside the participatory space. Accountability will link to related meetings and proposals and will be used to show the progress on the related proposals.
 
 ## Usage
 
-Accountability will be available as a Component for a Participatory Process.
+Accountability will be available as a Component for a Participatory Space.
 
 ## Installation
 
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'decidim-accountability'
-```
-
-And then execute:
-
-```bash
-bundle
-```
+This is on the default Decidim installation so you should not change anything to use this component.
 
 ## Contributing
 
-See [Decidim](https://github.com/AjuntamentdeBarcelona/decidim).
+See [Decidim](https://github.com/decidim/decidim).
 
 ## License
 
-See [Decidim](https://github.com/AjuntamentdeBarcelona/decidim).
+See [Decidim](https://github.com/decidim/decidim).

data/app/cells/decidim/accountability/result_metadata/{project_aside.erb → result_aside.erb}

@@ -1,5 +1,5 @@
 <% items.each do |item| %>
-  <div class="accountability__project-aside-item">
+  <div class="accountability__result-aside-item">
     <div><%= icon item[:icon], class: "w-3.5 h-3.5 fill-current text-gray" %><%= item[:text] %></div>
     <div><%= item[:value] %></div>
   </div>

data/app/cells/decidim/accountability/result_metadata_cell.rb

@@ -23,7 +23,7 @@ module Decidim
       private
 
       def result_items
-        return [dates_item, status_item, status_description] if template == :project_aside
+        return [dates_item, status_item, status_description] if template == :result_aside
         return [reference, versions] if template == :show_footer
 
         [dates_item_compact, status_item_compact] + taxonomy_items

data/app/cells/decidim/accountability/{project → result_show}/milestones.erb

@@ -1,10 +1,10 @@
-<ol class="accountability__project-milestones">
+<ol class="accountability__result-milestones">
   <% milestones.each_with_index do |milestone, i| %>
-    <li class="accountability__project-milestones-milestone">
-      <div class="accountability__project-milestones-milestone-number">
+    <li class="accountability__result-milestones-milestone">
+      <div class="accountability__result-milestones-milestone-number">
         <span><%= i + 1 %></span>
       </div>
-      <div class="accountability__project-milestones-milestone-attributes">
+      <div class="accountability__result-milestones-milestone-attributes">
         <h3>
           <%= decidim_sanitize_translated milestone.title %>
         </h3>

data/app/cells/decidim/accountability/{project_cell.rb → result_show_cell.rb}

@@ -4,10 +4,11 @@ require "cell/partial"
 
 module Decidim
   module Accountability
-    # This cell renders a project
-    class ProjectCell < Decidim::ViewModel
+    # This cell renders a result
+    class ResultShowCell < Decidim::ViewModel
       include Decidim::Accountability::ApplicationHelper
       include Cell::ViewModel::Partial
+
       delegate :children, :milestones, to: :model
 
       alias result model
@@ -24,7 +25,7 @@ module Decidim
             text: t("decidim.accountability.results.milestones.title"),
             icon: "route-line",
             method: :cell,
-            args: ["decidim/accountability/project", result, { template: :milestones }]
+            args: ["decidim/accountability/result_show", result, { template: :milestones }]
           },
           {
             enabled: ResultHistoryCell.new(result).render?,

data/app/cells/decidim/accountability/status_cell.rb

@@ -7,7 +7,7 @@ module Decidim
     # This cell renders the status of a taxonomy or a result.
     class StatusCell < Decidim::ViewModel
       include Decidim::Accountability::ApplicationHelper
-      include Decidim::Accountability::BreadcrumbHelper
+      include Decidim::Accountability::CalculatorHelper
       include ActionView::Helpers::NumberHelper
 
       def show
@@ -80,10 +80,6 @@ module Decidim
         options[:render_count]
       end
 
-      def count_calculator(taxonomy_id)
-        Decidim::Accountability::ResultsCalculator.new(current_component, taxonomy_id).count
-      end
-
       def decidim
         Decidim::Accountability::Engine.routes.url_helpers
       end

data/app/commands/decidim/accountability/admin/import_component_to_accountability.rb

@@ -3,7 +3,7 @@
 module Decidim
   module Accountability
     module Admin
-      # A command with all the business logic when an admin imports projects from
+      # A command with all the business logic when an admin imports results from
       # one component to accountability.
       class ImportComponentToAccountability < Decidim::Command
         attr_reader :form

data/app/controllers/concerns/decidim/accountability/admin/filterable.rb

@@ -23,10 +23,6 @@ module Decidim
             collection.includes(:taxonomies).joins(:taxonomies)
           end
 
-          def search_field_predicate
-            :id_string_or_title_cont
-          end
-
           def filters
             [
               :taxonomies_part_of_contains,
@@ -48,7 +44,7 @@ module Decidim
           end
 
           def status_ids_hash(statuses)
-            statuses.each_with_object({}) { |status, hash| hash[status.id] = status.id }
+            statuses.to_h { |status| [status.id, status.id] }
           end
 
           def translated_status_id_eq(id)

data/app/controllers/decidim/accountability/admin/attachment_collections_controller.rb

@@ -9,8 +9,6 @@ module Decidim
       class AttachmentCollectionsController < Admin::ApplicationController
         include Decidim::Admin::Concerns::HasAttachmentCollections
 
-        protected
-
         def after_destroy_path
           result_attachment_collections_path(result, result.component, current_participatory_space)
         end

data/app/controllers/decidim/accountability/admin/attachments_controller.rb

@@ -9,8 +9,6 @@ module Decidim
       class AttachmentsController < Admin::ApplicationController
         include Decidim::Admin::Concerns::HasAttachments
 
-        protected
-
         def after_destroy_path
           results_path
         end

data/app/controllers/decidim/accountability/admin/import_components_controller.rb

@@ -15,20 +15,18 @@ module Decidim
           @form = form(Admin::ImportComponentForm).from_params(params, accountability_component: current_component)
 
           ImportComponentToAccountability.call(@form) do
-            on(:ok) do |projects|
-              flash[:notice] = I18n.t("import_components.new.success", scope: "decidim.accountability.admin", count: projects)
+            on(:ok) do |results|
+              flash[:notice] = I18n.t("import_components.new.success", scope: "decidim.accountability.admin", count: results)
               redirect_to results_path
             end
 
             on(:invalid) do
               flash[:alert] = I18n.t("import_components.create.invalid", scope: "decidim.accountability.admin")
-              render action: "new", status: :unprocessable_entity
+              render action: "new", status: :unprocessable_content
             end
           end
         end
 
-        protected
-
         def results_import_params
           params[:results_import] || {}
         end

data/app/controllers/decidim/accountability/admin/import_results_controller.rb

@@ -5,15 +5,13 @@ module Decidim
     module Admin
       # This controller allows an admin to import results from a csv file for the Accountability component
       class ImportResultsController < Admin::ApplicationController
-        def new
-          enforce_permission_to :create, :result
+        before_action :ensure_permissions
 
+        def new
           @form = form(Admin::ImportResultsForm).instance
         end
 
         def create
-          enforce_permission_to :create, :result
-
           @form = form(Admin::ImportResultsForm).from_params(params, current_component:)
 
           if @form.valid?
@@ -23,9 +21,15 @@ module Decidim
             redirect_to import_results_path(current_participatory_space, current_component)
           else
             flash[:alert] = I18n.t("imports.create.invalid", scope: "decidim.accountability.admin")
-            render action: "new", status: :unprocessable_entity
+            render action: "new", status: :unprocessable_content
           end
         end
+
+        private
+
+        def ensure_permissions
+          enforce_permission_to :create, :result
+        end
       end
     end
   end

data/app/controllers/decidim/accountability/admin/milestones_controller.rb

@@ -27,7 +27,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("milestones.create.invalid", scope: "decidim.accountability.admin")
-              render action: "new", status: :unprocessable_entity
+              render action: "new", status: :unprocessable_content
             end
           end
         end
@@ -51,7 +51,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("milestones.update.invalid", scope: "decidim.accountability.admin")
-              render action: "edit", status: :unprocessable_entity
+              render action: "edit", status: :unprocessable_content
             end
           end
         end

data/app/controllers/decidim/accountability/admin/results_bulk_actions_controller.rb

@@ -88,12 +88,12 @@ module Decidim
         end
 
         def result_params
-          @result_params ||= params.require(:result_bulk_actions).permit(
-            :decidim_accountability_status_id,
-            :start_date,
-            :end_date,
-            result_ids: [],
-            taxonomies: []
+          @result_params ||= params.expect(
+            result_bulk_actions: [:decidim_accountability_status_id,
+                                  :start_date,
+                                  :end_date,
+                                  { result_ids: [],
+                                    taxonomies: [] }]
           )
         end
       end

data/app/controllers/decidim/accountability/admin/results_controller.rb

@@ -13,6 +13,11 @@ module Decidim
 
         helper_method :results, :parent_result, :parent_results, :statuses, :present, :bulk_actions_form
 
+        def collection
+          parent_id = params[:parent_id].presence
+          @collection ||= Result.where(component: current_component, parent_id:).page(params[:page]).per(15).order(created_at: :asc)
+        end
+
         def new
           enforce_permission_to :create, :result
 
@@ -33,7 +38,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("results.create.invalid", scope: "decidim.accountability.admin")
-              render action: "new", status: :unprocessable_entity
+              render action: "new", status: :unprocessable_content
             end
           end
         end
@@ -57,18 +62,11 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("results.update.invalid", scope: "decidim.accountability.admin")
-              render action: "edit", status: :unprocessable_entity
+              render action: "edit", status: :unprocessable_content
             end
           end
         end
 
-        protected
-
-        def collection
-          parent_id = params[:parent_id].presence
-          @collection ||= Result.where(component: current_component, parent_id:).page(params[:page]).per(15).order(created_at: :asc)
-        end
-
         private
 
         def trashable_deleted_resource_type

data/app/controllers/decidim/accountability/admin/statuses_controller.rb

@@ -5,6 +5,8 @@ module Decidim
     module Admin
       # This controller allows an admin to manage results from a Participatory Process
       class StatusesController < Admin::ApplicationController
+        include Decidim::Accountability::Admin::Filterable
+
         helper_method :statuses
 
         def new
@@ -26,7 +28,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("statuses.create.invalid", scope: "decidim.accountability.admin")
-              render action: "new", status: :unprocessable_entity
+              render action: "new", status: :unprocessable_content
             end
           end
         end
@@ -50,7 +52,7 @@ module Decidim
 
             on(:invalid) do
               flash.now[:alert] = I18n.t("statuses.update.invalid", scope: "decidim.accountability.admin")
-              render action: "edit", status: :unprocessable_entity
+              render action: "edit", status: :unprocessable_content
             end
           end
         end
@@ -68,8 +70,18 @@ module Decidim
 
         private
 
+        def base_query
+          Status.where(component: current_component)
+        end
+
+        def filtered_collection
+          query.sorts = ["progress asc", "key asc"] if query.sorts.empty?
+
+          paginate(query.result)
+        end
+
         def statuses
-          @statuses ||= Status.where(component: current_component).page(params[:page]).per(15)
+          @statuses ||= filtered_collection
         end
 
         def status

data/app/controllers/decidim/accountability/results_controller.rb

@@ -5,22 +5,18 @@ module Decidim
     # Exposes the result resource so users can view them
     class ResultsController < Decidim::Accountability::ApplicationController
       include FilterResource
+
       helper Decidim::TraceabilityHelper
       helper Decidim::Accountability::BreadcrumbHelper
+      helper Decidim::Accountability::CalculatorHelper
 
-      helper_method :results, :result, :count_calculator, :selected_root_taxonomy, :selected_taxonomy_children, :selected_taxonomy_grandchildren?
-
-      before_action :set_controller_breadcrumb
+      helper_method :results, :result, :selected_root_taxonomy, :selected_taxonomy_children, :selected_taxonomy_grandchildren?
 
       def show
         raise ActionController::RoutingError, "Not Found" unless result
-
-        enforce_permission_to :read, :result, result:
       end
 
       def home
-        enforce_permission_to :read, :result
-
         @all_geocoded_results = results.geocoded
       end
 
@@ -70,27 +66,25 @@ module Decidim
                                     end
       end
 
-      def count_calculator(taxonomy_id)
-        Decidim::Accountability::ResultsCalculator.new(current_component, taxonomy_id).count
-      end
-
-      def controller_breadcrumb_items
-        @controller_breadcrumb_items ||= []
-      end
-
-      def set_controller_breadcrumb
-        controller_breadcrumb_items << breadcrumb_item
-      end
-
-      def breadcrumb_item
+      def add_parent_breadcrumb_item
         return {} if result&.parent.blank?
 
         {
           label: translated_attribute(result.parent.title),
-          url: result_path(result.parent),
+          url: Decidim::EngineRouter.main_proxy(current_component).result_path(result.parent),
           active: true
         }
       end
+
+      def add_breadcrumb_item
+        return {} if result.blank?
+
+        {
+          label: translated_attribute(result.title),
+          url: Decidim::EngineRouter.main_proxy(current_component).result_path(result),
+          active: false
+        }
+      end
     end
   end
 end

data/app/controllers/decidim/accountability/versions_controller.rb

@@ -10,15 +10,25 @@ module Decidim
 
       include Decidim::ResourceVersionsConcern
 
-      private
-
       def versioned_resource
         result
       end
 
+      private
+
       def result
         @result ||= Result.includes(:milestones).where(component: current_component).find(params[:result_id])
       end
+
+      def add_breadcrumb_item
+        return {} if result.blank?
+
+        {
+          label: translated_attribute(result.title),
+          url: Decidim::EngineRouter.main_proxy(current_component).result_path(result),
+          active: false
+        }
+      end
     end
   end
 end

data/app/forms/decidim/accountability/admin/status_form.rb

@@ -15,7 +15,6 @@ module Decidim
 
         validates :key, presence: true
         validates :name, translatable_presence: true
-        validates :progress, numericality: { greater_than_or_equal_to: 0, less_than_or_equal_to: 100 }, if: ->(form) { form.progress.present? }
       end
     end
   end

data/app/helpers/decidim/accountability/breadcrumb_helper.rb

@@ -5,10 +5,6 @@ module Decidim
     # Helpers needed to render the navigation breadcrumbs in results.
     #
     module BreadcrumbHelper
-      def progress_calculator(taxonomy_id)
-        Decidim::Accountability::ResultsCalculator.new(current_component, taxonomy_id).progress
-      end
-
       def taxonomy
         return if (taxonomy_id = params.dig(:filter, :taxonomies_part_of_contains)).blank?
 

data/app/helpers/decidim/accountability/calculator_helper.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Accountability
+    # Helpers for calculating results progress and count
+    module CalculatorHelper
+      def progress_calculator(taxonomy_id)
+        ResultsCalculator.new(current_component, taxonomy_id).progress
+      end
+
+      def count_calculator(taxonomy_id)
+        ResultsCalculator.new(current_component, taxonomy_id).count
+      end
+    end
+  end
+end

data/app/mailers/decidim/accountability/import_projects_mailer.rb

@@ -3,12 +3,13 @@
 module Decidim
   module Accountability
     # This mailer sends a notification email containing the result of importing
-    # Cprojects to the results.
+    # projects from one budget component to accountability.
     class ImportProjectsMailer < Decidim::ApplicationMailer
       include Decidim::TranslatableAttributes
+
       helper Decidim::TranslationsHelper
 
-      # Public: Sends a notification email with the result of projects import selected projects to Accountability
+      # Public: Sends a notification email with the result of importing projects
       #
       # user   - The user to be notified.
       #

data/app/mailers/decidim/accountability/import_proposals_mailer.rb

@@ -6,6 +6,7 @@ module Decidim
     # proposals to the results.
     class ImportProposalsMailer < Decidim::ApplicationMailer
       include Decidim::TranslatableAttributes
+
       helper Decidim::TranslationsHelper
 
       # Public: Sends a notification email with the result of proposals import selected proposals to Accountability

data/app/models/decidim/accountability/result.rb

@@ -39,13 +39,15 @@ module Decidim
 
       after_save :update_parent_progress, if: -> { parent_id.present? }
 
-      searchable_fields(
-        scope_id: :decidim_scope_id,
-        participatory_space: { component: :participatory_space },
-        A: :title,
-        D: :description,
-        datetime: :start_date
-      )
+      searchable_fields({
+                          scope_id: :decidim_scope_id,
+                          participatory_space: { component: :participatory_space },
+                          A: :title,
+                          D: :description,
+                          datetime: :start_date
+                        },
+                        index_on_create: ->(result) { result.visible? },
+                        index_on_update: ->(result) { result.visible? })
 
       geocoded_by :address
 

data/app/models/decidim/accountability/status.rb

@@ -22,8 +22,11 @@ module Decidim
       # Allow ransacker to search for a key in a hstore column (`name`.`en`)
       ransacker_i18n :name
 
-      def self.ransackable_attributes(_auth_object = nil)
-        %w(id name)
+      def self.ransackable_attributes(auth_object = nil)
+        base = %w(id name)
+        return base unless auth_object&.admin?
+
+        base + %w(key progress)
       end
 
       def self.log_presenter_class_for(_log)

data/app/packs/stylesheets/accountability.scss

@@ -91,7 +91,7 @@
       @apply text-3xl;
     }
 
-    &__project &-title {
+    &__result &-title {
       @apply text-gray-2 text-md font-normal;
     }
   }
@@ -132,7 +132,7 @@
     @apply ml-auto rounded px-3 md:px-6 py-4 bg-background font-bold text-gray-2 text-xl w-full md:w-auto min-w-[120px] grid place-items-center;
   }
 
-  &__project {
+  &__result {
     &-aside {
       @apply bg-background p-4 rounded divide-y divide-gray-3 [&>*]:py-4 first:[&>*]:pt-0 last:[&>*]:pb-0;
 

data/app/permissions/decidim/accountability/permissions.rb

@@ -18,7 +18,7 @@ module Decidim
       def public_read_result_action?
         return unless permission_action.action == :read && permission_action.subject == :result
 
-        toggle_allow(result.nil? || !result.deleted?)
+        toggle_allow(result && !result.deleted?)
       end
 
       def result

data/app/views/decidim/accountability/admin/import_components/new.html.erb

@@ -7,7 +7,7 @@
 
 <div class="item__edit item__edit-1col">
   <div class="item__edit-form">
-    <%= render "form" %>
+    <%= render "decidim/accountability/admin/import_components/form" %>
   </div>
 </div>
 

data/app/views/decidim/accountability/admin/import_results/new.html.erb

@@ -6,7 +6,7 @@
 </div>
 <div class="item__edit item__edit-1col">
   <div class="item__edit-form">
-    <%= decidim_form_for(@form, url: import_results_path, html: { class: "form form-defaults import_projects" }) do |form| %>
+    <%= decidim_form_for(@form, url: import_results_path, html: { class: "form form-defaults import_results" }) do |form| %>
       <div class="card py-4">
         <div class="card-section space-y-4 prose max-w-full">
           <div class="row column">

data/app/views/decidim/accountability/admin/results/_actions.html.erb

@@ -88,7 +88,7 @@
       <% else %>
         <li class="dropdown__item">
           <div class="dropdown__button-disabled">
-            <%= with_tooltip t("tooltips.deleted_results_info", scope: "decidim.admin"), class: :left do %>
+            <%= with_tooltip t("tooltips.deleted_results_info", scope: "decidim.admin") do %>
               <%= icon "delete-bin-line", class: "text-gray" %>
               <span>
                 <%= t("actions.soft_delete", scope: "decidim.admin") %>

data/app/views/decidim/accountability/admin/results/_form.html.erb

@@ -48,11 +48,9 @@
       <% end %>
 
       <div class="row">
-        <% if statuses.any? %>
-          <div class="columns">
-            <%= form.select :decidim_accountability_status_id, statuses.map { |status| [translated_attribute(status.name), status.id, { "data-progress" => status.progress }] }, include_blank: true %>
-          </div>
-        <% end %>
+        <div class="columns">
+          <%= form.select :decidim_accountability_status_id, statuses.map { |status| [translated_attribute(status.name), status.id, { "data-progress" => status.progress }] }, include_blank: true %>
+        </div>
 
         <div class="columns">
           <%= form.number_field :progress %>