dech 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 558691d6d3a193e1034f53c757653d8b445e0ce1
-  data.tar.gz: 7eff60d509fe99172ec652dec658b41af0b60541
+  metadata.gz: 1e37c4e3ffda0a6566eb7bfd5315130ad4badcc5
+  data.tar.gz: 21995ddea993c65866b478cc49721f2a25c3cffe
 SHA512:
-  metadata.gz: 1532a2a6c9daa0005fc6b937304b8bf4e450da8117e144f3064d0592fbe0bca1344fc98e1a18c2b23197c0b71469d235936142a224ca5d8226f241c53e064ffc
-  data.tar.gz: dfbc97fc9eb0673f8f770abc13217a98695a31fda768a23d26b77edb5c457819f99de71bf40b84eee48eccccfc831882545ad3e44e26530d3def468980692438
+  metadata.gz: 29e3d5644ada4cfc0dd21cc6fba9588442fac3d32c818e82d8011f74007a1e7179d74869e7d865066c1111462310116dc4c1ca825bb12f9098a56b72beb4c138
+  data.tar.gz: bf6f9bcf903be27f07f28710ae5a55a0212d626086a4e46a11d3e8b9486356ec9b1c1f6508d6266da4eea4ae9fbcdbcd345f5021dbd9f84d09f62dca3b04e8f1

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in dech.gemspec
 gemspec
+
+gem "coveralls", require: false

data/README.md

@@ -1,6 +1,8 @@
 # Dech
 
+[![Gem Version](https://badge.fury.io/rb/dech.svg)](http://badge.fury.io/rb/dech)
 ![travis](https://travis-ci.org/e-maido/dech.svg?branch=master)
+[![Coverage Status](https://coveralls.io/repos/e-maido/dech/badge.png?branch=master)](https://coveralls.io/r/e-maido/dech?branch=master)
 
 ## Installation
 

data/lib/dech.rb

@@ -4,6 +4,7 @@ require "dech/hash_key_mapper"
 require "dech/version"
 
 require "dech/rakuten"
+require "dech/yahoo"
 
 # deprecated classes
 require "dech/price_uploader"

data/lib/dech/csv.rb

@@ -7,6 +7,10 @@ module Dech
   class CSV < StringIO
     DEFAULT_ENCODING = Encoding::Windows_31J
 
+    HEADER_MAPPINGS  = {}
+    REQUIRED_HEADERS = []
+    STATIC_COLUMNS   = {}
+
     def initialize(array, args={})
       @array = array
       @option = {}

data/lib/dech/version.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
 
 module Dech
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/dech/yahoo.rb

@@ -0,0 +1,7 @@
+# coding: utf-8
+require 'dech/yahoo/ftp'
+
+module Dech
+  class Yahoo
+  end
+end

data/lib/dech/yahoo/csv.rb

@@ -0,0 +1,58 @@
+# coding: utf-8
+require 'emmental'
+require 'dech/csv'
+require 'dech/hash_key_mapper'
+
+module Dech
+  class Yahoo
+    class CSV < Dech::CSV
+      ENCODING = Encoding::Windows_31J
+
+      HEADER_MAPPINGS = {
+        id:    "code",
+        price: ["price", "sale-price"]
+      }
+
+      REQUIRED_HEADERS = [
+        "path",
+        "name",
+        "code",
+        "price",
+        "sale-price"
+      ]
+
+      def initialize(products)
+        @products = products
+        super(formatted_products)
+      end
+
+      def valid?
+        validate! rescue false
+      end
+
+      def validate!
+        translated_products.each do |product|
+          REQUIRED_HEADERS.each do |header|
+            raise "#{header} is missing in #{product}" unless product.keys.include?(header)
+          end
+        end
+      end
+
+      private
+
+      def formatted_products
+        emmental = Emmental.new
+        translated_products.each{|product| emmental << product }
+        emmental.to_a
+      end
+
+      def translated_products
+        merged_products.map{|product| Dech::HashKeyMapper.map(product, HEADER_MAPPINGS) }
+      end
+
+      def merged_products
+        @products.map{|product| STATIC_COLUMNS.merge(product) }
+      end
+    end
+  end
+end

data/lib/dech/yahoo/ftp.rb

@@ -0,0 +1,45 @@
+# coding: utf-8
+require 'net/ftp'
+require 'dech/yahoo/csv'
+
+module Dech
+  class Yahoo
+    class FTP
+      DEFAULT_HOST = "yjftp.yahoofs.jp"
+      DEFAULT_PATH = "/data_spy.csv"
+
+      attr_accessor :products, :username, :host, :path
+
+      def initialize(args={})
+        @products = args[:products] || []
+        @username = args[:username]
+        @password = args[:password]
+        @host     = args[:host] || DEFAULT_HOST
+        @path     = args[:path] || DEFAULT_PATH
+      end
+
+      def csv
+        Dech::Yahoo::CSV.new(@products)
+      end
+
+      def ready?
+        ftp_connection{|ftp| !ftp.nlst(File.dirname(@path)).include?(@path) }
+      end
+
+      def upload!
+        ftp_connection{|ftp| ftp.storlines("STOR #{@path}", csv) }
+        true
+      end
+
+      def upload
+        ready? && upload!
+      end
+
+      private
+
+      def ftp_connection
+         Net::FTP.open(@host, @username, @password){|ftp| yield(ftp) }
+      end
+    end
+  end
+end

data/spec/dech/rakuten/csv_spec.rb

@@ -12,8 +12,6 @@ describe Dech::Rakuten::CSV do
     it { is_expected.to be_an_instance_of(Dech::Rakuten::CSV) }
     it { is_expected.to be_a(Dech::CSV) }
     it { is_expected.to be_a(StringIO) }
-
-    p Dech::Rakuten::CSV.new(products).to_a
   end
 
   describe "#valid?" do

data/spec/dech/rakuten/ftp_spec.rb

@@ -55,22 +55,6 @@ describe Dech::Rakuten::FTP do
     end
   end
 
-=begin
-  describe "#upload" do
-    context "server is ready" do
-      before do
-        allow(ftp).to receive(:nlst).and_return([])
-        expect(ftp).to receive(:storlines)
-        expect(Net::FTP).to receive(:new).and_return(ftp).at_least(:once)
-      end
-
-      it "should upload CSV file to the path on FTP server" do
-        expect(dech.upload).to be true
-      end
-    end
-  end
-=end
-
   describe "#upload" do
     subject{ lambda{ ftp.upload } }
 

data/spec/dech/yahoo/csv_spec.rb

@@ -0,0 +1,44 @@
+# coding: utf-8
+require "spec_helper"
+
+describe Dech::Yahoo::CSV do
+  let(:valid_products){
+    [
+      {id: "ABC-001", price: 12800, "name" => "ProductName1", "path" => "a:b"},
+      {id: "xyz-123", price: 9800, "name" => "ProductName2", "path" => "a:b:c"}
+    ]
+  }
+
+  let(:invalid_products){ [ {price: 12800}, {price: 9800} ] }
+
+  describe "initialize" do
+    subject{ Dech::Yahoo::CSV.new(valid_products) }
+    it { is_expected.to be_an_instance_of(Dech::Yahoo::CSV) }
+    it { is_expected.to be_a(Dech::CSV) }
+    it { is_expected.to be_a(StringIO) }
+  end
+
+  describe "#valid?" do
+    context "with valid columns" do
+      subject{ Dech::Yahoo::CSV.new(valid_products) }
+      it { is_expected.to be_valid }
+    end
+
+    context "with invalid columns" do
+      subject{ Dech::Yahoo::CSV.new(invalid_products) }
+      it { is_expected.not_to be_valid }
+    end
+  end
+
+  describe "#validate!" do
+    context "valid columns" do
+      subject{ lambda{ Dech::Yahoo::CSV.new(valid_products).validate! } }
+      it { is_expected.not_to raise_error }
+    end
+
+    context "invalid columns" do
+      subject{ lambda{ Dech::Yahoo::CSV.new(invalid_products).validate! } }
+      it { is_expected.to raise_error }
+    end
+  end
+end

data/spec/dech/yahoo/ftp_spec.rb

@@ -0,0 +1,76 @@
+# coding: utf-8
+require "spec_helper"
+
+describe Dech::Yahoo::FTP do
+  let(:ftp) {
+    described_class.new(
+      products: [{id: "PRODUCT-CODE", price: 9800, "path" => "a:b", "name" => "productA"}],
+      username: "username",
+      password: "password",
+      host:     "example.com"
+    )
+  }
+
+  let(:net_ftp) {
+    net_ftp = double("net_ftp")
+    allow(net_ftp).to receive(:passive=)
+    allow(net_ftp).to receive(:connect)
+    allow(net_ftp).to receive(:login)
+    allow(net_ftp).to receive(:close)
+    expect(Net::FTP).to receive(:new).and_return(net_ftp)
+    net_ftp
+  }
+
+  describe "initialize" do
+    subject { ftp }
+    it { is_expected.to be_an_instance_of(described_class) }
+  end
+
+  describe "#csv" do
+    subject { ftp.csv }
+    it { is_expected.to be_an_instance_of(Dech::Yahoo::CSV) }
+  end
+
+  describe "#ready?" do
+    subject { ftp.ready? }
+
+    context "CSV file exists in FTP server" do
+      before { expect(net_ftp).to receive(:nlst).and_return([ftp.path]) }
+      it { is_expected.to be false }
+    end
+
+    context "CSV file does not exist in FTP server" do
+      before { expect(net_ftp).to receive(:nlst).and_return([]) }
+      it { is_expected.to be true }
+    end
+  end
+
+  describe "#upload!" do
+    subject{ lambda{ ftp.upload! } }
+
+    it "should upload CSV file to the path on FTP server" do
+      expect(net_ftp).to receive(:storlines)
+      subject.call
+    end
+  end
+
+  describe "#upload" do
+    subject{ lambda{ ftp.upload } }
+
+    context "FTP server is ready" do
+      it "should call #upload!" do
+        expect(ftp).to receive(:ready?).and_return(true)
+        expect(ftp).to receive(:upload!).and_return(true)
+        subject.call
+      end
+    end
+
+    context "FTP server is not ready" do
+      it "should not call #upload!" do
+        expect(ftp).to receive(:ready?).and_return(false)
+        expect(ftp).not_to receive(:upload!)
+        subject.call
+      end
+    end
+  end
+end

data/spec/dech/yahoo_spec.rb

@@ -0,0 +1,5 @@
+# coding: utf-8
+require "spec_helper"
+
+describe Dech::Yahoo do
+end

data/spec/spec_helper.rb

@@ -6,3 +6,6 @@ $: << project_root
 Dir[File.join(File.dirname(__FILE__), "support", "*")].each {|f| require f }
 
 require 'lib/dech'
+
+require 'coveralls'
+Coveralls.wear!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dech
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - OSA Shunsuke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-07 00:00:00.000000000 Z
+date: 2014-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: double-bag-ftps
@@ -123,6 +123,9 @@ files:
 - lib/dech/rakuten/csv.rb
 - lib/dech/rakuten/ftp.rb
 - lib/dech/version.rb
+- lib/dech/yahoo.rb
+- lib/dech/yahoo/csv.rb
+- lib/dech/yahoo/ftp.rb
 - spec/dech/csv_spec.rb
 - spec/dech/csvio_spec.rb
 - spec/dech/hash_key_mapper_spec.rb
@@ -131,6 +134,9 @@ files:
 - spec/dech/rakuten/csv_spec.rb
 - spec/dech/rakuten/ftp_spec.rb
 - spec/dech/rakuten_spec.rb
+- spec/dech/yahoo/csv_spec.rb
+- spec/dech/yahoo/ftp_spec.rb
+- spec/dech/yahoo_spec.rb
 - spec/dech_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/e-maido/dech
@@ -166,5 +172,8 @@ test_files:
 - spec/dech/rakuten/csv_spec.rb
 - spec/dech/rakuten/ftp_spec.rb
 - spec/dech/rakuten_spec.rb
+- spec/dech/yahoo/csv_spec.rb
+- spec/dech/yahoo/ftp_spec.rb
+- spec/dech/yahoo_spec.rb
 - spec/dech_spec.rb
 - spec/spec_helper.rb