debug 1.0.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3e49208dc5aafac57624c1bfb06a1f1d4975bc1a3ea1739b170cd97b4805f80
-  data.tar.gz: 631bb42bb4bb78cb6bda141e062e317edfb49fc01bbf6e4ca65036efc5175c12
+  metadata.gz: 7831c2e401b4bf33ecd14f5cef5eeb1c1a0feb57037a162c00f6cc780975b4c6
+  data.tar.gz: 182d55e56b662858b04e03336dd8bb4d0e15da8418b3aea137d05dcd02aa4ac0
 SHA512:
-  metadata.gz: 03d36a4f2ba792570d77206897e112e74947cf951f36dbd62b94f6faefbc431735b92da833682b1e768368e9393051cc7efea784daf853ab6d927b57780ca780
-  data.tar.gz: 837963016cb3d8cb932796706323761ecbcdda55d9c8da0cc68d1d324ad92018e06959489273edbb7a3f0fadc817d699dd744266a3e48ce6ce1647370a77cd1d
+  metadata.gz: dcf9f62fc4cf7f782238cd7b61137bde035047f6226eeac6cae639b28ada181862ee82ce146a1e33c6c08d80a8fc35ffe4a2cf24eda576e4792babbf8436ca88
+  data.tar.gz: 1f66b3c18a14f1f337d010a8e9d29d6a0e0b1c4c92c976a87e0c2db265ff6a1259d31918e4c10525d16154f6a8f9fa694bcdbebbb081278b6ee488ae122f8713

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,24 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Your environment**
+
+* `ruby -v`: 
+* `rdbg -v`:
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Additional context**
+Add any other context about the problem here.

data/.github/ISSUE_TEMPLATE/custom.md

@@ -0,0 +1,10 @@
+---
+name: Custom issue template
+about: Blank issue
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,14 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Your proposal**
+What is your idea?
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

data/README.md

@@ -8,7 +8,7 @@ This debug.rb is replacement of traditional lib/debug.rb standard library which
 New debug.rb has several advantages:
 
 * Fast: No performance penalty on non-stepping mode and non-breakpoints.
-* Remote debugging: Support remote debugging natively.
+* [Remote debugging](#remote-debugging): Support remote debugging natively.
   * UNIX domain socket
   * TCP/IP
   * VSCode/DAP integration ([VSCode rdbg Ruby Debugger - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=KoichiSasada.vscode-rdbg))
@@ -44,22 +44,24 @@ To use a debugger, roughly you will do the following steps:
 2. Run a program with the debugger.
 3. At the breakpoint, enter the debugger console.
 4. Use debug commands.
-    * Query the program status (e.g. `p lvar` to see the local variable `lvar`).
-    * Control program flow (e.g. move to the another line with `step`, to the next line with `next`).
-    * Set another breakpoint (e.g. `catch Exception` to set a breakpoint when `Exception` is raised).
-    * Change the configuration (e.g. `config set no_color true` to disable coloring).
+    * [Evaluate Ruby expressions](#evaluate) (e.g. `p lvar` to see the local variable `lvar`).
+    * [Query the program status](#information) (e.g. `info` to see information about the current frame).
+    * [Control program flow](#control-flow) (e.g. move to the another line with `step`, to the next line with `next`).
+    * [Set another breakpoint](#breakpoint) (e.g. `catch Exception` to set a breakpoint that'll be triggered when `Exception` is raised).
+    * [Activate tracing in your program](#trace) (e.g. `trace call` to trace method calls).
+    * [Change the configuration](#configuration-1) (e.g. `config set no_color true` to disable coloring).
     * Continue the program (`c` or `continue`) and goto 3.
 
 ## Invoke with the debugger
 
 There are several options for (1) and (2). Please choose your favorite way.
 
-### Modify source code as `binding.pry` and `binding.irb`
+### Modify source code with [`binding.break`](#bindingbreak-method) (similar to `binding.pry` or `binding.irb`)
 
-If you can modify the source code, you can use the debugger by adding `require 'debug'` line at the top of your program and putting `binding.break` method (`binding.b` for short) into lines where you want to stop as breakpoints like `binding.pry` and `binding.irb`.
+If you can modify the source code, you can use the debugger by adding `require 'debug'` line at the top of your program and putting [`binding.break`](#bindingbreak-method) method (`binding.b` for short) into lines where you want to stop as breakpoints like `binding.pry` and `binding.irb`.
 After that, you run the program as usual and you will enter the debug console at breakpoints you inserted.
 
-The following example shows the demonstration of `binding.break`.
+The following example shows the demonstration of [`binding.break`](#bindingbreak-method).
 
 ```shell
 $ cat target.rb                        # Sample program
@@ -355,7 +357,7 @@ config set no_color true
   * `RUBY_DEBUG_LOG_LEVEL` (`log_level`): Log level same as Logger (default: WARN)
   * `RUBY_DEBUG_SHOW_SRC_LINES` (`show_src_lines`): Show n lines source code on breakpoint (default: 10 lines)
   * `RUBY_DEBUG_SHOW_FRAMES` (`show_frames`): Show n frames on breakpoint (default: 2 frames)
-  * `RUBY_DEBUG_USE_SHORT_PATH` (`use_short_path`): Show shoten PATH (like $(Gem)/foo.rb)
+  * `RUBY_DEBUG_USE_SHORT_PATH` (`use_short_path`): Show shorten PATH (like $(Gem)/foo.rb)
   * `RUBY_DEBUG_NO_COLOR` (`no_color`): Do not use colorize (default: false)
   * `RUBY_DEBUG_NO_SIGINT_HOOK` (`no_sigint_hook`): Do not suspend on SIGINT (default: false)
   * `RUBY_DEBUG_NO_RELINE` (`no_reline`): Do not use Reline library (default: false)
@@ -370,6 +372,7 @@ config set no_color true
 
 * BOOT
   * `RUBY_DEBUG_NONSTOP` (`nonstop`): Nonstop mode
+  * `RUBY_DEBUG_STOP_AT_LOAD` (`stop_at_load`): Stop at just loading location
   * `RUBY_DEBUG_INIT_SCRIPT` (`init_script`): debug command script path loaded at first stop
   * `RUBY_DEBUG_COMMANDS` (`commands`): debug commands invoked at first stop. commands should be separated by ';;'
   * `RUBY_DEBUG_NO_RC` (`no_rc`): ignore loading ~/.rdbgrc(.rb)
@@ -434,6 +437,9 @@ The `<...>` notation means the argument.
   * Stop the debuggee process with `Kernal#exit!`.
 * `kill!`
   * Same as kill but without the confirmation prompt.
+* `sigint`
+  * Execute SIGINT handler registerred by the debuggee.
+  * Note that this command should be used just after stop by `SIGINT`.
 
 ### Breakpoint
 
@@ -494,7 +500,7 @@ The `<...>` notation means the argument.
   * Show information about the current frame (local variables)
   * It includes `self` as `%self` and a return value as `%return`.
 * `i[nfo] i[var[s]]` or `i[nfo] instance`
-  * Show information about insttance variables about `self`.
+  * Show information about instance variables about `self`.
 * `i[nfo] c[onst[s]]` or `i[nfo] constant[s]`
   * Show information about accessible constants except toplevel constants.
 * `i[nfo] g[lobal[s]]`
@@ -726,6 +732,7 @@ Attach mode:
 Other options:
     -h, --help                       Print help
         --util=NAME                  Utility mode (used by tools)
+        --stop-at-load               Stop immediately when the debugging feature is loaded.
 
 NOTE
   All messages communicated between a debugger and a debuggee are *NOT* encrypted.

data/Rakefile

@@ -7,15 +7,18 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList["test/**/*_test.rb"]
 end
 
-require "rake/extensiontask"
-
-task :build => :compile
-
-Rake::ExtensionTask.new("debug") do |ext|
-  ext.lib_dir = "lib/debug"
+begin
+  require "rake/extensiontask"
+  task :build => :compile
+
+  Rake::ExtensionTask.new("debug") do |ext|
+    ext.lib_dir = "lib/debug"
+  end
+rescue LoadError
 end
 
-task :default => [:clobber, :compile, :test, 'README.md']
+
+task :default => [:clobber, :compile, 'README.md', :test]
 
 file 'README.md' => ['lib/debug/session.rb', 'lib/debug/config.rb',
                      'exe/rdbg', 'misc/README.md.erb'] do

data/TODO.md

@@ -3,7 +3,7 @@
 ## Basic functionality
 
 * Support Ractors
-* Signal (SIGINT) trap handling
+* Signal (SIGINT) trap handling 
 
 ## UI
 
@@ -12,6 +12,7 @@
 * Interactive record & play debugging
 * irb integration
 * Web browser integrated UI
+* History file
 
 ## Debug command
 

data/debug.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.extensions    = ['ext/debug/extconf.rb']
 
-  spec.add_dependency "irb" # for its color_printer class, which was added after 1.3
+  spec.add_dependency "irb", ">= 1.3.6" # for its color_printer class, which was added after 1.3
   spec.add_dependency "reline", ">= 0.2.7"
 end

data/ext/debug/debug.c

@@ -122,6 +122,11 @@ Init_debug(void)
 {
     rb_mDebugger = rb_const_get(rb_cObject, rb_intern("DEBUGGER__"));
     rb_cFrameInfo = rb_const_get(rb_mDebugger, rb_intern("FrameInfo"));
+
+    // Debugger and FrameInfo were defined in Ruby. We need to register them
+    // as mark objects so they are automatically pinned.
+    rb_gc_register_mark_object(rb_mDebugger);
+    rb_gc_register_mark_object(rb_cFrameInfo);
     rb_define_singleton_method(rb_mDebugger, "capture_frames", capture_frames, 1);
     rb_define_singleton_method(rb_mDebugger, "frame_depth", frame_depth, 0);
     rb_define_singleton_method(rb_mDebugger, "create_method_added_tracker", create_method_added_tracker, 0);

data/lib/debug/breakpoint.rb

@@ -288,6 +288,7 @@ module DEBUGGER__
       @tp = TracePoint.new(:line){|tp|
         next if tp.path.start_with? __dir__
         next if tp.path.start_with? '<internal:'
+        next if ThreadClient.current.management?
 
         if safe_eval tp.binding, @expr
           suspend
@@ -430,17 +431,24 @@ module DEBUGGER__
         if @sig_op == '#'
           @cond_class = @klass if @method.owner != @klass
         else # '.'
-          @cond_class = @klass.singleton_class if @method.owner != @klass.singleton_class
+          begin
+            @cond_class = @klass.singleton_class if @method.owner != @klass.singleton_class
+          rescue TypeError
+          end
         end
 
-      rescue ArgumentError
+      rescue ArgumentError => e
         raise if retried
         retried = true
 
         # maybe C method
         case @sig_op
         when '.'
-          override @klass.singleton_class
+          begin
+            override @klass.singleton_class
+          rescue TypeError
+            override @klass.class
+          end
         when '#'
           override @klass
         end
@@ -450,7 +458,7 @@ module DEBUGGER__
         @override_method = true if @method
         retry
       end
-    rescue Exception
+    rescue Exception => e
       raise unless added
     end
 
@@ -460,7 +468,8 @@ module DEBUGGER__
 
     def to_s
       if @method
-        "#{generate_label("Method")} #{sig} at #{@method.source_location.join(':')}"
+        loc = @method.source_location || []
+        "#{generate_label("Method")} #{sig} at #{loc.join(':')}"
       else
         "#{generate_label("Method (pending)")} #{sig}"
       end + super

data/lib/debug/color.rb

@@ -17,9 +17,25 @@ end
 module DEBUGGER__
   module Color
     if defined? IRB::Color.colorize
+      begin
+        IRB::Color.colorize('', [:DIM], colorable: true)
+        SUPPORT_COLORABLE_OPTION = true
+      rescue ArgumentError
+      end
+
+      if defined? SUPPORT_COLORABLE_OPTION
+        def irb_colorize str, color
+          IRB::Color.colorize str, color, colorable: true
+        end
+      else
+        def irb_colorize str, color
+          IRB::Color.colorize str, color
+        end
+      end
+
       def colorize str, color
         if !CONFIG[:no_color]
-          IRB::Color.colorize str, color
+          irb_colorize str, color
         else
           str
         end
@@ -63,8 +79,14 @@ module DEBUGGER__
     end
 
     if defined? IRB::Color.colorize_code
-      def colorize_code code
-        IRB::Color.colorize_code(code)
+      if SUPPORT_COLORABLE_OPTION
+        def colorize_code code
+          IRB::Color.colorize_code(code, colorable: true)
+        end
+      else
+        def colorize_code code
+          IRB::Color.colorize_code(code)
+        end
       end
     else
       def colorize_code code

data/lib/debug/config.rb

@@ -1,12 +1,20 @@
 # frozen_string_literal: true
 
 module DEBUGGER__
+  LOG_LEVELS = {
+    UNKNOWN: 0,
+    FATAL:   1,
+    ERROR:   2,
+    WARN:    3,
+    INFO:    4,
+  }.freeze
+
   CONFIG_SET = {
     # UI setting
     log_level:      ['RUBY_DEBUG_LOG_LEVEL',      "UI: Log level same as Logger (default: WARN)",                   :loglevel],
     show_src_lines: ['RUBY_DEBUG_SHOW_SRC_LINES', "UI: Show n lines source code on breakpoint (default: 10 lines)", :int],
     show_frames:    ['RUBY_DEBUG_SHOW_FRAMES',    "UI: Show n frames on breakpoint (default: 2 frames)",            :int],
-    use_short_path: ['RUBY_DEBUG_USE_SHORT_PATH', "UI: Show shoten PATH (like $(Gem)/foo.rb)",                      :bool],
+    use_short_path: ['RUBY_DEBUG_USE_SHORT_PATH', "UI: Show shorten PATH (like $(Gem)/foo.rb)",                      :bool],
     no_color:       ['RUBY_DEBUG_NO_COLOR',       "UI: Do not use colorize (default: false)",                       :bool],
     no_sigint_hook: ['RUBY_DEBUG_NO_SIGINT_HOOK', "UI: Do not suspend on SIGINT (default: false)",                  :bool],
     no_reline:      ['RUBY_DEBUG_NO_RELINE',      "UI: Do not use Reline library (default: false)",                 :bool],
@@ -21,6 +29,7 @@ module DEBUGGER__
 
     # boot setting
     nonstop:        ['RUBY_DEBUG_NONSTOP',     "BOOT: Nonstop mode",                                                :bool],
+    stop_at_load:   ['RUBY_DEBUG_STOP_AT_LOAD',"BOOT: Stop at just loading location",                               :bool],
     init_script:    ['RUBY_DEBUG_INIT_SCRIPT', "BOOT: debug command script path loaded at first stop"],
     commands:       ['RUBY_DEBUG_COMMANDS',    "BOOT: debug commands invoked at first stop. commands should be separated by ';;'"],
     no_rc:          ['RUBY_DEBUG_NO_RC',       "BOOT: ignore loading ~/.rdbgrc(.rb)",                               :bool],
@@ -102,7 +111,9 @@ module DEBUGGER__
       end
 
       if_updated old_conf, conf, :postmortem do |_, new_p|
-        SESSION.postmortem = new_p
+        if defined?(SESSION)
+          SESSION.postmortem = new_p
+        end
       end
 
       if_updated old_conf, conf, :sigdump_sig do |old_sig, new_sig|
@@ -306,6 +317,10 @@ module DEBUGGER__
           exit
         end
 
+        o.on('--stop-at-load', 'Stop immediately when the debugging feature is loaded.') do
+          config[:stop_at_load] = true
+        end
+
         o.separator ''
         o.separator 'NOTE'
         o.separator '  All messages communicated between a debugger and a debuggee are *NOT* encrypted.'
@@ -372,7 +387,7 @@ module DEBUGGER__
     desc = cat = nil
     cmds = Hash.new
 
-    File.read(File.join(__dir__, 'session.rb')).each_line do |line|
+    File.read(File.join(__dir__, 'session.rb'), encoding: Encoding::UTF_8).each_line do |line|
       case line
       when /\A\s*### (.+)/
         cat = $1

data/lib/debug/console.rb

@@ -6,11 +6,19 @@ module DEBUGGER__
       require 'reline'
 
       # reline 0.2.7 or later is required.
-      raise LoadError if Reline::VERSION < '0.2.6'
+      raise LoadError if Reline::VERSION < '0.2.7'
 
       require_relative 'color'
       include Color
 
+      begin
+        prev = trap(:SIGWINCH, nil)
+        trap(:SIGWINCH, prev)
+        SIGWINCH_SUPPORTED = true
+      rescue ArgumentError
+        SIGWINCH_SUPPORTED = false
+      end
+
       # 0.2.7 has SIGWINCH issue on non-main thread
       class ::Reline::LineEditor
         m = Module.new do
@@ -20,7 +28,7 @@ module DEBUGGER__
           end
         end
         prepend m
-      end
+      end if SIGWINCH_SUPPORTED
 
       def readline_setup prompt
         commands = DEBUGGER__.commands

data/lib/debug/frame_info.rb

@@ -9,10 +9,10 @@ module DEBUGGER__
                         )
 
   # extend FrameInfo with debug.so
-  if File.exist? File.join(__dir__, 'debug.so')
+  begin
     require_relative 'debug.so'
-  else
-    require_relative 'debug'
+  rescue LoadError
+    require 'debug/debug.so'
   end
 
   class FrameInfo
@@ -27,6 +27,7 @@ module DEBUGGER__
     end
 
     def pretty_path
+      return '#<none>' unless path = self.path
       use_short_path = CONFIG[:use_short_path]
 
       case
@@ -137,10 +138,9 @@ module DEBUGGER__
       if lvars = self._local_variables
         lvars
       elsif b = self.binding
-        lvars = b.local_variables.map{|var|
+        b.local_variables.map{|var|
           [var, b.local_variable_get(var)]
         }.to_h
-        self._local_variables = lvars
       end
     end
 

data/lib/debug/local.rb

@@ -7,32 +7,27 @@ module DEBUGGER__
   class UI_LocalConsole < UI_Base
     def initialize
       @console = Console.new
-
-      unless CONFIG[:no_sigint_hook]
-        @prev_handler = trap(:SIGINT){
-          if SESSION.active?
-            ThreadClient.current.on_trap :SIGINT
-          end
-        }
-      end
-    end
-
-    def close
-      if @prev_handler
-        trap(:SIGINT, @prev_handler)
-      end
     end
 
     def remote?
       false
     end
 
-    def activate on_fork: false
-      # Do nothing
+    def activate session, on_fork: false
+      unless CONFIG[:no_sigint_hook]
+        prev_handler = trap(:SIGINT){
+          if session.active?
+            ThreadClient.current.on_trap :SIGINT
+          end
+        }
+        session.intercept_trap_sigint_start prev_handler
+      end
     end
 
     def deactivate
-      # Do nothing
+      if SESSION.intercept_trap_sigint?
+        trap(:SIGINT, SESSION.intercepted_sigint_cmd)
+      end
     end
 
     def width
@@ -76,15 +71,17 @@ module DEBUGGER__
     end
 
     def setup_interrupt
-      current_thread = Thread.current # should be session_server thread
+      SESSION.intercept_trap_sigint false do
+        current_thread = Thread.current # should be session_server thread
 
-      prev_handler = trap(:INT){
-        current_thread.raise Interrupt
-      }
+        prev_handler = trap(:INT){
+          current_thread.raise Interrupt
+        }
 
-      yield
-    ensure
-      trap(:INT, prev_handler)
+        yield
+      ensure
+        trap(:INT, prev_handler)
+      end
     end
   end
 end

data/lib/debug/server.rb

@@ -15,8 +15,6 @@ module DEBUGGER__
       @q_ans = nil
       @unsent_messages = []
       @width = 80
-
-      activate
     end
 
     class Terminate < StandardError
@@ -37,7 +35,7 @@ module DEBUGGER__
       end
     end
 
-    def activate on_fork: false
+    def activate session, on_fork: false
       @reader_thread = Thread.new do
         # An error on this thread should break the system.
         Thread.current.abort_on_exception = true
@@ -138,9 +136,9 @@ module DEBUGGER__
     end
 
     def setup_interrupt
-      prev_handler = trap(:SIGINT) do
+      prev_handler = trap(:SIGURG) do
         # $stderr.puts "trapped SIGINT"
-        ThreadClient.current.on_trap :SIGINT
+        ThreadClient.current.on_trap :SIGURG
 
         case prev_handler
         when Proc
@@ -150,9 +148,12 @@ module DEBUGGER__
         end
       end
 
+      if prev_handler != "SYSTEM_DEFAULT"
+        DEBUGGER__.warn "SIGURG handler is overriddend by the debugger."
+      end
       yield
     ensure
-      trap(:SIGINT, prev_handler)
+      trap(:SIGURG, prev_handler)
     end
 
     attr_reader :reader_thread
@@ -230,7 +231,7 @@ module DEBUGGER__
 
     def pause
       # $stderr.puts "DEBUG: pause request"
-      Process.kill(:SIGINT, Process.pid)
+      Process.kill(:SIGURG, Process.pid)
     end
 
     def quit n