debtective 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a9c75632f4f3a8785af1c96209c22b68772f8bde253cbd76e2bdb774a3812a8
-  data.tar.gz: d4b50399a0806ad8e4a6fb20305429882847ef79dd42bd176d17be3f5f1df786
+  metadata.gz: 4c9cd2c9eaaa35023797d69a854fd1b749269c03e029a1fd9447b993d653b917
+  data.tar.gz: 7b3cff2afb3474d1ec0ba8449f88e4795f91d35c4b49af4337e9eb64693443e2
 SHA512:
-  metadata.gz: 59b68258f51e5f7a83992c8d24d0bc028fcb7dcdea2f379d0af011a8ec9c5dba645d6ffef4f94652d3ce7f0662185597934b96a6c8d2fa74ccc392b027b207fe
-  data.tar.gz: a5556a654c194fc442727c67f6c06686c6df851fe4008540670603d5aac8203e67e96a62d498b0eb57b91bdae76a2c967d789b29709659b84d3178632e7b893f
+  metadata.gz: 3ad250e7e42470f6404de2eaff106319c5c7f6f543276e02ef28afba2a6fc301f3bb35ecea069737e21f5ceeb70126fc968e70118f3f4196f75eeebd0ad1c724
+  data.tar.gz: d648747191b567134e238e4692014ef211c5715bd5524245e524626de5b8ee8fd87979641a6a3238755a2512171266081072c9ca3a5fc47f3b16d7ce7084f752

data/bin/debtective

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require "debtective"
+require "debtective/output_todos"
+
+Debtective::OutputTodos.new.call

data/lib/debtective/build_todo.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require "debtective/todo"
+require "debtective/find_end_of_statement"
+
+module Debtective
+  # Find the todos comments and their boundaries
+  class BuildTodo
+    BEFORE_LINE_TODO_REGEX = /^\s*#\sTODO:\s/
+    INLINE_TODO_REGEX = /\s*#\sTODO:\s/
+    COMMENT_REGEX = /\s*#/
+
+    # @param pathname [Pathname]
+    # @param index [Integer]
+    def initialize(pathname, index)
+      @pathname = pathname
+      @index = index
+    end
+
+    # @return [Debtective::Todo]
+    def call
+      Todo.new(
+        @pathname,
+        lines,
+        todo_boundaries,
+        statement_boundaries
+      )
+    end
+
+    private
+
+    # @return [Array<String>]
+    def lines
+      @lines ||= @pathname.readlines
+    end
+
+    # @return [Range]
+    def todo_boundaries
+      @index..([@index, statement_boundaries.min - 1].max)
+    end
+
+    # range of the concerned code
+    # @return [Range]
+    def statement_boundaries
+      @statement_boundaries ||=
+        case lines[@index]
+        when BEFORE_LINE_TODO_REGEX
+          first_line_index = statement_start
+          last_line_index = FindEndOfStatement.new(lines, first_line_index).call
+          first_line_index..last_line_index
+        when INLINE_TODO_REGEX
+          @index..@index
+        end
+    end
+
+    # start index of the concerned code (i.e. below the TODO comment)
+    # @return [Integer]
+    def statement_start
+      lines.index.with_index do |line, i|
+        i > @index &&
+          !line.strip.empty? &&
+          !line.match?(COMMENT_REGEX)
+      end
+    end
+  end
+end

data/lib/debtective/{end_of_statement.rb → find_end_of_statement.rb}

@@ -1,23 +1,26 @@
 # frozen_string_literal: true
 
-require "parser/current"
+require "debtective/stderr_helper"
 
 module Debtective
   # Find the index of the line ending a statement
   #
-  # EndOfStatement.new(
-  #   [
-  #     "class User",
-  #     "  def example",
-  #     "    x + y",
-  #     "  end"
-  #     "end"
-  #   ],
-  #   1
-  # ).call
-  # => 3
+  # @example
+  #   FindEndOfStatement.new(
+  #     [
+  #       "class User",
+  #       "  def example",
+  #       "    x + y",
+  #       "  end"
+  #       "end"
+  #     ],
+  #     1
+  #   ).call
+  #   => 3
   #
-  class EndOfStatement
+  class FindEndOfStatement
+    include StderrHelper
+
     # @param lines [Array<String>] lines of code
     # @param index [Integer] index of the statement first line
     def initialize(lines, first_line_index)
@@ -27,24 +30,24 @@ module Debtective
 
     # index of the line ending the statement
     # @return [Integer]
+    # @note use suppress_stderr to prevent error outputs
+    #   from RubyVM::InstructionSequence.compile
     def call
-      suppress_stderr do
-        last_line_index || @first_line_index
-      end
+      suppress_stderr { last_line_index }
     end
 
     private
 
-    # index of the line ending the statement
+    # recursively find index of the line ending the statement
+    # @param index [Integer] used for recursion
     # @return[Integer, void]
     # @note it is possible that no line ends the statement
     # especially if first line is not the start of a statement
-    def last_line_index
-      @lines.index.with_index do |_line, index|
-        index >= @first_line_index &&
-          statement?(index) &&
-          !chained?(index)
-      end
+    def last_line_index(index = @first_line_index)
+      return @first_line_index if index >= @lines.size
+      return index if !chained?(index) && statement?(index)
+
+      last_line_index(index + 1)
     end
 
     # check if the code from first index to given index is a statement
@@ -53,9 +56,8 @@ module Debtective
     # @return boolean
     def statement?(index)
       code = @lines[@first_line_index..index].join("\n")
-      ::Parser::CurrentRuby.parse(code)
-      true
-    rescue Parser::SyntaxError
+      RubyVM::InstructionSequence.compile(code)
+    rescue SyntaxError
       false
     end
 
@@ -66,16 +68,5 @@ module Debtective
     def chained?(index)
       @lines[index + 1]&.match?(/^(\s*)\./)
     end
-
-    # silence the $stderr
-    # to avoid logs from the parser
-    # @return void
-    def suppress_stderr
-      original_stderr = $stderr.clone
-      $stderr.reopen(File.new("/dev/null", "w"))
-      yield
-    ensure
-      $stderr.reopen(original_stderr)
-    end
   end
 end

data/lib/debtective/find_todos.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require "debtective/build_todo"
+
+module Debtective
+  # Find and investigate todo comments and return a list of todos
+  class FindTodos
+    TODO_REGEX = /#\sTODO:/
+
+    # @param paths [Array<String>]
+    def initialize(paths)
+      @paths = paths
+    end
+
+    # @return [Array<Debtective::Todo>]
+    def call
+      ruby_pathnames.flat_map { pathname_todos(_1) }
+    end
+
+    private
+
+    # @return [Array<Pathname>] only pathes to ruby files
+    def ruby_pathnames
+      @paths
+        .flat_map { Dir[_1] }
+        .map { Pathname(_1) }
+        .select { _1.file? && _1.extname == ".rb" }
+    end
+
+    # return todos in the pathname
+    # @return [Array<Debtective::Todo>]
+    def pathname_todos(pathname)
+      pathname.readlines.filter_map.with_index do |line, index|
+        next unless line.match?(TODO_REGEX)
+
+        Todo.build(pathname, index)
+      end
+    end
+  end
+end

data/lib/debtective/git_commit.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require "git"
+require "open3"
+
+module Debtective
+  # find the commit that introduced a line of code
+  class GitCommit
+    Author = Struct.new(:email, :name)
+    Commit = Struct.new(:sha, :author, :time)
+
+    SPECIAL_CHARACTER_REGEX = /(?!\w|\s|#|:).+/
+
+    # @param pathname [Pathname] file path
+    # @param code [String] line of code
+    def initialize(pathname, code)
+      @pathname = pathname
+      @code = code
+    end
+
+    # @return [Debtective::GitCommit::Commit]
+    def call
+      Commit.new(sha, author, time)
+    rescue Git::GitExecuteError
+      author = Author.new(nil, nil)
+      Commit.new(nil, author, nil)
+    end
+
+    # @return [Debtective::GitCommit::Author]
+    def author
+      Author.new(commit.author.email, commit.author.name)
+    end
+
+    # @return [Time]
+    def time
+      commit.date
+    end
+
+    # @return [Git::Base]
+    def git
+      Git.open(".")
+    end
+
+    # @return [Git::Object::Commit]
+    def commit
+      git.gcommit(sha)
+    end
+
+    # commit sha
+    # @return [String]
+    def sha
+      @sha ||=
+        begin
+          cmd = "git log -S \"#{safe_code}\" #{@pathname}"
+          stdout, _stderr, _status = ::Open3.capture3(cmd)
+          stdout[/commit (\w{40})\n/, 1]
+        end
+    end
+
+    # characters " and ` can break the git command
+    # @return [String]
+    def safe_code
+      @code.gsub(/"/, "\\\"").gsub("`", "\\\\`")
+    end
+  end
+end

data/lib/debtective/output_todos.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+require "json"
+require "debtective/todo_list"
+
+module Debtective
+  # Generate todolist
+  class OutputTodos
+    FILE_PATH = "todos.json"
+
+    # @return [void]
+    def call
+      log_table_headers
+      log_table_rows
+      log_counts
+      update_json_file
+    end
+
+    private
+
+    # @return [void]
+    def update_json_file
+      File.open(FILE_PATH, "w") do |file|
+        file.puts(
+          JSON.pretty_generate(
+            todo_list.todos.map(&:to_h)
+          )
+        )
+      end
+      puts FILE_PATH
+      puts separator
+    end
+
+    # @return [void]
+    def create_directory
+      return if File.directory?(DIRECTORY_PATH)
+
+      FileUtils.mkdir_p(DIRECTORY_PATH)
+    end
+
+    # @return [void]
+    def log_table_headers
+      puts separator
+      puts table_row("location", "author", "days", "size")
+      puts separator
+    end
+
+    # @return [void]
+    def log_table_rows
+      with_trace_logs(
+        lambda do |todo|
+          puts(
+            table_row(
+              todo.location,
+              todo.commit.author.name || "?",
+              todo.days || "?",
+              todo.size
+            )
+          )
+        end
+      ) do
+        todo_list.todos
+      end
+      puts separator
+    end
+
+    # @param lambda [Lambda]
+    # @yield
+    def with_trace_logs(lambda)
+      trace =
+        TracePoint.new(:return) do |trace_point|
+          next unless trace_point.defined_class == Debtective::BuildTodo && trace_point.method_id == :call
+
+          todo = trace_point.return_value
+          lambda.call(todo)
+        end
+      trace.enable
+      yield
+      trace.disable
+    end
+
+    # @return [Debtective::Todo]
+    def todo_list
+      @todo_list ||= Debtective::TodoList.new(
+        Debtective.configuration&.paths || ["./**/*"]
+      )
+    end
+
+    # @return [void]
+    def log_counts
+      puts "count: #{todo_list.todos.count}"
+      puts "combined lines count: #{todo_list.combined_count}"
+      puts "extended lines count: #{todo_list.extended_count}"
+      puts separator
+    end
+
+    # @return [String]
+    def separator
+      @separator ||= Array.new(table_row(nil, nil, nil, nil).size) { "-" }.join
+    end
+
+    # @return [String]
+    def table_row(col1, col2, col3, col4)
+      [
+        format("%-80.80s", col1.to_s),
+        format("%-20.20s", col2.to_s),
+        format("%-12.12s", col3.to_s),
+        format("%-12.12s", col4.to_s)
+      ].join(" | ")
+    end
+  end
+end

data/lib/debtective/stderr_helper.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Debtective
+  # Silence the $stderr
+  module StderrHelper
+    # @return void
+    def suppress_stderr
+      original_stderr = $stderr.clone
+      $stderr.reopen(File.new("/dev/null", "w"))
+      yield
+    ensure
+      $stderr.reopen(original_stderr)
+    end
+  end
+end

data/lib/debtective/todo.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+require "debtective/git_commit"
+
+module Debtective
+  # Hold todo information
+  class Todo
+    class << self
+      # @return [Debtective::Todo]
+      def build(pathname, index)
+        BuildTodo.new(pathname, index).call
+      end
+    end
+
+    attr_accessor :pathname, :todo_boundaries, :statement_boundaries
+
+    # @param pathname [Pathname]
+    # @param lines [Array<String>]
+    # @param todo_boundaries [Range]
+    # @param statement_boundaries [Range]
+    def initialize(pathname, lines, todo_boundaries, statement_boundaries)
+      @pathname = pathname
+      @lines = lines
+      @todo_boundaries = todo_boundaries
+      @statement_boundaries = statement_boundaries
+    end
+
+    # location in the codebase
+    # @return [String]
+    def location
+      "#{@pathname}:#{@todo_boundaries.min + 1}"
+    end
+
+    # size of the todo code
+    # @return [Integer]
+    def size
+      @statement_boundaries.size
+    end
+
+    # return commit that introduced the todo
+    # @return [Git::Object::Commit]
+    def commit
+      @commit ||= Debtective::GitCommit.new(@pathname, @lines[@todo_boundaries.min]).call
+    end
+
+    # @return [Integer]
+    def days
+      return if commit.time.nil?
+
+      ((Time.now - commit.time) / (24 * 60 * 60)).round
+    end
+
+    # @return [Hash]
+    def to_h
+      {
+        pathname: pathname,
+        location: location,
+        todo_boundaries: todo_boundaries.minmax,
+        statement_boundaries: statement_boundaries.minmax,
+        size: size,
+        commit: {
+          sha: commit.sha,
+          author: commit.author.to_h,
+          time: commit.time
+        }
+      }
+    end
+  end
+end

data/lib/debtective/todo_list.rb

@@ -1,52 +1,33 @@
 # frozen_string_literal: true
 
-require "debtective/file_todos"
+require "debtective/find_todos"
 
 module Debtective
-  # Find and investigate todo comments
+  # Information about the todos in the codebase
   class TodoList
-    DEFAULT_PATHS = ["./**/*"].freeze
+    Author = Struct.new(:email, :name, :todos)
 
-    REPORTS = %i[
-      combined_count
-      extended_count
-      todos
-    ].freeze
-
-    Result = Struct.new(*REPORTS)
-
-    # @return [TodoList::Result]
-    def call
-      Result.new(*REPORTS.map { __send__(_1) })
-    end
-
-    private
-
-    # @return [Array<String>]
-    def paths
-      Debtective.configuration&.paths || DEFAULT_PATHS
+    # @param paths [Array<String>]
+    def initialize(paths)
+      @paths = paths
     end
 
-    # @return [Array<Pathname>] only pathes to ruby files
-    def ruby_pathnames
-      paths
-        .flat_map { File.extname(_1) == "" ? Dir[_1] : [_1] }
-        .map { Pathname(_1) }
-        .select { _1.file? && _1.extname == ".rb" }
+    # @return [Array<Debtective::Todo>]
+    def todos
+      @todos ||= Debtective::FindTodos.new(@paths).call
     end
 
-    # @return [Array<FileTodos::Result>]
-    def todos
-      @todos ||=
-        ruby_pathnames
-        .flat_map { FileTodos.new(_1).call }
-        .select(&:any?)
+    # @return [Array<TodoList::Author>]
+    def authors
+      todos
+        .map { [_1.commit.author.email, _1.commit.author.name] }
+        .uniq
+        .map { author(_1) }
     end
 
     # @return [Integer]
     def extended_count
-      todos
-        .sum { _1.boundaries.size }
+      todos.sum(&:size)
     end
 
     # @return [Integer]
@@ -54,12 +35,23 @@ module Debtective
       todos
         .group_by(&:pathname)
         .values
-        .sum do |file_todos|
-          file_todos
-            .map { _1.boundaries.to_a }
+        .sum do |pathname_todos|
+          pathname_todos
+            .map { _1.statement_boundaries.to_a }
             .reduce(:|)
             .length
         end
     end
+
+    private
+
+    # @param email_and_name [Array<String>]
+    # @return [TodoList::Author]
+    def author(email_and_name)
+      Author.new(
+        *email_and_name,
+        todos.select { email_and_name == [_1.commit.author.email, _1.commit.author.name] }
+      )
+    end
   end
 end

data/lib/debtective/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Debtective
-  VERSION = "0.2.1"
+  VERSION = "0.2.3"
 end

data/lib/tasks/debtective/todo_list.rake

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "debtective/todo_list"
+require "debtective/output_todos"
 
 begin
   require "#{Rails.root}/config/initializers/debtective" if defined?(Rails)
@@ -11,52 +11,6 @@ end
 namespace :debtective do
   desc "Todo List"
   task :todo_list do
-    todo_list = Debtective::TodoList.new.call
-    todos = todo_list.todos.sort_by { _1.boundaries.size }.reverse
-
-    separator = Array.new(120 + 3 + 12 + 3 + 12) { "-" }.join
-
-    puts separator
-
-    puts "todo list"
-
-    puts separator
-
-    puts(
-      [
-        "pathname".ljust(120),
-        "lines".rjust(12)
-      ].join(" | ")
-    )
-
-    puts separator
-
-    todos.each do |todo|
-      location = "#{todo.pathname}:#{todo.todo_index + 1}".ljust(120)
-      puts(
-        [
-          location,
-          [todo.boundaries.first + 1, todo.boundaries.last + 1].join(":").rjust(12),
-          todo.boundaries.size.to_s.rjust(12)
-        ].join(" | ")
-      )
-    end
-
-    puts separator
-
-    puts "todos count"
-    puts todos.count
-
-    puts separator
-
-    puts "combined lines count"
-    puts todo_list.combined_count
-
-    puts separator
-
-    puts "extended lines count"
-    puts todo_list.extended_count
-
-    puts separator
+    Debtective::OutputTodos.new.call
   end
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: debtective
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Edouard Piron
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-09 00:00:00.000000000 Z
+date: 2023-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: parser
+  name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -115,14 +115,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- MIT-LICENSE
-- README.md
-- Rakefile
+- bin/debtective
 - lib/debtective.rb
+- lib/debtective/build_todo.rb
 - lib/debtective/configuration.rb
-- lib/debtective/end_of_statement.rb
-- lib/debtective/file_todos.rb
+- lib/debtective/find_end_of_statement.rb
+- lib/debtective/find_todos.rb
+- lib/debtective/git_commit.rb
+- lib/debtective/output_todos.rb
 - lib/debtective/railtie.rb
+- lib/debtective/stderr_helper.rb
+- lib/debtective/todo.rb
 - lib/debtective/todo_list.rb
 - lib/debtective/version.rb
 - lib/tasks/debtective/todo_list.rake

data/MIT-LICENSE

@@ -1,20 +0,0 @@
-Copyright 2021 Edouard Piron
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -1,53 +0,0 @@
-# Debtective
-
-Find todos in your codebase so you don't forget to pay off your debts! 💰
-
-## Usage
-
-Run the task with:
-
-```bash
-bundle exec rake debtective:todo_list
-```
-
-It outputs the todos positions with the concerned lines of code and some counts.
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-group :development do
-  gem "debtective"
-end
-```
-
-And then execute:
-
-```bash
-$ bundle
-```
-
-Or install it yourself as:
-
-```bash
-$ gem install debtective
-```
-
-Configure the paths that should be analyzed (all by default):
-
-```ruby
-# config/initializers/debtective.rb
-
-Debtective.configure do |config|
-  config.paths = ["app/**/*", "lib/**/*"]
-end
-```
-
-## Contributing
-
-This gem is still a work in progress. You can use GitHub issue to start a discussion.
-
-## License
-
-The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/Rakefile

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
-require "rubocop/rake_task"
-
-RuboCop::RakeTask.new
-
-task default: %i[spec rubocop]

data/lib/debtective/file_todos.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-require "debtective/end_of_statement"
-
-module Debtective
-  # Find the todos comments and their boundaries
-  class FileTodos
-    Result = Struct.new(:pathname, :todo_index, :boundaries)
-
-    BEFORE_LINE_TODO_REGEX = /^\s*#\sTODO:\s/
-    INLINE_TODO_REGEX = /\s*#\sTODO:\s/
-    COMMENT_REGEX = /\s*#/
-
-    # @param pathname [Pathname]
-    def initialize(pathname)
-      @pathname = pathname
-    end
-
-    # @return [Array<FileTodos::Result>]
-    def call
-      lines.filter_map.with_index do |line, index|
-        boundaries = boundaries(line, index)
-        next if boundaries.nil?
-
-        Result.new(@pathname, index, boundaries)
-      end
-    end
-
-    private
-
-    # return todo boundaries if there is a todo
-    # @param line [String]
-    # @param index [Integer]
-    # @return [Range, nil]
-    def boundaries(line, index)
-      case line
-      when BEFORE_LINE_TODO_REGEX
-        first_line_index = statement_first_line_index(index)
-        last_line_index = EndOfStatement.new(@lines, first_line_index).call
-        first_line_index..last_line_index
-      when INLINE_TODO_REGEX
-        index..index
-      end
-    end
-
-    # @return [Array<String>]
-    def lines
-      @lines ||= @pathname.readlines
-    end
-
-    # @param todo_index [Integer]
-    # @return [Integer]
-    def statement_first_line_index(todo_index)
-      @lines.index.with_index do |line, i|
-        i > todo_index &&
-          !line.strip.empty? &&
-          !line.match?(COMMENT_REGEX)
-      end
-    end
-  end
-end