debitech_soap 1.0.2 → 1.2.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: bd72f376fc8244561d542048c01a2a67f3c6af855b7f5d1f48e79d334935f62c
+  data.tar.gz: 58f219906628833960645ee107abed6384bccc57816a56bb7b5d3521b120fbaa
+SHA512:
+  metadata.gz: bf50187ec7a834e00c8260eabe716cefb8291236f357c7c41104afe837961dd37cfb7f1bdb7befa15aba54200ea6bab45175d243722b18de77c0762d2322f17e
+  data.tar.gz: 0f510554dd1452104ff04df0215a779bb1e9100e3e03a93247368c92b24453af067c7257c47a13844e5eb70044018e1ddbbde3dcdd3d26bc08c31f8c858eb169

data/.github/workflows/ci.yml

@@ -0,0 +1,26 @@
+name: Ruby CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby-version: ["3.0", "2.7", "2.6", "2.5"]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@ae9cb3b565e36682a2c6045e4f664388da4c73aa
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rake

data/.gitignore

@@ -7,3 +7,6 @@ todo.txt
 */**/.*.swp
 */**/*.swp
 */*/*/*.swp
+tmp
+Gemfile.lock
+*.gem

data/.rubocop.yml

@@ -0,0 +1,5 @@
+AllCops:
+  Exclude:
+    - "tmp/**/*"
+inherit_gem:
+  barsoom_utils: shared_rubocop.yml

data/Gemfile

@@ -2,3 +2,12 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in debitech_soap.gemspec
 gemspec
+
+group :development, :test do
+  gem "barsoom_utils", github: "barsoom/barsoom_utils"
+  gem "guard"
+  gem "guard-rspec"
+  gem "rake"
+  gem "rspec"
+  gem "rubocop"
+end

data/Guardfile

@@ -1,4 +1,4 @@
-guard 'rspec', :version => 2, :cli => "--color" do
+guard "rspec", :version => 2, :cli => "--color" do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec" }
 end

data/README.markdown

@@ -1,5 +1,4 @@
-[![Build Status](https://secure.travis-ci.org/joakimk/debitech_soap.png)](http://travis-ci.org/joakimk/debitech_soap)
-[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/joakimk/debitech_soap)
+[![Ruby CI](https://github.com/barsoom/debitech_soap/actions/workflows/ci.yml/badge.svg)](https://github.com/barsoom/debitech_soap/actions/workflows/ci.yml)
 
 This is a wrapper of the DebiTech SOAP API. It's intended to be API compatible with the DebiTech Java client but also supports a more developer friendly syntax :).
 
@@ -7,33 +6,33 @@ If you're looking for a more complete solution, check the [debitech](https://git
 
 Installing
 ----
-
-    gem install debitech_soap
-
+```bash
+gem install debitech_soap
+```
 Usage
 ----
  
 This is how you would have used the DebiTech Java API:
-
-    include_class "com.verifyeasy.server.VEServer"
-    veserver = VEServer.get_instance("https://secure.incab.se/verify/server/merchant_name")
-
+```java
+include_class "com.verifyeasy.server.VEServer"
+veserver = VEServer.get_instance("https://secure.incab.se/verify/server/merchant_name")
+```
 This is how you use DebitechSoap:
-
-    require 'debitech_soap'
-    veserver = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-
+```ruby
+require 'debitech_soap'
+veserver = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+```
 Supported arguments
 ----
 
 Java style (see DebitechSoap::API::PARAMS.keys in lib/debitech_soap.rb):
-
-    veserver.refund(1234567, 23456, 100, "extra")
-
+```java
+veserver.refund(1234567, 23456, 100, "extra")
+```
 Hash:
-
-    veserver.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra")
-
+```ruby
+veserver.refund(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra")
+```
 Custom methods
 ----
 
@@ -56,3 +55,16 @@ API docs
 ----
 
 Get DIBSServerManual.pdf from the DIBS Manager.
+
+Changing HTTPClient SSL ciphers
+----
+
+If you're a library developer, you may want to experiment with changing the set of HTTPClient SSL ciphers, e.g. if DIBS deprecates old ones.
+
+You can do that by setting an environment variable:
+
+    DIBS_HTTPCLIENT_CIPHERS='ALL:!aNULL:!eNULL:!SSLv2'
+
+If nothing is set, it uses the default (`HTTPClient::SSLConfig::CIPHERS_DEFAULT`).
+
+Once the experiments are concluded, you should move that configuration into the library instead, so each user of this library doesn't have to configure it.

data/Rakefile

@@ -1,11 +1,11 @@
-require 'bundler'
-require 'rspec/core/rake_task'
+require "bundler"
+require "rspec/core/rake_task"
 
 Bundler::GemHelper.install_tasks
 
 desc "Run all specs"
-RSpec::Core::RakeTask.new('spec') do |t|
-  t.pattern = 'spec/**/*.rb'
+RSpec::Core::RakeTask.new("spec") do |t|
+  t.pattern = "spec/**/*.rb"
 end
 
 task :default => :spec

data/debitech_soap.gemspec

@@ -6,21 +6,22 @@ Gem::Specification.new do |s|
   s.name        = "debitech_soap"
   s.version     = DebitechSoap::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Joakim Kolsjö", 'Niklas Holmgren', 'Henrik Nyh', 'Daniel Eriksson']
-  s.email       = ["joakim.kolsjo@gmail.com", 'niklas.holmgren@bukowskis.com', 'henrik@barsoom.se']
-  s.homepage    = "http://github.com/joakimk/debitech_soap"
+  s.authors     = [ "Joakim Kolsjö", "Niklas Holmgren", "Henrik Nyh", "Daniel Eriksson" ]
+  s.email       = [ "joakim.kolsjo@gmail.com", "niklas.holmgren@bukowskis.com", "henrik@barsoom.se" ]
+  s.homepage    = "http://github.com/barsoom/debitech_soap"
   s.summary     = %q{A pure ruby way to make payments with DebiTech}
   s.description = %q{An implementation of the DebiTech Java API using pure ruby and the SOAP API.}
+  s.metadata      = { "rubygems_mfa_required" => "true" }
 
-  s.add_dependency "mumboe-soap4r", "~> 1.5.8.4"
+  # Earlier versions of HTTPClient may prefer SSLv3 as its ssl_version,
+  # but 2014-10-15 Debitech started having issues with SSLv3, sometimes returning
+  # "sslv3 alert handshake failure"
+  # Probably because of changes to counter the "Poodle" vulnerability.
+  # See: https://gist.github.com/henrik/321bb53dc7c236a6f4a0
+  s.add_dependency "httpclient", ">= 2.4.0"
 
-  s.add_development_dependency "rake"
-  s.add_development_dependency 'rspec'
-  s.add_development_dependency "guard"
-  s.add_development_dependency "guard-rspec"
+  s.add_dependency "mumboe-soap4r", "~> 1.5.8.4"
 
   s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.require_paths = [ "lib" ]
 end

data/lib/debitech_soap/api.rb

@@ -1,34 +1,28 @@
-require 'stringio'
+require "stringio"
 $previous_stderr = $stderr
 $stderr = StringIO.new
-require 'soap/wsdlDriver'
+require "soap/wsdlDriver"
 $stderr = $previous_stderr
-require 'ostruct'
-require 'debitech_soap/string_extensions'
+require "ostruct"
+require "debitech_soap/string_extensions"
 
 module DebitechSoap
   class API
 
     RETURN_DATA = %w{aCSUrl acquirerAddress acquirerAuthCode acquirerAuthResponseCode acquirerCity acquirerConsumerLimit acquirerErrorDescription acquirerFirstName acquirerLastName acquirerMerchantLimit acquirerZipCode amount errorMsg infoCode infoDescription pAReqMsg resultCode resultText verifyID}
 
-    PARAMS = { %w(settle)                     => ["verifyID", "transID", "amount", "extra"],
-               %w(subscribeAndSettle subscribe_and_settle) \
-                                              => ["verifyID", "transID", "data", "ip", "extra"],
-               %w(authorize)                  => ["billingFirstName", "billingLastName", "billingAddress", "billingCity",
-                                                  "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra"],
-               %w(authorizeAndSettle3DS authorize_and_settle_3ds) \
-                                              => ["verifyID", "paRes", "extra"],
-               %w(refund)                     => ["verifyID", "transID", "amount", "extra"],
-               %w(askIf3DSEnrolled ask_if_3ds_enrolled) \
-                                              => ["billingFirstName", "billingLastName", "billingAddress", "billingCity",
-                                                  "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID",
-                                                  "httpAcceptHeader", "httpUserAgentHeader", "method", "referenceNo", "extra"],
-               %w(authReversal auth_reversal) => ["verifyID", "amount", "transID", "extra"],
-               %w(authorize3DS authorize_3ds) => ["verifyID", "paRes", "extra"],
-               %w(subscribe)                  => ["verifyID", "transID", "data", "ip", "extra"],
-               %w(authorizeAndSettle authorize_and_settle) \
-                                              => ["billingFirstName", "billingLastName", "billingAddress", "billingCity", "billingCountry",
-                                                  "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra"] }
+    PARAMS = {
+      %w(settle)                                         => [ "verifyID", "transID", "amount", "extra" ],
+      %w(subscribeAndSettle subscribe_and_settle)        => [ "verifyID", "transID", "data", "ip", "extra" ],
+      %w(authorize)                                      => [ "billingFirstName", "billingLastName", "billingAddress", "billingCity", "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra" ],
+      %w(authorizeAndSettle3DS authorize_and_settle_3ds) => [ "verifyID", "paRes", "extra" ],
+      %w(refund)                                         => [ "verifyID", "transID", "amount", "extra" ],
+      %w(askIf3DSEnrolled ask_if_3ds_enrolled)           => [ "billingFirstName", "billingLastName", "billingAddress", "billingCity", "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "httpAcceptHeader", "httpUserAgentHeader", "method", "referenceNo", "extra" ],
+      %w(authReversal auth_reversal)                     => [ "verifyID", "amount", "transID", "extra" ],
+      %w(authorize3DS authorize_3ds)                     => [ "verifyID", "paRes", "extra" ],
+      %w(subscribe)                                      => [ "verifyID", "transID", "data", "ip", "extra" ],
+      %w(authorizeAndSettle authorize_and_settle)        => [ "billingFirstName", "billingLastName", "billingAddress", "billingCity", "billingCountry", "cc", "expM", "expY", "eMail", "ip", "data", "currency", "transID", "extra" ],
+    }
 
     def initialize(opts = {})
       @api_credentials = {}
@@ -40,12 +34,37 @@ module DebitechSoap
         @client = SOAP::WSDLDriverFactory.new(File.join(File.dirname(__FILE__), "../service.wsdl")).create_rpc_driver
       end
 
+      # Uncomment this line if you want to see the request and response printed to STDERR.
+      #@client.wiredump_dev = STDERR
+
+      # Enable changing supported ciphers, for deprecation situations like http://tech.dibspayment.com/nodeaddpage/listofapprovedciphersuites.
+      # This lets us easily experiment in development, and to do quick changes in production if we must.
+      dibs_httpclient_ciphers = ENV["DIBS_HTTPCLIENT_CIPHERS"]
+      if dibs_httpclient_ciphers
+        httpclient_instance = @client.streamhandler.client
+        httpclient_instance.ssl_config.ciphers = dibs_httpclient_ciphers
+      end
+
       define_java_wrapper_methods!
     end
 
     def valid_credentials?
       disable_stderr do
-        return_value(@client.checkSwedishPersNo(@api_credentials.merge({ :persNo => "5555555555" }))) == "true"
+        # We make a "refund" request, but we make sure to set the amount to 0 and to enter a verify ID that will never match a real one.
+        # Previously, we'd confirm credentials with the safer checkSwedishPersNo call, but that seems broken now (always returns false).
+        response_value = return_value(@client.refund(@api_credentials.merge({ verifyID: -1, amount: 0 })))
+        result_text = response_value.resultText
+
+        case result_text
+        when "error_transID_or_verifyID"
+          # The auth succeeded, but the refund (thankfully and intentionally) did not.
+          true
+        when "336 web_service_login_failed"
+          # The auth is wrong.
+          false
+        else
+          raise "Unexpected result text: #{result_text.inspect}"
+        end
       end
     end
 
@@ -64,18 +83,18 @@ module DebitechSoap
           define_method(method) do |*args|                                # def refund(*args)
             attributes = @api_credentials.clone
 
-            if args.first.is_a?(Hash) 
+            if args.first.is_a?(Hash)
               attributes.merge!(args.first)
             else
               parameter_order = api_signature(method).last
               args.each_with_index { |argument, i|
                 attributes[parameter_order[i].to_sym] = argument
               }
-            end            
+            end
             begin
               client_result = return_value(@client.send(api_signature(method).first.first, attributes))
             rescue Timeout::Error
-              client_result = OpenStruct.new(:resultCode => 403, :resultText => "SOAP Timeout")
+              client_result = OpenStruct.new(resultCode: 403, resultText: "SOAP Timeout")
               return return_data(client_result)
             end
             return_data(client_result)
@@ -105,16 +124,14 @@ module DebitechSoap
     end
 
     def disable_stderr
-      begin
-        $stderr = File.open('/dev/null', 'w')
-        yield
-      ensure
-        $stderr = STDERR
-      end
+      $stderr = File.open("/dev/null", "w")
+      yield
+    ensure
+      $stderr = STDERR
     end
 
     def api_signature(method)
-      PARAMS.find {|key,value| key.include?(method.to_s) }
+      PARAMS.find { |key, value| key.include?(method.to_s) }
     end
 
   end

data/lib/debitech_soap/string_extensions.rb

@@ -4,9 +4,9 @@ module DebitechSoap
     module Underscore
       def underscore
         word = dup
-        word.gsub!(/::/, '/')
-        word.gsub!(/([A-Z]+)([A-Z][a-z])/,'\1_\2')
-        word.gsub!(/([a-z\d])([A-Z])/,'\1_\2')
+        word.gsub!(/::/, "/")
+        word.gsub!(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+        word.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
         word.tr!("-", "_")
         word.downcase!
         word
@@ -26,13 +26,13 @@ module DebitechSoap
   end
 end
 
-unless String.methods.include?('underscore')
+unless String.methods.include?("underscore")
   String.class_eval do
     include DebitechSoap::StringExtensions::Underscore
   end
 end
 
-unless String.methods.include?('camelcase')
+unless String.methods.include?("camelcase")
   String.class_eval do
     include DebitechSoap::StringExtensions::CamelCase
   end

data/lib/debitech_soap/version.rb

@@ -1,3 +1,3 @@
 module DebitechSoap
-  VERSION = "1.0.2"
+  VERSION = "1.2.1"
 end

data/lib/debitech_soap.rb

@@ -1,4 +1,4 @@
 module DebitechSoap
   # It takes a little while to load, so don't load it when rails loads.
-  autoload :API, File.expand_path(File.join(File.dirname(__FILE__), 'debitech_soap/api'))
+  autoload :API, File.expand_path(File.join(File.dirname(__FILE__), "debitech_soap/api"))
 end

data/spec/debitech_soap_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.join(File.dirname(__FILE__), '../lib/debitech_soap'))
+require File.expand_path(File.join(File.dirname(__FILE__), "../lib/debitech_soap"))
 
 class MockSoapResult
   class MockReturn
@@ -20,7 +20,7 @@ class MockSoapResultRuby19
   end
 end
 
-describe DebitechSoap::API do
+RSpec.describe DebitechSoap::API do
   # When it can't find the wsdl file it throws an error. We need to ensure
   # it can find the file (fixed regression bug).
   it "can be initialized" do
@@ -28,68 +28,84 @@ describe DebitechSoap::API do
   end
 end
 
-describe DebitechSoap::API, "valid_credentials?" do
+RSpec.describe DebitechSoap::API, "valid_credentials?" do
 
   before do
-    @client = mock(Object)
-    SOAP::WSDLDriverFactory.stub!(:new).and_return(mock(Object, :create_rpc_driver => @client))
+    @client = double("client")
+    allow(SOAP::WSDLDriverFactory).to receive(:new).and_return(double("a-factory", create_rpc_driver: @client))
   end
 
-  it "should call checkSwedishPersNo with the credentials and a valid swedish social security number" do
-    @client.should_receive(:checkSwedishPersNo).with(:shopName => "merchant_name", :userName => "api_user_name",
-                                                     :password => "api_user_password", :persNo => "5555555555").
-                                                     and_return(mock(Object, :return => "true"))
+  it "should call 'refund' with the credentials and dummy values, returning true if we were authed but failed to refund" do
+    expect(@client).to receive(:refund)
+      .with(shopName: "merchant_name", userName: "api_user_name", password: "api_user_password", verifyID: -1, amount: 0)
+      .and_return(double("refund", return: double("return", resultText: "error_transID_or_verifyID")))
 
-    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-    api.valid_credentials?.should == true
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+
+    expect(api.valid_credentials?).to eq true
   end
 
-  it "should return false if the service returns false" do
-    @client.stub!(:checkSwedishPersNo).and_return(mock(Object, :return => "false"))
-    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-    api.valid_credentials?.should == false
+  it "should return false if the service returns an auth error" do
+    expect(@client).to receive(:refund).and_return(double("refund", return: double("return", resultText: "336 web_service_login_failed")))
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+
+    expect(api.valid_credentials?).to eq false
+  end
+
+  it "raises if the service returns an unexpected result" do
+    expect(@client).to receive(:refund).and_return(double("refund", return: double("return", resultText: "let's have lunch")))
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+
+    expect { api.valid_credentials? }.to raise_error(%{Unexpected result text: "let's have lunch"})
   end
 
   it "should work with Ruby 1.9 SOAP API" do
-    @client.stub!(:checkSwedishPersNo).and_return(mock(Object, :m_return => "true"))
+    expect(@client).to receive(:refund).and_return(double("refund", m_return: double("m_return", resultText: "error_transID_or_verifyID")))
     api = DebitechSoap::API.new
-    api.valid_credentials?.should == true
+
+    expect(api.valid_credentials?).to eq true
   end
 
 end
 
-describe DebitechSoap::API, "calling a method with java-style arguments" do
+RSpec.describe DebitechSoap::API, "calling a method with java-style arguments" do
 
   before do
-    @client = mock(Object)
-    SOAP::WSDLDriverFactory.stub!(:new).and_return(mock(Object, :create_rpc_driver => @client))
+    @client = double("client")
+
+    expect(SOAP::WSDLDriverFactory).to receive(:new).and_return(double("a-factory", create_rpc_driver: @client))
   end
-  
+
   it "should map the arguments to a hash and call the corresponding SOAP method" do
-    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-    @client.should_receive("refund").with(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra",
-                                          :shopName => "merchant_name", :userName => "api_user_name", :password => "api_user_password").
-                                          and_return(MockSoapResult.new)
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+
+    expect(@client).to receive("refund")
+      .with(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra", shopName: "merchant_name", userName: "api_user_name", password: "api_user_password")
+      .and_return(MockSoapResult.new)
+
     api.refund(1234567, 23456, 100, "extra")
   end
 
   it "should camel case method names" do
-    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-    @client.should_receive("authorize3DS").with(:verifyID => 1234567, :paRes => "RES", :extra => "extra",
-                                          :shopName => "merchant_name", :userName => "api_user_name", :password => "api_user_password").
-                                          and_return(MockSoapResult.new)
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+
+    expect(@client).to receive("authorize3DS")
+      .with(verifyID: 1234567, paRes: "RES", extra: "extra", shopName: "merchant_name", userName: "api_user_name", password: "api_user_password")
+      .and_return(MockSoapResult.new)
+
     api.authorize_3ds(1234567, "RES", "extra")
   end
 
   it "should not keep old attributes when making subsequent api calls" do
-    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-    @client.should_receive("refund").with(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra",
-                                          :shopName => "merchant_name", :userName => "api_user_name", :password => "api_user_password").
-                                          and_return(MockSoapResult.new)
-    @client.should_receive("authorize3DS").with(:verifyID => 1234567, :paRes => "RES", :extra => "extra",
-                                          :shopName => "merchant_name", :userName => "api_user_name", :password => "api_user_password").
-                                          and_return(MockSoapResult.new)
-                                          
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+
+    expect(@client).to receive("refund")
+      .with(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra", shopName: "merchant_name", userName: "api_user_name", password: "api_user_password")
+      .and_return(MockSoapResult.new)
+    expect(@client).to receive("authorize3DS")
+      .with(verifyID: 1234567, paRes: "RES", extra: "extra", shopName: "merchant_name", userName: "api_user_name", password: "api_user_password")
+      .and_return(MockSoapResult.new)
+
     api.refund(1234567, 23456, 100, "extra")
     api.authorize3DS(1234567, "RES", "extra")
   end
@@ -97,107 +113,136 @@ describe DebitechSoap::API, "calling a method with java-style arguments" do
   it "should create a return object" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResult.new
-    mock_soap_result.return.stub!(:resultText).and_return("success")
-    @client.stub!("refund").and_return(mock_soap_result)
-    api.refund(1234567, 23456, 100, "extra").resultText.should == "success"
+    expect(mock_soap_result.return).to receive(:resultText).and_return("success")
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
+
+    expect(api.refund(1234567, 23456, 100, "extra").resultText).to eq "success"
   end
 
   it "should return nil when there is no data" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResult.new
-    @client.stub!("refund").and_return(mock_soap_result)
-    api.refund(1234567, 23456, 100, "extra").resultCode.should be_nil
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
+
+    expect(api.refund(1234567, 23456, 100, "extra").resultCode).to be_nil
   end
 
   it "should be able to access the data using getCamelCase, get_underscore and underscore methods" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResult.new
-    mock_soap_result.return.stub!(:resultText).and_return("success")
-    @client.stub!("refund").and_return(mock_soap_result)
+    expect(mock_soap_result.return).to receive(:resultText).and_return("success")
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
+
     result = api.refund(1234567, 23456, 100, "extra")
-    result.getResultText.should == "success"
-    result.get_result_text.should == "success"
-    result.result_text.should == 'success'
+
+    expect(result.getResultText).to eq "success"
+    expect(result.get_result_text).to eq "success"
+    expect(result.result_text).to eq "success"
   end
 
   it "should convert the result to an integer when its a number" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResult.new
-    mock_soap_result.return.stub!(:resultCode).and_return("100")
-    @client.stub!("refund").and_return(mock_soap_result)
+    expect(mock_soap_result.return).to receive(:resultCode).and_return("100")
+
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
+
     result = api.refund(1234567, 23456, 100, "extra")
-    result.resultCode.should == 100
-    result.getResultCode.should == 100
-    result.get_result_code.should == 100
+    expect(result.resultCode).to eq 100
+    expect(result.getResultCode).to eq 100
+    expect(result.get_result_code).to eq 100
   end
 
   it "should convert the result to an integer when its zero" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResult.new
-    mock_soap_result.return.stub!(:resultCode).and_return("0")
-    @client.stub!("refund").and_return(mock_soap_result)
+    expect(mock_soap_result.return).to receive(:resultCode).and_return("0")
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
+
     result = api.refund(1234567, 23456, 100, "extra")
-    result.resultCode.should == 0
+
+    expect(result.resultCode).to eq 0
   end
 
   it "should work with Ruby 1.9 SOAP API" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResultRuby19.new
-    mock_soap_result.m_return.stub!(:resultCode).and_return("0")
-    @client.stub!("refund").and_return(mock_soap_result)
+    expect(mock_soap_result.m_return).to receive(:resultCode).and_return("0")
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
+
     result = api.refund(1234567, 23456, 100, "extra")
-    result.resultCode.should == 0
-  end
 
+    expect(result.resultCode).to eq 0
+  end
 end
 
-describe DebitechSoap::API, "calling a method with hash-style arguments" do
+RSpec.describe DebitechSoap::API, "calling a method with hash-style arguments" do
 
   before do
-    @client = mock(Object)
-    SOAP::WSDLDriverFactory.stub!(:new).and_return(mock(Object, :create_rpc_driver => @client))
+    @client = double("client")
+    expect(SOAP::WSDLDriverFactory).to receive(:new).and_return(double("factory", create_rpc_driver: @client))
   end
 
   it "should call the corresponding soap method" do
-    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
-    @client.should_receive("refund").with(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra",
-                                          :shopName => "merchant_name", :userName => "api_user_name", :password => "api_user_password").
-                                          and_return(MockSoapResult.new)
-    api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra")
+    api = DebitechSoap::API.new(merchant: "merchant_name", username: "api_user_name", password: "api_user_password")
+    expect(@client).to receive("refund")
+      .with(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra", shopName: "merchant_name", userName: "api_user_name", password: "api_user_password")
+      .and_return(MockSoapResult.new)
+    api.refund(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra")
   end
 
   it "should return data" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResult.new
-    mock_soap_result.return.stub!(:resultText).and_return("success")
-    @client.stub!("refund").and_return(mock_soap_result)
-    api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra").getResultText.should == "success"
+    expect(mock_soap_result.return).to receive(:resultText).and_return("success")
+    expect(@client).to receive("refund").and_return(mock_soap_result)
+
+    expect(api.refund(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra").getResultText).to eq "success"
   end
 
   it "should work with Ruby 1.9 SOAP API" do
     api = DebitechSoap::API.new
     mock_soap_result = MockSoapResultRuby19.new
-    mock_soap_result.m_return.stub!(:resultText).and_return("success")
-    @client.stub!("refund").and_return(mock_soap_result)
-    result = api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra")
-    result.getResultText.should == "success"
-  end
+    expect(mock_soap_result.m_return).to receive(:resultText).and_return("success")
+    expect(@client).to receive(:refund).and_return(mock_soap_result)
 
+    result = api.refund(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra")
+
+    expect(result.getResultText).to eq "success"
+  end
 end
 
-describe DebitechSoap::API, "handling exceptions" do
+RSpec.describe DebitechSoap::API, "handling exceptions" do
 
   before do
-    @client = mock(Object)
-    SOAP::WSDLDriverFactory.stub!(:new).and_return(mock(Object, :create_rpc_driver => @client))
+    @client = double
+    expect(SOAP::WSDLDriverFactory).to receive(:new).and_return(double("factory", create_rpc_driver: @client))
   end
 
   it "should catch Timeout::Error and return 403" do
     api = DebitechSoap::API.new
-    @client.stub!("refund").and_raise(Timeout::Error)
-    result = api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra")
-    result.getResultCode.should == 403
-    result.getResultText.should == "SOAP Timeout"
+    expect(@client).to receive(:refund).and_raise(Timeout::Error)
+    result = api.refund(verifyID: 1234567, transID: 23456, amount: 100, extra: "extra")
+
+    expect(result.getResultCode).to eq 403
+    expect(result.getResultText).to eq "SOAP Timeout"
+  end
+end
+
+RSpec.describe DebitechSoap::API, "overriding ciphers with ENV" do
+  around do |example|
+    old_env = ENV["DIBS_HTTPCLIENT_CIPHERS"]
+    ENV["DIBS_HTTPCLIENT_CIPHERS"] = "FOO"
+    example.run
+    ENV["DIBS_HTTPCLIENT_CIPHERS"] = old_env
+  end
+
+  it "changes the configured HTTPClient ciphers" do
+    api = DebitechSoap::API.new
+
+    httpclient = api.instance_variable_get("@client").streamhandler.client
+
+    expect(httpclient).to be_instance_of HTTPClient
+    expect(httpclient.ssl_config.ciphers).to eq "FOO"
   end
-  
 end

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+  config.expect_with(:rspec) { |c| c.syntax = :expect }
+end

metadata

@@ -1,116 +1,62 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: debitech_soap
-version: !ruby/object:Gem::Version 
-  hash: 19
-  prerelease: 
-  segments: 
-  - 1
-  - 0
-  - 2
-  version: 1.0.2
+version: !ruby/object:Gem::Version
+  version: 1.2.1
 platform: ruby
-authors: 
-- "Joakim Kolsj\xC3\xB6"
+authors:
+- Joakim Kolsjö
 - Niklas Holmgren
 - Henrik Nyh
 - Daniel Eriksson
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-05-21 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: mumboe-soap4r
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 95
-        segments: 
-        - 1
-        - 5
-        - 8
-        - 4
-        version: 1.5.8.4
-  type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rake
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rspec
-  prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+date: 2021-11-19 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: httpclient
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: guard
+      - !ruby/object:Gem::Version
+        version: 2.4.0
+  type: :runtime
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: guard-rspec
+      - !ruby/object:Gem::Version
+        version: 2.4.0
+- !ruby/object:Gem::Dependency
+  name: mumboe-soap4r
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.8.4
+  type: :runtime
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  type: :development
-  version_requirements: *id005
-description: An implementation of the DebiTech Java API using pure ruby and the SOAP API.
-email: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.8.4
+description: An implementation of the DebiTech Java API using pure ruby and the SOAP
+  API.
+email:
 - joakim.kolsjo@gmail.com
 - niklas.holmgren@bukowskis.com
 - henrik@barsoom.se
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- .gitignore
-- .rvmrc
-- .travis.yml
+files:
+- ".github/workflows/ci.yml"
+- ".gitignore"
+- ".rubocop.yml"
+- ".rvmrc"
 - CHANGELOG
 - Gemfile
-- Gemfile.lock
 - Guardfile
 - LICENCE
 - README.markdown
@@ -122,38 +68,28 @@ files:
 - lib/debitech_soap/version.rb
 - lib/service.wsdl
 - spec/debitech_soap_spec.rb
-homepage: http://github.com/joakimk/debitech_soap
+- spec/spec_helper.rb
+homepage: http://github.com/barsoom/debitech_soap
 licenses: []
-
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
-rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 3.2.28
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A pure ruby way to make payments with DebiTech
-test_files: 
-- spec/debitech_soap_spec.rb
+test_files: []

data/.travis.yml

@@ -1,3 +0,0 @@
-rvm:
-  - ree
-

data/Gemfile.lock

@@ -1,37 +0,0 @@
-PATH
-  remote: .
-  specs:
-    debitech_soap (1.0.1)
-      mumboe-soap4r (~> 1.5.8.4)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    diff-lcs (1.1.3)
-    guard (0.8.8)
-      thor (~> 0.14.6)
-    guard-rspec (0.5.0)
-      guard (>= 0.8.4)
-    httpclient (2.3.3)
-    mumboe-soap4r (1.5.8.6)
-      httpclient (>= 2.1.1)
-    rake (0.9.2)
-    rspec (2.7.0)
-      rspec-core (~> 2.7.0)
-      rspec-expectations (~> 2.7.0)
-      rspec-mocks (~> 2.7.0)
-    rspec-core (2.7.1)
-    rspec-expectations (2.7.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.7.0)
-    thor (0.14.6)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  debitech_soap!
-  guard
-  guard-rspec
-  rake
-  rspec