debitech 1.0.1 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 82279dd06b05d239c43e6ff2190190fa8ffd654b
+  data.tar.gz: 9dd2575228951cce994151aab74f883af3a64f62
+SHA512:
+  metadata.gz: e9343f83273a827349186aa6b63187eaf54674c5be823c19ad9968bc891979a1d50b0945a14de5fb1749962a71a4547bbf728696f64bb7efd93f5ccf3d6b9ccc
+  data.tar.gz: e2a9dd971b861a830d0322f88734e304b07e2a6ec2518b71c1280987ce400e02edd0651cb1e29dcaa417c9108f69e78f48ca8cc063df3f9295e6a41d684ff926

data/lib/debitech/mac.rb

@@ -1,4 +1,4 @@
-require 'digest/sha1'
+require "digest/sha1"
 
 module Debitech
   class Mac

data/lib/debitech/server_api.rb

@@ -1,5 +1,5 @@
-require 'debitech_soap'
-require 'debitech/mac'
+require "debitech_soap"
+require "debitech/mac"
 
 module Debitech
   class ServerApi

data/lib/debitech/version.rb

@@ -1,4 +1,4 @@
 module Debitech
   # try to follow http://semver.org/
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

data/lib/debitech/web_api.rb

@@ -1,5 +1,5 @@
-require 'digest/sha1'
-require 'debitech/mac'
+require "digest/sha1"
+require "debitech/mac"
 
 module Debitech
   class WebApi
@@ -15,7 +15,7 @@ module Debitech
     end
 
     def form_action
-      "https://secure.incab.se/verify/bin/#{@opts[:merchant]}/index"
+      "https://securedt.dibspayment.com/verify/bin/#{@opts[:merchant]}/index"
     end
 
     def valid_response?(mac, sum, reply, verify_id)

data/spec/debitech/server_api_spec.rb

@@ -1,4 +1,4 @@
-require 'debitech'
+require "debitech"
 
 describe Debitech::ServerApi, "charge" do
   let(:unique_reference) {
@@ -16,34 +16,42 @@ describe Debitech::ServerApi, "charge" do
       :soap_opts => {
         :merchant => "store",
         :username => "api_user",
-        :password => "api_password"
+        :password => "api_password",
       }
     }
 
-    DebitechSoap::API.should_receive(:new).with({ :merchant => "store", :username => "api_user", :password => "api_password" }).
-                                           and_return(soap_api = mock)
-    soap_api.should_receive(:subscribe_and_settle).with(:verifyID => 1234567,
-                            :data => "001:payment:1:10000:",
-                            :ip => "127.0.0.1",
-                            :extra => "&method=cc.cekab&currency=SEK&MAC=1931EE498A77F6B12B2C2D2EC8599719EF9CE419&referenceNo=some_unique_ref")
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).
+      with({ :merchant => "store", :username => "api_user", :password => "api_password" }).
+      and_return(soap_api)
+    expect(soap_api).to receive(:subscribe_and_settle).with(
+      :verifyID => 1234567,
+      :data => "001:payment:1:10000:",
+      :ip => "127.0.0.1",
+      :extra => "&method=cc.cekab&currency=SEK&MAC=1931EE498A77F6B12B2C2D2EC8599719EF9CE419&referenceNo=some_unique_ref",
+    )
 
     server_api = Debitech::ServerApi.new(settings)
     server_api.charge(transaction.merge(:amount => 10000))
   end
 
   it "should convert the amount to a integer to avoid 500 errors" do
-    DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
-    soap_api.should_receive(:subscribe_and_settle).with(:verifyID => 1234567,
-                            :data => "001:payment:1:2235:",
-                            :ip => "127.0.0.1",
-                            :extra => "&method=&currency=SEK&MAC=78B1144270B1A74A55539FAEB81BB49EC39B90DF&referenceNo=some_unique_ref")
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
+    expect(soap_api).to receive(:subscribe_and_settle).with(
+      :verifyID => 1234567,
+      :data => "001:payment:1:2235:",
+      :ip => "127.0.0.1",
+      :extra => "&method=&currency=SEK&MAC=78B1144270B1A74A55539FAEB81BB49EC39B90DF&referenceNo=some_unique_ref",
+    )
 
     server_api = Debitech::ServerApi.new({})
     server_api.charge(transaction.merge(:amount => 2235.0))
   end
 
   it "should raise an error if the amount has a fraction" do
-    DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
     server_api = Debitech::ServerApi.new({})
     expect {
       server_api.charge(transaction.merge(:amount => 2235.55))
@@ -51,7 +59,8 @@ describe Debitech::ServerApi, "charge" do
   end
 
   it "should raise an error if the unique_reference is nil" do
-    DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
     server_api = Debitech::ServerApi.new({})
     expect {
       server_api.charge(transaction.merge(:unique_reference => nil))
@@ -59,7 +68,8 @@ describe Debitech::ServerApi, "charge" do
   end
 
   it "should raise an error if the unique_reference is less than 4 characters" do
-    DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
     server_api = Debitech::ServerApi.new({})
     expect {
       server_api.charge(transaction.merge(:unique_reference => "1234"))
@@ -67,16 +77,19 @@ describe Debitech::ServerApi, "charge" do
   end
 
   it "should be valid with a 5 character unique_reference" do
-    DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
-    soap_api.stub!(:subscribe_and_settle)
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
+    allow(soap_api).to receive(:subscribe_and_settle)
     server_api = Debitech::ServerApi.new({})
     server_api.charge(transaction.merge(:unique_reference => "12345"))
   end
 
   [ 100, 101, 150, 199 ].each do |result_code|
     it "should return success for result_code #{result_code}" do
-      DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
-      soap_api.stub!(:subscribe_and_settle).and_return(response = mock(:result_code => result_code))
+      soap_api = double
+      allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
+      response = double(:result_code => result_code)
+      allow(soap_api).to receive(:subscribe_and_settle).and_return(response)
 
       server_api = Debitech::ServerApi.new({})
       result = server_api.charge(unique_reference)
@@ -89,8 +102,10 @@ describe Debitech::ServerApi, "charge" do
 
   [ 200, 250, 300, 400 ].each do |result_code|
     it "should not be successful for result_code #{result_code}" do
-      DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
-      soap_api.stub!(:subscribe_and_settle).and_return(response = mock(:result_code => result_code))
+      soap_api = double
+      allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
+      response = double(:result_code => result_code)
+      allow(soap_api).to receive(:subscribe_and_settle).and_return(response)
 
       server_api = Debitech::ServerApi.new({})
       result = server_api.charge(unique_reference)
@@ -102,8 +117,10 @@ describe Debitech::ServerApi, "charge" do
   end
 
   it "should return pending and not be successful for 403" do
-    DebitechSoap::API.stub!(:new).and_return(soap_api = mock)
-    soap_api.stub!(:subscribe_and_settle).and_return(response = mock(:result_code => 403))
+    soap_api = double
+    allow(DebitechSoap::API).to receive(:new).and_return(soap_api)
+    response = double(:result_code => 403)
+    allow(soap_api).to receive(:subscribe_and_settle).and_return(response)
     server_api = Debitech::ServerApi.new({})
     result = server_api.charge(unique_reference)
 

data/spec/debitech/web_api_spec.rb

@@ -1,5 +1,5 @@
-require 'ostruct'
-require 'debitech'
+require "ostruct"
+require "debitech"
 
 describe Debitech::WebApi do
   let(:secret_key) {
@@ -26,7 +26,8 @@ describe Debitech::WebApi do
 
   describe "form_action" do
     it "return the url based on shop" do
-      expect(Debitech::WebApi.new({ :merchant => "shop" }).form_action).to include "https://secure.incab.se/verify/bin/shop/index"
+      api = Debitech::WebApi.new({ :merchant => "myshop" })
+      expect(api.form_action).to include "https://securedt.dibspayment.com/verify/bin/myshop/index"
     end
   end
 
@@ -34,14 +35,14 @@ describe Debitech::WebApi do
     context "given reply is 'A' for approved" do
       it "is true" do
         api = Debitech::WebApi.new
-        expect(api.approved_reply?("A")).to be_true
+        expect(api.approved_reply?("A")).to be true
       end
     end
 
     context "given reply is 'D' for denied" do
       it "is false" do
         api = Debitech::WebApi.new
-        expect(api.approved_reply?("D")).to be_false
+        expect(api.approved_reply?("D")).to be false
       end
     end
   end
@@ -49,22 +50,22 @@ describe Debitech::WebApi do
   describe "valid_response?" do
     it "validate that the response hashes down to the mac value" do
       api = Debitech::WebApi.new(secret_key)
-      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", "1234567")).to be_true
+      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", "1234567")).to be true
     end
 
     it "is not true if any of the values are wrong" do
       api = Debitech::WebApi.new(secret_key)
-      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", "1234568")).to be_false
+      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", "1234568")).to be false
     end
 
     it "is not true if the secretkey is different" do
       api = Debitech::WebApi.new({ :secret_key => "secretkey2" })
-      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", "1234567")).to be_false
+      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", "1234567")).to be false
     end
 
     it "handle if verify_id is an int" do
       api = Debitech::WebApi.new(secret_key)
-      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", 1234567)).to be_true
+      expect(api.valid_response?("MAC=667026AD7692F9AFDA362919EA72D8E6A250A849", "1,00", "A", 1234567)).to be true
     end
   end
 end

metadata

@@ -1,49 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: debitech
 version: !ruby/object:Gem::Version
-  version: 1.0.1
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Joakim Kolsjö
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-21 00:00:00.000000000 Z
+date: 2016-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: debitech_soap
-  requirement: &70154789689380 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70154789689380
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70154789688920 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70154789688920
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70154789688500 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70154789688500
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Library for doing payments using DebiTech (DIBS)
 email:
 - joakim@barsoom.se
@@ -51,9 +59,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rvmrc
-- .travis.yml
+- ".gitignore"
+- ".rvmrc"
+- ".travis.yml"
 - Gemfile
 - README.md
 - Rakefile
@@ -67,29 +75,25 @@ files:
 - spec/debitech/web_api_spec.rb
 homepage: https://github.com/barsoom/debitech
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.8.7
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1595935195943276561
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.5
+rubygems_version: 2.4.8
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Library for doing payments using DebiTech (DIBS)
 test_files: []