dead_bro 0.2.25 → 0.2.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aec6a4f779a49726e225b3d01e9e1a6516c56639a451837615a8d8c08cb59e8a
-  data.tar.gz: 186f7fd09ef2b4c3d2ed9390c1278a9f5bbc577a0e05572e63cea7461689fccc
+  metadata.gz: 0f527f74687fb94ef798bfbd31870d8dcf765c1b6c75584302cf273b56c68cab
+  data.tar.gz: 4e4afa23e175daeb1f1227921ddc7475f50b3bd45d2551f92ec9f4e373efe7a8
 SHA512:
-  metadata.gz: 2b7028050d353c623587cd3f083b2b8666fcd05abfa68b7cf05d7bdda5979f29118bdabcbb37c0165a10eca829e30305ff061874c08d9a45e65d89193acd3ad3
-  data.tar.gz: 2f16e4716988194147e087396dc419c4d20fdb4bd2a958d38f866e158d76e2f233d0187a08eb54c6b7f40a9eb9637dc0079e857257cb9d3f2091a05b9490968b
+  metadata.gz: 1fd2320017c4f5975a8c0dbf04066b7c9a1ec057099bcd4b10e816b69cc389faa0f0d0ae7b0e4a5b0450b17a97b910886335f76d874d0e5e6eb92449e11eae0b
+  data.tar.gz: ddaba39dc62527ea96b03170579879849f2dd214d2247c7de5dae53a59ff2ab94b6de84a968e5d884213f67fd3e8de24964cad453c728e20f409c7555d214b09

data/lib/dead_bro/configuration.rb

@@ -19,6 +19,10 @@ module DeadBro
     # and cache the regex form once, instead of rebuilding it per request.
     attr_reader :excluded_controllers, :excluded_jobs, :exclusive_controllers, :exclusive_jobs
 
+    # Per-request-type sample rate overrides, keyed by exact "Controller#action"
+    # (or "JobClass#perform") strings — same identity ApmRequestType uses server-side.
+    attr_reader :sample_rates_by_type
+
     # Tracks when we last received settings from the backend (in-memory only)
     attr_accessor :settings_received_at
 
@@ -59,6 +63,7 @@ module DeadBro
       explain_analyze_enabled slow_query_threshold_ms max_sql_queries_to_send max_logs_to_send
       excluded_controllers excluded_jobs exclusive_controllers exclusive_jobs
       monitor_enabled enable_db_stats enable_process_stats enable_system_stats
+      sample_rates_by_type
     ].freeze
 
     def initialize
@@ -91,6 +96,7 @@ module DeadBro
       self.excluded_jobs = []
       self.exclusive_controllers = []
       self.exclusive_jobs = []
+      self.sample_rates_by_type = {}
       @monitor_enabled = false
       @enable_db_stats = false
       @enable_process_stats = false
@@ -134,6 +140,15 @@ module DeadBro
       @compiled_exclusive_jobs = compile_patterns(@exclusive_jobs)
     end
 
+    # Exact-match only — no wildcard/regex support, unlike the exclusion lists.
+    def sample_rates_by_type=(value)
+      return @sample_rates_by_type = {} unless value.is_a?(Hash)
+
+      @sample_rates_by_type = value.each_with_object({}) do |(k, v), memo|
+        memo[k.to_s] = v.to_i
+      end
+    end
+
     # Apply a settings hash received from the backend response.
     # Only known keys are applied; unknown keys are silently ignored.
     # Serialized so concurrent HTTP threads do not interleave writes with request-thread reads.
@@ -153,6 +168,8 @@ module DeadBro
             send(:"#{k}=", !!value)
           when "excluded_controllers", "excluded_jobs", "exclusive_controllers", "exclusive_jobs"
             send(:"#{k}=", Array(value).map(&:to_s))
+          when "sample_rates_by_type"
+            send(:"#{k}=", value)
           end
         end
       end
@@ -232,8 +249,12 @@ module DeadBro
       compiled.any? { |entry| match_compiled?(target, entry) }
     end
 
-    def should_sample?
-      sample_rate = resolve_sample_rate
+    def should_sample?(request_type_key = nil)
+      sample_rate = if request_type_key && @sample_rates_by_type.key?(request_type_key.to_s)
+        @sample_rates_by_type[request_type_key.to_s]
+      else
+        resolve_sample_rate
+      end
       sample_rate = 100 if sample_rate.nil?
 
       return true if sample_rate >= 100

data/lib/dead_bro/job_subscriber.rb

@@ -44,7 +44,8 @@ module DeadBro
         # enough that even the "cheap" stop/analyze work matters under load.
         # Completions have no exception attached; the exception subscriber below
         # always sends errors with force: true.
-        unless DeadBro.configuration.should_sample?
+        job_type_key = "#{job_class_name}#perform"
+        unless DeadBro.configuration.should_sample?(job_type_key)
           drain_job_tracking
           next
         end
@@ -124,7 +125,9 @@ module DeadBro
           logs: DeadBro.logger.logs
         }
 
-        client.post_metric(event_name: name, payload: payload)
+        # force: true — the sampling decision above already accounted for any
+        # per-job-type override; client#post_metric must not re-roll it globally.
+        client.post_metric(event_name: name, payload: payload, force: true)
       end
 
       # Track job exceptions

data/lib/dead_bro/subscriber.rb

@@ -43,8 +43,9 @@ module DeadBro
         end
 
         has_error = data[:exception] || data[:exception_object]
+        request_type_key = "#{controller_name}##{action_name}"
         # Errors always ship regardless of sampling (this is what the docs promise).
-        unless has_error || DeadBro.configuration.should_sample?
+        unless has_error || DeadBro.configuration.should_sample?(request_type_key)
           drain_request_tracking
           next
         end
@@ -223,7 +224,10 @@ module DeadBro
           cpu_time_ms: cpu_time_ms,
           logs: DeadBro.logger.logs
         }
-        client.post_metric(event_name: name, payload: payload)
+        # force: true — the sampling decision (global or per-request-type) was
+        # already made above; client#post_metric must not re-roll it with the
+        # global-only rate, which would silently override a per-type sample rate.
+        client.post_metric(event_name: name, payload: payload, force: true)
       end
     end
 

data/lib/dead_bro/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeadBro
-  VERSION = "0.2.25"
+  VERSION = "0.2.26"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dead_bro
 version: !ruby/object:Gem::Version
-  version: 0.2.25
+  version: 0.2.26
 platform: ruby
 authors:
 - Emanuel Comsa