de_rjs 0.3.1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ef7b1985606279e19f688ce19a2bf653ec16b9f2
-  data.tar.gz: 1d4b2e9945ef5faf9364b45da0d5c9a162d98e2d
+  metadata.gz: eae4de9892c19b5e8f6192db42a2a79723406577
+  data.tar.gz: 9079ab6320e36da5aeca6ac240313d1e451b4569
 SHA512:
-  metadata.gz: '048cff985a57484e5a978347761e9a72fd80a7f7ba6cbf3250099ae5b6163faf339eb80bf55927c6e85ec9141603d092d2f09abf4e9eae77ae0b1e3fc57f10a7'
-  data.tar.gz: 749b55aa71df3705d28470be60aad909828483107d3636239110246fc8373ddffa0aa6cd9a9c5e8abf2d252472f0054a93cd6fda5fa91b46bfb723d44bbc7f9e
+  metadata.gz: 78bd18998d5a272491e345a190c1c131d181fb6d3e8f6844a88d47e559ef6f2803122dec6fb200233e32508c33c62a81705c4264cb2091bfc869cfe7c2824184
+  data.tar.gz: 427622719892e792ae4847b94e6cb948897617482dafa5fac48d485f29a26258e60a83c441467771fd97cf6da692a42157ad18adf9c99ef7631d1753274ee2c4

data/lib/de_rjs/jquery_generator.rb

@@ -566,10 +566,6 @@ module DeRjs
         generator = self.class.new(@context, &block)
         literal("function() { #{generator.to_s} }")
       end
-
-      def method_missing(method, *arguments)
-        JavaScriptProxy.new(self, method.to_s.camelize)
-      end
     end
   end
 
@@ -584,15 +580,30 @@ module DeRjs
       klass == JavaScriptProxy
     end
 
+    def ==(other)
+      raise "haha"
+    end
+
     private
     def method_missing(method, *arguments, &block)
       if method.to_s =~ /(.*)=$/
+        warn(method.to_s, *arguments)
         assign($1, arguments.first)
       else
+        warn(method.to_s, *arguments)
         call("#{method.to_s.camelize(:lower)}", *arguments, &block)
       end
     end
 
+    def known_jquery_methods
+      %w(hide show first last)
+    end
+
+    def warn(method, *arguments)
+      return if known_jquery_methods.include? method.to_s
+      ::Kernel.puts "#{method} is called via method_missing with args: #{arguments.inspect} at: #{::Kernel.caller.join("\n")}"
+    end
+
     def call(function, *arguments, &block)
       append_to_function_chain!("#{function}(#{@generator.send(:arguments_for_call, arguments, block)})")
       self
@@ -789,7 +800,7 @@ module DeRjs
 
   class JavaScriptElementCollectionProxy < JavaScriptCollectionProxy #:nodoc:\
     def initialize(generator, pattern)
-      super(generator, "#{::JQUERY_VAR}(#{::ActiveSupport::JSON.encode(pattern)})")
+      super(generator, "#{::JQUERY_VAR}(#{::ActiveSupport::JSON.encode(pattern)});")
     end
   end
 end

data/test/de_rjs_test.rb

@@ -9,15 +9,6 @@ end
 
 class DeRjsBaseTest < Minitest::Test
   protected
-  def not_supported
-    skip "not supported"
-  end
-
-  def create_generator
-    block = Proc.new { |*args| yield(*args) if block_given? }
-    DeRjs::JqueryGenerator.new self, &block
-  end
-
   def generate_js(rjs)
     rewritten_source = DeRjs::Rewriter.rewrite_rjs(rjs)
     generator = DeRjs::JqueryGenerator.new(nil) { eval(rewritten_source)}
@@ -29,7 +20,6 @@ end
 class DeRjsTest < DeRjsBaseTest
   def setup
     super
-    @generator = create_generator
     ActiveSupport.escape_html_entities_in_json  = true
   end
 
@@ -120,32 +110,6 @@ class DeRjsTest < DeRjsBaseTest
       generate_js(%Q{ page.reload })
   end
 
-  def test_delay
-    not_supported
-
-    @generator.delay(20) do
-      @generator.hide('foo')
-    end
-
-    assert_equal "setTimeout(function() {\n;\njQuery(\"#foo\").hide();\n}, 20000);", @generator.to_s
-  end
-
-  def test_to_s
-    not_supported
-
-    @generator.insert_html(:top, 'element', '<p>This is a test</p>')
-    @generator.insert_html(:bottom, 'element', '<p>This is a test</p>')
-    @generator.remove('foo', 'bar')
-    @generator.replace_html('baz', '<p>This is a test</p>')
-
-    assert_equal <<-EOS.chomp, @generator.to_s
-jQuery("#element").prepend("\\u003cp\\u003eThis is a test\\u003c/p\\u003e");
-jQuery("#element").append("\\u003cp\\u003eThis is a test\\u003c/p\\u003e");
-jQuery("#foo,#bar").remove();
-jQuery("#baz").html("\\u003cp\\u003eThis is a test\\u003c/p\\u003e");
-    EOS
-  end
-
   def test_element_access
     assert_equal %(jQuery("#hello");), generate_js(%Q{ page['hello'] })
   end
@@ -189,12 +153,12 @@ jQuery("#baz").html("\\u003cp\\u003eThis is a test\\u003c/p\\u003e");
   end
 
   def test_element_proxy_two_deep
-    @generator['hello'].hide("first").clean_whitespace
-    assert_equal %(jQuery("#hello").hide("first").cleanWhitespace();), @generator.to_s
+    skip "I don't think this has ever worked"
+    assert_equal %(jQuery("#hello").hide("first").cleanWhitespace();), generate_js(%Q{ page.hide("first").clean_whitespace })
   end
 
   def test_select_access
-    assert_equal %(jQuery("div.hello");), @generator.select('div.hello')
+    assert_equal %(jQuery("div.hello");), generate_js(%Q{ page.select('div.hello') })
   end
 
   def test_select_proxy_one_deep
@@ -219,25 +183,6 @@ jQuery("#baz").html("\\u003cp\\u003eThis is a test\\u003c/p\\u003e");
       generate_js(%Q{ page.visual_effect(:toggle_appear,"blah" + blah.id) })
   end
 
-  def test_sortable
-    assert_equal %(Sortable.create("blah", {onUpdate:function(){new Ajax.Request('http://www.example.com/order', {asynchronous:true, evalScripts:true, parameters:Sortable.serialize("blah")})}});),
-      @generator.sortable('blah', :url => { :action => "order" })
-    assert_equal %(Sortable.create("blah", {onUpdate:function(){new Ajax.Request('http://www.example.com/order', {asynchronous:false, evalScripts:true, parameters:Sortable.serialize("blah")})}});),
-      @generator.sortable('blah', :url => { :action => "order" }, :type => :synchronous)
-  end
-
-  def test_draggable
-    assert_equal %(new Draggable("blah", {});),
-      @generator.draggable('blah')
-  end
-
-  def test_drop_receiving
-    assert_equal %(Droppables.add("blah", {onDrop:function(element){new Ajax.Request('http://www.example.com/order', {asynchronous:true, evalScripts:true, parameters:'id=' + encodeURIComponent(element.id)})}});),
-      @generator.drop_receiving('blah', :url => { :action => "order" })
-    assert_equal %(Droppables.add("blah", {onDrop:function(element){new Ajax.Request('http://www.example.com/order', {asynchronous:false, evalScripts:true, parameters:'id=' + encodeURIComponent(element.id)})}});),
-      @generator.drop_receiving('blah', :url => { :action => "order" }, :type => :synchronous)
-  end
-
   def test_collection_first_and_last
     js = generate_js(%Q{
     page.select('p.welcome b').first.hide()
@@ -249,190 +194,8 @@ jQuery("p.welcome b").last().show();
       EOS
   end
 
-  def test_collection_proxy_with_each
-    not_supported
-
-    @generator.select('p.welcome b').each do |value|
-      value.remove_class_name 'selected'
-    end
-    @generator.select('p.welcome b').each do |value, index|
-      @generator.visual_effect :highlight, value
-    end
-    assert_equal <<-EOS.strip, @generator.to_s
-jQuery("p.welcome b").each(function(value, index) {
-value.removeClassName("selected");
-});
-jQuery("p.welcome b").each(function(value, index) {
-jQuery("#value").effect("highlight",{});
-});
-      EOS
-  end
-
-  def test_collection_proxy_on_collect
-    not_supported
-
-    @generator.select('p').collect('a') { |para| para.show }
-    @generator.select('p').collect { |para| para.hide }
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = jQuery("p").collect(function(value, index) {
-return value.show();
-});
-jQuery("p").collect(function(value, index) {
-return value.hide();
-});
-    EOS
-    @generator = create_generator
-  end
-
-  def test_collection_proxy_with_grep
-    not_supported
-
-    @generator.select('p').grep 'a', /^a/ do |value|
-      @generator << '(value.className == "welcome")'
-    end
-    @generator.select('p').grep 'b', /bjQuery/ do |value, index|
-      @generator.call 'alert', value
-      @generator << '(value.className == "welcome")'
-    end
-
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = jQuery("p").grep(/^a/, function(value, index) {
-return (value.className == "welcome");
-});
-var b = jQuery("p").grep(/bjQuery/, function(value, index) {
-alert(value);
-return (value.className == "welcome");
-});
-    EOS
-  end
-
-  def test_collection_proxy_with_inject
-    not_supported
-
-    @generator.select('p').inject 'a', [] do |memo, value|
-      @generator << '(value.className == "welcome")'
-    end
-    @generator.select('p').inject 'b', nil do |memo, value, index|
-      @generator.call 'alert', memo
-      @generator << '(value.className == "welcome")'
-    end
-
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = jQuery("p").inject([], function(memo, value, index) {
-return (value.className == "welcome");
-});
-var b = jQuery("p").inject(null, function(memo, value, index) {
-alert(memo);
-return (value.className == "welcome");
-});
-    EOS
-  end
-
   def test_collection_proxy_with_pluck
     js = generate_js(%Q{ page.select('p').pluck('a', 'className') })
     assert_equal %(var a = jQuery("p").pluck("className");), js
   end
-
-  def test_collection_proxy_with_zip
-    not_supported
-
-    ActionView::Helpers::JavaScriptCollectionProxy.new(@generator, '[1, 2, 3]').zip('a', [4, 5, 6], [7, 8, 9])
-    ActionView::Helpers::JavaScriptCollectionProxy.new(@generator, '[1, 2, 3]').zip('b', [4, 5, 6], [7, 8, 9]) do |array|
-      @generator.call 'array.reverse'
-    end
-
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = [1, 2, 3].zip([4,5,6], [7,8,9]);
-var b = [1, 2, 3].zip([4,5,6], [7,8,9], function(array) {
-return array.reverse();
-});
-    EOS
-  end
-
-  def test_collection_proxy_with_find_all
-    not_supported
-
-    @generator.select('p').find_all 'a' do |value, index|
-      @generator << '(value.className == "welcome")'
-    end
-
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = jQuery("p").findAll(function(value, index) {
-return (value.className == "welcome");
-});
-    EOS
-  end
-
-  def test_collection_proxy_with_in_groups_of
-    not_supported
-
-    @generator.select('p').in_groups_of('a', 3)
-    @generator.select('p').in_groups_of('a', 3, 'x')
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = jQuery("p").inGroupsOf(3);
-var a = jQuery("p").inGroupsOf(3, "x");
-    EOS
-  end
-
-  def test_collection_proxy_with_each_slice
-    not_supported
-
-    @generator.select('p').each_slice('a', 3)
-    @generator.select('p').each_slice('a', 3) do |group, index|
-      group.reverse
-    end
-
-    assert_equal <<-EOS.strip, @generator.to_s
-var a = jQuery("p").eachSlice(3);
-var a = jQuery("p").eachSlice(3, function(value, index) {
-return value.reverse();
-});
-    EOS
-  end
-
-  #def test_debug_rjs
-    #ActionView::Base.debug_rjs = true
-    #@generator['welcome'].replace_html 'Welcome'
-    #assert_equal "try {\njQuery(\"#welcome\").html(\"Welcome\");\n} catch (e) { alert('RJS error:\\n\\n' + e.toString()); alert('jQuery(\\\"#welcome\\\").html(\\\"Welcome\\\");'); throw e }", @generator.to_s
-  #ensure
-    #ActionView::Base.debug_rjs = false
-  #end
-
-  def test_literal
-    not_supported
-
-    literal = @generator.literal("function() {}")
-    assert_equal "function() {}", ActiveSupport::JSON.encode(literal)
-    assert_equal "", @generator.to_s
-  end
-
-  def test_class_proxy
-    @generator.form.focus('my_field')
-    assert_equal "Form.focus(\"my_field\");", @generator.to_s
-  end
-
-  def test_call_with_block
-    not_supported
-
-    @generator.call(:before)
-    @generator.call(:my_method) do |p|
-      p[:one].show
-      p[:two].hide
-    end
-    @generator.call(:in_between)
-    @generator.call(:my_method_with_arguments, true, "hello") do |p|
-      p[:three].visual_effect(:highlight)
-    end
-    assert_equal "before();\nmy_method(function() { jQuery(\"#one\").show();\njQuery(\"#two\").hide(); });\nin_between();\nmy_method_with_arguments(true, \"hello\", function() { jQuery(\"#three\").visualEffect(\"highlight\"); });", @generator.to_s
-  end
-
-  def test_class_proxy_call_with_block
-    not_supported
-
-    @generator.my_object.my_method do |p|
-      p[:one].show
-      p[:two].hide
-    end
-    assert_equal "MyObject.myMethod(function() { jQuery(\"#one\").show();\njQuery(\"#two\").hide(); });", @generator.to_s
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: de_rjs
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.4.0
 platform: ruby
 authors:
 - Thong Kuah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-28 00:00:00.000000000 Z
+date: 2017-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails