ddy_remote_resource 1.3.4 → 1.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f46c58fdc36a27fab841cc9e7f7b00b031222ae791c45868202dd78585ab5740
-  data.tar.gz: db13bcd527681297b4f0f610cf400a82d277343563f95d12cf69b5feec9df281
+  metadata.gz: '08f25322ca3d01eebb8816f4623aeec281e47b71e89ed46ba810d28f77abbb0e'
+  data.tar.gz: d1c8965207f1dd8c7df47de47e709f796918592307c6445941ca45898a2f1e97
 SHA512:
-  metadata.gz: df1ef50fbcf959873d094f68b40876d8a7792e424180ac1c31799b9ff15044d7dea069e5816a5a39216139c29612261cfb1e2a9f1cda7efface82de7092ab6b6
-  data.tar.gz: ebc39842902d31a43ab64898952b437793172727514c3ccc56dea15f5f464447789ad5ba795d7e196e02ccc9b79869fb2985d81d1e6567eda5a35c8b96ee635b
+  metadata.gz: f0738e9617ee9716b7553553314bac7163bb6cce9f2ef7cd6b1689d2dde0575f51035e475887f79c568d2aec4c62c9ab171e5aaf87983188f4ae1ee55b8adbe4
+  data.tar.gz: 4c98e7bc8cbb8c1d508310a163ad498371a9e7e490071f72d166ac3961c4223f34bed9ece37ad4ac572503ed389fe0f427838f37f8ccc67085970b992abb9b7a

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [1.3.5] - 2026-02-24
+
+### Added
+
+- Enrich DELETE action with body params
+
 ## [1.3.4] - 2024-10-29
 
 ### Added

data/lib/remote_resource/request.rb

@@ -81,6 +81,9 @@ module RemoteResource
         case http_action
         when :put, :patch, :post
           attributes.to_json
+        when :delete
+          body_attributes = connection_options[:body]
+          body_attributes.present? ? body_attributes.to_json : nil
         when :get
           connection_options[:params].to_json if connection_options[:force_get_params_in_body]
         else

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '1.3.4'.freeze
+  VERSION = '1.3.5'.freeze
 end

data/spec/integration/destroy_spec.rb

@@ -180,6 +180,20 @@ RSpec.describe '.destroy and #destroy' do
       end
     end
 
+    describe 'with connection_options[:body]' do
+      let!(:expected_request) do
+        mock_request = stub_request(:delete, 'https://www.example.com/posts/12.json')
+        mock_request.with(body: { pseudonym: 'pseudonym' }.to_json, headers: expected_default_headers.merge('Content-Type' => 'application/json'))
+        mock_request.to_return(status: 204, body: response_body.to_json)
+        mock_request
+      end
+
+      it 'performs the correct HTTP DELETE request' do
+        resource.destroy(body: { pseudonym: 'pseudonym' })
+        expect(expected_request).to have_been_requested
+      end
+    end
+
     describe 'with connection_options[:headers]' do
       let!(:expected_request) do
         mock_request = stub_request(:delete, 'https://www.example.com/posts/12.json')

data/spec/lib/remote_resource/querying/persistence_methods_spec.rb

@@ -415,6 +415,15 @@ RSpec.describe RemoteResource::Querying::PersistenceMethods do
       end
     end
 
+    it 'sends the body when connection_options[:body] is present' do
+      expected_request = stub_request(:delete, 'https://www.example.com/posts/12.json')
+        .with(body: { pseudonym: 'pseudonym' }.to_json)
+        .to_return(status: 204, body: response_body.to_json)
+
+      resource.destroy(body: { pseudonym: 'pseudonym' })
+      expect(expected_request).to have_been_requested
+    end
+
     it 'does NOT change the given connection_options' do
       connection_options = { headers: { 'Foo' => 'Bar' } }
 

data/spec/lib/remote_resource/request_spec.rb

@@ -267,7 +267,55 @@ RSpec.describe RemoteResource::Request do
       let(:expected_body) { nil }
       let(:expected_connection_options) { request.connection_options }
 
-      it 'makes a DELETE request with the connection_options[:params] as query' do
+      it 'makes a DELETE request without a body' do
+        expect(connection).to receive(:delete).with(expected_request_url, params: expected_params,
+                                                    body: expected_body, headers: expected_headers,
+                                                    connecttimeout: 30, timeout: 120).and_call_original
+        request.perform
+      end
+
+      include_examples 'a conditional construct for the response'
+    end
+
+    context 'when the http_action is :delete with connection_options[:body]' do
+      let(:http_action) { 'delete' }
+      let(:attributes) do
+        { id: 15 }
+      end
+      let(:connection_options) do
+        { params: { pseudonym: 'pseudonym' }, body: { pseudonym: 'pseudonym', labels: [1, '2', 'three'] } }
+      end
+
+      let(:expected_request_url) { 'http://www.foobar.com/request_dummy/15.json' }
+      let(:expected_params) { RemoteResource::Util.encode_params_to_query({ pseudonym: 'pseudonym' }) }
+      let(:expected_headers) { described_class::DEFAULT_HEADERS.merge(described_class::DEFAULT_CONTENT_TYPE) }
+      let(:expected_body) { JSON.generate(connection_options[:body]) }
+      let(:expected_connection_options) { request.connection_options }
+
+      it 'makes a DELETE request with the body from connection_options[:body]' do
+        expect(connection).to receive(:delete).with(expected_request_url, params: expected_params,
+                                                    body: expected_body, headers: expected_headers,
+                                                    connecttimeout: 30, timeout: 120).and_call_original
+        request.perform
+      end
+
+      include_examples 'a conditional construct for the response'
+    end
+
+    context 'when the http_action is :delete without attributes' do
+      let(:http_action) { 'delete' }
+      let(:attributes) { {} }
+      let(:connection_options) do
+        { id: 15, params: { pseudonym: 'pseudonym' } }
+      end
+
+      let(:expected_request_url) { 'http://www.foobar.com/request_dummy/15.json' }
+      let(:expected_params) { RemoteResource::Util.encode_params_to_query({ pseudonym: 'pseudonym' }) }
+      let(:expected_headers) { described_class::DEFAULT_HEADERS }
+      let(:expected_body) { nil }
+      let(:expected_connection_options) { request.connection_options }
+
+      it 'makes a DELETE request without body' do
         expect(connection).to receive(:delete).with(expected_request_url, params: expected_params,
                                                     body: expected_body, headers: expected_headers,
                                                     connecttimeout: 30, timeout: 120).and_call_original
@@ -460,6 +508,30 @@ RSpec.describe RemoteResource::Request do
         expect(request.body).to be_nil
       end
     end
+
+      context 'when the http_action is :delete and connection_options[:body] is present' do
+        let(:http_action) { :delete }
+        let(:connection_options) do
+          { body: { pseudonym: 'pseudonym', labels: [1, '2', 'three'] } }
+        end
+
+        let(:expected_body) do
+          '{"pseudonym":"pseudonym","labels":[1,"2","three"]}'
+        end
+
+        it 'returns the JSON-encoded connection_options[:body]' do
+          expect(request.body).to eql expected_body
+        end
+      end
+
+      context 'when the http_action is :delete and connection_options[:body] is not present' do
+        let(:http_action) { :delete }
+
+        it 'returns nil' do
+          expect(request.body).to be_nil
+        end
+      end
+
   end
 
   describe '#attributes' do

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - Digidentity
 - Johnny Dongelmans
 - Jan van der Pas
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-29 00:00:00.000000000 Z
+date: 2026-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -309,7 +309,7 @@ homepage: https://github.com/digidentity/ddy_remote_resource
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -324,8 +324,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
-signing_key:
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: RemoteResource, a gem to use resources with REST services.
 test_files: