ddy_remote_resource 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72cede4abb216272f1f22c2e8c2509bc832a77ecfc1b10435c462206f56294de
-  data.tar.gz: d4fb9fa5d7515de365d5115e9652c27ece767f588ac99f458cb6cb367af947f0
+  metadata.gz: b75b31568bd5a246694f34d65c20226e97c2620f7afd6f11750af62ed594b458
+  data.tar.gz: 3bdce3777b2ea4fc6a72371ec9e117a3f41bd304316cd0f8eb064e8fa3c0fa8e
 SHA512:
-  metadata.gz: 518d4d673aed4390fc3b46bf190905da19566b31e86f2d20b82b7cc3efa1f4120244d69b6aaf2dafd2aecc6e90529df0362864b53511d218406d85ea33a8db98
-  data.tar.gz: 07621f0c66b4efb19536e34a08ca6a38ed3ae8bf2e760843363ff2ab9e0fcb8c5cf0b1b5626063856710378bfc09ca40f06f58d421e44a02fa432b547dc7cd7a
+  metadata.gz: d0c20de26d1ae69f00878158fa2730fffa0cf43a1b6981a55faec3e435950009700fee9d600160698b45b235d9ffa42c8ee8848bb8e5a8eaab6935461976d554
+  data.tar.gz: 9cd8475b745edad03b039567d5353b7a7b5077ad4d2721bd91b6b114a35d4a44554d417b060f3a069e20fa911232e5ec080183c1328f09e4e2ea1301713d3025

data/.travis.yml

@@ -1,3 +1,3 @@
 language: ruby
 rvm:
-  - 2.5.3
+  - 2.6.8

data/lib/remote_resource/errors.rb

@@ -42,6 +42,12 @@ module RemoteResource
       @response.code
     end
 
+    # The return code can contain additional information when response_code=0
+    # see https://curl.se/libcurl/c/libcurl-errors.html for the full list
+    def return_code
+      @response.return_code
+    end
+
     def response_body
       @response.body # TODO: Filter sensitive information using: RemoteResource::Util.filter_params
     end
@@ -53,6 +59,7 @@ module RemoteResource
     def to_s
       message = "HTTP request failed for #{resource_klass}"
       message << " with response_code=#{response_code}" if response_code.present?
+      message << " with return_code=#{return_code}" if return_code.present? && response_code.zero?
       message << " with http_action=#{http_action}"
       message << " with request_url=#{request_url}"
       message

data/lib/remote_resource/response.rb

@@ -28,7 +28,11 @@ module RemoteResource
       @response_code ||= @connection_response.response_code
     end
 
-    alias_method :code, :response_code
+    alias code response_code
+
+    def return_code
+      @return_code ||= @connection_response.return_code
+    end
 
     def headers
       @headers ||= @connection_response.headers

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '1.2.1'.freeze
+  VERSION = '1.2.2'.freeze
 end

data/spec/lib/remote_resource/request_spec.rb

@@ -682,6 +682,17 @@ RSpec.describe RemoteResource::Request do
       end
     end
 
+    context 'when the response code is 0 and no other error is raised' do
+      it 'raises a RemoteResource::HTTPError with correct error message' do
+        allow(response).to receive(:response_code) { 0 }
+        allow(connection_response).to receive(:return_code) { :ssl_connect }
+        allow(connection_response).to receive(:response_code) { 0 }
+
+        error_message = 'HTTP request failed for RemoteResource::RequestDummy with response_code=0 with return_code=ssl_connect with http_action=get with request_url=http://www.foobar.com/request_dummy.json'
+        expect { request.send(:raise_http_error, request, response) }.to raise_error RemoteResource::HTTPError, error_message
+      end
+    end
+
     context 'when the response code is nothing and no other error is raised' do
       it 'raises a RemoteResource::HTTPError' do
         allow(response).to receive(:response_code) { nil }

data/spec/lib/remote_resource/version_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
 
 RSpec.describe RemoteResource::VERSION do
-  it { is_expected.to eql '1.2.0' }
+  it { is_expected.to eql '1.2.2' }
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Digidentity
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-10 00:00:00.000000000 Z
+date: 2021-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler