ddy_remote_resource 1.2.0 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0032d56e8df7f6e90e146abb65b29a41a59a63e39747c6b0b7585c02f577069
-  data.tar.gz: 4454b9226626e5a2028dc871c83d15347da8a373d104e641810c3f002e8e94c0
+  metadata.gz: bc832463abbb4ae23f60450dd26d5ea1c0877936bec0bd73240fa5e57146500c
+  data.tar.gz: bce2d906670cc76c1ce5a3d078556d6bb36db600257427481c29abc4a70f2fcc
 SHA512:
-  metadata.gz: 327330942d08e782894d10b46be1c6a6fc560f4cab2a4f7bb77a2b2958853ad929a024ccc00c560a3672e48c55a5844e9064e9c7fc00ae9839228d904038f2b6
-  data.tar.gz: f6d6b6c025c695cd68f4697b9a001046d54a29b32f51aabbec187ff9359bf32da6db83510cc5a3a251729159100e06b11054986a009d55386ece26e5f372ed8b
+  metadata.gz: adb4cba41affef80d801a7797643f71430303ce62e1a1243ad17f2c8590ae6e83baa19c5f5bba5b237084daf9637c0c11cb159abd5e2e8a713631a6f573217af
+  data.tar.gz: 665c40303743c338d00423c05e0e7307ea8f617c536078ee92452e7b4f56758e2f477db96fba6f9734815d326b35da975b0cf30d303693b1057bab645203d823

data/.gitignore

@@ -22,3 +22,4 @@ tmp
 *.a
 mkmf.log
 sandbox/
+*.DS_Store

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.7.6

data/.travis.yml

@@ -1,3 +1,6 @@
 language: ruby
 rvm:
-  - 2.5.3
+  - 2.6.10
+  - 2.7.6
+  - 3.0.4
+  - 3.1.2

data/Gemfile

@@ -2,5 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in remote_resource.gemspec
 gemspec
-
-gem 'webmock', git: 'https://github.com/JanDintel/webmock.git', branch: 'feature/ignore-json-keys-order'

data/README.md

@@ -11,9 +11,6 @@ To replace `ActiveResource` by providing a dynamic and customizable API interfac
 Add this line to your application's Gemfile:
 
 ```ruby
-# Use this to fetch the gem from Gitlab
-gem 'remote_resource', git: 'git@lab.digidentity.eu:jvanderpas/remote_resource.git'
-
 # Use this to fetch the gem from RubyGems.org
 gem 'ddy_remote_resource', require: 'remote_resource'
 ```

data/lib/remote_resource/errors.rb

@@ -42,6 +42,12 @@ module RemoteResource
       @response.code
     end
 
+    # The return code can contain additional information when response_code=0
+    # see https://curl.se/libcurl/c/libcurl-errors.html for the full list
+    def return_code
+      @response.return_code
+    end
+
     def response_body
       @response.body # TODO: Filter sensitive information using: RemoteResource::Util.filter_params
     end
@@ -53,6 +59,7 @@ module RemoteResource
     def to_s
       message = "HTTP request failed for #{resource_klass}"
       message << " with response_code=#{response_code}" if response_code.present?
+      message << " with return_code=#{return_code}" if return_code.present? && response_code.zero?
       message << " with http_action=#{http_action}"
       message << " with request_url=#{request_url}"
       message

data/lib/remote_resource/response.rb

@@ -28,7 +28,11 @@ module RemoteResource
       @response_code ||= @connection_response.response_code
     end
 
-    alias_method :code, :response_code
+    alias code response_code
+
+    def return_code
+      @return_code ||= @connection_response.return_code
+    end
 
     def headers
       @headers ||= @connection_response.headers

data/lib/remote_resource/url_naming_determination.rb

@@ -30,7 +30,7 @@ module RemoteResource
             raise(RemoteResource::CollectionOptionKeyError, "`collection_prefix` variable `#{key}` is missing from `collection_options`") if check_collection_options
             value = key
           end
-          URI.parser.escape(value.to_s)
+            URI::DEFAULT_PARSER.escape(value.to_s)
         end
       end
     end

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '1.2.0'.freeze
+  VERSION = '1.2.3'.freeze
 end

data/remote_resource.gemspec

@@ -6,7 +6,7 @@ require 'remote_resource/version'
 Gem::Specification.new do |spec|
   spec.name          = 'ddy_remote_resource'
   spec.version       = RemoteResource::VERSION
-  spec.authors       = ['Digidentity', 'Jan van der Pas']
+  spec.authors       = ['Digidentity', 'Johnny Dongelmans', 'Jan van der Pas']
   spec.email         = ['development@digidentity.com']
   spec.summary       = %q{RemoteResource, a gem to use resources with REST services.}
   spec.description   = %q{RemoteResource, a gem to use resources with REST services. A replacement for ActiveResource gem.}
@@ -18,20 +18,20 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.4'
   spec.add_development_dependency 'rspec', '~> 3.1'
   spec.add_development_dependency 'pry', '~> 0.10'
-  # spec.add_development_dependency 'webmock', '~> 1.24'
+  spec.add_development_dependency 'webmock', '~> 3'
   spec.add_development_dependency 'guard', '~> 2.14'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
   spec.add_development_dependency 'terminal-notifier-guard', '~> 1.6'
 
-  spec.add_runtime_dependency 'activesupport', '>= 4.1', '< 7'
-  spec.add_runtime_dependency 'activemodel', '>= 4.1', '< 7'
+  spec.add_runtime_dependency 'activesupport', '>= 4.1', '< 8'
+  spec.add_runtime_dependency 'activemodel', '>= 4.1', '< 8'
   spec.add_runtime_dependency 'virtus', '~> 1.0', '>= 1.0.4'
   spec.add_runtime_dependency 'mime-types', '~> 3.0'
-  spec.add_runtime_dependency 'ethon', '~> 0.7', '>= 0.7.1'
-  spec.add_runtime_dependency 'typhoeus', '~> 0.7', '>= 0.7.0'
+  spec.add_runtime_dependency 'ethon'
+  spec.add_runtime_dependency 'typhoeus', '>= 0.7'
   spec.add_runtime_dependency 'request_store', '~> 1.4.1'
 end

data/spec/integration/save_spec.rb

@@ -21,8 +21,8 @@ RSpec.describe '#save' do
         id:         12,
         title:      'Lorem Ipsum',
         body:       'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
-        featured:   false,
         created_at: Time.new(2015, 10, 4, 9, 30, 0),
+        featured:   false
       }
     }
   end
@@ -39,8 +39,8 @@ RSpec.describe '#save' do
         data: {
           title:      'Lorem Ipsum',
           body:       'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
-          featured:   false,
           created_at: Time.new(2015, 10, 4, 9, 30, 0),
+          featured:   false
         }
       }
     end
@@ -103,8 +103,8 @@ RSpec.describe '#save' do
           data: {
             title:      'Lore',
             body:       '',
-            featured:   true,
             created_at: Time.new(2015, 10, 4, 9, 30, 0),
+            featured:   true
           }
         }
       end
@@ -181,8 +181,8 @@ RSpec.describe '#save' do
         data: {
           title:      'Lorem Ipsum',
           body:       'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
-          featured:   false,
           created_at: nil,
+          featured:   false
         }
       }
     end
@@ -246,8 +246,8 @@ RSpec.describe '#save' do
           data: {
             title:      'Lore',
             body:       '',
-            featured:   true,
-            created_at: nil
+            created_at: nil,
+            featured:   true
           }
         }
       end

data/spec/lib/remote_resource/request_spec.rb

@@ -682,6 +682,17 @@ RSpec.describe RemoteResource::Request do
       end
     end
 
+    context 'when the response code is 0 and no other error is raised' do
+      it 'raises a RemoteResource::HTTPError with correct error message' do
+        allow(response).to receive(:response_code) { 0 }
+        allow(connection_response).to receive(:return_code) { :ssl_connect }
+        allow(connection_response).to receive(:response_code) { 0 }
+
+        error_message = 'HTTP request failed for RemoteResource::RequestDummy with response_code=0 with return_code=ssl_connect with http_action=get with request_url=http://www.foobar.com/request_dummy.json'
+        expect { request.send(:raise_http_error, request, response) }.to raise_error RemoteResource::HTTPError, error_message
+      end
+    end
+
     context 'when the response code is nothing and no other error is raised' do
       it 'raises a RemoteResource::HTTPError' do
         allow(response).to receive(:response_code) { nil }

data/spec/lib/remote_resource/version_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
 
 RSpec.describe RemoteResource::VERSION do
-  it { is_expected.to eql '1.2.0' }
+  it { is_expected.to eql '1.2.3' }
 end

metadata

@@ -1,30 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.3
 platform: ruby
 authors:
 - Digidentity
+- Johnny Dongelmans
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-08 00:00:00.000000000 Z
+date: 2022-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -67,6 +68,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -118,7 +133,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -128,7 +143,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
@@ -138,7 +153,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -148,7 +163,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: virtus
   requirement: !ruby/object:Gem::Requirement
@@ -187,42 +202,30 @@ dependencies:
   name: ethon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.7'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: request_store
   requirement: !ruby/object:Gem::Requirement
@@ -320,8 +323,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.3.15
 signing_key: 
 specification_version: 4
 summary: RemoteResource, a gem to use resources with REST services.