ddy_remote_resource 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a83306ed9f8641a5842e6b886a0fad7ac91898f9
-  data.tar.gz: c47d38be2244a886ba8afaae18aa54f8953436be
+  metadata.gz: 105d5039c31e2184308d4644f7abfb77d7d4d1b8
+  data.tar.gz: 6bafc95fb2ddcfe869e10c4ea1a56159454c10f7
 SHA512:
-  metadata.gz: d6f5cc8d3bbd70527df5337af6ec8e9ba4ac8257a34d683772654fc79e170a0a43629fa5985c3ba7cf7db9907fe53fbb86bb431dc5257783bc08a2949ab4e530
-  data.tar.gz: d29ffc3ad4f221bf3bc756aa0a1935de98fdb8f06da14bad8e745304e04214e2a3076827abce3b59be56bfefef967da9b22edcfe194494f92b49aa1e193246eb
+  metadata.gz: 3014a4aed78428e91fd8b8e0ad79731838537a021d28077f04b3892bbf535887cb903355a412924643dbe4a5f32adddda78a5eb24084bb453930c3070267b16d
+  data.tar.gz: f359aceea77a8470012c43269827787329124d14e1702cf28224c5bd8a3c7dbb3bb572de4fbf06e75abdc4574455899886152403bcb5d63b62fc0bb512aea497

data/lib/remote_resource/base.rb

@@ -20,7 +20,7 @@ module RemoteResource
       include RemoteResource::Querying::PersistenceMethods
 
       attr_accessor :last_request, :last_response, :meta
-      attr_accessor :destroyed
+      attr_writer :destroyed, :persisted, :success
 
       class_attribute :root_element, instance_accessor: false
 
@@ -74,19 +74,23 @@ module RemoteResource
     end
 
     def persisted?
-      if destroyed
+      if destroyed?
         false
       else
-        id.present?
+        !!@persisted || id.present?
       end
     end
 
     def new_record?
-      !persisted?
+      !persisted? && !destroyed?
+    end
+
+    def destroyed?
+      !!@destroyed
     end
 
     def success?
-      last_response.success? && !errors?
+      !!@success || (last_response.present? && last_response.success? && !errors?)
     end
 
     def errors?

data/lib/remote_resource/errors.rb

@@ -55,11 +55,9 @@ module RemoteResource
       message << " with response_code=#{response_code}" if response_code.present?
       message << " with http_action=#{http_action}"
       message << " with request_url=#{request_url}"
-      # message << " with request_query=#{request_query}" if request_query.present? # TODO: Test usability of error message whether to include this
-      # message << " with request_body=#{request_body}" if request_body.present? # TODO: Test usability of error message whether to include this
-      # message << " with response_body=#{response_body}" if response_body.present? # TODO: Test usability of error message whether to include this
       message
     end
+
   end
 
   HTTPRedirectionError = Class.new(HTTPError) # HTTP 3xx

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 end

data/spec/lib/remote_resource/base_spec.rb

@@ -137,50 +137,67 @@ RSpec.describe RemoteResource::Base do
     end
   end
 
-  describe '#persisted?' do
+  describe '#persisted?, #new_record? and #destroyed?' do
     context 'when id is present' do
-      it 'returns true' do
+      it 'returns the correct lifecycle predicates' do
         dummy.id = 10
-        expect(dummy.persisted?).to eql true
+
+        aggregate_failures do
+          expect(dummy.persisted?).to eql true
+          expect(dummy.new_record?).to eql false
+          expect(dummy.destroyed?).to eql false
+        end
       end
     end
 
-    context 'when id is present and destroyed is present' do
-      it 'returns false' do
+    context 'when id is present and @destroyed flag is present' do
+      it 'returns the correct lifecycle predicates' do
         dummy.id = 10
         dummy.destroyed = true
-        expect(dummy.persisted?).to eql false
+
+        aggregate_failures do
+          expect(dummy.persisted?).to eql false
+          expect(dummy.new_record?).to eql false
+          expect(dummy.destroyed?).to eql true
+        end
       end
     end
 
     context 'when id is NOT present' do
-      it 'returns false' do
+      it 'returns the correct lifecycle predicates' do
         dummy.id = nil
-        expect(dummy.persisted?).to eql false
+
+        aggregate_failures do
+          expect(dummy.persisted?).to eql false
+          expect(dummy.new_record?).to eql true
+          expect(dummy.destroyed?).to eql false
+        end
       end
     end
 
-    context 'when id is NOT present and destroyed is present' do
-      it 'returns false' do
+    context 'when id is NOT present and @persisted flag is present' do
+      it 'returns the correct lifecycle predicates' do
         dummy.id = nil
-        dummy.destroyed = true
-        expect(dummy.persisted?).to eql false
-      end
-    end
-  end
+        dummy.persisted = true
 
-  describe '#new_record?' do
-    context 'when #persisted?' do
-      it 'returns false' do
-        dummy.id = 10
-        expect(dummy.new_record?).to eql false
+        aggregate_failures do
+          expect(dummy.persisted?).to eql true
+          expect(dummy.new_record?).to eql false
+          expect(dummy.destroyed?).to eql false
+        end
       end
     end
 
-    context 'when NOT #persisted?' do
-      it 'returns true' do
+    context 'when id is NOT present and @destroyed flag is present' do
+      it 'returns the correct lifecycle predicates' do
         dummy.id = nil
-        expect(dummy.new_record?).to eql true
+        dummy.destroyed = true
+
+        aggregate_failures do
+          expect(dummy.persisted?).to eql false
+          expect(dummy.new_record?).to eql false
+          expect(dummy.destroyed?).to eql true
+        end
       end
     end
   end
@@ -210,6 +227,32 @@ RSpec.describe RemoteResource::Base do
         expect(dummy.success?).to eql false
       end
     end
+
+    context 'when last response is NOT successful and #success flag is present' do
+      it 'returns true' do
+        dummy.last_response = instance_double(RemoteResource::Response, success?: false)
+        dummy.success = true
+
+        expect(dummy.success?).to eql true
+      end
+    end
+
+    context 'when last response is NOT present' do
+      it 'returns false' do
+        dummy.last_response = nil
+
+        expect(dummy.success?).to eql false
+      end
+    end
+
+    context 'when last response is NOT present and #success flag is present' do
+      it 'returns true' do
+        dummy.last_response = nil
+        dummy.success = true
+
+        expect(dummy.success?).to eql true
+      end
+    end
   end
 
   describe '#errors?' do

data/spec/lib/remote_resource/version_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe RemoteResource::VERSION do
-  it { is_expected.to eql '1.0.2' }
+  it { is_expected.to eql '1.0.3' }
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-18 00:00:00.000000000 Z
+date: 2017-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler