ddy_remote_resource 0.4.9 → 0.4.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4fb6043c6ff3de6d36965017bffec730b1659f17
-  data.tar.gz: 32cf30b232c83c0a42c969ff24ce78f362a3bd6c
+  metadata.gz: 105352f9caf2a46040cd7428628bd73371f09b76
+  data.tar.gz: e64caf4294b2d126b306b8906327e5adea78c249
 SHA512:
-  metadata.gz: 948ad8bad7470092350a50a357f63810ff24728e4b9b4114766a64d56c217e720ba76727b4ea3b4c3a982e044db6c4e4a905b0cf0626fba01cdee7060338dffc
-  data.tar.gz: 02723a379602c6bb06e99b7c63882d833a79562122951e886c050ee7c4dd044d0242e85168eae0d3fe5d86a90155d03627e1c9e2d5bafb87409ffdf555349aec
+  metadata.gz: 697f9c48d2761ed0c689866ea9ffb0a86133b9232a822807a8bdbe8f19c4eca5f7b0dab48b0767fd83054389cb46f29a13990b9437225b99dc505194cff9b748
+  data.tar.gz: 8dcf2452275ea8ecf7a03f83a81f6537fd2853d5694a48e7eadaaeb64c97eba1d5e928118a3b57f077554a70c8bc205e78c9b2bae581805ffff22fbd2eab0776

data/lib/remote_resource/querying/persistence_methods.rb

@@ -13,7 +13,7 @@ module RemoteResource
 
         def destroy(id, connection_options = {})
           resource = new
-          response = RemoteResource::Request.new(self, :delete, { id: id }, connection_options).perform
+          response = RemoteResource::Request.new(self, :delete, { id: id }, connection_options.reverse_merge(no_attributes: true)).perform
           resource.handle_response(response)
         end
       end
@@ -41,7 +41,7 @@ module RemoteResource
 
       def destroy(connection_options = {})
         id.present? || raise(RemoteResource::IdMissingError.new("`id` is missing from resource"))
-        response = RemoteResource::Request.new(self, :delete, { id: id }, connection_options).perform
+        response = RemoteResource::Request.new(self, :delete, { id: id }, connection_options.reverse_merge(no_attributes: true)).perform
         handle_response(response)
         success? ? self : false
       end

data/lib/remote_resource/request.rb

@@ -32,7 +32,7 @@ module RemoteResource
       when :put, :patch, :post
         response = connection.public_send rest_action, determined_request_url, body: determined_attributes, headers: determined_headers
       when :delete
-        response = connection.public_send rest_action, determined_request_url, body: determined_attributes, headers: determined_headers
+        response = connection.public_send rest_action, determined_request_url, params: determined_params, headers: determined_headers
       else
         raise RemoteResource::RESTActionUnknown, "for action: '#{rest_action}'"
       end

data/lib/remote_resource/version.rb

@@ -1,3 +1,3 @@
 module RemoteResource
-  VERSION = '0.4.9'
+  VERSION = '0.4.10'
 end

data/spec/lib/remote_resource/querying/persistence_methods_spec.rb

@@ -60,7 +60,7 @@ describe RemoteResource::Querying::PersistenceMethods do
     end
 
     it 'performs a RemoteResource::Request' do
-      expect(RemoteResource::Request).to receive(:new).with(dummy_class, :delete, { id: '15' }, {}).and_call_original
+      expect(RemoteResource::Request).to receive(:new).with(dummy_class, :delete, { id: '15' }, { no_attributes: true }).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy_class.destroy('15')
     end
@@ -69,6 +69,21 @@ describe RemoteResource::Querying::PersistenceMethods do
       expect_any_instance_of(dummy_class).to receive(:handle_response).with response
       dummy_class.destroy('15')
     end
+
+    context 'request' do
+      let(:response) { { status: 200, body: '' } }
+      before { allow_any_instance_of(RemoteResource::Request).to receive(:perform).and_call_original }
+
+      it 'generates correct request url' do
+        stub_request(:delete, 'https://foobar.com/persistence_methods_dummy/15.json').with(body: nil).to_return(response)
+        dummy_class.destroy('15')
+      end
+
+      it 'includes params' do
+        stub_request(:delete, 'https://foobar.com/persistence_methods_dummy/15.json?pseudonym=3s8e3j').with(body: nil).to_return(response)
+        dummy_class.destroy('15', params: { pseudonym: '3s8e3j' })
+      end
+    end
   end
 
   describe '#update_attributes' do
@@ -208,7 +223,7 @@ describe RemoteResource::Querying::PersistenceMethods do
     end
 
     it 'performs a RemoteResource::Request with rest_action :delete' do
-      expect(RemoteResource::Request).to receive(:new).with(dummy, :delete, { id: dummy.id }, {}).and_call_original
+      expect(RemoteResource::Request).to receive(:new).with(dummy, :delete, { id: dummy.id }, { no_attributes: true }).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy.destroy
     end
@@ -218,6 +233,21 @@ describe RemoteResource::Querying::PersistenceMethods do
       dummy.destroy
     end
 
+    context 'request' do
+      let(:response) { { status: 200, body: '' } }
+      before { allow_any_instance_of(RemoteResource::Request).to receive(:perform).and_call_original }
+
+      it 'generates correct request url' do
+        stub_request(:delete, 'https://foobar.com/persistence_methods_dummy/18.json').with(body: nil).to_return(response)
+        dummy.destroy
+      end
+
+      it 'includes params' do
+        stub_request(:delete, 'https://foobar.com/persistence_methods_dummy/18.json?pseudonym=3s8e3j').with(body: nil).to_return(response)
+        dummy.destroy(params: { pseudonym: '3s8e3j' })
+      end
+    end
+
     context 'when the destroy was successful' do
       it 'returns the resource' do
         allow(dummy).to receive(:success?) { true }

data/spec/lib/remote_resource/request_spec.rb

@@ -275,7 +275,7 @@ describe RemoteResource::Request do
       let(:rest_action) { 'delete' }
 
       it 'makes a DELETE request with the attributes as body' do
-        expect(connection).to receive(:delete).with(determined_request_url, body: determined_attributes, headers: determined_headers).and_call_original
+        expect(connection).to receive(:delete).with(determined_request_url, params: determined_params, headers: determined_headers).and_call_original
         request.perform
       end
 

data/spec/lib/remote_resource/version_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe RemoteResource::VERSION do
 
-  it { should eql '0.4.9' }
+  it { should eql '0.4.10' }
 end
 
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 0.4.9
+  version: 0.4.10
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-25 00:00:00.000000000 Z
+date: 2016-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler