ddy_remote_resource 0.4.11 → 1.0.0.rc1

data/spec/lib/remote_resource/response_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe RemoteResource::Response do
+RSpec.describe RemoteResource::Response do
 
   describe '#original_response' do
     it 'is private' do
@@ -15,7 +15,7 @@ describe RemoteResource::Response do
   end
 
   describe 'Typhoeus::Response' do
-    let(:typhoeus_options)  { { body: 'typhoeus_response_body', code: 200 } }
+    let(:typhoeus_options)  { { body: 'typhoeus_response_body', code: 200, headers: { 'Content-Type' => 'application/json', 'Server' => 'nginx/1.4.6 (Ubuntu)' } } }
     let(:typhoeus_response) { Typhoeus::Response.new typhoeus_options }
     let(:response)          { described_class.new typhoeus_response }
 
@@ -37,6 +37,12 @@ describe RemoteResource::Response do
         expect(response.response_code).to eql 200
       end
     end
+
+    describe '#response_headers' do
+      it 'returns the response headers of the original response' do
+        expect(response.response_headers).to eql({ 'Content-Type' => 'application/json', 'Server' => 'nginx/1.4.6 (Ubuntu)' })
+      end
+    end
   end
 
   describe '#unprocessable_entity?' do
@@ -246,4 +252,4 @@ describe RemoteResource::Response do
     end
   end
 
-end
+end

data/spec/lib/remote_resource/rest_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe RemoteResource::REST do
+RSpec.describe RemoteResource::REST do
 
   module RemoteResource
     class RESTDummy
@@ -32,7 +32,7 @@ describe RemoteResource::REST do
   before { allow_any_instance_of(RemoteResource::Request).to receive(:perform) { response } }
 
   describe '.get' do
-    it 'performs a RemoteResource::Request with the rest_action :get' do
+    it 'performs a RemoteResource::Request with the http_action :get' do
       expect(RemoteResource::Request).to receive(:new).with(dummy_class, :get, params, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy_class.get params, connection_options
@@ -40,7 +40,7 @@ describe RemoteResource::REST do
   end
 
   describe '.put' do
-    it 'performs a RemoteResource::Request with the rest_action :put' do
+    it 'performs a RemoteResource::Request with the http_action :put' do
       expect(RemoteResource::Request).to receive(:new).with(dummy_class, :put, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy_class.put attributes, connection_options
@@ -48,7 +48,7 @@ describe RemoteResource::REST do
   end
 
   describe '.patch' do
-    it 'performs a RemoteResource::Request with the rest_action :patch' do
+    it 'performs a RemoteResource::Request with the http_action :patch' do
       expect(RemoteResource::Request).to receive(:new).with(dummy_class, :patch, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy_class.patch attributes, connection_options
@@ -56,7 +56,7 @@ describe RemoteResource::REST do
   end
 
   describe '.post' do
-    it 'performs a RemoteResource::Request with the rest_action :post' do
+    it 'performs a RemoteResource::Request with the http_action :post' do
       expect(RemoteResource::Request).to receive(:new).with(dummy_class, :post, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy_class.post attributes, connection_options
@@ -64,7 +64,7 @@ describe RemoteResource::REST do
   end
 
   describe '.delete' do
-    it 'performs a RemoteResource::Request with the rest_action :delete' do
+    it 'performs a RemoteResource::Request with the http_action :delete' do
       expect(RemoteResource::Request).to receive(:new).with(dummy_class, :delete, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy_class.delete(attributes, connection_options)
@@ -72,7 +72,7 @@ describe RemoteResource::REST do
   end
 
   describe '#get' do
-    it 'performs a RemoteResource::Request with the rest_action :get' do
+    it 'performs a RemoteResource::Request with the http_action :get' do
       expect(RemoteResource::Request).to receive(:new).with(dummy, :get, params, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy.get params, connection_options
@@ -80,7 +80,7 @@ describe RemoteResource::REST do
   end
 
   describe '#put' do
-    it 'performs a RemoteResource::Request with the rest_action :put' do
+    it 'performs a RemoteResource::Request with the http_action :put' do
       expect(RemoteResource::Request).to receive(:new).with(dummy, :put, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy.put attributes, connection_options
@@ -88,7 +88,7 @@ describe RemoteResource::REST do
   end
 
   describe '#patch' do
-    it 'performs a RemoteResource::Request with the rest_action :patch' do
+    it 'performs a RemoteResource::Request with the http_action :patch' do
       expect(RemoteResource::Request).to receive(:new).with(dummy, :patch, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy.patch attributes, connection_options
@@ -96,7 +96,7 @@ describe RemoteResource::REST do
   end
 
   describe '#post' do
-    it 'performs a RemoteResource::Request with the rest_action :post' do
+    it 'performs a RemoteResource::Request with the http_action :post' do
       expect(RemoteResource::Request).to receive(:new).with(dummy, :post, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy.post attributes, connection_options
@@ -104,7 +104,7 @@ describe RemoteResource::REST do
   end
 
   describe '#delete' do
-    it 'performs a RemoteResource::Request with the rest_action :delete' do
+    it 'performs a RemoteResource::Request with the http_action :delete' do
       expect(RemoteResource::Request).to receive(:new).with(dummy, :delete, attributes, connection_options).and_call_original
       expect_any_instance_of(RemoteResource::Request).to receive(:perform)
       dummy.delete(attributes, connection_options)

data/spec/lib/remote_resource/url_naming_determination_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe RemoteResource::UrlNamingDetermination do
+RSpec.describe RemoteResource::UrlNamingDetermination do
 
   module RemoteResource
     class UrlNamingDeterminationDummy

data/spec/lib/remote_resource/url_naming_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe RemoteResource::UrlNaming do
+RSpec.describe RemoteResource::UrlNaming do
 
   module RemoteResource
     class UrlNamingDummy
@@ -35,32 +35,17 @@ describe RemoteResource::UrlNaming do
   end
 
   describe '.app_host' do
-    context 'when the env is given as an argument' do
-      it 'uses the host specified in the CONFIG constant for the given env' do
-        stub_const("CONFIG", { test: { apps: { dummy: 'https://foobar.test.com' } } })
-
-        expect(dummy_class.app_host 'dummy', 'test').to eql 'https://foobar.test.com'
-      end
-    end
-
-    context 'when the env is NOT given as an argument' do
-      it 'uses the host specified in the CONFIG constant for the development env' do
-        stub_const("CONFIG", { development: { apps: { dummy: 'https://foobar.development.com' } } })
-
-        expect(dummy_class.app_host 'dummy').to eql 'https://foobar.development.com'
-      end
+    it 'warns that the method is deprecated' do
+      expect(dummy_class).to receive(:warn).with('[DEPRECATION] `.app_host` is deprecated. Please use a different method to determine the site.')
+      dummy_class.app_host('dummy', 'test')
     end
   end
 
   describe '.base_url' do
-    it 'uses the RemoteResource::UrlNamingDetermination class to determine the base_url' do
-      expect(RemoteResource::UrlNamingDetermination).to receive(:new).with(dummy_class).and_call_original
+    it 'warns that the method is deprecated' do
+      expect(dummy_class).to receive(:warn).with('[DEPRECATION] `.base_url` is deprecated. Please use the connection_options[:base_url] when querying instead.')
       dummy_class.base_url
     end
-
-    it 'returns the determined base_url' do
-      expect(dummy_class.base_url).to eql 'https://foobar.com/url_naming_dummy'
-    end
   end
 
   describe '.use_relative_model_naming?' do
@@ -69,4 +54,4 @@ describe RemoteResource::UrlNaming do
     end
   end
 
-end
+end

data/spec/lib/remote_resource/util_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+RSpec.describe RemoteResource::Util do
+
+  describe '.filter_params' do
+    let(:scenarios) do
+      [
+        { params: '{"account_migration":{"username":"foo","password":"bar"}}', expected_params: '{"account_migration":{"username":"foo","password":[FILTERED]}}' },
+        { params: '{"account_migration":{"password":"bar","username":"foo"}}', expected_params: '{"account_migration":{"password":[FILTERED],"username":"foo"}}' },
+        { params: '?username=foo&password=bar', expected_params: '?username=foo&password=[FILTERED]' },
+        { params: '?password=bar&username=foo', expected_params: '?password=[FILTERED]&username=foo' },
+        { params: nil, expected_params: '' }
+      ]
+    end
+
+    it 'removes sensitive information of the filtered params' do
+      aggregate_failures do
+        scenarios.each do |scenario|
+          result = described_class.filter_params(scenario[:params], filtered_params: ['password'])
+
+          expect(result).to eql scenario[:expected_params]
+        end
+      end
+    end
+  end
+
+  describe '.encode_params_to_query' do
+    let(:scenarios) do
+      [
+        { params: nil, expected_query: '' },
+        { params: {}, expected_query: '' },
+        { params: [], expected_query: '' },
+        { params: 'Mies', expected_query: 'Mies' },
+        { params: { name: 'Mies' }, expected_query: 'name=Mies' },
+        { params: { name: 'Mies', age: 29, famous: true, smart: nil }, expected_query: 'name=Mies&age=29&famous=true&smart=' },
+        { params: { page: 5, limit: 15 }, expected_query: 'page=5&limit=15' },
+        { params: { labels: [1, '2', 'three'] }, expected_query: 'labels[]=1&labels[]=2&labels[]=three' },
+        { params: { page: 5, limit: 15, order: [:created_at, :desc] }, expected_query: 'page=5&limit=15&order[]=created_at&order[]=desc' },
+        { params: { page: 5, limit: 15, order: { field: :created_at, direction: :desc } }, expected_query: 'page=5&limit=15&order[field]=created_at&order[direction]=desc' },
+        { params: { name: 'Mies', age: 29, famous: true, labels: [1, '2', 'three'], pagination: { page: 5, limit: 15, order: { field: :created_at, direction: :desc } } }, expected_query: 'name=Mies&age=29&famous=true&labels[]=1&labels[]=2&labels[]=three&pagination[page]=5&pagination[limit]=15&pagination[order][field]=created_at&pagination[order][direction]=desc' },
+      ]
+    end
+
+    it 'encodes the params to a URL-encoded query' do
+      aggregate_failures do
+        scenarios.each do |scenario|
+          result = described_class.encode_params_to_query(scenario[:params])
+          query  = CGI.unescape(result)
+
+          expect(query).to eql scenario[:expected_query]
+        end
+      end
+    end
+  end
+
+end

data/spec/lib/remote_resource/version_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe RemoteResource::VERSION do
-
-  it { should eql '0.4.11' }
+RSpec.describe RemoteResource::VERSION do
+  it { is_expected.to eql '1.0.0.rc1' }
 end
 
 

data/spec/spec_helper.rb

@@ -3,3 +3,40 @@ require 'remote_resource'
 
 require 'webmock/rspec'
 require 'pry'
+
+RSpec.configure do |config|
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # Limits the available syntax to the non-monkey patched syntax that is recommended.
+  # For more details, see:
+  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  config.disable_monkey_patching!
+
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddy_remote_resource
 version: !ruby/object:Gem::Version
-  version: 0.4.11
+  version: 1.0.0.rc1
 platform: ruby
 authors:
 - Jan van der Pas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-06 00:00:00.000000000 Z
+date: 2016-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,20 +66,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.24'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.24'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -249,17 +235,28 @@ files:
 - lib/remote_resource/collection.rb
 - lib/remote_resource/connection.rb
 - lib/remote_resource/connection_options.rb
-- lib/remote_resource/http_errors.rb
 - lib/remote_resource/querying/finder_methods.rb
 - lib/remote_resource/querying/persistence_methods.rb
 - lib/remote_resource/request.rb
 - lib/remote_resource/response.rb
-- lib/remote_resource/response_handeling.rb
 - lib/remote_resource/rest.rb
 - lib/remote_resource/url_naming.rb
 - lib/remote_resource/url_naming_determination.rb
+- lib/remote_resource/util.rb
 - lib/remote_resource/version.rb
 - remote_resource.gemspec
+- spec/fixtures/text_file.txt
+- spec/integration/all_spec.rb
+- spec/integration/collection_prefix_spec.rb
+- spec/integration/create_spec.rb
+- spec/integration/destroy_spec.rb
+- spec/integration/find_by_spec.rb
+- spec/integration/find_spec.rb
+- spec/integration/headers_spec.rb
+- spec/integration/naming_spec.rb
+- spec/integration/save_spec.rb
+- spec/integration/update_attributes_spec.rb
+- spec/integration/where_spec.rb
 - spec/lib/extensions/ethon/easy/queryable_spec.rb
 - spec/lib/remote_resource/base_spec.rb
 - spec/lib/remote_resource/builder_spec.rb
@@ -273,6 +270,7 @@ files:
 - spec/lib/remote_resource/rest_spec.rb
 - spec/lib/remote_resource/url_naming_determination_spec.rb
 - spec/lib/remote_resource/url_naming_spec.rb
+- spec/lib/remote_resource/util_spec.rb
 - spec/lib/remote_resource/version_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -290,9 +288,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.1
@@ -300,6 +298,18 @@ signing_key:
 specification_version: 4
 summary: RemoteResource, a gem to use resources with REST services.
 test_files:
+- spec/fixtures/text_file.txt
+- spec/integration/all_spec.rb
+- spec/integration/collection_prefix_spec.rb
+- spec/integration/create_spec.rb
+- spec/integration/destroy_spec.rb
+- spec/integration/find_by_spec.rb
+- spec/integration/find_spec.rb
+- spec/integration/headers_spec.rb
+- spec/integration/naming_spec.rb
+- spec/integration/save_spec.rb
+- spec/integration/update_attributes_spec.rb
+- spec/integration/where_spec.rb
 - spec/lib/extensions/ethon/easy/queryable_spec.rb
 - spec/lib/remote_resource/base_spec.rb
 - spec/lib/remote_resource/builder_spec.rb
@@ -313,5 +323,6 @@ test_files:
 - spec/lib/remote_resource/rest_spec.rb
 - spec/lib/remote_resource/url_naming_determination_spec.rb
 - spec/lib/remote_resource/url_naming_spec.rb
+- spec/lib/remote_resource/util_spec.rb
 - spec/lib/remote_resource/version_spec.rb
 - spec/spec_helper.rb

data/lib/remote_resource/http_errors.rb

@@ -1,33 +0,0 @@
-module RemoteResource
-  module HTTPErrors
-
-    private
-
-    def raise_http_errors(response)
-      case response.response_code
-      when 301, 302, 303, 307 then raise RemoteResource::HTTPRedirectionError, response
-      when 400 then raise RemoteResource::HTTPBadRequest, response
-      when 401 then raise RemoteResource::HTTPUnauthorized, response
-      when 403 then raise RemoteResource::HTTPForbidden, response
-      when 404 then raise RemoteResource::HTTPNotFound, response
-      when 405 then raise RemoteResource::HTTPMethodNotAllowed, response
-      when 406 then raise RemoteResource::HTTPNotAcceptable, response
-      when 408 then raise RemoteResource::HTTPRequestTimeout, response
-      when 409 then raise RemoteResource::HTTPConflict, response
-      when 410 then raise RemoteResource::HTTPGone, response
-      when 418 then raise RemoteResource::HTTPTeapot, response
-      when 444 then raise RemoteResource::HTTPNoResponse, response
-      when 494 then raise RemoteResource::HTTPRequestHeaderTooLarge, response
-      when 495 then raise RemoteResource::HTTPCertError, response
-      when 496 then raise RemoteResource::HTTPNoCert, response
-      when 497 then raise RemoteResource::HTTPToHTTPS, response
-      when 499 then raise RemoteResource::HTTPClientClosedRequest, response
-      when 400..499 then raise RemoteResource::HTTPClientError, response
-      when 500..599 then raise RemoteResource::HTTPServerError, response
-      else
-        raise RemoteResource::HTTPError, response
-      end
-    end
-
-  end
-end